Hi David, thanks for fixing this issue.
Just one comment: > +[DIAGNOSTICS_URLS_DEFAULT=DIAGNOSTICS_URL_AUTO]) > +AC_DEFINE_UNQUOTED(DIAGNOSTICS_URLS_DEFAULT, $DIAGNOSTICS_URLS_DEFAULT, > + [The default for -fdiagnostics-urls option]) I think for a feature as disruptive as this, when a terminal implements that it ought to advertise this feature via an environment variable. So I would prefer the default to be auto-if-env. Ideally there should be some neutral variable similar to TERM, maybe TERM_URL=yes if that convention does not exist yet, maybe we should invent it? Thanks Bernd.
