Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-29 Thread Jakub Jelinek
On Mon, Oct 28, 2024 at 03:12:03PM -0400, James K. Lowden wrote: > Jakub Jelinek said: > > > > We'll mainly have to remember when pushing any of the series. > > > > The m2 dances were git_commit.py tweaks: > > https://gcc.gnu.org/r13-4588 > > followed by asking one of us gccadmins on IRC to inst

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-29 Thread James K. Lowden
On Tue, 29 Oct 2024 11:56:18 +0100 Richard Biener wrote: > gcc/ should be stripped from * gcc/common.opt, so just * common.opt ... > Likewise for gcc/cobol. I see. The names in these cases are relative to gcc, not to the whole project. The runtime library, libgcobol, like the other libraries, i

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-29 Thread Jakub Jelinek
On Tue, Oct 29, 2024 at 11:56:18AM +0100, Richard Biener wrote: > It's probably best to have a first commit just generate the directories with > the > empty ChangeLog and amend the contrib/gcc-changelog/git_commit.py > scipts default_changelog_locations. > > I'm not sure about the exact order of

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-29 Thread Richard Biener
On Sat, Oct 26, 2024 at 10:37 PM James K. Lowden wrote: > > On Sat, 26 Oct 2024 11:22:20 +0800 > Xi Ruoyao wrote: > > > The changelog is not formatted correctly. gcc/ has its own > > changelog. And gcc/cobol should have its own changelog too, like all > > other frontends. > > Thank you for point

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-26 Thread James K. Lowden
On Sat, 26 Oct 2024 11:22:20 +0800 Xi Ruoyao wrote: > The changelog is not formatted correctly. gcc/ has its own > changelog. And gcc/cobol should have its own changelog too, like all > other frontends. Thank you for pointing that out. I now have [snip] Subject: [PATCH] Add 'cobol' to 10 fil

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-25 Thread Xi Ruoyao
On Sun, 2024-10-13 at 20:44 -0400, James K. Lowden wrote: /* snip */ > In testing the patch with "git am" Please also use "git gcc-verify". See below for the incorrect changelog which would be caught by the command. > I got a warning about a blank line > at EOF, but I couldn't figure out where

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-25 Thread James K. Lowden
On Thu, 24 Oct 2024 12:01:10 -0400 "James K. Lowden" wrote: > They are not. With --enable-generated-files-in-srcdir, the build > fails. What do I need to do to fix it? I haven't the faintest idea. I believe I found it: diff --git a/gcc/cobol/Make-lang.in b/gcc/cobol/Make-lang.in index 6a57

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-25 Thread James K. Lowden
On Wed, 23 Oct 2024 15:12:19 +0200 Richard Biener wrote: > Note there's --enable-generated-files-in-srcdir specifically to remove > yacc and flex - can you check whether with this configure flag those > files are generated in the source directory and thus picked up when > building the release tar

Re: [PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-23 Thread Richard Biener
On Tue, Oct 15, 2024 at 1:10 AM James K. Lowden wrote: > > Consequent to advice, I'm preparing the Cobol front-end patches as a > small number of hopefully meaningful patches covering many files. > > 1. meta files used by autotools etc. > 2. gcc/cobol/*.h > 3. gcc/cobol/*.{y,l,cc} > 4. libgcob

[PATCH] Add 'cobol' to Makefile.def, take 2

2024-10-14 Thread James K. Lowden
Consequent to advice, I'm preparing the Cobol front-end patches as a small number of hopefully meaningful patches covering many files. 1. meta files used by autotools etc. 2. gcc/cobol/*.h 3. gcc/cobol/*.{y,l,cc} 4. libgcobol 5. documentation 6. tests The patch below is step #1. It compr