On Sat, Oct 26, 2024 at 10:37 PM James K. Lowden <jklow...@schemamania.org> wrote: > > On Sat, 26 Oct 2024 11:22:20 +0800 > Xi Ruoyao <xry...@xry111.site> wrote: > > > The changelog is not formatted correctly. gcc/ has its own > > changelog. And gcc/cobol should have its own changelog too, like all > > other frontends. > > Thank you for pointing that out. I now have > > [snip] > Subject: [PATCH] Add 'cobol' to 10 files > > ChangeLog > * Makefile.def: Add libgcobol module and cobol language. > * configure: Regenerated > * configure.ac: Add libgcobol module and cobol language. > > gcc/ChangeLog > * gcc/common.opt: Add libgcobol module and cobol language.
gcc/ should be stripped from * gcc/common.opt, so just * common.opt > > gcc/cobol/ChangeLog > * gcc/cobol/ChangeLog: Add gcc/cobol/ChangeLog > * gcc/cobol/LICENSE: Add gcc/cobol/LICENSE > * gcc/cobol/Make-lang.in: Add gcc/cobol/Make-lang.in > * gcc/cobol/config-lang.in: Add gcc/cobol/config-lang.in > * gcc/cobol/lang.opt: Add gcc/cobol/lang.opt > * gcc/cobol/lang.opt.urls: Add gcc/cobol/lang.opt.urls Likewise for gcc/cobol. It's probably best to have a first commit just generate the directories with the empty ChangeLog and amend the contrib/gcc-changelog/git_commit.py scipts default_changelog_locations. I'm not sure about the exact order of the dance, Jakub possibly remembers. We'll mainly have to remember when pushing any of the series. Richard. > [pins] > > > Please also use "git gcc-verify". > > Where is this documented? I found > > https://gcc.gnu.org/pipermail/gcc-cvs/2020-May/288244.html > > and > > contrib/gcc-git-customization.sh > > There's quite a bit of stuff in there. I genenerally don't use anyone else's > handy-dandy configuration, especially for git, which is baroque enough as it > is. But I can run one command, > > $ grep gcc-verify gcc-git-customization.sh > git config alias.gcc-verify '!f() { "`git rev-parse > --show-toplevel`/contrib/gcc-changelog/git_check_commit.py" $@; } ; f' > > if that's what we need. Probably helpful (I'm also cherry-picking from the git customization). Richard. > > --jkl
