Re: [PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-02-20 Thread Marcus Shawcroft
On 11 February 2015 at 10:57, Alan Lawrence wrote: > gcc/ChangeLog: > > PR target/64997 > * config/aarch64/aarch64.md (*xor_one_cmpl3): Use FP_REGNUM_P > as split condition; force split via '#' in output pattern. OK /Marcus

Re: [PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-02-17 Thread James Greenhalgh
On Wed, Feb 11, 2015 at 10:57:03AM +, Alan Lawrence wrote: > gcc/ChangeLog: > > PR target/64997 > * config/aarch64/aarch64.md (*xor_one_cmpl3): Use FP_REGNUM_P > as split condition; force split via '#' in output pattern. I'd be happier with the testcase added, but I appreci

Re: [PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-02-11 Thread Alan Lawrence
Here is a revised patch using '#'. Bootstrap + check-gcc natively on aarch64-none-linux-gnu. My feeling is still against including the testcase because even when it passes it doesn't increase my confidence that the compiler is right very much (i.e. the insn could still be reading which_alterna

Re: [PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-02-10 Thread James Greenhalgh
On Wed, Jan 28, 2015 at 02:04:04PM +, James Greenhalgh wrote: > On Wed, Jan 28, 2015 at 12:32:45PM +, Alan Lawrence wrote: > > Ok for stage 4? > > This is a regression from 4.9, so once we iron out some nits, it should > be. > > > gcc/ChangeLog: > > > > * config/aarch64/aarch64.md (*

Re: [PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-01-28 Thread James Greenhalgh
On Wed, Jan 28, 2015 at 12:32:45PM +, Alan Lawrence wrote: > Ok for stage 4? This is a regression from 4.9, so once we iron out some nits, it should be. > gcc/ChangeLog: > > * config/aarch64/aarch64.md (*xor_one_cmpl3): Use FP_REGNUM_P > as split condition. And a testcase, pleas

[PATCH][AArch64] Fix illegal assembly 'eon v1, v2, v3'

2015-01-28 Thread Alan Lawrence
Hi, The split rule introduced in r218961 uses as its split condition 'reload_completed && (which_alternative == 1)', but which_alternative does not seem to be set reliably during split phases, even after reload. This can lead to the split rule not being used even for insns using FP/SIMD regist