Re: [PATCH:RL78] Add new insn for mulqi3 and mulhi3

2013-05-30 Thread Richard Henderson
8] Add new insn for mulqi3 and mulhi3 Hi Richard, Thanks for the quick review. No constraints on define_expand, only predicates. +(define_insn "mulhi3_g13" These names are not used. They should be prefixed with "*" to indicate the name is just for documentation. I have made

RE: [PATCH:RL78] Add new insn for mulqi3 and mulhi3

2013-05-30 Thread Kaushik Phatak
Ping. Can I commit this with below changes? Thanks, Kaushik -Original Message- From: Kaushik Phatak Sent: 20 May 2013 20:17 To: gcc-patches@gcc.gnu.org Cc: 'Richard Henderson'; DJ Delorie (d...@redhat.com) Subject: RE: [PATCH:RL78] Add new insn for mulqi3 and mulhi3 Hi Richa

RE: [PATCH:RL78] Add new insn for mulqi3 and mulhi3

2013-05-20 Thread Kaushik Phatak
Hi Richard, Thanks for the quick review. > No constraints on define_expand, only predicates. >> +(define_insn "mulhi3_g13" >These names are not used. They should be prefixed with "*" to indicate the >name is just for documentation. I have made the suggested changes. Please find below an updated

Re: [PATCH:RL78] Add new insn for mulqi3 and mulhi3

2013-05-17 Thread Richard Henderson
On 05/14/2013 09:43 PM, Kaushik Phatak wrote: > Hi, > The below patch adds expanders and insns for QI and HI mode for the RL78 > target. > The QI mode uses a generic 'mulu' instruction supported by all variants, while > the HI mode creates insn for G13 and G14 target variants using hardware > mul

[PATCH:RL78] Add new insn for mulqi3 and mulhi3

2013-05-14 Thread Kaushik Phatak
Hi, The below patch adds expanders and insns for QI and HI mode for the RL78 target. The QI mode uses a generic 'mulu' instruction supported by all variants, while the HI mode creates insn for G13 and G14 target variants using hardware multiply instructions. Tested on hardware and simulator with no