Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845

2017-08-14 Thread Segher Boessenkool
On Mon, Aug 14, 2017 at 09:21:51AM -0500, Bill Schmidt wrote: > > On Aug 13, 2017, at 3:41 PM, Martin Sebor wrote: > >> --- gcc/config/rs6000/rs6000-c.c (revision 250965) > >> +++ gcc/config/rs6000/rs6000-c.c (working copy) > >> @@ -5812,7 +5812,7 @@ altivec_resolve_overloaded_builtin (locatio

Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845

2017-08-14 Thread Bill Schmidt
> On Aug 13, 2017, at 3:41 PM, Martin Sebor wrote: > >> --- gcc/config/rs6000/rs6000-c.c (revision 250965) >> +++ gcc/config/rs6000/rs6000-c.c (working copy) >> @@ -5812,7 +5812,7 @@ altivec_resolve_overloaded_builtin (location_t loc >> types. */ >> if (nargs != 2) >> {

Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845

2017-08-13 Thread Martin Sebor
--- gcc/config/rs6000/rs6000-c.c(revision 250965) +++ gcc/config/rs6000/rs6000-c.c(working copy) @@ -5812,7 +5812,7 @@ altivec_resolve_overloaded_builtin (location_t loc types. */ if (nargs != 2) { - error ("vec_mul only accepts 2 arguments"); +

Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845

2017-08-11 Thread Segher Boessenkool
On Fri, Aug 11, 2017 at 02:21:17PM -0500, Bill Schmidt wrote: > >> if (nargs == 0) > >>{ > >> -error ("%s only accepts %d arguments", name, (fcode == > >> ALTIVEC_BUILTIN_VEC_PROMOTE)+1 ); > >> +error ("builtin %qs only accepts %d arguments", name, > >> + (fcode == ALTI

Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845

2017-08-11 Thread Bill Schmidt
Hi Segher, Thanks for the review! > On Aug 11, 2017, at 2:14 PM, Segher Boessenkool > wrote: > > Hi Bill, > > On Thu, Aug 10, 2017 at 04:28:49PM -0500, Bill Schmidt wrote: >> This continues the cleanup of diagnostic messages in the rs6000 back end. >> The >> primary focus is to make sure th

Re: [PATCH, rs6000] More diagnostic cleanup, addressing PR79845

2017-08-11 Thread Segher Boessenkool
Hi Bill, On Thu, Aug 10, 2017 at 04:28:49PM -0500, Bill Schmidt wrote: > This continues the cleanup of diagnostic messages in the rs6000 back end. The > primary focus is to make sure that we use quoted strings with %qs, %<, %> as > appropriate, and that option strings are separated from translata

[PATCH, rs6000] More diagnostic cleanup, addressing PR79845

2017-08-10 Thread Bill Schmidt
Hi, This continues the cleanup of diagnostic messages in the rs6000 back end. The primary focus is to make sure that we use quoted strings with %qs, %<, %> as appropriate, and that option strings are separated from translatable strings to make things easier on the internationalization folks, as r