[PATCHv8] c++:Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic[PR96752]

2020-06-23 Thread Nicholas Krause via Gcc-patches
From: Nicholas Krause This fixes the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. In v2, add the missing required test case for all new patches. v3 Fixes both the test case

[PATCHv7] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-23 Thread Nicholas Krause via Gcc-patches
From: Nicholas Krause This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. In v2, add the missing required test case for all new patches. v3 Fixes both the test case

Re: [PATCHv6] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-22 Thread Nicholas Krause via Gcc-patches
On 6/22/20 10:01 PM, Marek Polacek wrote: On Mon, Jun 22, 2020 at 09:42:51PM -0400, Nicholas Krause via Gcc-patches wrote: From: Nicholas Krause This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing

[PATCHv6] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-22 Thread Nicholas Krause via Gcc-patches
From: Nicholas Krause This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. In v2, add the missing required test case for all new patches. v3 Fixes both the test case

Re: [PATCHv5] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-22 Thread Nicholas Krause via Gcc-patches
On 6/22/20 7:47 PM, Marek Polacek wrote: On Mon, Jun 22, 2020 at 06:55:01PM -0400, Nicholas Krause via Gcc-patches wrote: On 6/22/20 5:51 PM, Jason Merrill wrote: On 6/22/20 4:01 PM, Nicholas Krause wrote: From: Nicholas Krause This fixs the PR95672 by adding the missing

Re: [PATCHv5] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-22 Thread Nicholas Krause via Gcc-patches
On 6/22/20 5:51 PM, Jason Merrill wrote: On 6/22/20 4:01 PM, Nicholas Krause wrote: From: Nicholas Krause This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. In

[PATCHv5] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-22 Thread Nicholas Krause via Gcc-patches
From: Nicholas Krause This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. In v2, add the missing required test case for all new patches. v3 Fixes both the test case

[PATCHv4] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-21 Thread Nicholas Krause via Gcc-patches
From: Nicholas Krause This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. In v2, add the missing required test case for all new patches. v3 Fixes both the test case

[PATCHv3] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-20 Thread Nicholas Krause via Gcc-patches
From: Nicholas Krause This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. In v2, add the missing required test case for all new patches. v3 Fixes both the test case

[PATCH] Handle TYPE_PACK_EXPANSION in cxx_incomplete_type_diagnostic

2020-06-19 Thread Nicholas Krause via Gcc-patches
This fixs the PR95672 by adding the missing TYPE_PACK_EXPANSION case in cxx_incomplete_type_diagnostic in order to avoid ICES on diagnosing incomplete template pack expansion cases. Signed-off-by: Nicholas Krause Changelog: *cp/type2ck.c: Add missing case TYPE_PACK_EXPANSION for diagnosticing

Re: [PATCH RFC] Propose Updating Basic Block Checking Limits in variable_tracking_main_1

2020-06-18 Thread Nicholas Krause via Gcc-patches
On 6/18/20 2:32 PM, Nicholas Krause wrote: From: Nicholas Krause Changelog:gcc/ *var-tracking.c(variable_tracking_main): Update numbers for both number of basic blocks per function and number of edges per function to basic blocks to more sane numbers, in

[PATCH RFC] Propose Updating Basic Block Checking Limits in variable_tracking_main_1

2020-06-18 Thread Nicholas Krause via Gcc-patches
From: Nicholas Krause Changelog:gcc/ *var-tracking.c(variable_tracking_main): Update numbers for both number of basic blocks per function and number of edges per function to basic blocks to more sane numbers, in order to avoid extra edge cases. Signed

Re: [PATCH] vectorizer: add _bb_vec_info::const_iterator

2020-06-12 Thread Nicholas Krause via Gcc-patches
On 6/12/20 11:49 AM, Richard Sandiford wrote: Martin Liška writes: On 6/12/20 3:22 PM, Richard Sandiford wrote: Martin Liška writes: diff --git a/gcc/tree-vect-patterns.c b/gcc/tree-vect-patterns.c index 636ad59c001..eac372e6abc 100644 --- a/gcc/tree-vect-patterns.c +++ b/gcc/tree-vect-pa

Re: [PATCH] Describe coding conventions surrounding "auto"

2020-05-19 Thread Nicholas Krause via Gcc-patches
On 5/18/20 6:51 PM, Martin Sebor via Gcc-patches wrote: On 5/18/20 12:02 PM, Richard Sandiford wrote: Martin Sebor writes: On 5/16/20 4:43 AM, Richard Sandiford wrote: Sorry for the empty subject line earlier... Jason Merrill writes: On Fri, May 15, 2020 at 9:47 PM Martin Sebor wrote:

Re: [PATCH] rs6000: Save/restore r31 if frame_pointer_needed is true

2020-03-29 Thread Nicholas Krause via Gcc-patches
On 3/30/20 12:18 AM, luoxhu via Gcc-patches wrote: On 2020/3/28 00:04, Segher Boessenkool wrote: Hi! On Fri, Mar 27, 2020 at 09:34:00AM +0800, luoxhu wrote: On 2020/3/27 07:59, Segher Boessenkool wrote: On Wed, Mar 25, 2020 at 11:15:22PM -0500, luo...@linux.ibm.com wrote: frame_pointer_n

Re: [PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-20 Thread Nicholas Krause
On 1/20/20 6:51 PM, Segher Boessenkool wrote: On Tue, Jan 21, 2020 at 12:23:02AM +0100, Jakub Jelinek wrote: On Mon, Jan 20, 2020 at 05:10:55PM -0600, Segher Boessenkool wrote: On Mon, Jan 20, 2020 at 11:52:55PM +0100, Jakub Jelinek wrote: PR target/93073 * config/rs6000/rs6

Re: Add a new combine pass

2019-11-23 Thread Nicholas Krause
On 11/23/19 6:09 PM, Segher Boessenkool wrote: On Sat, Nov 23, 2019 at 06:01:28PM -0500, Nicholas Krause wrote: Please just CC to this conversation as I keep getting removed. Everyone who was on Cc: for this thread still is. This is how email works. If you want to see everything on the

Re: Add a new combine pass

2019-11-23 Thread Nicholas Krause
On 11/23/19 5:34 PM, Segher Boessenkool wrote: Hi! On Mon, Nov 18, 2019 at 05:55:13PM +, Richard Sandiford wrote: Richard Sandiford writes: (It's 23:35 local time, so it's still just about stage 1. :-)) Or actually, just under 1 day after end of stage 1. Oops. Could have sworn stage

Re: Add a new combine pass

2019-11-21 Thread Nicholas Krause
On 11/17/19 6:35 PM, Richard Sandiford wrote: (It's 23:35 local time, so it's still just about stage 1. :-)) While working on SVE, I've noticed several cases in which we fail to combine instructions because the combined form would need to be placed earlier in the instruction stream than the l

Re: Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

2019-09-21 Thread Nicholas Krause
On 9/21/19 2:18 PM, Segher Boessenkool wrote: On Thu, Sep 19, 2019 at 03:29:27PM -0400, Jason Merrill wrote: I suppose we also need to decide what form we want to use for the equivalent of gcc.gnu.org/rN. I figure it needs to be some prefix followed by a "commit-ish" (hash, tag, etc.). P

[PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-04-08 Thread Nicholas Krause
, 88395 on the gcc bugzilla. OK for merge? Signed-off-by: Nicholas Krause --- gcc/cp/constraint.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc index 9884eb0db50..a78d0a9a49b 100644 --- a/gcc/cp/constraint.cc +++ b/gcc/cp/constraint.cc

[PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-04-08 Thread Nicholas Krause
, 88395 on the gcc bugzilla. Signed-off-by: Nicholas Krause --- gcc/cp/constraint.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc index 9884eb0db50..cb06d0ec6e2 100644 --- a/gcc/cp/constraint.cc +++ b/gcc/cp/constraint.cc

[PATCH] Remove unnecessary FIXME header comments in gimplify.c

2019-04-02 Thread Nicholas Krause
header files being included. Signed-off-by: Nicholas Krause --- gcc/gimplify.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/gimplify.c b/gcc/gimplify.c index 6ac1b718ebd..e51c9b7d493 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -31,7 +31,7 @@ along with GCC

[PATCH] Fix function, tsubst_requires_expr for callers to tsubst_constraint_variables

2019-03-30 Thread Nicholas Krause
in the future. Signed-off-by: Nicholas Krause --- gcc/cp/constraint.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/cp/constraint.cc b/gcc/cp/constraint.cc index 9884eb0db50..cb06d0ec6e2 100644 --- a/gcc/cp/constraint.cc +++ b/gcc/cp/constraint.cc @@ -1882,13

[PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-03-27 Thread Nicholas Krause
This fixes bug id,88395 by checking if the second tree reqs is correctly not a null pointer before calling the function, tsubst_requirement_body. Otherwise we will get a nullptr if compiling with -fconcepts for concepts enabled. Signed-off-by: Nicholas Krause --- gcc/cp/constraint.cc | 2 ++ 1

[PATCH] Proposed patch to fix bug id, 89796 on bugzilla

2019-03-24 Thread Nicholas Krause
Not sure if this is a correct fix to this bug found here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89796 but comments are welcome. If a backtrace is required please let me know. Signed-off-by: Nicholas Krause --- gcc/cp/constraint.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH] Use proper print formatter in main function in fixincl.c

2018-12-20 Thread Nicholas Krause
This fixes the bug id, 71176 to use the proper known code print formatter type, %lu for size_t rather than %d which is considered best pratice for print statements. Signed-off-by: Nicholas Krause --- fixincludes/fixincl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] Use proper print formatter in main function in fixincl.c

2018-12-19 Thread Nicholas Krause
This fixes the bug id, 71176 to use the proper known code print formatter type, %lu for size_t rather than %d which is considered best pratice for print statements. Signed-off-by: Nicholas Krause --- fixincludes/fixincl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH] Use proper print formatter in main function in fixincl.c

2018-12-19 Thread Nicholas Krause
This fixes the bug id, 71176 to use the proper known code print formatter type, %lu for size_t rather than %d which is considered best pratice for print statements. Signed-off-by: Nicholas Krause --- fixincludes/fixincl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] Add missing noexpect causes in tuple for move functions

2018-11-30 Thread Nicholas Krause
This adds the remainging noexcept causes required for this cause to meet the spec as dicussed last year and documented here: http://cplusplus.github.io/LWG/lwg-active.html#2899. Signed-off-by: Nicholas Krause --- libstdc++-v3/include/std/tuple | 4 1 file changed, 4 insertions(+) diff

[PATCH] Fix bug 86293

2018-10-29 Thread Nicholas Krause
: Nicholas Krause --- libitm/method-serial.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libitm/method-serial.cc b/libitm/method-serial.cc index e4804946a34..ab23d0b5660 100644 --- a/libitm/method-serial.cc +++ b/libitm/method-serial.cc @@ -306,7 +306,7 @@ GTM::gtm_thread

[PATCH]C++/PR80188: Add correct marco call to error_at call in maybe_complain_about_tail_call

2017-10-07 Thread Nicholas Krause
any new regressions. Ok for trunk? Signed-off-by: Nicholas Krause --- gcc/calls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/calls.c b/gcc/calls.c index 72cf9e016c8..38b4dc7617b 100644 --- a/gcc/calls.c +++ b/gcc/calls.c @@ -1515,7 +1515,7