Re: [RFC][PATCH] Adjust param_vect_max_version_for_alias_checks

2024-11-14 Thread Kugan Vivekanandarajah
Ping? Thanks, Kugan > On 2 Nov 2024, at 7:49 pm, Kugan Vivekanandarajah > wrote: > > External email: Use caution opening links or attachments > > > > On 31 Oct 2024, at 7:29 pm, Jakub Jelinek wrote: > > > > External email: Use caution opening links or a

Re: [RFC][PATCH] Adjust param_vect_max_version_for_alias_checks

2024-11-02 Thread Kugan Vivekanandarajah
> On 31 Oct 2024, at 7:29 pm, Jakub Jelinek wrote: > > External email: Use caution opening links or attachments > > > On Thu, Oct 31, 2024 at 08:21:09AM +, Kugan Vivekanandarajah wrote: >> >> >>> On 31 Oct 2024, at 6:18 pm, Jakub Jelinek wrote: >

[testsuite] Fix bb-slp-77.c for x86

2024-10-31 Thread Kugan Vivekanandarajah
This test bb-slp-77.c extracted relies on the completely unrolling of the inner loop. However, for x86 in gcc.dg/vect/, loop is not unrolled and the inner loop is vectorized thus not triggering expected BB SLP Also noticed that the "vectorizing stmts using SLP” count is different when I for

Re: [RFC][PATCH] Adjust param_vect_max_version_for_alias_checks

2024-10-31 Thread Kugan Vivekanandarajah
> On 31 Oct 2024, at 6:18 pm, Jakub Jelinek wrote: > > External email: Use caution opening links or attachments > > > On Tue, Oct 29, 2024 at 05:01:40AM +, Kugan Vivekanandarajah wrote: >> For param_vect_max_version_for_alias_checks of 15, the average code si

Re: [PATCH] Allow BB vectorisation of scalar loop when ifcvt versioned loop is not vectorized

2024-10-30 Thread Kugan Vivekanandarajah
Hi Richard, > On 29 Oct 2024, at 8:33 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Tue, Oct 29, 2024 at 9:24 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> Thanks for the review. >> &

Re: [PATCH] Allow BB vectorisation of scalar loop when ifcvt versioned loop is not vectorized

2024-10-29 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. > On 28 Oct 2024, at 9:18 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Mon, Oct 28, 2024 at 9:35 AM Kugan Vivekanandarajah > wrote: >> >> Hi, >> >> When ifcvt

Re: [RFC][PATCH] Adjust param_vect_max_version_for_alias_checks

2024-10-28 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. > On 25 Oct 2024, at 8:53 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Fri, Oct 25, 2024 at 12:22 AM Kugan Vivekanandarajah > wrote: >> &g

[PATCH] Allow BB vectorisation of scalar loop when ifcvt versioned loop is not vectorized

2024-10-28 Thread Kugan Vivekanandarajah
Hi, When ifcvt version a loop, it sets dont_vectorize to the scalar loop. If the vector loop is not vectorized and removed, the scalar loop is still left with dont_vectorize. As a result, BB vectorization will not happen. This patch adds a new attribute called dont_loop_vectorize (that is differe

[RFC][PATCH] Adjust param_vect_max_version_for_alias_checks

2024-10-24 Thread Kugan Vivekanandarajah
Hi, This patch sets param_vect_max_version_for_alias_checks to 15. This was causing GCC to miss vectorization opportunities in one internal application making it slower than LLVM by about ~14%. I've tested different param_vect_max_version_for_alias_checks such as 15 and 100 and the SPEC2017 resu

[PATCH][AARCH64][PR115258]Fix excess moves

2024-10-24 Thread Kugan Vivekanandarajah
Hi, Fix for PR115258 cases a performance regression in some of the TSVC kernels by adding additional mov instructions. This patch fixes this. i.e., When operands are equal, it is likely that all of them get the same register similar to: (insn 19 15 20 3 (set (reg:V2x16QI 62 v30 [117])

Re: [PR middle-end/114635] Set OMP safelen handling to INT_MAX when the pragma didn’t provide one.

2024-10-13 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. > On 8 Oct 2024, at 7:15 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Mon, Aug 5, 2024 at 7:05 AM Kugan Vivekanandarajah > wrote: >> >> >> >>>

Re: [PR middle-end/114635] Set OMP safelen handling to INT_MAX when the pragma didn’t provide one.

2024-10-07 Thread Kugan Vivekanandarajah
ping? Thanks, Kugan From: Kugan Vivekanandarajah Sent: Tuesday, 20 August 2024 6:18 PM To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org ; richard.guent...@gmail.com ; richard.sandif...@arm.com Subject: Re: [PR middle-end/114635] Set OMP safelen handling to

[testcase] Fix absfloat16.c testcase

2024-09-29 Thread Kugan Vivekanandarajah
Hi, This patch Fixes absfloat16.c testcase to have the dg-add-options float16 at the correct order. Due to this mixup, this test is failing for some arm variants. Is this OK for trunk? Thanks, Kugan 0001-Fix-absfloat16.c-testcase.patch Description: 0001-Fix-absfloat16.c-testcase.patch

Re: [PATCH] MATCH: add abs support for half float

2024-09-20 Thread Kugan Vivekanandarajah
Hi Richard, > On 17 Sep 2024, at 7:36 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Tue, Sep 17, 2024 at 10:31 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >>> On 10 Sep 2024, at 9:33 

Re: [PATCH] MATCH: add abs support for half float

2024-09-17 Thread Kugan Vivekanandarajah
Hi Richard, > On 10 Sep 2024, at 9:33 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Thu, Sep 5, 2024 at 3:19 AM Kugan Vivekanandarajah > wrote: >> >> Thanks for the explanation. >> >> >&g

Re: [PATCH] MATCH: add abs support for half float

2024-09-04 Thread Kugan Vivekanandarajah
Thanks for the explanation. > On 2 Sep 2024, at 9:47 am, Andrew Pinski wrote: > > External email: Use caution opening links or attachments > > > On Sun, Sep 1, 2024 at 4:27 PM Kugan Vivekanandarajah > wrote: >> >> Hi Andrew. >> >>>

Re: [PATCH] MATCH: add abs support for half float

2024-09-01 Thread Kugan Vivekanandarajah
Hi Andrew. > On 28 Aug 2024, at 2:23 pm, Andrew Pinski wrote: > > External email: Use caution opening links or attachments > > > On Tue, Aug 27, 2024 at 8:54 PM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >> Thanks for the reply. >&

Re: [PATCH] MATCH: add abs support for half float

2024-08-27 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the reply. > On 27 Aug 2024, at 7:05 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Tue, Aug 27, 2024 at 8:23 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >>

Re: [PATCH] MATCH: add abs support for half float

2024-08-26 Thread Kugan Vivekanandarajah
Hi Richard, > On 22 Aug 2024, at 10:34 pm, Richard Biener > wrote: > > External email: Use caution opening links or attachments > > > On Wed, Aug 21, 2024 at 12:08 PM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >>> On

Re: [PATCH] MATCH: add abs support for half float

2024-08-21 Thread Kugan Vivekanandarajah
Hi Richard, > On 20 Aug 2024, at 6:09 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Fri, Aug 9, 2024 at 2:39 AM Kugan Vivekanandarajah > wrote: >> >> Thanks for the comments. >> >>> On 2

Re: [PR middle-end/114635] Set OMP safelen handling to INT_MAX when the pragma didn’t provide one.

2024-08-20 Thread Kugan Vivekanandarajah
ping? Any feedback. Thanks, Kugan From: Kugan Vivekanandarajah Sent: Monday, 5 August 2024 3:05 PM To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org ; richard.guent...@gmail.com ; richard.sandif...@arm.com Subject: Re: [PR middle-end/114635] Set OMP safelen

Re: [PATCH] MATCH: add abs support for half float

2024-08-08 Thread Kugan Vivekanandarajah
Thanks for the comments. > On 2 Aug 2024, at 8:36 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Fri, Aug 2, 2024 at 11:20 AM Kugan Vivekanandarajah > wrote: >> >> >> >>> On 1 A

Re: [PR middle-end/114635] Set OMP safelen handling to INT_MAX when the pragma didn’t provide one.

2024-08-04 Thread Kugan Vivekanandarajah
> On 15 Jul 2024, at 5:18 pm, Jakub Jelinek wrote: > > External email: Use caution opening links or attachments > > > On Mon, Jul 15, 2024 at 12:39:22AM +, Kugan Vivekanandarajah wrote: >> OMP safelen handling is assigning backend provided max as an int even wh

Re: [PATCH] MATCH: add abs support for half float

2024-08-02 Thread Kugan Vivekanandarajah
> On 1 Aug 2024, at 10:46 pm, Richard Biener wrote: > > External email: Use caution opening links or attachments > > > On Thu, Aug 1, 2024 at 5:31 AM Kugan Vivekanandarajah > wrote: >> >> >> On Mon, Jul 29, 2024 at 10:11 AM Andrew Pinski wrote: &g

Re: [PATCH] MATCH: add abs support for half float

2024-07-31 Thread Kugan Vivekanandarajah
On Mon, Jul 29, 2024 at 10:11 AM Andrew Pinski wrote: > > On Mon, Jul 29, 2024 at 12:57 AM Kugan Vivekanandarajah > wrote: > > > > On Thu, Jul 25, 2024 at 10:19 PM Richard Biener > > wrote: > > > > > > On Thu, Jul 25, 2024 at 4:42 AM Kugan Vivekana

Re: [PATCH] MATCH: add abs support for half float

2024-07-29 Thread Kugan Vivekanandarajah
On Thu, Jul 25, 2024 at 10:19 PM Richard Biener wrote: > > On Thu, Jul 25, 2024 at 4:42 AM Kugan Vivekanandarajah > wrote: > > > > On Tue, Jul 23, 2024 at 11:56 PM Richard Biener > > wrote: > > > > > > On Tue, Jul 23, 2024 at 10:27 AM Kugan Vivekana

Re: [PATCH] MATCH: add abs support for half float

2024-07-24 Thread Kugan Vivekanandarajah
On Tue, Jul 23, 2024 at 11:56 PM Richard Biener wrote: > > On Tue, Jul 23, 2024 at 10:27 AM Kugan Vivekanandarajah > wrote: > > > > On Tue, Jul 23, 2024 at 10:35 AM Andrew Pinski wrote: > > > > > > On Mon, Jul 22, 2024 at 5:26 PM Kugan Vivekanandaraja

Re: [PATCH] MATCH: add abs support for half float

2024-07-23 Thread Kugan Vivekanandarajah
On Tue, Jul 23, 2024 at 10:35 AM Andrew Pinski wrote: > > On Mon, Jul 22, 2024 at 5:26 PM Kugan Vivekanandarajah > wrote: > > > > Revised based on the comment and moved it into existing patterns as. > > > > gcc/ChangeLog: > > > > * match.pd: Extend

Re: [PATCH] MATCH: add abs support for half float

2024-07-22 Thread Kugan Vivekanandarajah
Vivekanandarajah Bootstrapped and regression test on aarch64-linux-gnu. Is this OK for trunk? Thanks, Kugan From: Andrew Pinski Sent: Monday, 15 July 2024 5:30 AM To: Kugan Vivekanandarajah Cc: gcc-patches@gcc.gnu.org ; richard.guent...@gmail.com Subject: Re

[PR middle-end/114635] Set OMP safelen handling to INT_MAX when the pragma didn’t provide one.

2024-07-14 Thread Kugan Vivekanandarajah
safelen. gcc/testsuite/ChangeLog: * c-c++-common/pr114635-1.cpp: New test. * c-c++-common/pr114635-2.cpp: New test. Signed-off-by: Kugan Vivekanandarajah diff --git a/gcc/omp-low.cc b/gcc/omp-low.cc index 4d003f42098..69feedbde54 100644 --- a/gcc/omp-low.cc +++ b/gcc/omp-low.cc

[PATCH] MATCH: add abs support for half float

2024-07-14 Thread Kugan Vivekanandarajah
ee-ssa/absfloat16.c: New test. Signed-off-by: Kugan Vivekanandarajah 0001-abs-for-half-float.patch Description: 0001-abs-for-half-float.patch

[MAINTAINERS] Update my email address and move to DCO

2024-07-10 Thread Kugan Vivekanandarajah
Pushing to trunk. Thanks, Kugan Signed-off-by: Kugan Vivekanandarajah 2024-07-11 Kugan Vivekanandarajah * MAINTAINERS: Update my email address. diff --git a/MAINTAINERS b/MAINTAINERS index 762b91256c4..d27640708c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -704,7 +704,7

Re: [PATCH 1/4] Relax COND_EXPR reduction vectorization SLP restriction

2024-06-07 Thread Kugan Vivekanandarajah
Thanks Richard. Created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115383 Thanks, Kugan On Fri, Jun 7, 2024 at 5:51 PM Richard Biener wrote: > > On Fri, 7 Jun 2024, Kugan Vivekanandarajah wrote: > > > Hi Richard, > > > > This seems to have introduced a regres

Re: [PATCH 1/4] Relax COND_EXPR reduction vectorization SLP restriction

2024-06-07 Thread Kugan Vivekanandarajah
Hi Richard, This seems to have introduced a regression. I am seeing ICE while building TSVC_2 for AARCH64 with -O3 -flto -mcpu=neoverse-v2 -msve-vector-bits=128 tsvc.c: In function 's331': tsvc.c:2744:8: internal compiler error: Segmentation fault 2744 | real_t s331(struct args_t * func_args)

Re: [PR47785] COLLECT_AS_OPTIONS

2019-11-07 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Tue, 5 Nov 2019 at 23:08, Richard Biener wrote: > > On Tue, Nov 5, 2019 at 12:17 AM Kugan Vivekanandarajah > wrote: > > > > Hi, > > Thanks for the review. > > > > On Tue, 5 Nov 2019 at 03:57, H.J. Lu wrote: > >

Re: [PR47785] COLLECT_AS_OPTIONS

2019-11-04 Thread Kugan Vivekanandarajah
Hi, Thanks for the review. On Tue, 5 Nov 2019 at 03:57, H.J. Lu wrote: > > On Sun, Nov 3, 2019 at 6:45 PM Kugan Vivekanandarajah > wrote: > > > > Thanks for the reviews. > > > > > > On Sat, 2 Nov 2019 at 02:49, H.J. Lu wrote: > > > > > &g

Re: [PR47785] COLLECT_AS_OPTIONS

2019-11-03 Thread Kugan Vivekanandarajah
Thanks for the reviews. On Sat, 2 Nov 2019 at 02:49, H.J. Lu wrote: > > On Thu, Oct 31, 2019 at 6:33 PM Kugan Vivekanandarajah > wrote: > > > > On Wed, 30 Oct 2019 at 03:11, H.J. Lu wrote: > > > > > > On Sun, Oct 27, 2019 at 6:33 PM Kugan Vivekanand

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-31 Thread Kugan Vivekanandarajah
On Wed, 30 Oct 2019 at 03:11, H.J. Lu wrote: > > On Sun, Oct 27, 2019 at 6:33 PM Kugan Vivekanandarajah > wrote: > > > > Hi Richard, > > > > Thanks for the review. > > > > On Wed, 23 Oct 2019 at 23:07, Richard Biener > > wrote:

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-28 Thread Kugan Vivekanandarajah
Hi Bernhard, Thanks for the review. On Tue, 29 Oct 2019 at 08:52, Bernhard Reutner-Fischer wrote: > > On Mon, 28 Oct 2019 11:53:06 +1100 > Kugan Vivekanandarajah wrote: > > > On Wed, 23 Oct 2019 at 23:07, Richard Biener > > wrote: > > > > Did you try this

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-21 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the pointers. On Fri, 11 Oct 2019 at 22:33, Richard Biener wrote: > > On Fri, Oct 11, 2019 at 6:15 AM Kugan Vivekanandarajah > wrote: > > > > Hi Richard, > > Thanks for the review. > > > > On Wed, 2 Oct 2019 at 20:41, Richard Bien

Re: [PR47785] COLLECT_AS_OPTIONS

2019-10-10 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Wed, 2 Oct 2019 at 20:41, Richard Biener wrote: > > On Wed, Oct 2, 2019 at 10:39 AM Kugan Vivekanandarajah > wrote: > > > > Hi, > > > > As mentioned in the PR, attached patch adds COLLECT_AS_OPTIONS for > > passing a

[ARM] Enable DF only when TARGET_VFP_DOUBLE

2019-10-09 Thread Kugan Vivekanandarajah
As reported in Linaro bug report (https://bugs.linaro.org/show_bug.cgi?id=4636 ; there is no reproducible testcase provided), for some applications, we see (insn 126 125 127 9 (set (reg:DF 189) (fma:DF (reg:DF 126 [ _74 ]) (reg:DF 190) (reg:DF 191))) "ops.c":30 -1

[PR47785] COLLECT_AS_OPTIONS

2019-10-02 Thread Kugan Vivekanandarajah
Hi, As mentioned in the PR, attached patch adds COLLECT_AS_OPTIONS for passing assembler options specified with -Wa, to the link-time driver. The proposed solution only works for uniform -Wa options across all TUs. As mentioned by Richard Biener, supporting non-uniform -Wa flags would require eit

Re: AARCH64 configure check for gas -mabi support

2019-06-20 Thread Kugan Vivekanandarajah
00, Christophe Lyon > wrote: > > Committed on Kugan's behalf as rev 205891. > > > > On 11 December 2013 13:27, Marcus Shawcroft > > wrote: > > > On 10/12/13 20:23, Kugan wrote: > > > > > >> gcc/ > > >> > > >>

Re: [PATCH 0/2][RFC][PR88836][AARCH64] Fix redundant ptest instruction

2019-06-19 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for your comments. On Thu, 16 May 2019 at 18:13, Richard Sandiford wrote: > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > Inorder to fix this PR. > > * We need to change the whilelo pattern in backend &

Fix ICE due to commit for PR88834

2019-06-16 Thread Kugan Vivekanandarajah
believe this is the only way we can have GET_MODE_UNIT_SIZE of 0. Otherwise, we can check for GET_MODE_UNIT_SIZE of zero. Bootstrapped and regression tested attached patch on x86_64-linux-gnu with no new regressions. Is this OK for trunk? Thanks, Kugan gcc/ChangeLog: 2019-06-17 Kugan Vivekanandarajah

Re: [AARCH64] Fix typo in comment

2019-06-12 Thread Kugan Vivekanandarajah
Hi Kyrill, Thanks for the comments. Committed as you suggested. Thanks, Kugan On Wed, 12 Jun 2019 at 18:07, Kyrill Tkachov wrote: > > Hi Kugan, > > On 6/12/19 4:59 AM, Kugan Vivekanandarajah wrote: > > AArch64 comment for ADDSUB iterator is a typo or copy-and-paste error.

[AARCH64] Fix typo in comment

2019-06-11 Thread Kugan Vivekanandarajah
AArch64 comment for ADDSUB iterator is a typo or copy-and-paste error. Attached patch fixes this. I believe this falls under obvious category. I will commit it after 48hrs unless comments should be better worded. Thanks, Kugan gcc/ChangeLog: 2019-06-12 Kugan Vivekanandarajah * config

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 6 Jun 2019 at 22:07, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > Hi Richard, > > > > On Thu, 6 Jun 2019 at 19:35, Richard Sandiford > > wrote: > >> > >> Kugan Vivekanandarajah writes: > >> >

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-06 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 6 Jun 2019 at 19:35, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > Hi Richard, > > > > Thanks for the review. Attached is the latest patch. > > > > For testcase like cond_arith_1.c, with the patch, gcc ICE in fwprop. I

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-05 Thread Kugan Vivekanandarajah
3 Jun 2019 at 19:08, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > > index b3fae5b..ad838dd 100644 > > --- a/gcc/tree-vect-loop-manip.c > > +++ b/gcc/tree-vec

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-06-02 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review, On Fri, 31 May 2019 at 19:43, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > @@ -609,8 +615,14 @@ vect_set_loop_masks_directly (struct loop *loop, > > loop_vec_info loop_vinfo, > > > >/* Get the mask v

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-30 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Tue, 28 May 2019 at 20:44, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > [...] > > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > > index b3fae5b..c15b8a2 100644 > > --- a/gcc/tree-v

Re: [RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-27 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Sat, 25 May 2019 at 19:41, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > diff --git a/gcc/tree-vect-loop-manip.c b/gcc/tree-vect-loop-manip.c > > index 77d3dac..d6452a1 100644 > > --- a/gcc/tree-vect-loop-manip.c

Re: [PATCH 1/2] Add support for IVOPT

2019-05-21 Thread Kugan Vivekanandarajah
Hi Richard, On Fri, 17 May 2019 at 18:47, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > [...] > >> > +{ > >> > + struct mem_address parts = {NULL_TREE, integer_one_node, > >> > + NULL

[RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

2019-05-21 Thread Kugan Vivekanandarajah
4e9837ff9c0c080923f342e83574a6fdba2b3d92 Mon Sep 17 00:00:00 2001 From: Kugan Vivekanandarajah Date: Tue, 5 Mar 2019 10:01:45 +1100 Subject: [PATCH] pr88838[v2] As Mentioned in PR88838, this patch avoid the SXTW by using WHILELO on W registers instead of X registers. As mentined in PR, vect_verify_full_masking checks which IV widths

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

2019-05-16 Thread Kugan Vivekanandarajah
Hi, On Fri, 17 May 2019 at 13:37, wrote: > > From: Kewen Lin > > Hi, > > Previous version link: > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html > > Comparing with the previous version, I moved the generic > parts of rs6000 target hook to IVOPTs. But I still kept > the target hook as

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Thu, 16 May 2019 at 21:14, Richard Biener wrote: > > On Wed, May 15, 2019 at 4:40 AM wrote: > > > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > > > >

Re: [PATCH 1/2] Add support for IVOPT

2019-05-16 Thread Kugan Vivekanandarajah
Hi Richard, On Wed, 15 May 2019 at 16:57, Richard Sandiford wrote: > > Thanks for doing this. > > kugan.vivekanandara...@linaro.org writes: > > From: Kugan Vivekanandarajah > > > > gcc/ChangeLog: > > > > 2019-05-15 Kugan Vivekanandarajah > >

Re: [PATCH 2/2] aarch64 back-end changes

2019-05-15 Thread Kugan Vivekanandarajah
Hi Richard, On Wed, 15 May 2019 at 23:24, Richard Earnshaw (lists) wrote: > > On 15/05/2019 13:48, Richard Earnshaw (lists) wrote: > > On 15/05/2019 03:39, kugan.vivekanandara...@linaro.org wrote: > >> From: Kugan Vivekanandarajah > >> > > > > The subje

[PATCH 2/2] [PR88836][aarch64] Fix CSE to process parallel rtx dest one by one

2019-05-15 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah This patch changes cse_insn to process parallel rtx one by one such that any destination rtx in cse list is invalidated before processing the next. gcc/ChangeLog: 2019-05-16 Kugan Vivekanandarajah PR target/88834 * cse.c (safe_hash): Handle

[PATCH 1/2] [PR88836][aarch64] Set CC_REGNUM instead of clobber

2019-05-15 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah For aarch64 sve while_ult pattern, Set CC_REGNUM instead of clobbering. gcc/ChangeLog: 2019-05-16 Kugan Vivekanandarajah PR target/88834 * config/aarch64/aarch64-sve.md (while_ult): Set CC_REGNUM instead of clobbering. Change-Id

[PATCH 0/2][RFC][PR88836][AARCH64] Fix redundant ptest instruction

2019-05-15 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah Inorder to fix this PR. * We need to change the whilelo pattern in backend * Change RTL CSE such that: - Add support for VEC_DUPLICATE - When handling PARALLEL rtx in cse_insn, we kill CSE defined by all the parallel rtx at the end. For example, with

[PATCH 2/2] aarch64 back-end changes

2019-05-14 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah gcc/ChangeLog: 2019-05-15 Kugan Vivekanandarajah PR target/88834 * config/aarch64/aarch64.c (aarch64_classify_address): Relax allow_reg_index_p. gcc/testsuite/ChangeLog: 2019-05-15 Kugan Vivekanandarajah PR target/88834

[PATCH 0/2] [RFC][PR88834]

2019-05-14 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah In PR88834, IVOPT is not selecting the right addressing mode. Inorder to fix thix, we need to add support to add IV uses for IFN_MASK_LOAD_LANES and IFN_MASK_STORE_LANES. In addition, we also need to add IV candidate with scaled by the element or access size if

[PATCH 1/2] Add support for IVOPT

2019-05-14 Thread kugan . vivekanandarajah
From: Kugan Vivekanandarajah gcc/ChangeLog: 2019-05-15 Kugan Vivekanandarajah PR target/88834 * tree-ssa-loop-ivopts.c (get_mem_type_for_internal_fn): Handle IFN_MASK_LOAD_LANES and IFN_MASK_STORE_LANES. (find_interesting_uses_stmt): Likewise

Re: [aarch64][RFA][rtl-optimization/87763] Fix insv_1 and insv_2 for aarch64

2019-04-22 Thread Kugan Vivekanandarajah
Hi Jeff, [...] + "#" + "&& 1" + [(const_int 0)] + "{ + /* If we do not have an RMW operand, then copy the input + to the output before this insn. Also modify the existing + insn in-place so we can have make_field_assignment actually + generate a suitable extraction. */ + if (!rtx_eq

[PR89862] Fix ARM lto bootstrap

2019-03-28 Thread Kugan Vivekanandarajah
Hi All, LTO bootstrap for ARM fails with the commit commit 67c18bce7054934528ff5930cca283b4ac967dca * combine.c (record_dead_and_set_regs_1): Record the source unmodified for a paradoxical SUBREG on a WORD_REGISTER_OPERATIONS target. It fails with an internal compiler error: in operator+=, at pr

[SVE ACLE] svbic implementation

2019-03-19 Thread Kugan Vivekanandarajah
I have committed attached patch to aarch64/sve-acle-branch branch which implements svbic. Thanks, Kugan From 182bd15334874844bef5e317f55a6497f77e12ff Mon Sep 17 00:00:00 2001 From: Kugan Vivekanandarajah Date: Thu, 24 Jan 2019 20:57:19 +1100 Subject: [PATCH 1/3] svbic Change-Id

[SVE ACLE] Implements svdot

2019-01-17 Thread Kugan Vivekanandarajah
I committed the following patch which implements svdot to aarch64/sve-acle-branch. branch Thanks, Kugan From b75cd8ba8f911c137380677b85882c22a6467bf6 Mon Sep 17 00:00:00 2001 From: Kugan Vivekanandarajah Date: Fri, 18 Jan 2019 09:07:10 +1100 Subject: [PATCH] [SVE ACLE] Implements svdot Change

[SVE ACLE] Implements svmulh

2019-01-17 Thread Kugan Vivekanandarajah
I committed the following patch which implements svmulh to aarch64/sve-acle-branch. branch Thanks, Kugan From 33b76de8ef5f370dfacba0addef2fe0b1f2a61db Mon Sep 17 00:00:00 2001 From: Kugan Vivekanandarajah Date: Fri, 18 Jan 2019 07:33:26 +1100 Subject: [PATCH] [SVE ACLE] Implements svmulh Change

[SVE ACLE] Implements svabs, svnot, svneg and svsqrt

2019-01-15 Thread Kugan Vivekanandarajah
I committed the following patch which implements svabs, svnot, svneg and svsqrt to aarch64/sve-acle-branch. branch Thanks, Kugan From 2af9609a58cf7efbed93f15413224a2552b9696d Mon Sep 17 00:00:00 2001 From: Kugan Vivekanandarajah Date: Wed, 16 Jan 2019 07:45:52 +1100 Subject: [PATCH] [SVE ACLE

Re: [RFC][PR87528][PR86677] Disable builtin popcount detection when back-end does not define it

2018-11-11 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Thu, 8 Nov 2018 at 00:03, Richard Biener wrote: > > On Fri, Nov 2, 2018 at 10:02 AM Kugan Vivekanandarajah > wrote: > > > > Hi Richard, > > Thanks for the review. > > On Tue, 30 Oct 2018 at 01:25, Richard Biener > >

Re: [RFC][PR87528][PR86677] Disable builtin popcount detection when back-end does not define it

2018-11-02 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On Tue, 30 Oct 2018 at 01:25, Richard Biener wrote: > > On Mon, Oct 29, 2018 at 2:06 AM Kugan Vivekanandarajah > wrote: > > > > Hi Richard and Jeff, > > > > Thanks for your comments. > > > > On Fri, 26

Re: [RFC][PR87528][PR86677] Disable builtin popcount detection when back-end does not define it

2018-10-28 Thread Kugan Vivekanandarajah
Hi Richard and Jeff, Thanks for your comments. On Fri, 26 Oct 2018 at 19:40, Richard Biener wrote: > > On Fri, Oct 26, 2018 at 4:55 AM Jeff Law wrote: > > > > On 10/25/18 4:33 PM, Kugan Vivekanandarajah wrote: > > > Hi, > > > > > > PR87528 sho

[PR87469] ICE in record_estimate, at tree-ssa-loop-niter.c

2018-10-27 Thread Kugan Vivekanandarajah
this OK? Thanks, Kugan gcc/testsuite/ChangeLog: 2018-10-26 Kugan Vivekanandarajah PR middle-end/87469 * g++.dg/pr87469.C: New test. gcc/ChangeLog: 2018-10-26 Kugan Vivekanandarajah PR middle-end/87469 * tree-ssa-loop-niter.c (number_of_iterations_popcount): Fix niter max

[ABSU_EXPR] Add some of the missing patterns in match.pd

2018-10-25 Thread Kugan Vivekanandarajah
gcc/testsuite/ChangeLog: 2018-10-25 Kugan Vivekanandarajah * gcc.dg/gimplefe-30.c: New test. * gcc.dg/gimplefe-31.c: New test. * gcc.dg/gimplefe-32.c: New test. * gcc.dg/gimplefe-33.c: New test. gcc/ChangeLog: 2018-10-25 Kugan Vivekanandarajah * doc/generic.texi

[RFC][PR87528][PR86677] Disable builtin popcount detection when back-end does not define it

2018-10-25 Thread Kugan Vivekanandarajah
2018-10-25 Kugan Vivekanandarajah * tree-scalar-evolution.c (expression_expensive_p): Make BUILTIN POPCOUNT as expensive when backend does not define it. gcc/testsuite/ChangeLog: 2018-10-25 Kugan Vivekanandarajah * gcc.target/aarch64/popcount4.c: New test.

[SVE ACLE] Implements ACLE svdup, svindex, svqad/qsub, svabd and svmul

2018-10-15 Thread Kugan Vivekanandarajah
Hi, Attached patch implements ACLE svdup, svindex, svqad/qsub, svabd and svmul built-ins. Committed to ACLE branch, Thanks, Kugan 0001-svdup-svindex-svqad-qsub-svabd-and-svmul.patch.gz Description: application/gzip

Re: [RFC] Fix recent popcount change is breaking

2018-07-27 Thread Kugan Vivekanandarajah
Hi, On 28 July 2018 at 01:13, Richard Biener wrote: > On July 27, 2018 3:33:59 PM GMT+02:00, "Martin Liška" wrote: >>On 07/11/2018 02:31 PM, Richard Biener wrote: >>> Why not simply make popcountdi available in the kernel? They do have >>> implementations for other libgcc functions IIRC. >> >>C

[PR86544] Fix Popcount detection generates different code on C and C++

2018-07-17 Thread Kugan Vivekanandarajah
, Kugan gcc/ChangeLog: 2018-07-18 Kugan Vivekanandarajah PR middle-end/86544 * tree-ssa-phiopt.c (cond_removal_in_popcount_pattern): Handle comparison with EQ_EXPR in last stmt. gcc/testsuite/ChangeLog: 2018-07-18 Kugan Vivekanandarajah PR middle-end/86544 * g++.dg

Re: [RFC] Fix recent popcount change is breaking

2018-07-11 Thread Kugan Vivekanandarajah
Hi Andrew, On 11 July 2018 at 15:43, Andrew Pinski wrote: > On Tue, Jul 10, 2018 at 6:35 PM Kugan Vivekanandarajah > wrote: >> >> Hi Andrew, >> >> On 11 July 2018 at 11:19, Andrew Pinski wrote: >> > On Tue, Jul 10, 2018 at 6:14 PM Kugan Vivekanandarajah &

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Kugan Vivekanandarajah
Hi Andrew, On 11 July 2018 at 11:19, Andrew Pinski wrote: > On Tue, Jul 10, 2018 at 6:14 PM Kugan Vivekanandarajah > wrote: >> >> On 10 July 2018 at 23:17, Richard Biener wrote: >> > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah >> > wrote: >

Re: [RFC] Fix recent popcount change is breaking

2018-07-10 Thread Kugan Vivekanandarajah
On 10 July 2018 at 23:17, Richard Biener wrote: > On Tue, Jul 10, 2018 at 3:06 PM Kugan Vivekanandarajah > wrote: >> >> Hi, >> >> Jeff told me that the recent popcount built-in detection is causing >> kernel build issues as >> ERROR: "__popcounts

[RFC] Fix recent popcount change is breaking

2018-07-10 Thread Kugan Vivekanandarajah
pcount? I am testing the attached RFC patch. Is this reasonable? Thanks, Kugan gcc/ChangeLog: 2018-07-10 Kugan Vivekanandarajah * tree-ssa-loop-niter.c (number_of_iterations_popcount): Check if libfunc for popcount is available. diff --git a/gcc/tree-ssa-loop-niter.c b/gcc/tre

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

2018-07-09 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On 6 July 2018 at 20:17, Richard Biener wrote: > On Fri, Jul 6, 2018 at 11:45 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >> > It was rewrite_to_non_trapping_overflow available in tree.h. Thus >> > f

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

2018-07-06 Thread Kugan Vivekanandarajah
gressions. Thanks, Kugan gcc/ChangeLog: 2018-07-06 Kugan Vivekanandarajah * tree-scalar-evolution.c (final_value_replacement_loop): Use rewrite_to_non_trapping_overflow instead of rewrite_to_defined_overflow. From 68a4f232f6cde68751f6785059121fe116363886 Mon Sep 17 00:00:00 2001 Fr

Re: [PATCH 0/3][POPCOUNT]

2018-07-05 Thread Kugan Vivekanandarajah
Hi Jeff, Thanks for looking into it. On 6 July 2018 at 08:03, Jeff Law wrote: > On 06/24/2018 08:41 PM, Kugan Vivekanandarajah wrote: >> Hi Jeff, >> >> Thanks for the comments. >> >> On 23 June 2018 at 02:06, Jeff Law wrote: >>> On 06/22/2018 03:11 A

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

2018-07-05 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On 28 June 2018 at 21:26, Richard Biener wrote: > On Wed, Jun 27, 2018 at 7:00 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >> Thanks for the review. >> >> On 25 June 2018 at 20:01, Richard Biener wrote: &

Re: [PATCH 3/3][POPCOUNT] Remove unnecessary if condition in phiopt

2018-07-01 Thread Kugan Vivekanandarajah
Hi Richard, On 29 June 2018 at 18:45, Richard Biener wrote: > On Wed, Jun 27, 2018 at 7:09 AM Kugan Vivekanandarajah > wrote: >> >> Hi Richard, >> >> Thanks for the review, >> >> On 25 June 2018 at 20:20, Richard Biener wrote: >> > On F

Re: [ABSU_EXPR] Add some of the missing patterns in match,pd

2018-06-28 Thread Kugan Vivekanandarajah
convert again. > > Where are the testcases? I have fixed the above and added test-cases. > >> Bootstrap and regression testing on x86_64-linux-gnu. Is this OK if no >> regressions. > > > Does it mean you have run the tests or intend to run them in the future? It &g

[ABSU_EXPR] Add some of the missing patterns in match,pd

2018-06-27 Thread Kugan Vivekanandarajah
Hi, This patch adds some of the missing patterns in match.pd for ABSU_EXPR. Bootstrap and regression testing on x86_64-linux-gnu. Is this OK if no regressions. Thanks, Kugan gcc/ChangeLog: 2018-06-28 Kugan Vivekanandarajah * match.pd (absu(x)*absu(x) -> x*x): Handle. (a

Re: [PATCH 3/3][POPCOUNT] Remove unnecessary if condition in phiopt

2018-06-26 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review, On 25 June 2018 at 20:20, Richard Biener wrote: > On Fri, Jun 22, 2018 at 11:16 AM Kugan Vivekanandarajah > wrote: >> >> gcc/ChangeLog: > > @@ -1516,6 +1521,114 @@ minmax_replacement (basic_block cond_bb, > basic_block mi

Re: [PATCH 2/3][POPCOUNT] Check if zero check is done before entering the loop

2018-06-26 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On 25 June 2018 at 20:02, Richard Biener wrote: > On Fri, Jun 22, 2018 at 11:14 AM Kugan Vivekanandarajah > wrote: >> >> gcc/ChangeLog: > > The canonical way is calling simplify_using_initial_conditions on the > may_be_zero condit

Re: [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p

2018-06-26 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. On 25 June 2018 at 20:01, Richard Biener wrote: > On Fri, Jun 22, 2018 at 11:13 AM Kugan Vivekanandarajah > wrote: >> >> [PATCH 1/3][POPCOUNT] Handle COND_EXPR in expression_expensive_p > > This says that COND_EXPR itself isn't

Re: [PATCH 0/3][POPCOUNT]

2018-06-24 Thread Kugan Vivekanandarajah
Hi Bin, On 25 June 2018 at 13:56, Bin.Cheng wrote: > On Mon, Jun 25, 2018 at 11:37 AM, Kugan Vivekanandarajah > wrote: >> Hi Bin, >> >> Thanks for your comments. >> >> On 25 June 2018 at 11:15, Bin.Cheng wrote: >>> On Fri, Jun 22, 2018 at 5:11 PM,

Re: [PATCH 0/3][POPCOUNT]

2018-06-24 Thread Kugan Vivekanandarajah
Hi Bin, Thanks for your comments. On 25 June 2018 at 11:15, Bin.Cheng wrote: > On Fri, Jun 22, 2018 at 5:11 PM, Kugan Vivekanandarajah > wrote: >> When we set niter with maybe_zero, currently final_value_relacement >> will not happen due to expression_expensive_p not handlin

Re: [PATCH 0/3][POPCOUNT]

2018-06-24 Thread Kugan Vivekanandarajah
Hi Jeff, Thanks for the comments. On 23 June 2018 at 02:06, Jeff Law wrote: > On 06/22/2018 03:11 AM, Kugan Vivekanandarajah wrote: >> When we set niter with maybe_zero, currently final_value_relacement >> will not happen due to expression_expensive_p not handling. Patch

[PATCH 3/3][POPCOUNT] Remove unnecessary if condition in phiopt

2018-06-22 Thread Kugan Vivekanandarajah
gcc/ChangeLog: 2018-06-22 Kugan Vivekanandarajah * tree-ssa-phiopt.c (cond_removal_in_popcount_pattern): New. (tree_ssa_phiopt_worker): Call cond_removal_in_popcount_pattern. gcc/testsuite/ChangeLog: 2018-06-22 Kugan Vivekanandarajah * gcc.dg/tree-ssa/popcount3.c: New test

[PATCH 2/3][POPCOUNT] Check if zero check is done before entering the loop

2018-06-22 Thread Kugan Vivekanandarajah
gcc/ChangeLog: 2018-06-22 Kugan Vivekanandarajah * tree-ssa-loop-niter.c (number_of_iterations_popcount): If popcount argument is checked for zero before entering loop, avoid checking again. From 4f2a6ad5a49eec0a1cae15e033329f889f9137b9 Mon Sep 17 00:00:00 2001 From: Kugan

  1   2   >