Re: [RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe

2022-11-29 Thread Joel Brobecker via Gcc-patches
> >>>>> "Joel" == Joel Brobecker via Gdb-patches > >>>>> writes: > > Joel> ChangeLog: > > Joel> * src-release.sh (GDB_SUPPORT_DIRS): Add libsframe. > > Joel> Ok to apply to master? > > Looks good to

[RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe

2022-11-27 Thread Joel Brobecker via Gcc-patches
Hello, This script was recently changed as follow: | commit e619dddb3a45780ae66d762756882a3b896b617d | Date: Tue Nov 15 15:07:13 2022 -0800 | Subject: src-release.sh: Add libsframe | | Add libsframe to the list of top level directories that will be included | in a releas

Re: [ping] Re: [RFA] gcc.misc-tests/outputs.exp: Use link test to check for -gsplit-dwarf support

2022-05-24 Thread Joel Brobecker via Gcc-patches
> >> gcc/testsuite/ChangeLog: > >> > >> * gcc.misc-tests/outputs.exp: Make the -gsplit-dwarf test > >> a compile-and-link test rather than a compile-only test. > > OK, thanks. Thank you Richard. Pushed to master. -- Joel

[ping] Re: [RFA] gcc.misc-tests/outputs.exp: Use link test to check for -gsplit-dwarf support

2022-05-16 Thread Joel Brobecker via Gcc-patches
Hello, Gentle ping on this patch. Thank you! On Mon, Apr 25, 2022 at 09:04:51AM -0700, Joel Brobecker wrote: > Hello, > > We have noticed that, when running the GCC testsuite on AArch64 > RTEMS 6, we have about 150 tests failing due to a link failure. > When investigating, we

[RFA] gcc.misc-tests/outputs.exp: Use link test to check for -gsplit-dwarf support

2022-04-25 Thread Joel Brobecker via Gcc-patches
Hello, We have noticed that, when running the GCC testsuite on AArch64 RTEMS 6, we have about 150 tests failing due to a link failure. When investigating, we found that all the tests were failing due to the use of -gsplit-dwarf. On this platform, using -gsplit-dwarf currently causes an error duri

Re: Patch RFA: Support non-ASCII file names in git-changelog

2020-12-24 Thread Joel Brobecker
> > I have no idea who that is (if it is a single user at all, > > if it isn't any user with git write permissions). > > CCing Joel, he should help us how to set a git config > that will be used by the server hooks. I am not sure that requiring both the server and the user to agree on a non-defau

Re: Ping: [RFA] Require powerpc_vsx_ok in gcc.target/powerpc/pr71763.c

2020-05-18 Thread Joel Brobecker
Hi Peter and Segher, > > You should always CC the PPC maintainers on PPC patches. > > I've CC'd both Segher and David. Thanks a lot for doing that. And well understood for future patches. > > >>> This commit adds a powerpc_vsx_ok dg-require-effective-target directive > > >>> to that test, and th

Re: Ping: [RFA] Require powerpc_vsx_ok in gcc.target/powerpc/pr71763.c

2020-05-13 Thread Joel Brobecker
llowed onto branch master. > > > On Fri, Apr 17, 2020 at 04:49:47PM -0700, Joel Brobecker wrote: > > From: Douglas Rupp > > > > Hello, > > > > (submitting this on behalf of Doug Rupp, one of my colleagues) > > > > We're getting an er

Ping: [RFA] Require powerpc_vsx_ok in gcc.target/powerpc/pr71763.c

2020-05-01 Thread Joel Brobecker
Hello, Just a friendly ping on the following patch, hopefully sufficiently straightforward and tested to be allowed onto branch master. Thank you! On Fri, Apr 17, 2020 at 04:49:47PM -0700, Joel Brobecker wrote: > From: Douglas Rupp > > Hello, > > (submitting this on behalf of

[RFA] Require powerpc_vsx_ok in gcc.target/powerpc/pr71763.c

2020-04-17 Thread Joel Brobecker
From: Douglas Rupp Hello, (submitting this on behalf of Doug Rupp, one of my colleagues) We're getting an error when running this test on PowerPC VxWorks 7, due to an unexpected warning: | Excess errors: | cc1: warning: '-mvsx' and '-mno-altivec' are incompatible The warning comes fro

Re: [RFA] skip gcc.target/arm/div64-unwinding.c on vxworks_kernel targets

2020-04-06 Thread Joel Brobecker
> > gcc/testsuite/ > > > > * gcc.target/arm/div64-unwinding.c: Skip on vxworks_kernel targets. > OK. Thank you, Richard. Pushed to master. -- Joel

[RFA] skip gcc.target/arm/div64-unwinding.c on vxworks_kernel targets

2020-04-03 Thread Joel Brobecker
Hello, This test verifies, by using a weak reference to _Unwind_RaiseException, that performing division by zero does not cause that symbol to get indirectly pulled into our closure. The testing methodology unfortunately does not work on VxWorks targets when building in kernel mode. This is inher

Re: limit on emails for merge commits.

2020-01-17 Thread Joel Brobecker
Hi Ian, > As I noted, 100 commits to master is a small number, so I expect this problem > to fire almost every time someone does a merge of master to a devel or user > branch (unless they have the habit of doing that almost daily, which I doubt > for > most). The main goal of the limit is really

Re: limit on emails for merge commits.

2020-01-16 Thread Joel Brobecker
Hello, > You should include Joel on such questions as the expert on the hooks. > > I don't know whether there's something to put in the commit message to say > "allow this merge of more than 100 commits". I don't think a squashed > merge is the right workaround, supposing you do want the git a

Re: [RFA] adjust src-release following the renaming of gdb/common/ to gdb/gdbsupport/

2019-07-13 Thread Joel Brobecker
> >ChangeLog: > > > >* src-release (getver): If $tool/gdbsupport/create-version.sh > >exists, use that to determine the version number. > > > >Tested on x86_64-linux, by running the src-release script with "gdb" > >as the argument, and verifying that the name of the tarball is now >

[RFA] adjust src-release following the renaming of gdb/common/ to gdb/gdbsupport/

2019-07-12 Thread Joel Brobecker
Hello, A recent change renamed the common/ directory into gdbsupport/ in gdb. This causes problems in the getver function in the src-release script which doesn't find the create-version.sh script anymore. As a result, it falls back on using the version.in file verbatim, meaning that the "DATE" pla

Re: [RFA] fix copyright year range in libstdc++ test file (was: "Re: [v3 PATCH] Implement std::string_view and P0254r2, Integrating std::string_view and std::string.")

2019-01-01 Thread Joel Brobecker
> > In working on updating the copyright year notices for the GDB files, > > I noticed something very minor regarding the patch which added the > > file below (the same file was copied in gdb's testsuite); it looks > > like the year range for one of the files is truncated: > > > libstdc++-v3/Chang

[RFA] fix copyright year range in libstdc++ test file (was: "Re: [v3 PATCH] Implement std::string_view and P0254r2, Integrating std::string_view and std::string.")

2018-12-31 Thread Joel Brobecker
ne a fix pushed to GCC, I will take care of the GDB side. Thank you, -- Joel >From a29191e526c1aeed7da592af3e9bb51c7db8c297 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Tue, 1 Jan 2019 09:40:00 +0400 Subject: [PATCH] Fix year range in libstdc++v3/testsuite/.../empty.cc copyright he

Re: [RFA] require profiling support for gcc.dg/lto/20100430-1_0.c test

2018-12-12 Thread Joel Brobecker
> > gcc/testsuite/ChangeLog: > > > > * gcc.dg/lto/20100430-1_0.c: Add dg-require-profiling requirement. > > > > OK to push? > > OK. Thank you Richard. Patch pushed to trunk (r267055). -- Joel

[RFA] require profiling support for gcc.dg/lto/20100430-1_0.c test

2018-12-12 Thread Joel Brobecker
Hello, This test currently fails unexpectedly if GCC is configured with --disable-gcov, because it requires -fprofile-arcs. This patch fixes the issue by requiring profiling support in order to run this test. Tested with two compilers, one built with --disable-gcov, resulting in the test reportin

Re: [PATCH] [configure] Added "nfp" to the build for binutils.

2018-04-30 Thread Joel Brobecker
> +2018-04-30 Francois H. Theron > + > + * config.sub: Added "nfp" to basic_machine list. > + * configure.ac: Added "nfp" target. > + * configure: Regenerate. I am not a maintainer, but I noticed that config.sub is not being modified by this commit -- a small discrepancy between the

Re: MinGW compilation warnings in libiberty's waitpid.c

2017-06-07 Thread Joel Brobecker
> I ended up not having time before going on holiday. If the resync > hasn't already been done, I'll do it now. Thanks for doing that, Iain! -- Joel

Re: MinGW compilation warnings in libiberty's waitpid.c

2017-05-30 Thread Joel Brobecker
> This has been on my todo-list for a little while, as re-syncing is > something I normally do after pushing D language support updates into > libiberty. However I decided to give it a wait until I got all > pending patches in, the last of which I'm just pushing in now. That's very kind of you to

Re: MinGW compilation warnings in libiberty's waitpid.c

2017-05-26 Thread Joel Brobecker
> What can I do to expedite the process? This currently holds the 8.0 > release, and I'm uneasy to be the culprit. The way I usually do it is grab the commit in GCC, and apply it as is in the GDB repository. To make it easier, I use the git mirror of the GCC repository, because I can then just ad

Re: MinGW compilation warnings in libiberty's waitpid.c

2017-05-26 Thread Joel Brobecker
> Thanks. Is the environ thing also fixed? > > Joel/Pedro, how should I go about making sure these changes are in the > GDB copy of libiberty? Normally, I'd expect someone pushing to GCC's libibert to also update our repo accordingly. However, it's easy to forget so, if you notice a change that

Re: [PATCH] For broken exception handling in GDB on AIX platform

2017-03-26 Thread Joel Brobecker
Hello, > I got some review comment from Bernhard Reutner-Fischer, and I have > updated the patch accordingly. > This patch is for bug opened > here:https://sourceware.org/bugzilla/show_bug.cgi?id=21187 This patch has been identified as one of the desirable patches to have for the GDB 8.0 release,

Re: update zlib to 1.2.8

2015-11-24 Thread Joel Brobecker
> No, just a packaging issue with somebody mentioning a static binutils build. > That's when I saw the outdated version. > > Now updated in the GCC VCS. OK, if you have updated the GCC sources, would you mind updating the binutils-gdb.git as well? We should really keep the two as much in sync as

Re: update zlib to 1.2.8

2015-11-23 Thread Joel Brobecker
> In GCC zlib is only used for libjava; for binutils and gdb it is used when > building without --with-system-zlib. This just updates zlib from 1.2.7 to > 1.2.8 (released in 2013). Applies cleanly, libjava still builds and doesn't > show any regressions in the testsuite. Ok to apply (even if we

Re: [RFA] Do not use libiberty's getpagesize on Android

2015-11-06 Thread Joel Brobecker
> > libiberty/ChangeLog: > > > > * configure.ac: Set AC_CV_FUNC_GETPAGESIZE to "yes" on > > Android hosts. > > * configure: Regenerate. > > > > OK to apply? > > Ok. Thank you, DJ. committed in gcc's SVN, and pushed to binutils-gdb. -- Joel

[RFA] Do not use libiberty's getpagesize on Android

2015-11-06 Thread Joel Brobecker
Hello, Building libiberty on Android currently fails with the error message shown below. This was discovered by trying to build GDBserver for Android, which stopped building after libiberty became a GDBserver dependency. Here is the error message: [...]/getpagesize.c:64:1: error: redefinition o

Re: [RFA] libiberty/mkstemps.c: Include if not available.

2015-05-08 Thread Joel Brobecker
> > * mkstemps.c: #include if HAVE_TIME_H is defined > > but not HAVE_SYS_TIME_H. > > Ok. Thank you, DJ. Pushed to both GCC and binutils-gdb. -- Joel

[RFA] libiberty/mkstemps.c: Include if not available.

2015-05-08 Thread Joel Brobecker
Hello, Attempting to build libiberty on LynxOS-178 fails trying to compile mkstemps.c with the following error: mkstemps.c:84:18: error: storage size of 'tv' isn't known struct timeval tv; ^ This file would normally include to get the type's definition, but unfo

Re: [PATCH] PR debug/61352 back port from mainline

2015-05-07 Thread Joel Brobecker
> > The attached patch is a back port of the change from > > https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=211067 for > > gcc-4_9-branch. Bootstrap and regression tested on > > x86_64-apple-darwin14 with Xcode 6.3. Okay for gcc-4_9-branch? > > Jack > > > > Ok. > > Committed

Re: ping #3: [RFA] Add --with-libz-prefix option in config/zlib.m4

2015-02-18 Thread Joel Brobecker
> Why do you want to turn off zlib? On Linux/x86, zlib is required > for assembler. At least, you should issue an error when --without-libz > is used in binutils for Linux/x86 target. I am trying to do the exact opposite, which is to provide an option to compile WITH zlib, but using an install a

Re: ping: [RFA] Add --with-libz-prefix option in config/zlib.m4

2015-01-21 Thread Joel Brobecker
> What is the rational for having --with-zlib but --with-libz-prefix > (ie zlib vs libz) ? Looks not very consistent. I agree it's unfortunate, but it is unavoidable if I want to keep the current option as it is (compatibility), and reuse AC_LIB_HAVE_LINKFLAGS (which is a fairly complex function)

Re: [RFA] Add --with-libz-prefix option in config/zlib.m4

2015-01-07 Thread Joel Brobecker
> > This patch enhances config/zlib.m4 to introduce an extra option > > --with-libz-prefix which allows us to provide the location of > > the zlib library we want to use during the build. > > I prefer the gcc way to provide external library: > > --with-zlib -> system zlib used > --with-zlib=pathn

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
> > libiberty/ChangeLog: > > > > * d-demangle.c: Replace strtold with strtod in global comment. > > (strtold): Remove declaration. > > (strtod): New declaration. > > (dlang_parse_real): Declare value as double instead of long > > double. Replace call to strt

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
rom 99f9794c6d2f4dabed0bbcf2cf362b1eb25ee2a7 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Tue, 14 Oct 2014 12:47:43 -0400 Subject: [PATCH] Use strtod instead of strtold in libiberty/d-demangle.c strtold is currently used to decode templates which have a floating-point value encoded inside;

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
d to strtod. Thank you! -- Joel >From 9e4d74607075ef857dfa4e118f43641494aaff90 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Tue, 14 Oct 2014 09:54:05 -0400 Subject: [PATCH] libiberty: fallback on strtod if strtold is not available. This patch fixes a build failurer on Solaris 2.9, and al

Re: [RFA/dwarf v2] Add DW_AT_GNAT_use_descriptive_type flag for Ada units.

2014-05-08 Thread Joel Brobecker
On 02/19/2013 10:42 PM, Joel Brobecker wrote: > > >This is useful when a DIE does not have a descriptive type attribute. > > >In that case, the debugger needs to determine whether the unit > > >was compiled with a compiler that normally provides that information, > >

Re: [PATCH 1/2] Windows libibery: Don't quote args unnecessarily

2014-04-21 Thread Joel Brobecker
> Changelog libiberty/ > * pex-win32.c (argv_to_cmdline): Don't quote > args unnecessarily Some minor comments... > > diff --git a/libiberty/pex-win32.c b/libiberty/pex-win32.c > > index eae72c5..775b53c 100644 > > --- a/libiberty/pex-win32.c > > +++ b/libiberty/pex-win32.c > > @@ -34

Re: copyright dates in binutils (and includes/)

2014-02-28 Thread Joel Brobecker
> Joseph, do you know why implicitly adding years to the claimed > copyright years is a problem? I'm guessing the file needs to be > published somewhere for each year claimed. IANAL, but from 2 discussions with copyright-clerk: 1. We start claiming copyright the year the file as committed

Re: copyright dates in binutils (and includes/)

2014-02-27 Thread Joel Brobecker
Hi Alan, My two cents... > --- a/bfd/elf32-sparc.c > +++ b/bfd/elf32-sparc.c > @@ -1,7 +1,5 @@ > /* SPARC-specific support for 32-bit ELF > - Copyright 1993, 1994, 1995, 1996, 1997, 1998, 1999, 2000, 2001, 2002, > - 2003, 2004, 2005, 2006, 2007, 2010, 2011 > - Free Software Foundation, Inc

Re: [RFA/dwarf v2] Add DW_AT_GNAT_use_descriptive_type flag for Ada units.

2014-02-21 Thread Joel Brobecker
arted working on producing standard DWARF in place of our encodings, and small progress has been made. But this is even more of a huge task than we thought, and in the meantime, this little flag will help non-AdaCore users... Thank you! On Fri, Jan 31, 2014 at 09:09:05AM +0400, Joel Brobecker wrote: >

Re: [RFA/dwarf v2] Add DW_AT_GNAT_use_descriptive_type flag for Ada units.

2014-01-30 Thread Joel Brobecker
[resending with the patch - sorry about that] Hi Jason, On Tue, Feb 19, 2013 at 10:50:46PM -0500, Jason Merrill wrote: > On 02/19/2013 10:42 PM, Joel Brobecker wrote: > >This is useful when a DIE does not have a descriptive type attribute. > >In that case, the debugger needs to de

[RFA/dwarf v2] Add DW_AT_GNAT_use_descriptive_type flag for Ada units.

2014-01-30 Thread Joel Brobecker
Hi Jason, On Tue, Feb 19, 2013 at 10:50:46PM -0500, Jason Merrill wrote: > On 02/19/2013 10:42 PM, Joel Brobecker wrote: > >This is useful when a DIE does not have a descriptive type attribute. > >In that case, the debugger needs to determine whether the unit > >was compiled

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-19 Thread Joel Brobecker
> Thanks! That's great progress on the Binutils side. You are very welcome. > What is the status of patches for GCC to generate DWARF for AIX XCOFF > and do the AIX assembler and linker recognize, consume and process the > directives produced by GCC correctly? I haven't looked at this part in d

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-18 Thread Joel Brobecker
> > >> AFAICT, for gcc+gas it should already work with binutils that include > > >> the AdaCore patch for DWARF support. But this has apparently not been > > >> tested with AIX ld, and there are AdaCore local patches pending. > > >> http://sourceware.org/ml/binutils/2011-04/msg00250.html > > >> htt

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)

2013-02-14 Thread Joel Brobecker
hu Oct 18 23:00:04 2012 + daily update -- Joel >From dc928a0dbd0e762577c51204b043d6b6f066940d Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Thu, 14 Feb 2013 23:53:25 +0100 Subject: [PATCH] AIX: add DWARF support * bfd/coff-rs6000.c (xcoff_dwsect_names): Add .dwframe,

Ping: [RFA/dwarf] Add DW_AT_use_GNAT_descriptive_type flag for Ada units.

2013-01-29 Thread Joel Brobecker
Hello, I was hoping someone would kindly review this patch? It is an important part for debugging Ada code, helping with performance. Thank you! On Tue, Jan 08, 2013 at 07:24:14AM -0500, Joel Brobecker wrote: > Hello, > > I just noticed that part of the proposal we made for.

Re: [RFA/dwarf] Add DW_AT_use_GNAT_descriptive_type flag for Ada units.

2013-01-14 Thread Joel Brobecker
Ping? Thank you! On Tue, Jan 08, 2013 at 07:24:14AM -0500, Joel Brobecker wrote: > Hello, > > I just noticed that part of the proposal we made for... > http://gcc.gnu.org/wiki/DW_AT_GNAT_descriptive_type > > ... got missed in the patch that got checked in: > http://gcc.g

Re: [RFA] statement before variable declaration in cp_parser_initializer_list.

2013-01-08 Thread Joel Brobecker
> > Eric Botcazou asked that we have the same code for both 4.7 and HEAD. > > Would it be OK to apply it to both? It's not really strictly > > necessary for the HEAD, but I don't see it as being harmful either. > > Sure. Thank you! Now checked in. -- Joel

[RFA/dwarf] Add DW_AT_use_GNAT_descriptive_type flag for Ada units.

2013-01-08 Thread Joel Brobecker
Hello, I just noticed that part of the proposal we made for... http://gcc.gnu.org/wiki/DW_AT_GNAT_descriptive_type ... got missed in the patch that got checked in: http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00099.html In particular, we're missing the second part, where we are expected to gener

Re: [RFA] statement before variable declaration in cp_parser_initializer_list.

2013-01-08 Thread Joel Brobecker
Hi Richard, > >> Hmm? We compile with a C++ compiler where this is perfectly valid ... > > > > I was compiling with GCC 4.7 where it gave me a warning... I don't know > > much about C++ anymore, so I didn't know. Oh well! > > Ah, for the 4.7 branch yes. Eric Botcazou asked that we have the same

Re: [RFA] statement before variable declaration in cp_parser_initializer_list.

2013-01-03 Thread Joel Brobecker
> > Tested against x86_64-linux, no regression. > > OK to commit? (obvious?) > > Hmm? We compile with a C++ compiler where this is perfectly valid ... I was compiling with GCC 4.7 where it gave me a warning... I don't know much about C++ anymore, so I didn't know. Oh well! -- Joel

[RFA] statement before variable declaration in cp_parser_initializer_list.

2013-01-03 Thread Joel Brobecker
Hello, I happened to notice a warning while compiling GCC, and it seemed like an easy fix... gcc/cp/ChangeLog: * parser.c (cp_parser_initializer_list): Move declaration of variable non_const to start of lexical block. Tested against x86_64-linux, no regression. OK to commit? (ob

Re: [RFA] .gitignore: Ignore *.pyc files.

2012-12-18 Thread Joel Brobecker
Ping. This patch seems fairly straightforward to the point of being almost obvious, but so far, no review (beyond one email expressing interest). Thanks! > The GDB sources contain some python files, and executing them > causes these .pyc files to appear. We could ignore them in GDB > only, but

[RFA] .gitignore: Ignore *.pyc files.

2012-12-07 Thread Joel Brobecker
Hello, The GDB sources contain some python files, and executing them causes these .pyc files to appear. We could ignore them in GDB only, but I think this is the type of extension (compilation artifact) which can be shared amoung all projects. ChangeLog: * .gitignore: Ignore *.pyc file.

Re: [RFA] Update config.sub to 2012-04-18 version.

2012-04-25 Thread Joel Brobecker
> ChangeLog: > > * config.sub: Update to 2012-04-18 version from official repo. Thanks to everyone who answered. This patch is no in, both GCC & src. -- Joel

[RFA] Update config.sub to 2012-04-18 version.

2012-04-19 Thread Joel Brobecker
Hello everyone, I wasn't sure if I needed approval for this patch or not, but better be safe than sorry. I'll apply to both GCC and then src when I receive confirmation that it's OK to apply. I would like to update the config.sub script to the latest version from the official config repo. The bi

Re: [RFA/libiberty] Darwin has case-insensitive filesystems

2011-07-01 Thread Joel Brobecker
> Looks OK to me. Thanks, DJ. I've just checked the patch in on the GCC side. I will push it on the src/GDB CVS momentarily. -- Joel

Re: [RFA/libiberty] Darwin has case-insensitive filesystems

2011-06-14 Thread Joel Brobecker
> There's a difference between case preserving and case sensitive, > though, and we really don't have a portable way to detect > case-sensitivity on a per-directory basis, sow how can we do better? That's roughly my thoughts on this issue. It's true that this property is not an OS property, and we

[RFA/libiberty] Darwin has case-insensitive filesystems

2011-06-14 Thread Joel Brobecker
Hello, HFS+, the FS on Darwin, is case insensitive. So this patch adjusts filename_cmp.c to ignore the casing when comparing filenames on Darwin. This is visible in GDB when trying to break on a file whose name is, say 'Mixed_Case.adb', but was compiled using 'mixed_case.adb' as the filename. In