Hi Jason,
On Tue, Feb 19, 2013 at 10:50:46PM -0500, Jason Merrill wrote:
> On 02/19/2013 10:42 PM, Joel Brobecker wrote:
> >This is useful when a DIE does not have a descriptive type attribute.
> >In that case, the debugger needs to determine whether the unit
> >was compiled with a compiler that normally provides that information,
> >or not.
>
> Ah. OK, then. But I'd prefer to call it
> DW_AT_GNAT_use_descriptive_type, to follow the convention of keeping
> the vendor tag at the beginning of the name.
Almost a year ago, you privately approved a small patch of mine,
with the small request above. I'm sorry I let it drag so long!
Here is the updated patch.
include/ChangeLog:
* dwarf2.def: Rename DW_AT_use_GNAT_descriptive_type into
DW_AT_GNAT_use_descriptive_type.
gcc/ChangeLog:
* dwarf2out.c (gen_compile_unit_die): Add
DW_AT_use_GNAT_descriptive_type attribute for Ada units.
Tested on x86_64-linux.
I should also adjust the Wiki page accordingly, but the login process
keeps timing out. I know I have the right login and passwd since
I succesfully reset them using the passwd recovery procedure, just
in case the error was due to bad credentials. I'll try again later.
If approved, I will also take care of coordinating the dwarf2.def
change with binutils-gdb.git.
Is this patch still OK to commit?
Thank you,
--
Joel
