Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread Andreas Schwab
On Jun 02 2025, John Paul Adrian Glaubitz wrote: > To me both statements seem to contradict each other. How? They comment two different things. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something co

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread Andreas Schwab
On Jun 02 2025, John Paul Adrian Glaubitz wrote: > Both NetBSD and Linux return structs differently, yet the comments in the > source code claim their way is according to the m68k SVR4 specification. Where does it claim that? -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-06-02 Thread Andreas Schwab
On Jun 01 2025, John Paul Adrian Glaubitz wrote: > I was talking about the comments, not the code since NetBSD and Linux > disagree on what the SVR4 ABI claims. In which way? -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC

Re: DEFAULT_PCC_STRUCT_RETURN on NetBSD vs Linux

2025-05-28 Thread Andreas Schwab
And, secondly, shouldn't the comment in linux.h be corrected since > apparently linux.h and netbsd-elf.h disagree on what the SVR4 ABI > specifies how structs and unions are returned? This is controlled by TARGET_RETURN_IN_MEMORY if DEFAULT_PCC_STRUCT_RETURN is 0. -- Andreas Schwab, sch.

Re: [RFC 2/2] libstdc++: Avoid double indirection when cosntructing function_ref owning wrappers [PR119126]

2025-05-21 Thread Andreas Schwab
s/cosntructing/constructing/ -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v2 6/8] RISC-V: Drop riscv_implied_info and riscv_combine_info in favor of riscv_ext_info_t data

2025-05-16 Thread Andreas Schwab
cc/common/config/riscv/riscv-common.cc:1645:48: note: 'const std::string' {aka 'const std::__cxx11::basic_string'} temporary created here 1645 | auto &ext_info = get_riscv_ext_info (search_ext); |^~ c

[PATCH] libiberty: remove duplicated declaration of mkstemps

2025-05-14 Thread Andreas Schwab
mp;& \ !defined (HAVE_MEMRCHR) -- 2.49.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] libiberty: Fix off-by-one when collecting range expression

2025-05-12 Thread Andreas Schwab
amp;& *p == ']') || p == pend) break; - if (c1 < sizeof (str)) + if (c1 < sizeof (str) - 1) str[c1++] = c; else /* This is in any case an invalid class name. *

Re: [pushed] [PATCH] check_GNU_style: Remove literal prefix

2025-05-09 Thread Andreas Schwab
t[2:] a.k.a. t = pfile.target_file.removeprefix('b/') -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] testsuite: Skip pr119160 for RISC-V backend.

2025-05-08 Thread Andreas Schwab
dditional-options "-mgeneral-regs-only" { target { x86_64-*-* > i?86-*-* } } } */ arm and aarch64 support it too, if it matters. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] testsuite: Skip pr119160 for RISC-V backend.

2025-05-08 Thread Andreas Schwab
On Mai 08 2025, Jiawei wrote: > RISC-V backend don't support '-mgeneral-regs-only' option, skip it. Almost all backends do not support it. It should be used only on those few that do. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4

[PATCH] Fix off-by-one when collecting range expression

2025-05-07 Thread Andreas Schwab
amp;& *p == ']') || p == pend) break; - if (c1 < sizeof (str)) + if (c1 < sizeof (str) - 1) str[c1++] = c; else /* This is in any case an invalid class name. *

[PATCH] libstdc++: Update baseline symbols for powerpc-linux and powerpc64-linux

2025-04-23 Thread Andreas Schwab
:GLIBCXX_3.4.6 -- 2.49.0 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

[PATCH] libstdc++: Update baseline symbols for riscv64-linux

2025-04-22 Thread Andreas Schwab
@@CXXABI_1.3.14 OBJECT:32:_ZTIPKDF64_@@CXXABI_1.3.14 -- 2.49.0 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

[PATCH] libstdc++: Update baseline_symbols.txt for m68k-linux

2025-04-22 Thread Andreas Schwab
-- 2.49.0 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] recog: Handle some mode-changing hardreg propagations

2025-04-19 Thread Andreas Schwab
On Apr 19 2025, Jeff Law wrote: > Well, I *think* Andreas's comment was suggesting that the patch was caused > a build failure in libstdc++, so that needs to be addressed as before this > could go forward. Yes, it breaks the -mlra build. -- Andreas Schwab, sch...@linux-m6

[PATCH] libstdc++: Finalize GCC 15 ABI

2025-04-19 Thread Andreas Schwab
uot; + bool latestp = (test.version_name == "GLIBCXX_3.4.35" +|| test.version_name == "CXXABI_1.3.17" || test.version_name == "CXXABI_FLOAT128" || test.version_name == "CXXABI_TM_1"); if (

[PATCH] libgcobol: mark riscv64-*-linux* as supported target

2025-04-15 Thread Andreas Schwab
ux* | i?86-*-linux* | x86_64-*-darwin*) if test x$ac_cv_sizeof_void_p = x8; then LIBGCOBOL_SUPPORTED=yes -- 2.49.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] libgcobol: Add missing float128 suffix

2025-04-14 Thread Andreas Schwab
348623157E308 ) + if( FP128_FUNC(fabs)(value) > GCOB_FP128_LITERAL(1.7976931348623157E308) ) { retval = 1; } -- 2.49.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] libgcobol: Check for struct tm tm_zone

2025-04-11 Thread Andreas Schwab
On Apr 11 2025, Rainer Orth wrote: > This patch uses Autoconf's AC_STRUCT_TIMEZONE to determine its presence > and guard the use accordingly. You cannot use AC_STRUCT_TIMEZONE because it requires a link test (which is forbidden in a target module, see PR119550). -- Andreas Schwab, s

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-11 Thread Andreas Schwab
1365 | char name[NAME_MAX]; > | ^~~~ > > NAME_MAX being undefined is allowed by POSIX.1, actually: it's listed > for under "Pathname Variable Values": It doesn't look like this member is accociated with file names at all. -- Andreas Schwab, sch

Re: [PATCH] gcc_release: Generate srcdir extras/infos/man pages from all FEs [PR119510]

2025-03-31 Thread Andreas Schwab
On Mär 31 2025, Richard Biener wrote: > Do we even install libffi.info? We shouldn't. It would conflict with the standalone libffi library, and we don't install anything from the target libffi library anyway (it's only used internally). -- Andreas Schwab, SUSE Labs, sch.

Re: [PATCH] RISC-V: vsetvl: skip abnormal edge on vsetvl insertion [PR119533]

2025-03-30 Thread Andreas Schwab
1 @@ pre_vsetvl::emit_vsetvl () > eg->src->index, eg->dest->index); > footer_info.dump (dump_file, ""); > } > + if (eg->flags & EDGE_ABNORMAL) > + { > + fprintf (dump_file, "\nsk

[PATCH] Remove buffer overflow in cobol driver

2025-03-24 Thread Andreas Schwab
, ach, 1); prior_main = false; entry_point = NULL; -- 2.49.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] libgcobol: use standard f128 suffix instead of Q for _Float128 literals

2025-03-24 Thread Andreas Schwab
lue) > 3.4028235E38Q ) + if( fabsf128(value) > 3.4028235E38f128 ) { retval = 1; } @@ -11675,7 +11675,7 @@ __gg__float64_from_128( cblc_field_t *dest, // _Float128 value = *(_Float128*)(source->data+source_offset); _Float128 value; memcpy(&value, source->data+source_offset,

Re: [PATCH] Fix up some further cases of missing or extraneous spaces in diagnostics

2025-03-22 Thread Andreas Schwab
On Mär 22 2025, Jakub Jelinek wrote: > I think it must be exgettext and something in the option processing at the > same time. Yes, optc-gen.awk would need to apply the same quoting. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E78

Re: [PATCH] Fix up some further cases of missing or extraneous spaces in diagnostics

2025-03-22 Thread Andreas Schwab
an easy to make error. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] cobol: Fifteen new cobol.dg testscases.

2025-03-20 Thread Andreas Schwab
->ÿÿÿ<\-(\n|\r\n|\r)} } > +*> { dg-output { (\n|\r\n|\r)} } > +*> { dg-output {\-><\-(\n|\r\n|\r)} } > +*> { dg-output {\-><\-(\n|\r\n|\r)} } > +*> { dg-output {\->""""<\-(\n|\r\n|\r)} } > +*> { dg-output {\-><\-

Re: [PATCH] COBOL v3: 3/14 80K bld: config and build machinery

2025-03-18 Thread Andreas Schwab
On Mär 17 2025, Robert Dubner wrote: >> -Original Message- >> From: Andreas Schwab >> Sent: Monday, March 17, 2025 04:13 >> To: James K. Lowden >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH] COBOL v3: 3/14 80K bld: config and build machinery &

Re: [PATCH] cobol: Eliminate CPPFLAGS assignment from Make-lang.in [PR119213].

2025-03-17 Thread Andreas Schwab
hat reference libgcobol. > * structs.cc: Modify #includes that reference libgcobol. > * symbols.cc: Modify #includes that reference libgcobol. > * symfind.cc: Modify #includes that reference libgcobol. > * util.cc: Modify #includes that reference libgcobol. Y

Re: [PATCH] COBOL v3: 3/14 80K bld: config and build machinery

2025-03-17 Thread Andreas Schwab
On Mär 13 2025, James K. Lowden wrote: > On Tue, 11 Mar 2025 11:18:22 +0100 > Andreas Schwab wrote: > >> libgcobol/configure.tgt says it's supported on powerpc64le. > > Our intention, tell me if you disagree, is that cobol is enabled if > > 1. --enable-langu

Re: [PATCH][RFC] add -[DU]_FORTIFY_SOURCE[=n] to DW_AT_producer

2025-03-13 Thread Andreas Schwab
On Mär 13 2025, Richard Biener wrote: > The following makes sure to record -D_FORTIFY_SOURCE=n and > -U_FORTIFY_SOURCE in the DW_AT_producer debuginfo attribute when > present on the compiler command line. Should this also handle defines passed via -Wp? -- Andreas Schwab, SUSE

Re: [PATCH] Make libgcobol/configure.tgt more similar to other libraries

2025-03-11 Thread Andreas Schwab
LIBGCOBOL_SUPPORTED=yes > +x86_64-*-linux* | i?86-*-linux*) > + if test x$ac_cv_sizeof_void_p = x8; then > + LIBGCOBOL_SUPPORTED=yes > + fi I think that makes the x32 match obsolete. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 019

Re: [PATCH] COBOL v3: 3/14 80K bld: config and build machinery

2025-03-11 Thread Andreas Schwab
s_okay_host="yes" > +;; > +esac > +case "${target}" in > + x86_64-*-*) > +cobol_is_okay_target="yes" > +;; > + aarch64-*-*) > +cobol_is_okay_target="yes" > +;; > +esac libgcobol/configure.tgt says it's supported on powerpc64le. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] libstdc++: Fix gnu.ver CXXABI_1.3.16 for Solaris [PR118701]

2025-02-04 Thread Andreas Schwab
lla PR) or somebody needs to > regenerate baseline_symbols.txt for risc-v, so that there are no "new" > symbols. All other new symbols will be in GLIBCXX_3.4.34 (as required by latestp), not CXXABI_1.3.16. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1

Re: Patch held up in gcc-patches due to size

2025-02-03 Thread Andreas Schwab
pipermail/gcc-patches/2025-February/674931.html -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] libstdc++: correct symbol version of typeinfo for bfloat16_t on RISC-V

2025-01-27 Thread Andreas Schwab
wn_versions.push_back("CXXABI_IEEE128_1.3.13"); known_versions.push_back("CXXABI_TM_1"); known_versions.push_back("CXXABI_FLOAT128"); -- 2.48.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] rtl: Remove invalid compare simplification [PR117186]

2025-01-11 Thread Andreas Schwab
test::run_tests() ../../gcc/selftest-run-tests.cc:122 0xe66e2a toplev::run_self_tests() ../../gcc/toplev.cc:2267 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] AArch64: Deprecate -mabi=ilp32

2025-01-10 Thread Andreas Schwab
avoid starting a sentence with a lower case letter. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] riscv: add mising masking in lrsc expander (PR118137)

2025-01-08 Thread Andreas Schwab
Please fix your git to strip the subject prefix. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] riscv: add mising masking in lrsc expander (PR118137)

2025-01-07 Thread Andreas Schwab
; + + short h[2] = {}; + bar(h); + + if (b[1] || b[2] || b[3] || h[1]) +__builtin_abort(); +} -- 2.47.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] testsuite: enable effective-target sync_char_short on RISC-V

2025-01-07 Thread Andreas Schwab
rget arc*-*-*] && [check_effective_target_arc_atomic]) || [istarget loongarch*-*-*] +|| [istarget riscv*-*-*] || [check_effective_target_mips_llsc] }}] } -- 2.47.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE

Re: [PATCH] recog: Handle some mode-changing hardreg propagations

2025-01-02 Thread Andreas Schwab
gcc/lra.cc:2449 0xee1247 do_reload ../../gcc/ira.cc:5977 0xee1247 execute ../../gcc/ira.cc:6165 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] Fix toplevel-asm-1.c failure for riscv

2024-12-18 Thread Andreas Schwab
e toplevel-asm-1, so the failure remains. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] Fix toplevel-asm-1.c failure for riscv

2024-12-12 Thread Andreas Schwab
level-asm-1.c @@ -8,7 +8,7 @@ enum E { E0, E1 = sizeof (struct S) + 15 }; int v[42]; void foo (void) {} -asm ("# %0 %1 %2 %c3 %c4 %5 %% %=" +asm ("# %0 %1 %2 %3 %4 %5 %% %=" :: "i" (sizeof (struct S)), "i" (__builtin_offsetof (struct S, c)),

Re: [PATCH] v2: Allow limited extended asm at toplevel [PR41045]

2024-12-11 Thread Andreas Schwab
n in non-pic code. */ > +#if !defined(__i386__) && !defined(__x86_64__) > + "s" (v)); > +#else > + "m" (v)); > +asm ("# %0 %1" > + : "=m" (v[16]) > + : "m" (v[41])); > +#endif That fails on riscv64: .../

[PATCH] gcc/configure: Properly remove -O flags from C[XX]FLAGS

2024-12-04 Thread Andreas Schwab
LAGS +new_CXXFLAGS= +for flag in $CXXFLAGS; do + case $flag in + -O*) ;; + *) new_CXXFLAGS="$new_CXXFLAGS $flag" ;; + esac +done +CXXFLAGS=$new_CXXFLAGS +;; esac AC_SUBST(CFLAGS) AC_SUBST(CXXFLAGS) -- 2.47.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

m68k: don't allow o/o in movdi, movdf, movxf

2024-12-02 Thread Andreas Schwab
t;>") - (match_operand:DI 1 "general_operand" "rF,m,roi<>F"))] + [(set (match_operand:DI 0 "nonimmediate_operand" "=rm,r,&ro<>,&r<>") + (match_operand:DI 1 "general_operand" "rF,m,ri<>F,roi<>F"))] ; [(set (match_operand:DI 0 "nonimmediate_operand" "=rm,&r,&ro<>,!&rm,!&f") ; (match_operand:DI 1 "general_operand" "r,m,roi<>,fF"))] ; [(set (match_operand:DI 0 "nonimmediate_operand" "=rm,&rf,&ro<>,!&rm,!&f") -- 2.47.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] riscv: Avoid narrowing warning

2024-12-02 Thread Andreas Schwab
r *fli_value_print[32] = int riscv_float_const_rtx_index_for_fli (rtx x) { - unsigned HOST_WIDE_INT *fli_value_array; + const unsigned HOST_WIDE_INT *fli_value_array; machine_mode mode = GET_MODE (x); -- 2.47.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 B

Re: [PATCH] Fortran: fix crash with bounds check writing array section [PR117791]

2024-11-29 Thread Andreas Schwab
not handled in switch [-Werror=switch] ../../gcc/fortran/trans-io.cc:2662:24: error: enumeration value 'EXPR_PPC' not handled in switch [-Werror=switch] cc1plus: all warnings being treated as errors make[3]: *** [Makefile:1203: fortran/trans-io.o] Error 1 -- Andreas Schwab, sch...@linu

testsuite: robustify gcc.target/m68k/20100512-1.c

2024-11-21 Thread Andreas Schwab
@@ -9,8 +9,10 @@ void doTest1(void) { volatile char foo[10]; memset((void *)foo, 1, 100); + asm volatile("# %0" : : "g"(foo)); } void doTest2(void) { volatile char foo[10]; memset((void *)foo, 1, 100); + asm volatile("# %0" : : "g"(foo));

Re: [patch,avr] PR84211: Add a new post reload optimization pass

2024-11-20 Thread Andreas Schwab
make[2]: *** [../../gcc/config/avr/t-avr:65: avr-passes.o] Error 1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

testsuite: m68k: Fix tests for C23

2024-11-19 Thread Andreas Schwab
/pr63347.c @@ -2,7 +2,7 @@ /* { dg-options "-O2 -mcpu=5208 -w" } */ void __attribute__ ((noinline)) -oof() +oof(const char *s) { asm volatile ("" ::: "memory"); } -- 2.47.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9

Re: rs6000: Add -msplit-patch-nops (PR112980)

2024-11-13 Thread Andreas Schwab
NOPs for a patchable area via the > +@option{-fpatchable-function-entry} option emit the "before" NOPs in front > +of the global entry point and the "after" NOPs after the local entry point. Please use TeX quotes ``before'' and ``after''. -- Andreas Sch

Re: [gcc r15-5081] modula2: Reimplement parameter declaration and checking.

2024-11-12 Thread Andreas Schwab
of non-void function [-Werror=return-type] 544 | END DeviceError ; | ^~~ cc1gm2: some warnings being treated as errors make[5]: *** [Makefile:937: IOChan.lo] Error 1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 &quo

Re: [PATCH] middle-end: Use rtx_equal_p in notice_stack_pointer_modification_1 [PR117359]

2024-11-05 Thread Andreas Schwab
the compiler? Saying that SP is changed (when it isn't) certainly isn't the right way. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH] middle-end: Use rtx_equal_p in notice_stack_pointer_modification_1 [PR117359]

2024-11-05 Thread Andreas Schwab
On Nov 05 2024, Uros Bizjak wrote: > But what is the non-deprecated way to communicate the fact that SP > changes, and possibly clobbers stack in the asm to the compiler? Since an asm statement is not allowed to change SP there is no need for that. -- Andreas Schwab, sch...@linux-m68k.o

Re: [PATCH] RISC-V: override alignment of function/jump/loop

2024-10-25 Thread Andreas Schwab
../../gcc/config/riscv/riscv.cc:460:1: error: could not convert '{{(4 * 4), (5 \ * 4)}, {(4 * 4), (5 * 4)}, {(20 * 4), (20 * 4)}, {(4 * 4), (4 * 4)}, {(33 * 4),\ (65 * 4)}, 1, 3, 5, 8, true, false, false, false, RISCV_FUSE_NOTHING, nullptr}\ ' from '' to 'const riscv

m68k: replace reload_in_progress by reload_in_progress || lra_in_progress

2024-10-13 Thread Andreas Schwab
{ diff --git a/gcc/config/m68k/predicates.md b/gcc/config/m68k/predicates.md index 46fc3795a17..787e544a43f 100644 --- a/gcc/config/m68k/predicates.md +++ b/gcc/config/m68k/predicates.md @@ -237,6 +237,7 @@ (define_predicate "fp_src_operand" || (TARGET_68881 && (!standard_68881_constant_p (op) || reload_in_progress + || lra_in_progress || reload_completed))); }) -- 2.47.0 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v5] gcc, libcpp: Add warning switch for "#pragma once in main file" [PR89808]

2024-10-08 Thread Andreas Schwab
|^ ../../libcpp/directives.cc:2078:34: error: unknown conversion type character '>' in format [-Werror=format=] 2078 | "%<#pragma once%> in main file"); | ^ cc1plus: all warnings being treated as e

Re: [PATCH] ltmain.sh: allow more flags at link-time

2024-09-26 Thread Andreas Schwab
This has been fixed in commit d31c9cf54ac. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] ltmain.sh: allow more flags at link-time

2024-09-26 Thread Andreas Schwab
7oz.mk:48: /tmp/cc9vfAF0.ltrans23.ltrans.o] Error 1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] doc: Remove @code wrapping of fortran option names [PR116801]

2024-09-23 Thread Andreas Schwab
a different formatting), than as > "-free-line-length-". It makes it clear that there is a suffix to the > option. Whatever you feel like is the right solution, please make it constent throughout the manual. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47

Re: [committed] arc: Remove mlra option [PR113954]

2024-09-23 Thread Andreas Schwab
machine_mode mode); >arc_no_speculation_in_delay_slots_p > > #undef TARGET_LRA_P > -#define TARGET_LRA_P arc_lra_p > +#define TARGET_LRA_P hook_bool_void_true This is the default for lra_p, so you can remove the override. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key

Re: [PATCH] doc: Remove @code wrapping of fortran option names [PR116801]

2024-09-22 Thread Andreas Schwab
On Sep 22 2024, Arsen Arsenović wrote: > Andreas Schwab writes: > >> On Sep 22 2024, Jakub Jelinek wrote: >> >>> On Sun, Sep 22, 2024 at 10:52:37PM +0200, Andreas Schwab wrote: >>>> On Sep 22 2024, Mikael Morin wrote: >>>> >>>>

Re: [PATCH] doc: Remove @code wrapping of fortran option names [PR116801]

2024-09-22 Thread Andreas Schwab
On Sep 22 2024, Jakub Jelinek wrote: > On Sun, Sep 22, 2024 at 10:52:37PM +0200, Andreas Schwab wrote: >> On Sep 22 2024, Mikael Morin wrote: >> >> > @@ -370,7 +370,7 @@ Set the default accessibility of module entities to >> > @code{PRIVATE}. >> > Use-

Re: [PATCH] doc: Remove @code wrapping of fortran option names [PR116801]

2024-09-22 Thread Andreas Schwab
var{n} > +@opindex ffixed-line-length-@var{n} Shouldn't all the @var{...} parts be dropped as well, throughout? -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

[PATCH] riscv: Fix duplicate assmbler label in @tlsdesc insn

2024-09-16 Thread Andreas Schwab
(.LT%1)\;" - "jalr\tt0,t0,%%tlsdesc_call(.LT%1)"; +return ".LT%=: auipc\ta0,%%tlsdesc_hi(%0)\;" + "\tt0,%%tlsdesc_load_lo(.LT%=)(a0)\;" + "addi\ta0,a0,%%tlsdesc_add_lo(.LT%=)\;" + "jalr\tt0,t0,%%tlsdesc_call(.LT%=)&q

[PATCH] testsuite: Relax line number match in gfortran.dg/pr95690.f90

2024-09-11 Thread Andreas Schwab
actual line number is target dependent, allow any +! { dg-error "not a floating constant" "" { target *-*-* } 0 } -- 2.46.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

[PATCH] libsupc++: Fix handling of m68k extended real in

2024-09-02 Thread Andreas Schwab
__ival._M_lo); + } else if constexpr (sizeof(_Tp) == 2 * sizeof(int64_t)) { #if __SIZEOF_INT128__ -- 2.46.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

m68k: Accept ASHIFT like MULT in address operand

2024-08-27 Thread Andreas Schwab
p;& GET_CODE (XEXP (XEXP (x, 0), 0)) == REG + && GET_CODE (XEXP (XEXP (x, 0), 1)) == CONST_INT + && ((unsigned HOST_WIDE_INT) INTVAL (XEXP (XEXP (x, 0), 1)) + <= 3 { /* lea an@(dx:l:i),am */ *total = COSTS_N_INSNS (TARGET_COLDFIRE ? 2 : 3); -- 2.46.0 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v4] Extend check-function-bodies to allow label and directives

2024-08-27 Thread Andreas Schwab
+/* { dg-final { check-function-bodies "**" "" "" { target "*-*-*" } {^\t?\.} > } } */ This has a "nested" comment (line 3 missing coment end). -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: LRA: Fix setup_sp_offset

2024-08-25 Thread Andreas Schwab
On Aug 25 2024, H.J. Lu wrote: > Is it because i386 pushes the return address on stack? Like m68k. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

m68k: Add -mlra

2024-08-19 Thread Andreas Schwab
-2) mlong-jump-table-offsets UrlSuffix(gcc/M680x0-Options.html#index-mlong-jump-table-offsets) +; skipping UrlSuffix for 'mlra' due to finding no URLs + mnobitfield UrlSuffix(gcc/M680x0-Options.html#index-mnobitfield) -- 2.46.0 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fin

Re: [PATCH] Tweak base/index disambiguation in decompose_normal_address [PR116236]

2024-08-15 Thread Andreas Schwab
ryone for chasing this down. No idea where we sit with > the conversion of m68k to LRA but this looks like it'd be helpful > irrespective of that effort. With PR116236 and PR116374 the situation is looking quite well. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: Fwd: [PATCH] Don't force-enable ifuncs on RISC-V

2024-07-18 Thread Andreas Schwab
t; +enable_gnu_indirect_function=no > + fi > + rm -f conftest conftest.o conftest.s > + AC_MSG_RESULT($enable_gnu_indirect_function) > + ;; > + esac > +fi That should actually set default_gnu_indirect_function instead of enable_gnu_indirect_function, and

Re: [committed][PR rtl-optimization/115876][PR rtl-optimization/115916] Fix sign/carry bit handling in ext-dce

2024-07-16 Thread Andreas Schwab
On Jul 15 2024, Jeff Law wrote: > My change to fix a ubsan issue broke handling propagation of the > carry/sign bit down through a right shift. What about the other ASHIFTs? -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC

Re: [r15-2011 Regression] FAIL: gcc.target/i386/pr31985.c scan-assembler-times movl 4 on Linux/x86_64

2024-07-15 Thread Andreas Schwab
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115876#c7 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] [libstdc++] [testsuite] xfail 128bit from_chars on all aarch64-*-*

2024-07-11 Thread Andreas Schwab
's no good reason that float128_t wouldn't work. What are the > conditions that trigger the problem? Both tests run sucessfully on aarch64-linux. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [gcc r15-1619] ira: Scale save/restore costs of callee save registers with block frequency

2024-06-27 Thread Andreas Schwab
../../gcc/gcc/final.cc:4317 Also seen when compiling glibc. during RTL pass: final dl-lookup.c: In function 'check_match': dl-lookup.c:162:1: internal compiler error: in print_addrstyle_operand, at config/s390/s390.cc:8143 162 | } | ^ -- Andreas Schwab, SUSE Labs, sch...@suse.

Re: [PATCH] Fortran: fix passing of optional dummy as actual to optional argument [PR55978]

2024-06-24 Thread Andreas Schwab
On Jun 24 2024, Mikael Morin wrote: > tree-pretty-print.cc's op_symbol_code handles them as: > > case TRUTH_AND_EXPR: > case TRUTH_ANDIF_EXPR: > return "&&"; > > so no, I don't think they are differentiated. Only because C does

Re: [RFC v2] RISC-V: Promote Zaamo/Zalrsc to a when using an old binutils

2024-06-15 Thread Andreas Schwab
if (subset_cmp (a_subset->name, subset->name) > 0) | ~~^~~~ ../../gcc/common/config/riscv/riscv-common.cc:923:19: note: 'a_subset' was declared here 923 | riscv_subset_t *a_subset; | ^~~~ cc1plus: all warnin

Re: [Committed] RISC-V: Add basic Zaamo and Zalrsc support

2024-06-12 Thread Andreas Schwab
On Jun 12 2024, Li, Pan2 wrote: > Do we need to upgrade the binutils of the riscv-gnu-toolchain repo? Or we may > have unknown prefixed ISA extension `zaamo' when building. There needs to be a configure check if binutils can grok the extension. -- Andreas Schwab, SUSE Labs, sch...@

Re: [PATCH] jit: Ensure ssize_t is defined.

2024-06-11 Thread Andreas Schwab
On Jun 11 2024, Iain Sandoe wrote: > well, afaict, all the code is c++ and we are building with a std >= 11, so > that > presumes c99 support. The C standard does not define ssize_t at all, it is only part of POSIX. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint

Re: [PATCH] jit: Ensure ssize_t is defined.

2024-06-11 Thread Andreas Schwab
f a system header. > Oh, and the manpage says that also defines ssize_t which > is a bit odd since we already include that ... Only since POSIX.1-2008. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [to-be-committed] [RISC-V] Use Zbkb for general 64 bit constants when profitable

2024-06-07 Thread Andreas Schwab
nction 'void riscv_move_integer(rtx, rtx, long int, machine_mode)': ../../gcc/config/riscv/riscv.cc:2723:7: note: 'x' was declared here 2723 | rtx x; | ^ cc1plus: all warnings being treated as errors make[3]: *** [Makefile:2563: riscv.o] Error 1 -- Andreas Schwab, sch

Re: [NOT CODE REVIEW] [PATCH v3 1/1] [RISC-V] Add support for _Bfloat16

2024-05-14 Thread Andreas Schwab
type size: 32 status: added 2 _ZTIDF16b typeinfo for std::bfloat16_t version status: incompatible CXXABI_1.3.14 type: object type size: 16 status: added -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for some

Re: [COMMITTED] Enable prange support.

2024-05-09 Thread Andreas Schwab
graph_node*) ../../gcc/ipa-inline-analysis.cc:474 0x200d153 inline_small_functions ../../gcc/ipa-inline.cc:2081 0x200d153 ipa_inline ../../gcc/ipa-inline.cc:2850 0x200d153 execute ../../gcc/ipa-inline.cc:3248 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprin

Re: [PATCH][risc-v] libstdc++: Preserve signbit of nan when converting float to double [PR113578]

2024-05-07 Thread Andreas Schwab
On Mai 07 2024, Jonathan Wakely wrote: > +#ifdef __riscv > + return _M_insert(__builtin_copysign((double)__f, > + (double)-__builtin_signbit(__f)); Should this use static_cast? -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerpri

[PATCH] libstdc++: Update powerpc-linux-gnu baseline_symbols

2024-05-03 Thread Andreas Schwab
OBJECT:8:_ZTIDf@@CXXABI_1.3.4 -- 2.45.0 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

[PATCH] libstdc++: Update baseline symbols for riscv64-linux

2024-04-15 Thread Andreas Schwab
:_ZNKSt12__shared_ptrINSt10filesystem7__cxx114_DirELN9__gnu_cxx12_Lock_policyE1EEcvbEv@@GLIBCXX_3.4.31 FUNC:_ZNKSt12bad_weak_ptr4whatEv@@GLIBCXX_3.4.15 FUNC:_ZNKSt12future_error4whatEv@@GLIBCXX_3.4.14 FUNC:_ZNKSt12strstreambuf6pcountEv@@GLIBCXX_3.4 -- 2.44.0 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Andreas Schwab
On Apr 11 2024, Jakub Jelinek wrote: > On Thu, Apr 11, 2024 at 04:35:52PM +0200, Andreas Schwab wrote: >> +FUNC:_ZNKSt12__shared_ptrINSt10filesystem28recursive_directory_iterator10_Dir_stackELN9__gnu_cxx12_Lock_policyE1EEcvbEv@@GLIBCXX_3.4.31

Re: [PATCH] libstdc++: Regenerate trunk baseline_symbols.txt files for Linux

2024-04-11 Thread Andreas Schwab
31 +FUNC:_ZNKSt12__shared_ptrINSt10filesystem4_DirELN9__gnu_cxx12_Lock_policyE1EEcvbEv@@GLIBCXX_3.4.31 +FUNC:_ZNKSt12__shared_ptrINSt10filesystem7__cxx1128recursive_directory_iterator10_Dir_stackELN9__gnu_cxx12_Lock_policyE1EEcvbEv@@GLIBCXX_3.4.31 +FUNC:_ZNKSt12__shared_ptrINSt10filesystem7__cxx114_DirELN9__gnu_c

Re: [PATCH] libstdc++: Regenerate baseline_symbols.txt files for Linux

2024-04-11 Thread Andreas Schwab
xa_call_terminate@@CXXABI_1.3.15 FUNC:__cxa_call_unexpected@@CXXABI_1.3 FUNC:__cxa_current_exception_type@@CXXABI_1.3 FUNC:__cxa_deleted_virtual@@CXXABI_1.3.6 @@ -4566,6 +4574,7 @@ OBJECT:0:CXXABI_1.3.11 OBJECT:0:CXXABI_1.3.12 OBJECT:0:CXXABI_1.3.13 OBJECT:0:CXXABI_1.3.14 +OBJECT:0:CXXABI_1.3.15 OB

Re: [PATCH] Regenerate opt.urls

2024-04-10 Thread Andreas Schwab
On Apr 09 2024, Palmer Dabbelt wrote: > I didn't actually regenerate this as I can't figure out how, make regenerate-opt-urls -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH v2] RISC-V: Bugfix ICE for __attribute__((target("arch=+v"))

2024-03-30 Thread Andreas Schwab
riscv_subset_t *itr; | ^~~ cc1plus: all warnings being treated as errors make[3]: *** [Makefile:2563: riscv-common.o] Error 1 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH v1] RISC-V: Allow RVV intrinsic when function target("arch=+v")

2024-03-29 Thread Andreas Schwab
instead [-Werror=format-diag] 4592 | "builtin function %qE requires the V ISA extension", exp); |^~~~ cc1plus: all warnings being treated as errors make[3]: *** [../../gcc/config/riscv/t-riscv:28: riscv-vector-builtins.o] Error 1 -- Andre

Re: [PATCH] aarch64: Add +lse128 architectural extension command-line flag

2024-03-26 Thread Andreas Schwab
On Mär 15 2024, Victor Do Nascimento wrote: > \ No newline at end of file Please fix that. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."

Re: [PATCH] s390: Fix TARGET_SECONDARY_RELOAD for non-SYMBOL_REFs

2024-02-29 Thread Andreas Schwab
On Feb 29 2024, Stefan Schulze Frielinghaus wrote: > RTX X must not necessarily be a SYMBOL_REF and may e.g. be an False friend: s/must not/need not/ -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for s

[PATCH] Skip gnat.dg/div_zero.adb on RISC-V

2024-02-14 Thread Andreas Schwab
trap" { aarch64*-*-* powerpc*-*-* riscv*-*-* } } -- This test requires architecture- and OS-specific support code for unwinding -- through signal frames (typically located in *-unwind.h) to pass. Feel free -- 2.43.1 -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8

  1   2   3   4   5   6   7   8   9   10   >