Re: [PATCH] cse, v3: Fix up delete_trivially_dead_insns [PR119594]

2025-04-04 Thread Jakub Jelinek
On Fri, Apr 04, 2025 at 07:51:54PM +0200, Jakub Jelinek wrote: > On Fri, Apr 04, 2025 at 03:06:52PM +0100, Richard Sandiford wrote: > > > 2025-04-04 Jakub Jelinek > > > > > > PR rtl-optimization/119594 > > > * cse.cc (count_reg_usage): If INCR is 0, increment by 1 counts > > > of encounter

Re: [PATCH 1/4] combine: Allow 2->2 combinations, but with a tweak [PR116398]

2025-04-04 Thread Jeff Law
On 4/4/25 3:21 AM, Richard Sandiford wrote: One of the problems in PR101523 was that, after each successful 2->2 combination attempt, try_combine would restart combination attempts at i2 even if i2 hadn't changed. This led to quadratic behaviour as the same failed combinations between i2 and

Re: [PATCH RFA] ipa: target clone and mangling alias [PR114992]

2025-04-04 Thread Jan Hubicka
> On Thu, 20 Mar 2025, Jason Merrill wrote: > > > Tested x86_64-pc-linux-gnu. OK for trunk and backports? > > > > -- 8< -- > > > > Since the mangling of the second lambda changed (previously we counted all > > lambdas, now we only count lambdas with the same signature), we > > generate_mangling

[PATCH 3/3] libstdc++: Fix localized %c formatting for non-UTC times [PR117214]

2025-04-04 Thread Jonathan Wakely
The previous commit fixed most cases of %c formatting, but it incorrectly prints times using the system's local time zone. This only matters if the locale's %c format includes %Z, but some do. To print a correct value for %Z we can set tm.tm_zone to either "UTC" or the abbreviation passed to the f

Re: [PATCH] libstdc++: Fix handling of field width for wide strings and characters [PR119593]

2025-04-04 Thread Jonathan Wakely
On Thu, 3 Apr 2025 at 09:55, Tomasz Kamiński wrote: > > This patch corrects handling of UTF-32LE and UTF32-BE in > __unicode::__literal_encoding_is_unicode<_CharT>, so they are > recognized as unicode and functions produces correct result for wchar_t. > > Use `__unicode::__field_width` to compute

Re: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Sam James
Robert Dubner writes: > Anybody who might have gotten interested should stand down. Glad I could be of help ;) You had it sorted before I even got to see the first email. > > As usual, that analysis got me thinking. > > I got focused on where var_decl_return_code was being used. (I was wrong.

Re: [PATCH] c++: structural equality and partially inst typedef [PR119379]

2025-04-04 Thread Jason Merrill
On 3/21/25 3:58 PM, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? OK. -- >8 -- Complex alias templates (and their dependent specializations) use structural equality because we want to treat them as transparent in some contexts but not ot

Re: [PATCH] libstdc++: Add unreachable checks to begin/end [PR111499]

2025-04-04 Thread Andrew Pinski
On Fri, Apr 4, 2025 at 3:37 PM Andrew Pinski wrote: > > To help along cases where begin and end are passed on to another function > and then uses std::distance on them. In the case of the testcases added, > std::lexicographical_compare_three_way (for C++20). We now able to opimize > `vector < know

[pushed] c++: __FUNCTION__ in lambda return type [PR118629]

2025-04-04 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- In this testcase, the use of __FUNCTION__ is within a function parameter scope, the lambda's. And P1787 changed __func__ to live in the parameter scope. But [basic.scope.pdecl] says that the point of declaration of __func__ is immediately

[PATCH] c++: Rename -fmodules-ts to -fmodules in diagnostics

2025-04-04 Thread Nathaniel Shead
Tested on x86_64-pc-linux-gnu, OK for trunk if full bootstrap + regtest succeeds? -- >8 -- This replaces some usages of the old -fmodules-ts flag with the new -fmodules flag made in r15-5112-gd9c3c3c85665b2. gcc/cp/ChangeLog: * parser.cc (cp_parser_diagnose_invalid_type_name): Replace

Re: [PATCH] wwwdocs: Clarify DCO name/identity and (anonymous) pseudonym policy

2025-04-04 Thread Sam James
NightStrike writes: > How is an online only name different from an anonymous pseudonym? It doesn’t > seem to me that your changes actually > clarify anything. To me, they make it more ambiguous. The idea is to not have something throwaway (please also don't toppost).

Re: [PATCH] gcc-gitref.cgi: Redirect to cgit instead of gitweb

2025-04-04 Thread Mark Wielaard
Hi Gerald, (Adding Arsen to CC, see below) On Sat, Apr 05, 2025 at 12:02:44AM +0200, Gerald Pfeifer wrote: > On Fri, 4 Apr 2025, Mark Wielaard wrote: > > So I really don't have time to rewrite this to use some other cgi > > mechanism. Would you mind if we go with the current version? > > Apologi

Re: [RFC] [C]New syntax for the argument of counted_by attribute for C language

2025-04-04 Thread Bill Wendling
On Thu, Apr 3, 2025 at 9:54 AM Kees Cook wrote: > On Wed, Apr 02, 2025 at 09:16:47PM +, Qing Zhao wrote: > > Hi, Bill, > > > > Thanks for the summary. > > > > I think that this is good. > > > > Two more questions: > > > > 1. Shall we keep the same name of the attribute counted_by for the 2nd n

Re: [PATCH] rtlanal, i386: Adjust pattern_cost and x86 constant cost [PR115910]

2025-04-04 Thread Richard Biener
> Am 02.04.2025 um 18:31 schrieb Jakub Jelinek : > > Hi! > > Below is an attempt to fix up RTX costing P1 caused by r15-775 > https://gcc.gnu.org/pipermail/gcc-patches/2024-May/thread.html#652446 > @@ -21562,7 +21562,8 @@ ix86_rtx_costs (rtx x, machine_mode mode, int > outer_code_i, int opno

Re: [PATCH] toplevel, Makefile: Add missing CXX_FOR_TARGET export [PR88319].

2025-04-04 Thread Jeff Law
On 3/23/25 2:13 PM, Iain Sandoe wrote: do you think it’s worth backporting (after some bake time)? Feels pretty marginal to me, but I wouldn't object if you want to. jeff

Re: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Simon Sobisch
Nice that you have that covered, and thanks for sharing your way there. I just want to offer an additional thing to consider: different environments have a different byte-size for the return code (most common on COBOL for PC is 4, but 2 and 8 also exist). Micro Focus COBOL and GnuCOBOL have a

[PATCH 1/2] c++: maybe_dependent_member_ref and stripped alias [PR118626]

2025-04-04 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? This isn't a regression and potentially impacts C++17 code, but it also makes alias CTAD unusable for our std::variant currently. -- >8 -- Here during maybe_dependent_member_ref (as part of CTAD rewriting for the var

Re: [PATCH 06/10] testsuite: aarch64: arm: Add -mfpu=auto to arm_v8_2a_bf16_neon_ok

2025-04-04 Thread Christophe Lyon
On Fri, 21 Mar 2025 at 11:18, Richard Earnshaw (lists) wrote: > > On 20/03/2025 16:15, Christophe Lyon wrote: > > Depending on if/how the testing flags are overridden, the first value > > we try("") might not do what we want. > > > > For instance, if the whole testsuite is executed with > > (A) -m

Re: [PATCH] tree-optimization/119532 - ICE with fixed-point tail recursion

2025-04-04 Thread Richard Biener
On Mon, 31 Mar 2025, Jakub Jelinek wrote: > On Mon, Mar 31, 2025 at 11:12:45AM +0200, Richard Biener wrote: > > The following disables tail recursion optimization when fixed-point > > types are involved as we cannot generate -1 for all fixed-point > > types. > > > > Bootstrapped and tested on x86

Re: [PATCH] libstdc++: Replace use of __mindist in ranges::uninitialized_xxx algos [PR101587]

2025-04-04 Thread Jonathan Wakely
On Fri, 4 Apr 2025 at 10:56, Jonathan Wakely wrote: > > On Fri, 4 Apr 2025 at 10:32, Tomasz Kaminski wrote: > > > > > > > > On Fri, Apr 4, 2025 at 11:10 AM Jonathan Wakely wrote: > >> > >> In r15-8980-gf4b6acfc36fb1f I introduced a new function object for > >> finding the smaller of two distance

[committed] cobol: Set compile-time and run-time signable_e bits the same

2025-04-04 Thread Robert Dubner
>From 6602fc076a883cf0cd20a37655a6bd9c146a2770 Mon Sep 17 00:00:00 2001 From: Bob Dubner Date: Fri, 4 Apr 2025 18:33:42 -0400 Subject: [PATCH] cobol: Set compile-time and run-time signable_e bits the same for RETURN-CODE. This fix reverts the recent cobol_langhook_post_options change setting fla

Re: [PATCH] wwwdocs: Clarify DCO name/identity and (anonymous) pseudonym policy

2025-04-04 Thread Mark Wielaard
Hi NightStrike, On Fri, Apr 04, 2025 at 05:42:03PM -0400, NightStrike wrote: > How is an online only name different from an anonymous pseudonym? It > doesn’t seem to me that your changes actually clarify anything. To me, they > make it more ambiguous. The difference is intent. An established (onl

Subject: [PATCH] cobol: gcobc wrapper fixes and additions

2025-04-04 Thread Simon Sobisch
Note: the check_GNU_style.sh script raises several errors - but it would raise them on the complete script, so I've opted to stay with its style. Side-note: Using this updated wrapper allows to runt the NIST test runner from a configured GnuCOBOL source tree using make  COBC=/usr/local/gcobol-d

[PATCH] libstdc++: Add unreachable checks to begin/end [PR111499]

2025-04-04 Thread Andrew Pinski
To help along cases where begin and end are passed on to another function and then uses std::distance on them. In the case of the testcases added, std::lexicographical_compare_three_way (for C++20). We now able to opimize `vector < known empty vector` to a constant where before we would need to loa

[PATCH] libstdc++: Add unreachable checks to begin/end [PR111499]

2025-04-04 Thread Andrew Pinski
To help along cases where begin and end are passed on to another function and then uses std::distance on them. In the case of the testcases added, std::lexicographical_compare_three_way (for C++20). We now able to opimize `vector < known empty vector` to a constant where before we would need to loa

[COMMITTED 035/146] gccrs: Fixes some tests appearing with a moved variant

2025-04-04 Thread arthur . cohen
From: Pierre-Emmanuel Patry A variant being moved lead to a null being created and a segfault later down the line. gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::visit): Call getter instead of size function. * checks/errors/privacy/rust-privacy-reporter

Re: [PATCH] gcc-gitref.cgi: Redirect to cgit instead of gitweb

2025-04-04 Thread Gerald Pfeifer
On Fri, 4 Apr 2025, Mark Wielaard wrote: >>> Might there be a way to do that on the server side (via .htaccess or some >>> other configuration)? >> There might be, but it has been more than a decade since I hacked on >> cgi scripts. I am not sure I can reliably rewrite this one to use some >> othe

RE: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Robert Dubner
Anybody who might have gotten interested should stand down. As usual, that analysis got me thinking. I got focused on where var_decl_return_code was being used. (I was wrong. I made the mistake because I had just eliminated two sets of errors caused by the optimization actually optimizing away t

Re: [PATCH 2/2] [cobol] make sources coretypes.h and tree.h clean

2025-04-04 Thread James K. Lowden
On Thu, 20 Mar 2025 10:06:20 +0100 (CET) Richard Biener wrote: > > I just want to put all 3 hands on the table, and make sure we all > > understand why we're doing this, if we are, and what it will entail > > if we do. I'm sure you feel the same. > > Sure! So let me explain the advantage I

Re: [PATCH] wwwdocs: Clarify DCO name/identity and (anonymous) pseudonym policy

2025-04-04 Thread NightStrike
How is an online only name different from an anonymous pseudonym? It doesn’t seem to me that your changes actually clarify anything. To me, they make it more ambiguous. On Sun, Mar 30, 2025 at 09:47 Mark Wielaard wrote: > Ping again. Are there any other clarifications you like to see added? > >

Re: [pushed] c++: lambda in requires outside template [PR99546]

2025-04-04 Thread Patrick Palka
On Fri, 4 Apr 2025, Jason Merrill wrote: > On 4/4/25 4:35 PM, Patrick Palka wrote: > > On Fri, 4 Apr 2025, Jason Merrill wrote: > > > > > Tested x86_64-pc-linux-gnu, applying to trunk. > > > > > > -- 8< -- > > > > > > Since r10-7441 we set processing_template_decl in a requires-expression so >

Re: [PATCH] RISC-V: Add support for Zalasr extension

2025-04-04 Thread Andrea Parri
> @@ -54,8 +54,13 @@ (define_insn "atomic_load_ztso" > if (model == MEMMODEL_SEQ_CST) >return "fence\trw,rw\;" >"\t%0,%1"; > -else > - return "\t%0,%1"; > + > +/* Ignoring RCsc atomic load-acquire on MEMMODEL_SEQ_CST due to > + Note 3 abi break. */ > +

[PATCH v2] c++: fix missing lifetime extension [PR119383]

2025-04-04 Thread Marek Polacek
On Thu, Mar 27, 2025 at 11:27:04AM -0400, Jason Merrill wrote: > On 3/25/25 3:37 PM, Marek Polacek wrote: > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk/14? > > > > -- >8 -- > > Since r15-8011 cp_build_indirect_ref_1 won't do the *&TARGET_EXPR -> > > TARGET_EXPR folding not to cha

Re: [PATCH] libstdc++: Constrain formatters for chrono types [PR119517]

2025-04-04 Thread Jonathan Wakely
On 28/03/25 16:31 +0100, Tomasz Kamiński wrote: The formatters for chrono types defined the parse/format methods as accepting unconstrained types, this in combination with lack of constrain on _CharT lead to them falsy statisfying formattable requirements for any type used as character. This pat

[COMMITTED 32/35] gccrs: FIX ICE for malformed repr attribute

2025-04-04 Thread arthur . cohen
From: Philip Herron Fixes Rust-GCC#3614 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-base.cc (TypeCheckBase::parse_repr_options): check for input gcc/testsuite/ChangeLog: * rust/compile/issue-3614.rs: New test. Signed-off-by: Philip Herron --- gcc/rust/typecheck/rus

Re: [PATCH] tailc: Deal with trivially useless EH cleanups [PR119491]

2025-04-04 Thread Richard Biener
> Am 02.04.2025 um 18:10 schrieb Jakub Jelinek : > > Hi! > > The following testcases FAIL, because EH cleanup is performed only before > IPA and then right before musttail pass. > At -O2 etc. (except for -O0/-Og) we handle musttail calls in the tailc > pass though, and we can fail at that poi

Re: [PATCH] config, toplevel, Darwin: Pass -B instead of -L to C++ commands.

2025-04-04 Thread Richard Biener
On Tue, Apr 1, 2025 at 9:26 AM Iain Sandoe wrote: > > Another misconfigure (Darwin-only) found by a combination of increases > in system security contraints and the COBOL runtime. We will now fail > any C++ configure test that needs the binary to run. > > Tested on x86_64-darwin17,21,24 and on x8

Re: [PATCH] sra: Avoid creating TBAA hazards (PR118924)

2025-04-04 Thread Richard Biener
On Thu, 3 Apr 2025, Jan Hubicka wrote: > > On Mon, 31 Mar 2025, Martin Jambor wrote: > > > > > Hi, > > > > > > the testcase in PR 118924, when compiled on Aarch64, contains an > > > gimple aggregate assignment statement in between different types which > > > are types_compatible_p but behave dif

Re: [pushed] c++: lambda in requires outside template [PR99546]

2025-04-04 Thread Jason Merrill
On 4/4/25 4:35 PM, Patrick Palka wrote: On Fri, 4 Apr 2025, Jason Merrill wrote: Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- Since r10-7441 we set processing_template_decl in a requires-expression so that we can use tsubst_expr to evaluate the requirements, but that confuses lambd

[PATCH] Put early debug generation under TV_SYMOUT

2025-04-04 Thread Richard Biener
Like all other debug info generation this should be with TV_SYMOUT, otherwise it's recorded as TV_CGRAPH. Bootstrap and regtest running on x86_64-unknown-linux-gnu, will push tomorrow. * cgraphunit.cc (symbol_table::finalize_compilation_unit): Put early debug generation under TV_S

Re: [PATCH] c++: harmless use of 'this' rejected despite P2280R4 [PR118249]

2025-04-04 Thread Jason Merrill
On 4/4/25 12:11 PM, Patrick Palka wrote: Here the implicit use of 'this' in inner.size() template argument was being rejected despite P2280R4 relaxations, due to the special *this handling in the INDIRECT_REF case of potential_constant_expression_1. This handling was originally added by r196737

Re: [pushed] c++: lambda in requires outside template [PR99546]

2025-04-04 Thread Patrick Palka
On Fri, 4 Apr 2025, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu, applying to trunk. > > -- 8< -- > > Since r10-7441 we set processing_template_decl in a requires-expression so > that we can use tsubst_expr to evaluate the requirements, but that confuses > lambdas terribly; begin_lambda_typ

[COMMITTED 121/146] gccrs: ast: Fix warning about copy elision for moved expr

2025-04-04 Thread arthur . cohen
From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-ast.cc (BlockExpr::normalize_tail_expr): Remove overzealous std::move --- gcc/rust/ast/rust-ast.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/rust/ast/rust-ast.cc b/gcc/rust/ast/rust-ast.cc index 25e5

cobol: [committed] More testcases

2025-04-04 Thread Robert Dubner
commit 13fb7a39f5dc037e95420ad86e89f99e622d7259 Author: Bob Dubner Date: Fri Apr 4 14:41:27 2025 -0400 cobol: New testcases. Derived from cobolworx UAT run_functions.at. gcc/testsuite * cobol.dg/group2/call_subprogram_using_pointer__passing_pointer.cob: New testcase.

[PATCH] toplevel, libcobol: Add dependency on libquadmath build [PR119244].

2025-04-04 Thread Iain Sandoe
Tested on x86_64, aarch64-linux and x86_64-darwin, verified that there is no change in the libquadmath build on the platforms that do not need it. OK for trunk? thanks Iain --- 8< --- For the configuration of libgcobol to be correct for targets that need to use libquadmath for 128b FP support, w

RE: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Robert Dubner
> -Original Message- > From: Sam James > Sent: Friday, April 4, 2025 14:28 > To: Robert Dubner > Cc: 'GCC Patches' > Subject: Re: [committed] cobol: Eliminate cobolworx UAT errors when > compiling with -Os

[PATCH] tailc: Deal with trivially useless EH cleanups [PR119491]

2025-04-04 Thread Jakub Jelinek
Hi! The following testcases FAIL, because EH cleanup is performed only before IPA and then right before musttail pass. At -O2 etc. (except for -O0/-Og) we handle musttail calls in the tailc pass though, and we can fail at that point because the calls might appear to throw internal exceptions which

[PATCH] tree-optimization/119532 - ICE with fixed-point tail recursion

2025-04-04 Thread Richard Biener
The following disables tail recursion optimization when fixed-point types are involved as we cannot generate -1 for all fixed-point types. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK? Thanks, Richard. PR tree-optimization/119532 * tree-tailcall.cc (process_assignment

[PATCH] c++: constraint variable used in evaluated context [PR117849]

2025-04-04 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk/14? -- >8 -- Here we wrongly reject the requires-expression requirement at parse time due to the use of the constraint variable 't' within a template argument (an evaluated context). Fix this simply by refining the "u

Re: [RFC] [C]New syntax for the argument of counted_by attribute for C language

2025-04-04 Thread Qing Zhao
> On Apr 4, 2025, at 13:09, Martin Uecker wrote: > > Am Freitag, dem 04.04.2025 um 18:51 +0200 schrieb Michael Matz: >> Hello, >> >> On Fri, 4 Apr 2025, Qing Zhao wrote: >> >>> So, a different attribute name “counted_by_exp” might be better? >> >> I would prefer Martins empty-decl idea to th

[pushed] c++: lambda in requires outside template [PR99546]

2025-04-04 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- Since r10-7441 we set processing_template_decl in a requires-expression so that we can use tsubst_expr to evaluate the requirements, but that confuses lambdas terribly; begin_lambda_type silently returns error_mark_node and we continue into

Re: [PATCH] PR middle-end/119442: expr.cc: Fix vec_duplicate into vector boolean modes

2025-04-04 Thread Richard Biener
On Mon, Mar 31, 2025 at 3:07 PM Mark Wielaard wrote: > > On Mon, 2025-03-31 at 09:12 +, Kyrylo Tkachov wrote: > > > > > On 31 Mar 2025, at 09:43, Richard Biener > > > wrote: > > > > > > On Mon, Mar 31, 2025 at 9:41 AM Richard Biener > > > wrote: > > > > > > > > On Mon, Mar 31, 2025 at 9:36 

[PATCH] libstdc++: Make operator== for std::tuple convert to bool [PR119545]

2025-04-04 Thread Jonathan Wakely
The boolean-testable requirements don't require the type to be copyable, so we need to convert to bool before it might need to be copied. libstdc++-v3/ChangeLog: PR libstdc++/119545 * include/std/tuple (operator==): Convert comparison results to bool. * testsuite/2

RE: [PATCH][RFC] [cobol] change cbl_field_data_t::etc_t::value from _Float128 to tree

2025-04-04 Thread Robert Dubner
> -Original Message- > From: Richard Biener > Sent: Thursday, March 20, 2025 10:16 > To: gcc-patches@gcc.gnu.org > Cc: Jakub Jelinek ; rdub...@symas.com > Subject: Re: [PATCH][RFC] [cobol] change cbl_field_data_t::etc_t::value > from _Float128 to tree > > On Thu, 20 Mar 2025, Richard B

Re: [PATCH] combine: Allow 2->2 combos but limit insn searches [PR116398]

2025-04-04 Thread Richard Sandiford
Richard Biener writes: > On Tue, 1 Apr 2025, Richard Sandiford wrote: > >> The problem in PR101523 was that, after each successful 2->2 >> combination attempt, distribute_links would search further and >> further for the next combinable use of the i2 destination. >> The original patch for the PR d

[COMMITTED 072/146] gccrs: hir: Start adapting visitors to accept multiple kinds of Paths

2025-04-04 Thread arthur . cohen
From: Arthur Cohen gcc/rust/ChangeLog: * ast/rust-item.h: Add new method to specifically get a type-path. * ast/rust-path.cc (LangItemPath::as_string): Implement properly. * hir/rust-ast-lower-type.cc (ASTLowerTypePath::translate): Adapt visitor to use the new Lan

Re: [PATCH] gcc-gitref.cgi: Redirect to cgit instead of gitweb

2025-04-04 Thread Mark Wielaard
Hi Gerald, On Mon, 2025-03-31 at 15:27 +0200, Gerald Pfeifer wrote: > > - echo 'https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h='$ret'">' > > + echo 'https://gcc.gnu.org/cgit/gcc/commit/?id='$ret'">' > > Might there be a way to do that on the server side (via .htaccess or some > other configura

[PATCH] c++: Honor noipa attribute for FE nothrow discovery [PR119518]

2025-04-04 Thread Jakub Jelinek
Hi! The following testcase has different code generation in bar depending on whether foo is defined or just declared. That is undesirable when it has noipa attribute, that attribute is documented to be a black box between caller and callee, so the caller shouldn't know about any implicitly determi

[committed] MAINTAINERS: Add myself

2025-04-04 Thread James K. Lowden
Below is the output of my first use (believe it or not) of "git format-patch". I'm not sure of the significance of the first date, 6 days after the attack on the World Trade Center. I hope the rest is both obvious and correct. >From eda74cd05447475d385b8a8216e3412da96a46da Mon Sep 17 00:00:00

[COMMITTED 055/144] gccrs: Added noreturn checking for nevertype, new test

2025-04-04 Thread arthur . cohen
From: badumbatish gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Added noreturn checking for nevertype gcc/testsuite/ChangeLog: * rust/compile/inline_asm_typecheck.rs: New test. --- .../typecheck/rust-hir-type-check-expr.cc | 18

Re: [PATCH v2 1/3] libstdc++: Use formatting locale for std::time_put formats

2025-04-04 Thread Jonathan Wakely
On Fri, 21 Mar 2025 at 09:47, Tomasz Kaminski wrote: > > > > On Thu, Mar 20, 2025 at 5:29 PM Jonathan Wakely wrote: >> >> On Thu, 20 Mar 2025 at 16:16, Jonathan Wakely wrote: >> > >> > When using std::time_put to format a chrono value, we should imbue the >> > formatting locale into the stream.

RE: [PATCH 2/2] [cobol] make sources coretypes.h and tree.h clean

2025-04-04 Thread Robert Dubner
Yes. Back in about 75 minutes. > -Original Message- > From: Jakub Jelinek > Sent: Wednesday, March 19, 2025 13:18 > To: Robert Dubner > Cc: Richard Biener ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH 2/2] [cobol] make sources coretypes.h and tree.h clean > > On Wed, Mar 19, 2025 at 1

RE: [PATCH][RFC] [cobol] change cbl_field_data_t::etc_t::value from _Float128 to tree

2025-04-04 Thread Robert Dubner
It's time to slow down a bit and give me a chance to catch up. First, all those tests are not arbitrary. I was getting the correct answers before, and it was not an insignificant effort to get them correct in the first place. If we don't get the same answers, then something isn't the same as it

[COMMITTED 017/144] gccrs: Add location to BIR::Statement of kind RETURN

2025-04-04 Thread arthur . cohen
From: Kushal Pal This commit adds location_t to BIR::Statement where type is RETURN. gcc/rust/ChangeLog: * checks/errors/borrowck/rust-bir-builder-expr-stmt.cc (ExprStmtBuilder::visit): Add location parameter. * checks/errors/borrowck/rust-bir-builder.h: Likewise.

[COMMITTED 18/35] gccrs: Fix ICE when compiling block expressions in array capacity

2025-04-04 Thread arthur . cohen
From: Philip Herron We need to reuse the existing compile_constant_item helper which handles the case if this is a simple expression, fn-call or a block expression. The patch extracts out this helper as a static method so this can be used in more places. Fixes Rust-GCC#3566 gcc/rust/ChangeLog:

[committed] d: Bump front-end language version to v2.111.0

2025-04-04 Thread Iain Buclaw
Hi, This patch merges the front-end language implementation and runtime library with upstream dmd c6863be720, and the standard library with phobos 60034b56e. Synchronizing with the upstream release of v2.111.0. Bootstrapped and regression tested on x86_64-linux-gnu/-m32, and committed to mainlin

Re: [RFC] [C]New syntax for the argument of counted_by attribute for C language

2025-04-04 Thread Qing Zhao
> On Apr 4, 2025, at 12:51, Michael Matz wrote: > > Hello, > > On Fri, 4 Apr 2025, Qing Zhao wrote: > >> So, a different attribute name “counted_by_exp” might be better? > > I would prefer Martins empty-decl idea to that: "counted_by(;len+0)" > (looks up 'len' normally, i.e. doesn't look in

Re: [PATCH 2/2] GCN: Don't emit weak undefined symbols [PR119369]

2025-04-04 Thread Andrew Stubbs
On 31/03/2025 10:48, Thomas Schwinge wrote: This resolves all instances of PR119369 "GCN: weak undefined symbols -> execution test FAIL, 'HSA_STATUS_ERROR_VARIABLE_UNDEFINED'"; for all affected test cases, the execution test status progresses FAIL -> PASS. This however also causes a small numbe

[COMMITTED 040/144] gccrs: Make sure CompileExpr::visit is reached

2025-04-04 Thread arthur . cohen
From: jjasmine gcc/rust/ChangeLog: * hir/tree/rust-hir.cc (InlineAsm::accept_vis): Make sure CompileExpr::visit is reached * typecheck/rust-hir-type-check-expr.cc (TypeCheckExpr::visit): Likewise gcc/testsuite/ChangeLog: * rust/compile/inline_asm_compile_

[COMMITTED 108/146] gccrs: rust/intrinsic: add try intrinsic and panic strategy options

2025-04-04 Thread arthur . cohen
From: liushuyu gcc/rust/ChangeLog: * backend/rust-compile-intrinsic.cc: add `try` intrinsic handler. * lang.opt: add `-frust-panic` option. * rust-lang.cc: enable exception handler code generation. * rust-session-manager.cc: add getter and setter for panic

Re: [RFC] [C]New syntax for the argument of counted_by attribute for C language

2025-04-04 Thread Qing Zhao
> On Apr 4, 2025, at 12:40, Jakub Jelinek wrote: > > On Fri, Apr 04, 2025 at 04:25:11PM +, Qing Zhao wrote: >>> It is not just the parser, it is also the human reader who should be >>> able to clearly distinguish this (which is why I still prefer >>> designators syntax because this makes it

[COMMITTED 140/146] gccrs: derive(Clone): Improve existing testcase

2025-04-04 Thread arthur . cohen
From: Arthur Cohen gcc/testsuite/ChangeLog: * rust/compile/derive_macro4.rs: Mark Copy and Clone as lang items. --- gcc/testsuite/rust/compile/derive_macro4.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/testsuite/rust/compile/derive_macro4.rs b/gcc/testsuite/rust/compil

[COMMITTED 009/144] gccrs: Fix the parser's operand and flags storage

2025-04-04 Thread arthur . cohen
From: badumbatish gcc/rust/ChangeLog: * ast/rust-expr.h (struct InlineAsmOperand): Add construction for register_type * expand/rust-macro-builtins-asm.cc (parse_reg_operand): Fix parsing logic & reassignment logic (parse_reg_operand_in): Fix parsing

Re: [PATCH] cobol: Do not overload int64_t, overload long and long long.

2025-04-04 Thread NightStrike
On Thu, Mar 20, 2025 at 15:41 Iain Sandoe wrote: > > > > On 20 Mar 2025, at 19:28, Robert Dubner wrote: > > > > Although I am confused about how _int64_t can be anything but a 64-bit > > signed integer, and because it is my understanding that long and long > long > > really *do* change from plat

Re: [PATCH] libstdc++: Add P1206R7 range operations to std::deque [PR111055]

2025-04-04 Thread Jonathan Wakely
On Fri, 21 Mar 2025 at 14:31, Tomasz Kaminski wrote: > > > > On Fri, Mar 21, 2025 at 11:14 AM Tomasz Kamiński wrote: >> >> This is another piece of P1206R7, adding from_range constructor, >> append_range, >> prepend_range, insert_range, and assign_range members to std::deque. >> >> For insert_ra

Re: [PATCH] toplevel, Makefile: Add missing CXX_FOR_TARGET export [PR88319].

2025-04-04 Thread Jeff Law
On 3/23/25 8:03 AM, Iain Sandoe wrote: Tested on x86_64-Linux, Darwin, OK for trunk? backports? thanks Iain --- 8< --- Actually, the issue is not local to the libitm case, it currently affects any 'cxx=true' top-level configured target library. The issue is a missing export of CXX_FOR_TARGE

Re: [PATCH 1/8] aarch64: Use PAUTH instead of V8_3A in some places

2025-04-04 Thread Richard Sandiford
Alfie Richards writes: > Hi Richard, > > Is this backport okay for GCC 14 as well? > (It applies cleanly for 14 but patch for 12 and 13 required a minor edit) Yeah, OK for GCC 14, thanks. Richard > > Alfie > > On 20/03/2025 14:05, Alfie Richards wrote: >> Hi all, >> >> This commit applies clea

[committed] libphobos: Add module declaration to rt.invariant

2025-04-04 Thread Iain Buclaw
Hi, This patch adds a module declaration to the rt/invariant.d module, preventing conflicts with a user-provided `invariant.d' module. Bootstrapped and regression tested on x86_64-linux-gnu/-m32, and committed to mainline. Regards, Iain. --- gcc/d/ChangeLog: * runtime.def (INVARIANT):

Re: [PATCH 03/10] testsuite: aarch64: restore torture options in bf16_dup.c

2025-04-04 Thread Richard Earnshaw (lists)
On 20/03/2025 16:15, Christophe Lyon wrote: > Remove dg-options, so that the test is executed as expected using the > options defined by advsimd-intrinsics.exp. > (Previously we pretend we do, but in fact all torture options are > silently overriden with -O2) > > We skip it at -O0, because the tes

[COMMITTED 002/144] gccrs: Add rustc test directory for testsuite adaptor

2025-04-04 Thread arthur . cohen
From: Muhammad Mahad gcc/testsuite/ChangeLog: * rust/rustc/README.md: information about rustc external directory. * rust/rustc/rustc.exp: New test. Signed-off-by: Muhammad Mahad --- gcc/testsuite/rust/rustc/README.md | 4 gcc/testsuite/rust/rustc/rustc.exp | 35 +

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-04 Thread Hongtao Liu
On Mon, Mar 31, 2025 at 9:52 PM Richard Biener wrote: > > On Mon, 31 Mar 2025, Jakub Jelinek wrote: > > > On Mon, Mar 31, 2025 at 03:33:34PM +0200, Richard Biener wrote: > > > On Mon, 31 Mar 2025, Jakub Jelinek wrote: > > > > > > > On Mon, Mar 31, 2025 at 03:12:56PM +0200, Richard Biener wrote: >

Re: [PATCH] testsuite: i386: Fix gcc.target/i386/pr82142?.c etc. on Solaris/x86

2025-04-04 Thread Rainer Orth
Ping? It's been a week: https://gcc.gnu.org/pipermail/gcc-patches/2025-March/679330.html > Three tests FAIL on Solaris/x86 in similar ways: > > FAIL: gcc.target/i386/pr111673.c check-function-bodies advance > FAIL: gcc.target/i386/pr82142a.c check-function-bodies assignzero > FAIL: gcc.t

[COMMITTED 077/144] gccrs: Implement initial pattern analysis pass.

2025-04-04 Thread arthur . cohen
From: Raiki Tamura gcc/rust/ChangeLog: * Make-lang.in: Add rust-hir-pattern-analysis.o. * rust-session-manager.cc (Session::compile_crate): Add pattern analysis pass. * typecheck/rust-hir-type-check-pattern.cc (TypeCheckPattern::visit): Do

Re: [PATCH] lto: lto-opts fixes [PR119625]

2025-04-04 Thread Jakub Jelinek
On Fri, Apr 04, 2025 at 08:52:10PM +0200, Richard Biener wrote: > > Or do you want something further (like > > switch (global_options.x_flag_cf_protection & ~CF_SET) > > )? > > Dunno what that CF_SET is, we’re supposed to record options like the user > specified so we can merge them. Why does th

Re: [PATCH] [cobol] move global data to symbol_table_init

2025-04-04 Thread Richard Biener
On Thu, 20 Mar 2025, Richard Biener wrote: > The following avoids early runtime initialization of cbl_field_t > objects which, when using tree to represent the current _Float128 > data, segfaults as tree data like float128_type_node is not yet > initialized. The solution is to move the global dat

Re: [PATCH v2] libgcobol: C++-ify the configuration steps.

2025-04-04 Thread Richard Biener
> Am 04.04.2025 um 17:19 schrieb Iain Sandoe : > > Nightstrike kindly made an initial review of this patch (offlist) and > pointed out a few things. This, thus, is version 2 - it does not change > in basic mechanism but is even shorter. > > This is blocking some already-approved patches and t

Re: [PATCH 2/2] cobol: use ldirname in cdf-copy.cc

2025-04-04 Thread Richard Biener
On Mon, Mar 17, 2025 at 7:45 PM Jose E. Marchesi wrote: > > This patch changes gcc/cobol/cdf-copy.cc to use the new ldirname from > libibertay rather than the host's dirname. This removes an include > for libgen.h. > > Regtested in x86_64-linux-gnu by running make check-cobol. OK to both patches

Re: [PATCH v2] RISC-V: vsetvl: skip abnormal edge on vsetvl insertion [PR119533]

2025-04-04 Thread Heinrich Schuchardt
On 3/30/25 01:49, Vineet Gupta wrote: changes since v2 - dump log sanfu --- vsetvl phase4 uses LCM guided info to insert VSETVL insns. It has an additional loop to insert missing vsetvls on certain edges. Currently it asserts/aborts on encountering EDGE_ABNORMAL. When enabling go frontend with

[COMMITTED 21/35] gccrs: Give the builtin unit struct an actual locus

2025-04-04 Thread arthur . cohen
From: Philip Herron This has been a pet peeve of mine for a while because the gimple never emitted the struct () name properly it was always empty which for record types they always require a real locus or they dont get a proper name. gcc/rust/ChangeLog: * backend/rust-compile-base.cc (

Re: Please Ignore -- testing email

2025-04-04 Thread Matthew Malcomson
One more time -- trying to figure out email difficulties. On 2/5/25 08:41, Matthew Malcomson wrote: Again -- apologies for the noise On 1/22/25 16:16, Matthew Malcomson wrote: *External email: Use caution opening links or attachments* Apologies for the noise.

[PATCH 2/2] arm: select CCFPEmode for LTGT [PR91323]

2025-04-04 Thread Richard Earnshaw
Besides Arm, there are three other ports that define both CCFPmode and CCFPEmode. AArch64 and Sparc return CCFPEmode for LTGT; the other, Visium, doesn't support LTGT at all. AArch64 was changed in r8-5286-g8332c5ee8c5f3b, and Sparc with r10-2926-g000a5f8d23c04c. I suspect this issue is latent o

[PATCH] testsuite: arm: Fix dg-final in short-vfp-1.c [PR119556]

2025-04-04 Thread Christophe Lyon
Recent syntactic fixes enabled the test, but the result was failing. It turns out it was missing a space between the register arguments in the scan-assembler-times directives. gcc/testsuite/ChangeLog: PR target/119556 * gcc.target/arm/short-vfp-1.c: Add missing spaces. --- gcc/t

Re: [RFC] [C]New syntax for the argument of counted_by attribute for C language

2025-04-04 Thread Bill Wendling
On Fri, Apr 4, 2025 at 10:09 AM Martin Uecker wrote: > > Am Freitag, dem 04.04.2025 um 18:51 +0200 schrieb Michael Matz: > > Hello, > > > > On Fri, 4 Apr 2025, Qing Zhao wrote: > > > > > So, a different attribute name “counted_by_exp” might be better? > > > > I would prefer Martins empty-decl idea

Re: [PATCH] lto: lto-opts fixes [PR119625]

2025-04-04 Thread Richard Biener
> Am 04.04.2025 um 19:50 schrieb Jakub Jelinek : > > Hi! > > I can reproduce a really weird error in our distro i686 trunk gcc > (but haven't managed to reproduce it with vanilla trunk yet). > echo 'void foo (void) {}' > a.c; gcc -O2 -flto=auto -m32 -march=i686 > -ffat-lto-objects -fhardened

Re: [PATCH] target/119549 - fixup handling of -mno-sse4

2025-04-04 Thread Jakub Jelinek
On Mon, Mar 31, 2025 at 03:51:26PM +0200, Richard Biener wrote: > options entry. Or whether that means ix86_valid_target_attribute_inner_p > should have created OPT_mno_sse4 from -mno-sse4. Or OPT_msse4_1 with value 0. Whatever. I think your patch with keeping OPT_mno_sse4 unmodified (it could

Re: [PATCH] PR middle-end/119442: expr.cc: Fix vec_duplicate into vector boolean modes

2025-04-04 Thread Richard Biener
On Mon, Mar 24, 2025 at 3:57 PM Kyrylo Tkachov wrote: > > Hi all, > > In this testcase GCC tries to expand a VNx4BI vector: > vector(4) _40; > _39 = () _24; > _40 = {_39, _39, _39, _39}; > > This ends up in a scalarised sequence of bitfield insert operations. > This is despite the fact that AArch

Re: [PATCH] gcc-gitref.cgi: Redirect to cgit instead of gitweb

2025-04-04 Thread Gerald Pfeifer
On Sun, 30 Mar 2025, Mark Wielaard wrote: > cgit is more efficient compared to gitweb and has nicer URLs. Other > redirects like gcc.gnu.org/g:x and bugzilla now also redirect to > cgit. Happy to follow your recommendation. > - echo 'https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h='$ret'">'

Re: [PATCH] tailc: Don't reject all tail calls if param has addr taken [PR119616]

2025-04-04 Thread Richard Biener
> Am 04.04.2025 um 19:35 schrieb Jakub Jelinek : > > Hi! > > Before my PR119376 r15-9145 changes, suitable_for_tail_call_opt_p would > return the same value in the same caller, regardless of the calls in it. > If it fails, the caller clears opt_tailcalls which is a reference and > therefore s

Re: [PATCH] profile: Another musttail fix [PR119618]

2025-04-04 Thread Richard Biener
> Am 04.04.2025 um 19:37 schrieb Jakub Jelinek : > > Hi! > > As the following testcase shows, sometimes we can have debug stmts > after a musttail call and profile.cc in that case would incorrectly > allow the edge from that, causing musttail error and -fcompare-debug > failure (because if th

[PATCH] [testsuite] [riscv] xfail some [PR113281] tests

2025-04-04 Thread Alexandre Oliva
Some of the tests regressed with a fix for the vectorization of shifts. The riscv cost models need to be adjusted to avoid the unprofitable optimization. The failure of these tests has been known since 2024-03-13, without a forthcoming fix, so I suggest we consider it expected by now. Adjust t

  1   2   3   >