Please review the second version of a patch to add clang's invalid-noreturn
flag to toggle noreturn warnings. This patch keeps the old behaviour of
always warning on every noreturn violation, but unlike clang also adds an
extra layer of fine tuning by turning invalid-noreturn into a warning with
l
This is a pretty simple patch that ought to help Darwin users understand
better why their build is failing when they forget to pass the
--with-sysroot= flag to configure.
gcc/ChangeLog:
PR target/90835
* Makefile.in: improve error message when /usr/include is
missing
---
This is a pretty simple patch that ought to help Darwin users understand
better why their build is failing when they forget to pass the
--with-sysroot= flag to configure.
gcc/ChangeLog:
PR target/90835
* Makefile.in: improve error message when /usr/include is
missing
---
Pushed as r14-3331.
Thanks.
chenglulu writes:
> LGTM!
>
> 在 2023/8/16 上午9:48, Guo Jie 写道:
>> gcc/ChangeLog:
>>
>> * config/loongarch/t-loongarch: Add loongarch-driver.h into
>> TM_H. Add loongarch-def.h and loongarch-tune.h into
>> OPTIONS_H_EXTRA.
>>
>> Co-authored-by: Lulu Cheng
On 8/18/23 17:24, Vineet Gupta wrote:
On 8/18/23 16:08, Jeff Law wrote:
There is some slight regression in code quality for a number of
vector tests where we spill more due to different instructions order.
The ones I looked at were a mix of bad luck and/or brittle tests.
Comparing the size
I wonder whether this patch fix such following issues :?
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108271
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108412
juzhe.zh...@rivai.ai
From: Robin Dapp
Date: 2023-08-19 03:32
To: gcc-patches; palmer; Kito Cheng; jeffreyalaw; juzhe.zh...@rivai.
On 8/18/23 16:08, Jeff Law wrote:
There is some slight regression in code quality for a number of
vector tests where we spill more due to different instructions order.
The ones I looked at were a mix of bad luck and/or brittle tests.
Comparing the size of the generated assembly or the number o
On 8/18/23 13:37, Robin Dapp wrote:
Hi,
this patch adds a missing constraint check in order to be able to
print (and not ICE) vector immediates 17-31 for vector shifts.
Regards
Robin
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_print_operand):
gcc/testsuite/ChangeLog:
On 8/18/23 13:56, Palmer Dabbelt wrote:
On Fri, 18 Aug 2023 12:37:06 PDT (-0700), rdapp@gmail.com wrote:
Hi,
this patch adds a missing constraint check in order to be able to
print (and not ICE) vector immediates 17-31 for vector shifts.
Regards
Robin
gcc/ChangeLog:
* config/risc
On 8/18/23 07:57, Robin Dapp wrote:
Hi,
this patch enables pressure-aware scheduling for riscv. There have been
various requests for it so I figured I'd just go ahead and send
the patch.
Thanks. Your timing is good, I was pondering nominating a victim to
pick this up next week ;-)
The
> On 18 Aug 2023, at 23:59, Joseph Myers wrote:
>
> On Fri, 18 Aug 2023, Iain Sandoe via Gcc-patches wrote:
>
>> There is quite extensive Apple Developer documentation on delivering
>> packages with co-installed libraries using @rpath (that is the intended
>> mechanism for delivery since it
On Fri, 18 Aug 2023, Iain Sandoe via Gcc-patches wrote:
> There is quite extensive Apple Developer documentation on delivering
> packages with co-installed libraries using @rpath (that is the intended
> mechanism for delivery since it allows drag-and-drop installation and
> moving of built appl
Tested x86_64-linux (--with-arch-32=i686). Pushed to trunk.
-- >8 --
In r14-3304-g1a566fddea212a and r14-3305-g6cf214b4fc97f5 I tried to
enable std::format for 16-bit float types before C++23. This causes
errors for targets where the types are defined but can't actually be
used, e.g. i686 without
This patch changes the mapping node arrangement used for array components
of derived types in order to accommodate for changes made in the previous
patch, particularly the use of "GOMP_MAP_ATTACH_DETACH" for pointer-typed
derived-type members instead of "GOMP_MAP_ALWAYS_POINTER".
We change the map
This patch adds support for non-constant component offsets in "map"
clauses for OpenMP (and the equivalants for OpenACC), which are not able
to be sorted into order at compile time. Normally struct accesses in
such clauses are gathered together and sorted into increasing address
order after a "GOM
This patch has been separated out from the C++ "declare mapper"
support patch. It contains just the gimplify.cc rearrangement
work, mostly moving gimplification from gimplify_scan_omp_clauses
to gimplify_adjust_omp_clauses for map clauses.
The motivation for doing this was that we don't know if w
This patch trivially adds braces and reindents the
OMP_CLAUSE_TO/OMP_CLAUSE_FROM/OMP_CLAUSE__CACHE_ stanza in
c_finish_omp_clause and finish_omp_clause, in preparation for the
following patch (to clarify the diff a little).
2023-08-18 Julian Brown
gcc/c/
* c-typeck.cc (c_finish_omp_cla
This series comprises the first few patches in support of several OpenMP
5.0 features: "lvalue" parsing for map/to/from clauses, "declare mapper"
support and array shaping/strided "target update" support. These patches
provide the critical infrastructure changes needed to implement those
features.
Hi Joseph,
> On 18 Aug 2023, at 21:17, Joseph Myers wrote:
>
> On Tue, 15 Aug 2023, FX Coudert via Gcc-patches wrote:
>
>> I am currently retesting the patches on various archs (Linux and Darwin)
>> after a final rebase, but various previous versions were
>> regression-tested, and have been s
Hello Tobias,
Tobias Burnus writes:
> Hello Thiago,
>
> the patch looks good to me. Thanks! Can you commit the patch yourself or
> do you need someone to do this for you?
Thank you! I don't have commit access, so I would need someone to do
this for me.
> On 15.08.23 18:17, Thiago Jung Bauerm
Eric Feng writes:
> Thanks for the patch, Thiago. I've pushed it to trunk:
> https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=6785917c9103e18bba0d718ac3b65a386d9a14f7.
Thank you, Eric and Dave.
> On Fri, Aug 18, 2023 at 2:11 PM David Malcolm wrote:
>>
>> On Thu, 2023-08-17 at 23:30 -0300, Thiag
Hi,
testing on 32bit arm revealed that even the simplest case of PR 110378
was still not resolved there because destructors were returning this
pointer. Needless to say, the return value of those destructors often
is just not used, which IPA-SRA can already detect in time. Since
such enhancement
On Tue, 15 Aug 2023, FX Coudert via Gcc-patches wrote:
> I am currently retesting the patches on various archs (Linux and Darwin)
> after a final rebase, but various previous versions were
> regression-tested, and have been shipped for a long time in Homebrew.
>
> OK to commit?
The driver chan
Thanks for the patch, Thiago. I've pushed it to trunk:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=6785917c9103e18bba0d718ac3b65a386d9a14f7.
Best,
Eric
On Fri, Aug 18, 2023 at 2:11 PM David Malcolm wrote:
>
> On Thu, 2023-08-17 at 23:30 -0300, Thiago Jung Bauermann wrote:
> > If GCC is tested
On Fri, 18 Aug 2023 12:37:06 PDT (-0700), rdapp@gmail.com wrote:
Hi,
this patch adds a missing constraint check in order to be able to
print (and not ICE) vector immediates 17-31 for vector shifts.
Regards
Robin
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_print_operand):
gcc/t
On Fri, 18 Aug 2023, Richard Sandiford via Gcc-patches wrote:
> [[]] attributes are a recent addition to C, but as a GNU extension,
> GCC allows them to be used in C11 and earlier. Normally this use
> would trigger a pedwarn (for -pedantic, -Wc11-c2x-compat, etc.).
>
> This patch allows the pedw
Hi,
this patch adds a missing constraint check in order to be able to
print (and not ICE) vector immediates 17-31 for vector shifts.
Regards
Robin
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_print_operand):
gcc/testsuite/ChangeLog:
* gcc.target/riscv/rvv/autovec/binop/shift
Hi,
this patch adds some missing tests for vf[nw]cvt.
Regards
Robin
gcc/testsuite/ChangeLog:
* gcc.target/riscv/rvv/autovec/conversions/vfncvt-ftoi-run.c:
Add tests.
* gcc.target/riscv/rvv/autovec/conversions/vfncvt-ftoi-rv32gcv.c:
Ditto.
* gcc.target/ri
Hi
Jonathan, I just went over the proposal again as well as [compliance],
which Arsen mentioned ( https://wg21.link/compliance ) don't seem to
mention either or .
Shouldn't I just stick to the ones we know are in?
(Still working on figuring out how to do the change log thing)
Best regards
Paul
On Thu, 2023-08-17 at 23:30 -0300, Thiago Jung Bauermann wrote:
> If GCC is tested with a sysroot which doesn't contain a Python
> installation (e.g., with a command such as
> "make check-gcc-c FLAGS_UNDER_TEST="--sysroot=/some/path"), but
> there's
> a python3-config in $PATH, then the testsuite w
gcc/c-family/ChangeLog
* c-omp.cc (c_omp_directives): Uncomment "declare mapper" entry.
gcc/cp/ChangeLog
* parser.cc (cp_parser_omp_declare_mapper): Allow commas between
clauses.
gcc/testsuite/ChangeLog
* g++.dg/gomp/attrs-declare-mapper-3.C: New file.
* g+
gcc/cp/ChangeLog
* parser.cc (cp_parser_omp_all_clauses): Allow comma before first
clause.
(cp_parser_see_omp_loop_nest): Accept C++ standard attributes
before RID_FOR.
(cp_parser_omp_loop_nest): Process C++ standard attributes like
pragmas. Improve
gcc/cp/ChangeLog:
* parser.cc (analyze_metadirective_body): Handle CPP_PRAGMA and
CPP_PRAGMA_EOL.
(cp_parser_omp_metadirective): Allow comma between clauses.
gcc/testsuite/ChangeLog:
* g++.dg/gomp/attrs-metadirective-1.C: New file.
* g++.dg/gomp/attrs-metadi
I've had a task item to ensure that g++ accepts the standard C++
attribute syntax form for all (currently-implemented) OpenMP 5.1
directives, and that there are tests to verify this. I used some
scripting to scan for existing testcases given a list of the
directives, which I extracted from the ref
On Fri, Aug 18, 2023 at 07:15:16PM +0200, Tobias Burnus wrote:
> Comments, questions, concerns?
>
> If not, I intent to commit the attached patch to mainline on Monday
> and after the usual grace time to GCC 13 and then to GCC 12.
>
> PR middle-end/111017
> gcc/
> * omp-expand.cc (exp
This patch fixes a bug with an OpenMP non-rectangular loop nest where the
factor is 0.
With the old code before r12-5295-g47de0b56ee455e, the testcase of the
PR (or included in the attached patch) worked fine. omp-expand.c contained
back then:
https://gcc.gnu.org/git/?p=gcc.git;a=blob;f=gcc/omp-e
On 8/17/23 3:54 AM, Richard Biener wrote:
I think it needs a new category, 'inline' is probably the "closest" existing one
but that also tends to be noisy. Maybe 'call' would be a good name? We could
report things like tail-recursion optimization, tail-calling and sibling calling
optimizations
Implement vector extend and zero_extend functionality for TARGET_SSE2 using
PUNPCKL?? family of instructions. The code for e.g. zero-extend from V2SI to
V2DImode improves from:
movd%xmm0, %edx
pshufd $85, %xmm0, %xmm0
movd%xmm0, %eax
movq%rdx, (%rdi)
On 8/2/23 8:23 AM, Vladimir Makarov wrote:
>>> gcc/
>>> PR rtl-optimization/PR110254
>>> * ira-color.cc (improve_allocation): Update array
>
> I guess you missed the next line in the changelog. I suspect it should be
> "Update array allocated_hard_reg_p."
>
> Please, fix it before commi
Hello Thiago,
the patch looks good to me. Thanks! Can you commit the patch yourself or
do you need someone to do this for you?
On 15.08.23 18:17, Thiago Jung Bauermann via Gcc-patches wrote:
Thiago Jung Bauermann writes:
Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls"
On Fri, Aug 18, 2023 at 06:31:10PM +0200, Jose E. Marchesi wrote:
> > This won't work if target can't use a direct call instruction.
> > Consider
> > __int128 a, b; void foo () { a = a / b; }
> > on x86_64-linux. With just -O2, the above works fine, with
> > -O2 -mcmodel=large it will not, the cal
A rather trivial fix for fprintf() specifier of a HOST_WIDE_INT value.
Tested on aarch64-apple-darwin. OK to commit?
FX
0001-aarch64-fix-format-specifier.patch
Description: Binary data
Hi Jakub.
Thanks for the review.
> On Fri, Aug 18, 2023 at 03:53:51PM +0200, Jose E. Marchesi via Gcc-patches
> wrote:
>> --- a/gcc/final.cc
>> +++ b/gcc/final.cc
>> @@ -815,6 +815,8 @@ make_pass_compute_alignments (gcc::context *ctxt)
>> reorg.cc, since the branch splitting exposes new ins
> On Aug 17, 2023, at 5:32 PM, Siddhesh Poyarekar wrote:
>
> On 2023-08-17 17:25, Qing Zhao wrote:
>>> It's not exactly the same issue, the earlier discussion was about choosing
>>> sizes in the same pass while the current one is about choosing between
>>> passes, but I agree it "rhymes". T
The mask/value pair we track in the irange is a bit fickle in that it
can sometimes contradict the bitmask inherent in the range. This can
happen when a series of calculations yield a combination such as:
[3, 1000] MASK 0xfffe VALUE 0x0
The mask/value above implies that the lowest bi
Hi,
A few updates to the patch:
1. rank_ops_for_fma: return FMA_STATE_NESTED only for complete
FMA chain, since the regression is obvious only in this case.
2. Added new testcase.
Thanks,
Di Zhao
PR tree-optimization/110279
gcc/ChangeLog:
* tree-ssa-math-opts.cc (con
On Fri, Aug 18, 2023 at 03:53:51PM +0200, Jose E. Marchesi via Gcc-patches
wrote:
> --- a/gcc/final.cc
> +++ b/gcc/final.cc
> @@ -815,6 +815,8 @@ make_pass_compute_alignments (gcc::context *ctxt)
> reorg.cc, since the branch splitting exposes new instructions with delay
> slots. */
>
>
Hi,
this patch enables pressure-aware scheduling for riscv. There have been
various requests for it so I figured I'd just go ahead and send
the patch.
There is some slight regression in code quality for a number of
vector tests where we spill more due to different instructions order.
The ones I
[Previous thread:
https://gcc.gnu.org/pipermail/gcc-patches/2022-December/608162.html]
There are many places in GCC where alternative local sequences are
tried in order to determine what is the cheapest or best alternative
to use in the current target. When any of these sequences involve a
libca
On Fri, 18 Aug 2023, Tamar Christina wrote:
> > -Original Message-
> > From: Richard Biener
> > Sent: Friday, August 18, 2023 2:53 PM
> > To: Tamar Christina
> > Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com
> > Subject: RE: [PATCH 12/19]middle-end: implement loop peeling and I
> -Original Message-
> From: Richard Biener
> Sent: Friday, August 18, 2023 2:53 PM
> To: Tamar Christina
> Cc: gcc-patches@gcc.gnu.org; nd ; j...@ventanamicro.com
> Subject: RE: [PATCH 12/19]middle-end: implement loop peeling and IV
> updates for early break.
>
> On Fri, 18 Aug 2023, Ta
The following fixes a bad choice in representing things to the alias
oracle by LIM which while correct in pieces is inconsistent with itself.
When canonicalizing a ref to a bare deref instead of leaving the base
object and the extracted offset the same and just substituting an
alternate ref the fol
On Fri, 18 Aug 2023, Tamar Christina wrote:
> > > Yeah if you comment it out one of the testcases should fail.
> >
> > using new_preheader instead of e->dest would make things clearer.
> >
> > You are now adding the same arg to every exit (you've just queried the
> > main exit redirect_edge_var_
This commit bumps the maximum stack frame size allowed for BPF
functions to the maximum possible value.
Tested in x86_64-linux-gnu host and target bpf-unknown-none.
gcc/ChangeLog
* config/bpf/bpf.opt (mframe-limit): Set default to 32767.
gcc/testsuite/ChangeLog
* gcc.target/bpf
On Fri, 18 Aug 2023, Richard Biener wrote:
> On Thu, 17 Aug 2023, Prathamesh Kulkarni wrote:
>
> > On Tue, 15 Aug 2023 at 14:28, Richard Sandiford
> > wrote:
> > >
> > > Richard Biener writes:
> > > > On Mon, 14 Aug 2023, Prathamesh Kulkarni wrote:
> > > >> On Mon, 7 Aug 2023 at 13:19, Richard
> > Yeah if you comment it out one of the testcases should fail.
>
> using new_preheader instead of e->dest would make things clearer.
>
> You are now adding the same arg to every exit (you've just queried the
> main exit redirect_edge_var_map_vector).
>
> OK, so I think I understand what you're
This should be really fixed now!
Tested x86_64-linux. Pushed to trunk.
-- >8 --
This is one more piece of the rework to make wchar_t support in
std::format depend on _GLIBCXX_USE_WCHAR_T.
In the __to_wstring_numeric function is called with arguments
that aren't type-dependent, so a declaration
Ping. Since this fixes bootstrap problem PR110939 for Loongarch I'm
pingen this one earlier.
On Thu, Aug 10, 2023 at 03:04:03PM +0200, Stefan Schulze Frielinghaus wrote:
> In the former fix in commit 41ef5a34161356817807be3a2e51fbdbe575ae85 I
> completely missed the fact that the normal form of a
On 2023/8/11 23:57, Jeff Law wrote:
On 8/8/23 21:54, Lehua Ding wrote:
Hi Jeff,
> The pattern's operand 0 explicitly allows MEMs as do the constraints.
> So forcing the operand into a register just seems like it's papering
> over the real problem.
The added of force_reg code is address th
Thanks for Richi.
I will wait for Richard's comments and fix for both of you then send V2
patch.
Richard Sandiford writes:
> Joseph Myers writes:
>> On Wed, 16 Aug 2023, Richard Sandiford via Gcc-patches wrote:
>>
>>> Would it be OK to add support for:
>>>
>>> [[__extension__ ...]]
>>>
>>> to suppress the pedwarn about using [[]] prior to C2X? Then we can
>>
>> That seems like a plausib
On Thu, Aug 17, 2023 at 8:22 AM Kewen.Lin wrote:
>
> Hi,
>
> Similar to the existing function vect_build_gather_load_calls,
> this patch is to factor out the handling on scatter store
> having gs_info.decl to vect_build_scatter_store_calls which
> is a new function. It also does some minor refact
On Thu, Aug 17, 2023 at 8:15 AM Kewen.Lin wrote:
>
> Hi,
>
> As PR111021 shows, the below ${port}-protos.h include tree.h
> for code_helper and tree_code:
>
> arm/arm-protos.h:#include "tree.h"
> cris/cris-protos.h:#include "tree.h" (H-P removed this in r14-3218)
> microblaze/microblaze-prot
On Thu, Aug 17, 2023 at 3:38 AM Andrew Pinski via Gcc-patches
wrote:
>
> Convert be sinked into a vec_cond if both sides
> fold. Unlike other unary operations, we need to check that we still can handle
> this vec_cond's first operand is the same as the new truth type.
>
> I tried a few different v
On Thu, 17 Aug 2023, Prathamesh Kulkarni wrote:
> On Tue, 15 Aug 2023 at 14:28, Richard Sandiford
> wrote:
> >
> > Richard Biener writes:
> > > On Mon, 14 Aug 2023, Prathamesh Kulkarni wrote:
> > >> On Mon, 7 Aug 2023 at 13:19, Richard Biener
> > >> wrote:
> > >> > It doesn't seem to make a di
On Wed, 16 Aug 2023, Juzhe-Zhong wrote:
> Hi, Richard and Richi.
>
> Currently, GCC support COND_LEN_FMA for floating-point **NO** -ffast-math.
> It's supported in tree-ssa-math-opts.cc. However, GCC failed to support
> COND_LEN_FNMA/COND_LEN_FMS/COND_LEN_FNMS.
>
> Consider this following case:
On Fri, 18 Aug 2023, Richard Sandiford wrote:
> Richard Biener writes:
> > The following avoids running into somehow flawed logic in fold_vec_perm
> > for non-VLA vectors.
> >
> > Bootstrap & regtest running on x86_64-unknown-linux-gnu.
> >
> > Richard.
> >
> > PR tree-optimization/111048
> >
Tested x86_64-linux. Pushed to trunk.
-- >8 --
r14-3300-g023a62b77f999b left make_wformat_args and some uses of
std::wformat_context unguarded by _GLIBCXX_USE_WCHAR_T.
libstdc++-v3/ChangeLog:
* include/bits/chrono_io.h (operator<<): Use __format_context.
* include/std/format (__
Richard Biener writes:
> The following avoids running into somehow flawed logic in fold_vec_perm
> for non-VLA vectors.
>
> Bootstrap & regtest running on x86_64-unknown-linux-gnu.
>
> Richard.
>
> PR tree-optimization/111048
> * fold-const.cc (fold_vec_perm_cst): Check for non-VLA
>
Good morning
Do you know a system that not only monitors but also optimizes production,
bringing constant income?
Thanks to the latest technologies and data analysis, our solution identifies
areas of optimization, increasing efficiency and reducing costs. Our clients
have recorded an increase
在 2023-08-18五的 15:19 +0800,Xi Ruoyao写道:
> On Fri, 2023-08-18 at 15:05 +0800, Xi Ruoyao via Gcc-patches wrote:
> > On Fri, 2023-08-18 at 14:58 +0800, Xi Ruoyao via Gcc-patches wrote:
> > > On Fri, 2023-08-18 at 14:39 +0800, chenxiaolong wrote:
> > > > 在 2023-08-17四的 15:08 +,Joseph Myers写道:
> > >
This patch implements the following TODO in gcc/config/aarch64/aarch64.cc
to provide the requested behaviour for handling ldp and stp:
/* Allow the tuning structure to disable LDP instruction formation
from combining instructions (e.g., in peephole2).
TODO: Implement fine-grained tunin
The following avoids running into somehow flawed logic in fold_vec_perm
for non-VLA vectors.
Bootstrap & regtest running on x86_64-unknown-linux-gnu.
Richard.
PR tree-optimization/111048
* fold-const.cc (fold_vec_perm_cst): Check for non-VLA
vectors first.
* gcc.
On Fri, 2023-08-18 at 15:05 +0800, Xi Ruoyao via Gcc-patches wrote:
> On Fri, 2023-08-18 at 14:58 +0800, Xi Ruoyao via Gcc-patches wrote:
> > On Fri, 2023-08-18 at 14:39 +0800, chenxiaolong wrote:
> > > 在 2023-08-17四的 15:08 +,Joseph Myers写道:
> > > > On Thu, 17 Aug 2023, Xi Ruoyao via Gcc-patche
On 2023/8/18 14:39, Robin Dapp wrote:
This little patch fixs the -march error of a zhinxmin testcase I added earlier
and an old zhinxmin testcase, since these testcases are for zhinxmin extension
and not zfhmin extension.
Arg, I should have noticed that ;)
OK, of course.
Regards
Robin
Com
On Fri, 2023-08-18 at 14:58 +0800, Xi Ruoyao via Gcc-patches wrote:
> On Fri, 2023-08-18 at 14:39 +0800, chenxiaolong wrote:
> > 在 2023-08-17四的 15:08 +,Joseph Myers写道:
> > > On Thu, 17 Aug 2023, Xi Ruoyao via Gcc-patches wrote:
> > >
> > > > So I guess we just need
> > > >
> > > > builtin_def
76 matches
Mail list logo