On Tue, 15 Aug 2023, FX Coudert via Gcc-patches wrote: > I am currently retesting the patches on various archs (Linux and Darwin) > after a final rebase, but various previous versions were > regression-tested, and have been shipped for a long time in Homebrew. > > OK to commit?
The driver changes are OK. I think the new configure options and the new -nodefaultrpaths compiler option need documenting (I suppose there might be a case for the configure option defined in libtool code being documented somewhere in libtool, if there's somewhere appropriate, but I don't see that in the libtool patch submission). The help text for --enable-darwin-at-rpath refers to it as --enable-darwin-at-path. Somewhere the documentation ought to discuss the considerations around embedding such paths in binaries, and what's appropriate for building a binary on the system where it's going to be used, versus using the compiler to build redistributed binaries that will be run on a system that doesn't have the compiler installed (and so shouldn't have hardcoded paths that were only applicable on the system with the compiler, but will need to be able to find shared libraries - probably shipped with the binary - somehow). -- Joseph S. Myers jos...@codesourcery.com
