Re: [PATCH] libgccjit: Fix float vector comparison

I'm posting the patch again so that you can double-check that I wrote the DCO for the co-author correctly. Does that look good? Thanks. On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote: > > On Thu, 2022-12-01 at 10:25 -0500, David Ma

[PATCH v3] c++: Reject UDLs in certain contexts [PR105300]

On Fri, Nov 18, 2022 at 08:39:10PM -0500, Jason Merrill wrote: > On 11/18/22 18:52, Marek Polacek wrote: > > +/* Parse a string literal or user defined string literal. > > + > > + user-defined-string-literal : > > + string-literal ud-suffix > > + > > + Parameters as for cp_parser_string_lit

Re: [PATCH] Fortran: intrinsic MERGE shall use all its arguments [PR107874]

Dear all, I've committed an obvious fix for the testcase to avoid recursive I/O, as it did cause a hang on some systems: https://gcc.gnu.org/g:36a4ee406b95ae24a59b8b3f8ebe29af6fd5261e Confirmed by Jerry that this resolves his issue. See also attached. Thanks, Harald Am 29.11.22 um 09:08 schri

[committed] analyzer: introduce struct event_loc_info

Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-4472-ge24fe1283ca1c4. gcc/analyzer/ChangeLog: * analyzer.h (struct event_loc_info): New forward decl. * bounds-checking.cc: Use event_loc_info throughout to bundle the loc, fndecl, depth t

[committed] analyzer: fixes to region creation messages [PR107851]

In r13-2573-gc81b60b8c6ff3d I split up the analyzer's region-creation events to describe the memory space and capacity of the region as two separate events to avoid combinatorial explosion of message wordings. However I didn't take into account r13-1405-ge6c3bb379f515b which added a pending_diagno

[PATCH] coroutines: Do not promote temporaries that will be elided.

Thanks to Adrian for working on this and producing the revised test-cases. This has been tested on x86_64-darwin21 with our testsuite, cppcoro and a patched version of folly (that enables the experimental coroutines tests) without regresssion (actually a handful of progressions on folly, plus the

Re: [PATCH v3] c++: P2448 - Relaxing some constexpr restrictions [PR106649]

On 12/2/22 14:48, Marek Polacek wrote: On Fri, Nov 18, 2022 at 09:26:26PM -0500, Jason Merrill wrote: On 11/16/22 15:27, Jason Merrill wrote: On 11/16/22 11:06, Marek Polacek wrote: On Wed, Nov 16, 2022 at 08:41:53AM -0500, Jason Merrill wrote: On 11/15/22 19:30, Marek Polacek wrote: @@ -996

Re: [PATCH 2/5] c++: Set the locus of the function result decl

On 2 December 2022 20:30:56 CET, Jason Merrill wrote: >Here's what I'm applying: I meant to play with it during the weekend, looks good, many thanks for taking care of this! cheers,

Re: [PATCH v3] c++: P2448 - Relaxing some constexpr restrictions [PR106649]

On Fri, Nov 18, 2022 at 09:26:26PM -0500, Jason Merrill wrote: > On 11/16/22 15:27, Jason Merrill wrote: > > On 11/16/22 11:06, Marek Polacek wrote: > > > On Wed, Nov 16, 2022 at 08:41:53AM -0500, Jason Merrill wrote: > > > > On 11/15/22 19:30, Marek Polacek wrote: > > > > > @@ -996,19 +1040,26 @@

[PATCH] c++: unexpanded pack in requires-expr parm list [PR107417]

Here find_parameter_packs_r isn't recognizing the unexpanded pack T inside the requires-expr's parameter list ultimately because cp_walk_trees avoids walking the parameters, for good reason: in requires (Ts... ts) { } walking 'ts' would trigger a false positive in the unexpanded pack checker si

Re: [PATCH] c++: substituting CONST_DECL_USING_P enumerator [PR103081]

On 12/2/22 14:01, Patrick Palka wrote: We implement using enum at class scope by injecting clones of the enum's CONST_DECLs as fields of the class, for which CONST_DECL_USING_P is true, so that qualified lookup naturally finds the enumerators. Substitution into such a CONST_DECL currently ICEs ho

Re: [PATCH 2/5] c++: Set the locus of the function result decl

On 11/23/22 10:28, Jason Merrill wrote: On 11/22/22 15:25, Jason Merrill wrote: On 11/20/22 12:06, Bernhard Reutner-Fischer wrote: Hi Jason! The "meh" of result-decl-plugin-test-2.C should likely be omitted, grokdeclarator would need some changes to add richloc hints and we would not be able

[PATCH trunk] [PR104308] [analyzer] handle memmove like memcpy

On Fri, 2022-12-02 at 06:45 -0300, Alexandre Oliva wrote: > Hello, David, > > I'd written this patch for gcc-12, but you've worked too much on the > analyzer ;-) for it to apply in the trunk. I wonder if there's any > use > you can make of it, or of the observations in it, or whether you'd > pref

[PATCH] c++: substituting CONST_DECL_USING_P enumerator [PR103081]

We implement using enum at class scope by injecting clones of the enum's CONST_DECLs as fields of the class, for which CONST_DECL_USING_P is true, so that qualified lookup naturally finds the enumerators. Substitution into such a CONST_DECL currently ICEs however, because we assume the DECL_CONTEXT

Ping #3: [PATCH 3/3] Update float 128-bit conversions, PR target/107299.

Ping for patches submitted on November 1st. These 3 patches are needed to be able to build GCC for PowerPC target systems where long double is configured to be IEEE 128-bit, such as Fedora 36. This is the 3rd of 3 patches. | Date: Tue, 1 Nov 2022 22:44:01 -0400 | Subject: [PATCH 3/3] Update floa

Ping #3: [PATCH 2/3] Make __float128 use the _Float128 type, PR target/107299

Ping for patches submitted on November 1st. These 3 patches are needed to be able to build GCC for PowerPC target systems where long double is configured to be IEEE 128-bit, such as Fedora 36. This is for the 2nd of 3 patches. | Date: Tue, 1 Nov 2022 22:42:30 -0400 | Subject: [PATCH 2/3] Make __

Ping #3: [PATCH 1/3] Rework 128-bit complex multiply and divide, PR target/107299

Ping for patches submitted on November 1st. These 3 patches are needed to be able to build GCC for PowerPC target systems where long double is configured to be IEEE 128-bit, such as Fedora 36. This is the first patch of 3 patches. | Date: Tue, 1 Nov 2022 22:40:43 -0400 | Subject: [PATCH 1/3] Rew

[PATCH 1/2] select .rodata for const volatile variables.

Changed target code to select .rodata section for 'const volatile' defined variables. This change is in the context of the bugzilla #170181. gcc/ChangeLog: v850.c(v850_select_section): Changed function. --- gcc/config/v850/v850.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/co

[PATCH 2/2] Corrected pr25521.c target matching.

This commit is a follow up of bugzilla #107181. The commit /a0aafbc/ changed the default implementation of the SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the placement of `const volatile' objects. However, the following targets use target-specific selection functions and the

[PATCH] `const volatile' sections selection - bugzilla #107181

Hi everyone, Recently I looked over the issue reported in bugzilla #107181, related to commit `a0aafbc'. The commit changes the object section for `const volatile' objects. However it does it only for the targets using the default section selection hook. The included patches addresses all the arc

Re: [PATCH] Fix a few incorrect accesses.

On 12/2/22 09:52, Richard Biener wrote: On Fri, Dec 2, 2022 at 3:13 PM Andrew MacLeod via Gcc-patches wrote: This consists of 3 changes which stronger type checking has indicated are non-compliant with the type field. I doubt they are super important because there has not been a trap trigger

Re: [PATCH][OG12] amdgcn: Support AMD-specific 'isa' and 'arch' traits in OpenMP context selectors

So this is the OG12-specific part (including metadirective and dynamic context selectors) of the previous patch. Once https://gcc.gnu.org/r13-4446-ge41b243302e996 is backported, is it OK for OG12? Looks good to me, thanks! Kwok

Re: [PATCH] [OpenMP] GC unused SIMD clones

On Thu, Nov 24, 2022 at 07:13:38PM -0700, Sandra Loosemore wrote: > This patch is a followup to my not-yet-reviewed patch > > [PATCH v4] OpenMP: Generate SIMD clones for functions with "declare target" > > https://gcc.gnu.org/pipermail/gcc-patches/2022-November/606218.html > > In comments on a p

Re: [PATCH] c++: explicit spec of constrained member tmpl [PR107522]

On 12/2/22 09:30, Patrick Palka wrote: On Thu, 1 Dec 2022, Jason Merrill wrote: On 12/1/22 14:51, Patrick Palka wrote: On Thu, 1 Dec 2022, Jason Merrill wrote: On 12/1/22 11:37, Patrick Palka wrote: When defining a explicit specialization of a constrained member template (of a class templat

[PATCH RFA(tree)] c++: source position of lambda captures [PR84471]

Tested x86_64-pc-linux-gnu, OK for trunk? -- 8< -- If the DECL_VALUE_EXPR of a VAR_DECL has EXPR_LOCATION set, then any use of that variable looks like it has that location, which leads to the debugger jumping back and forth for both lambdas and structured bindings. Rather than fix all the uses,

Re: [PATCH] Fix a few incorrect accesses.

On Fri, Dec 2, 2022 at 3:13 PM Andrew MacLeod via Gcc-patches wrote: > > This consists of 3 changes which stronger type checking has indicated > are non-compliant with the type field. > > I doubt they are super important because there has not been a trap > triggered by them, and they have been in

Re: [V2][PATCH 1/1] Add a new warning option -Wstrict-flex-arrays.

> On Dec 2, 2022, at 2:20 AM, Richard Biener wrote: > > On Fri, 2 Dec 2022, Richard Biener wrote: > >> On Thu, 1 Dec 2022, Siddhesh Poyarekar wrote: >> >>> On 2022-12-01 11:42, Kees Cook wrote: On Wed, Nov 30, 2022 at 02:25:56PM +, Qing Zhao wrote: > '-Wstrict-flex-arrays' >

Re: [V2][PATCH 1/1] Add a new warning option -Wstrict-flex-arrays.

> On Dec 2, 2022, at 2:16 AM, Richard Biener wrote: > > On Thu, 1 Dec 2022, Siddhesh Poyarekar wrote: > >> On 2022-12-01 11:42, Kees Cook wrote: >>> On Wed, Nov 30, 2022 at 02:25:56PM +, Qing Zhao wrote: '-Wstrict-flex-arrays' Warn about inproper usages of flexible array me

[PATCH] tree-optimization/107833 - invariant motion of uninit uses

The following fixes a wrong-code bug caused by loop invariant motion hoisting an expression using an uninitialized value outside of its controlling condition causing IVOPTs to use that to rewrite a defined value. PR107839 is a similar case involving a bogus uninit diagnostic. Bootstrapped and tes

Re: [PATCH] c++: explicit spec of constrained member tmpl [PR107522]

On Thu, 1 Dec 2022, Jason Merrill wrote: > On 12/1/22 14:51, Patrick Palka wrote: > > On Thu, 1 Dec 2022, Jason Merrill wrote: > > > > > On 12/1/22 11:37, Patrick Palka wrote: > > > > When defining a explicit specialization of a constrained member template > > > > (of a class template) such as f

Re: [PATCH] libgccjit: Fix float vector comparison

On Thu, 2022-12-01 at 11:57 -0500, David Malcolm wrote: > On Thu, 2022-12-01 at 10:33 -0500, Antoni Boucher wrote: > > On Thu, 2022-12-01 at 10:25 -0500, David Malcolm wrote: > > > On Thu, 2022-12-01 at 10:01 -0500, Antoni Boucher wrote: > > > > Thanks, David. > > > > Since we're not in phase 1 any

[PATCH] Fix a few incorrect accesses.

This consists of 3 changes which stronger type checking has indicated are non-compliant with the type field. I doubt they are super important because there has not been a trap triggered by them, and they have been in the source base since sometime before 2017.  However, we should probably fix

nvptx: Support global constructors/destructors via 'collect2'

Hi! On 2022-12-01T22:13:38+0100, I wrote: > I'm working on support for global constructors/destructors with > GCC/nvptx See "nvptx: Support global constructors/destructors via 'collect2'" attached; OK to push? (... with 'gcc/doc/install.texi' accordingly updated once

[committed] [PR106462] LRA: Check hard reg availability of pseudo and its subreg for pseudo reload

The following patch solves   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106462 The patch was successfully bootstrapped and tested on x86-64. commit 70596a0fb2a2ec072e1e97e37616e05041dfa4e5 Author: Vladimir N. Makarov Date: Fri Dec 2 08:18:04 2022 -0500 LRA: Check hard reg availability

[PATCH 9/9] nvptx: Re-enable 'gcc.misc-tests/options.exp'

..., just conditionalize its profiling test (as done elsewhere). gcc/testsuite/ * gcc.misc-tests/options.exp: Re-enable for nvptx. --- gcc/testsuite/gcc.misc-tests/options.exp | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/gcc/testsuite/gcc.misc-tes

[PATCH 6/9] nvptx: Re-enable all variants of 'c-c++-common/torture/complex-sign-mixed-add.c', 'c-c++-common/torture/complex-sign-mixed-sub.c'

PASS with: $ ptxas --version ptxas: NVIDIA (R) Ptx optimizing assembler Copyright (c) 2005-2018 NVIDIA Corporation Built on Sun_Sep__9_21:06:46_CDT_2018 Cuda compilation tools, release 10.0, V10.0.145 ..., and execution with 'Driver Version: 361.93.02'. gcc/testsuite/

[PATCH 5/9] nvptx: Re-enable 'gcc.dg/special/weak-2.c'

PASSes with: $ ptxas --version ptxas: NVIDIA (R) Ptx optimizing assembler Copyright (c) 2005-2018 NVIDIA Corporation Built on Sun_Sep__9_21:06:46_CDT_2018 Cuda compilation tools, release 10.0, V10.0.145 ..., and execution with 'Driver Version: 361.93.02'. gcc/testsuit

[PATCH 8/9] nvptx: Re-enable "Stack alignment causes use of alloca" test cases

Generally PASS with: $ ptxas --version ptxas: NVIDIA (R) Ptx optimizing assembler Copyright (c) 2005-2018 NVIDIA Corporation Built on Sun_Sep__9_21:06:46_CDT_2018 Cuda compilation tools, release 10.0, V10.0.145 ..., and execution with 'Driver Version: 361.93.02'. The exceptio

[PATCH 4/9] nvptx: Re-enable all variants of 'gcc.c-torture/execute/20020529-1.c'

Generally PASSes with: $ ptxas --version ptxas: NVIDIA (R) Ptx optimizing assembler Copyright (c) 2005-2018 NVIDIA Corporation Built on Sun_Sep__9_21:06:46_CDT_2018 Cuda compilation tools, release 10.0, V10.0.145 ..., and execution with 'Driver Version: 361.93.02'. Only the '

[PATCH 3/9] nvptx: Re-enable test cases by removing effective target 'freestanding'

After 2014's commit 157e859ffe3b5d43db1e19475711c1a3d21ab57a "remove picochip", the effective target 'freestanding' (later) was only ever used for nvptx. However, the relevant I/O library functions have long been implemented in nvptx newlib, and otherwise, the more specific effective target 'fileio

[PATCH 7/9] nvptx: Re-enable 'gcc.dg/torture/c99-contract-1.c'

Generally PASSes with: $ ptxas --version ptxas: NVIDIA (R) Ptx optimizing assembler Copyright (c) 2005-2018 NVIDIA Corporation Built on Sun_Sep__9_21:06:46_CDT_2018 Cuda compilation tools, release 10.0, V10.0.145 ..., and execution with 'Driver Version: 361.93.02', at least fo

[PATCH 1/9] nvptx: Re-enable 'gcc.c-torture/compile/20080721-1.c'

PASSes with: $ ptxas --version ptxas: NVIDIA (R) Ptx optimizing assembler Copyright (c) 2005-2018 NVIDIA Corporation Built on Sun_Sep__9_21:06:46_CDT_2018 Cuda compilation tools, release 10.0, V10.0.145 gcc/testsuite/ * gcc.c-torture/compile/20080721-1.c: Re-en

[PATCH 2/9] nvptx: Re-enable "ptxas times out" test cases

These are all quick to compile and generally PASS with: $ ptxas --version ptxas: NVIDIA (R) Ptx optimizing assembler Copyright (c) 2005-2018 NVIDIA Corporation Built on Sun_Sep__9_21:06:46_CDT_2018 Cuda compilation tools, release 10.0, V10.0.145 (Tested 'gcc.c-torture/compile/

nvptx: Re-enable a number of test cases

Hi! I'm proposing to re-enable a number of test cases for nvptx. OK to push? Grüße Thomas - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz de

[PATCH (pushed)] gcc: regenerate configure

gcc/ChangeLog: * configure: Regenerate. --- gcc/configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/configure b/gcc/configure index 74bf1c63e47..6af7dbd06b0 100755 --- a/gcc/configure +++ b/gcc/configure @@ -19712,7 +19712,7 @@ else lt_dlunknown=0; lt_

[PATCH] ipa: silent -Wodr notes with -w

If -w is used, warn_odr properly sets *warned = false and so it should be preserved when calling warn_types_mismatch. Noticed that during a LTO reduction where I used -w. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog:

Re: [committed][nvptx] Use .alias directive for mptx >= 6.3

Hi Tom! (My following analysis and WIP patch is from a few months ago, but I thought I'd send it now, in case you've got any comments, and to avoid potential duplicate work.) On 2022-03-22T14:41:46+0100, Tom de Vries via Gcc-patches wrote: > Starting with ptx isa version 6.3, a ptx directive .

Re: [PATCH 19/56] Revert "Move void_list_node init to common code". (8ff2a92a0450243e52d3299a13b30f208bafa7e0)

Ok, well following that logic it should work to just remove the void_list_node definition that java uses, as per 8ff2a92. However, it doesn't, so clearly java does something else to the end_params_node definition that it shouldn't be, or something similar. I'll have a look.

Re: [PATCH] i386: fix assert (__builtin_cpu_supports ("x86-64") >= 0)

On Fri, Dec 2, 2022 at 10:46 AM Martin Liška wrote: > > PING^1 > > On 11/25/22 13:57, Martin Liška wrote: > > Similar story as PR103661, we again return a negative number > > for __builtin_cpu_supports: > > > > Documentation says: > > > > int __builtin_cpu_supports(const char *feature) > > This fu

Re: [PATCH] i386: Save/restore recog_data in ix86_vector_duplicate_value [PR106577]

On Fri, Dec 2, 2022 at 10:39 AM Jakub Jelinek wrote: > > Hi! > > On Tue, Aug 16, 2022 at 09:14:06AM +0100, Richard Sandiford via Gcc-patches > wrote: > > IMO the correct low-effort fix is to save and restore recog_data > > in ix86_vector_duplicate_value. It's a relatively big copy, > > but the c

Re: [PATCH] i386: fix assert (__builtin_cpu_supports ("x86-64") >= 0)

PING^1 On 11/25/22 13:57, Martin Liška wrote: > Similar story as PR103661, we again return a negative number > for __builtin_cpu_supports: > > Documentation says: > > int __builtin_cpu_supports(const char *feature) > This function returns a positive integer if the run-time CPU supports feature

[PATCH gcc-12] [PR104308] [analyzer] handle memmove like memcpy

Hello, David, I'd written this patch for gcc-12, but you've worked too much on the analyzer ;-) for it to apply in the trunk. I wonder if there's any use you can make of it, or of the observations in it, or whether you'd prefer me to try to port it. I've regstrapped it on x86_64-linux-gnu, and a

[PATCH] i386: Save/restore recog_data in ix86_vector_duplicate_value [PR106577]

Hi! On Tue, Aug 16, 2022 at 09:14:06AM +0100, Richard Sandiford via Gcc-patches wrote: > IMO the correct low-effort fix is to save and restore recog_data > in ix86_vector_duplicate_value. It's a relatively big copy, > but the current code is pretty wasteful anyway (allocating at > least a new SE

Re: [PATCH] [testsuite] [riscv] skip ssa-sink-18.c

OK, thanks! On Fri, Dec 2, 2022 at 5:24 PM Alexandre Oliva via Gcc-patches wrote: > > > On riscv64, despite being lp64, we choose two IV candidates as on arm, > which prevents some of the expected sinking. Add an xfail for it. > > Regstraped on x86_64-linux-gnu, also tested with crosses to riscv

Re: [PATCH] [testsuite] [riscv] uninit-pred-9_b bogus warning

OK, thanks :) On Fri, Dec 2, 2022 at 5:21 PM Alexandre Oliva via Gcc-patches wrote: > > > Like other platforms, riscv hits the uninitialized warning because the > optimizations don't eliminate the nonviable path that would enable it > to be omitted. > > Regstraped on x86_64-linux-gnu, also tested

[PATCH] [arm] xfail fp-uint64-convert-double tests

The FP emulation on ARM doesn't take rounding modes into account. The tests require hard_float, but that only tests for calls when adding doubles. There are arm targets that support hardware adds, but that emulate conversions. Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64

[PATCH] [PR40457] [arm] expand SI-aligned movdi into pair of movsi

When expanding a misaligned DImode move, emit aligned SImode moves if the parts are sufficiently aligned. This enables neighboring stores to be peephole-combined into stm, as expected by the PR40457 testcase, even after SLP vectorizes the originally aligned SImode stores into a misaligned DImode

[PATCH] [PR42093] [arm] [thumb2] disable tree-dce for test

CD-DCE introduces blocks to share common PHI nodes, which replaces a backwards branch that used to prevent the thumb2 jump table shortening that PR42093 tested for. In order to keep on testing that the backward branch prevents the jumptable shortening, disable tree-dce. Regstraped on x86_64-lin

[PATCH] [testsuite] [arm/aarch64] -fno-short-enums for auto-init-[12].c

On arm-eabi, and possibly on other platforms, -fshort-enums is enabled by default, which breaks some tests' expectations as to enum sizes with DEFERRED_INIT. Disable short enums so that the expectations are met. Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64-elf and arm-eab

[PATCH] [testsuite] [riscv] skip ssa-sink-18.c

On riscv64, despite being lp64, we choose two IV candidates as on arm, which prevents some of the expected sinking. Add an xfail for it. Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64-elf and arm-eabi. Ok to install? for gcc/testsuite/ChangeLog * gcc.dg/tree-ss

[PATCH] [testsuite] [riscv] uninit-pred-9_b bogus warning

Like other platforms, riscv hits the uninitialized warning because the optimizations don't eliminate the nonviable path that would enable it to be omitted. Regstraped on x86_64-linux-gnu, also tested with crosses to riscv64-elf and arm-eabi. Ok to install? for gcc/testsuite/ChangeLog

Re: [PATCH 2/3]rs6000: NFC use sext_hwi to replace ((v&0xf..f)^0x80..0) - 0x80..0

on 2022/12/1 20:16, guojiufu wrote: > On 2022-12-01 15:10, Jiufu Guo via Gcc-patches wrote: >> Hi Kewen, >> >> 在 12/1/22 2:11 PM, Kewen.Lin 写道: >>> on 2022/12/1 13:35, Jiufu Guo wrote: Hi Kewen, Thanks for your quick and insight review! 在 12/1/22 1:17 PM, Kewen.Lin 写道:

Re: [PATCH v2] match.pd: rewrite select to branchless expression

On Thu, Dec 1, 2022 at 7:57 PM Michael Collison wrote: > > Richard, > > Can you submit this patch for me while I sort out git write access? Done. I had to apply the patch manually - in future please make sure to send patches that can be applied with git am. Thanks, Richard. > On 11/18/22 07:57