On 12/2/22 09:52, Richard Biener wrote:
On Fri, Dec 2, 2022 at 3:13 PM Andrew MacLeod via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
This consists of 3 changes which stronger type checking has indicated
are non-compliant with the type field.
I doubt they are super important because there has not been a trap
triggered by them, and they have been in the source base since sometime
before 2017. However, we should probably fix them.
I also notice that those are all uses of VOID_TYPE_P, which
coincidentally does not check if its a type node being checked:
/* Nonzero if this type is the (possibly qualified) void type. */
#define VOID_TYPE_P(NODE) (TREE_CODE (NODE) == VOID_TYPE)
So I guess it wouldn't trap anyway, just silently never trigger.
Bootstraps on x86_64-pc-linux-gnu with no regressions. OK for trunk?
LGTM.
Pushed as commit 76dd48f8956b5e17adf0ae1cd1ed3d804a005470
Andrew