Re: [PATCH] x86: Use x constraint on KL patterns

2022-03-25 Thread Hongtao Liu via Gcc-patches
On Sat, Mar 26, 2022 at 10:05 AM Hongyu Wang via Gcc-patches wrote: > > > > Is it possible to create a test case that gas would throw an error for > > > invalid operands? > > > > You can use -ffix-xmmN to disable XMM0-15. > > I mean can we create an intrinsic test for this PR that produces xmm16-3

Re: [PATCH] x86: Use x constraint on SSSE3 patterns with MMX operands

2022-03-25 Thread Hongtao Liu via Gcc-patches
On Sat, Mar 26, 2022 at 1:27 AM H.J. Lu via Gcc-patches wrote: > > Since PHADDW/PHADDD/PHADDSW/PHSUBW/PHSUBD/PHSUBSW/PSIGNB/PSIGNW/PSIGND > have no AVX512 version, replace the "Yv" register constraint with the > "x" register constraint. LGTM, please backport to GCC10/GCC11 branch. > > PR t

Re: [PATCH] x86: Use x constraint on KL patterns

2022-03-25 Thread Hongtao Liu via Gcc-patches
On Sat, Mar 26, 2022 at 4:50 AM H.J. Lu via Gcc-patches wrote: > > Since KL instructions have no AVX512 version, replace the "v" register > constraint with the "x" register constraint. > > PR target/105058 > * config/i386/sse.md (loadiwkey): Replace "v" with "x". > (aesu8):

Re: [PATCH] x86: Use x constraint on KL patterns

2022-03-25 Thread H.J. Lu via Gcc-patches
On Fri, Mar 25, 2022 at 7:04 PM Hongyu Wang wrote: > > > > Is it possible to create a test case that gas would throw an error for > > > invalid operands? > > > > You can use -ffix-xmmN to disable XMM0-15. > > I mean can we create an intrinsic test for this PR that produces xmm16-31? > And the -ffi

Re: [PATCH] x86: Use x constraint on KL patterns

2022-03-25 Thread Hongyu Wang via Gcc-patches
> > Is it possible to create a test case that gas would throw an error for > > invalid operands? > > You can use -ffix-xmmN to disable XMM0-15. I mean can we create an intrinsic test for this PR that produces xmm16-31? And the -ffix-xmmN is an option for assembler or compiler? I didn't find it in

[PATCH, stage 1] Fortran: Add support for OMP non-rectangular loops

2022-03-25 Thread Sandra Loosemore
This patch adds Fortran support for OMP 5.1 "canonical loop nest form" and non-rectangular loops. The C/C++ and middle-end support is already present except for some missing constraint checks in the gimplifier, which I've added here. There's still a TODO with respect to the not-yet-implemente

[PATCH] Fortran: Add location info to OpenMP tree nodes

2022-03-25 Thread Sandra Loosemore
I've got another patch forthcoming (stage 1 material) that adds some new diagnostics for non-rectangular loops during gimplification of OMP nodes. When I was working on that, I discovered that the Fortran front end wasn't attaching location information to the tree nodes corresponding to the va

[PATCH] Fortran: Fix clause splitting for OMP masked taskloop directive

2022-03-25 Thread Sandra Loosemore
I ran into this bug in the handling of clauses on the combined "masked taskloop" OMP directive when I was working on something else. The fix turned out to be a 1-liner. OK for trunk? -Sandracommit 17c4fa0bd97c070945004095a06fb7d9e91869e3 Author: Sandra Loosemore Date: Wed Mar 23 18:45:25 2

Re: [PATCH] x86: Use x constraint on KL patterns

2022-03-25 Thread H.J. Lu via Gcc-patches
On Fri, Mar 25, 2022 at 6:08 PM Hongyu Wang wrote: > > Is it possible to create a test case that gas would throw an error for > invalid operands? You can use -ffix-xmmN to disable XMM0-15. > H.J. Lu via Gcc-patches 于2022年3月26日周六 04:50写道: > > > > Since KL instructions have no AVX512 version, rep

Re: [PATCH] x86: Use x constraint on KL patterns

2022-03-25 Thread Hongyu Wang via Gcc-patches
Is it possible to create a test case that gas would throw an error for invalid operands? H.J. Lu via Gcc-patches 于2022年3月26日周六 04:50写道: > > Since KL instructions have no AVX512 version, replace the "v" register > constraint with the "x" register constraint. > > PR target/105058 >

Re: rs6000/testsuite: Use -mdejagnu-cpu= and -mdejagnu-tune= options

2022-03-25 Thread Segher Boessenkool
On Fri, Mar 25, 2022 at 06:15:56PM -0500, Peter Bergner wrote: > On 3/25/22 4:08 PM, Segher Boessenkool wrote: > > On Fri, Mar 25, 2022 at 02:51:38PM -0500, Peter Bergner wrote: > > It seems likely many of these tests should move to g++.target/powerpc . > > Probably, that can be a follow on patch.

Re: rs6000/testsuite: Use -mdejagnu-cpu= and -mdejagnu-tune= options

2022-03-25 Thread Peter Bergner via Gcc-patches
On 3/25/22 4:08 PM, Segher Boessenkool wrote: > On Fri, Mar 25, 2022 at 02:51:38PM -0500, Peter Bergner wrote: >> This patch updates the POWER testsuite test cases using -mcpu= and -mtune= >> to use the preferred -mdejagnu-cpu= and -mdejagnu-tune= options. This also >> obviates the need for the dg

[committed] wwwdocs: Add release notes for new C2X features in GCC 12

2022-03-25 Thread Joseph Myers
Committed. diff --git a/htdocs/gcc-12/changes.html b/htdocs/gcc-12/changes.html index 9cff81b9..689feeba 100644 --- a/htdocs/gcc-12/changes.html +++ b/htdocs/gcc-12/changes.html @@ -193,6 +193,27 @@ a work-in-progress. +C + + Some new features from the upcoming C2X revision of the ISO C +

[PATCH] c++: ICE with aggregate assignment and DMI [PR104583]

2022-03-25 Thread Marek Polacek via Gcc-patches
The attached 93280 test no longer ICEs but looks like it was never added to the testsuite. The 104583 test, modified so that it closely resembles 93280, still ICEs. The problem is that in 104583 we have a value-init from {} (the line A a{};), so this code in convert_like_internal 7960 /

[PATCH] gimple-fold: fix location of loads for memory ops [PR104308]

2022-03-25 Thread David Malcolm via Gcc-patches
PR analyzer/104308 reports that when -Wanalyzer-use-of-uninitialized-value complains about certain memmove operations where the source is uninitialized, the diagnostic uses UNKNOWN_LOCATION: In function 'main': cc1: warning: use of uninitialized value '*(short unsigned int *)&s + 1' [CWE-457] [-W

Re: rs6000/testsuite: Use -mdejagnu-cpu= and -mdejagnu-tune= options

2022-03-25 Thread Segher Boessenkool
On Fri, Mar 25, 2022 at 02:51:38PM -0500, Peter Bergner wrote: > This patch updates the POWER testsuite test cases using -mcpu= and -mtune= > to use the preferred -mdejagnu-cpu= and -mdejagnu-tune= options. This also > obviates the need for the dg-skip-if directive, since the user cannot > overrid

[PATCH] x86: Use -msse2 on gcc.target/i386/pr95483-1.c

2022-03-25 Thread H.J. Lu via Gcc-patches
Replace -msse with -msse2 since requires SSE2. PR testsuite/105055 * gcc.target/i386/pr95483-1.c: Replace -msse with -msse2. --- gcc/testsuite/gcc.target/i386/pr95483-1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.target/i386/pr95483-1.c

[PATCH] x86: Use x constraint on KL patterns

2022-03-25 Thread H.J. Lu via Gcc-patches
Since KL instructions have no AVX512 version, replace the "v" register constraint with the "x" register constraint. PR target/105058 * config/i386/sse.md (loadiwkey): Replace "v" with "x". (aesu8): Likewise. --- gcc/config/i386/sse.md | 6 +++--- 1 file changed, 3 insertio

Re: [PATCH v3] Document that the 'access' and 'nonnull' attributes are independent

2022-03-25 Thread Martin Sebor via Gcc-patches
On 3/25/22 12:45, David Malcolm wrote: On Wed, 2022-03-23 at 17:52 +0100, Sebastian Huber wrote: On 23/03/2022 17:31, Martin Sebor via Gcc-patches wrote: The concern is that the constraints implied by atttributes access and nonnull are independent of each other. I would suggest to document th

[committed] libstdc++: Add more doxygen comments in

2022-03-25 Thread Jonathan Wakely via Gcc-patches
Tested powerpc64le-linux, pushed to trunk. -- >8 -- libstdc++-v3/ChangeLog: * include/std/bit (bit_cast, byteswap, endian): Add doxygen comments. --- libstdc++-v3/include/std/bit | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/libstdc++-v

rs6000/testsuite: Use -mdejagnu-cpu= and -mdejagnu-tune= options

2022-03-25 Thread Peter Bergner via Gcc-patches
This patch updates the POWER testsuite test cases using -mcpu= and -mtune= to use the preferred -mdejagnu-cpu= and -mdejagnu-tune= options. This also obviates the need for the dg-skip-if directive, since the user cannot override the -mcpu= value being used to compile the test case. This passed re

[PATCH] Add condition coverage profiling

2022-03-25 Thread Jørgen Kvalsvik via Gcc-patches
Hello, and thanks for the review! > 1) Do I correctly understand that __conditions_accu_true/false track > every short-circuit sub-expression of a condition and record > if a given sub-expr is seen to be true or false? Sort-of. It is not really aware of sub-expressions at all, but tracks every bo

Re: [PATCH] c++: Fix up __builtin_{bit_cast,convertvector} parsing

2022-03-25 Thread Jason Merrill via Gcc-patches
On 3/25/22 11:58, Jakub Jelinek wrote: Hi! Jonathan reported on IRC that we don't parse __builtin_bit_cast (type, val).field etc. The problem is that for these 2 builtins we return from cp_parser_postfix_expression instead of setting postfix_expression to the cp_build_* value and falling through

Re: [PATCH] c++: ICE when building builtin operator->* set [PR103455]

2022-03-25 Thread Jason Merrill via Gcc-patches
On 3/25/22 14:09, Patrick Palka wrote: When constructing the builtin operator->* candidate set according to the available conversion functions for each operand type, we end up considering a candidate with C1=T (a TEMPLATE_TYPE_PARM) and C2=F, during which we crash from lookup_base because depende

Re: [PATCH] c++: diagnosing if-stmt with non-constant branches [PR105050]

2022-03-25 Thread Jason Merrill via Gcc-patches
On 3/25/22 12:07, Patrick Palka wrote: When an if-stmt is deemed non-constant because both of its branches are non-constant, we issue a rather generic error which, given that it points to the 'if' token, misleadingly suggests the condition is at fault: constexpr-105050.C:8:3: error: expressio

[PATCH v3] Document that the 'access' and 'nonnull' attributes are independent

2022-03-25 Thread David Malcolm via Gcc-patches
On Wed, 2022-03-23 at 17:52 +0100, Sebastian Huber wrote: > On 23/03/2022 17:31, Martin Sebor via Gcc-patches wrote: > > > > The concern is that the constraints implied by atttributes access > > and > > nonnull are independent of each other. I would suggest to document > > that without talking ab

[PATCH] c++: ICE when building builtin operator->* set [PR103455]

2022-03-25 Thread Patrick Palka via Gcc-patches
When constructing the builtin operator->* candidate set according to the available conversion functions for each operand type, we end up considering a candidate with C1=T (a TEMPLATE_TYPE_PARM) and C2=F, during which we crash from lookup_base because dependent_type_p sees a TEMPLATE_TYPE_PARM when

Re: [PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-03-25 Thread Jason Merrill via Gcc-patches
On 3/25/22 12:34, Jakub Jelinek wrote: Hi! cplus_decl_attributes can be called with attributes equal to error_mark_node, there are some spots in the function that test it or decl_attributes it calls starts with: if (TREE_TYPE (*node) == error_mark_node || attributes == error_mark_node) r

[PATCH] PR102024 - IBM Z: Add psabi diagnostics

2022-03-25 Thread Andreas Krebbel via Gcc-patches
For IBM Z in particular there is a problem with structs like: struct A { float a; int :0; }; Our ABI document allows passing a struct in an FPR only if it has exactly one member. On the other hand it says that structs of 1,2,4,8 bytes are passed in a GPR. So this struct is expected to be passed i

Re: [PATCH] arm: Revert Auto-vectorization for MVE: add pack/unpack patterns PR target/104882

2022-03-25 Thread Christophe Lyon via Gcc-patches
On 3/25/22 11:42, Jakub Jelinek wrote: On Tue, Mar 22, 2022 at 03:33:44PM +0100, Christophe Lyon via Gcc-patches wrote: This reverts commit r12-1434-g046a3beb1673bf to fix PR target/104882. As discussed in the PR, it turns out that the MVE ISA has no natural mapping with GCC's vec_pack_trunc

[PATCH] x86: Use x constraint on SSSE3 patterns with MMX operands

2022-03-25 Thread H.J. Lu via Gcc-patches
Since PHADDW/PHADDD/PHADDSW/PHSUBW/PHSUBD/PHSUBSW/PSIGNB/PSIGNW/PSIGND have no AVX512 version, replace the "Yv" register constraint with the "x" register constraint. PR target/105052 * config/i386/sse.md (ssse3_phwv4hi3): Replace "Yv" with "x". (ssse3_phdv2si3): Lik

Re: [PATCH] recog: Return 1 from insn_invalid_p if REG_INC reg overlaps some stored reg [PR103775]

2022-03-25 Thread Jeff Law via Gcc-patches
On 3/25/2022 4:17 AM, Jakub Jelinek wrote: Hi! The following testcase ICEs on aarch64-linux with -g and assembles with a warning otherwise, because it emits ldrb w0,[x0,16]! instruction which sets the x0 register multiple times. Due to disabled DCE (from -Og) we end up before REE with: (insn

Re: [aarch64] Implement determine_suggested_unroll_factor

2022-03-25 Thread Andre Vieira (lists) via Gcc-patches
Hi, Addressed all of your comments bar the pred ops one. Is this OK? gcc/ChangeLog:     * config/aarch64/aarch64.cc (aarch64_vector_costs): Define determine_suggested_unroll_factor and m_nosve_pattern.     (determine_suggested_unroll_factor): New function.     (aarch64_vector_co

[PATCH] c++: Fix up ICE when cplus_decl_attributes is called with error_mark_node attributes [PR104668]

2022-03-25 Thread Jakub Jelinek via Gcc-patches
Hi! cplus_decl_attributes can be called with attributes equal to error_mark_node, there are some spots in the function that test it or decl_attributes it calls starts with: if (TREE_TYPE (*node) == error_mark_node || attributes == error_mark_node) return NULL_TREE; But the recent PR104245 ch

[committed] [PR104971] LRA: check live hard regs to remove a dead insn

2022-03-25 Thread Vladimir Makarov via Gcc-patches
The following patch is for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104971 The PR was already fixed by Jakub but his patch did not fix a latent LRA bug mentioned in the PR comments.  The current patch fixes the latent bug. The patch was successfully bootstrapped and tested on x86-64 and a

Re: [PATCH] c++: diagnosing if-stmt with non-constant branches [PR105050]

2022-03-25 Thread Marek Polacek via Gcc-patches
On Fri, Mar 25, 2022 at 12:07:31PM -0400, Patrick Palka via Gcc-patches wrote: > When an if-stmt is deemed non-constant because both of its branches are > non-constant, we issue a rather generic error which, given that it points > to the 'if' token, misleadingly suggests the condition is at fault:

[PATCH] c++: diagnosing if-stmt with non-constant branches [PR105050]

2022-03-25 Thread Patrick Palka via Gcc-patches
When an if-stmt is deemed non-constant because both of its branches are non-constant, we issue a rather generic error which, given that it points to the 'if' token, misleadingly suggests the condition is at fault: constexpr-105050.C:8:3: error: expression ‘’ is not a constant expression 8

[PATCH] c++: Fix up __builtin_{bit_cast,convertvector} parsing

2022-03-25 Thread Jakub Jelinek via Gcc-patches
Hi! Jonathan reported on IRC that we don't parse __builtin_bit_cast (type, val).field etc. The problem is that for these 2 builtins we return from cp_parser_postfix_expression instead of setting postfix_expression to the cp_build_* value and falling through into the postfix regression suffix handl

[PATCH][GCC 13] Enable match.pd dumping with -fdump-tree-original

2022-03-25 Thread Alex Coplan via Gcc-patches
Hi, I noticed that, while the C/C++ frontends invoke the GENERIC match.pd simplifications to do early folding, the debug output from generic-match.cc does not appear in the -fdump-tree-original output, even with -fdump-tree-original-folding or -fdump-tree-original-all. This patch fixes that. For

[PATCH] tree-optimization/105053 - fix reduction chain epilogue generation

2022-03-25 Thread Richard Biener via Gcc-patches
When we optimize permutations in a reduction chain we have to be careful to select the correct live-out stmt, otherwise the reduction result will be unused and the retained scalar code will execute only the number of vector iterations. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed to

Re: [PATCH] middle-end/104854: Avoid overread warning for strnlen and strndup

2022-03-25 Thread Siddhesh Poyarekar
On 10/03/2022 06:09, Siddhesh Poyarekar wrote: The size argument larger than size of SRC for strnlen and strndup is problematic only if SRC is not NULL terminated, which invokes undefined behaviour. In all other cases, as long as SRC is large enough to have a NULL char (i.e. size 1 or more), a l

Re: [committed] Docs: Document that taint analyzer checker disables some warnings [PR103533]

2022-03-25 Thread David Malcolm via Gcc-patches
On Fri, 2022-03-25 at 10:58 +0100, Tobias Burnus wrote: > This commit broke bootstrapping - well, at least kind of: >    make pdf   (and probably 'make dvi' and other formats using TeX) > now fails with: > > Runaway argument? > > > > -Wanalyzer-tainted-allocation-size @gol > > -Wanalyzer-tainted-

Re: [PATCH v2] middle-end/104854: Limit strncmp overread warnings

2022-03-25 Thread Siddhesh Poyarekar
On 25/03/2022 18:56, Jason Merrill via Gcc-patches wrote: Perhaps a suitable compromise would be to add a separate warning flag specifically for the strn* warnings, so users deliberately using the bound to express a limit other than the length of the argument string (and confident that their st

Re: [PATCH][RFC] tree-optimization/101908 - avoid STLF fails when vectorizing

2022-03-25 Thread Hongtao Liu via Gcc-patches
On Fri, Mar 25, 2022 at 9:42 PM Richard Biener wrote: > > On Fri, 25 Mar 2022, Hongtao Liu wrote: > > > On Fri, Mar 25, 2022 at 8:11 PM Richard Biener via Gcc-patches > > wrote: > > > > > > Since we're now vectorizing by default at -O2 issues like PR101908 > > > become more important where we app

Re: [PATCH] c++: memory corruption during name lookup w/ modules [PR99479]

2022-03-25 Thread Patrick Palka via Gcc-patches
On Thu, 17 Mar 2022, Patrick Palka wrote: > On Tue, Mar 1, 2022 at 8:13 AM Patrick Palka wrote: > > > > On Thu, Feb 17, 2022 at 3:24 PM Patrick Palka wrote: > > > > > > name_lookup::search_unqualified uses a statically allocated vector > > > in order to avoid repeated reallocation, under the ass

Re: [PATCH v3] c++: alignas and alignof void [PR104944]

2022-03-25 Thread Marek Polacek via Gcc-patches
On Fri, Mar 25, 2022 at 09:36:10AM -0400, Jason Merrill wrote: > On 3/24/22 18:43, Marek Polacek wrote: > > On Thu, Mar 24, 2022 at 05:12:12PM -0400, Jason Merrill wrote: > > > On 3/24/22 15:56, Marek Polacek wrote: > > > > On Thu, Mar 24, 2022 at 12:02:29PM -0400, Jason Merrill wrote: > > > > > On

Re: [PATCH][RFC] tree-optimization/101908 - avoid STLF fails when vectorizing

2022-03-25 Thread Richard Biener via Gcc-patches
On Fri, 25 Mar 2022, Hongtao Liu wrote: > On Fri, Mar 25, 2022 at 8:11 PM Richard Biener via Gcc-patches > wrote: > > > > Since we're now vectorizing by default at -O2 issues like PR101908 > > become more important where we apply basic-block vectorization to > > parts of the function covering loa

Re: [PATCH v3] c++: alignas and alignof void [PR104944]

2022-03-25 Thread Jason Merrill via Gcc-patches
On 3/24/22 18:43, Marek Polacek wrote: On Thu, Mar 24, 2022 at 05:12:12PM -0400, Jason Merrill wrote: On 3/24/22 15:56, Marek Polacek wrote: On Thu, Mar 24, 2022 at 12:02:29PM -0400, Jason Merrill wrote: On 3/24/22 11:49, Marek Polacek wrote: I started looking into this PR because in GCC 4.9

[wwwdocs] Add functions that require to GCC 12 porting-to docs

2022-03-25 Thread Jonathan Wakely via Gcc-patches
Pushed to wwwdocs. --- htdocs/gcc-12/porting_to.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/htdocs/gcc-12/porting_to.html b/htdocs/gcc-12/porting_to.html index 470703c7..079bda30 100644 --- a/htdocs/gcc-12/porting_to.html +++ b/htdocs/gcc-12/porting_to.html @@ -67,7

Re: [PATCH v2] middle-end/104854: Limit strncmp overread warnings

2022-03-25 Thread Jason Merrill via Gcc-patches
On 3/17/22 06:35, Jonathan Wakely via Gcc-patches wrote: On 15/03/22 14:36 -0600, Martin Sebor wrote: On 3/15/22 10:40, Siddhesh Poyarekar wrote: On 15/03/2022 21:09, Martin Sebor wrote: The strncmp function takes arrays as arguments (not necessarily strings).? The main purpose of the -Wstring

Re: [PATCH][RFC] tree-optimization/101908 - avoid STLF fails when vectorizing

2022-03-25 Thread Hongtao Liu via Gcc-patches
On Fri, Mar 25, 2022 at 8:11 PM Richard Biener via Gcc-patches wrote: > > Since we're now vectorizing by default at -O2 issues like PR101908 > become more important where we apply basic-block vectorization to > parts of the function covering loads from function parameters passed > on the stack. S

RE: [aarch64] Update Neoverse N2 core definition

2022-03-25 Thread Kyrylo Tkachov via Gcc-patches
> -Original Message- > From: Andre Vieira (lists) > Sent: Wednesday, March 16, 2022 3:01 PM > To: gcc-patches@gcc.gnu.org > Cc: Kyrylo Tkachov ; Richard Sandiford > > Subject: [aarch64] Update Neoverse N2 core definition > > Hi, > > As requested, I updated the Neoverse N2 entry to use

Re: [PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

2022-03-25 Thread Tom de Vries via Gcc-patches
On 3/25/22 13:35, Thomas Schwinge wrote: Hi! On 2022-03-25T13:08:52+0100, Tom de Vries wrote: On 3/25/22 11:04, Tobias Burnus wrote: On 25.03.22 10:27, Jakub Jelinek via Gcc-patches wrote: On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote: [...] Fix this by scaling down the faili

Re: [PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

2022-03-25 Thread Thomas Schwinge
Hi! On 2022-03-25T13:08:52+0100, Tom de Vries wrote: > On 3/25/22 11:04, Tobias Burnus wrote: >> On 25.03.22 10:27, Jakub Jelinek via Gcc-patches wrote: >>> On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote: [...] Fix this by scaling down the failing test-cases. Tested o

Re: [PATCH] fortran: Fix up initializers of param(0) PARAMETERs [PR103691]

2022-03-25 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 25, 2022 at 01:13:06PM +0100, Richard Biener wrote: > > Also, I think typically in the Fortran FE side-effects would go into > > se.pre and se.post sequences, not into se.expr, and this routine > > doesn't emit those se.pre/se.post sequences anywhere, so presumably it > > assumes they d

Re: [PATCH] middle-end/105049 - fix uniform_vector_p and vector CTOR gimplification

2022-03-25 Thread Richard Biener via Gcc-patches
On Fri, 25 Mar 2022, Richard Biener wrote: > We have > > return VIEW_CONVERT_EXPR( VEC_PERM_EXPR < {<<< Unknown tree: > compound_literal_expr > V D.1984 = { 0 }; >>>, { 0 }} , {<<< Unknown tree: > compound_literal_expr > V D.1985 = { 0 }; >>>, { 0 }} , { 0, 0 } > & {(short in

Re: [PATCH] fortran: Fix up initializers of param(0) PARAMETERs [PR103691]

2022-03-25 Thread Richard Biener via Gcc-patches
On Fri, Mar 25, 2022 at 12:34 PM Jakub Jelinek wrote: > > On Fri, Mar 25, 2022 at 12:16:40PM +0100, Richard Biener wrote: > > On Fri, Mar 25, 2022 at 11:13 AM Tobias Burnus > > wrote: > > > > > > On 25.03.22 09:57, Jakub Jelinek via Fortran wrote: > > > > On the gfortran.dg/pr103691.f90 testcase

Re: [PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

2022-03-25 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 25, 2022 at 01:08:52PM +0100, Tom de Vries wrote: > On 3/25/22 11:04, Tobias Burnus wrote: > > On 25.03.22 10:27, Jakub Jelinek via Gcc-patches wrote: > > > On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote: > > > > [...] > > > > Fix this by scaling down the failing test-case

[PATCH][RFC] tree-optimization/101908 - avoid STLF fails when vectorizing

2022-03-25 Thread Richard Biener via Gcc-patches
Since we're now vectorizing by default at -O2 issues like PR101908 become more important where we apply basic-block vectorization to parts of the function covering loads from function parameters passed on the stack. Since we have no good idea how the stack pushing was performed but we do have a go

Re: [PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

2022-03-25 Thread Tom de Vries via Gcc-patches
On 3/25/22 11:04, Tobias Burnus wrote: On 25.03.22 10:27, Jakub Jelinek via Gcc-patches wrote: On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote: [...] Fix this by scaling down the failing test-cases. Tested on x86_64-linux with nvptx accelerator. [...] Will defer to Thomas, as it i

[c-family] Fix issue for pointers to anonymous types with -fdump-ada-spec

2022-03-25 Thread Eric Botcazou via Gcc-patches
This used to work long ago but broke at some point, so I'm applying the fix only on the mainline, all the more so that it deals the "section" attribute. Tested on x86-64/Linux, applied on the mainline. 2022-03-25 Eric Botcazou c-family/ * c-ada-spec.cc (dump_ada_import): Deal with th

Re: [PATCH] fortran: Fix up initializers of param(0) PARAMETERs [PR103691]

2022-03-25 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 25, 2022 at 12:16:40PM +0100, Richard Biener wrote: > On Fri, Mar 25, 2022 at 11:13 AM Tobias Burnus > wrote: > > > > On 25.03.22 09:57, Jakub Jelinek via Fortran wrote: > > > On the gfortran.dg/pr103691.f90 testcase the Fortran ICE emits > > >static real(kind=4) a[0] = {[0 ... -1

Re: [PATCH] fortran: Fix up initializers of param(0) PARAMETERs [PR103691]

2022-03-25 Thread Richard Biener via Gcc-patches
On Fri, Mar 25, 2022 at 11:13 AM Tobias Burnus wrote: > > On 25.03.22 09:57, Jakub Jelinek via Fortran wrote: > > On the gfortran.dg/pr103691.f90 testcase the Fortran ICE emits > >static real(kind=4) a[0] = {[0 ... -1]=2.0e+0}; > > That is an invalid RANGE_EXPR where the maximum is smaller tha

Re: [PATCH] arm: Revert Auto-vectorization for MVE: add pack/unpack patterns PR target/104882

2022-03-25 Thread Jakub Jelinek via Gcc-patches
On Tue, Mar 22, 2022 at 03:33:44PM +0100, Christophe Lyon via Gcc-patches wrote: > This reverts commit r12-1434-g046a3beb1673bf to fix PR target/104882. > > As discussed in the PR, it turns out that the MVE ISA has no natural > mapping with GCC's vec_pack_trunc / vec_unpack standard patterns, unli

[PATCH] recog: Return 1 from insn_invalid_p if REG_INC reg overlaps some stored reg [PR103775]

2022-03-25 Thread Jakub Jelinek via Gcc-patches
Hi! The following testcase ICEs on aarch64-linux with -g and assembles with a warning otherwise, because it emits ldrb w0,[x0,16]! instruction which sets the x0 register multiple times. Due to disabled DCE (from -Og) we end up before REE with: (insn 12 39 13 2 (set (reg:SI 1 x1 [orig:93 _2 ] [93])

Re: [PATCH] fortran: Fix up initializers of param(0) PARAMETERs [PR103691]

2022-03-25 Thread Tobias Burnus
On 25.03.22 09:57, Jakub Jelinek via Fortran wrote: On the gfortran.dg/pr103691.f90 testcase the Fortran ICE emits static real(kind=4) a[0] = {[0 ... -1]=2.0e+0}; That is an invalid RANGE_EXPR where the maximum is smaller than the minimum. The following patch fixes that. If TYPE_MAX_VALUE is

Re: [PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

2022-03-25 Thread Tobias Burnus
On 25.03.22 10:27, Jakub Jelinek via Gcc-patches wrote: On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote: [...] Fix this by scaling down the failing test-cases. Tested on x86_64-linux with nvptx accelerator. [...] Will defer to Thomas, as it is a purely OpenACC change. One way to d

Re: [committed] Docs: Document that taint analyzer checker disables some warnings [PR103533]

2022-03-25 Thread Tobias Burnus
This commit broke bootstrapping - well, at least kind of: make pdf (and probably 'make dvi' and other formats using TeX) now fails with: Runaway argument? -Wanalyzer-tainted-allocation-size @gol -Wanalyzer-tainted-array-inde@ETC. src/gcc-mainline/gcc/doc/invoke.texi:96 82: File ended while s

[PATCH] middle-end/105049 - fix uniform_vector_p and vector CTOR gimplification

2022-03-25 Thread Richard Biener via Gcc-patches
We have return VIEW_CONVERT_EXPR( VEC_PERM_EXPR < {<<< Unknown tree: compound_literal_expr V D.1984 = { 0 }; >>>, { 0 }} , {<<< Unknown tree: compound_literal_expr V D.1985 = { 0 }; >>>, { 0 }} , { 0, 0 } > & {(short int) SAVE_EXPR , (short int) SAVE_EXPR }); where we gimplif

Re: [PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

2022-03-25 Thread Jakub Jelinek via Gcc-patches
On Fri, Mar 25, 2022 at 10:18:49AM +0100, Tom de Vries wrote: > When a display manager is running on an nvidia card, all CUDA kernel launches > get a 5 seconds watchdog timer. > > Consequently, when running the libgomp testsuite with nvptx accelerator and > GOMP_NVPTX_JIT=-O0 we run into a few FAI

[PATCH][libgomp, testsuite] Scale down some OpenACC test-cases

2022-03-25 Thread Tom de Vries via Gcc-patches
Hi, When a display manager is running on an nvidia card, all CUDA kernel launches get a 5 seconds watchdog timer. Consequently, when running the libgomp testsuite with nvptx accelerator and GOMP_NVPTX_JIT=-O0 we run into a few FAILs like this: ... libgomp: cuStreamSynchronize error: the launch ti

[PATCH] fortran: Fix up initializers of param(0) PARAMETERs [PR103691]

2022-03-25 Thread Jakub Jelinek via Gcc-patches
Hi! On the gfortran.dg/pr103691.f90 testcase the Fortran ICE emits static real(kind=4) a[0] = {[0 ... -1]=2.0e+0}; That is an invalid RANGE_EXPR where the maximum is smaller than the minimum. The following patch fixes that. If TYPE_MAX_VALUE is smaller than TYPE_MIN_VALUE, the array is empty a