Re: Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target"

2021-02-15 Thread Bernd Edlinger
Oops, thanks for fixing this problem. To my excuse I would like to note, that the script error does not happen on x86_64-pc-linux-gnu, probably it would only happen when a file is left over. Since usually this is never executed because $outs is empty: foreach f $outs { file delete $

Re: [RFC] test builtin ratio for loop distribution

2021-02-15 Thread Alexandre Oliva
On Feb 12, 2021, Richard Biener wrote: >> + if (TREE_CODE (mem) == SSA_NAME) >> +if (ptr_info_def *pi = get_ptr_info (mem)) >> + { >> + unsigned al = get_pointer_alignment (builtin->dst_base); >> + if (al > pi->align || pi->misalign) > We still might prefer pi->align == 64

Re: [PATCH] MIPS: Fix PR target/98491 (ChangeLog)

2021-02-15 Thread Xi Ruoyao via Gcc-patches
On 2021-02-15 16:16 -0700, Jeff Law wrote: > > > On 2/12/21 7:17 AM, Xi Ruoyao wrote: > > On 2021-01-11 01:01 +0800, Xi Ruoyao wrote: > > > Hi Jeff and Jakub, > > > > > > On 2021-01-04 14:19 -0700, Jeff Law wrote: > > > > On 1/4/21 2:00 PM, Jakub Jelinek wrote: > > > > > On Mon, Jan 04, 2021 at

Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target"

2021-02-15 Thread Hans-Peter Nilsson via Gcc-patches
Committed as obvious. Please be more careful; this typo should have been obvious in "make check" output as below. Commit-log: --- Fix typo for istarget in "is_target hppa*-*-hpux*", yielding an error running the test-suite for any target not matching powerpc*-*-aix* (p

Re: [PATCH] PR98096: inline-asm: Take inout operands into account for access to labels by names.

2021-02-15 Thread Jeff Law via Gcc-patches
On 2/4/21 2:29 PM, Vladimir Makarov wrote: > The following patch solves > >    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98096 > > The patch is for a new GCC extension -- asm goto with output reloads. > > GCC splits inout operands (with constraint "+") into output and new > matched input oper

Re: [PATCH] [X86] Fold more shuffle builtins to VEC_PERM_EXPR.

2021-02-15 Thread Jeff Law via Gcc-patches
On 12/16/20 3:41 AM, Hongtao Liu via Gcc-patches wrote: > On Tue, Dec 15, 2020 at 7:11 PM Jakub Jelinek wrote: >> On Tue, Dec 15, 2020 at 06:10:57PM +0800, Hongtao Liu via Gcc-patches wrote: >>> --- a/gcc/config/i386/i386.c >>> +++ b/gcc/config/i386/i386.c >>> @@ -18187,21 +18187,67 @@ ix86_gim

Re: [PATCH] Make switchconv smarter.

2021-02-15 Thread Jeff Law via Gcc-patches
On 12/18/20 6:19 AM, Martin Liška wrote: > The patch covers 2 cases mentioned in the PR. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/ChangeLog: > > PR tree-optimization/94779 > * tree-switch-conversion.c

Re: [PATCH] don't enable DWARF5 by default on Windows (PR98860)

2021-02-15 Thread Jeff Law via Gcc-patches
On 2/9/21 2:07 AM, Jakub Jelinek via Gcc-patches wrote: > On Tue, Feb 09, 2021 at 07:47:00AM +0100, Richard Biener via Gcc-patches > wrote: >> On February 8, 2021 10:44:26 PM GMT+01:00, Mikael Pettersson via Gcc-patches >> wrote: >>> PR98860 is a gcc-11 regression where bootstrap fails on Win

[PATCH] doc: c: c++: Document the C/C++ extended asm empty input constraints

2021-02-15 Thread Neven Sajko via Gcc-patches
There is a long-standing, but undocumented GCC inline assembly feature that's part of the extended asm GCC extension to C and C++: extended asm empty input constraints. Although I don't really use extended asm much, and I never contributed to GCC before; I tried to document the feature as far as I

Re: [PATCH] MIPS: Fix PR target/98491 (ChangeLog)

2021-02-15 Thread Jeff Law via Gcc-patches
On 2/12/21 7:17 AM, Xi Ruoyao wrote: > On 2021-01-11 01:01 +0800, Xi Ruoyao wrote: >> Hi Jeff and Jakub, >> >> On 2021-01-04 14:19 -0700, Jeff Law wrote: >>> On 1/4/21 2:00 PM, Jakub Jelinek wrote: On Mon, Jan 04, 2021 at 01:51:59PM -0700, Jeff Law via Gcc-patches wrote: >> Sorry, I for

[PATCH] Add -fgnu-retain/-fno-gnu-retain

2021-02-15 Thread H.J. Lu via Gcc-patches
When building Linux kernel, ld in bninutils 2.36 with GCC 11 generates thousands of ld: warning: orphan section `.data.event_initcall_finish' from `init/main.o' being placed in section `.data.event_initcall_finish' ld: warning: orphan section `.data.event_initcall_start' from `init/main.o' being

[PATCH] c++: Fix CTAD from single-element initializer list [PR99103]

2021-02-15 Thread Patrick Palka via Gcc-patches
When determining whether to rule out initializer-list constructors during CTAD with a single-element initializer list, the element type's cv-qualifiers should be irrelevant. This patch fixes this by making is_spec_or_derived strip cv-qualifiers from the supplied expression type. In passing, I not

Re: [PATCH] aarch64: Run SUBTARGET_INIT_BUILTINS if it exists

2021-02-15 Thread Richard Sandiford via Gcc-patches
Maya Rashish via Gcc-patches writes: > Some subtargets don't provide the canonical function names as > the symbol name in C libraries, and libcalls will only work if > the builtins are patched to emit the correct library name. > > For example, on NetBSD, cabsl has the symbol name __c99_cabsl, > an

[PATCH] aarch64: Run SUBTARGET_INIT_BUILTINS if it exists

2021-02-15 Thread Maya Rashish via Gcc-patches
Some subtargets don't provide the canonical function names as the symbol name in C libraries, and libcalls will only work if the builtins are patched to emit the correct library name. For example, on NetBSD, cabsl has the symbol name __c99_cabsl, and the patching is done via netbsd_patch_builtin.

Re: rtl-optimization: Fix uninitialized use of opaque mode variable ICE [PR98872]

2021-02-15 Thread Peter Bergner via Gcc-patches
On 2/15/21 6:25 AM, Richard Sandiford wrote: > Peter Bergner writes: >> 2021-02-12 Peter Bergner >> >> gcc/ >> PR rtl-optimization/98872 >> * init-regs.c (initialize_uninitialized_regs): Skip initialization >> if CONST0_RTX is NULL. >> >> gcc/testsuite/ >> PR rtl-optimizatio

[PATCH] sparc: Run SUBTARGET_INIT_BUILTINS if it exists

2021-02-15 Thread Maya Rashish via Gcc-patches
Some subtargets don't provide the canonical function names as the symbol name in C libraries, and libcalls will only work if the builtins are patched to emit the correct library name. For example, on NetBSD, cabsl has the symbol name __c99_cabsl, and the patching is done via netbsd_patch_builtin.

[committed] libstdc++: Fix __thread_yield for non-gthreads targets

2021-02-15 Thread Jonathan Wakely via Gcc-patches
The __gthread_yield() function is only defined for gthreads targets, so check _GLIBCXX_HAS_GTHREADS before using it. Also reorder __thread_relax and __thread_yield so that the former can use the latter instead of repeating the same preprocessor checks. libstdc++-v3/ChangeLog: * include/b

Re: [PATCH][AArch64] Leveraging the use of STP instruction for vec_duplicate

2021-02-15 Thread Richard Sandiford via Gcc-patches
Hi Victor, Thanks for the patch. I have a couple of very minor comments below, but otherwise it looks good to go. However, it will need to wait for stage 1 to open, unless it fixes a regression. Victor Do Nascimento via Gcc-patches writes: > diff --git a/gcc/config/aarch64/aarch64-simd.md > b

[committed] libstdc++: Add missing return and use reserved name

2021-02-15 Thread Jonathan Wakely via Gcc-patches
The once_flag::_M_activate() function is only ever called immediately after a call to once_flag::_M_passive(), and so in the non-gthreads case it is impossible for _M_passive() to be true in the body of _M_activate(). Add a check for it anyway, to avoid warnings about missing return. Also replace

Re: [PATCH 2/2] sparc: Run SUBTARGET_INIT_BUILTINS if it exists

2021-02-15 Thread Eric Botcazou
> Some subtargets don't provide the canonical function names as > the symbol name in C libraries, and libcalls will only work if > the builtins are patched to emit the correct library name. > > For example, on NetBSD, cabsl has the symbol name __c99_cabsl, > and the patching is done via netbsd_pat

Re: [PATCH][pushed] Add 2 missing Param keywords.

2021-02-15 Thread Richard Biener via Gcc-patches
On Mon, Feb 15, 2021 at 3:09 PM Martin Liška wrote: > > Pushed as obvious. Oops. Can we somehow make this more magic? > > Martin > > gcc/ChangeLog: > > * params.opt: Add 2 missing Param keywords. > --- > gcc/params.opt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > d

Re: [PATCH] Fix producer string memory leaks

2021-02-15 Thread Richard Biener via Gcc-patches
On Mon, Feb 15, 2021 at 2:46 PM Martin Liška wrote: > > On 2/12/21 5:56 PM, Martin Sebor wrote: > > On 2/12/21 2:09 AM, Richard Biener via Gcc-patches wrote: > >> On Thu, Feb 11, 2021 at 6:41 PM Martin Liška wrote: > >>> > >>> Hello. > >>> > >>> This fixes 2 memory leaks I noticed. > >>> > >>> Pa

[PATCH][pushed] Add 2 missing Param keywords.

2021-02-15 Thread Martin Liška
Pushed as obvious. Martin gcc/ChangeLog: * params.opt: Add 2 missing Param keywords. --- gcc/params.opt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/params.opt b/gcc/params.opt index c633648d047..a4e1ac0e88e 100644 --- a/gcc/params.opt +++ b/gcc/params.op

Re: [PATCH] Fix producer string memory leaks

2021-02-15 Thread Martin Liška
On 2/12/21 5:56 PM, Martin Sebor wrote: On 2/12/21 2:09 AM, Richard Biener via Gcc-patches wrote: On Thu, Feb 11, 2021 at 6:41 PM Martin Liška wrote: Hello. This fixes 2 memory leaks I noticed. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed?

[PATCH] PING^2 Add input_modes parameter to TARGET_MD_ASM_ADJUST hook

2021-02-15 Thread Ilya Leoshkevich via Gcc-patches
Hello, I would like to ping the following patch: Add input_modes parameter to TARGET_MD_ASM_ADJUST hook https://gcc.gnu.org/pipermail/gcc-patches/2021-January/562898.html It is needed for the following regression fix: IBM Z: Fix usage of "f" constraint with long doubles https://gcc.gnu.org/pipe

Re: [PATCH] c++: Private parent access check for using decls [PR19377]

2021-02-15 Thread Anthony Sharp via Gcc-patches
Scan the fields of BINFO for an exact match of DECL. If found, return DECL. Otherwise, return NULL_TREE. DECL is really the type "tree". */ Should say Scan the fields of BINFO for an exact match of DECL. If found, return the field. Otherwise, return NULL_TREE. DECL is really the type

Re: [PATCH] c++: Private parent access check for using decls [PR19377]

2021-02-15 Thread Anthony Sharp via Gcc-patches
Hi all, This overloaded functions issue has been a pain in the ass but I have found a solution that seems to work. I could really do with some feedback on it though since I'm not sure if there's a better way to do it that I am missing. Here's the problem. When a using statement causes an access f

Re: [PATCH] df: Record all definitions in DF_LR_BB_INFO->def [PR98863]

2021-02-15 Thread Richard Sandiford via Gcc-patches
Jakub Jelinek writes: > On Thu, Feb 11, 2021 at 03:03:38PM +, Richard Sandiford via Gcc-patches > wrote: >> gcc/ >> * df-problems.c (df_lr_bb_local_compute): Treat partial definitions >> as read-modify operations. >> >> gcc/testsuite/ >> * gcc.dg/rtl/aarch64/multi-subreg-1.c:

Re: [PATCH 1/2] aarch64: Run SUBTARGET_INIT_BUILTINS if it exists

2021-02-15 Thread Richard Sandiford via Gcc-patches
Maya Rashish via Gcc-patches writes: > Some subtargets don't provide the canonical function names as > the symbol name in C libraries, and libcalls will only work if > the builtins are patched to emit the correct library name. > > For example, on NetBSD, cabsl has the symbol name __c99_cabsl, > an

Re: rtl-optimization: Fix uninitialized use of opaque mode variable ICE [PR98872]

2021-02-15 Thread Richard Sandiford via Gcc-patches
Peter Bergner writes: > 2021-02-12 Peter Bergner > > gcc/ > PR rtl-optimization/98872 > * init-regs.c (initialize_uninitialized_regs): Skip initialization > if CONST0_RTX is NULL. > > gcc/testsuite/ > PR rtl-optimization/98872 > * gcc.target/powerpc/pr98872.c: New

Re: [PATCH] rtl-ssa: Reduce the amount of temporary memory needed [PR98863]

2021-02-15 Thread Richard Biener via Gcc-patches
On Fri, Feb 12, 2021 at 6:03 PM Richard Sandiford via Gcc-patches wrote: > > The rtl-ssa code uses an on-the-side IL and needs to build that IL > for each block and RTL insn. I'd originally not used the classical > dominance frontier method for placing phis on the basis that it seemed > like more

Re: [[PATCH] 1/3] aarch64: Sanitize access to cfun in aarch64_declare_function_name()

2021-02-15 Thread Richard Earnshaw via Gcc-patches
On 09/12/2020 17:21, Christoph Müllner wrote: > From: Christoph Muellner > > It is possible to call aarch64_declare_function_name() and > have cfun not set. Let's sanitize the access to this variable. > > gcc/ > > * config/aarch64/aarch64.c (aarch64_declare_function_name): > Santize acc

Fix cast in df_worklist_dataflow_doublequeue

2021-02-15 Thread Eric Botcazou
The existing cast to float gives weird results in the RTL dump files on x86 when the compiler is configured --with-fpmath=sse. Bootstrapped on x86/Linux, applied on the mainline as obvious. 2021-02-15 Eric Botcazou * df-core.c (df_worklist_dataflow_doublequeue): Use proper cast. --

Re: [PATCH] match.pd: Fix up A % (cast) (pow2cst << B) simplification [PR99079]

2021-02-15 Thread Richard Biener
On Sat, 13 Feb 2021, Jakub Jelinek wrote: > Hi! > > The (mod @0 (convert?@3 (power_of_two_cand@1 @2))) simplification > uses tree_nop_conversion_p (type, TREE_TYPE (@3)) condition, but I believe > it doesn't check what it was meant to check. On convert?@3 > TREE_TYPE (@3) is not the type of what