Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread luoxhu via Gcc-patches
Hi, On 2020/8/13 01:53, Jan Hubicka wrote: > Hello, > with Martin we spent some time looking into exchange2 and my > understanding of the problem is the following: > > There is the self recursive function digits_2 with the property that it > has 10 nested loops and calls itself from the innermost

[PATCH] C-SKY: Fix assembling error with -mfloat-abi=hard.

2020-08-12 Thread Jojo R
gcc/ChangeLog: * gcc/config/csky/csky-elf.h (ASM_SPEC): Use mfloat-abi. * gcc/config/csky/csky-linux-elf.h (ASM_SPEC): mfloat-abi. --- gcc/config/csky/csky-elf.h | 2 ++ gcc/config/csky/csky-linux-elf.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/gcc/config/csky/csky-elf.

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Feng Xue OS via Gcc-patches
> Hello, > with Martin we spent some time looking into exchange2 and my > understanding of the problem is the following: > > There is the self recursive function digits_2 with the property that it > has 10 nested loops and calls itself from the innermost. > Now we do not do amazing job on guessing

gcc.dg/pr94600-5.c .. -8.c: Align struct t0 explictly, as a type, PR middle-end/94600

2020-08-12 Thread Hans-Peter Nilsson via Gcc-patches
Committed as obvious. The bitfield-struct t0 in gcc.dg/pr94600-1.c ..-4.c is assigned through a pointer that is a (volatile-and-pointer-)cast literal, so gcc doesn't need to be otherwise told that the address is aligned. But, variants pr94600-5.c ..-8.c are assigned through a "volatile t0 *", and

Re: [Patch, fortran] PR93671 - gfortran 8-10 ICE on intrinsic assignment to allocatable derived-type component of coarray

2020-08-12 Thread Jerry DeLisle via Gcc-patches
This look good, OK to commit. Thanks, Jerry On 8/10/20 8:03 AM, Andre Vehreschild wrote: Hi folks, long time, no see. I was asked by Damian to do some Coarray stuff in gfortran so here is the first step on fixing a bug. The issue at hand is, that the coarray handling is not propagated correc

Re: [PATCH v2] rs6000: ICE when using an MMA type as a function param or return value [PR96506]

2020-08-12 Thread Peter Bergner via Gcc-patches
On 8/12/20 8:00 PM, Segher Boessenkool wrote: > On Wed, Aug 12, 2020 at 03:32:18PM -0500, Peter Bergner wrote: >> --- a/gcc/config/rs6000/rs6000-call.c >> +++ b/gcc/config/rs6000/rs6000-call.c >> @@ -6444,8 +6444,26 @@ machine_mode >> rs6000_promote_function_mode (const_tree type ATTRIBUTE_UNUSED,

RE: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-12 Thread qiaopeixin
Thanks for the review and commit. All the best, Peixin -Original Message- From: Richard Sandiford [mailto:richard.sandif...@arm.com] Sent: 2020年8月13日 0:25 To: qiaopeixin Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479] qiao

Re: [PATCH v2] rs6000: ICE when using an MMA type as a function param or return value [PR96506]

2020-08-12 Thread Segher Boessenkool
Hi! On Wed, Aug 12, 2020 at 03:32:18PM -0500, Peter Bergner wrote: > --- a/gcc/config/rs6000/rs6000-call.c > +++ b/gcc/config/rs6000/rs6000-call.c > @@ -6444,8 +6444,26 @@ machine_mode > rs6000_promote_function_mode (const_tree type ATTRIBUTE_UNUSED, > machine_mode mod

Re: [PATCH] rs6000: ICE when using an MMA type as a function param

2020-08-12 Thread Segher Boessenkool
On Wed, Aug 12, 2020 at 02:24:33PM -0500, Peter Bergner wrote: > On 8/11/20 9:00 PM, Segher Boessenkool wrote: > > On Sun, Aug 09, 2020 at 10:03:35PM -0500, Peter Bergner wrote: > >> +/* { dg-options "-mdejagnu-cpu=power10 -O2 -w" } */ > > > > Do you need -w or could a less heavy hammer work as we

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Segher Boessenkool
Hi! On Wed, Aug 12, 2020 at 09:03:35PM +0200, Richard Biener wrote: > On August 12, 2020 7:53:07 PM GMT+02:00, Jan Hubicka wrote: > >> From: Xiong Hu Luo > >> 523.xalancbmk_r +1.32% > >> 541.leela_r +1.51% > >> 548.exchange2_r +31.87% > >> 507.cactuBSSN_r +0.80% > >> 526.blender_r +1.25% >

Re: [PATCH 1/3] vec: add exact argument for various grow functions.

2020-08-12 Thread Martin Sebor via Gcc-patches
On 8/12/20 6:28 AM, Martin Liška wrote: On 8/11/20 4:58 PM, Martin Sebor wrote: On 8/11/20 5:36 AM, Martin Liška wrote: Hello. All right, I did it in 3 steps: 1) - new exact argument is added (no default value) - I tested the on x86_64-linux-gnu and I build all cross targets. 2) set default

Re: [PATCH 2/2] PowerPC: Add power10 IEEE 128-bit min/max/cmove.

2020-08-12 Thread Segher Boessenkool
On Tue, Aug 11, 2020 at 11:32:32PM -0400, Michael Meissner wrote: > > > + /* See if we can use the ISA 3.1 min/max/compare instructions for IEEE > > > + 128-bit floating point. At present, don't worry about doing > > > conditional > > > + moves with different types for the comparison and

Re: [PATCH 2/5] C front end support to detect out-of-bounds accesses to array parameters

2020-08-12 Thread Joseph Myers
On Fri, 7 Aug 2020, Martin Sebor via Gcc-patches wrote: > > I don't see anything in the tests in this patch to cover this sort of case > > (arrays of pointers, including arrays of pointers to arrays etc.). > > I've added a few test cases and reworked the declarator parsing > (get_parm_array_spec)

[Committed] PR target/96558: Only call ix86_expand_clear with GENERAL_REGS.

2020-08-12 Thread Roger Sayle
The following patch tightens the predicates of the peephole2 from my recent "Integer min/max improvements patch" to only hoist clearing a register when that register is a general register. Calling ix86_expand_clear with regs other than GENERAL_REGS is not supported. The following patch has been

[PATCH v2] rs6000: ICE when using an MMA type as a function param or return value [PR96506]

2020-08-12 Thread Peter Bergner via Gcc-patches
rs6000: ICE when using an MMA type as a function param or return value [PR96506] PR96506 shows a problem where we ICE on illegal usage, namely using MMA types for function arguments and return values. The solution is to flag these illegal usages as errors early, before we ICE. The patch below is

[committed] [OG10] Add nvptx support for subword compare-and-swap

2020-08-12 Thread Kwok Cheung Yeung
Hello I have committed the patch previously posted at https://gcc.gnu.org/pipermail/gcc-patches/2020-July/550291.html to support atomic compare-and-swap operations on 8-bit and 16-bit types on nvptx to the devel/omp/gcc-10 branch only. Kwok commit 9dc77fbd268ea138797ecc340cf6d9ddc13795c8 Aut

Re: [PATCH] c++: Fixing the wording of () aggregate-init [PR92812]

2020-08-12 Thread Jason Merrill via Gcc-patches
On 8/11/20 7:34 PM, Marek Polacek wrote: P1975R0 tweaks the static_cast wording: it says that "An expression e can be explicitly converted to a type T if [...] T is an aggregate type having a first element x and there is an implicit conversion sequence from e to the type of x." This already work

Re: [committed] libstdc++: Make self-move well-defined for containers [PR 85828]

2020-08-12 Thread Jonathan Wakely via Gcc-patches
On 12/08/20 20:37 +0100, Jonathan Wakely wrote: The C++ LWG recently confirmed that self-move assignment should not have undefined behaviour for standard containers (see the proposed resolution of LWG 2839). The result should be a valid but unspecified value, just like other times when a containe

[committed] libstdc++: Make self-move well-defined for containers [PR 85828]

2020-08-12 Thread Jonathan Wakely via Gcc-patches
The C++ LWG recently confirmed that self-move assignment should not have undefined behaviour for standard containers (see the proposed resolution of LWG 2839). The result should be a valid but unspecified value, just like other times when a container is moved from. Our std::list, std::__cxx11::bas

Re: [PATCH] rs6000: ICE when using an MMA type as a function param

2020-08-12 Thread Peter Bergner via Gcc-patches
On 8/11/20 9:00 PM, Segher Boessenkool wrote: > On Sun, Aug 09, 2020 at 10:03:35PM -0500, Peter Bergner wrote: >> +/* { dg-options "-mdejagnu-cpu=power10 -O2 -w" } */ > > Do you need -w or could a less heavy hammer work as well? So adding: extern void bar0(); etc. was enough to get rid of the wa

Re: [COMMITTED 0/4] bpf: backports to releases/gcc-10

2020-08-12 Thread Jose E. Marchesi via Gcc-patches
> On 8/12/20 8:19 PM, Jose E. Marchesi wrote: >> Hi Martin. >> I left the changelog entry dates of the original commits untouched, and added `(cherry-pick from commit XXX)' lines to the commit messages. Hope that is ok... please let me know otherwise! >>> >>> Hello. >>> >>> For c

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Richard Biener via Gcc-patches
On August 12, 2020 7:53:07 PM GMT+02:00, Jan Hubicka wrote: >Hello, >with Martin we spent some time looking into exchange2 and my >understanding of the problem is the following: > >There is the self recursive function digits_2 with the property that it >has 10 nested loops and calls itself from th

Re: [COMMITTED 0/4] bpf: backports to releases/gcc-10

2020-08-12 Thread Martin Liška
On 8/12/20 8:19 PM, Jose E. Marchesi wrote: Hi Martin. I left the changelog entry dates of the original commits untouched, and added `(cherry-pick from commit XXX)' lines to the commit messages. Hope that is ok... please let me know otherwise! Hello. For creating a backport please use cont

[no subject]

2020-08-12 Thread Ian Lance Taylor via Gcc-patches
This libgo patch by Clément Chigot correctly handles AIX FAT library creation. The previous patch wasn't working everytime. Especially when AR had "-X32_64", the new .so would replace the default one and not just being added. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed t

Re: [COMMITTED 0/4] bpf: backports to releases/gcc-10

2020-08-12 Thread Jose E. Marchesi via Gcc-patches
Hi Martin. >> I left the changelog entry dates of the original commits untouched, >> and added `(cherry-pick from commit XXX)' lines to the commit >> messages. Hope that is ok... please let me know otherwise! > > Hello. > > For creating a backport please use contrib/git-backport.py script. > Th

Re: [COMMITTED 0/4] bpf: backports to releases/gcc-10

2020-08-12 Thread Martin Liška
On 8/12/20 5:06 PM, Jose E. Marchesi via Gcc-patches wrote: I left the changelog entry dates of the original commits untouched, and added `(cherry-pick from commit XXX)' lines to the commit messages. Hope that is ok... please let me know otherwise! Hello. For creating a backport please use co

Re: [PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Jan Hubicka
Hello, with Martin we spent some time looking into exchange2 and my understanding of the problem is the following: There is the self recursive function digits_2 with the property that it has 10 nested loops and calls itself from the innermost. Now we do not do amazing job on guessing the profile s

Re: [PATCH] ipa: fix bit CPP when combined with IPA bit CP

2020-08-12 Thread Martin Liška
There's an updated version of the patch that is approved by Honza. I'm going to install it (and I'll backport it as well). Martin >From 906bc8b5bc1815471fea4f79b9f48a78ad9d6592 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Wed, 12 Aug 2020 09:21:51 +0200 Subject: [PATCH] ipa: fix bit CPP wh

Re: [Patch, fortran] PR93671 - gfortran 8-10 ICE on intrinsic assignment to allocatable derived-type component of coarray

2020-08-12 Thread Thomas Koenig via Gcc-patches
Hi Andre, Regtests ok on FC31.x86_64. Ok for trunk? Good thing you're back! Any help with bugfixing is highly appreciated, and Coarrays certainly can use some work. The patch is OK for trunk. Best regards Thomas

Re: [PATCH] diagnostics: Add new option -fdiagnostics-plain-output

2020-08-12 Thread Richard Sandiford
Lewis Hyatt writes: > Hello- > > Attached is the patch I mentioned in another discussion here: > https://gcc.gnu.org/pipermail/gcc-patches/2020-August/551442.html > > This adds a new option -fdiagnostics-plain-output that currently means the > same thing as: > -fno-diagnostics-show-caret -fno-

Re: [PATCH] AArch64: Add if condition in aarch64_function_value [PR96479]

2020-08-12 Thread Richard Sandiford
qiaopeixin writes: > Hi, > > The test case vector-subscript-2.c in the gcc testsuit will report an ICE in > the expand pass since '-mgeneral-regs-only' is incompatible with the use of > V4SI mode. I propose to report the diagnostic information instead of ICE, and > the problem has been discusse

Re: [PATCH] options: Make --help= to emit values post-overrided

2020-08-12 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi Segher, > > on 2020/8/7 锟斤拷锟斤拷10:42, Segher Boessenkool wrote: >> Hi! >> >> On Fri, Aug 07, 2020 at 10:44:10AM +0800, Kewen.Lin wrote: I think this makes a lot of sense. > btw, not sure whether it's a good idea to move target_option_override_hook > call

Re: [PATCH] Fix up flag_cunroll_grow_size handling in presence of optimize attr [PR96535]

2020-08-12 Thread Segher Boessenkool
Hi Jakub, On Wed, Aug 12, 2020 at 10:20:12AM +0200, Jakub Jelinek wrote: > This patch moves the unrolling related handling from process_options into > finish_options which is invoked whenever the options are being finalized, > and the rs6000 specific parts into the override_options_after_change ho

Re: [PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 12, 2020 at 04:30:35PM +0200, Richard Biener wrote: > Not a final review but if we care for this kind of normalization at all > the we should do so consistently, thus for both encode and interpret and > for all modes. For FP we could also check if we'd consider the values > equal rathe

Re: [Patch] Fortran: Add support for OpenMP's nontemporal clause

2020-08-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 12, 2020 at 04:55:03PM +0200, Tobias Burnus wrote: > Low-hanging fruit: Add support for 'omp simd's nontemporal clause, > which is part of the OpenMP 5.0 features suppored by the ME + C/C++. To be precise, the ME just ignores it. While GIMPLE has support for gimple_assign_nontemporal_m

[COMMITTED 1/4] bpf: add support for the -mxbpf option

2020-08-12 Thread Jose E. Marchesi via Gcc-patches
This patch adds support for a new option -mxbpf. This tells GCC to generate code for an expanded version of BPF that relaxes some of the restrictions imposed by BPF. (cherry pick of 51e10276d6792f67f1d88d90f299e7ac1b1f1f24) 2020-05-19 Jose E. Marchesi gcc/ * config/bpf/bpf.opt (mxbpf

[COMMITTED 0/4] bpf: backports to releases/gcc-10

2020-08-12 Thread Jose E. Marchesi via Gcc-patches
Hi people! Just a few BPF related backports from master to the gcc-10 branch. I left the changelog entry dates of the original commits untouched, and added `(cherry-pick from commit XXX)' lines to the commit messages. Hope that is ok... please let me know otherwise! :) Salud! Jose E. Marchesi

[COMMITTED 2/4] bpf: do not save/restore callee-saved registers in function prolog/epilog

2020-08-12 Thread Jose E. Marchesi via Gcc-patches
BPF considers that every call to a function allocates a fresh set of registers that are available to the callee, of which the first five may have bee initialized with the function arguments. This is implemented by both interpreter and JIT in the Linux kernel. This is enforced by the kernel BPF ve

[COMMITTED 3/4] bpf: more flexible support for kernel helpers

2020-08-12 Thread Jose E. Marchesi via Gcc-patches
This patch changes the existing support for BPF kernel helpers to be more flexible, in two main ways. First, there is no longer a hardcoded list of kernel helpers defined in the compiler internals. This is replaced by a new target-specific attribute `kernel_helper' that the user can use to define

[COMMITTED 4/4] bpf: remove trailing whitespaces from source files

2020-08-12 Thread Jose E. Marchesi via Gcc-patches
This patch is a little cleanup that removes trailing whitespaces from the bpf backend source files. (cherry pick of commit e87c540fe43e29663140ed67b98ee437c25696bb) 2020-08-07 Jose E. Marchesi gcc/ * config/bpf/bpf.md: Remove trailing whitespaces. * config/bpf/constraints.md:

[Patch] Fortran: Add support for OpenMP's nontemporal clause

2020-08-12 Thread Tobias Burnus
Low-hanging fruit: Add support for 'omp simd's nontemporal clause, which is part of the OpenMP 5.0 features suppored by the ME + C/C++. OK? Tobias - Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer:

Re: [PATCH] Fix up flag_cunroll_grow_size handling in presence of optimize attr [PR96535]

2020-08-12 Thread Richard Biener
On August 12, 2020 10:20:12 AM GMT+02:00, Jakub Jelinek wrote: >Hi! > >As the testcase in the PR shows (not included in the patch, as >it seems quite fragile to observe unrolling in the IL), the >introduction of >flag_cunroll_grow_size broke optimize attribute related to loop >unrolling. >The pro

Re: [PATCH][AVX512][PR96246] Merge two define_insn: _blendm, _load_mask.

2020-08-12 Thread Kirill Yukhin via Gcc-patches
Hello, On 22 июл 12:59, Hongtao Liu via Gcc-patches wrote: > Those two define_insns have same pattern, and > _load_mask would always be matched since it show up > earlier in the md file, and it may lose some opportunity in > pass_reload since _load_mask only have constraint "0C" > for operand2,

Re: [PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-12 Thread Richard Biener
On August 12, 2020 10:45:12 AM GMT+02:00, Jakub Jelinek wrote: >Hi! > >My patch to introduce native_encode_initializer to fold_ctor_reference >apparently broke gnulib/m4 on powerpc64. >There it uses a const union with two doubles and corresponding IBM >double >double long double which actually is

[committed][testsuite, nvptx] Borrow ia64-sync-*.c test-cases in gcc.target/nvptx

2020-08-12 Thread Tom de Vries
Hi, In absence of nvptx-enabling for effective target sync_int_long (see PR96494), copy a few test-cases to gcc.target/nvptx. Tested on nvptx. Committed to trunk. Thanks, - Tom [testsuite, nvptx] Borrow ia64-sync-*.c test-cases in gcc.target/nvptx --- gcc/testsuite/gcc.target/nvptx/ia64-sync

[PATCH][testsuite, nvptx] Add effective target sync_int_long_stack

2020-08-12 Thread Tom de Vries
Hi, The nvptx target currently doesn't support effective target sync_int_long, although it has support for 32-bit and 64-bit atomic. When enabling sync_int_long for nvptx, we run into a failure in gcc.dg/pr86314.c: ... nvptx-run: error getting kernel result: operation not supported on \ globa

Re: [PATCH 1/3] vec: add exact argument for various grow functions.

2020-08-12 Thread Martin Liška
On 8/11/20 4:58 PM, Martin Sebor wrote: On 8/11/20 5:36 AM, Martin Liška wrote: Hello. All right, I did it in 3 steps: 1) - new exact argument is added (no default value) - I tested the on x86_64-linux-gnu and I build all cross targets. 2) set default value of exact = false 3) change places wh

[PATCH] ipa: fix bit CPP when combined with IPA bit CP

2020-08-12 Thread Martin Liška
Hello. First, I must confess I'm not familiar with bit constant propagation. However, I learnt something during debugging session related to this PR. As mentioned in the PR, let's consider the following example: int __attribute__((noinline)) foo(int arg) { if (arg == 3) return 1; if (

Re: [PATCH][testsuite] Add effective target large_initializer

2020-08-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 12, 2020 at 01:05:26PM +0200, Tom de Vries wrote: > [testsuite] Add effective target large_initializer > > gcc/testsuite/ChangeLog: > > PR testsuite/96566 > * lib/target-supports.exp (check_effective_target_large_initializer): > New proc. > * gcc.dg/builtin-obj

[Committed] Update email address

2020-08-12 Thread Senthil Kumar Selvaraj via Gcc-patches
This patch updates my email address in the MAINTAINERS file 2020-08-12 Senthil Kumar Selvaraj * MAINTAINERS: Update my email address. diff --git MAINTAINERS MAINTAINERS index 0b825c7ea6d..217ec9c9eca 100644 --- MAINTAINERS +++ MAINTAINERS @@ -588,7 +588,7 @@ Stefan Schulze Frielinghaus

[PATCH][testsuite] Add effective target large_initializer

2020-08-12 Thread Tom de Vries
Hi, When compiling builtin-object-size-21.c for nvptx, cc1 times out while emitting the initializer for global variable xm3_3. With x86_64, we are able to emit the initializer with a few lines of assembly: ... xm3_3: .byte 0 .zero 9223372036854775803 .byte 1

RE: Do not combine PRED_LOOP_GUARD and PRED_LOOP_GUARD_WITH_RECURSION

2020-08-12 Thread Tamar Christina
Hi Honza, > -Original Message- > From: Gcc-patches On Behalf Of Jan > Hubicka > Sent: Tuesday, August 11, 2020 11:04 AM > To: gcc-patches@gcc.gnu.org > Subject: Do not combine PRED_LOOP_GUARD and > PRED_LOOP_GUARD_WITH_RECURSION > > Hi, > this patch avoids both PRED_LOOP_GUARD and > PRED

[committed][nvptx] Fix array dimension in nvptx_assemble_decl_begin

2020-08-12 Thread Tom de Vries
Hi, When compiling test-case builtin-object-size-21.c, cc1 emits: ... .visible .global .align 1 .u32 xm3_3[-2305843009213693951] = ... for: ... struct Ax_m3 { char a[PTRDIFF_MAX - 3], ax[]; }; struct Ax_m3 xm3_3 = { { 0 }, { 1, 2, 3 } }; ... Fix this by: - changing the printing format for unsi

[PATCH] ipa-inline: Improve growth accumulation for recursive calls

2020-08-12 Thread Xionghu Luo via Gcc-patches
From: Xiong Hu Luo For SPEC2017 exchange2, there is a large recursive functiondigits_2(function size 1300) generates specialized node from digits_2.1 to digits_2.8 with added build option: --param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=80 ipa-inline pass will consider inline these n

Re: [PATCH] middle-end: Recognize idioms for bswap32 and bswap64 in match.pd.

2020-08-12 Thread Marc Glisse
On Wed, 12 Aug 2020, Roger Sayle wrote: This patch is inspired by a small code fragment in comment #3 of bugzilla PR rtl-optimization/94804. That snippet appears almost unrelated to the topic of the PR, but recognizing __builtin_bswap64 from two __builtin_bswap32 calls, seems like a clever/usef

Re: [PATCH] arm: Clear canary value after stack_protect_test [PR96191]

2020-08-12 Thread Christophe Lyon via Gcc-patches
On Tue, 11 Aug 2020 at 18:42, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Mon, 10 Aug 2020 at 17:27, Richard Sandiford > > wrote: > >> > >> Christophe Lyon writes: > >> > On Wed, 5 Aug 2020 at 16:33, Richard Sandiford > >> > wrote: > >> >> > >> >> The stack_protect_test pattern

Re: [PATCH] testsuite: Fix gcc.target/arm/multilib.exp use of gcc_opts

2020-08-12 Thread Christophe Lyon via Gcc-patches
On Tue, 11 Aug 2020 at 18:40, Richard Sandiford wrote: > > Christophe Lyon via Gcc-patches writes: > > This patch fixes an incorrect parameter passing for $gcc_opts, which > > produces a DejaGnu error: (DejaGnu) proc "gcc_opts" does not exist. > > Huh, wonder how that went unnoticed for so long…

Re: [PATCH] testsuite: Add -fno-common to pr82374.c [PR94077]

2020-08-12 Thread Jakub Jelinek via Gcc-patches
On Wed, Aug 12, 2020 at 05:03:45PM +0800, Kewen.Lin wrote: > Hi, > > As the PR comments show, the case gcc.dg/gomp/pr82374.c fails > on Power7 since gcc8. But it passes from gcc10. By looking > into the difference, it's due to that gcc10 sets -fno-common > as default, which makes vectorizer forc

[PATCH] testsuite: Add -fno-common to pr82374.c [PR94077]

2020-08-12 Thread Kewen.Lin via Gcc-patches
Hi, As the PR comments show, the case gcc.dg/gomp/pr82374.c fails on Power7 since gcc8. But it passes from gcc10. By looking into the difference, it's due to that gcc10 sets -fno-common as default, which makes vectorizer force the alignment and be able to use aligned vector load/store on those t

Re: [AArch64] Upgrade integer MLA intrinsics to GCC vector extensions

2020-08-12 Thread Richard Sandiford
James Greenhalgh writes: > Hi, > > As subject, this patch rewrites the mla intrinsics to use a + b * c rather > than inline assembler, thereby opening them to CSE, scheduling, etc. Looks good for the unsigned ones. For the signed ones, there's a risk that the functions might become subject to th

Re: [AArch64] Upgrade integer MLA intrinsics to GCC vector extensions

2020-08-12 Thread Christophe Lyon via Gcc-patches
Hi James, On Wed, 12 Aug 2020 at 10:40, James Greenhalgh wrote: > > > Hi, > > As subject, this patch rewrites the mla intrinsics to use a + b * c rather > than inline assembler, thereby opening them to CSE, scheduling, etc. > > Bootstrapped and tested on aarch64-none-linux-gnu. > Do we have test

Re: [PR96519] Re: [PATCH][testsuite] Add gcc.dg/ia64-sync-5.c

2020-08-12 Thread Richard Sandiford
Kwok Cheung Yeung writes: > Hello > > On 06/08/2020 1:23 pm, Tom de Vries wrote: > > +static char AC[4]; > > +static char init_qi[4] = { -30,-30,-50,-50 }; > > +static char test_qi[4] = { -115,-115,25,25 }; > > + > > +static void > > +do_qi (void) > > +{ > > + if (__sync_val_compare_and_s

[PATCH] gimple-fold: Don't optimize wierdo floating point value reads [PR95450]

2020-08-12 Thread Jakub Jelinek via Gcc-patches
Hi! My patch to introduce native_encode_initializer to fold_ctor_reference apparently broke gnulib/m4 on powerpc64. There it uses a const union with two doubles and corresponding IBM double double long double which actually is the largest normalizable long double value (1 ulp higher than __LDBL_MA

[AArch64] Upgrade integer MLA intrinsics to GCC vector extensions

2020-08-12 Thread James Greenhalgh
Hi, As subject, this patch rewrites the mla intrinsics to use a + b * c rather than inline assembler, thereby opening them to CSE, scheduling, etc. Bootstrapped and tested on aarch64-none-linux-gnu. OK? Thanks, James --- gcc/Changelog: 2020-08-11 James Greenhalgh config/aarch64/

[PATCH] middle-end: Recognize idioms for bswap32 and bswap64 in match.pd.

2020-08-12 Thread Roger Sayle
This patch is inspired by a small code fragment in comment #3 of bugzilla PR rtl-optimization/94804. That snippet appears almost unrelated to the topic of the PR, but recognizing __builtin_bswap64 from two __builtin_bswap32 calls, seems like a clever/useful trick. GCC's optabs.c contains the inve

[PATCH] Fix up flag_cunroll_grow_size handling in presence of optimize attr [PR96535]

2020-08-12 Thread Jakub Jelinek via Gcc-patches
Hi! As the testcase in the PR shows (not included in the patch, as it seems quite fragile to observe unrolling in the IL), the introduction of flag_cunroll_grow_size broke optimize attribute related to loop unrolling. The problem is that the new option flag is set (if not set explicitly) only in p

Re: [PATCH] PR libstdc++/71579 assert that type traits are not misused with an incomplete type

2020-08-12 Thread Antony Polukhin via Gcc-patches
Fixed patch for type traits hardening Changelog 2020-08-12 Antony Polukhin PR libstdc/71579 * include/std/type_traits (invoke_result, is_nothrow_invocable_r) Add static_asserts to make sure that the argument of the type trait is not misused with incomplete types. (is_swapp

RE: [PATCH] x86_64: Use peephole2 to eliminate redundant moves.

2020-08-12 Thread Roger Sayle
Hi Uros, Many thanks for the review, and your help/explanation around constant materialization on x86_64/i386. Your suggestion to try x86_64_general_operand as a predicate was awesome! Not only does this improvement survive "make bootstrap" and "make -k check" on x86_64-pc-linux-gnu, and fix the