Hi!
On Wed, Aug 12, 2020 at 03:32:18PM -0500, Peter Bergner wrote:
> --- a/gcc/config/rs6000/rs6000-call.c
> +++ b/gcc/config/rs6000/rs6000-call.c
> @@ -6444,8 +6444,26 @@ machine_mode
> rs6000_promote_function_mode (const_tree type ATTRIBUTE_UNUSED,
> machine_mode mode,
> int *punsignedp ATTRIBUTE_UNUSED,
> - const_tree, int)
> + const_tree, int for_return)
> {
> + /* Warning: this is a static local variable and not always NULL! */
> + static struct function *fn = NULL;
It may be just me that always misses "static" on locals, heh. But
please comment what this is *for*: to warn only once per function. You
could choose a better variable name to say that, too.
"struct function" is GTY, will this work this way, btw?
So I am worried about that; other than that, this is just fine (if you
tune the comment a bit).
Thanks,
Segher
