Re: [PATCH] Use xchg for -Os (PR target/92549)

2019-12-01 Thread Uros Bizjak
On Sun, Dec 1, 2019 at 6:55 PM Jakub Jelinek wrote: > > On Sun, Dec 01, 2019 at 03:43:37PM +0100, Jan Hubicka wrote: > > > PR target/92549 > > > * config/i386/i386.md (peephole2 for *swap): New peephole2. > > > > > > * gcc.target/i386/pr92549.c: New test. > > > > It is very hard to ge

Re: [PATCH] Support multi-versioning on self-recursive function (ipa/92133)

2019-12-01 Thread Feng Xue OS
Done. -Thanks Feng From: Jeff Law Sent: Monday, December 2, 2019 4:33 AM To: Feng Xue OS; Martin Jambor; Jan Hubicka; Richard Biener Cc: luoxhu; gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Support multi-versioning on self-recursive function (ipa/9213

Re: [PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

2019-12-01 Thread Sandra Loosemore
Ping! On 11/13/19 9:27 AM, Sandra Loosemore wrote: This patch series lays some groundwork for the project to redo the OpenACC "kernels" region support in GCC, described in Thomas Schwinge's recent talk at the GNU Cauldron: https://gcc.gnu.org/wiki/cauldron2019talks?action=AttachFile&do=view&tar

Re: [PATCH, GCC/testsuite] Fix dump-noaddr dumpbase

2019-12-01 Thread Andrew Pinski
On Tue, Dec 5, 2017 at 11:27 AM Mike Stump wrote: > > On Dec 5, 2017, at 11:11 AM, Thomas Preudhomme > wrote: > > > > On 05/12/17 17:54, Andrew Pinski wrote: > >> On Tue, Dec 5, 2017 at 9:50 AM, Thomas Preudhomme > >> wrote: > >>> Hi, > >>> > >>> dump-noaddr test FAILS when $tmpdir is not the s

[PATCH v2, committed] Fix bugs relating to flexibly-sized objects in nios2 backend.

2019-12-01 Thread Sandra Loosemore
I've checked in this patch to fix PR target/92499 in a more restricted way than my initial patch, without breaking ABI compatibility. This version of the patch is for the nios2 backend only although (as I noted in the issue) I'm pretty sure other backends have similar problems. I've fixed the

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

2019-12-01 Thread Eric Gallager
On 11/16/19, Thomas Schwinge wrote: > Hi David! > > On 2019-11-15T20:22:47-0500, David Malcolm wrote: >> This patch kit > > (I have not looked at the patches.) ;-) > >> introduces a static analysis pass for GCC that can diagnose >> various kinds of problems in C code at compile-time (e.g. double

Re: [PATCH 00/49] RFC: Add a static analysis framework to GCC

2019-12-01 Thread Eric Gallager
On 11/20/19, Richard Biener wrote: > On Tue, Nov 19, 2019 at 11:02 PM David Malcolm wrote: >> >> > > The checker is implemented as a GCC plugin. >> > > >> > > The patch kit adds support for "in-tree" plugins i.e. GCC plugins >> > > that >> > > would live in the GCC source tree and be shipped as p

Re: [C++ PATCH] c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.

2019-12-01 Thread Marek Polacek
On Thu, Nov 28, 2019 at 11:29:20PM -0500, Jason Merrill wrote: > Sounds like reduced_constant_expression_p needs to deal better with empty > bases. This got a bit complicated because it also needs to handle unions and now we also need to heed vptr. But the following seems to work. (I'll skip the

Re: [PATCH] Support multi-versioning on self-recursive function (ipa/92133)

2019-12-01 Thread Jeff Law
On 11/26/19 6:44 PM, Feng Xue OS wrote: > Hi, Richard, > > This patch is a not bugfix, while it is small. Martin and Honza are fine > with it. > But now we are in stage 3, is it ok to commit? Yes. It was posted well in advance of the stage1->stage3 change. Please commit it ASAP so the testers

Re: [PATCH][RFC] Add new ipa-reorder pass

2019-12-01 Thread Jan Hubicka
Hi, I was playing with it a bit more and built with -fno-profile-reorder-functions. Here is -fno-profile-reorder-functions compared to first run https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=3d537be0cb37458e7928f69a37efb2a6d6b85eae&newProject=try&newRevi

Re: [PATCH] Use xchg for -Os (PR target/92549)

2019-12-01 Thread Jakub Jelinek
On Sun, Dec 01, 2019 at 03:43:37PM +0100, Jan Hubicka wrote: > > PR target/92549 > > * config/i386/i386.md (peephole2 for *swap): New peephole2. > > > > * gcc.target/i386/pr92549.c: New test. > > It is very hard to get a testcase, unforutnately, but I got the > following (locally non

Fix jump function update in inliner

2019-12-01 Thread Jan Hubicka
Hi, this patch fixes the problem with clearing bits and m_vr in inliner update we discussed earlier. I am not sure if dete_type_change_from_memory_writes needs the clear? Bootstrapped/regtested x86_64-linux, Martin, does it make sense? Honza * ipa-prop.c (ipa_set_jf_unknown): Do not cle

Fix profile_count comparsions with gcov_type

2019-12-01 Thread Jan Hubicka
Hi, this patch fixes one extra (and I hope last) place where we mix up global and local porfile. Bootstrapped/regtested x86_64-linux, comitted. Honza * profile-count.h (profile_count::operator<): Use IPA value for comparsion. (profile_count::operator>): Likewise.

Re: Fix crossmodule ipa-inline hint

2019-12-01 Thread Jan Hubicka
> On Nov 30 2019, Jan Hubicka wrote: > > > * g++.dg/lto/inline-crossmodule-1.h: New testcase. > > * g++.dg/lto/inline-crossmodule-1_0.C: New testcase. > > * g++.dg/lto/inline-crossmodule-1_1.C: New testcase. > > ERROR: (DejaGnu) proc "scan-wpa-ipa-times {Inlined ret1} 1 inlined" does

Re: [PATCH] Use xchg for -Os (PR target/92549)

2019-12-01 Thread Jan Hubicka
> Hi! > > xchg instruction is smaller, in some cases much smaller than 3 moves, > (e.g. in the testcase 2 bytes vs. 8 bytes), and is not a performance > disaster, but from Agner Fog tables and > https://stackoverflow.com/questions/45766444/why-is-xchg-reg-reg-a-3-micro-op-instruction-on-modern-int

Re: Fix crossmodule ipa-inline hint

2019-12-01 Thread Andreas Schwab
On Nov 30 2019, Jan Hubicka wrote: > * g++.dg/lto/inline-crossmodule-1.h: New testcase. > * g++.dg/lto/inline-crossmodule-1_0.C: New testcase. > * g++.dg/lto/inline-crossmodule-1_1.C: New testcase. ERROR: (DejaGnu) proc "scan-wpa-ipa-times {Inlined ret1} 1 inlined" does not exi

Re: [PATCH][RFC] Add new ipa-reorder pass

2019-12-01 Thread Jan Hubicka
> > Hi. > > > > I'm sending v3 of the patch where I changed: > > - function.cold sections are properly put into .text.unlikely and > > not into a .text.sorted.XYZ section > > > > I've just finished measurements and I still have the original speed up > > for tramp3d: > > Total runs: 10, before:

Re: [PATCH][RFC] Add new ipa-reorder pass

2019-12-01 Thread Jan Hubicka
> Hi. > > I'm sending v3 of the patch where I changed: > - function.cold sections are properly put into .text.unlikely and > not into a .text.sorted.XYZ section > > I've just finished measurements and I still have the original speed up > for tramp3d: > Total runs: 10, before: 13.92, after: 13.8