The GCC 7 branch is now closed

The GCC 7 branch is now closed, the GCC 7.5 release process is running after which no further commits are accepted on the branch. Thanks for your cooperation. Richard.

[committed] change normalize_{addresses,symbolics} to work in place

As per Andrew's change returning results by reference instead of value here: https://gcc.gnu.org/ml/gcc-patches/2019-11/msg00645.html ...attached are the analogous changes to normalize_address and normalize_symbolics. Tested on x86-64 Linux. Committed as obvious. Aldy commit 895d6d518988221

Re: [PATCH 2/2] gdbinit.in: fix wrong reference to function argument

On Ср, ноя 13, 2019 at 15:23, Jason Merrill wrote: On Wed, Nov 13, 2019 at 6:39 AM Segher Boessenkool wrote: On Tue, Nov 12, 2019 at 04:17:17PM +0300, Konstantin Kharlamov wrote: > On Вт, ноя 12, 2019 at 14:08, Andreas Schwab > wrote: > >On Nov 12 2019, Konstantin Kharlamov wrote: > >

Re: [PATCH, testsuite] Fix PR92464 by adjust test case loop bound

Hi Segher, on 2019/11/13 下午6:42, Segher Boessenkool wrote: > Hi! > > On Wed, Nov 13, 2019 at 03:31:11PM +0800, Kewen.Lin wrote: >> As PR92464 shows, the recent vectorization cost adjustment on load >> insns is responsible for this regression. It leads the profitable >> min iteration count to cha

Ping*2: [PATCH v5] Missed function specialization + partial devirtualization

Rebase to trunk including void gimple_ic_transform. This patch aims to fix PR69678 caused by PGO indirect call profiling performance issues. The bug that profiling data is never working was fixed by Martin's pull back of topN patches, performance got GEOMEAN ~1% improvement(+24% for 511.povray_r

[PATCH] Fix libstdc++ build on macOS

Bootstrap-building libstdc++ on macOS Sierra 10.12.6 (x86_64-apple-darwin16.7.0) fails with the following linker error: Undefined symbols for architecture x86_64: "__ZSt15__alloc_on_copyISaIcEEvRT_RKS1_", referenced from: __ZNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEE6a

Support C2x [[]] attributes for C

This patch adds support for the C2x [[]] attribute syntax to the C front end. Support is only added for C at this point, not for Objective-C; I intend to add the unbounded lookahead required to support it for Objective-C in a followup patch, but maybe not in development stage 1. The syntax is sup

Re: [PATCH] Add `--with-install-sysroot=' configuration option

On Thu, 14 Nov 2019, Maciej W. Rozycki wrote: > Questions, comments, OK to apply? 1. This needs documentation in install.texi. 2. A common macro in config/ would be better than duplicating code in each configure.ac file. 3. To confirm (this should be made clear in the documentation), this is

Re: [PATCH 1/2] Introduce dg-require-target-object-format

On Thu, 7 Nov 2019, Egeyar Bagcioglu wrote: > On 11/7/19 8:47 AM, Segher Boessenkool wrote: > > On Wed, Nov 06, 2019 at 06:21:33PM +0100, Egeyar Bagcioglu wrote: > > > +proc dg-require-target-object-format { args } { > > > +if { [gcc_target_object_format] == [lindex $args 1] } { > > > + return

[PATCH] Add `--with-install-sysroot=' configuration option

Provide means, in the form of a `--with-install-sysroot=' configuration option, to override the default installation directory for target libraries, otherwise known as $toolexeclibdir. This is so that it is possible to get newly-built libraries, particularly the shared ones, installed in a com

Re: [PATCH] Add support for C++2a stop_token

The attached patch should be a complete implementation of C++20 stop_token, jthread, and changes to condition_variable_any which also addresses the comments on the previous patch. From 2cdaa367ed919b24f3bbb84d6f7391a350dce77b Mon Sep 17 00:00:00 2001 From: Thomas Rodgers Date: Wed, 13 Nov 2019 17

Re: [PATCH] Switch gcc ftp URL's to http

On Wed, 13 Nov 2019, Janne Blomqvist wrote: > For me, when I use my normal web browser (firefox), it does redirect > to https. But I'm using the "HTTPS everywhere" extension, so I'm not > sure if it's the extension that does it, or if the server redirects > me, or if it's some other web-security-t

Re: Fix ICE when inlining into function containing polymorphic call

On Wed, Nov 13, 2019 at 10:08:23PM +0100, Jan Hubicka wrote: > PR c++/92421 > * ipa-prop.c (update_indirect_edges_after_inlining): > Mark parameter as used. > * ipa-inline.c (recursive_inlining): Reset node cache > after inlining. > (inline_small_functions): Remo

Re: [C++] Fix interaction between aka changes and DR1558 (PR92206)

On Wed, Nov 13, 2019 at 08:44:31AM +, Richard Sandiford wrote: > PR c++/92206 > * g++.dg/cpp0x/alias-decl-pr92206-1.C: New test. > * g++.dg/cpp0x/alias-decl-pr92206-2.C: Likewise. > * g++.dg/cpp0x/alias-decl-pr92206-3.C: Likewise. This last test FAILs with -std=c++11: /

Re: [Patch] PR fortran/92470 Fixes for CFI_address

On Tue, Nov 12, 2019 at 03:42:23PM +0100, Tobias Burnus wrote: > 2019-12-11 Tobias Burnus > > libgfortran/ > PR fortran/92470 > * runtime/ISO_Fortran_binding.c (CFI_address): Handle non-zero > lower_bound; update error message. > (CFI_allocate): Fix comment typo. >

Re: [PATCH] Relax lto-dump.o dependency.

> Hi. > > Current lto-dump.o relies on some FE generated files as > pre-requirement. That hover delays LTO linking of the lto-dump > and so that I adjusted the dependency to LTO_OBJS which will > work as well. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready t

Re: Ping: [PATCH v4, rs6000] Replace X-form addressing with D-form addressing in new pass for Power9

On 10/25/19 8:30 PM, Kelvin Nilsen wrote: > > This patch adds a new optimization pass for rs6000 targets. > > This new pass scans existing rtl expressions and replaces X-form loads and > stores with rtl expressions that favor selection of the D-form instructions > in contexts for which the D

[PATCH] Remove vestiges of MODIFY_JNI_METHOD_CALL

I happened to notice that MODIFY_JNI_METHOD_CALL was defined in cygming.h and documented in tm.texi. However, because it was only needed for gcj, it is obsolete. This patch removes the vestiges. Tested by grep, and rebuilding the documentation. gcc/ChangeLog 2019-11-13 Tom Tromey *

Re: [PATCH] libsupc++: Implement comparison algorithms for C++20

On 13/11/19 18:52 +0100, Daniel Krügler wrote: Am Mi., 13. Nov. 2019 um 17:26 Uhr schrieb Jonathan Wakely : This is incomplete because std::strong_order doesn't support floating-point types. I'm wondering whether the local __cat lambda expression at the beginning of __fp_weak_ordering is part

Fix ICE when inlining into function containing polymorphic call

Hi, the testcase causes inline context cache to go out of sync because I forgot to update used flags of parameters in one path of update_indirect_edges_after_inlining. While debugging it I also added better consistency check to ipa-inline-analysis and turned ipa-inline test from ifdef to -fcheckin

Re: [PATCH] Switch gcc ftp URL's to http

On Wed, Nov 13, 2019 at 10:41 PM Andrew Pinski wrote: > > On Wed, Nov 13, 2019 at 12:37 PM Janne Blomqvist > wrote: > > > > The FTP protocol is getting long in the tooth, and we should emphasize > > HTTP where that is available. This patch changes various gcc.gnu.org > > URL's to instead use HTTP

Re: [PATCH] Switch gcc ftp URL's to http

On Wed, Nov 13, 2019 at 12:37 PM Janne Blomqvist wrote: > > The FTP protocol is getting long in the tooth, and we should emphasize > HTTP where that is available. This patch changes various gcc.gnu.org > URL's to instead use HTTP. May I suggest you use https instead of http here? Because it will

[PATCH] Switch gcc ftp URL's to http

The FTP protocol is getting long in the tooth, and we should emphasize HTTP where that is available. This patch changes various gcc.gnu.org URL's to instead use HTTP. For instance, kernel.org shut down FTP access in 2017, with the explanation: - The protocol is inefficient and requires adding awk

Re: [PATCH 1/4] Preliminary m68k patches

On 11/13/19 6:08 AM, Bernd Schmidt wrote: > This tidies up a few spots in the m68k backend in preparation for the > large patch to follow. This is purely for review purposes: this patch > has not been tested independently, and will be committed together with > the following one. > > Noteworthy ch

Re: [PATCH 1/2] gdbinit.in: call a function with "call", not "set"

On 11/13/19 4:20 AM, Segher Boessenkool wrote: > Hi! > > On Tue, Nov 12, 2019 at 02:47:33PM +0300, Konstantin Kharlamov wrote: >> Last time a command that calls a function of debuggee with "set" was >> added is 2013 year. Apparently something has changed since then, since >> doing "set foo()" in g

Re: [PATCH 3/5] Use func_checker::hash_operand for hashing of GIMPLE operands.

On 11/8/19 1:31 AM, Martin Liska wrote: > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf-gimple.h (func_checker::func_checker): Add > default constructor. > * ipa-icf.c (sem_function::init): Make operand_equal_p > and hash_operand public. > (sem_item::ad

Re: [PATCH 5/5] Update statistics about needed symbols in IPA ICF.

On 11/11/19 6:38 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf.c (sem_item_optimizer::execute): Save > loaded_symbols. > (sem_item_optimizer::parse_nonsingleton_classes): > Return number of loaded symbols. > (sem_item_optimi

Re: [PATCH 2/5] Update dump message in IPA ICF.

On 11/8/19 12:13 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf-gimple.c (func_checker::compare_gimple_call): Update > bail out reason. > (func_checker::compare_gimple_assign): Likewise. OK jeff

Re: [PATCH 4/5] Handle FIELD_DECL in IPA ICF.

On 11/8/19 3:01 AM, Martin Liska wrote: > > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf-gimple.c (func_checker::hash_operand): Improve > func_checker::hash_operand by handling of FIELD_DECLs. OK jeff

Fix gcc.dg/tree-prof/crossmodule-indircall-1.c

Hi, this patch fixes reversed test I managed to get into last minute cleanup of a patch. It also fixes ICE when descriptors are missing. This happens during profiledbootstrap though I will further look into why such infos are around at all. Bootstrapped/regtested x86_64-linux, comitted.

Fix verify_propagated_use ICE during profiledbootstrap

Hi, this patch fixes problem with ipa-cp ICEing while building gnatbind during profiledbootstrap. The problem is that I was overzelaous about ignoring callers with optimization disabled. Nothing useful can be propagated across them but we still need to process calle after the caller so we further

Re: [PATCH] [MIPS] Sanitize the constant argument for rotr3

On 12.11.2019. 16:29, Jeff Law wrote: > On 11/12/19 7:56 AM, Dragan Mladjenovic wrote: >> From: "Dragan Mladjenovic" >> >> This was dormant for quite some time, but it started happening for me >> on gcc.c-torture/compile/pr65153.c sometime after r276645 for -mabi=32 linux >> runs. >> >> The patt

Re: [PATCH 0/4] Eliminate cc0 from m68k

On 11/13/19 6:04 AM, Bernd Schmidt wrote: > This is a set of patches to convert m68k so that it no longer uses cc0. > The approach is to combine cc0 setter/user pairs into cbranch and cstore > patterns. It does not expose the flag register directly. Since m68k is a > target that is not under active

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

On 11/6/19 10:21 AM, Egeyar Bagcioglu wrote: > Hello, > > I would like to propose the following patches which introduce a compile > option --record-gcc-command-line. When passed to gcc, it saves the command > line option into the produced object file. The option makes it trivial to > trace back

Re: [PATCH 0/4] Eliminate cc0 from m68k

On Wed, Nov 13, 2019 at 07:57:58PM +0100, Bernd Schmidt wrote: > On 11/13/19 7:16 PM, Segher Boessenkool wrote: > > I tried this out with a kernel build (just the defconfig). > > > during RTL pass: jump2 > > /home/segher/src/kernel/fs/binfmt_elf.c: In function 'elf_core_dump': > > /home/segher/src

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

On 11/13/19 2:37 AM, Martin Liška wrote: >> >> As Nick also mentioned many times, -grecord-gcc-switches is in DWARF >> and this causes a great disadvantage: it gets stripped out. > > Well, that's still something I disagree. I bet RedHat is similarly to > openSUSE also building all packages with a

[PATCH] implement pre-c++20 contracts

Hello, Attached is a patch that implements pre-c++20 contracts. This comes from a long running development branch which included ChangeLog entries as we went, which are included in the patch itself. The repo and initial wiki are located here: https://gitlab.com/lock3/gcc-new/wikis/GCC-with-Contrac

Re: [PATCH 0/4] Eliminate cc0 from m68k

On 11/13/19 7:16 PM, Segher Boessenkool wrote: > I tried this out with a kernel build (just the defconfig). > during RTL pass: jump2 > /home/segher/src/kernel/fs/binfmt_elf.c: In function 'elf_core_dump': > /home/segher/src/kernel/fs/binfmt_elf.c:2409:1: internal compiler error: in > patch_jump_i

Re: [PATCH 0/4] Eliminate cc0 from m68k

On Wed, Nov 13, 2019 at 02:04:59PM +0100, Bernd Schmidt wrote: > This is a set of patches to convert m68k so that it no longer uses cc0. I tried this out with a kernel build (just the defconfig). First problem was patch 4 doesn't apply, it has white-space damage. It's small, I fixed that up manu

Re: [PATCH] libsupc++: Implement comparison algorithms for C++20

Am Mi., 13. Nov. 2019 um 17:26 Uhr schrieb Jonathan Wakely : > > This is incomplete because std::strong_order doesn't support > floating-point types. I'm wondering whether the local __cat lambda expression at the beginning of __fp_weak_ordering is part of the incomplete code or just spurious? - D

Re: extract independent value_range bits to value-range.cc

On 11/13/19 12:12 PM, Aldy Hernandez wrote: tree-vrp.* is large and difficult to follow, in part because it has a hodgepodge of different interdependent things (value ranges bits, equivalences stuff, actual value range propagation things, etc etc). This patch pulls out the value_range function

extract independent value_range bits to value-range.cc

tree-vrp.* is large and difficult to follow, in part because it has a hodgepodge of different interdependent things (value ranges bits, equivalences stuff, actual value range propagation things, etc etc). This patch pulls out the value_range functionality into its own files: value-range.h and

Re: [PATCH] errno can't alias locals (PR 92412)

On 11/12/19 1:04 AM, Richard Biener wrote: On Mon, Nov 11, 2019 at 11:38 PM Martin Sebor wrote: The conditional in default_ref_may_alias_errno has the function return true even for local variables, implying that locals must be assumed not to have been changed across calls to errno-setting func

[PATCH 1/2] Move loop and switch tree data structures from cp/ to c-family/.

This patch moves the definitions for DO_STMT, FOR_STMT, WHILE_STMT, SWITCH_STMT, BREAK_STMT, and CONTINUE_STMT from the C++ front end to c-family. This includes the genericizers, pretty-printers, and dump support as well as the tree definitions and accessors. Some related code for OMP_FOR and sim

[PATCH 2/2] Change C front end to emit structured loop and switch tree nodes.

2019-11-12 Sandra Loosemore gcc/c * c-decl.c (c_break_label, c_cont_label): Delete, and replace with... (in_statement): New. (start_function): Adjust for above change. (c_push_function_context, c_pop_function_context): Likewise. * c-lang.h

[PATCH 0/2] Make C front end share the C++ tree representation of loops and switches

This patch series lays some groundwork for the project to redo the OpenACC "kernels" region support in GCC, described in Thomas Schwinge's recent talk at the GNU Cauldron: https://gcc.gnu.org/wiki/cauldron2019talks?action=AttachFile&do=view&target=OpenACC+kernels-cauldron2019.pdf Briefly, the lar

[PATCH] libsupc++: Implement comparison algorithms for C++20

This is incomplete because std::strong_order doesn't support floating-point types. The partial_order and weak_order tests use VERIFY instead of static_assert because of PR 92431. * libsupc++/compare (strong_order, weak_order, partial_order) (compare_strong_order_fallback, compare

Re: [PATCH 3/4] Set costs for jumps in combine

Hi! On Wed, Nov 13, 2019 at 02:13:48PM +0100, Bernd Schmidt wrote: > The combiner is somewhat strange about how it uses costs. If any of the > insns involved in a comparison have a cost of 0, it does not verify that > the substitution is cheaper. "Cost 0" means "unknown cost". This isn't just co

Re: [8/n] Replace autovectorize_vector_sizes with autovectorize_vector_modes

Richard Biener writes: > On Tue, Nov 12, 2019 at 6:54 PM Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On Wed, Oct 30, 2019 at 4:58 PM Richard Sandiford >> > wrote: >> >> >> >> Richard Biener writes: >> >> > On Fri, Oct 25, 2019 at 2:37 PM Richard Sandiford >> >> > wrote: >> >>

Re: [PATCH] Enable VPOPCNTDQ for icelake-{client,server} and tigerlake.

On Wed, Nov 13, 2019 at 4:25 PM Martin Liška wrote: > > Hi. > > The patch adds a missing feature for PTA_ICELAKE_CLIENT and > inherited CPUs. One can see that: > https://en.wikipedia.org/wiki/AVX-512#CPUs_with_AVX-512 > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > R

Re: [PATCH] Add if-chain to switch conversion pass.

Hi, On Wed, 13 Nov 2019, Martin Liška wrote: > > Not a review, just a few questions: > > Hello. > > Thank you for it. > > > > > 1) what does it do if __builtin_expect* has been used, does it preserve > > the probabilities and if in the end decides to expand as ifs, are those > > proba

Re: [C++ PATCH] c++/89070 - bogus [[nodiscard]] warning in SFINAE.

OK. On Tue, Nov 12, 2019 at 11:45 AM Marek Polacek wrote: > This is a complaint that we issue a [[nodiscard]] warning even in SFINAE > contexts. Here 'complain' is tf_decltype, but not tf_warning so I guess > we can fix it as below. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > >

Re: [PATCH][DOC] Document -fallocation-dce.

On 11/13/19 6:45 AM, Martin Liška wrote: Hi. The patch is about a documentation entry for a newly added option in GCC 10. Ready for trunk? I thought this would be OK, until I saw: +Enabled by default. At the beginning of invoke.texi where it is talking about options having both -foo and

[PATCH] Enable VPOPCNTDQ for icelake-{client,server} and tigerlake.

Hi. The patch adds a missing feature for PTA_ICELAKE_CLIENT and inherited CPUs. One can see that: https://en.wikipedia.org/wiki/AVX-512#CPUs_with_AVX-512 Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-11-13 Mar

Re: [PATCH 3/X] [libsanitizer] Add option to bootstrap using HWASAN

On 12/11/2019 12:08, Martin Liška wrote: > On 11/11/19 5:03 PM, Matthew Malcomson wrote: >> Ah! >> My apologies -- I sent up a series with a few documentation mistakes. >> (the others were wording problems so less noticeable) > > That's fine, I fixed that very easily. > > Right now, I can confirm

Re: [PATCH 2/2] gdbinit.in: fix wrong reference to function argument

On Wed, Nov 13, 2019 at 6:39 AM Segher Boessenkool < seg...@kernel.crashing.org> wrote: > On Tue, Nov 12, 2019 at 04:17:17PM +0300, Konstantin Kharlamov wrote: > > On Вт, ноя 12, 2019 at 14:08, Andreas Schwab > > wrote: > > >On Nov 12 2019, Konstantin Kharlamov wrote: > > >> I'm definitely missin

[committed] place value_range_kind at the end of value_range constructors

This patch rewrites the value_range constructors so that value_range_kind is at the end, and defaults to VR_RANGE. This reduces the constructors by 2, and simplifies a lot of the common cases to read: value_range foo(x, y); blah.set(x,y); instead of: value_range foo(V

Re: [PATCH] errno can't alias locals (PR 92412)

On Tue, Nov 12, 2019 at 11:13 AM Andreas Schwab wrote: > > On Nov 12 2019, Richard Biener wrote: > > > This means a tentative definition for 'errno' is non-conforming? > > https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/errno.h.html > > If a macro definition is suppressed in order to ac

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

On Tue, 12 Nov 2019 at 12:17, Richard Earnshaw (lists) wrote: > > On 18/10/2019 14:18, Christophe Lyon wrote: > > +thumb1_gen_const_int (rtx op0, HOST_WIDE_INT op1) > > +{ > > + bool mov_done_p = false; > > + int i; > > + > > + /* Emit upper 3 bytes if needed. */ > > + for (i = 0; i < 3; i++)

Re: Ping: [PATCH V6] Extend IPA-CP to support arithmetically-computed value-passing on by-ref argument (PR ipa/91682)

On Wed, Nov 13 2019, Feng Xue OS wrote: > Thanks. > > And for this issue, we can add a new tracker as a followup task. It's now PR 92497. Thanks, Martin > > Feng > > > From: Jan Hubicka > Sent: Tuesday, November 12, 2019 8:34 PM > To: Feng Xue OS > Cc

Re: [C++ PATCH] Sorry about <=> on VECTOR_TYPE.

On Tue, Nov 12, 2019 at 10:52 AM Jakub Jelinek wrote: > > On Tue, Nov 12, 2019 at 10:19:49AM +0100, Richard Biener wrote: > > On Tue, Nov 12, 2019 at 10:02 AM Jakub Jelinek wrote: > > > > > > On Tue, Nov 12, 2019 at 09:10:58AM +0100, Richard Biener wrote: > > > > On Tue, Nov 12, 2019 at 5:54 AM J

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

On Tue, 12 Nov 2019 at 12:13, Richard Earnshaw (lists) wrote: > > On 18/10/2019 14:18, Christophe Lyon wrote: > > + bool not_supported = arm_arch_notm || flag_pic || TARGET_NEON; > > > > This is a poor name in the context of the function as a whole. What's > not supported. Please think of a

Re: [PATCH] Sort debug counter names.

On Tue, Nov 12, 2019 at 10:01 AM Martin Liška wrote: > > On 11/12/19 9:39 AM, Richard Biener wrote: > > On Tue, Nov 12, 2019 at 8:50 AM Martin Liška wrote: > >> > >> On 11/11/19 3:20 PM, Richard Biener wrote: > >>> On Mon, Nov 11, 2019 at 9:23 AM Martin Liška wrote: > > Hi. > > >>

[PATCH] PR c++/92403

Suppress diagnostics when substituting into requires-expressions outside of concept definitions. This change broke one existing test, which I've updated to match the behavior of the current patch. Specifically, it changed the case below: template constexpr bool subst = true; template constexpr b

Re: [PATCH 2/2] [ARM] Add support for -mpure-code in thumb-1 (v6m)

Hi Kyrill, On Tue, 12 Nov 2019 at 11:34, Kyrill Tkachov wrote: > > Hi Christophe, > > On 10/18/19 2:18 PM, Christophe Lyon wrote: > > Hi, > > > > This patch extends support for -mpure-code to all thumb-1 processors, > > by removing the need for MOVT. > > > > Symbol addresses are built using uppe

Re: Ping: [PATCH V6] Extend IPA-CP to support arithmetically-computed value-passing on by-ref argument (PR ipa/91682)

> On Tue, Nov 12, 2019 at 2:27 PM Jan Hubicka wrote: > > > > > Hi, > > > > > > On Tue, Nov 12 2019, Jan Hubicka wrote: > > > > Also note that there is a long standing problem with inlining ipacp > > > > clones. This can be shown on the following example: > > > > > > > > struct a {int a;}; > > > >

Re: [PATCH] include size and offset in -Wstringop-overflow

On Tue, Nov 12, 2019 at 6:55 PM Jeff Law wrote: > > On 11/12/19 1:15 AM, Richard Biener wrote: > > On Tue, Nov 12, 2019 at 6:10 AM Jeff Law wrote: > >> > >> On 11/6/19 3:34 PM, Martin Sebor wrote: > >>> On 11/6/19 2:06 PM, Martin Sebor wrote: > On 11/6/19 1:39 PM, Jeff Law wrote: > > On

Re: handle VIEW_CONVERT_EXPR in debug_node

On Tue, Nov 12, 2019 at 8:49 PM Ulrich Drepper wrote: > > I am using debug_node() to emit the tree of functions for later > processing. For this I need all the information to be present. So far > I came across one expression type that isn't handled correctly. For > VIEW_CONVERT_EXPR only the ty

Re: [PATCH] contrib/download_prerequisites: Use http instead of ftp

On Tue, Nov 12, 2019 at 8:34 PM Janne Blomqvist wrote: > > Convert the download_prerequisites script to use http instead of > ftp. This works better with firewalls, proxies, and so on. It's also > faster, a quick test on my system before patch: > > time contrib/download_prerequisites --directory=/

Re: [8/n] Replace autovectorize_vector_sizes with autovectorize_vector_modes

On Tue, Nov 12, 2019 at 6:54 PM Richard Sandiford wrote: > > Richard Biener writes: > > On Wed, Oct 30, 2019 at 4:58 PM Richard Sandiford > > wrote: > >> > >> Richard Biener writes: > >> > On Fri, Oct 25, 2019 at 2:37 PM Richard Sandiford > >> > wrote: > >> >> > >> >> This is another patch in

Re: Ping Re: Add C2x *_NORM_MAX constants to

On Wed, Nov 13, 2019 at 02:10:34PM +, Joseph Myers wrote: > Ping. This patch > is pending > review. Ok. Jakub

[committed] Add a few missing checks that IPA_NODE_REF is not NULL (PR 92454)

Hi, since IPA_NODE_REF does not create summaries now, IPA-CP's spread_undeadness can attempt to dereference a NULL one when a thunk is a part of an SCC in the call graph (because of speculative devirtualization edges). Fixed with checking that is not the case. Bootstrapped and tested on x86_64-l

Re: [PATCH] Refactor tree-loop-distribution for thread safety

On Tue, Nov 12, 2019 at 2:31 PM Giuliano Belinassi wrote: > > Hi, Richard. > > On 11/12, Richard Biener wrote: > > On Sat, Nov 9, 2019 at 3:26 PM Giuliano Belinassi > > wrote: > > > > > > Hi all, > > > > > > This patch refactors tree-loop-distribution.c for thread safety without > > > use of C11

Ping Re: Add C2x *_NORM_MAX constants to

Ping. This patch is pending review. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] PR90838: Support ctz idioms

On Tue, Nov 12, 2019 at 3:36 PM Wilco Dijkstra wrote: > > Hi, > > Support common idioms for count trailing zeroes using an array lookup. > The canonical form is array[((x & -x) * C) >> SHIFT] where C is a magic > constant which when multiplied by a power of 2 contains a unique value > in the top 5

Re: Ping: [PATCH V6] Extend IPA-CP to support arithmetically-computed value-passing on by-ref argument (PR ipa/91682)

On Tue, Nov 12, 2019 at 2:27 PM Jan Hubicka wrote: > > > Hi, > > > > On Tue, Nov 12 2019, Jan Hubicka wrote: > > > Also note that there is a long standing problem with inlining ipacp > > > clones. This can be shown on the following example: > > > > > > struct a {int a;}; > > > static int foo (str

[PATCH][DOC] Document -fallocation-dce.

Hi. The patch is about a documentation entry for a newly added option in GCC 10. Ready for trunk? Martin gcc/ChangeLog: 2019-11-13 Martin Liska PR other/92329 * doc/invoke.texi: Document -fallocation-dce. --- gcc/doc/invoke.texi | 8 +++- 1 file changed, 7 insertions(+

Re: [PATCH 1/5] Do not overuse push/pop_cfun in IPA ICF.

On Wed, Nov 13, 2019 at 10:22 AM Martin Liska wrote: > OK. > gcc/ChangeLog: > > 2019-11-11 Martin Liska > > * ipa-icf.c (sem_function::equals_private): Do not overuse > push/pop_cfun functions. > --- > gcc/ipa-icf.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-

Re: [PATCH] Enhance syntax of -fdbg-cnt.

On Wed, Nov 13, 2019 at 10:15 AM Martin Liška wrote: > > On 11/12/19 10:00 AM, Martin Liška wrote: > > There's one another version that I'm testing right now. > > It survives regression tests and bootstrap. > > Richi, may I install it the patch? Yes. Thanks, Richard. > > Thanks, > Martin

Re: [PATCH] Remove params for a specific optimization option.

On Wed, Nov 13, 2019 at 9:30 AM Martin Liška wrote: > > On 11/13/19 9:20 AM, Jan Hubicka wrote: > >> Hello. > >> > >> The patch is about removal of special *-O2 parameters that Honza added > >> some time > >> ago. Right now, we have a better mechanism how to have a different default > >> value >

[PATCH] Diagnose hard errors during constraint satisfaction

This changes the diagnostic of non-boolean constraints and rvalue conversion failures in constraint satisfaction into hard errors. I also cleaned up the satisfaction routines to reduce the number of functions involved. Jason, this is a squashed version of the patches I sent earlier today. This pa

[PATCH 4/4] Fix autoinc cbranch

After the m68k cc0 conversion, there is one code quality regression that I can see: we no longer generate autoinc addressing modes in comparisons. This is because the parts of the compiler that generate autoinc are unwilling to substitute into jumps. If you look at the code in reload, you'll see t

[PATCH 3/4] Set costs for jumps in combine

The combiner is somewhat strange about how it uses costs. If any of the insns involved in a comparison have a cost of 0, it does not verify that the substitution is cheaper. Also, it does not compute costs for jump insns, so they are always set to zero. As a consequence, any possible substitution i

[PATCH 2/4] The main m68k cc0 conversion

This achieves the conversion by using combined cbranch/cstore patterns, and using a mechanism similar to the cc_status tracking to elide certain comparisons. Unlike cc_status, this is opt-in and requires a flags_valid attribute to be set for suitable instructions. Due to lack of test hardware, th

Re: [PATCH 1/4] Preliminary m68k patches

This tidies up a few spots in the m68k backend in preparation for the large patch to follow. This is purely for review purposes: this patch has not been tested independently, and will be committed together with the following one. Noteworthy changes: Some patterns and peepholes were unified throu

[PATCH 0/4] Eliminate cc0 from m68k

This is a set of patches to convert m68k so that it no longer uses cc0. The approach is to combine cc0 setter/user pairs into cbranch and cstore patterns. It does not expose the flag register directly. Since m68k is a target that is not under active development, and probably receives very limited t

Re: [PATCH 0/7 libgomp,amdgcn] AMD GCN Offloading Support

These patches are now all committed. I've adjusted the changelogs to list all the proper authors (apologies if I missed anyone). Thank you for the quick reviews, Jakub. :-) Andrew On 12/11/2019 13:29, Andrew Stubbs wrote: Hi all, This patch series contributes initial OpenMP and OpenACC suppo

[committed, amdgcn] Move gcn-run heap into GPU memory

I've just committed the attached patch. The patch adjusts the amdgcn-specific gcn-run tool such that it places the heap memory in actual GPU memory (previously it was accessing host memory via PCI). This is a performance optimization, of course, but also matches the conditions that offload k

Re: [PATCH] PR90838: Support ctz idioms

Hi Segher, > Out of interest, what uses this? I have never seen it before. It's used in sjeng in SPEC and gives a 2% speedup on Cortex-A57. Tricks like this used to be very common 20 years ago since a loop or binary search is way too slow and few CPUs supported fast clz/ctz instructions. It's o

Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

> On Tue, Nov 12, 2019 at 04:32:36PM +0100, Ilya Leoshkevich wrote: >>> Am 12.11.2019 um 15:32 schrieb Segher Boessenkool >>> : >>> On Tue, Nov 12, 2019 at 03:11:05PM +0100, Ilya Leoshkevich wrote: unsigned int pass_jump_after_combine::execute (function *) { + /* Jump threadin

[Ada] Fix -fdump-ada-spec issue with array field

This is a regression present on mainline and 9 branch: if the component type of array type is a structure declared in another file, then the binding would contain a local declaration for this structure type. Tested on x86_64-suse-linux, applied on the mainline and 9 branch. 2019-11-13 Eric Bo

Re: [PATCH] Free dominance info at the beginning of pass_jump_after_combine

Hi! On Tue, Nov 12, 2019 at 04:32:36PM +0100, Ilya Leoshkevich wrote: > > Am 12.11.2019 um 15:32 schrieb Segher Boessenkool > > : > > On Tue, Nov 12, 2019 at 03:11:05PM +0100, Ilya Leoshkevich wrote: > >> unsigned int > >> pass_jump_after_combine::execute (function *) > >> { > >> + /* Jump threa

Re: [PATCH] PR90838: Support ctz idioms

Hi! On Tue, Nov 12, 2019 at 02:35:54PM +, Wilco Dijkstra wrote: > Support common idioms for count trailing zeroes using an array lookup. > The canonical form is array[((x & -x) * C) >> SHIFT] where C is a magic > constant which when multiplied by a power of 2 contains a unique value > in the t

Re: [PATCH 2/2] gdbinit.in: fix wrong reference to function argument

On Tue, Nov 12, 2019 at 04:17:17PM +0300, Konstantin Kharlamov wrote: > On Вт, ноя 12, 2019 at 14:08, Andreas Schwab > wrote: > >On Nov 12 2019, Konstantin Kharlamov wrote: > >> I'm definitely missing something. Who are these users, and how can > >>they > >> make anything useful of these functio

Re: [PATCH] Add if-chain to switch conversion pass.

On 11/4/19 3:48 PM, Jakub Jelinek wrote: On Mon, Nov 04, 2019 at 03:23:20PM +0100, Martin Liška wrote: The patch adds a new pass that identifies a series of if-elseif statements and transform then into a GIMPLE switch (if possible). The pass runs right after tree-ssa pass and I decided to implem

Re: [PATCH 1/2] gdbinit.in: call a function with "call", not "set"

Hi! On Tue, Nov 12, 2019 at 02:47:33PM +0300, Konstantin Kharlamov wrote: > Last time a command that calls a function of debuggee with "set" was > added is 2013 year. Apparently something has changed since then, since > doing "set foo()" in gdb to call a "foo()" results in error. > Disregarding, i

Re: [Patch] PR fortran/92470 Fixes for CFI_address

I too had some considerable difficulty on this point. I wasn't at all sure that the C world view was relevant here since the API includes CFI_address and, in principle, one could reference directly the elements pointed to by base_addr. However, I bow to the wisdom of your correspondents on the j3 l

Re: [PATCH] rs6000: Use ULL on big hexadecimal literal

On Wed, Nov 13, 2019 at 09:15:38AM +0100, Richard Henderson wrote: > On 11/12/19 10:52 PM, Segher Boessenkool wrote: > > C++98 does not have long long int, and does not use (unsigned) long > > long int for hexadecimal literals. So let's use an ULL suffix here, > > which is still not strict C++98,

Re: Regression due to recent IPA changes

> This patch: > > > ef0752d323b5a250caf1b972354f3749382c8dce is the first bad commit > > commit ef0752d323b5a250caf1b972354f3749382c8dce > > Author: hubicka > > Date: Mon Nov 4 14:07:09 2019 + > > > > * cgraphclones.c (cgraph_node::create_version_clone): Do not > >

Re: [PATCH, testsuite] Fix PR92464 by adjust test case loop bound

Hi! On Wed, Nov 13, 2019 at 03:31:11PM +0800, Kewen.Lin wrote: > As PR92464 shows, the recent vectorization cost adjustment on load > insns is responsible for this regression. It leads the profitable > min iteration count to change from 19 to 12. The case happens to > hit the threshold. By actu

  1   2   >