[PATCH, rs6000] Support float from/to long conversion vectorization

2019-09-26 Thread Kewen.Lin
Hi, This patch is to add the support for float from/to long conversion vectorization. ISA 2.06 supports the vector version instructions for conversion between float and long long (both signed and unsigned), but vectorizer can't exploit them since the optab check fails. So this patch is mainly to

C++ PATCH for c++/91889 - follow-up fix for DR 2352

2019-09-26 Thread Marek Polacek
It turned out that DR 2352 needs some fixing: as of now, it means that in void f(int*); // #1 void f(const int* const &); // #2 void g(int* p) { f(p); } the call to f is ambiguous. This broke e.g. Boost. I raised this on the CWG reflector and Jason suggested wording that would break this

C++ PATCH for c++/91921 - stray warning with -Woverloaded-virtual

2019-09-26 Thread Marek Polacek
Here we were emitting a stray "by" message if base_fndecl was in a system header but fns was not. As usually, we need to guard such a use. Further, use inform instead of warning_at. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-09-26 Marek Polacek PR c++/91921 - stray w

[FYI] [Ada] set DECL_SIZE_UNIT for zero-sized fields

2019-09-26 Thread Alexandre Oliva
Zero-sized fields do not get processed by finish_record_type: they're removed from the field list before and reinserted after, so their DECL_SIZE_UNIT remains unset, causing the translation of assignment statements with use_memset_p, in quite unusual circumstances, to use a NULL_TREE as the memse

Re: [PATCH 2/2] libada: Respect `--enable-version-specific-runtime-libs'

2019-09-26 Thread Maciej W. Rozycki
On Thu, 26 Sep 2019, Arnaud Charlet wrote: > > Notice that ADA_RTL_OBJ_DIR never changes with/without the use of this > > configuration option (as expected). > > > > Does it answer your question? > > Yes, that's now very clear, thanks! Sorry not to make the original change description clear

Re: [PATCH 1/2] libada: Remove racy duplicate gnatlib installation

2019-09-26 Thread Maciej W. Rozycki
On Thu, 26 Sep 2019, Arnaud Charlet wrote: > Unfortunately the Make-lang.in part is still needed when using the > --disable-libada configure switch so a more elaborate change is needed. Hmm, I've experimented a bit and AFAICT if `--disable-libada' is given without my proposed change applied, th

Re: [PATCH v2, rs6000] Replace X-form addressing with D-form addressing in new pass for Power 9

2019-09-26 Thread Segher Boessenkool
Hi Kelvin, Sorry for the slow review. On Tue, Sep 03, 2019 at 03:10:09PM -0500, Kelvin Nilsen wrote: > This new pass scans existing rtl expressions and replaces them with rtl > expressions that favor selection of the D-form instructions in contexts for > which the D-form instructions are prefer

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Segher Boessenkool
On Fri, Sep 27, 2019 at 12:30:50AM +0200, Jakub Jelinek wrote: > On Thu, Sep 26, 2019 at 05:17:40PM -0500, Segher Boessenkool wrote: > > On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: > > > (insn 14 13 16 2 (parallel [ > > > (set (reg:SI 132) > > > (plus:SI (m

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jakub Jelinek
On Thu, Sep 26, 2019 at 05:17:40PM -0500, Segher Boessenkool wrote: > On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: > > (insn 14 13 16 2 (parallel [ > > (set (reg:SI 132) > > (plus:SI (mult:SI (zero_extend:DI (reg/v:SI 115 [ sec ])) > >

Avoid libbacktrace warnings with old compilers

2019-09-26 Thread Ian Lance Taylor
This patch to libbacktrace avoids a compilation warning when building libbacktrace with an old compiler. This fixes PR 91908. Bootstrapped and ran libbacktrace tests. Committed to mainline. Ian 2019-09-26 Ian Lance Taylor PR libbacktrace/91908 * pecoff.c (backtrace_initialize): Explicitly

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Segher Boessenkool
On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: > (insn 14 13 16 2 (parallel [ > (set (reg:SI 132) > (plus:SI (mult:SI (zero_extend:DI (reg/v:SI 115 [ sec ])) > (zero_extend:DI (reg:SI 124))) > (reg:SI 130))) >

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jakub Jelinek
On Thu, Sep 26, 2019 at 03:27:50PM -0600, Jeff Law wrote: > > Some machines support a multiplication that generates a product wider > > than the operands. Write the pattern for this as > > > > @smallexample > > (mult:@var{m} (sign_extend:@var{m} @var{x}) (sign_extend:@var{m} @var{y})) > > @end sm

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jeff Law
On 9/26/19 10:05 AM, Jakub Jelinek wrote: > On Thu, Sep 26, 2019 at 10:01:56AM -0600, Jeff Law wrote: >> On 9/26/19 9:47 AM, Jakub Jelinek wrote: >>> On Thu, Sep 26, 2019 at 09:39:31AM -0600, Jeff Law wrote: Right. My point is that the multiplication patterns are an exception as well. >>

Re: [PATCH] xtensa: fix PR target/91880

2019-09-26 Thread Max Filippov
On Thu, Sep 26, 2019 at 1:42 PM augustine.sterl...@gmail.com wrote: > > On Tue, Sep 24, 2019 at 5:41 PM Max Filippov wrote: > > > > Xtensa hwloop_optimize segfaults when zero overhead loop is about to be > > inserted as the first instruction of the function. > > Insert zero overhead loop instruct

Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-09-26 Thread Lewis Hyatt
On Thu, Sep 26, 2019 at 4:47 PM Joseph Myers wrote: > > On Thu, 26 Sep 2019, Lewis Hyatt wrote: > > > A couple notes: > > - In order to avoid any portability problems with wchar_t, the > > equivalent of wcwidth() from libc is implemented in-house. > > I'm uneasy about contrib/gen_wcwidth.cpp d

Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-09-26 Thread Joseph Myers
On Thu, 26 Sep 2019, Lewis Hyatt wrote: > A couple notes: > - In order to avoid any portability problems with wchar_t, the > equivalent of wcwidth() from libc is implemented in-house. I'm uneasy about contrib/gen_wcwidth.cpp doing the generation using host libc's wcwidth. The effect is tha

Re: [PATCH] xtensa: fix PR target/91880

2019-09-26 Thread augustine.sterl...@gmail.com
On Tue, Sep 24, 2019 at 5:41 PM Max Filippov wrote: > > Xtensa hwloop_optimize segfaults when zero overhead loop is about to be > inserted as the first instruction of the function. > Insert zero overhead loop instruction into new basic block before the > loop when basic block that precedes the loo

[PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-09-26 Thread Lewis Hyatt
Hello- PR preprocessor/49973 addresses the fact that the column number in diagnostics is not correct if the source lines contain multibyte characters. The attached patch corrects this. The outlines of it were discussed starting here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=49973#c13. If it lo

Re: [Patch, Fortran] CO_BROADCAST for derived types with allocatable components

2019-09-26 Thread Alessandro Fanfarillo
Hi Paul, that message was a copy/paste leftover. It doesn't make any sense in that part of the code, it's now removed. Committed as revision 276164. Thanks! Il giorno dom 15 set 2019 alle ore 12:19 Paul Richard Thomas ha scritto: > > Hi Sandro, > > This patch looks fine to me. I have a questio

[C++ Patch] Improve grokdeclarator error

2019-09-26 Thread Paolo Carlini
Hi, over the last weeks, while working on various batches of location improvements (a new one is forthcoming, in case you are wondering ;) I noticed this grokdeclarator diagnostic, one of those not exercised by our testsuite. While constructing a testcase I realized that probably it's better

Re: [00/32] Support multiple ABIs in the same translation unit

2019-09-26 Thread Dimitar Dimitrov
On Wed, 11 Sep 2019, 22:02:26 EEST Richard Sandiford wrote: > The reason for the PRU differences is that the port defines > targetm.hard_regno_call_part_clobbered, but uses it to test whether > a multi-register value contains a mixture of fully-clobbered and > fully-preserved registers. AFAICT the

A bug with -fprofile-dir? Profile directory concatenated with object file path

2019-09-26 Thread Qing Zhao
Hi, we noticed that the profile directory will be concatenated with object file path. the following small example explain this behavior: [qinzhao@localhost small]$ cat t #! /bin/bash CC=/home/qinzhao/Install/latest/bin/gcc opt="-O3 -fprofile-generate" opt="$opt -fprofile-dir=/home/qinzhao/prof_

[Darwin, PPC, Mode Iterators 2/n] Eliminate picbase expanders.

2019-09-26 Thread Iain Sandoe
Hi Segher, thanks for the pointers to how to simplify this! > On 25 Sep 2019, at 00:23, Segher Boessenkool > wrote: > On Tue, Sep 24, 2019 at 08:31:16PM +0100, Iain Sandoe wrote: >> This switches the picbase load and reload patterns to use the 'P' mode >> iterator instead of writing an SI and

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Paul Koning
> On Sep 26, 2019, at 12:01 PM, Jeff Law wrote: > > On 9/26/19 9:47 AM, Jakub Jelinek wrote: >> On Thu, Sep 26, 2019 at 09:39:31AM -0600, Jeff Law wrote: >>> Right. My point is that the multiplication patterns are an exception as >>> well. >> >> Do you have some evidence for that? > It's in

Re: [PATCH, rs6000] Update powerpc vector load builtins with PURE attribute

2019-09-26 Thread Segher Boessenkool
On Thu, Sep 26, 2019 at 12:06:03PM -0500, Bill Schmidt wrote: > On 9/26/19 12:00 PM, Segher Boessenkool wrote: > >On Thu, Sep 26, 2019 at 10:40:29AM -0500, will schmidt wrote: > >>Update our (rs6000) vector load built-ins with the PURE attribute. These > >>were previously given the MEM attribute,

Re: [PATCH, rs6000] Update powerpc vector load builtins with PURE attribute

2019-09-26 Thread Bill Schmidt
On 9/26/19 12:00 PM, Segher Boessenkool wrote: Hi Will, On Thu, Sep 26, 2019 at 10:40:29AM -0500, will schmidt wrote: Update our (rs6000) vector load built-ins with the PURE attribute. These were previously given the MEM attribute, which meant that redundant loads surrounding the built-in call

Re: [PATCH, rs6000] Update powerpc vector load builtins with PURE attribute

2019-09-26 Thread Segher Boessenkool
Hi Will, On Thu, Sep 26, 2019 at 10:40:29AM -0500, will schmidt wrote: > Update our (rs6000) vector load built-ins with the PURE attribute. These > were previously given the MEM attribute, which meant that redundant loads > surrounding the built-in calls could not be eliminated in earlier passes

[PATCH] Split out nested cycle loop-closed PHI vectorization

2019-09-26 Thread Richard Biener
Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-09-26 Richard Biener * tree-vect-loop.c (vect_analyze_loop_operations): Analyze loop-closed PHIs that are vect_internal_def. (vect_create_epilog_for_reduction): Exit early for nested cycles.

Re: [PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors

2019-09-26 Thread Jonathan Wakely
On 26/09/19 14:20 +0100, Jonathan Wakely wrote: Fix data race when _Safe_iterator_base::_M_detach() runs concurrently with the _Safe_container_base destructor. PR libstdc++/91910 * src/c++11/debug.cc (_Safe_iterator_base::_M_detach()): Load pointer atomically and lock the

[PATCH] Define std::to_array for Debug Mode

2019-09-26 Thread Jonathan Wakely
* include/debug/array (to_array): Define for debug mode. Tested x86_64-linux, committed to trunk. commit 6404cc56a2e300ffcf5f680f0728e695539a137a Author: Jonathan Wakely Date: Thu Sep 26 15:50:30 2019 +0100 Define std::to_array for Debug Mode * include/debug/arra

[PATCH] Implement C++20 constexpr changes to std::pair (P1032R1)

2019-09-26 Thread Jonathan Wakely
* include/bits/stl_pair.h (pair): Add _GLIBCXX20_CONSTEXPR to piecewise construction constructor, assignment operators, and swap. * include/std/tuple (pair::pair(piecewise_construct_t, tuple, tuple)): Add _GLIBCXX20_CONSTEXPR. (pair::pair(tuple, tuple, _Inde

[PATCH] Fix array index error in address_v6 comparisons

2019-09-26 Thread Jonathan Wakely
* include/experimental/internet (operator==, operator<): Fix loop condition to avoid reading past the end of the array. Tested x86_64-linux, committed to trunk. commit f5886e6a2c744196c089b16853d73d64e248a735 Author: Jonathan Wakely Date: Thu Sep 26 14:57:56 2019 +0100 F

[PATCH] Remove include directives for deleted Profile Mode headers

2019-09-26 Thread Jonathan Wakely
* include/std/array: Remove references to profile mode. * include/std/bitset: Likewise. * include/std/deque: Likewise. * include/std/forward_list: Likewise. * include/std/list: Likewise. * include/std/map: Likewise. * include/std/set: Likewis

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jakub Jelinek
On Thu, Sep 26, 2019 at 10:01:56AM -0600, Jeff Law wrote: > On 9/26/19 9:47 AM, Jakub Jelinek wrote: > > On Thu, Sep 26, 2019 at 09:39:31AM -0600, Jeff Law wrote: > >> Right. My point is that the multiplication patterns are an exception as > >> well. > > > > Do you have some evidence for that? >

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jeff Law
On 9/26/19 9:47 AM, Jakub Jelinek wrote: > On Thu, Sep 26, 2019 at 09:39:31AM -0600, Jeff Law wrote: >> Right. My point is that the multiplication patterns are an exception as >> well. > > Do you have some evidence for that? It's in the manual. And yes it potentially makes a huge mess due to th

Re: [libcpp] Issue a pedantic warning for UCNs outside UCS codespace

2019-09-26 Thread Joseph Myers
On Thu, 26 Sep 2019, Eric Botcazou wrote: > > For C, I think such UCNs violate the Semantics but not the Constraints on > > UCNs, so no diagnostic is actually required in C, although it is permitted > > as a pedwarn / error. > > > > However, while C++ doesn't have that Semantics / Constraints div

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jakub Jelinek
On Thu, Sep 26, 2019 at 09:39:31AM -0600, Jeff Law wrote: > Right. My point is that the multiplication patterns are an exception as > well. Do you have some evidence for that? I mean, e.g. simplify-rtx.c will in that case almost certainly misbehave, if some expression can have CONST_INT operand(

Re: [PATCH] Retain TYPE_MODE more often for BIT_FIELD_REFs in get_inner_referece

2019-09-26 Thread Eric Botcazou
> 2019-09-26 Richard Biener > > PR middle-end/91897 > * expr.c (get_inner_reference): For BIT_FIELD_REF with > vector type retain the original mode. > > * gcc.target/i386/pr91897.c: New testcase. This looks good to me, thanks. -- Eric Botcazou

[PATCH, rs6000] Update powerpc vector load builtins with PURE attribute

2019-09-26 Thread will schmidt
Hi, Update our (rs6000) vector load built-ins with the PURE attribute. These were previously given the MEM attribute, which meant that redundant loads surrounding the built-in calls could not be eliminated in earlier passes since they were defined as having the potential to touch memory.

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jeff Law
On 9/26/19 9:22 AM, Jakub Jelinek wrote: > On Thu, Sep 26, 2019 at 09:12:34AM -0600, Jeff Law wrote: >> On 9/26/19 12:49 AM, Jakub Jelinek wrote: >>> On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: (insn 13 12 14 2 (set (reg:SI 124) (const_int -939524096 [0xc8000

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Kyrill Tkachov
On 9/26/19 4:32 PM, Jeff Law wrote: On 9/26/19 9:14 AM, Kyrill Tkachov wrote: On 9/26/19 4:12 PM, Jeff Law wrote: On 9/26/19 12:49 AM, Jakub Jelinek wrote: On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: (insn 13 12 14 2 (set (reg:SI 124) (const_int -939524096 [0xfff

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jeff Law
On 9/26/19 9:14 AM, Kyrill Tkachov wrote: > > On 9/26/19 4:12 PM, Jeff Law wrote: >> On 9/26/19 12:49 AM, Jakub Jelinek wrote: >> > On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: >> >> (insn 13 12 14 2 (set (reg:SI 124) >> >> (const_int -939524096 [0xc800])) "j.c":10

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jakub Jelinek
On Thu, Sep 26, 2019 at 09:12:34AM -0600, Jeff Law wrote: > On 9/26/19 12:49 AM, Jakub Jelinek wrote: > > On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: > >> (insn 13 12 14 2 (set (reg:SI 124) > >> (const_int -939524096 [0xc800])) "j.c":10:54 161 > >> {*arm_movsi_insn

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Kyrill Tkachov
On 9/26/19 4:12 PM, Jeff Law wrote: On 9/26/19 12:49 AM, Jakub Jelinek wrote: > On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: >> (insn 13 12 14 2 (set (reg:SI 124) >> (const_int -939524096 [0xc800])) "j.c":10:54 161 >> {*arm_movsi_insn} >>  (nil)) >> >> (insn

Re: Problem exposed by recent ARM multiply changes

2019-09-26 Thread Jeff Law
On 9/26/19 12:49 AM, Jakub Jelinek wrote: > On Wed, Sep 25, 2019 at 10:06:13PM -0600, Jeff Law wrote: >> (insn 13 12 14 2 (set (reg:SI 124) >> (const_int -939524096 [0xc800])) "j.c":10:54 161 >> {*arm_movsi_insn} >> (nil)) >> >> (insn 14 13 16 2 (parallel [ >> (

[AArch64][SVE2] Shift-Right Accumulate combine patterns

2019-09-26 Thread Yuliang Wang
Hi, This patch adds combining support for SVE2's shift-right accumulate instructions. Example snippet: #define IMM ... void foo (TYPE a, TYPE b, int n) { for (int i = 0; i < n; i++) a[i] += b[i] >> IMM; } Signed: beforeasr z0.s, z0.s, #{IMM} add z0.s,

Re: [PATCH 2/2] libada: Respect `--enable-version-specific-runtime-libs'

2019-09-26 Thread Arnaud Charlet
> Notice that ADA_RTL_OBJ_DIR never changes with/without the use of this > configuration option (as expected). > > Does it answer your question? Yes, that's now very clear, thanks! The change is OK for me, thanks. Arno

[Ada] Remove dependency on To_C/To_Ada

2019-09-26 Thread Arnaud Charlet
A recent change in osint.adb introduced a dependency on To_C/To_Ada subprograms which are (too) recent additions to System.OS_Lib, breaking builds of cross compilers with an older version of GNAT. Even though this is not guaranteed to work, this dependency is relatively easy to lift, so done. Test

[PATCH][PR89924] [missed-optimization] Function not de-virtualized within the same TU

2019-09-26 Thread kamlesh kumar
This patch resolves subjected issue. bootstrapped and regtested on x86_64. ChangeLog: 2019-09-26 Kamlesh Kumar PR ipa/89924 * ipa-polymorphic-call.c (ipa_polymorphic_call_context::ipa_polymorphic_call_context): Updated outer_type. * g++.dg/opt/pr89924.C

Re: [PATCH 2/2] libada: Respect `--enable-version-specific-runtime-libs'

2019-09-26 Thread Maciej W. Rozycki
On Thu, 26 Sep 2019, Arnaud Charlet wrote: > > Respect the `--enable-version-specific-runtime-libs' configuration > > option in libada/, so that shared gnatlib libraries will be installed > > in non-version-specific $(toolexeclibdir) if requested. In a > > cross-compilation environment this he

[PATCH] PR libstdc++/91910 fix data race in Debug Mode destructors

2019-09-26 Thread Jonathan Wakely
Fix data race when _Safe_iterator_base::_M_detach() runs concurrently with the _Safe_container_base destructor. PR libstdc++/91910 * src/c++11/debug.cc (_Safe_iterator_base::_M_detach()): Load pointer atomically and lock the mutex before accessing the sequence. (_S

[PATCH] Do all reduction PHI creation upfront

2019-09-26 Thread Richard Biener
The following patch moves all reduction (and nested cycle) PHI creation upfront, generating vector defs in program order so that even for PHIs the vector defs are present when processing uses. As part of this reorg I also moved the preheader argument filling to the time we create the PHI node (s

Add a simulate_enum_decl langhook

2019-09-26 Thread Richard Sandiford
Similarly to the simulate_builtin_function_decl patch, this one adds a hook for simulating an enum declaration in the source language. Again, the main SVE ACLE patch has tests for various error conditions. Tested on aarch64-linux-gnu and x86_64-linux-gnu. OK to install? Richard 2019-09-26 Ri

Add a simulate_builin_function_decl langhook

2019-09-26 Thread Richard Sandiford
Although it's possible to define the SVE intrinsics in a normal header file, it's much more convenient to define them directly in the compiler. This also speeds up compilation and gives better error messages. The idea is therefore for arm_sve.h (the main intrinsics header file) to have the pragma:

Re: [libcpp] Issue a pedantic warning for UCNs outside UCS codespace

2019-09-26 Thread Eric Botcazou
> For C, I think such UCNs violate the Semantics but not the Constraints on > UCNs, so no diagnostic is actually required in C, although it is permitted > as a pedwarn / error. > > However, while C++ doesn't have that Semantics / Constraints division, > it's also the case that before C++2a, C++ on

Re: Kyrylo Tkachov and Richard Sandiford appointed AArch64 maintainers.

2019-09-26 Thread Richard Sandiford
Kyrill Tkachov writes: > On 9/26/19 8:02 AM, Ramana Radhakrishnan wrote: >> Hi, >> >> I'm pleased to announce that the GCC steering committee has appointed >> Kyrylo Tkachov and Richard Sandiford as AArch64 maintainers. >> >> Please join me in congratulating them both on their additional roles >>

Re: [PATCH] driver: Also prune joined switches with negation

2019-09-26 Thread Kyrill Tkachov
On 9/25/19 12:10 PM, Kyrill Tkachov wrote: On 9/24/19 7:47 PM, Matt Turner wrote: > When -march=native is passed to host_detect_local_cpu to the backend, > it overrides all command lines after it.  That means > > $ gcc -march=native -march=armv8-a > > is treated as > > $ gcc -march=armv8-a -ma

Re: [PATCH] Retain TYPE_MODE more often for BIT_FIELD_REFs in get_inner_referece

2019-09-26 Thread Richard Biener
On Thu, 26 Sep 2019, Eric Botcazou wrote: > > I see. So I misremember seeing aggregate typed BIT_FIELD_REFs > > (that was probably VIEW_CONVERTs then...). Still the GIMPLE verifier > > only has > > > > else if (!INTEGRAL_TYPE_P (TREE_TYPE (expr)) > >&& TYPE_MODE (T

Re: Make assemble_real generate canonical CONST_INTs

2019-09-26 Thread Richard Sandiford
Christophe Lyon writes: > On Wed, 18 Sep 2019 at 11:41, Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On Tue, Sep 17, 2019 at 4:33 PM Richard Sandiford >> > wrote: >> >> >> >> assemble_real used GEN_INT to create integers directly from the >> >> longs returned by real_to_target.

Re: [PATCH] Retain TYPE_MODE more often for BIT_FIELD_REFs in get_inner_referece

2019-09-26 Thread Eric Botcazou
> I see. So I misremember seeing aggregate typed BIT_FIELD_REFs > (that was probably VIEW_CONVERTs then...). Still the GIMPLE verifier > only has > > else if (!INTEGRAL_TYPE_P (TREE_TYPE (expr)) >&& TYPE_MODE (TREE_TYPE (expr)) != BLKmode >&& may

Re: Kyrylo Tkachov and Richard Sandiford appointed AArch64 maintainers.

2019-09-26 Thread Kyrill Tkachov
On 9/26/19 8:02 AM, Ramana Radhakrishnan wrote: Hi, I'm pleased to announce that the GCC steering committee has appointed Kyrylo Tkachov and Richard Sandiford as AArch64 maintainers. Please join me in congratulating them both on their additional roles in the community. Kyrill / Richard, please

Re: [PATCH][RFC] Add new ipa-reorder pass

2019-09-26 Thread Martin Liška
On 9/25/19 6:36 PM, Evgeny Kudryashov wrote: > On 2019-09-19 11:33, Martin Liška wrote: >> Hi. >> >> Function reordering has been around for quite some time and a naive >> implementation was also part of my diploma thesis some time ago. >> Currently, the GCC can reorder function based on first exec

[PATCH, Fortran] Optionally suppress no-automatic overwrites recursive warning - for approval

2019-09-26 Thread Mark Eggleston
Original thread starts here https://gcc.gnu.org/ml/gcc-patches/2019-09/msg01185.html OK to commit? gcc/fortran/ChangeLog     Mark Eggleston      * invoke.texi: Add -Wno-overwrite-recursive to list of options. Add     description of -Wno-overwrite-recursive. Fix typo in description     of -Wi

Re: [PATCH v4] Missed function specialization + partial devirtualization

2019-09-26 Thread Martin Liška
On 9/26/19 7:23 AM, luoxhu wrote: > Thanks Martin, > > > On 2019/9/25 18:57, Martin Liška wrote: >> On 9/25/19 5:45 AM, luoxhu wrote: >>> Hi, >>> >>> Sorry for replying so late due to cauldron conference and other LTO issues >>> I was working on. >> >> Hello. >> >> That's fine, we still have plen

Re: [PATCH][AArch64] Don't split 64-bit constant stores to volatile location

2019-09-26 Thread Kyrill Tkachov
On 9/25/19 10:24 PM, James Greenhalgh wrote: On Tue, Sep 24, 2019 at 02:40:20PM +0100, Kyrill Tkachov wrote: Hi all, On 8/22/19 10:16 AM, Kyrill Tkachov wrote: Hi all, The optimisation to optimise:    typedef unsigned long long u64;    void bar(u64 *x)    { *x = 0xabcdef10abcdef10

Re: [PATCH] DWARF array bounds missing from C++ array definitions

2019-09-26 Thread Richard Biener
On Thu, Sep 26, 2019 at 4:05 AM Alexandre Oliva wrote: > > On Sep 13, 2019, Richard Biener wrote: > > > On Fri, Sep 13, 2019 at 1:32 AM Alexandre Oliva wrote: > >> On Sep 12, 2019, Richard Biener wrote: > > >> > So - maybe we can have the patch a bit cleaner by adding > >> > a flag to add_type_

Re: [PATCH] PR tree-optimization/90836 Missing popcount pattern matching

2019-09-26 Thread Richard Biener
On Tue, Sep 24, 2019 at 5:29 PM Dmitrij Pochepko wrote: > > Hi, > > can anybody take a look at v2? +(if (tree_to_uhwi (@4) == 1 + && tree_to_uhwi (@10) == 2 && tree_to_uhwi (@5) == 4 those will still ICE for large __int128_t constants. Since you do not match any conversions you shou

Re: [PATCH 2/2] libada: Respect `--enable-version-specific-runtime-libs'

2019-09-26 Thread Arnaud Charlet
> Respect the `--enable-version-specific-runtime-libs' configuration > option in libada/, so that shared gnatlib libraries will be installed > in non-version-specific $(toolexeclibdir) if requested. In a > cross-compilation environment this helps setting up a consistent > sysroot, which can th

Re: [PATCH 1/2] libada: Remove racy duplicate gnatlib installation

2019-09-26 Thread Arnaud Charlet
Unfortunately the Make-lang.in part is still needed when using the --disable-libada configure switch so a more elaborate change is needed. > Remove the extraneous `install-gnatlib' invocation from within gcc/ then > as all the gnatlib handling ought to be done in libada/ nowadays. > > gcc/

Re: [PATCH] Add TODO_update_ssa for SLP BB vectorization (PR tree-optimization/91885).

2019-09-26 Thread Martin Liška
On 9/26/19 9:32 AM, Richard Biener wrote: > On Wed, Sep 25, 2019 at 12:06 PM Martin Liška wrote: >> >> Hi. >> >> Similarly to SLP pass, we should probably set TODO_update_ssa >> when a SLP BB vectorization happens from the normal vect pass. >> >> Patch can bootstrap on x86_64-linux-gnu and survive

Re: [PATCH] Fix continue condition in IPA-SRA's process_scan_results

2019-09-26 Thread Richard Biener
On Wed, Sep 25, 2019 at 4:18 PM Martin Jambor wrote: > > Hi, > > On Tue, Sep 24 2019, Martin Jambor wrote: > > > > > > It is the correct thing to do, sorry for the breakage. I have to run > > now but will prepare a patch tomorrow. > > > > and here it is. The patch fixes the thinko explained in m

Re: [PATCH] Fix quoting in a call to internal_error

2019-09-26 Thread Richard Biener
On Wed, Sep 25, 2019 at 5:29 PM Martin Jambor wrote: > > Hi, > > it was brought to my attention that my call to internal_error in the new > IPA-SRA makes -Wformat-diag complain because it thinks that everything > with an underscore is an identifier or a keyword and should be quoted. > Well, the st

Re: [PATCH] Add TODO_update_ssa for SLP BB vectorization (PR tree-optimization/91885).

2019-09-26 Thread Richard Biener
On Wed, Sep 25, 2019 at 12:06 PM Martin Liška wrote: > > Hi. > > Similarly to SLP pass, we should probably set TODO_update_ssa > when a SLP BB vectorization happens from the normal vect pass. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Hmm

Re: [PR 91853] Prevent IPA-SRA ICEs on type-mismatched calls

2019-09-26 Thread Richard Biener
On Wed, 25 Sep 2019, Martin Jambor wrote: > Hi, > > PR 91853 and its duplicate PR 91894 show that IPA-SRA can stumble when > presented with code with mismatched types, whether because it is a K&R C > or happening through an originally indirect call (or probably also > because of LTO). > > The pr

Re: [PATCH] Use build_clobber some more

2019-09-26 Thread Richard Biener
On Thu, 26 Sep 2019, Jakub Jelinek wrote: > Hi! > > I wasn't aware of this new build_clobber function added last year, > apparently we have still tons of spots that build clobbers by hand and using > build_clobber will make it clear what we are actually building. > > Bootstrapped/regtested on x8