Hi Paul, that message was a copy/paste leftover. It doesn't make any sense in that part of the code, it's now removed.
Committed as revision 276164. Thanks! Il giorno dom 15 set 2019 alle ore 12:19 Paul Richard Thomas <paul.richard.tho...@gmail.com> ha scritto: > > Hi Sandro, > > This patch looks fine to me. I have a question about the comment: > "This code is obviously added because the finalizer is not trusted to > free all memory." > 'obviously'? Not to me :-( Maybe you can expand on this? > > As to the stat and errmsg: Leave them for the time being. However, an > attempt will have to be made to implement F2018 "16.6 Collective > subroutines". I don't know enough about the coarrays implementation to > be able to help you about detecting these conditions. Maybe Tobias > Burnus can help? > > OK to commit. > > Paul > > PS Sometime before very long, something will have to be done about the > exponential code bloat that structure_alloc_comps. The more users that > there are for it the tougher it is going to get! > > On Thu, 22 Aug 2019 at 18:41, Alessandro Fanfarillo > <fanfarillo....@gmail.com> wrote: > > > > Dear all, > > please find in attachment a preliminary patch that adds support to > > co_broadcast for allocatable components of derived types. > > The patch is currently ignoring the stat and errmsg arguments, mostly > > because I am not sure how to handle them properly. I have created a > > new data structure called used to pass those argument to the > > preexisting structure_alloc_comps. > > Suggestions on how to handle them are more than welcome :-) > > > > The patch builds correctly on x86_64 and it has been tested with > > OpenCoarrays and the following test cases: > > > > https://github.com/sourceryinstitute/OpenCoarrays/blob/co_broadcast-derived-type/src/tests/unit/collectives/co_broadcast_allocatable_components.f90 > > > > https://github.com/sourceryinstitute/OpenCoarrays/blob/co_broadcast-derived-type/src/tests/unit/collectives/co_broadcast_allocatable_components_array.f90 > > > > Regards, > > > > -- > "If you can't explain it simply, you don't understand it well enough" > - Albert Einstein
