[PATCH] RISC-V: Handle g extension in multilib-generator

gcc/ChangeLog * gcc/config/riscv/multilib-generator: (canonical_order): Add 'g'. (arch_canonicalize): Support rv32g and rv64g and fix error handling. --- gcc/config/riscv/multilib-generator | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/confi

Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

Hi Jim. Andreas: Thanks your review :) Committed with English improvements and ChangeLog update as r274137 On Tue, Aug 6, 2019 at 5:48 AM Jim Wilson wrote: > > On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng wrote: > > gcc/ChangeLog > > * gcc/config/riscv/multilib-generator: Handle extension

[PATCH v2 18/18] Use DEBUG_INSN_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh DEBUG_INSN_P

2019-08-05 Arvind Sankar gcc/ChangeLog: * reload1.c: Convert GET_CODE (..) == DEBUG_INSN to DEBUG_INSN_P (..). * reorg.c: Likewise. 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/reload1.c b/gcc/reload1.c index 1a68d0567fc..d30badc0c4f 1006

[PATCH v2 17/18] Use SYMBOL_REF_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * dwarf2out.c: Convert GET_CODE (..) == SYMBOL_REF to SYMBOL_REF_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c index b2b4f6d82b2..ea38963d177 100644 --- a/gcc/dwarf2out.c

[PATCH v2 14/18] Use LABEL_REF_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh LABEL_REF

2019-08-05 Arvind Sankar gcc/ChangeLog: * alias.c: Convert GET_CODE (..) == LABEL_REF to LABEL_REF_P (..). * bb-reorder.c: Likewise. * cfgbuild.c: Likewise. * cfgexpand.c: Likewise. * cfgrtl.c: Likewise. * combine.c: Likewise.

[PATCH v2 06/18] Use CONST_DOUBLE_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_DOUBLE

2019-08-05 Arvind Sankar gcc/ChangeLog: * config/aarch64/aarch64.c: Convert GET_CODE (..) == CONST_DOUBLE to CONST_DOUBLE_P (..). * config/aarch64/aarch64.md: Likewise. * config/arc/arc.c: Likewise. * config/arc/arc.md: Likewise. * config

[PATCH v2 15/18] Use LABEL_REF_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtlanal.c: Convert GET_CODE (..) == LABEL_REF to LABEL_REF_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/rtlanal.c b/gcc/rtlanal.c index cb6c8902353..a8becc85047 100644 --- a/gcc/rtlanal.c +++ b/gcc/

[PATCH v2 09/18] Add CONST_STRING_P rtx_code predicate.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Add a predicate macro for checking CONST_STRING. 1 file changed, 3 insertions(+) diff --git a/gcc/rtl.h b/gcc/rtl.h index 45e2b85867d..d02772b65be 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -821,6 +821,9 @@ struct GTY(()) rtvec

[PATCH v2 10/18] Use CONST_STRING_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_STRING

2019-08-05 Arvind Sankar gcc/ChangeLog: * config/avr/avr.c: Convert GET_CODE (..) == CONST_STRING to CONST_STRING_P (..). * dwarf2out.c: Likewise. * genattrtab.c: Likewise. * gensupport.c: Likewise. 4 files changed, 15 insertions(+), 15 deletio

[PATCH v2 05/18] Use CONST_FIXED_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_FIXED

2019-08-05 Arvind Sankar gcc/ChangeLog: * cfgexpand.c: Convert GET_CODE (..) == CONST_FIXED to CONST_FIXED_P. * config/spu/spu.c: Likewise. * varasm.c: Likewise. 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/cfgexpand.c b/gcc/cfgex

[PATCH v2 08/18] Use CONST_VECTOR_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_VECTOR

2019-08-05 Arvind Sankar gcc/ChangeLog: * common.md: Convert GET_CODE (..) == CONST_VECTOR to CONST_VECTOR_P (..). * config/aarch64/aarch64.c: Likewise. * config/alpha/alpha.c: Likewise. * config/arc/arc.c: Likewise. * config/arc/simdext.

[PATCH v2 07/18] Add CONST_VECTOR_P rtx_code predicate.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Add a predicate macro for checking CONST_VECTOR. 1 file changed, 3 insertions(+) diff --git a/gcc/rtl.h b/gcc/rtl.h index 28b5a82d651..45e2b85867d 100644 --- a/gcc/rtl.h +++ b/gcc/rtl.h @@ -818,6 +818,9 @@ struct GTY(()) rtvec

[PATCH v2 03/18] Use CONST_INT_P macro.

2019-08-05 Arvind Sankar gcc/ChangeLog: * combine-stack-adj.c: Convert GET_CODE (..) == CONST_INT to CONST_INT_P (..). 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/combine-stack-adj.c b/gcc/combine-stack-adj.c index 3638a1b10ee..f98a0d54c98 100644

[PATCH v2 04/18] Use CONST_WIDE_INT_P macro. Autogenerated patch by running ../contrib/rtl-pred.sh CONST_WIDE_INT_P

2019-08-05 Arvind Sankar gcc/ChangeLog: * config/darwin.c: Convert GET_CODE (..) == CONST_WIDE_INT to CONST_WIDE_INT_P (..). * config/s390/s390.c: Likewise. * rtlanal.c: Likewise. 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/confi

[PATCH v2 01/18] Fix CONST_DOUBLE_AS_FLOAT_P comment.

2019-08-05 Arvind Sankar gcc/ChangeLog: * rtl.h: Fix comment for CONST_DOUBLE_AS_FLOAT_P and move it together with the other CONST_DOUBLE predicates. 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/rtl.h b/gcc/rtl.h index 039ab05f951..28b5a82d651 100644 ---

Re: Use predicates for RTL objects

Here's the patches split up. The ones that say autogenerated were generated from the script below. I haven't included that as a patch yet since not sure about the copyright/licensing boilerplate to insert in it. contrib/rtl-pred.sh: #!/bin/sh # codes="CONST_INT|CONST_WIDE_INT|CONST_FIXED|CONST

Re: [PATCH V5, rs6000] Support vrotr3 for int vector types

Hi Segher, on 2019/8/6 上午5:21, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 11:41:41AM +0800, Kewen.Lin wrote: >> on 2019/8/4 上午4:52, Segher Boessenkool wrote: >>> On Fri, Aug 02, 2019 at 04:59:44PM +0800, Kewen.Lin wrote: > There are two cases: either all elements are rotated by the same a

[PATCH][c++] Do not warn about unused macros while processing #pragma GCC optimize

Fixes c++/91318. libcpp/ChangeLog: 2019-08-06 Piotr Henryk Dabrowski PR c++/91318 * include/cpplib.h: Added cpp_define_unused(), cpp_define_formatted_unused() * directives.c: Likewise. gcc/c-family/ChangeLog: 2019-08-06 Piotr Henryk Dabrowski PR c++/9131

Re: C++ PATCH for DR 2413 - typename in conversion-function-ids

OK. On Mon, Aug 5, 2019 at 8:03 PM Marek Polacek wrote: > > While updating the C++ DR table, I noticed that one of the new DRs, DR 2413, > is trivial: > --- > The “Down with typename!” paper, P0634R3, overlooked the case of a > conversion-type-id > in a conversion-function-id: > > template str

[committed] add test for PR 50476

The expected warning is now issued so I resolved the bug and committed the test below in r274135. As an aside, the warning points to the pointer dereference but mentions the name of the local variable to which it points. Since the local variable is defined in a different function whose name isn't

[committed] add C++ test for PR60517

The expected diagnostic is now issued so I resolved the bug and committed the test in r274130. Martin Index: gcc/testsuite/g++.dg/pr60517.C === --- gcc/testsuite/g++.dg/pr60517.C (nonexistent) +++ gcc/testsuite/g++.dg/pr60517.C

C++ PATCH for DR 2413 - typename in conversion-function-ids

While updating the C++ DR table, I noticed that one of the new DRs, DR 2413, is trivial: --- The “Down with typename!” paper, P0634R3, overlooked the case of a conversion-type-id in a conversion-function-id: template struct S { operator typename T::X(); // typename is not helpful here. };

Re: [doc PATCH] document variable attribute alias

On 8/5/19 4:43 PM, Martin Sebor wrote: On 8/4/19 9:45 PM, Sandra Loosemore wrote: [snip] OK with that fixed. Done in r274127. Since people tend to refer to the manual for older versions of the compiler I'd like to make this change on supported release branches as well.  If you see any proble

Re: [PATCH] Add future.md placeholder to PowerPC

Whoops, I forgot to include the ChangeLog entry when I committed subversion id 274030 to add future.md. I just added it in subversion id 274129. 2019-08-02 Michael Meissner * config/rs6000/future.md: New file. * config/rs6000/rs6000.md: Include future.md. * config/rs60

[PATCH] RISC-V: Fix C ABI for flattened struct with 0-length bitfield.

This fixes a problem with the GCC implementation of the ABI, where we are accidentally emitting different code for the same struct when compiled by the C and C++ compilers. This was found by LLVM developers comparing the LLVM ABI to the GCC ABI. This affects any struct with one or more zero-lengt

Re: [doc PATCH] document variable attribute alias

On 8/4/19 9:45 PM, Sandra Loosemore wrote: On 7/31/19 5:05 PM, Martin Sebor wrote: It was pointed out recently in another forum that GCC doesn't document attribute alias for variables.  It was also noted in the same discussion that the semantics of accessing aliases and their targets can have "s

Re: [PATCH 1/3] add -Wstruct-not-pod, -Wclass-is-pod, -Wmismatched-tags (PR 61339)

On Mon, Aug 5, 2019 at 5:50 PM Martin Sebor wrote: > > On 8/5/19 1:25 PM, Jason Merrill wrote: > > On 8/1/19 7:35 PM, Martin Sebor wrote: > >> On 8/1/19 12:09 PM, Jason Merrill wrote: > >>> On 7/22/19 12:34 PM, Martin Sebor wrote: > Ping: https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00622.ht

Re: [C++ Patch] One more cp_expr_loc_or_input_loc

OK. On Mon, Aug 5, 2019 at 5:09 PM Paolo Carlini wrote: > > Hi, > > just spotted an additional error which can benefit from > cp_expr_loc_or_input_loc. Tested x86_64-linux. > > Thanks, Paolo. > > >

[wwwdocs] Update C++ DR table

A couple of new DRs, plus some status updates. Applied to CVS. Index: cxx-dr-status.html === RCS file: /cvs/gcc/wwwdocs/htdocs/projects/cxx-dr-status.html,v retrieving revision 1.25 diff -u -r1.25 cxx-dr-status.html --- cxx-dr-status

Re: [PATCH 02/10, OpenACC] Add OpenACC target kinds for decomposed kernels regions

I have run the whole patch series through check_GNU_style.sh and fixed up the formatting where indicated. Do I need to post the reformatted patchset? Thanks Kwok On 18/07/2019 10:24 am, Jakub Jelinek wrote: On Wed, Jul 17, 2019 at 10:04:10PM +0100, Kwok Cheung Yeung wrote: @@ -2319,7 +2339,

Re: [PATCH 06/10, OpenACC] Adjust parallelism of loops in gang-single parts of OpenACC kernels regions

The change to patch 04 (Turn OpenACC kernels regions into a sequence of parallel regions) necessitates an additional include of 'diagnostic-core.h' in omp-oacc-kernels.c, as it is no longer indirectly included by 'cp/cp-tree.h'. Kwok On 17/07/2019 10:12 pm, Kwok Cheung Yeung wrote: Loops in

Re: [PATCH 04/10, OpenACC] Turn OpenACC kernels regions into a sequence of, parallel regions

On 18/07/2019 10:30 am, Jakub Jelinek wrote: On Wed, Jul 17, 2019 at 10:06:07PM +0100, Kwok Cheung Yeung wrote: --- a/gcc/omp-oacc-kernels.c +++ b/gcc/omp-oacc-kernels.c @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3. If not see #include "backend.h" #include "target.h" #include "

Re: [PATCH 1/3] add -Wstruct-not-pod, -Wclass-is-pod, -Wmismatched-tags (PR 61339)

On 8/5/19 1:25 PM, Jason Merrill wrote: On 8/1/19 7:35 PM, Martin Sebor wrote: On 8/1/19 12:09 PM, Jason Merrill wrote: On 7/22/19 12:34 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00622.html On 7/8/19 3:58 PM, Martin Sebor wrote: The attached patch implements

Re: [PATCH] RISC-V: Handle extensions combination correctly in multilib-generator.

On Mon, Aug 5, 2019 at 1:20 AM Kito Cheng wrote: > gcc/ChangeLog > * gcc/config/riscv/multilib-generator: Handle extensions > combination correctly. A ChangeLog entry should generally describe what a patch changes, not what it does. So this should mention a new variable canonical

Re: [PATCH V5, rs6000] Support vrotr3 for int vector types

On Mon, Aug 05, 2019 at 11:41:41AM +0800, Kewen.Lin wrote: > on 2019/8/4 上午4:52, Segher Boessenkool wrote: > > On Fri, Aug 02, 2019 at 04:59:44PM +0800, Kewen.Lin wrote: > >> As to the predicate name and usage, I checked the current vector shifts, > >> they don't need to check const_vector special

[C++ Patch] One more cp_expr_loc_or_input_loc

Hi, just spotted an additional error which can benefit from cp_expr_loc_or_input_loc. Tested x86_64-linux. Thanks, Paolo. /cp 2019-08-05 Paolo Carlini * decl.c (check_array_designated_initializer): Use cp_expr_loc_or_input_loc in one place. /testsuit

PING^1 [PATCH] i386: Separate costs of pseudo registers from hard registers

On Tue, Jul 23, 2019 at 2:57 PM H.J. Lu wrote: > > On Mon, Jun 24, 2019 at 9:16 AM H.J. Lu wrote: > > > > On Mon, Jun 24, 2019 at 6:37 AM Richard Biener wrote: > > > > > > On Thu, 20 Jun 2019, Jan Hubicka wrote: > > > > > > > > > Currently, costs of moves are also used for costs of RTL > > > >

[PATCH] [LRA] Fix wrong-code PR 91109

Hi! PR 91109 is a wrong-code bug, where LRA is using a scratch register which is actually not available for use, and thus gets clobbered when it should not. That seems to be mostly because the live range info of the cloned schatch register is not working the way how update_scrach_ops sets up the

[PATCH] Sync MIPS support from libffi master repository

This updates the libffi MIPS support up to commit 746dbe3a6a79, with the exception of commit bd72848c7af9 which prefixes the ALIGN macro with FFI_ for all ports. These patches, with the exception of the softfloat one, have been used on the Debian GCC packages for quite some time. libffi/Changelog

Re: C++ PATCH for c++/91264 - detect modifying const objects in constexpr

On 7/31/19 3:26 PM, Marek Polacek wrote: One of the features of constexpr is that it doesn't allow UB; and such UB must be detected at compile-time. So running your code in a context that requires a constant expression should ensure that the code in question is free of UB. In effect, constexpr c

[Committed] PR fortran/91372 -- Fix parsing of DATA with implied do-loop

I've committed the attached patch as obvious. My previous patch was too strict (and incorrect) in the interpretation of R837 data-stmt is DATA data-stmt-set [ [ , ] data-stmt-set ] ... The previous patch required whitespace after DATA, but it seems that it id valid to do 'DATA(x(i),i=1,2)/1.,2

Re: [patch][aarch64]: add intrinsics for vld1(q)_x4 and vst1(q)_x4

On 7/18/19 1:18 PM, James Greenhalgh wrote: On Mon, Jun 10, 2019 at 06:21:05PM +0100, Sylvia Taylor wrote: Greetings, This patch adds the intrinsic functions for: - vld1__x4 - vst1__x4 - vld1q__x4 - vst1q__x4 Bootstrapped and tested on aarch64-none-linux-gnu. Ok for trunk? If yes, I don't hav

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 3:29 PM Richard Biener wrote: > > > > > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > > > > > > "TARGET_AVX512F"]) > > > > > > > > > > > > > > and then we need to split DImode for 32bits, too. > > > > > > > > > > > > For now, please add "TARGET_64BIT

Re: [PATCH 1/3] add -Wstruct-not-pod, -Wclass-is-pod, -Wmismatched-tags (PR 61339)

On 8/1/19 7:35 PM, Martin Sebor wrote: On 8/1/19 12:09 PM, Jason Merrill wrote: On 7/22/19 12:34 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2019-07/msg00622.html On 7/8/19 3:58 PM, Martin Sebor wrote: The attached patch implements three new warnings:   *  -Wstruct-not-p

Re: [C++ Patch] Improve delete_sanity locations

On 8/2/19 8:27 AM, David Malcolm wrote: On Fri, 2019-08-02 at 14:02 +0200, Paolo Carlini wrote: Hi, On 31/07/19 21:39, David Malcolm wrote: [snip] I don't care for "cp_expr_loc_or_loc". By "_or_here" do you mean "or input_location"? Calling it "cp_expr_loc_or_input_location" would spell out

Re: [PATCH]: Fix PR c++/88095, class template argument deduction for literal operator templates per P0732 for C++2a

On 8/2/19 9:59 AM, Tom Honermann wrote: This patch fixes PR c++/88095: - Bug 88095 - class nontype template parameter UDL string literals doesn't accepts deduction placeholder - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88095. It also addresses a latent issue; literal operator templates wit

Re: [Committed] PR fortran/90985 -- DATA must be followed by whitespace

On Mon, Aug 05, 2019 at 12:01:36PM -0700, H.J. Lu wrote: > On Fri, Aug 2, 2019 at 4:51 PM Steve Kargl > wrote: > > > > In free-form source code, DATA must be followed by whitespace. > > This patch checks for whitespace, and if none is found, returns > > MATCH_NO to give other matchers a chance to

Re: [Committed] PR fortran/90985 -- DATA must be followed by whitespace

On Fri, Aug 2, 2019 at 4:51 PM Steve Kargl wrote: > > In free-form source code, DATA must be followed by whitespace. > This patch checks for whitespace, and if none is found, returns > MATCH_NO to give other matchers a chance to run. > > 2019-08-02 Steven G. Kargl > > PR fortran/90985 >

Re: C++ PATCH for c++/91338 - P1161R3: Deprecate a[b,c]

On Mon, Aug 05, 2019 at 02:31:15PM -0400, Jason Merrill wrote: > On 8/3/19 9:54 PM, Marek Polacek wrote: > > This patch implements P1161R3, Deprecate uses of the comma operator in > > subscripting expressions: > > > > which made

Re: Use predicates for RTL objects

On Mon, Aug 05, 2019 at 01:29:26PM -0500, Segher Boessenkool wrote: > On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > > > -/* Predicate yielding true iff X is an rtx for a double-int. */ > > > > +/* Predicat

Re: C++ PATCH for c++/91338 - P1161R3: Deprecate a[b,c]

On 8/3/19 9:54 PM, Marek Polacek wrote: This patch implements P1161R3, Deprecate uses of the comma operator in subscripting expressions: which made its way to C++20. New [depr.comma.subscript] shows: void f(int *a, int b,

Re: Use predicates for RTL objects

On Mon, Aug 05, 2019 at 02:14:50PM -0400, Arvind Sankar wrote: > On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > > First: do you have a copyright assignment? See > > https://gcc.gnu.org/contribute.html > > for instructions. > > Nope, is this really substantial enough to wa

Re: Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On 8/5/19 11:34 AM, Jakub Jelinek wrote: On Mon, Aug 05, 2019 at 11:20:09AM -0400, Jason Merrill wrote: I agree. But for those who want a monotonically increasing identifier, there's already one in git: CommitDate. In the discussion of this issue four years ago, While commit date is monotoni

Re: Use predicates for RTL objects

On Mon, Aug 05, 2019 at 12:48:46PM -0500, Segher Boessenkool wrote: > Hi Arvind, > > First: do you have a copyright assignment? See > https://gcc.gnu.org/contribute.html > for instructions. Nope, is this really substantial enough to warrant one? > > This is easier to review, and even to comm

Re: [RFC][tree-vect]PR 88915: Further vectorize second loop when versioning

Hi Richard, Thanks for the feedback! See comments inline. On 01/08/2019 16:26, Richard Biener wrote: On Tue, 30 Jul 2019, Andre Vieira (lists) wrote: On 30/07/2019 13:16, Andre Vieira (lists) wrote: Hi Richard, I believe this is in line with what you were explaining to me earlier. The one

[PATCH] Add --with-static-standard-libraries to the top level

gdb should normally not be linked with -static-libstdc++. Currently this has not caused problems, but it's incompatible with catching an exception thrown from a shared library -- and a subsequent patch changes gdb to do just this. This patch adds a new --with-static-standard-libraries flag to the

[PATCH] issue a correct fix-it hint for bad argument in GCC diagnostics (PR 80619)

When the argument to a directive with a length modifier like %lu in a call to a GCC diagnostic function such as warning()) is not of the right integer type, GCC suggests to replace the length modifier in the directive with 'w'. For instance: warning: format ‘%lu’ expects argument of type ‘long

Re: Use predicates for RTL objects

Hi Arvind, First: do you have a copyright assignment? See https://gcc.gnu.org/contribute.html for instructions. This is easier to review, and even to commit as obvious, if you did a patch per macro, certainly for the new macros; and, put the script in contrib/, and then say with every patch th

[wwwdocs] Another C++20 table update

I've opened a bunch of PRs to track the status of C++2a features in G++. This patch updates the C++2a table accordingly. While at it, I made a small clarification regarding P1152R4: only certain uses of volatile are being deprecated, not volatile itself. Index: cxx-status.html ==

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Aug 2, 2019, at 4:06 AM, Richard Biener wrote: > > IMHO voting is bike-shedding. > > Those who do the work decide. _They_ may ask questions _and_ decide whether > to listen to the answer. I'd tend to agree. I also think the recent conversion work is a fine solution, and that my preference

Re: wrap math.h for M_PI et al in target/i386 tests

> On Jul 30, 2019, at 5:22 AM, Uros Bizjak wrote: >> Most but not all of the tests that expect M_PI, M_PI_2 and/or M_PI_4 >> to be defined in math.h explicitly exclude one target system that does >> not satisfy this non-standard assumption. >> >> This patch introduces a wrapper header that inc

Re: Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On 05/08/2019 16:34, Jakub Jelinek wrote: On Mon, Aug 05, 2019 at 11:20:09AM -0400, Jason Merrill wrote: I agree. But for those who want a monotonically increasing identifier, there's already one in git: CommitDate. In the discussion of this issue four years ago, While commit date is monoton

Re: Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On Mon, Aug 05, 2019 at 11:20:09AM -0400, Jason Merrill wrote: > I agree. But for those who want a monotonically increasing > identifier, there's already one in git: CommitDate. In the discussion > of this issue four years ago, While commit date is monotonically increasing, it has the problem th

Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git)

On Mon, Aug 5, 2019 at 9:20 AM Martin Liška wrote: > Based on the IRC discussion with Jakub, there's missing key element of the > transition. > Jakub requests to have a monotonically increasing revisions (aka rXXX) to > be assigned > for the future git revisions. These will be linked from b

[committed][MSP430] Add "cleanup-saved-temps" directive to gcc.target/msp430/pr80993.c

This fixes linker errors about different memory models in object files when the large/small memory models are tested one after the other in the same build directory, by cleaning up the temporary LTO files required to be generated for this test. Applied on trunk. >From a64c89e01c11b167e7113a49914ea

Re: [PATCH] Handle new operators with no arguments in DCE.

On Mon, 5 Aug 2019, Martin Liška wrote: You are right. It can really lead to confusion of the DCE. What we have is DECL_ABSTRACT_ORIGIN(decl) which we can use to indicate operators that were somehow modified by an IPA optimization. Looks similar to the cgraph_node->clone_of that Richard was

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, 5 Aug 2019, Uros Bizjak wrote: > On Mon, Aug 5, 2019 at 3:04 PM Richard Biener wrote: > > > > On Mon, 5 Aug 2019, Uros Bizjak wrote: > > > > > On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > > > > > > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > > > > (def

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On 8/3/19 12:31 AM, Jason Merrill wrote: > On Fri, Aug 2, 2019 at 7:35 AM Martin Liška wrote: >> >> On 8/2/19 1:06 PM, Richard Biener wrote: >>> On Fri, Aug 2, 2019 at 1:01 PM Martin Liška wrote: On 8/2/19 12:54 PM, Maxim Kuvyrkov wrote: >> On Aug 2, 2019, at 1:26 PM, Martin Liška

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 3:04 PM Richard Biener wrote: > > On Mon, 5 Aug 2019, Uros Bizjak wrote: > > > On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > > > > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, 5 Aug 2019, Uros Bizjak wrote: > On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > > > "TARGET_AVX512F"]) > > > > > > > > and then we need to spl

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 2:54 PM Jakub Jelinek wrote: > > On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > > "TARGET_AVX512F"]) > > > > > > and then we need to split DImode for 32bits, too. > > > > For now, please add

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 05, 2019 at 02:51:01PM +0200, Uros Bizjak wrote: > > (define_mode_iterator MAXMIN_IMODE [SI "TARGET_SSE4_1"] [DI > > "TARGET_AVX512F"]) > > > > and then we need to split DImode for 32bits, too. > > For now, please add "TARGET_64BIT && TARGET_AVX512F" for DImode > condition, I'll provi

Re: [PATCH] Handle new operators with no arguments in DCE.

On 8/5/19 1:57 PM, Marc Glisse wrote: > On Mon, 5 Aug 2019, Martin Liška wrote: > >> On 8/5/19 9:07 AM, Marc Glisse wrote: >>> On Mon, 5 Aug 2019, Martin Liška wrote: >>> I'm sending fix for the ICE. The issue is that we can end up with a ctor without an argument (when not being used). >

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 2:43 PM Uros Bizjak wrote: > > On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > > > On Thu

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener > > > > wrote: > > > > > > >

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener > > > > wrote: > > > > > > >

Re: [patch] Fix tree-optimization/91169

On Mon, Aug 5, 2019 at 10:28 AM Eric Botcazou wrote: > > > Testing went OK but it looks like acats doesn't honor > > RUNTESTFLAGS so I got no multilib testing for it :/ > > And the PR didn't contain sth I could plug into gnat.dg so I checked > > with visual inspection of dumps on the reduced testc

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 2:16 PM Richard Biener wrote: > > On Mon, 5 Aug 2019, Uros Bizjak wrote: > > > > dimode_{scalar_to_vector_candidate_p,remove_non_convertible_regs} > > > functions to drop the dimode_ prefix - is that OK or do you > > > prefer some other prefix? > > > > No, please just drop t

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, 5 Aug 2019, Uros Bizjak wrote: > > dimode_{scalar_to_vector_candidate_p,remove_non_convertible_regs} > > functions to drop the dimode_ prefix - is that OK or do you > > prefer some other prefix? > > No, please just drop the prefix. just noticed this applies to the derived dimode_scalar_c

Re: [PATCH] Handle new operators with no arguments in DCE.

On Mon, Aug 5, 2019 at 8:44 AM Martin Liška wrote: > > On 8/2/19 11:34 PM, H.J. Lu wrote: > > On Tue, Jul 2, 2019 at 4:50 AM Martin Liška wrote: > >> > >> Second part. > >> > >> Martin > > > > This caused: > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91334 > > > > Hi. > > I'm sending fix

Re: Protect tree_to_shwi call in unmodified_param_1

On Mon, Aug 5, 2019 at 10:58 AM Richard Sandiford wrote: > > unmodified_param_1 used tree_to_shwi without first checking > tree_fits_shwi_p. This is needed by the SVE ACLE support and > is hard to test independently. > > Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. > OK to instal

Re: Make function_code a 32-bit field

On Mon, Aug 5, 2019 at 10:56 AM Richard Sandiford wrote: > > Adding SVE intrinsics on top of the existing AArch64 intrinsics blows > the 12-bit function_code in tree_function_decl. That bitfield has no > spare bits, but it comes at the end of the structure and is preceded > by a pointer, so on LP

Re: Fold MASK_LOAD/STORE with an all-true mask

On Mon, Aug 5, 2019 at 10:50 AM Richard Sandiford wrote: > > This patch folds IFN_MASK_LOAD and IFN_MASK_STOREs to normal accesses > if the mask is all-true. This can happen for fully-masked loops that > didn't actually need to be (which could be handled by the vectoriser > instead), or for unrol

Re: Add a gimple_move_vops helper function

On Mon, Aug 5, 2019 at 10:49 AM Richard Sandiford wrote: > > I needed to add another instance of this idiom, so thought it'd > be worth having a helper function. > > Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. > OK to install? OK. > Richard > > > 2019-08-05 Richard Sandiford

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 1:50 PM Richard Biener wrote: > > On Sun, 4 Aug 2019, Uros Bizjak wrote: > > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener > > > > wrote: > > > > > > >

Re: [PATCH] Handle new operators with no arguments in DCE.

On Mon, 5 Aug 2019, Martin Liška wrote: On 8/5/19 9:07 AM, Marc Glisse wrote: On Mon, 5 Aug 2019, Martin Liška wrote: I'm sending fix for the ICE. The issue is that we can end up with a ctor without an argument (when not being used). Ah, I didn't realize that after cloning and drastically c

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Sun, 4 Aug 2019, Uros Bizjak wrote: > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > > > > On Thu, 1 Aug 2019, Uros Bizjak wrote: > > > > > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener wrote: > > > > > So you unconditionally add a smaxdi3 pattern - indeed this looks > > ne

[PATCH 2/2][MIPS][RFC] Emit .note.GNU-stack for hard-float linux targets.

From: "Dragan Mladjenovic" libgcc/ChangeLog: 2019-08-05 Dragan Mladjenovic * config/mips/gnustack.h: Check for TARGET_LIBC_GNUSTACK also. gcc/ChangeLog: 2019-08-05 Dragan Mladjenovic * config.in: Regenerated. * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Def

[PATCH 1/2][MIPS] Emit .note.GNU-stack for soft-float linux targets.

From: "Dragan Mladjenovic" gcc/ChangeLog: 2019-08-05 Dragan Mladjenovic * config/mips/linux.h (NEED_INDICATE_EXEC_STACK): Define to TARGET_SOFT_FLOAT. * config/mips/mips.c (TARGET_ASM_FILE_END): Define to ... (mips_asm_file_end): New function. Delegate to

Re: [PATCH v2] RISC-V: Promote type correctly for libcalls

Committed to gcc-9 as r274108 and gcc-8 as r274113 On Mon, Aug 5, 2019 at 3:29 PM Richard Biener wrote: > > On Mon, 5 Aug 2019, Kito Cheng wrote: > > > Committed as r274107 > > > > Hi Jakub, Richard: > > > > This patch is fix ABI bug for libcall on RISC-V, we've also tested on > > gcc 8 and 9, it

[PATCH 0/2] [MIPS] Emit .note.GNU-stack for linux targets.

From: "Dragan Mladjenovic" Greetings, These patches enable emitting .note.GNU-stack by default on mips linux targets. First one enables it unconditionally for soft-float builds while the second one enables it for hard-float build if gcc is configured against the future version of glibc that shou

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

Uros Bizjak writes: > On Mon, Aug 5, 2019 at 12:12 PM Richard Sandiford > wrote: >> >> Uros Bizjak writes: >> > On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford >> > wrote: >> >> >> >> Uros Bizjak writes: >> >> > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: >> >> >> >> >> >> On Thu,

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 12:12 PM Richard Sandiford wrote: > > Uros Bizjak writes: > > On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford > > wrote: > >> > >> Uros Bizjak writes: > >> > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > >> >> > >> >> On Thu, 1 Aug 2019, Uros Bizjak wrote: > >

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

Uros Bizjak writes: > On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford > wrote: >> >> Uros Bizjak writes: >> > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: >> >> >> >> On Thu, 1 Aug 2019, Uros Bizjak wrote: >> >> >> >> > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener >> >> > wrote: >

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

On Mon, Aug 5, 2019 at 11:13 AM Richard Sandiford wrote: > > Uros Bizjak writes: > > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: > >> > >> On Thu, 1 Aug 2019, Uros Bizjak wrote: > >> > >> > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener wrote: > >> > > >> So you unconditionally ad

Re: [PATCH] Handle new operators with no arguments in DCE.

On 8/5/19 9:07 AM, Marc Glisse wrote: > On Mon, 5 Aug 2019, Martin Liška wrote: > >> I'm sending fix for the ICE. The issue is that we can end up >> with a ctor without an argument (when not being used). > > Ah, I didn't realize that after cloning and drastically changing the > signature it woul

Re: [PATCH][RFC][x86] Fix PR91154, add SImode smax, allow SImode add in SSE regs

Uros Bizjak writes: > On Sat, Aug 3, 2019 at 7:26 PM Richard Biener wrote: >> >> On Thu, 1 Aug 2019, Uros Bizjak wrote: >> >> > On Thu, Aug 1, 2019 at 11:28 AM Richard Biener wrote: >> > >> So you unconditionally add a smaxdi3 pattern - indeed this looks >> necessary even when going th

[C] Fix bogus nested enum error message

For: enum a { A }; enum a { B }; we emit a bogus error about nested definitions before the real error: foo.c:2:6: error: nested redefinition of ‘enum a’ 2 | enum a { B }; | ^ foo.c:2:6: error: redeclaration of ‘enum a’ foo.c:1:6: note: originally defined here 1 | enum

Protect tree_to_shwi call in unmodified_param_1

unmodified_param_1 used tree_to_shwi without first checking tree_fits_shwi_p. This is needed by the SVE ACLE support and is hard to test independently. Tested on aarch64-linux-gnu, armeb-eabi and x86_64-linux-gnu. OK to install? Richard 2019-08-05 Richard Sandiford gcc/ * ipa-fnsum

Make function_code a 32-bit field

Adding SVE intrinsics on top of the existing AArch64 intrinsics blows the 12-bit function_code in tree_function_decl. That bitfield has no spare bits, but it comes at the end of the structure and is preceded by a pointer, so on LP64 hosts there's currently a 32-bit hole at end. This patch therefo

  1   2   >