Re: [PATCH][RFC] Come up with TARGET_HAS_FAST_MEMPCPY_ROUTINE (PR middle-end/90263).

On 5/20/19 11:28 PM, Jakub Jelinek wrote: > On Fri, May 17, 2019 at 09:38:31AM -0600, Jeff Law wrote: >>> 2019-05-15 Martin Liska >>> >>> PR middle-end/90263 >>> * gcc.c-torture/compile/pr90263.c: New test. >>> * lib/target-supports.exp: Add check_effective_target_glibc. > > The tes

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On Tue, May 21, 2019 at 1:50 PM Kewen.Lin wrote: > > on 2019/5/20 下午10:43, Jeff Law wrote: > > On 5/20/19 4:24 AM, Segher Boessenkool wrote: > >> Let me try to answer a bit here... > >> > >> On Mon, May 20, 2019 at 11:28:26AM +0200, Richard Biener wrote: > >>> On Thu, 16 May 2019, li...@linux.ibm.

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

on 2019/5/21 上午12:37, Segher Boessenkool wrote: > On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: >>> I think we should have two hooks: one is called with the struct loop as >>> parameter; and the other is called for every statement in the loop, if >>> the hook isn't null anyway. Or perh

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

on 2019/5/20 下午10:43, Jeff Law wrote: > On 5/20/19 4:24 AM, Segher Boessenkool wrote: >> Let me try to answer a bit here... >> >> On Mon, May 20, 2019 at 11:28:26AM +0200, Richard Biener wrote: >>> On Thu, 16 May 2019, li...@linux.ibm.com wrote: >> >>> So the better way would be to expose that via

Re: Hashtable comment cleanups & renamings

Here is a simplified form.     Rename variables and cleanup comments.     * include/bits/hashtable_policy.h     * include/bits/hashtable.h Ok to commit ? François On 5/17/19 10:24 PM, Jonathan Wakely wrote: On 17/05/19 18:19 +0200, François Dumont wrote: Hi     I got tired of '__n' being us

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

on 2019/5/20 下午5:28, Richard Biener wrote: > On Thu, 16 May 2019, li...@linux.ibm.com wrote: > >> From: Kewen Lin >> >> Hi, >> >> Previous version link: >> https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html >> >> Comparing with the previous version, I moved the generic >> parts of rs6000 ta

Re: [PATCH] tbb-backend effective target should check ability to link TBB

With the addition of "-ltbb" to the v3_target_compile flags (so as to, you know, actually try to link tbb). Tested x86_64-linux, committed to trunk. Thomas Rodgers writes: > PR libstdc++/90252 > * testsuite/lib/libstdc++.exp (check_effective_target_tbb-backend): > Changed v3_ta

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

on 2019/5/20 下午5:28, Richard Biener wrote: > On Thu, 16 May 2019, li...@linux.ibm.com wrote: > >> From: Kewen Lin >> >> Hi, >> >> Previous version link: >> https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00654.html >> >> Comparing with the previous version, I moved the generic >> parts of rs6000 ta

Re: Simplify more EXACT_DIV_EXPR comparisons

On 5/20/19 3:16 AM, Richard Biener wrote: On Mon, May 20, 2019 at 10:16 AM Marc Glisse wrote: On Mon, 20 May 2019, Richard Biener wrote: On Sun, May 19, 2019 at 6:16 PM Marc Glisse wrote: Hello, 2 pieces: - the first one handles the case where the denominator is negative. It doesn't hap

[PING] [PATCH V3] PR88497 - Extend reassoc for vector bit_field_ref

Hi, Gentle ping again. Thanks! Kewen on 2019/5/5 下午2:15, Kewen.Lin wrote: > Hi, > > I'd like to gentle ping for this patch: > https://gcc.gnu.org/ml/gcc-patches/2019-03/msg00966.html > > OK for trunk now? > > Thanks! > > on 2019/3/20 上午11:14, Kewen.Lin wrote: >> Hi, >> >> Please refer to b

RFA: fix PR90553, IRA assigning a call-clobbered reg to call with post-increment

I was looking into why I couldn't trivially move cris-elf to "use init_array". It appeared that it wasn't the hooks into that machinery that went wrong, but that a compiler bug is plaguing __libc_init_array. It's been there since at least 4.7-era, hiding under the covers of the __init_array being

Re: [PATCH] Check TBB version in tbb-backed effective target check

Tested x86_64-linux, committed to trunk. Thomas Rodgers writes: > * testsuite/lib/libstdc++.exp (check_effective_target_tbb-backend): > Add check for Thread Building Blocks 2018 or later. > > From bd3de7b67f184ed1387b63dc3bda1d12f7ebee04 Mon Sep 17 00:00:00 2001 > From: Thomas Rodgers

Re: *Ping* Re: [PATCH] PR c/43673 - Incorrect warning in dfp printf.

Ping for GCC-10. Thanks Xionghu On 2019/3/4 09:13, Xiong Hu Luo wrote: Ping: https://gcc.gnu.org/ml/gcc-patches/2019-02/msg01949.html Thanks Xionghu On 2019/2/26 AM9:13, luo...@linux.ibm.com wrote: From: Xiong Hu Luo dfp printf/scanf of Ha/HA, Da/DA and DDa/DDA is not set properly, cause

Re: [PATCH] fix diagnostic quoting/spelling in rs6000

Where you refer to 'homogeneous % aggregates', are such aggregates in the rs6000 case (or in the case where the ABI changed) really restricted to the type float, or do they apply more generally to some other floating-point types so that expanding "float" to a longer description would be the app

Re: State of the reposurgeon conversion

On Mon, 20 May 2019, Jakub Jelinek wrote: > On Mon, May 20, 2019 at 10:16:26AM +0200, Richard Biener wrote: > > There's not many details there but I always thought that the > > "interesting" parts of the GCC history (official branches and trunk) > > do _not_ contain merge commits so the GCC histor

Re: State of the reposurgeon conversion

On Mon, 20 May 2019, Richard Biener wrote: > There's not many details there but I always thought that the > "interesting" parts of the GCC history (official branches and trunk) > do _not_ contain merge commits so the GCC history forms a tree > rather than a DAG. (I'm not sure if there's an easy w

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Fri, 17 May 2019, Jason Merrill wrote: > Thanks for looking into this. My feeling has been that, if we give up > on reposurgeon, there's no need to start a new conversion at all: we > can just switch the current mirror over to being the primary > repository with some minor surgery (e.g. using

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Fri, 17 May 2019, Richard Sandiford wrote: > We're not starting from scratch on that though. The public git > (semi-)mirror has been going for a long time, so IMO we should just > inherit the policies for that. (Like you say, forced pushed are > restricted to the user namespace.) Policies ca

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

On Tue, May 21, 2019 at 12:03 AM Uros Bizjak wrote: > > On Mon, May 20, 2019 at 11:54 PM H.J. Lu wrote: > > > > > > Adjust gcc.target/i386/pr22076.c for 64-bit. > > > > > > > > > > * gcc.target/i386/pr22076.c: Adjusted for 64-bit. > > > > Well, it looks like you're just papering over a code

Re: CPUID Patch for IDT Winchip

On Mon, May 20, 2019 at 2:57 PM Uros Bizjak wrote: > > On Mon, May 20, 2019 at 6:12 PM tedheadster wrote: > > Did you instead mean "zeroing %EBX and %ECX regs should be enough"? > > Ah, yes. This is what I meant to say. The patch clears %ebx and %ecx. > Uros, your patch worked on real 32-bit h

C++ PATCH for c++/90548 - ICE with generic lambda and empty pack

We ICE here because we are accessing call_args even though it's empty: (gdb) p (*call_args).is_empty() $5 = true It's empty because the pack processed by tsubst_pack_expansion expanded into an empty vector, so nothing got pushed onto call_args. So handle that, and also handle pushing 'this' prop

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

On 5/20/19 2:00 PM, Joseph Myers wrote: Another couple of issues in the change as committed: + GCC_BAD ("%, ignored"); The word "malformed" should be outside the %<%>. +Warn about GCC format strings with strings unsuitable for diagnostics.. This help text should end with one '.', no

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

On 5/13/19 1:41 AM, Martin Liška wrote: > On 11/8/18 9:56 AM, Martin Liška wrote: >> On 11/7/18 11:23 PM, Jeff Law wrote: >>> On 10/30/18 6:28 AM, Martin Liška wrote: On 10/30/18 11:03 AM, Jakub Jelinek wrote: > On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: >> +hashtab_

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

On Mon, May 20, 2019 at 11:54 PM H.J. Lu wrote: > > > > Adjust gcc.target/i386/pr22076.c for 64-bit. > > > > > > > > * gcc.target/i386/pr22076.c: Adjusted for 64-bit. > > > Well, it looks like you're just papering over a code quality regression? > > > Or am I missing something? > > > > We h

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

On Mon, May 20, 2019 at 03:54:49PM -0600, Jeff Law wrote: > >>> Adjust gcc.target/i386/pr22076.c for 64-bit. > >>> > >>> * gcc.target/i386/pr22076.c: Adjusted for 64-bit. > >> Well, it looks like you're just papering over a code quality regression? > >> Or am I missing something? > > > > We

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

On Mon, May 20, 2019 at 2:52 PM Uros Bizjak wrote: > > On Mon, May 20, 2019 at 11:39 PM Jeff Law wrote: > > > > On 5/20/19 3:36 PM, H.J. Lu wrote: > > > With SSE emulation of MMX intrinsics in 64-bit mode, > > > > > > --- > > > __v8qi test () > > > { > > > __v8qi mm0 = {1,2,3,4,5,6,7,8}; > > >

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

On 5/20/19 3:51 PM, Uros Bizjak wrote: > On Mon, May 20, 2019 at 11:39 PM Jeff Law wrote: >> >> On 5/20/19 3:36 PM, H.J. Lu wrote: >>> With SSE emulation of MMX intrinsics in 64-bit mode, >>> >>> --- >>> __v8qi test () >>> { >>> __v8qi mm0 = {1,2,3,4,5,6,7,8}; >>> __v8qi mm1 = {11,22,33,44,55,

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

"H.J. Lu" writes: > With SSE emulation of MMX intrinsics in 64-bit mode, > > --- > __v8qi test () > { > __v8qi mm0 = {1,2,3,4,5,6,7,8}; > __v8qi mm1 = {11,22,33,44,55,66,77,88}; > volatile __m64 x; > > x = _mm_add_pi8 (mm0, mm1); > > return x; > } > --- > > is compiled into > > mo

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

On Mon, May 20, 2019 at 11:39 PM Jeff Law wrote: > > On 5/20/19 3:36 PM, H.J. Lu wrote: > > With SSE emulation of MMX intrinsics in 64-bit mode, > > > > --- > > __v8qi test () > > { > > __v8qi mm0 = {1,2,3,4,5,6,7,8}; > > __v8qi mm1 = {11,22,33,44,55,66,77,88}; > > volatile __m64 x; > > > >

Re: [PATCH] Hollerith constant documentation

On 5/13/19 8:57 AM, Mark Eggleston wrote: > The Hollerith constants support section in the gfortran manual stated > that they can be used with the ASSIGN statement. This is not the case as > a compilation error occurs and in any event the value of any such > constant would be larger than the larges

[C++ PATCH] P1091R3 - Extending structured bindings to be more like var decls

Hi! The following patch is an attempt at implementing these two papers. I must be missing something important, because in P1091R3 the rationale talks about the intent to support structured bindings with static, thread_local, constexpr, inline and extern, but the actual wording changes in the paper

Re: [PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

On 5/20/19 3:36 PM, H.J. Lu wrote: > With SSE emulation of MMX intrinsics in 64-bit mode, > > --- > __v8qi test () > { > __v8qi mm0 = {1,2,3,4,5,6,7,8}; > __v8qi mm1 = {11,22,33,44,55,66,77,88}; > volatile __m64 x; > > x = _mm_add_pi8 (mm0, mm1); > > return x; > } > --- > > is compile

[PATCH] i386: Adjust gcc.target/i386/pr22076.c for 64-bit

With SSE emulation of MMX intrinsics in 64-bit mode, --- __v8qi test () { __v8qi mm0 = {1,2,3,4,5,6,7,8}; __v8qi mm1 = {11,22,33,44,55,66,77,88}; volatile __m64 x; x = _mm_add_pi8 (mm0, mm1); return x; } --- is compiled into movq.LC0(%rip), %xmm0 movq.LC1(%rip

[committed] Fix libgomp build with very old glibc (PR libgomp/90527)

Hi! This fixes build against oldish glibcs, where posix_memalign has not been declared with the default feature test macros, but has been present in the library, so HAVE_POSIX_MEMALIGN is defined. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, committed to trunk and gcc-9-br

Re: [PATCH] Convert contrib/mklog script to Python 3

On 5/20/19 1:49 PM, Janne Blomqvist wrote: > Upstream will drop support for Python 2.x on January 1, 2020. This > patch converts the contrib/mklog script to Python 3. The process for > the conversion was as follows. > > - Use the futurize tool (https://python-future.org ) to apply the > print_

Re: [PATCH][RFC] Come up with TARGET_HAS_FAST_MEMPCPY_ROUTINE (PR middle-end/90263).

On Fri, May 17, 2019 at 09:38:31AM -0600, Jeff Law wrote: > > 2019-05-15 Martin Liska > > > > PR middle-end/90263 > > * gcc.c-torture/compile/pr90263.c: New test. > > * lib/target-supports.exp: Add check_effective_target_glibc. The test is: +UNRESOLVED: gcc.c-torture/compile/pr9026

Re: [PATCH] Fix uses of non-reserved names for template parameters

On 20/05/19 17:10 +0100, Jonathan Wakely wrote: On 20/05/19 16:05 +, Szabolcs Nagy wrote: On 20/05/2019 15:38, Jonathan Wakely wrote: On 20/05/19 14:11 +, Szabolcs Nagy wrote: On 17/05/2019 15:15, Jonathan Wakely wrote: * include/bits/random.h (seed_seq::param): Fix non-reserved n

Re: [PATCH 5/12] fix diagnostic quoting/spelling in c-family

Another couple of issues in the change as committed: > + GCC_BAD ("%, ignored"); The word "malformed" should be outside the %<%>. > +Warn about GCC format strings with strings unsuitable for diagnostics.. This help text should end with one '.', not two. -- Joseph S. Myers jos...@codesou

Re: [PATCH] Fix aarch64 exception handling (PR c++/59813)

On 5/14/19 4:57 PM, Jakub Jelinek wrote: > On Tue, May 14, 2019 at 01:08:27PM -0600, Jeff Law wrote: >>> In https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00484.html I've posted a >>> patch that would set it earlier (or it could be set during gimplification >>> and propagated during inlining, would

[PATCH] Convert contrib/mklog script to Python 3

Upstream will drop support for Python 2.x on January 1, 2020. This patch converts the contrib/mklog script to Python 3. The process for the conversion was as follows. - Use the futurize tool (https://python-future.org ) to apply the print_with_import, except, and dict transformations. - Remov

Re: New .md construct: define_insn_and_rewrite

On 5/14/19 8:14 AM, Richard Sandiford wrote: > Several SVE patterns need define_insn_and_splits that generate the > same insn_code, but with different operands. That's probably a > niche requirement, but it's cropping up often enough on the ACLE > branch that I think it would be good to have a syn

Re: [PATCH v2 2/3] Add predict_doloop_p target hook

On 5/15/19 10:44 AM, Segher Boessenkool wrote: > On Wed, May 15, 2019 at 10:53:43AM +0200, Richard Biener wrote: >> I wonder if making the doloop patterns (tried to find them in rs6000.md, >> but I only see define_expands with no predicates/alternatives...) > > "doloop_end" --> "ctr" --> "_" > (al

Re: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx

Thank you. From: Jeff Law Sent: Monday, May 20, 2019 9:13 PM To: Dragan Mladjenovic; gcc-patches@gcc.gnu.org Cc: Jakub Jelinek; Matthew Fortune Subject: Re: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx On 5/19/19 4:18 AM, Dragan Mladje

Re: [PATCH] netbsd EABI support

On 4/9/19 10:36 AM, Richard Earnshaw (lists) wrote: > On 09/04/2019 16:04, Jeff Law wrote: >> On 4/8/19 9:17 AM, co...@sdf.org wrote: >>> Pinging again in the hope of getting the patch in, I'd like to have >>> less outstanding patches :) (I have quite a few and new releases >>> can become painful!)

Re: C++ PATCH for c++/85679 and CWG 2094 - volatile scalars are trivially copyable

On Mon, May 20, 2019 at 01:51:13PM -0400, Jason Merrill wrote: > I'd add "again". Adjusted like that, thanks. On a related note, I often wish we had something like: but starting from scratch seems like a tremendous amount of work :/. -- Marek Polacek •

Re: [PATCH] Fix __builtin_init_dwarf_reg_size_table when built with -mfpxx

On 5/19/19 4:18 AM, Dragan Mladjenovic wrote: > Thank you. > > > What can I do to ensure this gets back-ported as further back as possible? I > assume that it can go all the way back to gcc 7 branch.Technically it's not a > regression fix, but I went ahead and backported to gcc-9 and gcc-8 bran

Re: C++ PATCH to fix naked inform call for strong using directive

On Mon, May 20, 2019 at 01:44:47PM -0400, Jason Merrill wrote: > On 5/20/19 11:56 AM, Marek Polacek wrote: > > This patch fixes a naked inform call that can be seen with -w. > > > > While at it, I added missing quotes; I'm surprisesd this wasn't fixed by the > > recent patch Martin submitted. > >

Re: CPUID Patch for IDT Winchip

On Mon, May 20, 2019 at 6:12 PM tedheadster wrote: > > On Mon, May 20, 2019 at 11:52 AM Uros Bizjak wrote: > > > How about the attached patch that enables zeroing only for 32bit > > processors, and only for cpuid leaf 1? Usually, __get_cpuid is used > > with a constant leaf argument, so we benefi

(C++) Remove -fdeduce-init-list?

Back in 2011, -fdeduce-init-list was marked as deprecated: . 7.5 years later, is it time to rip it out completely from the compiler? Marek

Re: [testsuite] aarch64,arm Add missing quotes to expected error message

On 5/20/19 8:50 AM, Martin Sebor wrote: > On 5/20/19 12:56 AM, Christophe Lyon wrote: >> Hi, >> >> After Martin's commit r271338, we now emit quotes around reserved >> names, and some tests started to fail on aarch64 and arm. >> >> This should fix them, OK? > > Thanks!  There will probably be a fe

Minor testsuite fixes after diagnostic cleanups

The 16bit integer targets are all failing Wtype-limits-Wextra.c due to slight changes in the diagnostic wording. This patch should fix 'em. Installing on the trunk. Jeff diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0b3c9be0837..0643cc35e69 100644 --- a/gcc/testsuite/Chan

Re: [PATCH] improve performance of std::allocator::deallocate

On 20/05/19 19:21 +0200, François Dumont wrote: On 5/20/19 1:14 PM, Jonathan Wakely wrote: - r1->deallocate(p, 2); + r1->deallocate(p, 2, alignof(char)); + __builtin_printf("%d\n", (int)bytes_allocated); Was this last line really intended to be added ? No, and I've already removed it loca

[PATCH,RFC 3/3] Create CTF debug hooks

Initialize CTF debug hooks when -gtLEVEL is specified. Import the CTF header from binutils. gcc/ChangeLog: * Makefile.in: Add ctfout.* files to GTFILES. * ctfout.c: New file. * ctfout.h: Likewise. * debug.h (ctf_debug_init): New function. * gengtype.c (ope

[PATCH,RFC 0/3] Support for CTF in GCC

Background : CTF is the Compact Ansi-C Type Format. It is a format designed to express some characteristics (specifically Type information) of the data types in a C program. CTF format is compact and fast; It was originally designed for use-cases like dynamic tracing, online in-application debuggin

[PATCH,RFC 2/3] Add CTF command line options : -gtLEVEL

-gtLEVEL is used to request CTF debug information and also to specify how much CTF debug information. gcc/ChangeLog: * common.opt: Add CTF debug info options. * doc/invoke.texi: Document the CTF debug info options. * flag-types.h (enum ctf_debug_info_levels): New enum.

[PATCH,RFC 1/3] Add new function lang_GNU_GIMPLE

gcc/ChangeLog: * langhooks.c (lang_GNU_GIMPLE): New Function. * langhooks.h (lang_GNU_GIMPLE): New Prototype. --- gcc/ChangeLog | 5 + gcc/langhooks.c | 9 + gcc/langhooks.h | 1 + 3 files changed, 15 insertions(+) diff --git a/gcc/langhooks.c b/gcc/langhooks.c ind

Re: C++ PATCH for c++/85679 and CWG 2094 - volatile scalars are trivially copyable

On 5/19/19 5:44 PM, Marek Polacek wrote: CWG 2094 partially reverts CWG 496, which means that volatile-qualified scalars are, once again, trivially copyable; [basic.types] now says "Scalar types, trivially copyable class types, arrays of such types, and cv-qualified versions of these types are co

Re: [C++ Patch, obvious?] Remove remnants of CONV_NONCONVERTING

On 5/20/19 10:22 AM, Paolo Carlini wrote: Hi, noticed a while ago this nit. Patchlet tested multiple times since, any objections? OK. Jason

Re: C++ PATCH to fix naked inform call for strong using directive

On 5/20/19 11:56 AM, Marek Polacek wrote: This patch fixes a naked inform call that can be seen with -w. While at it, I added missing quotes; I'm surprisesd this wasn't fixed by the recent patch Martin submitted. Bootstrapped/regtested on x86_64-linux, ok for trunk? OK. We might also change

Re: C++ PATCH to fix ext/utf8-2.C with -std=c++2a

On 5/20/19 12:23 PM, Marek Polacek wrote: On Mon, May 20, 2019 at 12:18:18PM -0400, Marek Polacek wrote: This test fails in C++2a since r271338, because the types in the "aka" differ: in C++17 and below we print: {aka 'const char [3]'} while in C++2a: {aka 'const char8_t [3]'} We can make

Re: Simplify more EXACT_DIV_EXPR comparisons

On 5/20/19 11:37 AM, Marc Glisse wrote: > On Mon, 20 May 2019, Jeff Law wrote: > >> On 5/20/19 3:16 AM, Richard Biener wrote: >>> Given code sinkings obvious effects on SSA value-range representation >>> it may make sense to add another instance of that pass earlier. >> There is an early pass alre

Re: Simplify more EXACT_DIV_EXPR comparisons

On Mon, 20 May 2019, Jeff Law wrote: On 5/20/19 3:16 AM, Richard Biener wrote: Given code sinkings obvious effects on SSA value-range representation it may make sense to add another instance of that pass earlier. There is an early pass already. IIUC Richard was talking about adding an early

Re: Simplify more EXACT_DIV_EXPR comparisons

On 5/20/19 2:04 AM, Richard Biener wrote: > On Sun, May 19, 2019 at 6:16 PM Marc Glisse wrote: >> >> Hello, >> >> 2 pieces: >> >> - the first one handles the case where the denominator is negative. It >> doesn't happen often with exact_div, so I don't handle it everywhere, but >> this one looked t

Re: Simplify more EXACT_DIV_EXPR comparisons

On 5/20/19 3:16 AM, Richard Biener wrote: > On Mon, May 20, 2019 at 10:16 AM Marc Glisse wrote: >> >> On Mon, 20 May 2019, Richard Biener wrote: >> >>> On Sun, May 19, 2019 at 6:16 PM Marc Glisse wrote: Hello, 2 pieces: - the first one handles the case where the deno

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

On 5/13/19 3:41 AM, Martin Liška wrote: On 11/8/18 9:56 AM, Martin Liška wrote: On 11/7/18 11:23 PM, Jeff Law wrote: On 10/30/18 6:28 AM, Martin Liška wrote: On 10/30/18 11:03 AM, Jakub Jelinek wrote: On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: +hashtab_chk_error () +{ + f

Re: [PATCH] improve performance of std::allocator::deallocate

On 5/20/19 1:14 PM, Jonathan Wakely wrote: - r1->deallocate(p, 2); + r1->deallocate(p, 2, alignof(char)); + __builtin_printf("%d\n", (int)bytes_allocated); Was this last line really intended to be added ?

Re: [testsuite] aarch64,arm Add missing quotes to expected error message

On 5/20/19 8:50 AM, Martin Sebor wrote: > On 5/20/19 12:56 AM, Christophe Lyon wrote: >> Hi, >> >> After Martin's commit r271338, we now emit quotes around reserved >> names, and some tests started to fail on aarch64 and arm. >> >> This should fix them, OK? > > Thanks!  There will probably be a fe

Re: [C++ PATCH] Commonixe using directive finishing

On 5/20/19 10:55 AM, Marek Polacek wrote: On Mon, May 20, 2019 at 09:48:57AM -0400, Nathan Sidwell wrote: + if (attribs != error_mark_node) +for (tree a = attribs; a; a = TREE_CHAIN (a)) + { + tree name = get_attribute_name (a); + if (current_binding_level->kind == sk_names

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: > > I think we should have two hooks: one is called with the struct loop as > > parameter; and the other is called for every statement in the loop, if > > the hook isn't null anyway. Or perhaps we do not need that second one. > I'd wait to

Re: C++ PATCH to fix ext/utf8-2.C with -std=c++2a

On Mon, May 20, 2019 at 12:18:18PM -0400, Marek Polacek wrote: > This test fails in C++2a since r271338, because the types in the "aka" differ: > in C++17 and below we print: > {aka 'const char [3]'} > while in C++2a: > {aka 'const char8_t [3]'} > > We can make the regexp accept both. ...beca

C++ PATCH to fix ext/utf8-2.C with -std=c++2a

This test fails in C++2a since r271338, because the types in the "aka" differ: in C++17 and below we print: {aka 'const char [3]'} while in C++2a: {aka 'const char8_t [3]'} We can make the regexp accept both. Tested on x86_64-linux, ok for trunk? 2019-05-20 Marek Polacek * g++.dg

Re: CPUID Patch for IDT Winchip

On Mon, May 20, 2019 at 11:52 AM Uros Bizjak wrote: > How about the attached patch that enables zeroing only for 32bit > processors, and only for cpuid leaf 1? Usually, __get_cpuid is used > with a constant leaf argument, so we benefit from constant propagation > into inline function. Also, accor

Re: [PATCH] Fix uses of non-reserved names for template parameters

On 20/05/19 16:05 +, Szabolcs Nagy wrote: On 20/05/2019 15:38, Jonathan Wakely wrote: On 20/05/19 14:11 +, Szabolcs Nagy wrote: On 17/05/2019 15:15, Jonathan Wakely wrote: * include/bits/random.h (seed_seq::param): Fix non-reserved name. * include/experimental/type_traits (is_d

Re: [PATCH] Fix uses of non-reserved names for template parameters

On 20/05/2019 15:38, Jonathan Wakely wrote: > On 20/05/19 14:11 +, Szabolcs Nagy wrote: >> On 17/05/2019 15:15, Jonathan Wakely wrote: >>> * include/bits/random.h (seed_seq::param): Fix non-reserved name. >>> * include/experimental/type_traits (is_detected_exact) >>> (is_detected_ex

Re: C++ PATCH to improve diagnostic for non-type template parameters

On 5/10/19 7:10 PM, Marek Polacek wrote: When we have template struct S { }; then in S s; "int()" is resolved to a type-id, as per [temp.arg]/2, causing this program to fail to compile. This can be rather confusing so I think we want to improve the diagnostic a bit. Bootstrapped/r

C++ PATCH to fix naked inform call for strong using directive

This patch fixes a naked inform call that can be seen with -w. While at it, I added missing quotes; I'm surprisesd this wasn't fixed by the recent patch Martin submitted. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-05-20 Marek Polacek * name-lookup.c (finish_using_dir

Re: CPUID Patch for IDT Winchip

On Mon, May 20, 2019 at 4:24 PM tedheadster wrote: > > Uros, > > On Mon, May 20, 2019 at 3:29 AM Uros Bizjak wrote: > > The CPUID documentation from Intel Architectures Developer's manual is > > crystal clear on the implementation: > > > > --quote-- > > CPUID—CPU Identification > > > > Returns pr

[PATCH, committed] Add myself to MAINTAINERS

=== --- ChangeLog (revision 271424) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2019-05-20 Vladislav Ivanishin + + * MAINTAINERS (Write After Approval): Add myself. + 2019-05-19 Peter Bergner * MAINTAINERS:

Re: CPUID Patch for IDT Winchip

On Sun, May 19, 2019 at 12:10 PM tedheadster wrote: > > I have confirmed that the IDT Winchip 2 does not expressly set %ecx > after a call to cpuid() with %eax = 1, and this causes incorrect > reporting of cpu capabilities. The %ecx register should return 0x0 > (and likely %ebx should too) on this

Re: [PATCH][AArch64] Emit TARGET_DOTPROD-specific sequence for sadv16qi

Ping. https://gcc.gnu.org/ml/gcc-patches/2019-05/msg00594.html Thanks, Kyrill On 5/13/19 12:18 PM, Kyrill Tkachov wrote: Hi Richard, On 5/9/19 9:06 AM, Richard Sandiford wrote: Kyrill Tkachov writes: +;; Helper expander for aarch64_abd_3 to save the callers +;; the hassle of constructing

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Mon, May 20, 2019 at 04:29:10PM +0200, Jakub Jelinek wrote: > On Mon, May 20, 2019 at 04:26:45PM +0200, Andreas Schwab wrote: > > On Mai 20 2019, Florian Weimer wrote: > > > > > If GCC policy is to reject merge commits, a command similar to > > > “git log --pretty=oneline | wc -l” gives someth

Re: [C++ PATCH] Commonixe using directive finishing

On Mon, May 20, 2019 at 09:48:57AM -0400, Nathan Sidwell wrote: > + if (attribs != error_mark_node) > +for (tree a = attribs; a; a = TREE_CHAIN (a)) > + { > + tree name = get_attribute_name (a); > + if (current_binding_level->kind == sk_namespace > + && is_attribute_p ("st

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

> I don't see how it is safe in a late pass when it is not safe in an > earlier one. Optimization is imperfect - we could fail to remove > an "obvious" never taken exit and still have a loop that appears to be > finite according to our definition. Yes. it is. This is somewhat similar to strict-a

Re: [testsuite] aarch64,arm Add missing quotes to expected error message

On 5/20/19 12:56 AM, Christophe Lyon wrote: Hi, After Martin's commit r271338, we now emit quotes around reserved names, and some tests started to fail on aarch64 and arm. This should fix them, OK? Thanks! There will probably be a few more like this on other targets. Jeff has been running a

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

Hi, On Mon, 20 May 2019, Richard Biener wrote: > > The C++ standard says that do{}while(1) is __builtin_unreachable(), we > > don't have to preserve it. There is no mention of anything like a > > "nontrivial exit condition". Other languages may have a different > > opinion though, so it would

Re: [testsuite] PR90106 Fix cdce3.c testcase

On 5/20/19 6:00 AM, Christophe Lyon wrote: > Hi, > > As discussed in the PR, the new cdce3.c test fails on > arm-linux-gnueabi, and passes on arm-linux-gnueabihf. > > On arm-linux-gnueabi, the generated code is: > .arm > .fpu softvfp > .type foo, %function > foo: >

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On 5/20/19 4:24 AM, Segher Boessenkool wrote: > Let me try to answer a bit here... > > On Mon, May 20, 2019 at 11:28:26AM +0200, Richard Biener wrote: >> On Thu, 16 May 2019, li...@linux.ibm.com wrote: >>> +/* Predict whether the given loop in gimple will be transformed in the RTL >>> + doloop_o

Re: [PATCH] Fix uses of non-reserved names for template parameters

On 20/05/19 14:11 +, Szabolcs Nagy wrote: On 17/05/2019 15:15, Jonathan Wakely wrote: * include/bits/random.h (seed_seq::param): Fix non-reserved name. * include/experimental/type_traits (is_detected_exact) (is_detected_exact_v): Likewise. * include/pstl/execution_defs.h (is_

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Mai 20 2019, Jakub Jelinek wrote: > On Mon, May 20, 2019 at 04:26:45PM +0200, Andreas Schwab wrote: >> On Mai 20 2019, Florian Weimer wrote: >> >> > If GCC policy is to reject merge commits, a command similar to >> > “git log --pretty=oneline | wc -l” gives something that is very >> >> git

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Mon, May 20, 2019 at 04:26:45PM +0200, Andreas Schwab wrote: > On Mai 20 2019, Florian Weimer wrote: > > > If GCC policy is to reject merge commits, a command similar to > > “git log --pretty=oneline | wc -l” gives something that is very > > git rev-list HEAD | wc -l That is still in the 1.3

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Mai 20 2019, Florian Weimer wrote: > If GCC policy is to reject merge commits, a command similar to > “git log --pretty=oneline | wc -l” gives something that is very git rev-list HEAD | wc -l Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Mon, May 20, 2019 at 03:56:35PM +0200, Florian Weimer wrote: > * Andrew Pinski: > > > On Sun, May 19, 2019 at 12:54 PM Segher Boessenkool > > wrote: > > >> Git can bisect automatically just fine, there is no upside to doing things > >> manually. In git there are various handy ways of referri

Re: CPUID Patch for IDT Winchip

Uros, On Mon, May 20, 2019 at 3:29 AM Uros Bizjak wrote: > The CPUID documentation from Intel Architectures Developer's manual is > crystal clear on the implementation: > > --quote-- > CPUID—CPU Identification > > Returns processor identification and feature > information to the EAX, EBX, ECX, an

[C++ Patch, obvious?] Remove remnants of CONV_NONCONVERTING

Hi, noticed a while ago this nit. Patchlet tested multiple times since, any objections? Thanks, Paolo. 2019-05-20 Paolo Carlini * cp-tree.h: Remove remnants of CONV_NONCONVERTING. Index: cp-tree.h ==

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On Mon, May 20, 2019 at 03:56:35PM +0200, Florian Weimer wrote: > If GCC policy is to reject merge commits, a command similar to > “git log --pretty=oneline | wc -l” gives something that is very > much like a Subversion revision number, in the sense that it matches > the commit ordering and that th

Re: [PATCH] Fix uses of non-reserved names for template parameters

On 17/05/2019 15:15, Jonathan Wakely wrote: > * include/bits/random.h (seed_seq::param): Fix non-reserved name. > * include/experimental/type_traits (is_detected_exact) > (is_detected_exact_v): Likewise. > * include/pstl/execution_defs.h (is_execution_policy) > (is_execution_pol

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

On Mon, May 20, 2019 at 4:00 PM Feng Xue OS wrote: > > >> I specialized a CD-DCE pass, named CD-DCE2, and only in this pass, loop > >> removal based on assumed finteness is performed. Please check the patch. > > > > Oh, but why not generally do this? > > It is nature that real finiteness of loop

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

>> I specialized a CD-DCE pass, named CD-DCE2, and only in this pass, loop >> removal based on assumed finteness is performed. Please check the patch. > Oh, but why not generally do this? It is nature that real finiteness of loop should override assumed one. As you said, CD-DCE could be invocat

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

* Andrew Pinski: > On Sun, May 19, 2019 at 12:54 PM Segher Boessenkool > wrote: >> Git can bisect automatically just fine, there is no upside to doing things >> manually. In git there are various handy ways of referring to commits; you >> can say master@{3 days ago} for example, or zut@{31}

[C++ PATCH] Commonixe using directive finishing

This patch commonizes local- and namespace-scope using directive finishing. While a small cleanup, it matches a more significant using-decl patch I have next. applying to trunk. nathan -- Nathan Sidwell 2019-05-20 Nathan Sidwell gcc/cp/ * name-lookup.c (finish_namespace_using_directive)

  1   2   >