Re: C++ PATCH for c++/88294 - ICE with non-constant noexcept-specifier

2019-02-22 Thread Jason Merrill
On Fri, Feb 22, 2019 at 1:17 PM Marek Polacek wrote: > On Thu, Feb 21, 2019 at 02:57:28PM -1000, Jason Merrill wrote: > > On 2/21/19 1:34 PM, Marek Polacek wrote: > > > On Thu, Feb 21, 2019 at 11:22:41AM -1000, Jason Merrill wrote: > > > > On 2/21/19 10:56 AM, Marek Polacek wrote: > > > > > On Wed

[PATCH, libgfortran] PR83387 Defined output does not work for a derived type that has no components

2019-02-22 Thread Jerry DeLisle
This patch is simple and obvious. Regression tested on x86_64-pc-linux-gnu. Test case attached. (Changelog for test case will be included) I will commit tomorrow. Regards, Jerry 2019-02-23 Jerry DeLisle PR fortran/84387 * trans-io.c (transfer_expr): Do not return if there

Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits

2019-02-22 Thread Jonathan Wakely
On 23/02/19 01:26 +, Jonathan Wakely wrote: On 23/02/19 02:06 +0100, Jakub Jelinek wrote: On Sat, Feb 23, 2019 at 01:02:20AM +, Jonathan Wakely wrote: PR libstdc++/89446 * include/bits/char_traits.h (__constant_char_array): Check index is in range before derefere

Re: PING^2: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

2019-02-22 Thread H.J. Lu
On Fri, Feb 22, 2019 at 11:18 AM H.J. Lu wrote: > > On Fri, Dec 14, 2018 at 1:28 PM Jeff Law wrote: > > > > On 12/11/18 9:03 AM, H.J. Lu wrote: > > > On Mon, Dec 3, 2018 at 5:45 AM H.J. Lu wrote: > > >> On Mon, Jun 18, 2018 at 2:20 AM Richard Biener > > >> wrote: > > >>> On Fri, Jun 15, 2018 at

[PATCH] make -Wformat-overflow consistent between data models

2019-02-22 Thread Martin Sebor
A few tests recently added for PR 88993 introduced an assumption on the host compiler's data model that breaks between ILP32 and LP64, causing failures test run failures (see https://gcc.gnu.org/ml/gcc-patches/2019-02/msg01867.html). Rather than avoiding the problem in the tests the attached patch

[PATCH] improve performance of std::allocator::deallocate

2019-02-22 Thread Pádraig Brady
Attached is a simple patch which has been extensively tested within Facebook, and is enabled by default in our code base. Passing the size to the allocator allows it to optimize deallocation, and this was seen to significantly reduce the work required in jemalloc, with about 40% reduction in CPU c

Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits

2019-02-22 Thread Jonathan Wakely
On 23/02/19 01:02 +, Jonathan Wakely wrote: +// { dg-options "-std=gnu++17 -fexceptions -fnon-call-exceptions -O1" } +// { dg-do run { target { powerpc*-*-linux* i?86-*-linux* x86_64-*-linux* } } } I forgot to say that this is a conservative list of targets where -fnon-call-exceptions is su

Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits

2019-02-22 Thread Jonathan Wakely
On 23/02/19 02:06 +0100, Jakub Jelinek wrote: On Sat, Feb 23, 2019 at 01:02:20AM +, Jonathan Wakely wrote: PR libstdc++/89446 * include/bits/char_traits.h (__constant_char_array): Check index is in range before dereferencing. * testsuite/21_strings/basic_strin

[PATCH] libgomp: Add master thread to thread pool

2019-02-22 Thread Kevin Buettner
For debugging purposes, I need to be able to find the master thread in the thread pool. Without this patch, I see over 20 failures in the tests that I've written for GDB. I've also tested this in the gcc tree - no regressions. libgomp/ChangeLog: * team.c (gomp_team_start): Initialize po

Re: [PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits

2019-02-22 Thread Jakub Jelinek
On Sat, Feb 23, 2019 at 01:02:20AM +, Jonathan Wakely wrote: > PR libstdc++/89446 > * include/bits/char_traits.h (__constant_char_array): Check index is > in range before dereferencing. > * testsuite/21_strings/basic_string_view/operators/char/89446.cc: > New test.

[PATCH] PR libstdc++/89446 fix null pointer dereference in char_traits

2019-02-22 Thread Jonathan Wakely
PR libstdc++/89446 * include/bits/char_traits.h (__constant_char_array): Check index is in range before dereferencing. * testsuite/21_strings/basic_string_view/operators/char/89446.cc: New test. Tested x86_64-linux, committed to gcc-8-branch and gcc-7-branc

Re: [PATCH] Minimum version of mpfr? (was Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074)), take 2

2019-02-22 Thread David Malcolm
On Fri, 2019-02-22 at 14:19 +0100, Jakub Jelinek wrote: > On Thu, Feb 21, 2019 at 04:50:27PM -0500, David Malcolm wrote: > > gcc/fortran/ChangeLog: > > PR middle-end/88074 > > * simplify.c (norm2_add_squared): Use mp_exp_t rather than > > mpfr_exp_t. > > I have discussed this with Rich

[PATCH] Limit simplify_merge_mask optimization to cases where it can't trap (PR rtl-optimization/89445)

2019-02-22 Thread Jakub Jelinek
Hi! The following testcase is miscompiled on x86_64. The problem is that simplify_merge_mask optimization throws away an inner VEC_MERGE when there is an outer one with the same mask. This can be done only if the change doesn't have observable side-effects. The code already uses side_effects_p

Re: PING [PATCH] avoid 4095/INT_MAX warning for fprintf (PR 88993)

2019-02-22 Thread Martin Sebor
On 2/22/19 4:33 PM, Jakub Jelinek wrote: On Fri, Feb 22, 2019 at 04:17:14PM -0700, Martin Sebor wrote: On 2/22/19 3:44 PM, Jakub Jelinek wrote: On Tue, Feb 19, 2019 at 05:43:53PM -0700, Martin Sebor wrote: PR tree-optimization/88993 PR tree-optimization/88835 * gcc.dg/t

[PATCH] Improve arm and aarch64 casesi (PR target/70341)

2019-02-22 Thread Jakub Jelinek
Hi! The testcase in the PR doesn't hoist any memory loads from the large switch before the switch on aarch64 and arm (unlike e.g. x86), because the arm/aarch64 casesi patterns don't properly annotate the memory load from the jump table. It is created by gen_* and in RTL directly one can't specify

Re: PING [PATCH] avoid 4095/INT_MAX warning for fprintf (PR 88993)

2019-02-22 Thread Jakub Jelinek
On Fri, Feb 22, 2019 at 04:17:14PM -0700, Martin Sebor wrote: > On 2/22/19 3:44 PM, Jakub Jelinek wrote: > > On Tue, Feb 19, 2019 at 05:43:53PM -0700, Martin Sebor wrote: > > > PR tree-optimization/88993 > > > PR tree-optimization/88835 > > > * gcc.dg/tree-ssa/builtin-fprintf-warn-2.c: New te

Re: C++ PATCH for c++/88294 - ICE with non-constant noexcept-specifier

2019-02-22 Thread Marek Polacek
On Thu, Feb 21, 2019 at 02:57:28PM -1000, Jason Merrill wrote: > On 2/21/19 1:34 PM, Marek Polacek wrote: > > On Thu, Feb 21, 2019 at 11:22:41AM -1000, Jason Merrill wrote: > > > On 2/21/19 10:56 AM, Marek Polacek wrote: > > > > On Wed, Feb 20, 2019 at 01:53:18PM -1000, Jason Merrill wrote: > > > >

Re: PING [PATCH] avoid 4095/INT_MAX warning for fprintf (PR 88993)

2019-02-22 Thread Martin Sebor
On 2/22/19 3:44 PM, Jakub Jelinek wrote: On Tue, Feb 19, 2019 at 05:43:53PM -0700, Martin Sebor wrote: PR tree-optimization/88993 PR tree-optimization/88835 * gcc.dg/tree-ssa/builtin-fprintf-warn-2.c: New test. * gcc.dg/tree-ssa/builtin-printf-warn-2.c: New test.

Re: PING [PATCH] avoid 4095/INT_MAX warning for fprintf (PR 88993)

2019-02-22 Thread Jakub Jelinek
On Tue, Feb 19, 2019 at 05:43:53PM -0700, Martin Sebor wrote: > PR tree-optimization/88993 > PR tree-optimization/88835 > * gcc.dg/tree-ssa/builtin-fprintf-warn-2.c: New test. > * gcc.dg/tree-ssa/builtin-printf-warn-2.c: New test. > * gcc.dg/tree-ssa/builtin-snprintf-w

[PATCH] Fix var-tracking ICE on ARM due to backend bug (PR target/89438)

2019-02-22 Thread Jakub Jelinek
Hi! The following testcase ICEs on arm, because the backend creates non-canonical SImode constants (0x8000). CONST_INTs always need to be sign-extended from their corresponding mode to HOST_WIDE_INT. Fixed thusly, bootstrapped/regtested on armv7hl-linux-gnueabi, ok for trunk? 2019-02-22 Ja

Re: [PATCH] luoxhu - backport from trunk r255555, r257253 and r258137

2019-02-22 Thread Segher Boessenkool
On Wed, Feb 20, 2019 at 09:40:25AM +0800, Xiong Hu Luo wrote: > On 2019/2/20 AM6:24, Segher Boessenkool wrote: > >On Tue, Feb 19, 2019 at 01:23:53AM -0600, luo...@linux.ibm.com wrote: > >>This is a backport of r25, r257253 and r258137 of trunk to > >>gcc-7-branch. > >>The patches were on trunk

Re: [patch] Add baseline for SPARC64/Linux

2019-02-22 Thread Eric Botcazou
> Sorry for the delay, I'm in a meeting all week with limited time for > patch review. No problem, thanks for reviewing! > We don't usually include the __once_callable symbols in the baseline > file, are you sure it's correct to do so for sparc64-linux-gnu? > > +TLS:8:_ZSt11__once_call@@GLIBCXX_

Re: [patch] Add baseline for SPARC64/Linux

2019-02-22 Thread Jonathan Wakely
On 22/02/19 21:26 +0100, Jakub Jelinek wrote: On Fri, Feb 22, 2019 at 08:24:09PM +, Jonathan Wakely wrote: > > We don't usually include the __once_callable symbols in the baseline > > file, are you sure it's correct to do so for sparc64-linux-gnu? > > > > +TLS:8:_ZSt11__once_call@@GLIBCXX_3.

Re: [PR fortran/83057, patch] - OPEN without a filename and without STATUS='SCRATCH' could produce a warning

2019-02-22 Thread Harald Anlauf
Committed to trunk as rev. 269134. Thanks for the review! Harald On 02/22/19 06:28, Jerry DeLisle wrote: > On 2/20/19 2:34 PM, Harald Anlauf wrote: >> There was a rather obvious bug in the logic for checking the arguments >> to the OPEN statement when NEWUNIT= was specified, which prohibited >>

[Committed] PR fortran/89431 -- correct documentation

2019-02-22 Thread Steve Kargl
Change and patch are self-explanatory. 2019-02-22 Steven G. Kargl PR fortran/89431 * gfortran.texi: Fix documentation to match the implementation. Index: gfortran.texi === --- gfortran.texi (revision 269131)

Re: [patch] Add baseline for SPARC64/Linux

2019-02-22 Thread Jakub Jelinek
On Fri, Feb 22, 2019 at 08:24:09PM +, Jonathan Wakely wrote: > > > We don't usually include the __once_callable symbols in the baseline > > > file, are you sure it's correct to do so for sparc64-linux-gnu? > > > > > > +TLS:8:_ZSt11__once_call@@GLIBCXX_3.4.11 > > > +TLS:8:_ZSt15__once_callable@

Re: [patch] Add baseline for SPARC64/Linux

2019-02-22 Thread Jonathan Wakely
On 22/02/19 20:43 +0100, Jakub Jelinek wrote: On Fri, Feb 22, 2019 at 07:24:57PM +, Jonathan Wakely wrote: On 22/02/19 08:27 +0100, Eric Botcazou wrote: > > 2019-02-20 Eric Botcazou > > > > * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux. > > * config/abi/po

Re: [patch] Add baseline for SPARC64/Linux

2019-02-22 Thread Jakub Jelinek
On Fri, Feb 22, 2019 at 07:24:57PM +, Jonathan Wakely wrote: > On 22/02/19 08:27 +0100, Eric Botcazou wrote: > > > 2019-02-20 Eric Botcazou > > > > > > * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux. > > > * config/abi/post/sparc64-linux-gnu: New directory. >

Re: [patch] Add baseline for SPARC64/Linux

2019-02-22 Thread Jonathan Wakely
On 22/02/19 08:27 +0100, Eric Botcazou wrote: 2019-02-20 Eric Botcazou * configure.host (abi_baseline_pair): Adjust for SPARC64/Linux. * config/abi/post/sparc64-linux-gnu: New directory. * config/abi/post/sparc64-linux-gnu/baseline_symbols.txt: New file. * conf

Re: PING^2: [PATCH] i386; Add -mmanual-endbr and cf_check function attribute

2019-02-22 Thread H.J. Lu
On Fri, Dec 14, 2018 at 1:28 PM Jeff Law wrote: > > On 12/11/18 9:03 AM, H.J. Lu wrote: > > On Mon, Dec 3, 2018 at 5:45 AM H.J. Lu wrote: > >> On Mon, Jun 18, 2018 at 2:20 AM Richard Biener > >> wrote: > >>> On Fri, Jun 15, 2018 at 2:59 PM H.J. Lu wrote: > Currently GCC inserts ENDBR instr

Re: C++ PATCH for c++/89420 - ICE with CAST_EXPR in explicit-specifier

2019-02-22 Thread Jason Merrill
OK, thanks. Jason On Fri, Feb 22, 2019 at 6:11 AM Marek Polacek wrote: > > On Thu, Feb 21, 2019 at 03:47:44PM -1000, Jason Merrill wrote: > > On 2/21/19 1:35 PM, Marek Polacek wrote: > > > We were ICEing because we called build_converted_constant_expr on an > > > expression > > > that wasn't va

Re: [PATCH] Fix -Wattributes warning in libstdc++ (PR libstdc++/89402)

2019-02-22 Thread Jonathan Wakely
On Fri, 22 Feb 2019 at 18:47, Jakub Jelinek wrote: > > On Fri, Feb 22, 2019 at 08:35:25AM -0700, Martin Sebor wrote: > > > /home/jwakely/src/gcc/libstdc++-v3/src/c++98/compatibility-ldbl.cc:78:65: > > > warning: ‘pure’ attribute on function returning ‘void’ [-Wattributes] > > >78 | _GLIBCXX_P

[PATCH] Fix -Wattributes warning in libstdc++ (PR libstdc++/89402)

2019-02-22 Thread Jakub Jelinek
On Fri, Feb 22, 2019 at 08:35:25AM -0700, Martin Sebor wrote: > > /home/jwakely/src/gcc/libstdc++-v3/src/c++98/compatibility-ldbl.cc:78:65: > > warning: ‘pure’ attribute on function returning ‘void’ [-Wattributes] > >   78 |   _GLIBCXX_PURE __attribute__((alias ("_ZNKSt3tr14hashIeEclEe"))); > >  

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-22 Thread Martin Sebor
I already explained the rationale behind the decision to have the built-in accept expressions: to be able to easily query for type attributes in expressions such as: typedef __attribute__ ((may_alias)) int* BadInt; void f (BadInt *p) { _Static_assert (__builtin_has_attribute (*p, m

Re: [PATCH] x86: (Reapply) Move AESNI generation to Skylake and Goldmont

2019-02-22 Thread H.J. Lu
On Thu, Feb 21, 2019 at 3:25 PM H.J. Lu wrote: > > On Thu, Feb 21, 2019 at 3:10 PM Thiago Macieira > wrote: > > > > This is a repeat of commit r263989, which commit r264052 accidentally > > reverted. > > > > Original commit message: > > > > The instruction set first appeared with Westmere, but no

[PING**2] [PATCH] Fix not 8-byte aligned ldrd/strd on ARMv5

2019-02-22 Thread Bernd Edlinger
Ping... On 2/12/19 1:32 PM, Bernd Edlinger wrote: > Hi! > > I'd like to ping for this patch: > https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00248.html > > Thanks > Bernd. > > > On 2/5/19 4:07 PM, Bernd Edlinger wrote: >> Hi, >> >> due to the AAPCS parameter passing of 8-byte aligned structure

Re: PING [PATCH] fix ICE in __builtin_has_attribute (PR 88383 and 89288)

2019-02-22 Thread Marek Polacek
On Thu, Feb 21, 2019 at 03:39:21PM -0700, Martin Sebor wrote: > On 2/21/19 1:27 PM, Jeff Law wrote: > > On 2/21/19 1:12 PM, Martin Sebor wrote: > > > On 2/21/19 12:08 PM, Jeff Law wrote: > > > > On 2/18/19 7:53 PM, Martin Sebor wrote: > > > > > Please let me know what it will take to get the fix fo

[committed] [rtl-optimization/87761] Partial fix by improving ability to generate exts instructions

2019-02-22 Thread Jeff Law
This mips.md fixes part of 87761. Specifically the failures for octeon-exts-3. There's roughly two ways to address the octeon-exts-3 issue. One is to recognize that (set (dest) (ashiftrt (truncate (shift ... is really just a bitfield extraction. This is fairly easily done in make_field_assi

[PATCH] i386: Properly encode xmm16-xmm31/ymm16-ymm31 for vector move

2019-02-22 Thread H.J. Lu
Hi Jan, Uros, This patch fixes the wrong code bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89229 Tested on AVX2 and AVX512 with and without --with-arch=native. OK for trunk? Thanks. H.J. -- i386 backend has INT_MODE (OI, 32); INT_MODE (XI, 64); So, XI_MODE represents 64 INTEGER bytes =

Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-22 Thread James Greenhalgh
On Fri, Feb 22, 2019 at 09:39:59AM -0600, Matthew Malcomson wrote: > Hi James, > > On 22/02/19 00:09, James Greenhalgh wrote: > > On Mon, Feb 18, 2019 at 08:40:12AM -0600, Matthew Malcomson wrote: > >> > >> Additionally, this patch contains two tidy-ups (happy to remove them or > >> put in > >> a

Re: C++ PATCH for c++/89420 - ICE with CAST_EXPR in explicit-specifier

2019-02-22 Thread Marek Polacek
On Thu, Feb 21, 2019 at 03:47:44PM -1000, Jason Merrill wrote: > On 2/21/19 1:35 PM, Marek Polacek wrote: > > We were ICEing because we called build_converted_constant_expr on an > > expression > > that wasn't value-dependent, but it still contained template codes, and that > > didn't work too wel

Re: [Patch] [aarch64] PR target/89324 Handle stack pointer for SUBS/ADDS instructions

2019-02-22 Thread Matthew Malcomson
Hi James, On 22/02/19 00:09, James Greenhalgh wrote: > On Mon, Feb 18, 2019 at 08:40:12AM -0600, Matthew Malcomson wrote: >> >> Additionally, this patch contains two tidy-ups (happy to remove them or put >> in >> a separate patch if people want): > > Generally, yes I prefer that. > I've remove

Re: [committed] Fix -Wmissing-attributes warning in libstdc++ (PR libstdc++/89402)

2019-02-22 Thread Martin Sebor
On 2/21/19 6:10 PM, Jonathan Wakely wrote: On 20/02/19 09:07 +0100, Jakub Jelinek wrote: Hi! The following patch fixes a warning when building on targets where long double switched from being the same as double to something wider, like e.g. powerpc*-linux, alpha*-linux, s390*-linux etc. Fixed

Re: [PATCH] Fix a test (PR testsuite/89441).

2019-02-22 Thread John David Anglin
Hi Martin, On 2019-02-22 5:21 a.m., Martin Liška wrote: > Hi. > > This patch makes main not hidden (as reported in the PR). > John: Can you verify it fixes your problem on hppa64-hp-hpux11.11 target? Your patch fixed the problem on the hppa64-hp-hpux11.11 target but we also need to require visib

Re: [PR middle-end/85598] make -Wprintf* pass use loop info for PHI's

2019-02-22 Thread Aldy Hernandez
On 2/22/19 7:34 AM, Jakub Jelinek wrote: On Fri, Feb 22, 2019 at 01:24:38PM +0100, Richard Biener wrote: I believe the flag_printf_return_value change was the final agreed upon solution. Tested on x86-64 Linux. OK for trunk? OK. Just a nit, could you please s/optimizing_late/use_scev/ o

Re: [PATCH] Minimum version of mpfr? (was Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074)), take 2

2019-02-22 Thread Richard Biener
On Fri, 22 Feb 2019, Jakub Jelinek wrote: > On Thu, Feb 21, 2019 at 04:50:27PM -0500, David Malcolm wrote: > > gcc/fortran/ChangeLog: > > PR middle-end/88074 > > * simplify.c (norm2_add_squared): Use mp_exp_t rather than > > mpfr_exp_t. > > I have discussed this with Richard on IRC ea

[PATCH] Minimum version of mpfr? (was Re: [PATCH] Fix up norm2 simplification (PR middle-end/88074)), take 2

2019-02-22 Thread Jakub Jelinek
On Thu, Feb 21, 2019 at 04:50:27PM -0500, David Malcolm wrote: > gcc/fortran/ChangeLog: > PR middle-end/88074 > * simplify.c (norm2_add_squared): Use mp_exp_t rather than > mpfr_exp_t. I have discussed this with Richard on IRC earlier today, there is another issue that mpfr_regul

Re: [committed][nvptx, libgomp] Move rtl-dump test-cases to libgomp

2019-02-22 Thread Tom de Vries
On 22-02-19 12:09, Thomas Schwinge wrote: > There is however still a problem here: if you have more than one offload > compiler configured, Ah, right, that's a configuration I'm not testing, evidently. > all of them will react to > '-foffload=-fdump-rtl-mach', and will overwrite their dump files

Re: [PR middle-end/85598] make -Wprintf* pass use loop info for PHI's

2019-02-22 Thread Jakub Jelinek
On Fri, Feb 22, 2019 at 01:24:38PM +0100, Richard Biener wrote: > > I believe the flag_printf_return_value change was the final agreed upon > > solution. > > > > Tested on x86-64 Linux. > > > > OK for trunk? > > OK. Just a nit, could you please s/optimizing_late/use_scev/ or something similar? W

Re: [PR middle-end/85598] make -Wprintf* pass use loop info for PHI's

2019-02-22 Thread Richard Biener
On Fri, Feb 22, 2019 at 10:57 AM Aldy Hernandez wrote: > > On 1/31/19 9:56 AM, Richard Biener wrote: > > On Thu, Jan 31, 2019 at 3:45 PM Jakub Jelinek wrote: > >> > >> On Thu, Jan 31, 2019 at 09:30:13AM -0500, Aldy Hernandez wrote: > > (LOOPS_HAVE_PREHEADERS). This avoids unnecessary changes

[PATCH][3/2] Fix PR87609

2019-02-22 Thread Richard Biener
And I forgot to update the copying to not copy non-inlined cliques... Bootstrap / regtest running on x86_64-unknown-linux-gnu. Richard. 2019-02-22 Richard Biener PR tree-optimization/87609 * tree-cfg.c (gimple_duplicate_bb): Only remap inlined cliques. Index: gcc/tree-cfg.

PR89433 "Repeated use of the OpenACC 'routine' directive"

2019-02-22 Thread Thomas Schwinge
Hi! To resolve PR89433 "Repeated use of the OpenACC 'routine' directive" at least for C/C++, I intend to push the attached patches in next GCC development stage 1 (unless that should be addressed right now, and also on other GCC release branches?). The corresponding Fortran changes will require a

Re: [committed][nvptx, libgomp] Move rtl-dump test-cases to libgomp

2019-02-22 Thread Thomas Schwinge
Hi! On Wed, 19 Dec 2018 15:28:41 +0100, Tom de Vries wrote: > The goacc.exp test-cases nvptx-merged-loop.c and nvptx-sese-1.c are failing > during linking due to missing libgomp.spec. Right; see also , from three years ago.

Re: [nvptx, committed] Unify C/Fortran routine handling in nvptx_goacc_validate_dims

2019-02-22 Thread Thomas Schwinge
Hi! On Mon, 17 Dec 2018 22:46:50 +0100, Tom de Vries wrote: > [ was: Re: [nvptx] vector length patch series ] > > On 14-12-18 20:58, Tom de Vries wrote: > >> 0004-openacc-Make-GFC-default-to-1-for-OpenACC-routine-di.patch > > If I remove this, I run into ICEs in the compiler, but I think that >

Re: [PATCH, GCC, AArch64] Fix a couple of bugs in BTI

2019-02-22 Thread Sudakshina Das
On 21/02/2019 22:52, James Greenhalgh wrote: > On Thu, Feb 21, 2019 at 06:19:10AM -0600, Sudakshina Das wrote: >> Hi >> >> While doing more testing I found a couple of issues with my BTI patches. >> This patch fixes them: >> 1) Remove a reference to return address key. The original patch was >> wri

Re: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior

2019-02-22 Thread Thomas Schwinge
Hi! On Fri, 14 Dec 2018 22:24:47 +0100, I wrote: > On Fri, 25 May 2018 13:01:58 -0700, Cesar Philippidis > wrote: > > This patch updates GCC's to support OpenACC 2.5's data clause semantics. > > In OpenACC 2.5, copy, copyin and copyout all behave like their > > present_or_* counterparts in Ope

Re: [PATCH] Fix PR78027

2019-02-22 Thread Thomas Schwinge
Hi! On Thu, 8 Dec 2016 15:05:10 -0800, Cesar Philippidis wrote: > --- /dev/null > +++ b/gcc/testsuite/gfortran.dg/goacc/pr78027.f90 > @@ -0,0 +1,20 @@ > +! { dg-additional-options "-fopenmp -O2 -fdump-ipa-icf" } > +[...] To address unrelated compiler diagnostics, I've just committed to trunk in

[PATCH] Significantly speed up verifiers for a cgraph_node with many clones.

2019-02-22 Thread Martin Liška
Hi. The patch makes a significant verifier speed up in a project that has a dtor for which we create ~70.000 clones. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-02-22 Martin Liska * cgraph.c (cgrap

Re: Use correct location information for OpenACC shape and simple clauses in C/C++

2019-02-22 Thread Thomas Schwinge
Hi! On Thu, 4 Aug 2016 11:03:25 -0600, Jeff Law wrote: > On 07/27/2016 09:17 AM, Thomas Schwinge wrote: > > I found that for a lot of OpenACC (and potentially also OpenMP) clauses > > (in C/C++ front ends; didn't look at Fortran), we use wrong location > > information. The problem is that > > c_

[PATCH] Fix PR89440

2019-02-22 Thread Richard Biener
The following removes an assert in the vectorizer since we can handle this nested cycle just fine. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2019-02-22 Richard Biener PR tree-optimization/89440 * tree-vect-loop.c (vect_create_epilog_for_reductio

[PATCH, wwwdocs] Mention -march=armv8.5-a and other new command line options for AArch64 and Arm for GCC 9

2019-02-22 Thread Sudakshina Das
Hi This patch documents the addition of the new Armv8.5-A and corresponding extensions in the gcc-9/changes.html. As per https://gcc.gnu.org/about.html, I have used W3 Validator. Is this ok for cvs? Thanks Sudi Index: htdocs/gcc-9/changes.html

[PATCH] Fix a test (PR testsuite/89441).

2019-02-22 Thread Martin Liška
Hi. This patch makes main not hidden (as reported in the PR). John: Can you verify it fixes your problem on hppa64-hp-hpux11.11 target? Ready for trunk? gcc/testsuite/ChangeLog: 2019-02-22 Martin Liska PR testsuite/89441 * g++.dg/ipa/pr89009.C (push): Don't make main hidden.

[PATCH] Remove vestiges of cc1-dummy

2019-02-22 Thread Richard Biener
After 2010-10-07 Andi Kleen * Makefile.in (MOSTLYCLEANFILES): Remove cc1*dummy, add checksum-options. (checksum-options): Add. (cc1-dummy): Remove. (cc1-checksum): Change to run checksum over object files and options only. * dummy-check

Re: [PR middle-end/85598] make -Wprintf* pass use loop info for PHI's

2019-02-22 Thread Aldy Hernandez
On 1/31/19 9:56 AM, Richard Biener wrote: On Thu, Jan 31, 2019 at 3:45 PM Jakub Jelinek wrote: On Thu, Jan 31, 2019 at 09:30:13AM -0500, Aldy Hernandez wrote: (LOOPS_HAVE_PREHEADERS). This avoids unnecessary changes to the CFG. But really, I'm just guessing here. LOOPS_NORMAL would also wor

[libgo, testsuite] Skip runtime.TestG0StackOverflow on Solaris

2019-02-22 Thread Rainer Orth
One of the relatively few remaining libgo failures on Solaris is --- FAIL: TestG0StackOverflow (2.17s) crash_test.go:754: === RUN TestG0StackOverflow (exit status signal: Segmentation Fault) FAIL FAIL: runtime Given that Solaris is a pthread target just like a bunch of others, it s

Re: [PATCH] Fix PR89437

2019-02-22 Thread Richard Biener
On Thu, Feb 21, 2019 at 6:09 PM Wilco Dijkstra wrote: > > Hi Richard, > > >>Fix an issue with sinl (atanl (sqrtl (LDBL_MAX)) returning 0.0 > >>instead of 1.0 by using x < sqrtl (LDBL_MAX) in match.pd. > > > > Wasn't that a intermediate problem with the mpfr exponent range limiting? > > Please chec

[PATCH] [NDS32] Fix nds32_split_ashiftdi3 with large shift amount

2019-02-22 Thread Kito Cheng
From: Kito Cheng ChangeLog: gcc/ * config/nds32/nds32-md-auxiliary.c (nds32_split_ashiftdi3): Fix wrong code gen with large shift amount. --- gcc/config/nds32/nds32-md-auxiliary.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/gcc/confi

[PATCH][2/2] Fix PR87609

2019-02-22 Thread Richard Biener
This is the original patch adjusted to not remap clique == 1. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2019-02-22 Richard Biener PR middle-end/87609 * cfghooks.h (dependence_hash): New typedef. (struct copy_bb_data): New type.

[PATCH][1/2] Fix PR87609

2019-02-22 Thread Richard Biener
This is a followup on the earlier RFC I sent in October. It implements a less restrictive variant by partitioning the clique set into problematic (have to remap on BB copy) and non-problematic ones. The single non-problematic one is where the scope of the restrict affected refs is the whole fun