[PATCH] Fix ICE in fixup_abnormal_edges (PR rtl-optimization/88018)

2018-11-14 Thread Jakub Jelinek
Hi! On the following testcase, we have a call (not marked noreturn), which can throw, followed immediately by __builtin_unreachable (), so it effectively is noreturn in this particular call site (i.e. if it returns, it is UB). In RTL this is represented by the corresponding bb having just EH edge

[PATCH, csky] Update dynamic linker'name

2018-11-14 Thread 瞿仙淼
Hi, I have submitted a patch to update dynamic linker'name Index: gcc/ChangeLog === --- gcc/ChangeLog (revision 266171) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2018-11-15 Xianmiao Qu + + * conf

Re: [wwwdocs] [committed] Add ARC news

2018-11-14 Thread Gerald Pfeifer
On Wed, 14 Nov 2018, claz...@gmail.com wrote: > I've just committed the attached patch containing the news for the ARC > backend. Nice! (Both in terms of improvements to the ARC target, and this release notes update.) GErald

Re: [PATCH] MIPS: Add `-mfix-r5900' option for the R5900 short loop erratum

2018-11-14 Thread Hans-Peter Nilsson
On Tue, 13 Nov 2018, Maciej W. Rozycki wrote: > On Sun, 11 Nov 2018, Fredrik Noring wrote: > > > ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_linux.cc:71:1: > > note: in expansion of macro ?COMPILER_CHECK? > >71 | COMPILER_CHECK(struct_kernel_stat_sz == sizeof(struct st

[doc, committed] __attribute__((aligned)) linker restrictions

2018-11-14 Thread Sandra Loosemore
I've checked in this patch for PR 56334, following the recommendation in comment 1 in that issue to * distinguish between stack-allocated and statically-allocated variables * mention object file format restrictions and not just blame it on the linker. -Sandra 2018-11-15 Sandra Loosemore

Re: [PATCH][RFC] Introduce BIT_FIELD_INSERT

2018-11-14 Thread Andrew Pinski
On Fri, May 13, 2016 at 3:51 AM Richard Biener wrote: > > > The following patch adds BIT_FIELD_INSERT, an operation to > facilitate doing bitfield inserts on registers (as opposed > to currently where we'd have a BIT_FIELD_REF store). > > Originally this was developed as part of bitfield lowering

[doc, committed] fix documentation about interaction between -flto and -O

2018-11-14 Thread Sandra Loosemore
I've checked in this patch to address the complaints about a bad example in the discussion of -flto reported in PR55102 and its duplicate PR56700. The bad example implied that you can compile files at -O0 and then link them with -O3 to get full optimization, which is not correct. I replaced th

Re: [PATCH] Fix incorrect assertion when deallocating big block

2018-11-14 Thread Jonathan Wakely
On 14/11/18 20:26 +, Jonathan Wakely wrote: On 14/11/18 10:31 +0100, Christophe Lyon wrote: On Tue, 13 Nov 2018 at 23:58, Jonathan Wakely wrote: Since a big_block rounds up the size to a multiple of big_block::min it is wrong to assert that the supplied number of bytes equals the big_bloc

[PATCH] Optimize pool resource allocation

2018-11-14 Thread Jonathan Wakely
A recent change caused a performance regression. This restores the previous performance and adds a performance test. * scripts/check_performance: Allow tests to choose a -std flag. * src/c++17/memory_resource.cc (bitset::get_first_unset()): Use local variables of the right

Re: [PATCH 21/25] GCN Back-end (part 2/2).

2018-11-14 Thread Jeff Law
On 11/12/18 5:53 AM, Andrew Stubbs wrote: > On 09/11/2018 19:39, Jeff Law wrote: >>> + >>> +/* Generate epilogue.  Called from gen_epilogue during >>> pro_and_epilogue pass. >>> + >>> +   See gcn_expand_prologue for stack details.  */ >>> + >>> +void >>> +gcn_expand_epilogue (void) >> You probably

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
On Wed, 14 Nov 2018 11:30:39 -0500 Paul Koning wrote: > > On Nov 14, 2018, at 10:44 AM, Jozef Lawrynowicz > > wrote: > > > > Patch 1 tweaks dg directives in tests specifically for msp430. Many of > > these are extensions to existing target selectors in dg directives. > > > > <0001-TESTSUITE-MS

Re: [PATCH][RFC] Come up with -flive-patching master option.

2018-11-14 Thread Miroslav Benes
On Tue, 13 Nov 2018, Qing Zhao wrote: > Hi, > > > On Nov 13, 2018, at 1:18 PM, Miroslav Benes wrote: > > > >> Attached is the patch for new -flive-patching=[inline-only-static | > >> inline-clone] master option. > >> > >> '-flive-patching=LEVEL' > >> Control GCC's optimizations to provide

Re: [PATCH 5/6] ifcvt: Only created temporaries as needed.

2018-11-14 Thread Jeff Law
On 11/14/18 6:07 AM, Robin Dapp wrote: > noce_convert_multiple_sets creates temporaries for the destination of > every emitted cmov and expects subsequent passes to get rid of them. This > does not happen every time and even if the temporaries are removed, code > generation can be affected adverse

Re: [PATCH 2/6] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2018-11-14 Thread Jeff Law
On 11/14/18 6:07 AM, Robin Dapp wrote: > This patch checks whether the current target supports conditional moves > with immediate then/else operands and allows noce_convert_multiple_sets > to deal with constants subsequently. > Also, minor refactoring is performed. > > -- > > gcc/ChangeLog: > >

+reminder+ Don’t build gdb/readline/libreadline.a, when --with-system-readline is supplied

2018-11-14 Thread Дилян Палаузов
Forwarded Message From: Дилян Палаузов To: gcc-patches@gcc.gnu.org Subject: Don’t build gdb/readline/libreadline.a, when --with-system- readline is supplied Date: Sat, 27 Oct 2018 19:53:44 + Building GDB always builds the bundled libreadline.a, even if use of the libreadline

Re: [PATCH] RFC: elide repeated source locations (PR other/84889)

2018-11-14 Thread David Malcolm
On Mon, 2018-11-12 at 13:37 -0700, Martin Sebor wrote: > On 11/11/2018 07:43 PM, David Malcolm wrote: > > We often emit more than one diagnostic at the same source location. > > For example, the C++ frontend can emit many diagnostics at > > the same source location when suggesting overload candidat

Re: [PATCH] Fix bootstrap with GCC 4.1.2 (PR bootstrap/86739)

2018-11-14 Thread Marc Glisse
On Wed, 14 Nov 2018, Richard Biener wrote: On Wed, 14 Nov 2018, Jakub Jelinek wrote: Hi! As mentioned in the PR, with GCC before 4.3 one can't instantiate std::pair where one or both of the template parameters are reference types, because the std::pair constructor has arguments references to

Re: C++ PATCH for c++/87781, detect invalid elaborated-type-specifier

2018-11-14 Thread Marek Polacek
On Wed, Nov 14, 2018 at 10:03:50AM -0500, Jason Merrill wrote: > On Wed, Nov 14, 2018 at 9:55 AM Marek Polacek wrote: > > > > In elaborated-type-specifier, the typename keyword can only follow a > > nested-name-specifier: > > > > class-key nested-name-specifier template[opt] simple-template-id >

Re: [PATCH] Fix incorrect assertion when deallocating big block

2018-11-14 Thread Jonathan Wakely
On 14/11/18 10:31 +0100, Christophe Lyon wrote: On Tue, 13 Nov 2018 at 23:58, Jonathan Wakely wrote: Since a big_block rounds up the size to a multiple of big_block::min it is wrong to assert that the supplied number of bytes equals the big_block's size(). Add big_block::alloc_size(size_t) to

Re: [PATCH 1/6] ifcvt: Store the number of created cmovs.

2018-11-14 Thread Jeff Law
On 11/14/18 6:07 AM, Robin Dapp wrote: > This patch saves the number of created conditional moves by > noce_convert_multiple_sets in the IF_INFO struct. This may be used by > the backend to easier decide whether to accept a generated sequence or > not. > > -- > > gcc/ChangeLog: > > 2018-11-14

[doc, committed] improve documentation for -Og

2018-11-14 Thread Sandra Loosemore
This patch is for PR 59658, "Document -f* flags enabled by -Og". As noted in the issue comments, this is tricky because -Og uses a separate pass list than the other -O levels, and like -O0 it completely ignores -f* options for many optimization passes. And, like -O0, there's really nothing in

[C++ Patch PING] Re: [C++ Patch] Improve compute_array_index_type locations

2018-11-14 Thread Paolo Carlini
Hi, gently pinging this older patch of mine: given the previous create_array_type_for_decl change, its gist should not be very controversial... On 06/11/18 10:01, Paolo Carlini wrote: Hi, when I improved create_array_type_for_decl I didn't notice that it calls compute_array_index_type as h

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
On 14/11/2018 18:50, Paul Koning wrote: On Nov 14, 2018, at 1:00 PM, Jozef Lawrynowicz wrote: On 14/11/2018 16:54, Andreas Schwab wrote: On Nov 14 2018, Jozef Lawrynowicz wrote: diff --git a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c b/gcc/testsuite/c-c++-common/tortu

Re: [PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o

2018-11-14 Thread David Malcolm
On Wed, 2018-11-14 at 09:49 +, Kyrill Tkachov wrote: > On 13/11/18 18:45, David Malcolm wrote: > > On Tue, 2018-11-13 at 17:58 +, Kyrill Tkachov wrote: > > > Hi David, > > > > > > On 09/11/18 21:00, Jeff Law wrote: > > > > On 11/9/18 10:51 AM, David Malcolm wrote: > > > > > One of the conc

Re: Bug 52869 - [DR 1207] "this" not being allowed in noexcept clauses

2018-11-14 Thread Marek Polacek
On Wed, Nov 14, 2018 at 09:55:39PM +0530, Umesh Kalappa wrote: > My bad Marek and thank you for pointing that out. > > Please find the attached correct one (pr52869.patch) . Index: gcc/cp/ChangeLog === --- gcc/cp/ChangeLog(revisi

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Paul Koning
> On Nov 14, 2018, at 1:00 PM, Jozef Lawrynowicz > wrote: > > On 14/11/2018 16:54, Andreas Schwab wrote: >> On Nov 14 2018, Jozef Lawrynowicz wrote: >> >>> diff --git a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c >>> b/gcc/testsuite/c-c++-common/torture/builtin-arith-ove

Re: [PATCH], Remove power9 fusion support

2018-11-14 Thread Segher Boessenkool
On Wed, Nov 07, 2018 at 01:36:50PM -0500, Michael Meissner wrote: > On Mon, Nov 05, 2018 at 04:09:23PM -0600, Segher Boessenkool wrote: > > Hi Mike, > > > > On Fri, Nov 02, 2018 at 02:37:34PM -0400, Michael Meissner wrote: > > > This patch removes all of the so-called power9 fusion support for the

Re: [debug/88006] -fdebug-types-section gives undefined ref

2018-11-14 Thread Jeff Law
On 11/14/18 8:08 AM, Nathan Sidwell wrote: > On 11/14/18 7:33 AM, Richard Biener wrote: > >> Hmm, there is reference_to_unused () used in a related case.  But generally >> >> for late emission such references are "OK" and expected to be pruned >> later by resolve_addr () (which I see we do not cal

Re: Allow target to override gnu-user.h crti and crtn

2018-11-14 Thread Jeff Law
On 11/12/18 4:31 AM, Alan Modra wrote: > Also give target access to the gnu-user.h LINK_GCC_C_SEQUENCE_SPEC. > In preparation for using gnu-user.h in rs6000/. > > Bootstrapped etc. powerpc64le-linux. OK? > > * config/gnu-user.h (GNU_USER_TARGET_CRTI): Define. > (GNU_USER_TARGET_START

Re: Delete !HAVE_LD_PIE variants of startfile/endfile specs

2018-11-14 Thread Jeff Law
On 11/12/18 4:29 AM, Alan Modra wrote: > This patch is a small cleanup. > > The HAVE_LD_PIE variant doesn't contain anything that will break > linking when !HAVE_LD_PIE that isn't already broken if you choose to > build PIEs with a linker that doesn't support PIE. All this > HAVE_LD_PIE protects

Re: [PATCH] pretty-print.c: add selftest::test_prefixes_and_wrapping

2018-11-14 Thread Jeff Law
On 11/11/18 6:39 PM, David Malcolm wrote: > gcc/ChangeLog: > * pretty-print.c (class selftest::test_pretty_printer): New > subclass of pretty_printer. > (selftest::test_prefixes_and_wrapping): New test. > (selftest::pretty_print_c_tests): Call it. > --- OK jeff

Re: RFA: Fix add_predicate_code to acknowledge ZERO_EXTRACT as an lvalue.

2018-11-14 Thread Jeff Law
On 11/11/18 1:52 AM, Joern Wolfgang Rennecke wrote: > With a configurable vector size, it is not really feasible to represent > every vector register > inside GCC as a collection of lots of imaginary BITS_PER_WORD registers. > So you got your general purpose registers that are BITS_PER_WORD, and >

Re: [PATCH] diagnose built-in declarations without prototype (PR 83656)

2018-11-14 Thread Jeff Law
On 11/6/18 4:56 PM, Martin Sebor wrote: > In response to Joseph's comment I've removed the interaction > with -Wpedantic from the updated patch. > > In addition, to help detect bugs like the one in the test case > for pr87886, I have also enhanced the detection of incompatible > calls to include i

Re: [PATCH] diagnose unsupported uses of hardware register variables (PR 88000)

2018-11-14 Thread Alexander Monakov
On Wed, 14 Nov 2018, Segher Boessenkool wrote: > Yeah, using local register vars to access global registers only works > by accident. It does work currently though, and people apparently use > it, so we shouldn't break it :-/ In the proposed approach (copying from/to pseudos just before/after the

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
On 14/11/2018 16:54, Andreas Schwab wrote: On Nov 14 2018, Jozef Lawrynowicz wrote: diff --git a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c b/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c index 6b1c427..71d24ce 100644 --- a/gcc/testsuite/c-c++-common/tortu

Re: [PATCH] diagnose unsupported uses of hardware register variables (PR 88000)

2018-11-14 Thread Segher Boessenkool
On Wed, Nov 14, 2018 at 06:50:38PM +0300, Alexander Monakov wrote: > On Wed, 14 Nov 2018, Segher Boessenkool wrote: > > > I think with "=g" rather than "+g" this example is ok. > > > > No, it needs the register var as an input. That is the whole *point*. > > Hm. I think I see what you meant, but

Re: Don't use %z printf format length specified

2018-11-14 Thread Michael Matz
Hi, On Wed, 14 Nov 2018, Alexander Monakov wrote: > On Wed, 14 Nov 2018, Michael Matz wrote: > > > Hi, > > > > it's not c++98 conforming and I get 1 million warnings when compiling. > > Initially I had also casts to long at the various arguments, but I get no > > warning with this variant ei

Re: Don't use %z printf format length specified

2018-11-14 Thread Andreas Schwab
On Nov 14 2018, Michael Matz wrote: > Initially I had also casts to long at the various arguments, but I get no > warning with this variant either, so I removed them again. That is probably pure luck. size_t is not required to be the same as unsigned long. Andreas. -- Andreas Schwab, SUSE L

Re: Don't use %z printf format length specified

2018-11-14 Thread Alexander Monakov
On Wed, 14 Nov 2018, Michael Matz wrote: > Hi, > > it's not c++98 conforming and I get 1 million warnings when compiling. > Initially I had also casts to long at the various arguments, but I get no > warning with this variant either, so I removed them again. I'm currently > regstrapping this

Don't use %z printf format length specified

2018-11-14 Thread Michael Matz
Hi, it's not c++98 conforming and I get 1 million warnings when compiling. Initially I had also casts to long at the various arguments, but I get no warning with this variant either, so I removed them again. I'm currently regstrapping this, okay for trunk if successfull? Ciao, Michael.

Re: Handle libphobos in contrib/gcc_update

2018-11-14 Thread Jeff Law
On 11/14/18 9:29 AM, Rainer Orth wrote: > I noticed that libphobos isn't currently handled in gcc_update. The > following patch fixes this. > > I guess this is close to obvious? Seems so to me :-) jeff

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Andreas Schwab
On Nov 14 2018, Jozef Lawrynowicz wrote: > diff --git a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c > b/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c > index 6b1c427..71d24ce 100644 > --- a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c > +++ b

[PATCH][rs6000] inline expansion of memcmp using vsx

2018-11-14 Thread Aaron Sawdey
This patch generalizes some the functions added earlier to do vsx expansion of strncmp so that the can also generate the code needed for memcmp. I reorganized expand_block_compare() a little to be able to make use of this there. The vsx code is more compact so I've changed the default block compa

[committed] Fix rl78 newlib build failure due to bogus operand_subword_force argument

2018-11-14 Thread Jeff Law
ignedp, next_methods); if (x == 0) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 50e53f0b196..cee33796cc5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-11-14 Jeff Law + + * gcc.c-torture/compile/20181114.c: New t

Re: [PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Paul Koning
> On Nov 14, 2018, at 10:44 AM, Jozef Lawrynowicz > wrote: > > Patch 1 tweaks dg directives in tests specifically for msp430. Many of > these are extensions to existing target selectors in dg directives. > > <0001-TESTSUITE-MSP430-Tweak-dg-directives-for-msp430-elf.patch> For pr41779.c, you

Re: record_ranges_from_incoming_edge: use value_range API for creating new range

2018-11-14 Thread Aldy Hernandez
On 11/13/18 1:47 PM, Richard Biener wrote: On November 13, 2018 5:40:59 PM GMT+01:00, Aldy Hernandez wrote: With your cleanups, the main raison d'etre for my patch goes away, but here is the promised removal of ignore_equivs_equal_p. I think the == operator is a bit confusing, and equality in

Handle libphobos in contrib/gcc_update

2018-11-14 Thread Rainer Orth
I noticed that libphobos isn't currently handled in gcc_update. The following patch fixes this. I guess this is close to obvious? Rainer -- - Rainer Orth, Center for Biotechnology, Bielefeld University 2018-1

Re: Bug 52869 - [DR 1207] "this" not being allowed in noexcept clauses

2018-11-14 Thread Umesh Kalappa
My bad Marek and thank you for pointing that out. Please find the attached correct one (pr52869.patch) . ~Umesh pr52869.patch Description: Binary data

Re: Fix PR86575

2018-11-14 Thread Michael Matz
Hi, On Wed, 14 Nov 2018, Marek Polacek wrote: > > static gimple * > > collect_fallthrough_labels (gimple_stmt_iterator *gsi_p, > > - auto_vec *labels) > > + auto_vec *labels, > > + location_t *prevloc) > > { > >gimple *pre

[PATCH 7/7][MSP430][TESTSUITE] Fix tests for msp430-elf large memory model

2018-11-14 Thread Jozef Lawrynowicz
Patch 7 fixes tests for msp430-elf in the large memory model. >From 494465f13df814bf3daad5e330d2c7139f2db625 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Sat, 10 Nov 2018 16:08:44 + Subject: [PATCH 7/7] [TESTSUITE] Fix tests for msp430-elf large memory model 2018-11-14 Jozef Lawr

Re: Fix PR86575

2018-11-14 Thread Marek Polacek
On Wed, Nov 14, 2018 at 02:51:45PM +, Michael Matz wrote: > Hi, > > our warning code sometimes adds locations to statement which didn't have > them before, which can in turn lead to code changes (here only label > numbers change). It seems better to not do that from warning code, and > her

[PATCH 6/7][MSP430][TESTSUITE] Fix tests requiring float printf support when GCC was configured with --enable-newlib-nano-formatted-io

2018-11-14 Thread Jozef Lawrynowicz
Patch 6 fixes tests expecting printf float support for targets which have been configured with "newlib-nano-formatted-io". When newlib is configured in this way, float printf is enabled at build time by registering _printf_float as an undefined symbol. >From 15a04e0139ec40196ddb79f1125635029dccae

[PATCH 5/7][MSP430][TESTSUITE] Prune messages about ISO C not supporting __int20 from output of tests

2018-11-14 Thread Jozef Lawrynowicz
Patch 5 deals with ISO C errors emitted by tests when the large memory model is used. size_t and ptrdiff_t are __int20 with -mlarge, and if the test is compiled with -pedantic-errors and -std=* or -ansi, then use of these types causes an error of the form: ISO C does not support __int20 types I

[PATCH 4/7][MSP430][TESTSUITE] Fix tests when int is 16-bit by default

2018-11-14 Thread Jozef Lawrynowicz
Patch 4 fixes tests when int is 16-bits by default. >From 62b273f73cd7a4db22b1161f450ae7267d185890 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 8 Nov 2018 23:09:38 + Subject: [PATCH 4/7] [TESTSUITE] Fix tests when int is 16-bit by default 2018-11-14 Jozef Lawrynowicz gcc

Re: [PATCH] diagnose unsupported uses of hardware register variables (PR 88000)

2018-11-14 Thread Alexander Monakov
On Wed, 14 Nov 2018, Segher Boessenkool wrote: > > I think with "=g" rather than "+g" this example is ok. > > No, it needs the register var as an input. That is the whole *point*. Hm. I think I see what you meant, but "+g" is not correct either: the asm, by intent, depends *on the current value

[PATCH 3/7][MSP430][TESTSUITE] Dynamically check if size_t is large enough for tests containing large structs/arrays

2018-11-14 Thread Jozef Lawrynowicz
Patch 3 sets up require-effective-target directives for tests which require the compilation of large arrays. Targets which have 16-bit or 20-bit size_t fail to compile tests with large arrays designed to test 32-bit or 64-bit behaviour. Rather than enumerating another target to skip, I've replaced

RE: [PATCH 1/9][GCC][AArch64][middle-end] Implement SLP recognizer for Complex addition with rotate and complex MLA with rotation

2018-11-14 Thread Tamar Christina
Hi Richard, Thanks for the feedback, I've replied inline below. I'll wait for your answers before making changes. > -Original Message- > From: Richard Biener > Sent: Wednesday, November 14, 2018 12:21 > To: Tamar Christina > Cc: GCC Patches ; nd ; Richard > Guenther ; Zdenek Dvorak ; Ri

RE: [PATCH 8/9][GCC][Arm] Add autovectorization support for complex multiplication and addition

2018-11-14 Thread Tamar Christina
Hi Richard, > > Ok for trunk? > > +;; The complex mla operations always need to expand to two instructions. > +;; The first operation does half the computation and the second does > +the ;; remainder. Because of this, expand early. > +(define_expand "fcmla4" > + [(set (match_operand:VF 0 "regis

[PATCH 2/7][MSP430][TESTSUITE] Add path to libssp to the linker search path when checking for -fstack-protector support

2018-11-14 Thread Jozef Lawrynowicz
Patch 2 fixes issues finding libssp when linking tests or checking for fstack_protector support. >From 6c6f34bae386a5f396e6f9630514fc7080c2f940 Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Sun, 11 Nov 2018 14:30:32 + Subject: [PATCH 2/7] [TESTSUITE] Add path to libssp to the linker

[PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
Patch 1 tweaks dg directives in tests specifically for msp430. Many of these are extensions to existing target selectors in dg directives. From a730d945647923c5c10e8487ca3c2a24511abf3d Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Thu, 8 Nov 2018 18:55:57 + Subject: [PATCH 1/7] [TES

Re: RFA: vectorizer patches 1/2 : WIDEN_MULT_PLUS support

2018-11-14 Thread Joern Wolfgang Rennecke
On 14/11/18 09:53, Richard Biener wrote: WIDEN_MULT_PLUS is special on our target in that it creates double-sized vectors. Are there really double-size vectors or does the target simply produce the output in two vectors? Usually targets have WIDEN_MULT_PLUS_LOW/HIGH or _EVEN/ODD split operati

[PATCH 0/7][MSP430][TESTSUITE] Fix GCC tests for msp430-elf

2018-11-14 Thread Jozef Lawrynowicz
The following series of patches fixes a number of test failures when running the GCC DejaGNU testsuite for msp430-elf. The raw output from contrib/compare_tests is a bit misleading for some tests, as lines have been added to the source code, changing line numbers for dg-warning/dg-error tests. I

Re: [C++ Patch] Fix two grokdeclarator locations

2018-11-14 Thread Jason Merrill
OK. On Wed, Nov 14, 2018 at 4:26 AM Paolo Carlini wrote: > > Hi, > > On 14/11/18 01:30, Jason Merrill wrote: > > On 11/12/18 6:39 AM, Paolo Carlini wrote: > >> Hi again, > >> > >> On 08/11/18 10:26, Paolo Carlini wrote: > >>> Hi, > >>> > >>> two additional grokdeclarator locations that we can easi

Re: [C++ PATCH] P1236R1 - Signed integers are two's complement

2018-11-14 Thread Jason Merrill
OK, thanks. On Wed, Nov 14, 2018 at 7:12 AM Jakub Jelinek wrote: > > Hi! > > This paper from what I can see mostly just codifies our > implementation-defined behavior as standard (two's complement as the only > possible representation of signed integers, but still keeping UB signed > integer overf

Re: [debug/88006] -fdebug-types-section gives undefined ref

2018-11-14 Thread Nathan Sidwell
On 11/14/18 7:33 AM, Richard Biener wrote: Hmm, there is reference_to_unused () used in a related case. But generally for late emission such references are "OK" and expected to be pruned later by resolve_addr () (which I see we do not call for type units?!). Quote: /* Resolve DW_OP_addr and D

Re: Fix PR86575

2018-11-14 Thread Richard Biener
On Wed, Nov 14, 2018 at 3:51 PM Michael Matz wrote: > > Hi, > > our warning code sometimes adds locations to statement which didn't have > them before, which can in turn lead to code changes (here only label > numbers change). It seems better to not do that from warning code, and > here it's easy

Re: C++ PATCH for c++/87781, detect invalid elaborated-type-specifier

2018-11-14 Thread Jason Merrill
On Wed, Nov 14, 2018 at 9:55 AM Marek Polacek wrote: > > In elaborated-type-specifier, the typename keyword can only follow a > nested-name-specifier: > > class-key nested-name-specifier template[opt] simple-template-id > > but we weren't detecting it. > > Bootstrapped/regtested on x86_64-linux,

Re: [PATCH][RFC] Come up with -flive-patching master option.

2018-11-14 Thread Martin Liška
On 11/13/18 10:16 PM, Qing Zhao wrote: > Hi, > >> On Nov 13, 2018, at 1:18 PM, Miroslav Benes wrote: >> >>> Attached is the patch for new -flive-patching=[inline-only-static | >>> inline-clone] master option. >>> >>> '-flive-patching=LEVEL' >>> Control GCC's optimizations to provide a safe c

Re: [PATCH][cunroll] Add unroll-known-loop-iterations-only param and use it in aarch64

2018-11-14 Thread Richard Biener
On Tue, Nov 13, 2018 at 3:33 PM Richard Biener wrote: > > On Tue, Nov 13, 2018 at 10:48 AM Kyrill Tkachov > wrote: > > > > > > On 13/11/18 09:28, Richard Biener wrote: > > > On Tue, Nov 13, 2018 at 10:15 AM Kyrill Tkachov > > > wrote: > > >> Hi Richard, > > >> > > >> On 13/11/18 08:24, Richard B

Re: [RFC][PATCH]Merge VEC_COND_EXPR into MASK_STORE after loop vectorization

2018-11-14 Thread Richard Biener
On Fri, Nov 9, 2018 at 4:49 PM Renlin Li wrote: > > Hi Richard, > > On 11/09/2018 11:48 AM, Richard Biener wrote: > > On Thu, Nov 8, 2018 at 5:55 PM Renlin Li wrote: > >> > >> Hi Richard, > >> > >> > >> *However*, after I rebased my patch on the latest trunk. > >> Got the following dump from ifcv

C++ PATCH for c++/87781, detect invalid elaborated-type-specifier

2018-11-14 Thread Marek Polacek
In elaborated-type-specifier, the typename keyword can only follow a nested-name-specifier: class-key nested-name-specifier template[opt] simple-template-id but we weren't detecting it. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2018-11-14 Marek Polacek PR c++/87781 - d

Re: [Committed][AArch64] Fix PR62178 testcase failures

2018-11-14 Thread Segher Boessenkool
On Wed, Nov 14, 2018 at 12:37:05PM +, Wilco Dijkstra wrote: > +/* { dg-final { scan-assembler-not { dup } } } */ > +/* { dg-final { scan-assembler-not { fmov } } } */ { dup } is the same as " dup " , that is, with spaces and all. I don't think you want that (there usually is a tab charact

Fix PR86575

2018-11-14 Thread Michael Matz
Hi, our warning code sometimes adds locations to statement which didn't have them before, which can in turn lead to code changes (here only label numbers change). It seems better to not do that from warning code, and here it's easy to do: just return the location we want to use for warnings,

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-14 Thread Tom de Vries
On 14-11-18 14:25, Jakub Jelinek wrote: > On Wed, Nov 14, 2018 at 02:08:05PM +0100, Tom de Vries wrote: >>> +btest_dwz_CFLAGS = $(AM_CFLAGS) -g -O0 >> >> Hmm, I already discovered that specifying the -O0 doesn't work, since >> it's overridden by $(CFLAGS). >> >> With a hack like this: >> ... >> dif

Re: Bug 52869 - [DR 1207] "this" not being allowed in noexcept clauses

2018-11-14 Thread Marek Polacek
On Wed, Nov 14, 2018 at 05:18:40PM +0530, Umesh Kalappa wrote: > Thank you Jason and Marek for the suggestions . > > Attached patch(pr86512.patch) along the Changelog . It seems you've attached the wrong patch. Marek

Re: [PATCH] Fix PR87985

2018-11-14 Thread Richard Biener
On Mon, 12 Nov 2018, Richard Biener wrote: > > The following fixes split_constant_offset unbound un-CSEing of > expressions when following SSA def stmts. Simply limiting it to > single-uses isn't good for consumers so the following instead > limits analysis by implementing a cache. Note this ma

[PATCH] Add missing dir to create_testsuite_files script

2018-11-14 Thread Jonathan Wakely
* scripts/create_testsuite_files: Add special_functions to the list of directories to search. Add comment referring to conformance.exp. * testsuite/libstdc++-dg/conformance.exp: Add comment referring to create_testsuite_files. Committed to trunk. commit de90993957

Re: [PATCH] Fix bootstrap with GCC 4.1.2 (PR bootstrap/86739)

2018-11-14 Thread Jonathan Wakely
On 14/11/18 09:25 +0100, Richard Biener wrote: On Wed, 14 Nov 2018, Jakub Jelinek wrote: Hi! As mentioned in the PR, with GCC before 4.3 one can't instantiate std::pair where one or both of the template parameters are reference types, because the std::pair constructor has arguments references

Re: [PATCH] Support simd function declarations via a pre-include.

2018-11-14 Thread Jakub Jelinek
On Wed, Nov 14, 2018 at 03:09:49PM +0100, Martin Liška wrote: > > So omp-simd-notinbranch or omp_simd_notinbranch? > > Any particular reason for this weird syntax and for not also > > supporting inbranch or just simd? > > Questionable whether to support as current glibc vector ABI only uses > not

Re: [PATCH] Support simd function declarations via a pre-include.

2018-11-14 Thread Martin Liška
On 11/14/18 12:35 PM, Jakub Jelinek wrote: > On Wed, Nov 14, 2018 at 11:06:04AM +0100, Martin Liška wrote: >> Question I have is about default search locations for the header file. On my >> machine I can >> see: >> access("/home/marxin/bin/gcc2/lib64/gcc/x86_64-pc-linux-gnu/9.0.0/math-vector-fortr

Re: [PATCH] diagnose unsupported uses of hardware register variables (PR 88000)

2018-11-14 Thread Segher Boessenkool
On Wed, Nov 14, 2018 at 03:33:43PM +0300, Alexander Monakov wrote: > On Wed, 14 Nov 2018, Jakub Jelinek wrote: > > > On Wed, Nov 14, 2018 at 06:22:51AM -0600, Segher Boessenkool wrote: > > > Btw, if you just add > > > > > > void * > > > retsp (void) > > > { > > > register void *sp __asm ("sp");

Re: [PATCH] diagnose unsupported uses of hardware register variables (PR 88000)

2018-11-14 Thread Segher Boessenkool
On Wed, Nov 14, 2018 at 01:27:26PM +0100, Jakub Jelinek wrote: > On Wed, Nov 14, 2018 at 06:22:51AM -0600, Segher Boessenkool wrote: > > Btw, if you just add > > > > void * > > retsp (void) > > { > > register void *sp __asm ("sp"); > > asm ("" : "+g" (sp)); // <-- this line > > return sp; >

Re: [PATCH v3] Add sinh(atanh(x)) and cosh(atanh(x)) optimizations

2018-11-14 Thread Wilco Dijkstra
Hi, > Indeed. After plotting the graph of both functions, it is very clear > that this check isn't required. Sorry about that. It wouldn't be clear from the graph, you need to check that +0.0, -0.0, out of range values, infinities, NaNs give the same answer before/after your transformation. If s

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-14 Thread Jakub Jelinek
On Wed, Nov 14, 2018 at 02:08:05PM +0100, Tom de Vries wrote: > > +btest_dwz_CFLAGS = $(AM_CFLAGS) -g -O0 > > Hmm, I already discovered that specifying the -O0 doesn't work, since > it's overridden by $(CFLAGS). > > With a hack like this: > ... > diff --git a/libbacktrace/Makefile.am b/libbacktra

Re: Bug 52869 - [DR 1207] "this" not being allowed in noexcept clauses

2018-11-14 Thread Umesh Kalappa
>>We are runing the make check-gcc(x86_64) and will let know for any >>regressions . No regress found . ~Umesh On Wed, Nov 14, 2018 at 5:18 PM Umesh Kalappa wrote: > > Thank you Jason and Marek for the suggestions . > > Attached patch(pr86512.patch) along the Changelog . > > and also please not

Re: [PR81878]: fix --disable-bootstrap --enable-languages=ada, and cross-back gnattools build

2018-11-14 Thread Arnaud Charlet
> Huh, indeed - it's a host_module without bootstrap ... and libada is > a target_module not bootstrapped either. So we're indeed in a curious > situation where we have a bootstrap of Ada requiring a host Ada but > nothing of Ada is actually bootstrapped ... ;) Not sure what you mean by that, al

Re: [PATCH] Add C++ runtime support for new 128-bit long double format

2018-11-14 Thread Michael Meissner
On Mon, Nov 12, 2018 at 11:09:45AM +, Jonathan Wakely wrote: > This adds support for the new 128-bit long double format on powerpc64, > see https://fedoraproject.org/wiki/Changes/PPC64LE_Float128_Transition > for more details. > > Most of the required changes are to the locale facets that pars

[PATCH 1/6] ifcvt: Store the number of created cmovs.

2018-11-14 Thread Robin Dapp
This patch saves the number of created conditional moves by noce_convert_multiple_sets in the IF_INFO struct. This may be used by the backend to easier decide whether to accept a generated sequence or not. -- gcc/ChangeLog: 2018-11-14 Robin Dapp * ifcvt.c (noce_convert_multiple_sets

[PATCH 4/6] S/390: Implement noce_conversion_profitable_p.

2018-11-14 Thread Robin Dapp
This patch implements noce_conversion_profitable_p by checking for the transformation ifcvt used and only return positively if noce_convert_multiple_sets created less than MAX_IFCVT_INSNS insns. -- gcc/ChangeLog: 2018-11-14 Robin Dapp * config/s390/s390.c (MAX_IFCVT_INSNS): Define.

[PATCH 6/6] S/390: Add test for noce_convert_multiple_sets.

2018-11-14 Thread Robin Dapp
New test. -- gcc/testsuite/ChangeLog: 2018-11-14 Robin Dapp * gcc.target/s390/ifcvt-two-insns-int.c: New test. --- .../gcc.target/s390/ifcvt-two-insns-int.c | 26 +++ 1 file changed, 26 insertions(+) create mode 100644 gcc/testsuite/gcc.target/s390/ifcvt-two-ins

[PATCH 3/6] ifcvt: Use enum instead of transform_name string.

2018-11-14 Thread Robin Dapp
This patch introduces an enum for ifcvt's various noce transformations. As the transformation might be queried by the backend, I find it nicer to allow checking for a proper type instead of a string comparison. -- gcc/ChangeLog: 2018-11-14 Robin Dapp * ifcvt.c (noce_try_move): Use ne

[PATCH 5/6] ifcvt: Only created temporaries as needed.

2018-11-14 Thread Robin Dapp
noce_convert_multiple_sets creates temporaries for the destination of every emitted cmov and expects subsequent passes to get rid of them. This does not happen every time and even if the temporaries are removed, code generation can be affected adversely. In this patch, temporaries are only create

Re: [PATCH][libbacktrace] Handle DW_FORM_GNU_strp_alt

2018-11-14 Thread Tom de Vries
On 13-11-18 14:42, Tom de Vries wrote: > diff --git a/libbacktrace/Makefile.am b/libbacktrace/Makefile.am > index 3c1bd49dd7b..2fec9bbb4b6 100644 > --- a/libbacktrace/Makefile.am > +++ b/libbacktrace/Makefile.am > @@ -96,6 +96,28 @@ btest_LDADD = libbacktrace.la > > check_PROGRAMS += btest > >

[PATCH 2/6] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2018-11-14 Thread Robin Dapp
This patch checks whether the current target supports conditional moves with immediate then/else operands and allows noce_convert_multiple_sets to deal with constants subsequently. Also, minor refactoring is performed. -- gcc/ChangeLog: 2018-11-14 Robin Dapp * ifcvt.c (have_const_cmo

[PATCH 0/6] If conversion with multiple sets.

2018-11-14 Thread Robin Dapp
Hi, the follow patch set was created in an attempt to allow multiple sets to be if converted. I was not able to make it work out of the box since I found the cost estimation for the newly created sequence to always be much higher than the sequence before. This is due to noce_convert_multiple_set

[PATCH] Fix PR88021

2018-11-14 Thread Richard Biener
This reportedly fixes PR88021 - I forgot to change some ints to lambda_ints when widening the representation of lambda_vectors. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-11-14 Richard Biener PR middle-end/88021 * tree-data-ref.c (lambda_mat

Re: [PATCH] S/390: Fix expectation in mrecord-mcount test for 31-bit mode

2018-11-14 Thread Andreas Krebbel
On 14.11.18 13:55, Ilya Leoshkevich wrote: > The emitted address is .long, not .quad, in that case. > > gcc/testsuite/ChangeLog: > > 2018-11-14 Ilya Leoshkevich > > * gcc.target/s390/mrecord-mcount.c (profileme): Expect .long in > 31-bit mode. Ok. Thanks! Andreas

Re: [PATCH] S/390: Disable 3 global-array-* tests for 31-bit mode

2018-11-14 Thread Andreas Krebbel
On 14.11.18 13:50, Ilya Leoshkevich wrote: > These tests rely on larl->movdi merge, which is not implemented for > 31-bit mode. > > gcc/testsuite/ChangeLog: > > 2018-11-14 Ilya Leoshkevich > > * gcc.target/s390/global-array-almost-huge-element.c: Run only > in 64-bit mode. >

Re: [PATCH v3] Add sinh(atanh(x)) and cosh(atanh(x)) optimizations

2018-11-14 Thread Giuliano Augusto Faulin Belinassi
On Wed, Nov 14, 2018 at 7:41 AM Richard Biener wrote: > > On Tue, Nov 13, 2018 at 10:25 PM Giuliano Augusto Faulin Belinassi > wrote: > > > > Only do the optimization if flag_signed_zeros && > > !flag_finite_math_only is set, as suggested in the previous iteration. > > > > Before, the patch did t

[PATCH] S/390: Fix expectation in mrecord-mcount test for 31-bit mode

2018-11-14 Thread Ilya Leoshkevich
The emitted address is .long, not .quad, in that case. gcc/testsuite/ChangeLog: 2018-11-14 Ilya Leoshkevich * gcc.target/s390/mrecord-mcount.c (profileme): Expect .long in 31-bit mode. --- gcc/testsuite/gcc.target/s390/mrecord-mcount.c | 3 ++- 1 file changed, 2 insertions(+)

  1   2   >