On 11/13/18 1:47 PM, Richard Biener wrote:
On November 13, 2018 5:40:59 PM GMT+01:00, Aldy Hernandez <al...@redhat.com> 
wrote:
With your cleanups, the main raison d'etre for my patch goes away, but
here is the promised removal of ignore_equivs_equal_p.

I think the == operator is a bit confusing, and equality intent should
be clearly specified.  I am providing the following for the derived
class (with no hidden default arguments):

        bool equal_p (const value_range &, bool ignore_equivs) const;

and providing the following for the base class:

        bool equal_p (const value_range_base &) const;

I am also removing access to both the == and the != operators.  It
should now be clear from the code whether the equivalence bitmap is
being taken into account or not.

What do you think?

Sounds good.

Committed to trunk.

Thanks.
Aldy

Reply via email to