Re: [PATCH 1/4] regcprop: Avoid REG_CFA_REGISTER notes (PR85645)

2018-08-10 Thread Jeff Law
On 08/10/2018 02:55 PM, Segher Boessenkool wrote: > On Mon, Jun 25, 2018 at 03:34:26PM -0600, Jeff Law wrote: >> On 06/25/2018 05:53 AM, Segher Boessenkool wrote: >>> Hi Eric, >>> >>> On Wed, May 09, 2018 at 09:22:47AM +0200, Eric Botcazou wrote: > 2018-05-08 Segher Boessenkool > >

Re: [PATCH 1/4] regcprop: Avoid REG_CFA_REGISTER notes (PR85645)

2018-08-10 Thread Segher Boessenkool
On Mon, Jun 25, 2018 at 03:34:26PM -0600, Jeff Law wrote: > On 06/25/2018 05:53 AM, Segher Boessenkool wrote: > > Hi Eric, > > > > On Wed, May 09, 2018 at 09:22:47AM +0200, Eric Botcazou wrote: > >>> 2018-05-08 Segher Boessenkool > >>> > >>> PR rtl-optimization/85645 > >>> * regcprop.c (co

[PATCH] Unconditionally use MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics

2018-08-10 Thread Janne Blomqvist
For floating point types, the question is what MAX(a, NaN) or MIN(a, NaN) should return (where "a" is a normal number). There are valid usecases for returning either one, but the Fortran standard doesn't specify which one should be chosen. Also, there is no consensus among other tested compilers.

Re: [PATCH] rs6000: Fix vector homogeneous aggregates (PR86197)

2018-08-10 Thread Segher Boessenkool
On Mon, Jun 25, 2018 at 06:32:27AM -0500, Segher Boessenkool wrote: > On Tue, Jun 19, 2018 at 10:45:59AM +, Segher Boessenkool wrote: > > The existing code allows only 4 vectors worth of ieee128 homogeneous > > aggregates, but it should be 8. This happens because at one spot it > > is mistaken

[PATCH] PR libstdc++/68210 adjust operator new and delete for LWG 206

2018-08-10 Thread Jonathan Wakely
Ensure that nothrow versions of new and delete call the ordinary versions of new or delete, instead of calling malloc or free directly. These files are all compiled with -std=gnu++14 so can use noexcept and nullptr to make the code more readable. PR libstdc++/68210 * doc/xml/manu

Re: [PATCH,nvptx] Use CUDA driver API to select default runtime launch, geometry

2018-08-10 Thread Cesar Philippidis
On 08/08/2018 08:19 AM, Tom de Vries wrote: > On Wed, Aug 08, 2018 at 07:09:16AM -0700, Cesar Philippidis wrote: >> On 08/07/2018 06:52 AM, Cesar Philippidis wrote: Thanks for review. This version should address all of the following remarks. However, one thing to note ... >> [nvptx] Use CUDA driv

Re: [PATCH] Make strlen range computations more conservative

2018-08-10 Thread Martin Sebor
On 08/08/2018 11:36 PM, Jeff Law wrote: On 08/02/2018 09:42 AM, Martin Sebor wrote: The warning bits are definitely not okay by me. The purpose of the warnings (-W{format,sprintf}-{overflow,truncation} is to detect buffer overflows. When a warning doesn't have access to string length informat

Re: [PATCH], Improve PowerPC switch behavior on medium code model system

2018-08-10 Thread Segher Boessenkool
On Tue, Jul 31, 2018 at 10:39:21AM -0400, Michael Meissner wrote: > This patch adds an insn to load a LABEL_REF into a GPR. This is needed so the > FWPROP1 pass can convert the load the of the label address from the TOC to a > direct load to a GPR. I don't see why you need a separate RTL insn for

Re: [arm-8-branch] Add Linaro version string and macros

2018-08-10 Thread Yvan Roux
On Fri, 10 Aug 2018 at 17:01, Ramana Radhakrishnan wrote: > > On Fri, Aug 10, 2018 at 3:35 PM, Yvan Roux wrote: > > On Fri, 10 Aug 2018 at 14:31, Yvan Roux wrote: > >> > >> On Fri, 10 Aug 2018 at 13:45, Ramana Radhakrishnan > >> wrote: > >> > > >> > On Fri, Aug 10, 2018 at 11:09 AM, Yvan Roux

Re: [PATCH v2 3/4] vxworks: enable use of .init_array/.fini_array for cdtors

2018-08-10 Thread Olivier Hainque
Hello Rasmus, > On 28 Jun 2018, at 10:43, Rasmus Villemoes wrote: > > Assume that if the user passed --enable-initfini-array when building > gcc, the rest of the toolchain (including the link spec and linker > script) is set up appropriately. > > Note that configuring with --enable-initfini-arr

Re: [RFC][PATCH][mid-end] Optimize immediate choice in comparisons.

2018-08-10 Thread Vlad Lazar
On 09/08/18 06:48, Jeff Law wrote: On 08/07/2018 02:11 PM, Richard Sandiford wrote: Hi Vlad, Thanks for the patch. Vlad Lazar writes: Hi. This patch optimises the choice of immediates in integer comparisons. Integer comparisons allow for different choices (e.g. a > b is equivalent to a >= b

Re: [PATCH][AARCH64] inline strlen for 8-bytes aligned strings

2018-08-10 Thread Anton Youdkevitch
Wilco, On 10.08.2018 18:04, Wilco Dijkstra wrote: Hi, A quick benchmark shows it's faster up to about 10 bytes, but after that it becomes extremely slow. At 16 bytes it's already 2.5 times slower and for larger sizes its over 13 times slower than the GLIBC implementation... The implementati

Re: [PATCH][AARCH64] inline strlen for 8-bytes aligned strings

2018-08-10 Thread Wilco Dijkstra
Hi, A quick benchmark shows it's faster up to about 10 bytes, but after that it becomes extremely slow. At 16 bytes it's already 2.5 times slower and for larger sizes its over 13 times slower than the GLIBC implementation... > The implementation falls back to the library call if the > string is

Re: [arm-8-branch] Add Linaro version string and macros

2018-08-10 Thread Ramana Radhakrishnan
On Fri, Aug 10, 2018 at 3:35 PM, Yvan Roux wrote: > On Fri, 10 Aug 2018 at 14:31, Yvan Roux wrote: >> >> On Fri, 10 Aug 2018 at 13:45, Ramana Radhakrishnan >> wrote: >> > >> > On Fri, Aug 10, 2018 at 11:09 AM, Yvan Roux wrote: >> > > Hi, >> > > >> > > This patch adds Linaro version string and r

Re: [arm-8-branch] Add Linaro version string and macros

2018-08-10 Thread Yvan Roux
On Fri, 10 Aug 2018 at 14:31, Yvan Roux wrote: > > On Fri, 10 Aug 2018 at 13:45, Ramana Radhakrishnan > wrote: > > > > On Fri, Aug 10, 2018 at 11:09 AM, Yvan Roux wrote: > > > Hi, > > > > > > This patch adds Linaro version string and release macros to ARM GCC 8 > > > vendor branch. > > > > > > O

Fix even more merging PIC and PIE options

2018-08-10 Thread Jan Hubicka
Hi, this patch should fix merging of PIC and PIE options so we always resort to the least common denominator of the object files compiled (i.e. linking together -fpic and -fPIE will result in -fpie binary). Note that we also use information about format of output passed by linker plugin so we will

Re: [PATCH][AARCH64] inline strlen for 8-bytes aligned strings

2018-08-10 Thread Anton Youdkevitch
Richard, On 10.08.2018 16:54, Richard Earnshaw (lists) wrote: On 10/08/18 14:38, Anton Youdkevitch wrote: The patch inlines strlen for 8-byte aligned strings on AARCH64 like it's done on other platforms (power, s390). The implementation falls back to the library call if the string is not aligne

Re: [RFC][PATCH v2] PR preprocessor/83173: Additional check before decrementing highest_location

2018-08-10 Thread Mike Gulick
On 05/29/2018 11:25 AM, Mike Gulick wrote: > On 03/04/2018 02:27 PM, Mike Gulick wrote: >> >> >> On 02/09/2018 05:54 PM, Mike Gulick wrote: >>> Hi David, >>> >>> Here is a new version of the linemap patch (see my earlier emails for an >>> updated >>> version of the test code). >> >> >> >> Hi Davi

Re: [RFC,PATCH] Introduce -msdata=explicit for powerpc

2018-08-10 Thread Segher Boessenkool
Hi Alexandre, On Thu, Aug 09, 2018 at 03:23:12AM -0300, Alexandre Oliva wrote: > On Aug 8, 2018, Segher Boessenkool wrote: > > > Then you get sdata2 used (via srodata in generic code), and it is accessed > > via GPR2 (via the sda21 reloc and linker magic). It is hard to trace down > > :-) >

Re: [PATCH][AARCH64] inline strlen for 8-bytes aligned strings

2018-08-10 Thread Richard Earnshaw (lists)
On 10/08/18 14:38, Anton Youdkevitch wrote: > The patch inlines strlen for 8-byte aligned strings on > AARCH64 like it's done on other platforms (power, s390). > The implementation falls back to the library call if the > string is not aligned. Synthetic testing on Cavium T88 > and Cavium T99 showed

[PATCH][AARCH64] inline strlen for 8-bytes aligned strings

2018-08-10 Thread Anton Youdkevitch
The patch inlines strlen for 8-byte aligned strings on AARCH64 like it's done on other platforms (power, s390). The implementation falls back to the library call if the string is not aligned. Synthetic testing on Cavium T88 and Cavium T99 showed the following performance gains: T99: up to 8 bytes:

Re: [arm-8-branch] Add Linaro version string and macros

2018-08-10 Thread Yvan Roux
On Fri, 10 Aug 2018 at 13:45, Ramana Radhakrishnan wrote: > > On Fri, Aug 10, 2018 at 11:09 AM, Yvan Roux wrote: > > Hi, > > > > This patch adds Linaro version string and release macros to ARM GCC 8 > > vendor branch. > > > > Ok to commit? > > > > > Ok if no regressions. (I'm assuming you've buil

Re: [arm-8-branch] Add Linaro version string and macros

2018-08-10 Thread Ramana Radhakrishnan
On Fri, Aug 10, 2018 at 11:09 AM, Yvan Roux wrote: > Hi, > > This patch adds Linaro version string and release macros to ARM GCC 8 > vendor branch. > > Ok to commit? > Ok if no regressions. (I'm assuming you've built and eyeballed that the pre-processor macros are being produced). (I have a patc

[RFC PATCH, i386]: Deprecate -mmitigate-rop

2018-08-10 Thread Uros Bizjak
This option is fairly ineffective, and in the light of CET, nobody seems interested to improve it. Deprecate the option, so it won't lure developers to the land of false security. 2018-08-10 Uros Bizjak * config/i386/i386.opt (mmitigate-rop): Mark as deprecated. * doc/invoke.texi (mmit

Re: [PATCH][OBVIOUS] Remove extra line in MAINTAINERS.

2018-08-10 Thread Martin Liška
On 08/10/2018 01:12 PM, Paolo Carlini wrote: > Hi, > > On 10/08/2018 12:44, Martin Liška wrote: >> On 08/10/2018 12:38 PM, Paolo Carlini wrote: >>> Hi, >>> >>> On 10/08/2018 12:35, Martin Liška wrote: Hi. This removes one extra line that's a typo. >>> It's not ;) The complete line i

Re: Improve safe iterator move semantic

2018-08-10 Thread Ville Voutilainen
On 10 August 2018 at 13:47, Jonathan Wakely wrote: > Doing a test like this with TSan should be the absolute minimum > required for any change to the mutex locking policy. Agreed. Concurrency code is something that our test suite is not well-equipped to test (because it doesn't support TSan and s

Re: [PATCH][OBVIOUS] Remove extra line in MAINTAINERS.

2018-08-10 Thread Paolo Carlini
Hi, On 10/08/2018 12:44, Martin Liška wrote: On 08/10/2018 12:38 PM, Paolo Carlini wrote: Hi, On 10/08/2018 12:35, Martin Liška wrote: Hi. This removes one extra line that's a typo. It's not ;) The complete line is "c++ runtime libs special modes". See? Admittedly, we may want to have some

Re: [PATCH] Remove not needed __builtin_expect due to malloc predictor.

2018-08-10 Thread Jonathan Wakely
On 10/08/18 12:32 +0200, Martin Liška wrote: Hi. After we introduced new non-NULL malloc predictor, we can remove these __builtin_expects. Predictors will change in following way: Before: Predictions for bb 5 first match heuristics: 10.00% combined heuristics: 10.00% __builtin_expect heuri

Re: Improve safe iterator move semantic

2018-08-10 Thread Jonathan Wakely
On 10/08/18 11:00 +0100, Jonathan Wakely wrote: This valid program shows data races with -fsanitize=thread after your patch is applied: #define _GLIBCXX_DEBUG #include #include void thrash(std::vector::iterator& iter) { for (int i = 0; i < 1000; ++i) { auto jiter = std::move(iter); iter =

Re: [PATCH][OBVIOUS] Remove extra line in MAINTAINERS.

2018-08-10 Thread Martin Liška
On 08/10/2018 12:38 PM, Paolo Carlini wrote: > Hi, > > On 10/08/2018 12:35, Martin Liška wrote: >> Hi. >> >> This removes one extra line that's a typo. > It's not ;) The complete line is "c++ runtime libs special modes". See? > Admittedly, we may want to have something clearer, but just removing

Re: [PATCH][OBVIOUS] Remove extra line in MAINTAINERS.

2018-08-10 Thread Paolo Carlini
Hi, On 10/08/2018 12:35, Martin Liška wrote: Hi. This removes one extra line that's a typo. It's not ;) The complete line is "c++ runtime libs special modes". See? Admittedly, we may want to have something clearer, but just removing that line isn't the way to go. Paolo.

[PATCH][OBVIOUS] Remove extra line in MAINTAINERS.

2018-08-10 Thread Martin Liška
Hi. This removes one extra line that's a typo. Martin ChangeLog: 2018-08-10 Martin Liska * MAINTAINERS: Remove extra line. --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f96ab622146..8d42c91b2d7 100644 --- a/MAINTAINERS +++ b/MAI

[PATCH] Remove not needed __builtin_expect due to malloc predictor.

2018-08-10 Thread Martin Liška
Hi. After we introduced new non-NULL malloc predictor, we can remove these __builtin_expects. Predictors will change in following way: Before: Predictions for bb 5 first match heuristics: 10.00% combined heuristics: 10.00% __builtin_expect heuristics of edge 5->6: 10.00% call heuristics

[arm-8-branch] Add Linaro version string and macros

2018-08-10 Thread Yvan Roux
Hi, This patch adds Linaro version string and release macros to ARM GCC 8 vendor branch. Ok to commit? Thanks Yvan gcc/ChangeLog 2018-08-10 Yvan Roux * LINARO-VERSION: New file. * configure.ac: Add Linaro version string. * configure: Regenerate. * Makefile.in (LINAROVER, LIN

Re: Improve safe iterator move semantic

2018-08-10 Thread Jonathan Wakely
On 09/08/18 20:41 +0200, François Dumont wrote:     Here is a patch to improve Debug mode safe iterator move semantic.     To summarize where we used to have N mutex locks we now have N - 1. For instance move constructor used to lock mutex twice, now it only does it once. Note that move constr

Re: [C++ Patch] Tweak check_previous_goto_1 to emit hard errors instead of permerrors in some cases

2018-08-10 Thread Paolo Carlini
.. an additional clarification (I told you that over the years we changed this code quite a bit...): I originally added the testcase that I'm adjusting here, I did that when, back in 2014, I worked on 63558: the test uses -fpermissive -w and was meant to check, as requested by Manuel in the bug