Re: [www-patch] Document new -Wshadow= variants in gcc-7/changes.html

A few markup fixes on top of the committed patch that I just applied. Essentially must not be within and was missing in one case. Thanks again for providing this nice documentation! Gerald Index: changes.html === RCS file: /cv

Re: [PATCH] Fix PR78230

Hi Jeff: Thanks your review and approve, however I don't have commit right yet, can you help me to commit it :) thanks On Wed, Nov 23, 2016 at 1:04 AM, Jeff Law wrote: > > On 11/08/2016 07:43 PM, Kito Cheng wrote: >> >> gcc/testsuite/ChangeLog: >> >> 2016-11-09 Kito Cheng >> >> PR tar

[PATCH] remove invalid "tail +16c"

Hi all, In "config/acx.m4", there are still some "tail +16c" which are invalid on POSIX systems. In my opinion， all "tail +16c" should be changed to "tail -c +16" directly, as most systems has accept the latter. And, to skip first 16 bytes, we should use "tail -c +17" instead of "tail -c

Re: [PING] [PATCH] Fix PR31096

On Wed, 23 Nov 2016, Hurugalawadi, Naveen wrote: Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01049.html Hi, the gcc part looks good to me (I didn't look at the tests

Re: GCC patch committed: Fix -fdump-go-spec to not align last field to type alignment

On Tue, Nov 22, 2016 at 7:01 PM, Martin Sebor wrote: > On 11/22/2016 04:25 PM, Ian Lance Taylor wrote: >> >> The code that handles -fdump-go-spec was incorrectly trying to pad the >> last field of a struct/union to the alignment of the overall >> struct/union. That is unnecessary and incorrect, a

[PING] [PATCH] Fix PR71727

Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00697.html Thanks, Naveen

[PATCH] [AArch64] Fix PR71112

Hi, Please find attached the patch that fixes PR71112. The current implementation that handles SYMBOL_SMALL_GOT_28K in aarch64_load_symref_appropriately access the high part of RTX for Big-Endian mode which results in ICE for ILP32. The attached patch modifies it by accessing the lower part for

[PING] [PATCH] Fix PR31096

Hi, Please consider this as a personal reminder to review the patch at following link and let me know your comments on the same. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01049.html Thanks, Naveen

[PATCH] [AArch64] Fix PR77635

Hi, Please find attached the patch that fixes PR77635. Some load pair testcase fails when gcc is configured "--with-cpu=thunderx" as -mcpu=generic is missed out in them. The attached patch modifies the testcases to use -mcpu=generic. Please review the patch and let me know if its okay? 2016-11-

[PATCH] [AArch64] Fix PR77634

Hi, Please find attached the patch that fixes PR77634. Some testcase does not use -fno-vect-cost-model and hence fails when gcc is configured "--with-cpu=thunderx". The attached patch modifies the testcases to use -fno-vect-cost-model. Please review the patch and let me know if its okay? 2016

[PATCH 7/9] Add patterns and predicates foutline-msabi-xlouges

Adds the predicates save_multiple and restore_multiple to predicates.md, which are used by following patterns in sse.md: * save_multiple - insn that calls a save stub * save_multiple_hfp - insn that calls a save stub when a hard frame pointer is used. * restore_multiple - call_insn that calls a

[PATCH 9/9] Add remainder of moutline-msabi-xlogues implementation

Adds functions emit_msabi_outlined_save and emit_msabi_outlined_restore, which are called from ix86_expand_prologue and ix86_expand_epilogue, respectively. Also adds the code to ix86_expand_call that enables the optimization (setting the machine_function's outline_ms_sysv field). --- gcc/config/i

[PATCH 8/9] Add msabi pro/epilogue stubs to libgcc

Adds libgcc/config/i386/i386-asm.h to manage common cpp and gas macros. stubs use the following naming convention: (sav|res)ms64[f][x] save|resSave or restore ms64Avoid possible name collisions with future stubs (specific to 64-bit msabi --> sysv scenario)

[PATCH 6/9] Modify ix86_compute_frame_layout for foutline-msabi-xlogues

ix86_compute_frame_layout will now populate fields added to structs machine_function and ix86_frame and modify the frame layout specific to facilitate the use of save & restore stubs. --- gcc/config/i386/i386.c | 138 ++--- 1 file changed, 131 insertions

[PATCH 5/9] Modify ix86_save_reg to optionally omit stub-managed registers

Adds static HARD_REG_SET stub_managed_regs to track registers that will be managed by the pro/epilogue stubs for the function. Adds a third parameter bool ignore_outlined to ix86_save_reg to specify rather or not the count should include registers marked in stub_managed_regs. --- gcc/config/i386/

[PATCH 3/9] Add option -moutline-msabi-xlogues

Adds the option to i386.opt and i386.c and adds documentation to invoke.texi. --- gcc/config/i386/i386.c | 1 + gcc/config/i386/i386.opt | 5 + gcc/doc/invoke.texi | 11 ++- 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386

[PATCH 1/9] Change type of x86_64_ms_sysv_extra_clobbered_registers

This will need to be unsigned for a subsequent patch. Also adds the constant NUM_X86_64_MS_CLOBBERED_REGS for brievity. --- gcc/config/i386/i386.c | 8 +++- gcc/config/i386/i386.h | 4 +++- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/

[PATCH 2/9] Minor refactor in ix86_compute_frame_layout

This refactor is separated from a future patch that actually alters ix86_compute_frame_layout. --- gcc/config/i386/i386.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 56cc67d..5ed8fb6 100644 --- a/gcc/config

[PATCH 4/9] Adds class xlouge_layout and new fields to struct machine_function

Of the new fields added to struct machine_function, outline_ms_sysv is initially set in ix86_expand_call, but may later be cleared when ix86_compute_frame_layout is called (both of these are in subsequent patch). If it is not cleared, then the remaining new fields will be set. The new class xloug

[PATCH v2 0/9] Add optimization -moutline-msabi-xlougues (for Wine 64)

Due to ABI differences, when a 64-bit Microsoft function calls and System V function, it must consider RSI, RDI and XMM6-15 as clobbered. Saving these registers can cost as much as 109 bytes and a similar amount for restoring. This patch set targets 64-bit Wine and aims to mitigate some of the

[PATCH, committed] TILEPro/TILE-Gx: add trap patterns

This patch adds a trap pattern to TILEPro/Tile-Gx. The pattern emits an instruction bundle that causes a SIGABRT. Bootstrapped and tested on TILEPro/TILE-Gx hardware, also backported to GCC 6. * config/tilegx/tilegx.md (trap): New pattern. * config/tilepro/tilepro.md (trap): Likewise. diff --gi

[PATCH, committed] TILE-Gx: fix zero_extract/sign_extract patterns

This patch fixes the zero_extract/sign_extract patterns so that they properly handle the case when pos + size > number of bits in a word. Bootstrapped and tested on TILE-Gx hardware, also backported to GCC 6. * config/tilegx/tilegx.md (*zero_extract): Use define_insn_and_split ins

[PATCH] eliminate calls to snprintf(0, 0, ...) with known return value (pr78476)

Calls to bounded functions like snprintf with a zero-size buffer are special requests to compute the size of output without actually writing any. For example: int n = snprintf(0, 0, "%08x", rand ()); is a request to compute the number of bytes that the function would format if it were passed

Re: GCC patch committed: Fix -fdump-go-spec to not align last field to type alignment

On 11/22/2016 04:25 PM, Ian Lance Taylor wrote: The code that handles -fdump-go-spec was incorrectly trying to pad the last field of a struct/union to the alignment of the overall struct/union. That is unnecessary and incorrect, as the alignment is handled by go_force_record_alignment anyhow. I

Re: [PATCH v3] cpp/c: Add -Wexpansion-to-defined

On Tue, 22 Nov 2016, Paolo Bonzini wrote: > > It's not obvious to me whether this belongs in -Wextra. After all, this > > is a perfectly reasonable and useful GNU C feature, or at least some cases > > of it are (like "#define FOO (BAR || defined something)"). Is the > > argument that there are t

Re: [PATCH] Fix up handle_pragma_target (PR target/78451)

On Tue, 22 Nov 2016, Jakub Jelinek wrote: > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > 2016-11-22 Jakub Jelinek > > PR target/78451 > * c-pragma.c (handle_pragma_target): Don't replace > current_target_pragma, but chainon the new args to the cur

Re: [PATCH PR68030/PR69710][RFC]Introduce a simple local CSE interface and use it in vectorizer

On 11/22/2016 08:07 AM, Bin.Cheng wrote: > On Mon, Nov 21, 2016 at 9:34 PM, Doug Gilmore wrote: >> I haven't seen any followups to this discussion of Bin's patch to >> PR68303 and PR69710, the patch submission: >> http://gcc.gnu.org/ml/gcc-patches/2016-05/msg02000.html >> >> Discussion: >> http://

GCC patch committed: Fix -fdump-go-spec to not align last field to type alignment

The code that handles -fdump-go-spec was incorrectly trying to pad the last field of a struct/union to the alignment of the overall struct/union. That is unnecessary and incorrect, as the alignment is handled by go_force_record_alignment anyhow. It caused a compiler crash on x32 and various other

Re: [PING][PATCH][2/2] Early LTO debug -- main part

On 11/11/2016 03:06 AM, Richard Biener wrote: +/* ??? In some cases the C++ FE (at least) fails to + set DECL_CONTEXT properly. Simply globalize stuff + in this case. For example + __dso_handle created via iostream line 74 col 25. */ The comment for DECL_CONTEXT says t

Go patch committed: Move encoding utilities from gcc/go to gofrontend proper

This patch by Than McIntosh moves the name encoding utilities from gcc/go/go-gcc.cc to the gofrontend proper, where they are available for other backend implementations. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/Make-lang.in ==

[PATCH] 78461 - [7 Regression] ICE: in operator+=, at gimple-ssa-sprintf.c:214

With r242674 having enabled the -fprintf-return-value option by default, when warnings are disabled the gimple-ssa-sprintf pass is now exercised in ways it was not being tested. One of these untested use cases exposed a bug in the logic used to compute the minimum number of bytes output by a %.*s

Re: [PATCH] PR fortran/78479 -- allocate a charlen

On Tue, Nov 22, 2016 at 10:21:52PM +0100, Janus Weil wrote: > > > The patch and ChangeLog shuod be sufficient to explain the change. > > Regression tested on x86_64-*-freebsd. OK to commit? > > the patch itself looks good. > Thanks. > For the test case, I'd prefer a somewhat more meaningful n

Re: [PATCH 7/9] Add RTL-error-handling to host

David Malcolm writes: > +inline file_location::file_location (const char *filename_in, int lineno_in, > int colno_in) > +: filename (filename_in), lineno (lineno_in), colno (colno_in) {} > + Long line (a pre-existing problem, since you're just moving the code). I'm happy with this FWIW, but it'

Re: [PATCH 6/9] Split class rtx_reader into md_reader vs rtx_reader

Sorry, only just realised that this one hadn't been approved as part of the earlier series. David Malcolm writes: > gcc/ChangeLog: > * genpreds.c (write_tm_constrs_h): Update for renaming of > rtx_reader_ptr to md_reader_ptr. > (write_tm_preds_h): Likewise. > (write_insn_p

Re: [PATCH] PR fortran/78479 -- allocate a charlen

Hi Steve, > The patch and ChangeLog shuod be sufficient to explain the change. > Regression tested on x86_64-*-freebsd. OK to commit? the patch itself looks good. For the test case, I'd prefer a somewhat more meaningful name (e.g. char_component_initializer_3.f90 or similar) and a mention of th

libgo patch committed: Don't check standard packages in go tool with gccgo

When using the go tool with gccgo, we can't check for whether the standard packages are up to date, because we can't assume that the source code is available. And we can't read runtime/internal/sys/zversion.go, because that too is not generally available. This was fixed in the gc repository with

[PATCH] PR fortran/78479 -- allocate a charlen

The patch and ChangeLog shuod be sufficient to explain the change. Regression tested on x86_64-*-freebsd. OK to commit? 2016-11-22 Steven G. Kargl PR fortran/78479 * expr.c (gfc_apply_init): Allocate a charlen if needed. 2016-11-22 Steven G. Kargl PR fortran/7847

[C++ PATCH] Fix ICE during VEC_INIT_EXPR gimplification (PR c++/77739)

Hi! As mentioned in the PR, we ICE because part of the body is genericized twice and each time it wraps is_invisiref_parm RESULT_DECL (in this case, could be also PARM_DEC) into REFERENCE_REF_P INDIRECT_REF. The first time it is desirable, but when done again during VEC_INIT_EXPR gimplification wh

[patch] boehm-gc removal and libobjc changes to build with an external bdw-gc

Re-posting this top-level, discussions and review happened in the GCJ removal thread: - https://gcc.gnu.org/ml/gcc-patches/2016-11/msg02069.html (last patch review). - https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00387.html (first patch sent) - https://gcc.gnu.org/ml/gcc-patches/2016-10/

Re: [PATCH] Replace _mm_setzero_[hd]i with _mm_setzero_si128 (PR target/78451)

On Tue, Nov 22, 2016 at 05:36:38PM +0100, Uros Bizjak wrote: > > Note that there is still _mm512_setzero_qi and _mm512_setzero_hi, > > shall those be replaced with _mm512_setzero_si512 too? > > Even those 2 aren't mentioned in ICC headers nor AVX512 manuals. > > Yes, please also remove these two.

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

Denis Chertykov schrieb: Do you have any objections, George ? No, the last delta rev3 from 2016-11-10 looks fine to me. 2016-11-22 8:05 GMT+03:00 Pitchumani Sivanupandi : Ping! On Monday 14 November 2016 07:03 PM, Pitchumani Sivanupandi wrote: Ping! On Thursday 10 November 2016 01:53 PM,

Re: [PATCH] OpenACC routines -- c++ front end

On 11/11/2016 03:43 PM, Cesar Philippidis wrote: > Like it's c FE counterpart, this contains the following changes: > > * Updates c_parser_oacc_shape_clause to accept a location_t >argument in order to make the diagnostics more precise. > > * Adds support for the bind and nohost clauses. >

Re: formatting cleanups

On 11/22/2016 01:48 PM, Jakub Jelinek wrote: When you are already changing this, the = should be on the next line. done -- Nathan Sidwell 2016-11-22 Nathan Sidwell * array-notation-common.c (cilkplus_extract_an_trplets): Fix indentation and formatting. Index: c-family/array-notation-c

Re: [PATCH] OpenACC routines -- middle end

On 11/22/2016 11:58 AM, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 11:53:50AM -0800, Cesar Philippidis wrote: >> I've incorporated those changes in this patch. Is it ok for trunk? > > The ChangeLog mentions omp-low.[ch] changes, but the patch doesn't include > them. > Have they been dropped, o

Re: [PATCH] OpenACC routines -- fortran front end

On 11/18/2016 04:29 AM, Jakub Jelinek wrote: > On Fri, Nov 11, 2016 at 03:44:07PM -0800, Cesar Philippidis wrote: >> --- a/gcc/fortran/gfortran.h >> +++ b/gcc/fortran/gfortran.h >> @@ -314,6 +314,15 @@ enum save_state >> { SAVE_NONE = 0, SAVE_EXPLICIT, SAVE_IMPLICIT >> }; >> >> +/* Flags to kee

Re: [PATCH] OpenACC routines -- middle end

On Tue, Nov 22, 2016 at 11:53:50AM -0800, Cesar Philippidis wrote: > I've incorporated those changes in this patch. Is it ok for trunk? The ChangeLog mentions omp-low.[ch] changes, but the patch doesn't include them. Have they been dropped, or moved to another patch? > 2016-11-22 Cesar Philippid

Re: [PATCH] OpenACC routines -- c front end

On 11/18/2016 04:21 AM, Jakub Jelinek wrote: > On Fri, Nov 11, 2016 at 03:43:23PM -0800, Cesar Philippidis wrote: >> @@ -11801,12 +11807,11 @@ c_parser_oacc_shape_clause (c_parser *parser, >> omp_clause_code kind, >> } >> >>location_t expr_loc = c_parser_peek_token (parser)->loc

Re: [PATCH] OpenACC routines -- middle end

On 11/18/2016 04:14 AM, Jakub Jelinek wrote: > On Fri, Nov 11, 2016 at 03:43:02PM -0800, Cesar Philippidis wrote: >> +error_at (OMP_CLAUSE_LOCATION (c), >> + "%qs specifies a conflicting level of parallelism", >> + omp_clause_code_name[OMP_CLAUSE_CODE (c)])

[PATCH, Fortran, accaf, v1] Add caf-API-calls to asynchronously handle allocatable components in derived type coarrays.

Hi all, attached patch addresses the need of extending the API of the caf-libs to enable allocatable components asynchronous allocation. Allocatable components in derived type coarrays are different from regular coarrays or coarrayed components. The latter have to be allocated on all images or on

Re: formatting cleanups

On Tue, Nov 22, 2016 at 01:45:07PM -0500, Nathan Sidwell wrote: > - tree ii_tree = array_exprs[ii][jj]; > - (*node)[ii][jj].is_vector = true; > - (*node)[ii][jj].value = ARRAY_NOTATION_ARRAY (ii_tree); > - (*node)[ii][jj].start = ARRAY_NOTATION_START (ii_tree); > -

formatting cleanups

I noticed some wonky formatting. Fixed as obvious. nathan -- Nathan Sidwell 2016-11-22 Nathan Sidwell gcc/ * gcc-ar.c (main): Fix indentation. * gcov-io.c (gcov_write_summary): Remove extraneous {...} * ggc-page.c (move_ptes_to_front): Fix formatting. * hsa-dump.c (dump_has_cfun): Fix i

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

Do you have any objections, George ? 2016-11-22 8:05 GMT+03:00 Pitchumani Sivanupandi : > Ping! > > On Monday 14 November 2016 07:03 PM, Pitchumani Sivanupandi wrote: >> >> Ping! >> >> On Thursday 10 November 2016 01:53 PM, Pitchumani Sivanupandi wrote: >>> >>> On Wednesday 09 November 2016 08:05

Re: [patch,avr] Fix PR60300: Minor prologue improvement.

2016-11-22 15:41 GMT+03:00 Georg-Johann Lay : > This patch is a minor improvement of prologue length. It now allows frame > sizes of up to 11 to be allocated by RCALL + PUSH 0 sequences but limits the > number of RCALLs to 3. > > The PR has some discussion on size vs. speed consideration w.r. to u

[PATCH, Fortran, cosmetics] Use convenience functions and constants

Hi all, during more hacking on the allocatable components in derived type coarrays, I encountered the improvable code fragments in the patch attached. Bootstraps and regtests ok on x86_64-linux/F23. Ok for trunk? Regards, Andre PS: The patch that motivated these changes follows as soon

Go patch committed: Rewrite panic/defer code from C to Go

This patch to the Go frontend and libgo rewrites the panic/defer code from C to Go. The actual stack unwind code is still in C, but the rest of the code, notably all the memory allocation, is now in Go. The names are changed to the names used in the Go 1.7 runtime, but the code is necessarily some

Re: gomp-nvptx branch - middle-end changes

On Tue, Nov 22, 2016 at 08:25:45PM +0300, Alexander Monakov wrote: > On Fri, 11 Nov 2016, Jakub Jelinek wrote: > > Ok for trunk, once the needed corresponding config/nvptx bits are committed, > > with one nit below that needs immediate action and the rest can be resolved > > incrementally. I'd lik

Re: [PATCH] Add map clauses to libgomp test device-3.f90

On Tue, 15 Nov 2016, Alexander Monakov wrote: > On Tue, 15 Nov 2016, Alexander Monakov wrote: > > Yep, I do see new test execution failures with both Intel MIC and PTX > > offloading > > on device-1.f90, device-3.f90 and target2.f90. Here's an actually-tested > > patch > > for the first two (on

Re: gomp-nvptx branch - middle-end changes

On Fri, 11 Nov 2016, Jakub Jelinek wrote: > Ok for trunk, once the needed corresponding config/nvptx bits are committed, > with one nit below that needs immediate action and the rest can be resolved > incrementally. I'd like to check in afterwards the attached patch, at least > for now, so that no

Re: [PATCH] Delete GCJ

On 11/21/2016 04:23 PM, Matthias Klose wrote: On 21.11.2016 18:16, Rainer Orth wrote: Hi Matthias, ahh, didn't see that :-/ Now fixed, is this clearer now? The options @option{--with-target-bdw-gc-include} and @option{--with-target-bdw-gc-lib} must always specified together for

Re: [PATCH] Fix PR78230

On 11/08/2016 07:43 PM, Kito Cheng wrote: gcc/testsuite/ChangeLog: 2016-11-09 Kito Cheng PR target/78230 * gcc.dg/torture/pr66178.c (test): Use uintptr_t instead of int. (test2) Ditto. OK. jeff

Re: [PATCH] enable -Wformat-length for dynamically allocated buffers (pr 78245)

On 11/08/2016 05:09 PM, Martin Sebor wrote: The -Wformat-length checker relies on the compute_builtin_object_size function to determine the size of the buffer it checks for overflow. The function returns either a size computed by the tree-object-size pass for objects referenced by the __builtin_o

Re: [PATCH, testsuite]: Fix detection of -j make argument

On Tue, Nov 22, 2016 at 4:54 PM, Marc Glisse wrote: > On Tue, 22 Nov 2016, Uros Bizjak wrote: > >> New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a >> different way. While older makes pass only "-j", newer makes pass e.g. >> "-j4" when -j is specified on the command line. The detect

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

On 18/11/16 12:50, Segher Boessenkool wrote: On Fri, Nov 18, 2016 at 09:29:13AM +, Kyrill Tkachov wrote: So your COMPONENTS_FOR_BB returns both components in a pair whenever one of those is needed? That should work afaics. I mean I still want to have one component per register and since e

Re: [PR target/78213] Do not ICE on non-empty -fself-test

On 11/16/2016 11:45 AM, Aldy Hernandez wrote: I would prefer Jakub's suggestion of running in finish_options(). I suspect we'll want both. Selftests should really run in an environment that's as close as possible to what would normally be going on in the compiler. I assume there are other

Re: [PATCH][ARM] PR target/78439: Update movdi constraints for Cortex-A8 tuning to handle LDRD/STRD

On Tue, Nov 22, 2016 at 9:57 AM, Kyrill Tkachov wrote: > Hi all, > > This PR is an ICE while bootstrapping GCC with Cortex-A8 tuning, which we > also get from the default ARMv7-A tuning. > The ldrd/strd peepholes were recently made more aggressive and in this case > they transform: > (insn 13 33 4

Re: [PATCH] Add avx5124fmaps,avx5124vnniw to sse-22.c target pragma (PR target/78451)

On Tue, Nov 22, 2016 at 5:12 PM, Jakub Jelinek wrote: > Hi! > > As mentioned in the PR, these 2 ISAs were added to just the first of the two > Intel specific target pragmas (the first one is used in the sse-22.c test > itself, the second one when it is included from sse-22a.c). > > Bootstrapped/re

Re: [PATCH] Replace _mm_setzero_[hd]i with _mm_setzero_si128 (PR target/78451)

On Tue, Nov 22, 2016 at 5:09 PM, Jakub Jelinek wrote: > Hi! > > _mm_setzero_di is problematic, because it is outside of AVX512* guarded > area, but it actually requires SSE2 which might not be enabled. > As discussed in the PR, I don't see neither _mm_setzero_[dh]i routines > in ICC headers nor in

[PATCH] PR78465 Remove runtime tests for macros

Andrew MacLeod did some digging and foudn that this test was changed from using #if to using a runtime if and abort() because the LOCK_FREE macros resolved to runtime calls at one point. However, they later got changed to predefined macros, and so can be changed back to using #if. This should fix

Re: [PATCH, testsuite]: Fix detection of -j make argument

On 22/11/16 16:54 +0100, Marc Glisse wrote: On Tue, 22 Nov 2016, Uros Bizjak wrote: New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a different way. While older makes pass only "-j", newer makes pass e.g. "-j4" when -j is specified on the command line. The detection of "-j" make a

[PATCH] Add avx5124fmaps,avx5124vnniw to sse-22.c target pragma (PR target/78451)

Hi! As mentioned in the PR, these 2 ISAs were added to just the first of the two Intel specific target pragmas (the first one is used in the sse-22.c test itself, the second one when it is included from sse-22a.c). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-11-22

Re: PR78153

On 22 November 2016 at 20:53, Richard Biener wrote: > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > >> On 22 November 2016 at 20:18, Richard Biener wrote: >> > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: >> > >> >> On 21 November 2016 at 15:10, Richard Biener wrote: >> >> > On Sun, 20 No

[PATCH] Replace _mm_setzero_[hd]i with _mm_setzero_si128 (PR target/78451)

Hi! _mm_setzero_di is problematic, because it is outside of AVX512* guarded area, but it actually requires SSE2 which might not be enabled. As discussed in the PR, I don't see neither _mm_setzero_[dh]i routines in ICC headers nor in AVX/AVX512 manuals, and fail to see what the difference is betwee

Re: [Patch, Fortran, OOP] PR 78443: Incorrect behavior with non_overridable keyword

2016-11-22 16:16 GMT+01:00 Steve Kargl : >> here is a patch for a wrong-code problem with non_overridable >> type-bound procedures. For details see the PR. Regtests cleanly. Ok >> for trunk? > > OK. Thanks, Steve. Committed as r242703. >> Since the patch is very simple and it fixes wrong code wh

Re: [PATCH PR68030/PR69710][RFC]Introduce a simple local CSE interface and use it in vectorizer

On Mon, Nov 21, 2016 at 9:34 PM, Doug Gilmore wrote: > I haven't seen any followups to this discussion of Bin's patch to > PR68303 and PR69710, the patch submission: > http://gcc.gnu.org/ml/gcc-patches/2016-05/msg02000.html > > Discussion: > http://gcc.gnu.org/ml/gcc-patches/2016-07/msg00761.html

Re: [PATCH, testsuite]: Fix detection of -j make argument

On Tue, 22 Nov 2016, Uros Bizjak wrote: New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a different way. While older makes pass only "-j", newer makes pass e.g. "-j4" when -j is specified on the command line. The detection of "-j" make argument doesn't work in the later case. Atta

[PATCH] Fix up handle_pragma_target (PR target/78451)

Hi! #pragma GCC targets when used more than once without being undone through #pragma GCC pop_options in between seems to act wierdly and is the reason why sse-22a.c testcase now fails on x86_64/i686-linux. The problem is that to some extent #pragma GCC target ("f1", "f2,f3") #pragma GCC target ("

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

On Tue, 2016-11-22 at 15:45 +0100, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 03:38:04PM +0100, Bernd Schmidt wrote: > > On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > > > Can't it be done only if xloc.file contains any fancy characters? > > > > Sure, but why? Strings generally get emitted wit

[testsuite,committed] Fix prototype of memset in a test case.

One test case used unsigned long for the 3rd parameter of memset, which should be size_t. This made the test crash for targets where correct parameter passing depends on correct prototypes. Fixed and committed as obvious. Johann gcc/testsuite/ * gcc.c-torture/execute/pr30778.c (mems

[PATCH] Fix PR78472

The following fixes a C/C++ interoperability issue with LTO when zero-sized fields appear in one variant of a struct but not in another. Bootstrap & regtest in progress on x86_64-unknown-linux-gnu. Richard. 2016-11-22 Richard Biener PR lto/78472 * tree.c (gimple_canonical_ty

Re: PR78153

On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > On 22 November 2016 at 20:18, Richard Biener wrote: > > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > > > >> On 21 November 2016 at 15:10, Richard Biener wrote: > >> > On Sun, 20 Nov 2016, Prathamesh Kulkarni wrote: > >> > > >> >> Hi, > >> >>

Re: PR78153

On 22 November 2016 at 20:18, Richard Biener wrote: > On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > >> On 21 November 2016 at 15:10, Richard Biener wrote: >> > On Sun, 20 Nov 2016, Prathamesh Kulkarni wrote: >> > >> >> Hi, >> >> As suggested by Martin in PR78153 strlen's return value cannot e

Re: [Patch, Fortran, OOP] PR 78443: Incorrect behavior with non_overridable keyword

On Tue, Nov 22, 2016 at 01:14:46PM +0100, Janus Weil wrote: > > here is a patch for a wrong-code problem with non_overridable > type-bound procedures. For details see the PR. Regtests cleanly. Ok > for trunk? OK. > Since the patch is very simple and it fixes wrong code which can > silently give

[testsuite,committed]: Restrict 2 test cases to big targets.

This adds requirements for 2 test cases: loop-split.c needs 32-bit int at least. Use int32plus as I didn't intend to change the very test case. gcc.dg/stack-layout-dynamic-1.c aligns the stack to 16 bits so ptr32plus seems reasonable. Committed to trunk. Johann gcc/testsuite/

Re: [PATCH, testsuite]: Fix detection of -j make argument

On 11/22/2016 05:25 AM, Uros Bizjak wrote: Hello! New makes (e.g. GNU Make 4.2.1) pass -j argument in MFLAGS is a different way. While older makes pass only "-j", newer makes pass e.g. "-j4" when -j is specified on the command line. The detection of "-j" make argument doesn't work in the later c

Re: [v3 PATCH] LWG 2766, LWG 2749

On 22/11/16 16:59 +0200, Ville Voutilainen wrote: On 22 November 2016 at 15:36, Jonathan Wakely wrote: +#if __cplusplus > 201402L || !defined(__STRICT_ANSI__) // c++1z or gnu++11 + template +inline +typename enable_if<__not_<__and_<__is_swappable<_T1>, +

Re: [PATCH, ARM] Enable ldrd/strd peephole rules unconditionally

Hi, does this follow-up patch look reasonable? See: https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01945.html Is it OK for trunk? Thanks Bernd. On 11/21/16 21:46, Christophe Lyon wrote: > On 18 November 2016 at 16:50, Bernd Edlinger > wrote: >> On 11/18/16 12:58, Christophe Lyon wrote: >>> O

Re: [v3 PATCH] LWG 2766, LWG 2749

On 22 November 2016 at 15:36, Jonathan Wakely wrote: >> +#if __cplusplus > 201402L || !defined(__STRICT_ANSI__) // c++1z or >> gnu++11 >> + template >> +inline >> +typename enable_if<__not_<__and_<__is_swappable<_T1>, >> +__is_swappable<_T2>>>::value>::

Re: PR78153

On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > On 21 November 2016 at 15:10, Richard Biener wrote: > > On Sun, 20 Nov 2016, Prathamesh Kulkarni wrote: > > > >> Hi, > >> As suggested by Martin in PR78153 strlen's return value cannot exceed > >> PTRDIFF_MAX. > >> So I set it's range to [0, PTRDI

Re: Fix PR78154

On Tue, 22 Nov 2016, Prathamesh Kulkarni wrote: > On 21 November 2016 at 15:34, Richard Biener wrote: > > On Fri, 18 Nov 2016, Prathamesh Kulkarni wrote: > > > >> On 17 November 2016 at 15:24, Richard Biener wrote: > >> > On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: > >> > > >> >> On 17 Novem

[arm-embedded] [PATCH, GCC/ARM 1/2] Add multilib support for embedded bare-metal targets

Hi, We have decided to backport this patch to add support for multilib for embedded bare-metal targets to our embedded-6-branch. *** gcc/ChangeLog.arm *** 2016-11-22 Thomas Preud'homme Backport from mainline 2016-11-22 Thomas Preud'homme * config.gcc: Allow new

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

On Tue, Nov 22, 2016 at 03:38:04PM +0100, Bernd Schmidt wrote: > On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > >Can't it be done only if xloc.file contains any fancy characters? > > Sure, but why? Strings generally get emitted with quotes around them, I > don't see a good reason for filenames to

Re: [PATCH, ARM] Enable ldrd/strd peephole rules unconditionally

On 22/11/16 14:42, Bernd Edlinger wrote: Hi, does this follow-up patch look reasonable? See: https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01945.html Is it OK for trunk? Ah yes, this one slipped my attention. This is ok. Thanks, Kyrill Thanks Bernd. On 11/21/16 21:46, Christophe Lyon wr

Re: [arm-embedded][PATCH, GCC/ARM, 2/3] Error out for incompatible ARM multilibs

Hi, We decided to also apply this patch to the ARM embedded 6 branch. Best regards, Thomas On 17/12/15 09:32, Thomas Preud'homme wrote: Hi, We decided to apply the following patch to the ARM embedded 5 branch. Best regards, Thomas -Original Message- From: gcc-patches-ow...@gcc.gn

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

On Tue, Nov 22, 2016 at 09:25:03AM -0500, David Malcolm wrote: > On Tue, 2016-11-22 at 14:37 +0100, Jakub Jelinek wrote: > > On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > > > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > > > > > > > @@ -284,7 +292,7 @@ print_rtx_operand_code_i

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

On 11/22/2016 02:37 PM, Jakub Jelinek wrote: Can't it be done only if xloc.file contains any fancy characters? Sure, but why? Strings generally get emitted with quotes around them, I don't see a good reason for filenames to be different, especially if it makes the output easier to parse. I

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

On Tue, 2016-11-22 at 14:37 +0100, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > > > > > @@ -284,7 +292,7 @@ print_rtx_operand_code_i (const_rtx in_rtx, > > > > int idx) > > > > if (INSN_HAS_LOCATION

Re: [PATCH 1/4] Remove build dependence on HSA run-time

On Tue, Nov 22, 2016 at 02:27:44PM +0100, Martin Jambor wrote: > I have basically copied what libgfortran did, with additional checking > for HAVE_UNISTD_H when attempting to implement secure_getenv in its > absence (which is maybe unnecessary but should not do any harm) and I > also needed to add

[testsuite,committed]: Fix a test that assumed int is 32 bits.

Committed as obvious because the test case is clearly about a vector of 4 * int. Johann gcc/testsuite/ * c-c++-common/builtin-shuffle-1.c (V): Use 4 * int in vector. Index: c-c++-common/builtin-shuffle-1.c === --- c-c++-c

Re: [PATCH 3/4] OpenMP lowering changes from the hsa branch

Hi, On Fri, Nov 18, 2016 at 11:38:56AM +0100, Jakub Jelinek wrote: > On Sun, Nov 13, 2016 at 10:42:01PM +0100, Martin Jambor wrote: > > + size_t collapse = gimple_omp_for_collapse (for_stmt); > > + struct omp_for_data_loop *loops > > += (struct omp_for_data_loop *) > > +alloca (gimple_om

Re: [PATCH] Propagate cv qualifications in variant_alternative

On 21/11/16 22:46 -0800, Tim Shen wrote: PR libstdc++/78441 * include/std/variant: Propagate cv qualifications to types returned by variant_alternative. * testsuite/20_util/variant/compile.cc: Tests. OK for trunk, thanks.

  1   2   >