On Tue, 22 Nov 2016, Paolo Bonzini wrote: > > It's not obvious to me whether this belongs in -Wextra. After all, this > > is a perfectly reasonable and useful GNU C feature, or at least some cases > > of it are (like "#define FOO (BAR || defined something)"). Is the > > argument that there are too many details of it that differ between > > implementations, as discussed in section 3.2 of > > <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4220.pdf>? > > Yes, and in general it fits the group of "often annoying warnings, that > people may nevertheless appreciate" that are already in -Wextra, for > example -Wunused-parameter, -Wmissing-field-initializers or > -Wshift-negative-value.
Thanks. The patch is OK, but we'll need to see how disruptive it is and consider whether evidence from large-scale builds indicates moving it out of -Wextra. -- Joseph S. Myers jos...@codesourcery.com
