Re: [PATCH] Simplify conditions in EVRP, handle taken edge

2016-10-19 Thread kugan
Hi, On 20/10/16 02:54, Andrew Pinski wrote: On Wed, Oct 19, 2016 at 1:01 AM, Christophe Lyon wrote: On 18 October 2016 at 09:34, Richard Biener wrote: On Mon, 17 Oct 2016, Richard Biener wrote: This refactors propagation vs. substitution and handles condition simplification properly as w

Re: [patch, avr, pr71676 and pr71678] Issues with casesi expand

2016-10-19 Thread Pitchumani Sivanupandi
On Wednesday 19 October 2016 07:51 PM, Georg-Johann Lay wrote: On 17.10.2016 09:27, Pitchumani Sivanupandi wrote: On Thursday 13 October 2016 08:42 PM, Georg-Johann Lay wrote: On 13.10.2016 13:44, Pitchumani Sivanupandi wrote: On Monday 26 September 2016 08:19 PM, Georg-Johann Lay wrote: On 2

PR53979: add transform (a ^ b) | a -> a | b

2016-10-19 Thread Prathamesh Kulkarni
Hi Richard, The attached patch adds the transform (a ^ b) | a -> a | b suggested in PR53979. Bootstrap+tested on x86_64-unknown-linux-gnu. OK to commit ? Thanks, Prathamesh 2016-10-20 Prathamesh Kulkarni PR tree-optimization/53979 * match.pd ((a ^ b) | a -> a | b): New pattern.

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread kugan
On 20/10/16 01:26, Jan Hubicka wrote: Would excluding weak symbols (I believe I can check DECL_WEAK for this) good enough. Or looking for acceptable subset would work? I think we should add a symtab helper to tell if address_nonzero_p (if that doesn't aleady exist). We have node->nonzero_ad

RTL frontend, insn recognition, and pointer equality

2016-10-19 Thread David Malcolm
I've updated the RTL frontend to the new "compact" dump format and have it "mostly working", for some definition of that term [1]. I'm focusing on the "__RTL" extension to cc1, rather than having a true "rtl1" frontend. I've run into an issue with insn recognition relating to pointer equality of

[PATCH] DWARF5 .debug_loclists support

2016-10-19 Thread Jakub Jelinek
Hi! This patch adds .debug_loclists and .debug_loclists.dwo support for -gdwarf-5 and -gdwarf-5 -gsplit-dwarf. The decrease of section size from .debug_loc section to .debug_loclists is really nice. The patch doesn't handle -gdwarf-5 -gsplit-dwarf on targets where assembler doesn't support .uleb1

[PATCH] DWARF5 .debug_line{,_str} support

2016-10-19 Thread Jakub Jelinek
Hi! This patch adds support for DWARF5 .debug_line{,_str} section format, though only if !DWARF2_ASM_LINE_DEBUG_INFO, because otherwise .debug_line is emitted by the assembler. For that we'll need some coordination with gas, dunno if we want a new as directive for that, or as command line switch,

[committed] Fix bootstrap for hppa64-hpux11* on trunk

2016-10-19 Thread John David Anglin
The removal of the JCR_SECTION_NAME define in config/pa/pa64-hpux.h broke bootstrap on hppa64-hpux with HP ld. It exposed a header ordering issue building the crt* objects. EH_FRAME_SECTION was not defined when pa64-hpux.h was included and as a result frame_dummy was not called. This caused e

Re: [patch] Fix PHI optimization issue with boolean types

2016-10-19 Thread Eric Botcazou
> Because BOOLEAN_TYPE types only have two values as documented in > tree.def: > > /* Boolean type (true or false are the only values). Looks like an >INTEGRAL_TYPE. */ > DEFTREECODE (BOOLEAN_TYPE, "boolean_type", tcc_type, 0) Yes, but on the other hand they have a precision and a range. >

Re: [PATCH v3] gcc/config/tilegx/tilegx.c (tilegx_function_profiler): Save r10 to stack before call mcount

2016-10-19 Thread Jeff Law
On 10/06/2016 07:53 AM, Chen Gang wrote: Hello Maintainers: Is this patch OK? Please help check it when you have time (at least for me, it passes all related test and comparation). And I shall continue to find and fix another issues about tilegx. Thanks. On 6/4/16 21:25, cheng...@emindsoft.co

[libgo] Remove unused declarations in runtime.h

2016-10-19 Thread Eric Botcazou
Hi, linking any Go program on SPARC/Solaris with the GNU assembler and the Sun linker yields a warning: ld: warning: relocation error: R_SPARC_UA32: file /sydney.a/users/botcazou/gcc-head/sparc-sun- solaris2.10/./libgo/libgobegin.a(libgobegin_a-go-main.o): symbol runtime_startup_random_data: e

Re: [PATCH] fix outstanding -Wformat-length failures (pr77735 et al.)

2016-10-19 Thread Jeff Law
On 10/17/2016 03:59 PM, Martin Sebor wrote: On 10/17/2016 01:11 PM, Jeff Law wrote: On 10/02/2016 02:10 PM, Martin Sebor wrote: The attached patch fixes a number of outstanding test failures and ILP32-related bugs in the gimple-ssa-sprintf pattch pointed out in bug 77676 and 77735). The patc

Re: [PR other/70945] Handle function_glibc_finite_math in offloading

2016-10-19 Thread Thomas Schwinge
Hi! On Sat, 21 May 2016 17:59:17 +0200, I wrote: > As discussed in "Offloading: compatibility > of target and offloading toolchains", there are situations where we have > to do more work to ensure compatibility between target and offloading > toolchains. The outcome

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Christophe Lyon
On 19 October 2016 at 20:43, Aldy Hernandez wrote: > >>> OK for the trunk whenever you're ready. >>> >>> jeff >> >> >> You are too fast for me :-) >> I do not have the build trees for all the configurations ready for >> manual testing... >> So, I just merged the initial patch and the 2nd one, and

Re: [PATCH] Make std::enable_shared_from_this cope with ambiguity

2016-10-19 Thread Jonathan Wakely
On 19/10/16 21:13 +0100, Jonathan Wakely wrote: This patch does three things: 1. Refactor std::enable_shared_from_this support code. Instead of several overloads of __enable_shared_from_this_helper that contain the same code but operating on slightly different types I've split it into two parts

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-10-19 Thread Jeff Law
On 10/18/2016 12:14 PM, Bernd Edlinger wrote: On 10/18/16 19:05, Joseph Myers wrote: > On Tue, 18 Oct 2016, Bernd Edlinger wrote: > >> Hi, >> >> this restricts the -Wint-in-bool-context warning to signed shifts, >> to reduce the number of false positives Markus reported yesterday. > > This pat

[PATCH] Make std::enable_shared_from_this cope with ambiguity

2016-10-19 Thread Jonathan Wakely
This patch does three things: 1. Refactor std::enable_shared_from_this support code. Instead of several overloads of __enable_shared_from_this_helper that contain the same code but operating on slightly different types I've split it into two parts. Upcasting to an accessible+unambiguous enab

Re: RFC [1/3] divmod transform v2

2016-10-19 Thread Jeff Law
On 10/15/2016 11:59 PM, Prathamesh Kulkarni wrote: Hi, After approval from Bernd Schmidt, I committed the patch to remove optab functions for sdivmod_optab and udivmod_optab in optabs.def, which removes the block for divmod patch. This patch is mostly the same as previous one, except it drops ta

[v3 PATCH] Do the operator= SFINAE in the return type for optional, not in the template parameters.

2016-10-19 Thread Ville Voutilainen
Tested on Linux-x64. 2016-10-19 Ville Voutilainen Do the operator= SFINAE in the return type for optional, not in the template parameters. * include/std/optional (operator=(_Up&&)): Move SFINAE from template parameters to the return type. (operator=(const optional<_Up>&)):

Re: [patch, gfortran] PR48298 DTIO, implement size=

2016-10-19 Thread Jerry DeLisle
On 10/19/2016 08:20 AM, Andreas Schwab wrote: On Okt 19 2016, Jerry DeLisle wrote: Could you try compiling manually the failing test with gfortran -static and then run it to see what happens. That does not change anything. Also what target is this failing on. aarch64 and m68k. Andreas.

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Aldy Hernandez
OK for the trunk whenever you're ready. jeff You are too fast for me :-) I do not have the build trees for all the configurations ready for manual testing... So, I just merged the initial patch and the 2nd one, and started a validation job to make sure the 2nd patch fixes all the regressions

Re: [PATCH] Implement P0084R2, Emplace return type, for C++17

2016-10-19 Thread Jonathan Wakely
On 17/10/16 12:56 +0100, Jonathan Wakely wrote: In C++17 the emplace_front and emplace_back members return a reference. There isn't a very neat way to implement this, so it's just lots of conditional compilation. This fixes a silly typo. Committed to trunk. commit 688f5967dd566c56c01c710f2c1

[PATCH] Fix incorrect comment about std::auto_ptr

2016-10-19 Thread Jonathan Wakely
Pedro pointed out this comment isn't true, see LWG 463 for the reason why (in short, it needs too many user-defined conversions). * include/backward/auto_ptr.h (dauto_ptr): Correct comment about conversions from auto_ptr rvalues to auto_ptr. * testsuite/20_util/auto_ptr/as

Re: [Patch, fortran] PR69566 - Failure of SELECT TYPE with unlimited polymorphic function result

2016-10-19 Thread Andre Vehreschild
Hi Paul, I am not completely through with your patch, but what jumped into my eye was that you copy ref in resolve_select_type and again in fixup_array_ref, when you use it? May be I oversee something. You are more into this code. Is the double copying necessary (line 49 and 82 as well as 95, resp

Re: RTL frontend input format again (was Re: [PATCH 15/16] RTL frontend (rtl1), on top of dump reader)

2016-10-19 Thread David Malcolm
On Wed, 2016-10-19 at 19:22 +0200, Bernd Schmidt wrote: > On 10/19/2016 07:19 PM, David Malcolm wrote: > > I already dropped LABEL_NUSES in compact mode in r241120; I think > > it's > > possible to regenerate that information. > > > > But how would we go about recreating the JUMP_LABEL data? As f

Re: [Fortran, Patch, PR{43366, 57117, 61337, 61376}, v1] Assign to polymorphic objects.

2016-10-19 Thread Andre Vehreschild
Hi all, attached is an enhanced version of the patch, which now catches all of the testcases in the comments of pr61337. Thanks for reporting that I missed them, Dominique. For a detailed description see below. PR61337 needed just some more pre-code joining and correct handling of class-typed arr

Re: RTL frontend input format again (was Re: [PATCH 15/16] RTL frontend (rtl1), on top of dump reader)

2016-10-19 Thread Bernd Schmidt
On 10/19/2016 07:19 PM, David Malcolm wrote: I already dropped LABEL_NUSES in compact mode in r241120; I think it's possible to regenerate that information. But how would we go about recreating the JUMP_LABEL data? As far as I can tell, it can be set up by reorg.c:make_return_insns via comparis

Re: RTL frontend input format again (was Re: [PATCH 15/16] RTL frontend (rtl1), on top of dump reader)

2016-10-19 Thread David Malcolm
On Wed, 2016-10-19 at 16:41 +0200, Bernd Schmidt wrote: > On 10/19/2016 04:35 PM, David Malcolm wrote: > > > In r241120 I dropped all dumping of the JUMP_LABEL when adding the > > "compact" mode. > > > > I'm now running into an issue with this as I update the __RTL in > > cc1 > > tests to use the

Re: libgo patch committed: copy rdebug code from Go 1.7

2016-10-19 Thread Ian Lance Taylor
On Wed, Oct 19, 2016 at 4:30 AM, Richard Biener wrote: > On Mon, Oct 17, 2016 at 6:54 PM, Ian Lance Taylor wrote: >> This patch to libgo copies the rdebug code from the Go 1.7 runtime to libgo. >> >> While we're at it, this updates the runtime/debug package, and starts >> running its testsuite by

Re: [gofrontend-dev] Re: libgo patch committed: copy rdebug code from Go 1.7

2016-10-19 Thread Ian Lance Taylor
On Wed, Oct 19, 2016 at 6:23 AM, Richard Biener wrote: > On Wed, Oct 19, 2016 at 3:17 PM, Ian Lance Taylor wrote: >> On Wed, Oct 19, 2016 at 4:30 AM, Richard Biener >> wrote: >>> On Mon, Oct 17, 2016 at 6:54 PM, Ian Lance Taylor wrote: This patch to libgo copies the rdebug code from the Go

Re: [PATCH] Reduce stack usage in sha512 (PR target/77308)

2016-10-19 Thread Kyrill Tkachov
On 19/10/16 17:06, Bernd Edlinger wrote: On 10/19/16 12:44, Christophe Lyon wrote: On 19 October 2016 at 10:34, Kyrill Tkachov wrote: On 19/10/16 07:55, Christophe Lyon wrote: On 18 October 2016 at 17:35, Christophe Lyon wrote: On 18 October 2016 at 16:45, Bernd Edlinger wrote: On 10/18/

Re: [tree-optimization/71947] Avoid unwanted propagations

2016-10-19 Thread Jeff Law
On 10/12/2016 09:00 AM, Georg-Johann Lay wrote: On 10.10.2016 23:06, Jeff Law wrote: So if we have an equality conditional between A & B, we record into our const/copy tables A = B and B = A. This helps us discover some of the more obscure equivalences. But it also creates problems with an ex

Re: [tree-optimization/71947] Avoid unwanted propagations

2016-10-19 Thread Jeff Law
On 10/12/2016 08:36 AM, Christophe Lyon wrote: It fixes the tests from 71947 and 77647 without regressing (obviously). I've included an xfailed test for a more complex situation that we don't currently handle (would require backtracking from the equality comparison through the logicals that feed

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Christophe Lyon
On 19 October 2016 at 17:55, Jeff Law wrote: > On 10/19/2016 09:32 AM, Aldy Hernandez wrote: >> >> On 10/19/2016 09:16 AM, Eric Botcazou wrote: m68k-suse-linux >>> >>> >>> visium-elf too. >>> >> >> The attached patch fixes the failures on m68k-suse-linux, visium-elf, >> and arm-eabi. >>

Re: [PATCH] Extend -Wint-in-bool-context to suspicious enum values (PR 77700)

2016-10-19 Thread Markus Trippelsdorf
On 2016.10.07 at 15:18 +, Bernd Edlinger wrote: > Hi! > > This extends -Wint-in-bool-context to uses of enum values in boolean > context, and fixes one place where accidentally an enum value was > passed to a bool parameter. > > I excluded enum values 0 and 1 because that is used in > gimple-ss

Re: [PATCH] Reduce stack usage in sha512 (PR target/77308)

2016-10-19 Thread Bernd Edlinger
On 10/19/16 12:44, Christophe Lyon wrote: > On 19 October 2016 at 10:34, Kyrill Tkachov > wrote: >> >> On 19/10/16 07:55, Christophe Lyon wrote: >>> >>> On 18 October 2016 at 17:35, Christophe Lyon >>> wrote: On 18 October 2016 at 16:45, Bernd Edlinger wrote: > > On 10/18

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Jeff Law
On 10/19/2016 09:32 AM, Aldy Hernandez wrote: On 10/19/2016 09:16 AM, Eric Botcazou wrote: m68k-suse-linux visium-elf too. The attached patch fixes the failures on m68k-suse-linux, visium-elf, and arm-eabi. There were a few problems. One problem is that on lp64 targets (where sizeof(size_

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Eric Botcazou
> This fixes both tests on m68k. Likewise on Visium. -- Eric Botcazou

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Andreas Schwab
On Okt 19 2016, Aldy Hernandez wrote: > commit 32b629dcab7b78e8181146338c4b077f1d55a0bf > Author: Aldy Hernandez > Date: Wed Oct 19 11:24:44 2016 -0400 > > * gcc.dg/Walloca-1.c: Adjust test for !lp64 targets. > * gcc.dg/Walloca-2.c: Same. This fixes both tests on m68k. Andreas.

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Eric Botcazou
> I have committed the attached patch as mostly obvious :). Thanks! -- Eric Botcazou

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Aldy Hernandez
On 10/19/2016 09:16 AM, Eric Botcazou wrote: m68k-suse-linux visium-elf too. The attached patch fixes the failures on m68k-suse-linux, visium-elf, and arm-eabi. There were a few problems. One problem is that on lp64 targets (where sizeof(size_t) != sizeof(int)), the warning is slightly

Re: [patch, gfortran] PR48298 DTIO, implement size=

2016-10-19 Thread Andreas Schwab
On Okt 19 2016, Jerry DeLisle wrote: > Could you try compiling manually the failing test with gfortran -static > and then run it to see what happens. That does not change anything. > Also what target is this failing on. aarch64 and m68k. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de

Re: [Patch 3/11] Implement TARGET_C_EXCESS_PRECISION for s390

2016-10-19 Thread Andreas Krebbel
On 10/17/2016 09:29 PM, Andreas Krebbel1 wrote: >> Here is a patch implementing what I think has been discussed in this > thread. >> >> OK? > > Looks good to me. > > Uli, do you agree with that change for S/390 or would you rather see us > fixing the float_t type definition in Glibc? I had a d

Re: [patch, gfortran] PR48298 DTIO, implement size=

2016-10-19 Thread Andreas Schwab
On Okt 19 2016, Jerry DeLisle wrote: > The patch changes nothing related to any particular target. If I were to > hazard a guess I would think the tests are linking against a wrong version > of the library, the follow on patch (not yet committed) is bumping the > libgfortran major version number.

Re: [patch, gfortran] PR48298 DTIO, implement size=

2016-10-19 Thread Jerry DeLisle
On 10/19/2016 04:04 AM, Andreas Schwab wrote: At line 74 of file /opt/gcc/gcc-20161019/gcc/testsuite/gfortran.dg/dtio_17.f90 (unit = 28, file = '/tmp/gfortrantmpQF10b7') Fortran runtime error: Bad value during integer read Error termination. Backtrace: FAIL: gfortran.dg/dtio_17

Re: [patch, gfortran] PR48298 DTIO, implement size=

2016-10-19 Thread Jerry DeLisle
On 10/19/2016 01:59 AM, Christophe Lyon wrote: Hi, On 18 October 2016 at 04:45, Steve Kargl wrote: On Mon, Oct 17, 2016 at 06:02:52PM -0700, Jerry DeLisle wrote: Hi all, The attached patch enables the size= specifier in a READ statement to work with child DTIO procedures. This is accomplish

Re: [PATCH 09/16] Split class rtx_reader into base_rtx_reader vs rtx_reader

2016-10-19 Thread Bernd Schmidt
On 10/18/2016 10:30 PM, David Malcolm wrote: I'm not in love with the names I chose in this patch. It does seem odd having an "rtx_reader" class that can't actually read hierarchical rtx. How about "md_reader" as the base class (with responsibility for the things in read-md.o), and "rtx_reader

Re: RTL frontend input format again (was Re: [PATCH 15/16] RTL frontend (rtl1), on top of dump reader)

2016-10-19 Thread Bernd Schmidt
On 10/19/2016 04:35 PM, David Malcolm wrote: In r241120 I dropped all dumping of the JUMP_LABEL when adding the "compact" mode. I'm now running into an issue with this as I update the __RTL in cc1 tests to use the new format, since various passes require the JUMP_INSNs to have JUMP_LABEL data.

Re: RTL frontend input format again (was Re: [PATCH 15/16] RTL frontend (rtl1), on top of dump reader)

2016-10-19 Thread David Malcolm
On Fri, 2016-10-07 at 15:58 +0200, Bernd Schmidt wrote: > On 10/07/2016 03:26 PM, David Malcolm wrote: > > > > We could simply print the INSN_UID for CODE_LABELs; something like > > this > > (see the "(code_label 16" below): > > I think that should work. > > > You appear to have trimmed the idea

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread Jan Hubicka
> > Would excluding weak symbols (I believe I can check DECL_WEAK for this) good > > enough. Or looking for acceptable subset would work? > > I think we should add a symtab helper to tell if address_nonzero_p (if > that doesn't aleady exist). We have node->nonzero_address() Honza > > Richard. >

Re: [patch, avr, pr71676 and pr71678] Issues with casesi expand

2016-10-19 Thread Georg-Johann Lay
On 17.10.2016 09:27, Pitchumani Sivanupandi wrote: On Thursday 13 October 2016 08:42 PM, Georg-Johann Lay wrote: On 13.10.2016 13:44, Pitchumani Sivanupandi wrote: On Monday 26 September 2016 08:19 PM, Georg-Johann Lay wrote: On 26.09.2016 15:19, Pitchumani Sivanupandi wrote: Attached patch f

[ping * 2] PR35503 - warn for restrict

2016-10-19 Thread Prathamesh Kulkarni
Hi, The attached patch is a rebased version of the patch posted at: https://gcc.gnu.org/ml/gcc-patches/2016-10/msg00446.html The C++ changes are approved by Jason, other parts still require approval. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK to commit ? I was wondering if the warnin

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Aldy Hernandez
On 10/19/2016 09:24 AM, Eric Botcazou wrote: It seems to me that there is a precedence for -W type tests to start with a capital letter, as opposed to a lowercase letter: $ cd gcc.dg $ ls W[a-z]* |wc 280 2805816 Do you think it would perhaps be reasonable to rename all of them to u

[PATCH] Fix PR77916

2016-10-19 Thread Bill Schmidt
Hi, The previous fix for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77916 ensured that record_increment would use normal multiplier initializers for increments of -1 with unknown strides, just as for all other negative increments. However, we still had a problem in insert_initializers wherein t

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Eric Botcazou
> It's unclear from your response whether you want to do this or want me > to do it. In the interest of being lazy, I'll let you do it :). I guess this wasn't really decided in my mind either. ;-) > p.s. If OTOH, you want me to do it, let me know. Yes, please do, thanks in advance. -- Eric Bo

Get rid of useless .oaccdevlow dump file

2016-10-19 Thread Eric Botcazou
Yet another pass generating a useless dump file when it is not run. Tested on x86_64-suse-linux, applied on mainline as obvious. 2016-10-19 Eric Botcazou * omp-low.c (pass_oacc_device_lower::gate): New method. (execute): Always call execute_oacc_device_lower. -- Eric Botcaz

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Aldy Hernandez
On 10/19/2016 09:24 AM, Eric Botcazou wrote: It seems to me that there is a precedence for -W type tests to start with a capital letter, as opposed to a lowercase letter: $ cd gcc.dg $ ls W[a-z]* |wc 280 2805816 Do you think it would perhaps be reasonable to rename all of them to u

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Eric Botcazou
> It seems to me that there is a precedence for -W type tests to start > with a capital letter, as opposed to a lowercase letter: > > $ cd gcc.dg > $ ls W[a-z]* |wc > 280 2805816 > > Do you think it would perhaps be reasonable to rename all of them to > uppercase? Yes, I agree that

Re: libgo patch committed: copy rdebug code from Go 1.7

2016-10-19 Thread Richard Biener
On Wed, Oct 19, 2016 at 3:17 PM, Ian Lance Taylor wrote: > On Wed, Oct 19, 2016 at 4:30 AM, Richard Biener > wrote: >> On Mon, Oct 17, 2016 at 6:54 PM, Ian Lance Taylor wrote: >>> This patch to libgo copies the rdebug code from the Go 1.7 runtime to libgo. >>> >>> While we're at it, this updates

Re: libgo patch committed: copy rdebug code from Go 1.7

2016-10-19 Thread Ian Lance Taylor
On Wed, Oct 19, 2016 at 4:30 AM, Richard Biener wrote: > On Mon, Oct 17, 2016 at 6:54 PM, Ian Lance Taylor wrote: >> This patch to libgo copies the rdebug code from the Go 1.7 runtime to libgo. >> >> While we're at it, this updates the runtime/debug package, and starts >> running its testsuite by

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Eric Botcazou
> m68k-suse-linux visium-elf too. -- Eric Botcazou

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Andreas Schwab
On Okt 19 2016, Aldy Hernandez wrote: > On 10/19/2016 06:45 AM, Andreas Schwab wrote: >> FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) >> FAIL: gcc.dg/Walloca-1.c (test for excess errors) >> Excess errors: >> /daten/aranym/gcc/gcc-20161019/gcc/testsu

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Aldy Hernandez
On 10/19/2016 06:45 AM, Andreas Schwab wrote: FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) FAIL: gcc.dg/Walloca-1.c (test for excess errors) Excess errors: /daten/aranym/gcc/gcc-20161019/gcc/testsuite/gcc.dg/Walloca-1.c:26:5: warning: unbounded use of 'alloca' [-Walloca-l

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Aldy Hernandez
On 10/19/2016 03:08 AM, Eric Botcazou wrote: My apologies for the delay. I have finally committed this patch. Before doing so, I merged with trunk and re-tested (x86-64 Linux) just in case. There were no regressions. Can you rename the testcases? Git doesn't like the names: *** These collis

Re: [PATCH 0/8] NVPTX offloading to NVPTX: backend patches

2016-10-19 Thread Jakub Jelinek
On Tue, Oct 18, 2016 at 07:58:49PM +0300, Alexander Monakov wrote: > On Tue, 18 Oct 2016, Bernd Schmidt wrote: > > The performance I saw was lower by a factor of 80 or so compared to their > > CUDA > > version, and even lower than OpenMP on the host. > > The currently published OpenMP version of

Re: [PATCH] Fix bootstrap with --enable-languages=all,go

2016-10-19 Thread Rainer Orth
Hi Jakub, >> 2016-10-01 Rainer Orth >> >> * configure.ac (target_libraries): Readd target-boehm-gc. >> Restore --enable-objc-gc handling. >> * configure: Regenerate. > > This is incomplete. I guess it can be committed as is, but should be > followed by re-addition of: > bfin-

Re: [PATCH] Fix std::experimental::shared_ptr SFINAE constraints

2016-10-19 Thread Jonathan Wakely
On 19/10/16 10:35 +0100, Jonathan Wakely wrote: There are lots of SFINAE checks missing from experimental::shared_ptr, and we even test that shared_ptr(new derived[1]) works, when it should be ill-formed. Moar tests! Tested powerpc64le-linux, committed to trunk. commit 9258e632b7810db67cef4e6

[PATCH] Do not disable aggressive loop opts for, -fsanitize=unreachable or leak

2016-10-19 Thread Martin Liška
Hello. This patch allows aggressive loop optimizations and strict overflow when -fsanitize=unreachabne or -fsanitize=leak is (are) enabled. That would help kernel people to have assumption that every functions should either end with jmp ret or by __builtin___ubsan_handle_builtin_unreachable. Patc

Re: libgo patch committed: copy rdebug code from Go 1.7

2016-10-19 Thread Richard Biener
On Mon, Oct 17, 2016 at 6:54 PM, Ian Lance Taylor wrote: > This patch to libgo copies the rdebug code from the Go 1.7 runtime to libgo. > > While we're at it, this updates the runtime/debug package, and starts > running its testsuite by default. I'm not sure why runtime/debug was > not previously

Implement -Wduplicated-branches (PR c/64279)

2016-10-19 Thread Marek Polacek
This patch introduces a new warning, -Wduplicated-branches. Its purpose is to warn for code such as if (cond) return 0; else return 0; as well as e.g. r = i ? *p : *p; The approach I took was to use inchash::add_expr to hash the expressions and then compare the hashes. But of co

Re: [patch, gfortran] PR48298 DTIO, implement size=

2016-10-19 Thread Andreas Schwab
At line 74 of file /opt/gcc/gcc-20161019/gcc/testsuite/gfortran.dg/dtio_17.f90 (unit = 28, file = '/tmp/gfortrantmpQF10b7') Fortran runtime error: Bad value during integer read Error termination. Backtrace: FAIL: gfortran.dg/dtio_17.f90 -O1 execution test Andreas. -- Andreas Sc

Re: [PR lto/77458] Avoid ICE in offloading with differing _FloatN, _FloatNx types

2016-10-19 Thread Thomas Schwinge
Hi! On Mon, 17 Oct 2016 17:59:16 +0200, I wrote: > On Thu, 29 Sep 2016 15:18:00 +0200, Thomas Schwinge > wrote: > > On Mon, 19 Sep 2016 13:25:01 +0200, Richard Biener > > wrote: > > > On Mon, Sep 19, 2016 at 1:19 PM, Thomas Schwinge > > > wrote: > > > > On Mon, 19 Sep 2016 10:18:35 +0200, Ric

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Christophe Lyon
On 19 October 2016 at 12:45, Andreas Schwab wrote: > FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) > FAIL: gcc.dg/Walloca-1.c (test for excess errors) > Excess errors: > /daten/aranym/gcc/gcc-20161019/gcc/testsuite/gcc.dg/Walloca-1.c:26:5: > warning: unbounded use of &#x

[patch, libstdc++] Optimize selection sampling by using generator to get two values at once

2016-10-19 Thread Eelis van der Weegen
This is the same optimization as was recently applied to std::shuffle. It reduces the runtime of the following program by 20% on my machine: int main() { std::vector a(1), b(1000); std::mt19937 gen; uint64_t c = 0;

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-10-19 Thread Andreas Schwab
FAIL: gcc.dg/Walloca-1.c (test for warnings, line 26) FAIL: gcc.dg/Walloca-1.c (test for excess errors) Excess errors: /daten/aranym/gcc/gcc-20161019/gcc/testsuite/gcc.dg/Walloca-1.c:26:5: warning: unbounded use of 'alloca' [-Walloca-larger-than=] FAIL: gcc.dg/Walloca-2.c (test fo

Re: [PATCH] Reduce stack usage in sha512 (PR target/77308)

2016-10-19 Thread Christophe Lyon
On 19 October 2016 at 10:34, Kyrill Tkachov wrote: > > On 19/10/16 07:55, Christophe Lyon wrote: >> >> On 18 October 2016 at 17:35, Christophe Lyon >> wrote: >>> >>> On 18 October 2016 at 16:45, Bernd Edlinger >>> wrote: On 10/18/16 10:36, Christophe Lyon wrote: > > I am seeing

Re: [PATCH PR78005]Fix miscompare issue by computing correct guard condition for vectorized loop

2016-10-19 Thread Richard Biener
On Wed, Oct 19, 2016 at 12:38 PM, Bin Cheng wrote: > Hi, > This is the patch fixing spec mis-compare issue reported in PR78005. In the > original patch, boundary condition was mis-handled when generating guard > checking if vectorized/scalar loop should be preferred. This isn't an issue > in

Re: [PATCH v2][AArch32][NEON] Implementing vmaxnmQ_ST and vminnmQ_ST intrinsincs.

2016-10-19 Thread Tamar Christina
> I think you forgot to attach the new tests. Ah, you're right! forgot an add. New patch coming soon. Thanks, Tamar

[PATCH PR78005]Fix miscompare issue by computing correct guard condition for vectorized loop

2016-10-19 Thread Bin Cheng
Hi, This is the patch fixing spec mis-compare issue reported in PR78005. In the original patch, boundary condition was mis-handled when generating guard checking if vectorized/scalar loop should be preferred. This isn't an issue in general, but in cases we need to peel for gaps, as well as ski

Re: [PATCH 0/8] NVPTX offloading to NVPTX: backend patches

2016-10-19 Thread Bernd Schmidt
On 10/18/2016 06:58 PM, Alexander Monakov wrote: The currently published OpenMP version of LULESH simply doesn't use openmp-simd anywhere. This should make it obvious that it won't be anywhere near any reasonable CUDA implementation, and also bound to be below host performance. Besides, it's com

Re: [PATCH 0/8] NVPTX offloading to NVPTX: backend patches

2016-10-19 Thread Alexander Monakov
On Tue, 18 Oct 2016, Bernd Schmidt wrote: > [...] but then I think we shouldn't repeat the mistakes we made with OpenACC I think it would be good if you'd mention for posterity what, specifically, the mistakes were, in particular if you want those not to be repeated in the context of OpenMP offloa

[PR tree-optimization/78024] Clear basic block flags before using BB_VISITED for OpenACC loops processing

2016-10-19 Thread Thomas Schwinge
Hi! On Wed, 19 Oct 2016 12:07:13 +0200, Richard Biener wrote: > On Tue, Oct 18, 2016 at 9:52 PM, Thomas Schwinge > wrote: > > can I at > > least commit the OpenACC loops processing fix? Here is the latest > > version, simplified after your r241296 IRA vs. BB_VISITED fixes: > > Sure, I conside

Re: [PATCH v2][AArch32][NEON] Implementing vmaxnmQ_ST and vminnmQ_ST intrinsincs.

2016-10-19 Thread Christophe Lyon
On 19 October 2016 at 11:36, Tamar Christina wrote: > Hi All, > > This patch implements the vmaxnmQ_ST and vminnmQ_ST intrinsics. The > current builtin registration code is deficient since it can't access > standard pattern names, to which vmaxnmQ_ST and vminnmQ_ST map > directly. Thus, to enable

Re: [libcc1] add support for C++

2016-10-19 Thread Alexandre Oliva
On Sep 23, 2016, Alexandre Oliva wrote: > This patchset adds support for the C++ language to libcc1. > It updates a few patches for libcc1 by Jan Kratochvil, posted long ago > but IIRC not reviewed; it updates a patch that adds support for > representing aliases and trampolines in dwarf2+ debug i

Re: [PR59319] output friends in debug info

2016-10-19 Thread Alexandre Oliva
On Sep 23, 2016, Alexandre Oliva wrote: > On Aug 30, 2016, Alexandre Oliva wrote: >> Handling non-template friends is kind of easy, [...] > Regstrapped on x86_64-linux-gnu and i686-linux-gnu, I'd failed to > mention. > Ping? Ping? (conflicts resolved, patch refreshed and retested) Handling

Re: [PR56974] output DWARF-5 markers for ref_qualifiers

2016-10-19 Thread Alexandre Oliva
On Sep 23, 2016, Alexandre Oliva wrote: > On Aug 12, 2016, Alexandre Oliva wrote: >> Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? > Ping? Ping? (conflicts resolved, patch refreshed and retested) When a method or a method or function type has a ref-qualifier, output DW

Re: [PR63238] output alignment debug information

2016-10-19 Thread Alexandre Oliva
On Sep 23, 2016, Alexandre Oliva wrote: > On Aug 27, 2016, Alexandre Oliva wrote: >> Output DWARFv5+ DW_AT_alignment for non-default alignment of >> variables, fields and types. >> Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? > Ping? Ping? (conflicts resolved, patch re

Re: [PATCH] PR77987 Fix unique_ptr::reset(U) for T != U

2016-10-19 Thread Jonathan Wakely
On 17/10/16 13:00 +0100, Jonathan Wakely wrote: This is a very simple change, to allow conversions that are supposed to be valid according to DR 2118. The fix was slightly complicated by the tests being a bit of a mess. We had tests for this requirement, but they were in files which mixed positiv

[PATCH, OBVIOUS] Replace NULL with false as a return value

2016-10-19 Thread Martin Liška
Hello. Replacing NULL with false in a method with the boolean return type should be obvious. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Martin >From 9071aa82e0203cf71fcc743f2e94aa7151986b6e Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 18 Oct 2016 17:59:33 +020

Re: Clear basic block flags before using BB_VISITED for OpenACC loops processing

2016-10-19 Thread Richard Biener
On Tue, Oct 18, 2016 at 9:52 PM, Thomas Schwinge wrote: > Hi! > > On Mon, 17 Oct 2016 15:38:50 +0200, I wrote: >> On Mon, 17 Oct 2016 14:08:44 +0200, Richard Biener >> wrote: >> > On Mon, Oct 17, 2016 at 1:47 PM, Thomas Schwinge >> > wrote: >> > > On Mon, 17 Oct 2016 13:22:17 +0200, Richard Bie

Re: [patch] Fix PHI optimization issue with boolean types

2016-10-19 Thread Richard Biener
On Tue, Oct 18, 2016 at 4:10 PM, Jeff Law wrote: > On 10/18/2016 02:35 AM, Richard Biener wrote: >> >> On Tue, Oct 18, 2016 at 8:35 AM, Eric Botcazou >> wrote: >>> >>> Hi, >>> >>> this is a regression present on the mainline and 6 branch: the compiler >>> now >>> generates wrong code for the atta

[PATCH v2][AArch32][NEON] Implementing vmaxnmQ_ST and vminnmQ_ST intrinsincs.

2016-10-19 Thread Tamar Christina
Hi All, This patch implements the vmaxnmQ_ST and vminnmQ_ST intrinsics. The current builtin registration code is deficient since it can't access standard pattern names, to which vmaxnmQ_ST and vminnmQ_ST map directly. Thus, to enable the vectoriser to have access to these intrinsics, we implement

Re: [PATCH] PR77990 refactor unique_ptr to encapsulate tuple

2016-10-19 Thread Jonathan Wakely
On 17/10/16 14:37 +0100, Jonathan Wakely wrote: We are incorrectly requiring unique_ptr deleters to be copyable here: explicit unique_ptr(pointer __p) noexcept : _M_t(__p, deleter_type()) { } We could just do: explicit unique_ptr(pointer __p) noexcept : _M_t() {

[PATCH] Fix std::experimental::shared_ptr SFINAE constraints

2016-10-19 Thread Jonathan Wakely
There are lots of SFINAE checks missing from experimental::shared_ptr, and we even test that shared_ptr(new derived[1]) works, when it should be ill-formed. I implemented a new trait for std::shared_ptr to check the conversions, but I'm not ready to commit that work yet, so this just adds it to e

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread Richard Biener
On Wed, 19 Oct 2016, kugan wrote: > Hi Richard, > > > On 19/10/16 19:23, Richard Biener wrote: > > On Wed, 19 Oct 2016, kugan wrote: > > > > > Hi, > > > > > > While computing jump function value range for pointer, I am wondering if > > > we > > > can assume that any tree with ADDR_EXPR will be

Re: [patch, gfortran] PR48298 DTIO, implement size=

2016-10-19 Thread Christophe Lyon
Hi, On 18 October 2016 at 04:45, Steve Kargl wrote: > On Mon, Oct 17, 2016 at 06:02:52PM -0700, Jerry DeLisle wrote: >> Hi all, >> >> The attached patch enables the size= specifier in a READ statement to work >> with >> child DTIO procedures. This is accomplished by moving the size_used variabl

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread kugan
Hi Richard, On 19/10/16 19:23, Richard Biener wrote: On Wed, 19 Oct 2016, kugan wrote: Hi, While computing jump function value range for pointer, I am wondering if we can assume that any tree with ADDR_EXPR will be nonnull. That is, in cases like: int arr[10]; foo (&arr[1]); OR struct st

Re: [PATCH] Reduce stack usage in sha512 (PR target/77308)

2016-10-19 Thread Kyrill Tkachov
On 19/10/16 07:55, Christophe Lyon wrote: On 18 October 2016 at 17:35, Christophe Lyon wrote: On 18 October 2016 at 16:45, Bernd Edlinger wrote: On 10/18/16 10:36, Christophe Lyon wrote: I am seeing a lot of regressions since this patch was committed: http://people.linaro.org/~christophe.ly

Re: r241307 - in /trunk: gcc/go/gofrontend/MERGE li...

2016-10-19 Thread Andreas Schwab
../../../libgo/go/runtime/netpoll_epoll.go:52:49: error: integer constant overflow ev.events = _EPOLLIN | _EPOLLOUT | _EPOLLRDHUP | _EPOLLET ^ $ grep EPOLLET -r ia64-suse-linux/libgo ia64-suse-linux/libgo/runtime_sysinfo.go:const _EPOLLET = -2147

Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull

2016-10-19 Thread Richard Biener
On Wed, 19 Oct 2016, kugan wrote: > Hi, > > While computing jump function value range for pointer, I am wondering if we > can assume that any tree with ADDR_EXPR will be nonnull. > > That is, in cases like: > > int arr[10]; > foo (&arr[1]); > > OR > > struct st > { > int a; > int b; > };

  1   2   >