Re: [RFC][IPA-VRP] Add support for IPA VRP in ipa-cp/ipa-prop

2016-08-29 Thread Kugan Vivekanandarajah
Hi Honza, Here is a re-based version which also addresses the review comments. On 21/07/16 22:54, Jan Hubicka wrote: >> Maybe it is better to separate value range and alignment summary >> writing/reading to different functions. Here is another updated >> version which does this. > > Makes sense t

Re: [PATCH] Fix avoid_constant_pool_reference (PR middle-end/77377)

2016-08-29 Thread Richard Biener
On August 29, 2016 9:43:50 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >Returning c from avoid_constant_pool_reference for constant pool >references >is only fine if the modes match and offset is zero, otherwise if the >offset >is sane, we can try to simplify it as subreg. But, returning c for out

Re: [PATCH] Fix dwarf2out ARRAY_TYPE handling (PR debug/77363)

2016-08-29 Thread Richard Biener
On August 29, 2016 9:53:32 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >In r231058 gen_type_die_with_usage has been changed to treat ARRAY_TYPE >like >VECTOR_TYPE and not to use type_main_variant in that case. But as the >following testcase shows, modified_type_die has similar condition and >if >th

Re: [PATCH] Fix compile time complexity of search_type_for_mask (PR tree-optimization/72866)

2016-08-29 Thread Richard Biener
On August 29, 2016 9:57:00 PM GMT+02:00, Jakub Jelinek wrote: >Hi! > >As the testcase shows, with deep chains of COND_EXPRs with the same >SSA_NAMEs appearing more than once in the various operands we can >hang in search_type_for_mask. Similar check_bool_pattern function >uses a hash_set to handl

Go patch committed: add -fgo-c-header=FILE option

2016-08-29 Thread Ian Lance Taylor
This patch to the Go frontend adds a new option -fgo-c-header=FILE that tells the Go frontend to create a C header file defining the package scope constants and struct types. This is a step toward converting much of the runtime package from C to Go, in order to use the new facilities in the master

Re: [PATCH 3/4] (v2) Introduce class edit_context

2016-08-29 Thread Trevor Saunders
On Mon, Aug 29, 2016 at 02:53:43PM -0400, David Malcolm wrote: > On Sun, 2016-08-28 at 11:13 -0400, Trevor Saunders wrote: > > On Wed, Aug 24, 2016 at 09:13:51PM -0400, David Malcolm wrote: > > > + > > > + const char *m_filename; > > > + char *m_content; > > > + size_t m_len; > > > + size_t m_a

Re: [PATCH] Fix template-params-12f.C on darwin/vxworks (PR debug/77389)

2016-08-29 Thread Mike Stump
On Aug 29, 2016, at 12:41 PM, Jakub Jelinek wrote: > > This testcase expects to find DWARF extensions, but those are disabled by > default on darwin/vxworks because broken tools there don't handle debug info > very well. > > I think the following patch (regtested on x86_64-linux and i686-linux)

Re: [PATCH] Eradicate MQ some more

2016-08-29 Thread David Edelsohn
On Mon, Aug 29, 2016 at 7:58 PM, Segher Boessenkool wrote: > Nothing uses MQ anymore, but it still shows up in all the dump files. > This patch removes it from CALL_REALLY_USED_REGISTERS so that that does > not happen anymore (it is still a fixed register, there should be no > functional change).

Re: PR35503 - warn for restrict pointer

2016-08-29 Thread David Malcolm
On Mon, 2016-08-29 at 20:01 -0400, David Malcolm wrote: > On Mon, 2016-08-29 at 19:55 -0400, David Malcolm wrote: > [...] > > Assuming you have the location_t values available, you can create a > > rich_location for the primary range, and then add secondary ranges > > like > > this: > > > > rich

Re: PR35503 - warn for restrict pointer

2016-08-29 Thread David Malcolm
On Mon, 2016-08-29 at 19:55 -0400, David Malcolm wrote: [...] > Assuming you have the location_t values available, you can create a > rich_location for the primary range, and then add secondary ranges > like > this: > > rich_location richloc (loc_of_arg1); Oops, the above should be: rich_l

[PATCH] Eradicate MQ some more

2016-08-29 Thread Segher Boessenkool
Nothing uses MQ anymore, but it still shows up in all the dump files. This patch removes it from CALL_REALLY_USED_REGISTERS so that that does not happen anymore (it is still a fixed register, there should be no functional change). Bootstrapped and regression tested on powerpc64-linux, -m32,-m64.

Re: PR35503 - warn for restrict pointer

2016-08-29 Thread David Malcolm
On Tue, 2016-08-30 at 03:23 +0530, Prathamesh Kulkarni wrote: > On 29 August 2016 at 19:59, Marek Polacek wrote: > > On Mon, Aug 29, 2016 at 04:25:25PM +0200, Tobias Burnus wrote: > > > Prathamesh Kulkarni wrote: > > > > Attachment: pr35503-3.txt > > > > > > I tried the patch - and it found a bug

Re: [PATCH] Fix template-params-12f.C on darwin/vxworks (PR debug/77389)

2016-08-29 Thread Dominique d'Humières
Preliminary tests show that the patch fixes the issue. Thanks, Dominique > Le 29 août 2016 à 21:41, Jakub Jelinek a écrit : > > Hi! > > This testcase expects to find DWARF extensions, but those are disabled by > default on darwin/vxworks because broken tools there don't handle debug info > ve

Re: PR35503 - warn for restrict pointer

2016-08-29 Thread Prathamesh Kulkarni
On 29 August 2016 at 19:59, Marek Polacek wrote: > On Mon, Aug 29, 2016 at 04:25:25PM +0200, Tobias Burnus wrote: >> Prathamesh Kulkarni wrote: >> > Attachment: pr35503-3.txt >> >> I tried the patch - and it found a bug in our code; nice! >> >> >> (a) Regarding the [-Werror] output: >> >>error

Re: [PATCH 1/4] selftest: split out named_temp_file from temp_source_file

2016-08-29 Thread Bernd Schmidt
On 08/25/2016 03:13 AM, David Malcolm wrote: Split out a new base class for temp_source_file, named_temp_file, moving the deletion to the base class dtor, so that we can write out temporary files in other ways in selftests. gcc/ChangeLog: * selftest.c (selftest::named_temp_file::named_te

[patch] Fix PR72715

2016-08-29 Thread Cesar Philippidis
It looks like the fortran FE has some preliminary support for do concurrent loops, however it was not well tested, nor is do concurrent supported by the OpenACC spec. This patch teaches the fortran FE to error when an acc loop directive is applied to a do concurrent loop. The reason why the existi

Re: [PATCH][msp430] Don't output __interrupt_vector sections for weak functions

2016-08-29 Thread DJ Delorie
Which results in a more user-obvious case, ignoring the interrupt attribute or ignoring the weak attribute? I would think that we never want to compile and link successfully if we can't do what the user wants, and omitting an interrupt handler is... bad. I think this should either be a hard erro

[committed] Allow the use of ad-hoc locations for fix-it hints

2016-08-29 Thread David Malcolm
On Mon, 2016-08-29 at 13:43 -0400, David Malcolm wrote: > On Mon, 2016-08-29 at 08:50 -0400, David Malcolm wrote: > > On Mon, 2016-08-29 at 13:44 +0200, Marek Polacek wrote: > > > On Mon, Aug 29, 2016 at 12:35:38PM +0200, Marek Polacek wrote: > > > > On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andrea

Re: [PATCH] df: Keep return address register undefined until epilogue_completed

2016-08-29 Thread Segher Boessenkool
On Mon, Aug 29, 2016 at 10:19:25PM +0200, Steven Bosscher wrote: > On Mon, Aug 29, 2016 at 6:50 PM, Segher Boessenkool wrote: > > This patch changes that so that that def is only added after > > epilogue_completed. > ... > > Does this work on all other targets? > > Guessing: not for targets where

Re: [PATCH] df: Keep return address register undefined until epilogue_completed

2016-08-29 Thread Steven Bosscher
On Mon, Aug 29, 2016 at 6:50 PM, Segher Boessenkool wrote: > This patch changes that so that that def is only added after > epilogue_completed. ... > Does this work on all other targets? Guessing: not for targets where INCOMING_RETURN_ADDR_RTX is the stack register? That'd be at least h8300, rl78,

[PATCH] Fix abi_tag23* test failure (PR c++/77379)

2016-08-29 Thread Jakub Jelinek
On Mon, Aug 29, 2016 at 12:42:28PM -0400, Jason Merrill wrote: > Another missing ABI tag, sigh. > > Tested x86_64-pc-linux-gnu, applying to trunk. > commit 1337a943a2d3926537b63d6e1f0d7f46ef10a06d > Author: Jason Merrill > Date: Fri Aug 26 15:12:52 2016 -0400 > > PR c++/77379 - ABI tag

Re: Implement -Wimplicit-fallthrough (version 7)

2016-08-29 Thread Jason Merrill
On Mon, Aug 29, 2016 at 7:58 AM, Marek Polacek wrote: > --- gcc/gcc/cp/parser.c > +++ gcc/gcc/cp/parser.c > @@ -5135,6 +5135,31 @@ cp_parser_primary_expression (cp_parser *parser, > case RID_AT_SELECTOR: > return cp_parser_objc_expression (parser); > > + case RID_ATTRIBUTE:

[PATCH] Fix compile time complexity of search_type_for_mask (PR tree-optimization/72866)

2016-08-29 Thread Jakub Jelinek
Hi! As the testcase shows, with deep chains of COND_EXPRs with the same SSA_NAMEs appearing more than once in the various operands we can hang in search_type_for_mask. Similar check_bool_pattern function uses a hash_set to handle stmts that have been checked already, this patch uses a hash_map in

[PATCH] Fix dwarf2out ARRAY_TYPE handling (PR debug/77363)

2016-08-29 Thread Jakub Jelinek
Hi! In r231058 gen_type_die_with_usage has been changed to treat ARRAY_TYPE like VECTOR_TYPE and not to use type_main_variant in that case. But as the following testcase shows, modified_type_die has similar condition and if those two don't agree, modified_type_die just fails the lookup if type_ma

[C++ PATCH] Fix ICE with PARM_DECL with incomplete type (PR c++/77338)

2016-08-29 Thread Jakub Jelinek
Hi! In r239289 you've done something similar for the VAR_DECL etc. case, but for PARM_DECL we can still call is_really_empty_class on incomplete types and ICE because TYPE_BINFO is NULL. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-08-29 Jakub Jelinek

[PATCH] Fix avoid_constant_pool_reference (PR middle-end/77377)

2016-08-29 Thread Jakub Jelinek
Hi! Returning c from avoid_constant_pool_reference for constant pool references is only fine if the modes match and offset is zero, otherwise if the offset is sane, we can try to simplify it as subreg. But, returning c for out of bounds offsets is always wrong, and especially if the mode doesn't

[PATCH] Fix template-params-12f.C on darwin/vxworks (PR debug/77389)

2016-08-29 Thread Jakub Jelinek
Hi! This testcase expects to find DWARF extensions, but those are disabled by default on darwin/vxworks because broken tools there don't handle debug info very well. I think the following patch (regtested on x86_64-linux and i686-linux) should fix it, but I have no access to darwin, so can't veri

[C++ PATCH] Propagate CLASSTYPE_HAS_MUTABLE from bases to derived classes (PR c++/77375)

2016-08-29 Thread Jakub Jelinek
Hi! The following testcase fails (foo is allocated in .rodata and modified) because while we clear TREE_READONLY for classes with mutable members, we don't do that if they only have bases with mutable members. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk? Wh

Re: [PATCH], Patch #7, Add PowerPC vector initialization tests

2016-08-29 Thread Michael Meissner
On Fri, Aug 26, 2016 at 08:24:40PM -0500, Segher Boessenkool wrote: > On Fri, Aug 26, 2016 at 03:29:50PM -0400, Michael Meissner wrote: > > These patches add more tests to the PowerPC vector initialization tests. > > Four > > of the tests added (#4, #5, #8, and #9) just try to do a bunch of vecto

[PTX] unbreak libgfortran

2016-08-29 Thread Nathan Sidwell
Libgfortran's configure tests cause it to think localtime_r doesn't exist, and then the build dies with an extern decl/static defn mismatch. This hardwires the expected newlib reoutines, in the same manner as mips doesn. nathan 2016-08-29 Nathan Sidwell * configure.ac (nvptx-*): Hardwire n

[PATCH, i386]: Fix PR77403, assemble failure of vinserti64x4 with -masm=intel

2016-08-29 Thread Uros Bizjak
2016-08-29 Uros Bizjak PR target/77403 * config/i386/sse.md (vec_set_lo_): Fix assembler template for intel asm dialect. (vec_set_hi_): Ditto. testsuite/ChangeLog: 2016-08-29 Uros Bizjak PR target/77403 * gcc.target/i386/pr77403.c: New test. Bootstrapped and regre

Re: [PATCH 3/4] (v2) Introduce class edit_context

2016-08-29 Thread David Malcolm
On Sun, 2016-08-28 at 11:13 -0400, Trevor Saunders wrote: > On Wed, Aug 24, 2016 at 09:13:51PM -0400, David Malcolm wrote: > > This version removes edit_context::apply_changes and related > > functionality, retaining the ability to generate diffs. > > > > It also improves error-handling (adding a

Re: [v3 PATCH] PR libstdc++/77395

2016-08-29 Thread Ville Voutilainen
On 29 August 2016 at 19:27, Ville Voutilainen wrote: > Tested for is_constructible and tuple on Linux-x64, finishing testing > the full suite on Linux-PPC64. New patch, tested with the full suite on Linux-PPC64, tests adjusted accordingly. 2016-08-29 Ville Voutilainen PR libstdc++/77395

Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)

2016-08-29 Thread Toon Moene
On 08/27/2016 10:15 PM, Janne Blomqvist wrote: On Sat, Aug 27, 2016 at 9:50 PM, Paul Richard Thomas wrote: Although we have said that we would commit on Monday if no review is forthcoming, we would very much prefer that somebody takes a look. We understand perfectly that a 4052 line patch i

[committed] make_location: ensure end-points are pure locations

2016-08-29 Thread David Malcolm
On Mon, 2016-08-29 at 08:50 -0400, David Malcolm wrote: > On Mon, 2016-08-29 at 13:44 +0200, Marek Polacek wrote: > > On Mon, Aug 29, 2016 at 12:35:38PM +0200, Marek Polacek wrote: > > > On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andreas Schwab wrote: > > > > On Aug 25 2016, Marek Polacek wrote: >

Re: PR35503 - warn for restrict pointer (-Wrestrict)

2016-08-29 Thread Jason Merrill
On Mon, Aug 29, 2016 at 10:28 AM, Marek Polacek wrote: > On Mon, Aug 29, 2016 at 09:20:53AM -0400, Eric Gallager wrote: >> I tried this patch on my fork of gdb-binutils and got a few warnings >> from it. Would it be possible to have the caret point to the argument >> mentioned, instead of the func

[PATCH] df: Keep return address register undefined until epilogue_completed

2016-08-29 Thread Segher Boessenkool
For separate shrink-wrapping we need to find out which basic blocks need what components set up by a prologue, so that we can move those prologue pieces deeper into the function, so that those pieces are executed less frequently, improving performance. To do this, target code will normally look at

Re: [PATCH] Fix PR64078

2016-08-29 Thread Bernd Edlinger
Thanks! Actually my patch missed to fix one combination: -m32 with -fpic make check-gcc-c++ RUNTESTFLAGS="ubsan.exp=object-size-9.c --tool_opts '-m32 -fpic'" FAIL: c-c++-common/ubsan/object-size-9.c -O2 execution test FAIL: c-c++-common/ubsan/object-size-9.c -O2 -flto -fno-use-linker-plugi

C++ PATCH for c++/77379 (abi_tag on thunk)

2016-08-29 Thread Jason Merrill
Another missing ABI tag, sigh. Tested x86_64-pc-linux-gnu, applying to trunk. commit 1337a943a2d3926537b63d6e1f0d7f46ef10a06d Author: Jason Merrill Date: Fri Aug 26 15:12:52 2016 -0400 PR c++/77379 - ABI tag on thunk * mangle.c (maybe_check_abi_tags): Add version parm, han

Re: [PATCH] PR fortran/77372

2016-08-29 Thread Steven G. Kargl
G. Kargl > >> > > >> > PR fortran/77372 > >> > gfortran.dg/pr77372.f90: New test. > >> > >> FAIL: gfortran.dg/pr77372.f90 -O (test for excess errors) > >> Excess errors: > >> /usr/local/gcc/gcc-20160829/gcc/testsuite/gfortran.dg/

[v3 PATCH] PR libstdc++/77395

2016-08-29 Thread Ville Voutilainen
Tested for is_constructible and tuple on Linux-x64, finishing testing the full suite on Linux-PPC64. 2016-08-29 Ville Voutilainen PR libstdc++/77395 * include/std/type_traits (is_constructible): Forward-declare... (__is_base_to_derived_ref): ...and use here. * testsuite/20_util

Re: [PATCH, PR71602, 4/4] Make canonical_va_list_type more strict

2016-08-29 Thread Tom de Vries
On 29/08/16 17:51, Joseph Myers wrote: On Wed, 24 Aug 2016, Tom de Vries wrote: This patch fixes PR71602 by making canonical_va_list_type more strict. Bootstrapped and reg-tested on x86_64. OK for trunk, 6-branch? ENOPATCH Patch attached this time. Thanks, - Tom Make canonical_va_list_t

Re: [x86] Don't use builtins for unaligned load/store

2016-08-29 Thread Marc Glisse
On Mon, 29 Aug 2016, Uros Bizjak wrote: On Mon, Aug 29, 2016 at 5:22 PM, Marc Glisse wrote: On Mon, 29 Aug 2016, Kirill Yukhin wrote: On 29.08.2016 14:58, Marc Glisse wrote: this patch gets rid of a few more builtins (well, I actually kept them, since Ada users may still need them). I had

Re: [PATCH] avoid -Wmissing-format-attribute for functions that use literal formats

2016-08-29 Thread Joseph Myers
On Tue, 23 Aug 2016, Martin Sebor wrote: > The attached patch refines the logic used to suggest the format > attribute to filter out functions that use string literals and > constants as formats. > > This change has the effect of not suggesting the attribute for > functions like the one below (si

Re: [PATCH, PR71602, 4/4] Make canonical_va_list_type more strict

2016-08-29 Thread Joseph Myers
On Wed, 24 Aug 2016, Tom de Vries wrote: > This patch fixes PR71602 by making canonical_va_list_type more strict. > > Bootstrapped and reg-tested on x86_64. > > OK for trunk, 6-branch? ENOPATCH -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH, 3/4] Fix assert in build_va_arg, case 2b

2016-08-29 Thread Joseph Myers
On Wed, 24 Aug 2016, Tom de Vries wrote: > Hi, > > this patch fixes an assert in build_va_arg. Instead of testing for pointer > equality, we use the same test as is used in std_canonical_va_list_type. > > Bootstrapped and reg-tested on x86_64. > > OK for trunk? OK. -- Joseph S. Myers jos...@

Re: [PATCH, 2/4] Replace error_at with assert in build_va_arg

2016-08-29 Thread Joseph Myers
On Wed, 24 Aug 2016, Tom de Vries wrote: > Hi, > > at the start of build_va_arg, we error out if there's an invalid va_list > argument. > > Therefore, the following checks on va_list type are not user errors, but > internal errors. > > This patch changes the user errors into internal errors. >

Re: [PATCH, 1/4] Handle errors in both args of va_arg

2016-08-29 Thread Joseph Myers
On Wed, 24 Aug 2016, Tom de Vries wrote: > This patch makes sure that both errors are given for the last example, by > moving the error call from gimplify_va_arg_expr to build_va_arg. OK. -- Joseph S. Myers jos...@codesourcery.com

Re: Make max_align_t respect _Float128

2016-08-29 Thread Joseph Myers
On Mon, 29 Aug 2016, Marek Polacek wrote: > On Fri, Aug 26, 2016 at 02:51:38PM -0700, Paul Eggert wrote: > > > Well, the patch could use __SIZEOF_FLOAT128__ just as well as __i386__ > > > (the effect would be an extra union member > > > > s/union/struct/. Though I've always wondered why it is a s

Re: Fix bogus warning with -Wlogical-not-parentheses (PR c/77292)

2016-08-29 Thread Joseph Myers
On Fri, 26 Aug 2016, Marek Polacek wrote: > 2016-08-26 Marek Polacek > > PR c/77292 > * c-common.c (warn_logical_not_parentheses): Don't warn for > a comparison or a logical operator. > > * c-c++-common/Wlogical-not-parentheses-1.c: New test. OK. -- Joseph S. Myers

Re: [x86] Don't use builtins for unaligned load/store

2016-08-29 Thread Uros Bizjak
On Mon, Aug 29, 2016 at 5:22 PM, Marc Glisse wrote: > On Mon, 29 Aug 2016, Kirill Yukhin wrote: > >> On 29.08.2016 14:58, Marc Glisse wrote: >>> >>> this patch gets rid of a few more builtins (well, I actually kept them, >>> since Ada users may still need them). I had to tweak the flags for >>> pr

Re: Implement -Wimplicit-fallthrough (version 7)

2016-08-29 Thread Marek Polacek
On Mon, Aug 29, 2016 at 10:41:57AM -0400, David Malcolm wrote: > Thanks. So presumably you have something like: > > ... case something: > 353 if (*(unsigned int *)c->var == UINT_MAX) > 354{ > 355 > 356/* various code here */ > 357} > 358 > 359 case var_zi

Re: [x86] Don't use builtins for unaligned load/store

2016-08-29 Thread Marc Glisse
On Mon, 29 Aug 2016, Kirill Yukhin wrote: On 29.08.2016 14:58, Marc Glisse wrote: this patch gets rid of a few more builtins (well, I actually kept them, since Ada users may still need them). I had to tweak the flags for pr59539-2.c, otherwise the compiler thinks it is more efficient to split

Re: [PATCH] PR fortran/77372

2016-08-29 Thread Andreas Schwab
New test. >> >> FAIL: gfortran.dg/pr77372.f90 -O (test for excess errors) >> Excess errors: >> /usr/local/gcc/gcc-20160829/gcc/testsuite/gfortran.dg/pr77372.f90:3:7: Fatal >> Error: Can't open module file 'ieee_arithmetic.mod' for reading at (1): No >

Re: [PATCH] PR fortran/77372

2016-08-29 Thread Steve Kargl
t for excess errors) > Excess errors: > /usr/local/gcc/gcc-20160829/gcc/testsuite/gfortran.dg/pr77372.f90:3:7: Fatal > Error: Can't open module file 'ieee_arithmetic.mod' for reading at (1): No > such file or directory > compilation terminated. > Does it FAIL if you move the test into the gfortran.dg/ieee directory? -- Steve

Re: [x86] Don't use builtins for unaligned load/store

2016-08-29 Thread Kirill Yukhin
Hello, On 29.08.2016 14:58, Marc Glisse wrote: Hello, this patch gets rid of a few more builtins (well, I actually kept them, since Ada users may still need them). I had to tweak the flags for pr59539-2.c, otherwise the compiler thinks it is more efficient to split the loads, reading 128 bits

[build] Add missing dummy command for gcov-iov.h

2016-08-29 Thread Eric Botcazou
Makefile.in contains a lengthy comment explaining the strategy for timestamp files associated with generated files; in particular, it explains that a dummy command is needed for 'make' not to think the generated file is unchanged. We experienced strange rebuilds at installation time on a recent

Re: Implement -Wimplicit-fallthrough (version 7)

2016-08-29 Thread David Malcolm
On Mon, 2016-08-29 at 10:04 -0400, Eric Gallager wrote: > On 8/29/16, David Malcolm wrote: > > On Mon, 2016-08-29 at 09:32 -0400, Eric Gallager wrote: > > > On 8/29/16, Marek Polacek wrote: > > > > Tobias tried my latest version and reported some ICEs. They > > > > should > > > > all be > > > >

Re: [PATCH 1/9] separate shrink-wrap: New command-line flag, status flag, hooks, and doc

2016-08-29 Thread Segher Boessenkool
On Mon, Aug 29, 2016 at 11:31:51AM +0200, Bernd Schmidt wrote: > On 08/01/2016 03:42 AM, Segher Boessenkool wrote: > >+@deftypefn {Target Hook} void TARGET_SHRINK_WRAP_EMIT_PROLOGUE_COMPONENTS > >(sbitmap) > >+Emit prologue insns for the components indicated by the parameter. > >+@end deftypefn >

Re: PR35503 - warn for restrict pointer

2016-08-29 Thread Marek Polacek
On Mon, Aug 29, 2016 at 04:25:25PM +0200, Tobias Burnus wrote: > Prathamesh Kulkarni wrote: > > Attachment: pr35503-3.txt > > I tried the patch - and it found a bug in our code; nice! > > > (a) Regarding the [-Werror] output: > >error: passing argument 24 to restrict qualified parameter ali

Re: PR35503 - warn for restrict pointer (-Wrestrict)

2016-08-29 Thread Marek Polacek
On Mon, Aug 29, 2016 at 09:20:53AM -0400, Eric Gallager wrote: > I tried this patch on my fork of gdb-binutils and got a few warnings > from it. Would it be possible to have the caret point to the argument > mentioned, instead of the function name? And also print the option > name? E.g., instead of

[testsuite] XFAIL gcc.dg/ipa/iinline-attr.c on Visium

2016-08-29 Thread Eric Botcazou
The test doesn't pass because of missing support for attribute __optimize__ in the Visium back-end. Tested on visium-elf, applied on the mainline and 6 branch. 2016-08-29 Eric Botcazou * gcc.dg/ipa/iinline-attr.c: XFAIL on Visium. -- Eric BotcazouIndex: gcc.dg/ipa/iinline-attr.c =

Re: PR35503 - warn for restrict pointer

2016-08-29 Thread Tobias Burnus
Prathamesh Kulkarni wrote: > Attachment: pr35503-3.txt I tried the patch - and it found a bug in our code; nice! (a) Regarding the [-Werror] output: error: passing argument 24 to restrict qualified parameter aliases with argument 29 [-Werror] Shouldn't that output "[-Werror=restrict]" inst

Re: PR35503 - warn for restrict pointer

2016-08-29 Thread Marek Polacek
On Sun, Aug 28, 2016 at 06:32:59PM +0530, Prathamesh Kulkarni wrote: > On 26 August 2016 at 21:25, Jason Merrill wrote: > > On Fri, Aug 26, 2016 at 7:39 AM, Prathamesh Kulkarni > > wrote: > >> However with C++FE it appears TYPE_RESTRICT is not set for the > >> parameters (buf and fmt) > >> and he

Re: Implement -Wimplicit-fallthrough (version 7)

2016-08-29 Thread Eric Gallager
On 8/29/16, David Malcolm wrote: > On Mon, 2016-08-29 at 09:32 -0400, Eric Gallager wrote: >> On 8/29/16, Marek Polacek wrote: >> > Tobias tried my latest version and reported some ICEs. They should >> > all be >> > fixed in this version (the only change since version 6 is the >> > cp/pt.c >> >

Re: Implement -Wimplicit-fallthrough (version 7)

2016-08-29 Thread David Malcolm
On Mon, 2016-08-29 at 09:32 -0400, Eric Gallager wrote: > On 8/29/16, Marek Polacek wrote: > > Tobias tried my latest version and reported some ICEs. They should > > all be > > fixed in this version (the only change since version 6 is the > > cp/pt.c > > hunk). > > > > At this point I'd like to

Re: Implement -Wimplicit-fallthrough (version 7)

2016-08-29 Thread Eric Gallager
On 8/29/16, Marek Polacek wrote: > Tobias tried my latest version and reported some ICEs. They should all be > fixed in this version (the only change since version 6 is the cp/pt.c > hunk). > > At this point I'd like to ask Jason and Joseph to review the C/C++ parts > and someone to review the ME

Re: Make max_align_t respect _Float128

2016-08-29 Thread Marek Polacek
On Fri, Aug 26, 2016 at 02:51:38PM -0700, Paul Eggert wrote: > > Well, the patch could use __SIZEOF_FLOAT128__ just as well as __i386__ > > (the effect would be an extra union member > > s/union/struct/. Though I've always wondered why it is a struct and not a > union. Maybe change it to union whi

Re: PR35503 - warn for restrict pointer (-Wrestrict)

2016-08-29 Thread Eric Gallager
On 8/28/16, Prathamesh Kulkarni wrote: > On 26 August 2016 at 21:25, Jason Merrill wrote: >> On Fri, Aug 26, 2016 at 7:39 AM, Prathamesh Kulkarni >> wrote: >>> However with C++FE it appears TYPE_RESTRICT is not set for the >>> parameters (buf and fmt) >>> and hence the warning doesn't get emitte

Re: Add fixit hint for -Wlogical-not-parentheses

2016-08-29 Thread David Malcolm
On Mon, 2016-08-29 at 13:44 +0200, Marek Polacek wrote: > On Mon, Aug 29, 2016 at 12:35:38PM +0200, Marek Polacek wrote: > > On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andreas Schwab wrote: > > > On Aug 25 2016, Marek Polacek wrote: > > > > > > > * c-c++-common/Wlogical-not-parentheses-2.c

[PTX] fix build

2016-08-29 Thread Nathan Sidwell
I've committed this to fix trunk build breakage for PTX targets. nathan 2016-08-29 Nathan Sidwell * config/nvptx/nvptx.c: #include tree-vrp.h. Index: config/nvptx/nvptx.c === --- config/nvptx/nvptx.c(revision 239

Ping! Re: [PATCH, Fortran] Extension: AUTOMATIC/STATIC symbol attributes with -fdec-static

2016-08-29 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00077.html On Wed, Aug 17, 2016 at 7:20 AM, Fritz Reese wrote: > This patch extends the GNU Fortran front-end to add support for > DEC-style AUTOMATIC and STATIC symbol attributes with a new flag > -fdec-static, allowing explicit control of variable storag

[committed] Re: [PATCH, Fortran] Fix compare logic for anonymous structure types

2016-08-29 Thread Fritz Reese
https://gcc.gnu.org/ml/fortran/2016-08/msg00145.html On Wed, Aug 24, 2016 at 5:32 PM, Fritz Reese wrote: > https://gcc.gnu.org/ml/fortran/2016-08/msg00144.html > > On Wed, Aug 24, 2016 at 5:14 PM, Fritz Reese wrote: >> With a few recent notes by others, I have identified that the >> comparison lo

Implement -Wimplicit-fallthrough (version 7): add gcc_fallthrough()

2016-08-29 Thread Marek Polacek
A rebased version, nothing has really changed since the last time. 2016-08-29 Marek Polacek PR c/7652 * Makefile.in (insn-attrtab.o-warn, insn-dfatab.o-warn, insn-latencytab.o-warn, insn-output.o-warn, insn-emit.o-warn): Add -Wno-switch-fallthrough. * bu

Implement -Wimplicit-fallthrough (version 7)

2016-08-29 Thread Marek Polacek
Tobias tried my latest version and reported some ICEs. They should all be fixed in this version (the only change since version 6 is the cp/pt.c hunk). At this point I'd like to ask Jason and Joseph to review the C/C++ parts and someone to review the ME parts so that I can finally wrap this thing

[x86] Don't use builtins for unaligned load/store

2016-08-29 Thread Marc Glisse
Hello, this patch gets rid of a few more builtins (well, I actually kept them, since Ada users may still need them). I had to tweak the flags for pr59539-2.c, otherwise the compiler thinks it is more efficient to split the loads, reading 128 bits at a time. This still breaks one testcase: avx

Re: Add fixit hint for -Wlogical-not-parentheses

2016-08-29 Thread Marek Polacek
On Mon, Aug 29, 2016 at 12:35:38PM +0200, Marek Polacek wrote: > On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andreas Schwab wrote: > > On Aug 25 2016, Marek Polacek wrote: > > > > > * c-c++-common/Wlogical-not-parentheses-2.c: New test. > > > > FAIL: c-c++-common/Wlogical-not-parentheses-2.c -s

Re: [PATCH build/doc] Replacing libiberty with gnulib

2016-08-29 Thread Joseph Myers
On Sun, 28 Aug 2016, ayush goel wrote: > > > +AUTOCONF_VERSION="2.69" > > > +AUTOMAKE_VERSION="1.15" > > > +ACLOCAL_VERSION="$AUTOMAKE_VERSION" > > > + > > > > Is there a reason these need to be different from what the rest > > of the toolchain uses? > > Not really, these were just the newer vers

Re: [RFC] ipa bitwise constant propagation

2016-08-29 Thread Christophe Lyon
On 26 August 2016 at 19:22, Prathamesh Kulkarni wrote: > On 26 August 2016 at 21:53, Rainer Orth wrote: >> Hi Prathamesh, >> >>> The attached version passes bootstrap+test on >>> x86_64-unknown-linux-gnu, ppc64le-linux-gnu, >>> and with c,c++,fortran on armv8l-linux-gnueabihf. >>> Cross-tested on

Re: Add fixit hint for -Wlogical-not-parentheses

2016-08-29 Thread Marek Polacek
On Mon, Aug 29, 2016 at 11:16:25AM +0200, Andreas Schwab wrote: > On Aug 25 2016, Marek Polacek wrote: > > > * c-c++-common/Wlogical-not-parentheses-2.c: New test. > > FAIL: c-c++-common/Wlogical-not-parentheses-2.c -std=gnu++11 expected > multiline pattern lines 13-17 not found: "\s*r \+

Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)

2016-08-29 Thread Paul Richard Thomas
Hi Janne, Andre, Jerry and All, I am perfectly happy to adopt Janne's suggestion for st_set_(dtio_)nml_var. Do the changes to the IO structures have any impact? These are in: fnode, st_parameter_dt & gfc_unit I don't think that these should be visible but I want expert opinion before making that

Re: [MPX] Fix for PR77267

2016-08-29 Thread Ilya Enkovich
2016-08-25 12:27 GMT+03:00 Alexander Ivchenko : > The attached patched fixes the usage of MPX in presence of > "-Wl,-as-needed" option. 'make checked' on MPX-enabled machine. > > "--push-state" and "--pop-state" are not supported by gold at the > moment. But that's OK because using MPX with gold on

Re: [PATCH 1/9] separate shrink-wrap: New command-line flag, status flag, hooks, and doc

2016-08-29 Thread Bernd Schmidt
On 08/01/2016 03:42 AM, Segher Boessenkool wrote: +@deftypefn {Target Hook} void TARGET_SHRINK_WRAP_EMIT_PROLOGUE_COMPONENTS (sbitmap) +Emit prologue insns for the components indicated by the parameter. +@end deftypefn + +@deftypefn {Target Hook} void TARGET_SHRINK_WRAP_EMIT_EPILOGUE_COMPONENTS

Re: [PATCH] report supported function classes correctly on *-musl

2016-08-29 Thread Bernd Schmidt
On 07/20/2016 03:39 PM, Szabolcs Nagy wrote: All function classes listed in gcc/coretypes.h are supported by musl. Most of the optimizations based on these function classes are not relevant for standard conform c code, but this is required to get rid of some test system noise. gcc/ 2016-07-20

Re: [PATCH] disable ifunc on *-musl by default

2016-08-29 Thread Bernd Schmidt
On 07/20/2016 03:37 PM, Szabolcs Nagy wrote: Musl libc does not support gnu ifunc, so disable it by default. (not disabled on s390-* since that has no musl support yet.) gcc/ 2016-07-20 Szabolcs Nagy * config.gcc (*-*-*musl*): Disable gnu-indirect-function. Ok I suppose? I'm assumi

Re: [PATCH] Fix PR69047

2016-08-29 Thread Andreas Schwab
On Aug 26 2016, Richard Biener wrote: > Index: gcc/testsuite/gcc.dg/pr69047.c > === > --- gcc/testsuite/gcc.dg/pr69047.c(revision 0) > +++ gcc/testsuite/gcc.dg/pr69047.c(working copy) > @@ -0,0 +1,18 @@ > +/* { dg-do compile

Re: Add fixit hint for -Wlogical-not-parentheses

2016-08-29 Thread Andreas Schwab
On Aug 25 2016, Marek Polacek wrote: > * c-c++-common/Wlogical-not-parentheses-2.c: New test. FAIL: c-c++-common/Wlogical-not-parentheses-2.c -std=gnu++11 expected multiline pattern lines 13-17 not found: "\s*r \+= !aaa == bbb;.*\n \^~\n r \+= !aaa == bbb;.*\n\^~~

Re: [PATCH] PR fortran/77372

2016-08-29 Thread Andreas Schwab
On Aug 26 2016, Steve Kargl wrote: > 2016-08-25 Steven G. Kargl > > PR fortran/77372 > gfortran.dg/pr77372.f90: New test. FAIL: gfortran.dg/pr77372.f90 -O (test for excess errors) Excess errors: /usr/local/gcc/gcc-20160829/gcc/testsuite/gfortran.dg/pr77372.f90:3:7:

Re: [PATCH 1/2] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-08-29 Thread Pierre-Marie de Rodat
Here is another attempt to solve the original issue. This time, with a proper testcase. ;-) Rebased against trunk, boostrapped and regtested on x86_64-linux. gcc/ * dwarf2out.c (process_scope_var): Relocate DIEs for TYPE_DECL nodes that are not stubs. (gen_decl_die): For TYPE_DECLs

Re: [PATCH] selftest.h: mark failure functions with ATTRIBUTE_NORETURN.

2016-08-29 Thread Bernd Schmidt
On 08/26/2016 08:20 PM, David Malcolm wrote: Is this revised version OK for trunk? LGTM. Bernd

Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)

2016-08-29 Thread Janne Blomqvist
On Mon, Aug 29, 2016 at 11:15 AM, Andre Vehreschild wrote: > Hi all, > >> Anyway, a small nit I found was the function st_set_nml_var in >> libgfortran. This is an exported function, and thus part of the ABI. >> So you cannot add arguments to it, as that would break backwards >> compatibility. > >

Re: Ping : [Patch, fortran] PR48298 - [F03] User-Defined Derived-Type IO (DTIO)

2016-08-29 Thread Andre Vehreschild
Hi all, > Anyway, a small nit I found was the function st_set_nml_var in > libgfortran. This is an exported function, and thus part of the ABI. > So you cannot add arguments to it, as that would break backwards > compatibility. Please explain the above. I was of the opinion, that when we change s

Re: [PATCH] Fix PR64078

2016-08-29 Thread Tom de Vries
On 17/09/15 20:08, Marek Polacek wrote: On Thu, Sep 17, 2015 at 08:06:48PM +0200, Bernd Edlinger wrote: Hi, On Thu, 17 Sep 2015 10:39:04, Jeff Law wrote: On 09/17/2015 09:00 AM, Marek Polacek wrote: On Wed, Sep 09, 2015 at 07:48:15PM +0200, Bernd Edlinger wrote: Hi, On Wed, 9 Sep 2015 09:3

Re: [PATCH, fortran] PR 77261 gfortran.dg/random_3.f90 failure

2016-08-29 Thread Paul Richard Thomas
Dear Janne, That's fine for trunk. Thanks for the patch. Paul On 29 August 2016 at 09:05, Janne Blomqvist wrote: > PING? > > FWIW, Rainer Orth confirmed that the fixed testcase now passes on > Solaris/SPARC. > > On Tue, Aug 23, 2016 at 4:40 PM, Janne Blomqvist > wrote: >> Hi, >> >> the attac

[PING v3] Unreviewed GCC-6 patches

2016-08-29 Thread Jakub Sejdak
Hi! I would like to ping a couple of unreviewed patches for GCC-6 branch (they are already in trunk): - Backport new Phoenix-RTOS OS name to config.sub https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01441.html - Backport support for Phoenix-RTOS targets in GCC's config for ARM platform. https://g

[patch, libgomp, OpenACC] Additional enter/exit data map handling

2016-08-29 Thread Chung-Lin Tang
Hi Jakub, this patch is a port of some changes from gomp-4_0-branch, including adding additional map type handling in OpenACC enter/exit data directives, and some pointer set handling changes. Updated testsuite case are also included. Tested on trunk to ensure no regressions, is this okay for trun

Re: [PATCH, testsuite]: Use -gdwarf-2 for g++.dg/other/anon5.C

2016-08-29 Thread Tom de Vries
On 01/02/16 23:10, Jeff Law wrote: On 02/01/2016 03:05 PM, Uros Bizjak wrote: Hello! This test case fails for targets, where dwarf-4 is unsupported (e.g. CentOS 5.11) with /usr/bin/ld: Dwarf Error: found dwarf version '4', this reader only handles version 2 information. We can use -gdwarf-2 h

Re: [PATCH, fortran] PR 77261 gfortran.dg/random_3.f90 failure

2016-08-29 Thread Janne Blomqvist
PING? FWIW, Rainer Orth confirmed that the fixed testcase now passes on Solaris/SPARC. On Tue, Aug 23, 2016 at 4:40 PM, Janne Blomqvist wrote: > Hi, > > the attached patch fixes PR 77261. The problem is that with the new > PRNG, the random sequence for real(16) and lesser kinds is not the > same