Re: [C/C++ PATCH] Don't emit invalid VEC_COND_EXPR for vector comparisons (PR c/68062)

Ping. On Wed, Jan 20, 2016 at 12:31:51PM +0100, Marek Polacek wrote: > On Wed, Jan 13, 2016 at 11:11:52PM +, Joseph Myers wrote: > > The C front-end changes are OK. > > Jason, is the C++ part of this patch here > > (which is identical

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

On 01/18/2016 11:27 AM, Ajit Kumar Agarwal wrote: Ajit, can you confirm which of adpcm_code or adpcm_decode where path splitting is showing a gain? I suspect it's the former but would like to make sure so that I can adjust the heuristics properly. I'd still like to have this answered when you

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

On 01/18/2016 02:13 AM, Ajit Kumar Agarwal wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Saturday, January 16, 2016 12:03 PM To: Ajit Kumar Agarwal; Richard Biener Cc: GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subjec

Re: [PATCH 4/5] Don't mark targets of unconditional jumps with side effects as FALLTHRU.

On 01/22/2016 12:44 AM, Andreas Krebbel wrote: On 01/22/2016 12:10 AM, Jeff Law wrote: On 01/21/2016 03:05 AM, Andreas Krebbel wrote: On 01/02/2016 08:16 PM, Marcin Kościelnicki wrote: When an unconditional jump with side effects targets an immediately following label, rtl_tidy_fallthru_edge i

Re: Suspicious code in fold-const.c

On 01/22/2016 10:21 AM, Bernd Schmidt wrote: On 01/22/2016 02:37 PM, Andrew MacLeod wrote: /* If the initializer is non-void, then it's a normal expression that will be assigned to the slot. */ (*) if (!VOID_TYPE_P (t)) (*) return RECURSE (t); I suspect

Re: Suspicious code in fold-const.c

On 01/22/2016 04:03 AM, Richard Biener wrote: My guess is this is probably suppose to be && ! VOID_TYPE_P (TREE_TYPE (TREE_OPERAND (tem, 1))) && ! VOID_TYPE_P (TREE_TYPE (TREE_OPERAND (tem, 2))) but I'm not sure. Any guesses whats intended here? Not sure, it might be to detect some of the

Re: [PATCH] Fix PR69336

On Tue, Jan 19, 2016 at 10:08:17AM +0100, Richard Biener wrote: > > The following patch enhances the recent change to DOMs memory reference > value-numbering to cover PR69336 (all handled components instead of > just ones with outermost ARRAY_REF). > > Bootstrapped and tested on x86_64-unknown-li

Re: [PATCH] fix #69317 - [6 regression] wrong ABI version in -Wabi warnings

On 01/25/2016 09:56 AM, Martin Sebor wrote: Ping: I'm looking a review/approval of the almost trivial patch below: https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01206.html On 01/16/2016 05:42 PM, Martin Sebor wrote: While adding an ABI warning in the patch for bug 69277 I noticed that the

Re: [wwwdocs][PATCH] Add notes on -Wmisleading-indentation to GCC 6 porting guide

On 01/26/2016 01:41 PM, David Malcolm wrote: htdocs/gcc-6/porting_to.html is looking rather empty right now. The attached patch starts fleshing it out by adding some notes on -Wmisleading-indentation. [see the notes at https://gcc.gnu.org/ml/gcc/2016-01/msg00224.html on what -Wmisleading-indent

Re: RFA: Fix for cygwin/mingw PR 66655

On 01/26/2016 07:34 AM, Nick Clifton wrote: Hi Guys, The patch below is offered as a fix for PR 66655. In testing it appears that the patch does work, and does not break building libstdc++-v3 for cygwin or mingw. (Unlike the earlier version...) Due to my brain being so small, I ha

Re: NetBSD has SSP in libc

On Tue, Jan 26, 2016 at 11:35:15PM -0700, Jeff Law wrote: > On 01/23/2016 02:52 PM, Thomas Klausner wrote: > >NetBSD has SSP included in libc: > > > >http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/ssp/?only_with_tag=MAIN > > > >gcc/configure does not know about this. The attached patch (against >

Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu

Ping? On Monday, January 18, 2016 11:33:47 AM Thomas Preud'homme wrote: > On Wednesday, January 13, 2016 06:39:20 PM Bernd Schmidt wrote: > > On 01/12/2016 08:55 AM, Thomas Preud'homme wrote: > > > On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote: > > >> On 01/08/2016 10:33 AM, Thomas P

Re: NetBSD has SSP in libc

On 01/23/2016 02:52 PM, Thomas Klausner wrote: NetBSD has SSP included in libc: http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/ssp/?only_with_tag=MAIN gcc/configure does not know about this. The attached patch (against SVN checkout from today) fixes this. I've previously reported this as htt

Re: new port: vn8

Hello Mike Stump, Thanks for your comment. I'll remove all of redundant code for this target. I wonder that what paper is? Is it an introduction about new feature in our target? On Wed, Jan 27, 2016 at 5:53 AM, Mike Stump wrote: > I don’t see the point of libgcc/config/vn8/test.patch. I suspec

Re: C++ PATCH for c++/69496 (ICE on VLA in constexpr function)

On 01/26/2016 04:02 PM, Marek Polacek wrote: The (invalid) testcase was causing an ICE because we were passing the result of array_type_nelts_top immediately into tree_int_cst_lt, but for VLAs, the result doesn't have to be a constant. Fixed by evaluating the bound of the array so that we're abl

Re: [PATCH 1/3] [D] libiberty: Correctly decode function pointer types.

On 27 January 2016 at 01:49, Ian Lance Taylor wrote: > On Tue, Jan 26, 2016 at 4:30 PM, Iain Buclaw wrote: >> >> This patch series ultimately supports recent support for >> extern(Objective-C) functions. However this simple addition exposed >> two nasty bugs in the process. >> >> This addresses

Re: [PATCH 1/3] [D] libiberty: Correctly decode function pointer types.

On Tue, Jan 26, 2016 at 4:30 PM, Iain Buclaw wrote: > > This patch series ultimately supports recent support for > extern(Objective-C) functions. However this simple addition exposed > two nasty bugs in the process. > > This addresses demangling function types. In real symbols, function > types

Re: [PATCH 3/3] [D] libiberty: Handle the new extern(Objective-C) calling convention

On Tue, Jan 26, 2016 at 4:41 PM, Iain Buclaw wrote: > Finally, recognizing the extern(Objective-C) symbol 'Y'. This is OK. Thanks. Ian

[PATCH 3/3] [D] libiberty: Handle the new extern(Objective-C) calling convention

Finally, recognizing the extern(Objective-C) symbol 'Y'. Iain. --- libiberty/ 2016-01-26 Iain Buclaw * d-demangle.c (dlang_call_convention): Handle extern Objective-C function calling convention. (dlang_call_convention_p): Likewise. (dlang_type): Likewise. * testsuite/d-demangle-expect

Re: [PATCH 2/3] [D] libiberty: Fix demangling of D-style variadic functions

On Tue, Jan 26, 2016 at 4:36 PM, Iain Buclaw wrote: > This one fixes support for D-style variadic functions, specifically > where non-variadic parameters can be omitted entirely. This is OK. Thanks. Ian

[PATCH 2/3] [D] libiberty: Fix demangling of D-style variadic functions

This one fixes support for D-style variadic functions, specifically where non-variadic parameters can be omitted entirely. Iain --- libiberty/ 2016-01-26 Iain Buclaw * d-demangle.c (dlang_function_args): Append ',' for variadic functions only if parameters were seen before the elipsis sym

[PATCH 1/3] [D] libiberty: Correctly decode function pointer types.

Hi, This patch series ultimately supports recent support for extern(Objective-C) functions. However this simple addition exposed two nasty bugs in the process. This addresses demangling function types. In real symbols, function types are only ever seen following the pointer type symbol 'P'. So

Go patch committed: Don't crash on erroneous array return types

This patch by Chris Manghane avoids a Go frontend crash on an erroneous array return type. This fixes https://golang.org/issue/12939. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE =

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On Tue, Jan 26, 2016 at 01:55:41PM -0800, Mike Stump wrote: > On Jan 26, 2016, at 1:26 PM, Jakub Jelinek wrote: > > will do cc1plus size comparison afterwards. > > We know the dynamic check is larger. You can’t tell the advantage of > speed from size. Better would be to time compiling any rando

Re: Wonly-top-basic-asm

On 1/26/2016 8:11 AM, Segher Boessenkool wrote: On Tue, Jan 26, 2016 at 01:11:36PM +0100, Bernd Schmidt wrote: On 01/26/2016 01:29 AM, Segher Boessenkool wrote: In my opinion we should not warn for any asm that means the same both as basic and as extended asm. The problem then becomes, what *

gccgo patch committed: Don't crash on invalid array type declarations

This patch by Chris Manghane fixes the Go frontend to not crash on an invalid array type declaration that is not otherwise used. This fixes https://golang.org/issue/12937. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE ===

C++ PATCH for c++/69496 (ICE on VLA in constexpr function)

The (invalid) testcase was causing an ICE because we were passing the result of array_type_nelts_top immediately into tree_int_cst_lt, but for VLAs, the result doesn't have to be a constant. Fixed by evaluating the bound of the array so that we're able to give a proper out-of-bounds diagnostics.

new port: vn8

I don’t see the point of libgcc/config/vn8/test.patch. I suspect either you need to apply it to your diffs before you send them out, or remove the file a junk from the diff set. I saw: inflating: libgcc/config/vn8/lib1funcs-fixed.S inflating: libgcc/config/vn8/lib1funcs-fixed.S.old i

[testsuite] XFAIL gcc.c-torture/execute/stkalign.c on SPARC 64-bit

This test is very convoluted, doesn't contain a single line of comment and apparently makes an invalid assumption (see PR testsuite/68886). Tested on x86-64/Linux and SPARC64/Solaris, applied on the mainline. 2016-01-26 Eric Botcazou * gcc.c-torture/execute/stkalign.c: XFAIL run on

Re: [PATCH, 4.9, rs6000, testsuite] Fix PR69479

On Tue, Jan 26, 2016 at 4:46 PM, Bill Schmidt wrote: > Hi, > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69479 notes that > gcc.dg/and-1.c fails a scan-assembler-not test for nand, but the test > does pass in subsequent releases. The test author indicates in comment > #1 that we can just remov

gccgo patch committed: avoid knock-on errors with impossibly large types

This patch by Chris Manghane patches the Go frontend to avoid knock-on errors when working with impossibly large types. This fixes https://golang.org/issue/12938. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE

Re: [gomp4] Un-parallelized OpenACC kernels constructs with nvptx offloading: "avoid offloading"

On Fri, Jan 22, 2016 at 02:18:38PM +0100, Bernd Schmidt wrote: > On 01/22/2016 09:36 AM, Jakub Jelinek wrote: > > > >I think it is a bad idea to go against what the user wrote. Warning that > >some code might not be efficient? Perhaps (if properly guarded with some > >warning option one can turn

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On Tue, Jan 26, 2016 at 1:40 PM, Jakub Jelinek wrote: > On Tue, Jan 26, 2016 at 01:21:52PM -0800, H.J. Lu wrote: >> Like this: >> >> /* Returns true if TYPE is POD for the purpose of layout and an empty >>class or an class with empty classes. */ >> >> static bool >> is_empty_record (tree type

Re: [Patch, fortran] PR69385 - [6 regression] ICE on valid with -fcheck=mem

Dear Janus, Thanks - committed as revision 232850. I hope that this signals your return - we need your help! Paul On 25 January 2016 at 22:13, Janus Weil wrote: > Hi Paul, > > seems we were pretty well-synchronized in posting this (in the PR it > sounded as if you wanted me to submit it ...) >

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On Jan 26, 2016, at 1:26 PM, Jakub Jelinek wrote: > will do cc1plus size comparison afterwards. We know the dynamic check is larger. You can’t tell the advantage of speed from size. Better would be to time compiling any random large translation unit. Nice to see that only 14 calls remain, tha

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On Jan 26, 2016, at 12:45 PM, Richard Biener wrote: > The original reasoning was to inline only the fast path if it is known at > compile time and otherwise have a call. Exactly to avoid bloating callers > with inlined conditionals. That’s part of it. And generally, yes, we do that. One other

[PATCH, 4.9, rs6000, testsuite] Fix PR69479

Hi, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69479 notes that gcc.dg/and-1.c fails a scan-assembler-not test for nand, but the test does pass in subsequent releases. The test author indicates in comment #1 that we can just remove this test for powerpc*-*-*, which this patch does. Verified fo

GCC 5 libgo patch committed: Update mksysinfo on GCC 5 branch

I've committed this patch to the GCC 5 branch to update libgo/mksysinfo.sh to bring in recent changes on mainline. This brings in https://golang.org/cl/17893, https://golang.org/cl/16588, https://golang.org/cl/16580, https://golang.org/cl/16534, https://golang.org/cl/14858. The patch was put toge

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On Tue, Jan 26, 2016 at 01:21:52PM -0800, H.J. Lu wrote: > Like this: > > /* Returns true if TYPE is POD for the purpose of layout and an empty >class or an class with empty classes. */ > > static bool > is_empty_record (tree type) > { > if (type == error_mark_node) > return false; >

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On Tue, Jan 26, 2016 at 09:45:19PM +0100, Richard Biener wrote: > On January 26, 2016 8:00:52 PM GMT+01:00, Mike Stump > wrote: > >On Jan 26, 2016, at 10:21 AM, Jakub Jelinek wrote > >> The question is, shall we do what wi::lshift does and have the fast > >path > >> only for the constant shifts,

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On Tue, Jan 26, 2016 at 12:44 PM, Marc Glisse wrote: > On Tue, 26 Jan 2016, H.J. Lu wrote: > >> On Tue, Jan 26, 2016 at 12:23 PM, Marc Glisse >> wrote: >>> >>> On Tue, 26 Jan 2016, H.J. Lu wrote: >>> On Tue, Jan 26, 2016 at 11:27 AM, Jason Merrill wrote: > > > On 12/14/2015

Is it OK for rtx_addr_can_trap_p_1 to attempt to compute the frame layout? (was Re: [PATCH] Skip re-computing the mips frame info after reload completed)

[cc-ing Eric as RTL maintainer] Matthew Fortune writes: > Bernd Edlinger writes: >> Matthew Fortune writes: >> > Has the patch been tested beyond just building GCC? I can do a >> > test run for you if you don't have things set up to do one yourself. >> >> I built a cross-gcc with all languages

Re: [PATCH] Handle -fsanitize=* in lto-wrapper (PR lto/69254)

On Tue, Jan 26, 2016 at 04:44:39PM +0100, Jakub Jelinek wrote: > 2016-01-26 Jakub Jelinek > > PR lto/69254 > * lto-opts.c (lto_write_options): Write also -f{,no-}sanitize= > options. > * lto-wrapper.c (struct lto_decoded_options): New type. > (append_option, merge_

[PATCH] [graphite] handle isl_ast_op_select

2016-01-26 Abderrazek Zaafrani Sebastian Pop * graphite-isl-ast-to-gimple.c (ternary_op_to_tree): Handle isl_ast_op_cond and isl_ast_op_select. (gcc_expression_from_isl_expr_op): Same. * gcc.dg/graphite/isl-ast-op-select.c: New. --- gcc/graphite-i

Re: RFA (tree.c): PATCH for c++/68782 (wrong TREE_CONSTANT flag on C++ CONSTRUCTOR)

On Tue, Jan 26, 2016 at 03:46:50PM -0500, Jason Merrill wrote: > On 01/26/2016 03:32 PM, Jakub Jelinek wrote: > >>>+if (CHECKING_P) > >>>+ verify_constructor_flags (t); > >>>+else > >>>+ recompute_constructor_flags (t); > > >But I don't understand this. Either the flags are supp

Re: RFA (tree.c): PATCH for c++/68782 (wrong TREE_CONSTANT flag on C++ CONSTRUCTOR)

On 01/26/2016 03:32 PM, Jakub Jelinek wrote: >+ if (CHECKING_P) >+ verify_constructor_flags (t); >+ else >+ recompute_constructor_flags (t); But I don't understand this. Either the flags are supposed to be already correct here, then I'd expect to see if (CHECKING_P)

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On January 26, 2016 8:00:52 PM GMT+01:00, Mike Stump wrote: >On Jan 26, 2016, at 10:21 AM, Jakub Jelinek wrote >> The question is, shall we do what wi::lshift does and have the fast >path >> only for the constant shifts, as the untested patch below does, or >shall we >> check shift dynamically (

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On Tue, 26 Jan 2016, H.J. Lu wrote: On Tue, Jan 26, 2016 at 12:23 PM, Marc Glisse wrote: On Tue, 26 Jan 2016, H.J. Lu wrote: On Tue, Jan 26, 2016 at 11:27 AM, Jason Merrill wrote: On 12/14/2015 05:08 PM, H.J. Lu wrote: + if (abi_version_at_least (10)) +TYPE_EMPTY_RECORD (t) = is_r

[Patch, MIPS] Patch for PR 68400, a mips16 bug

Here is a patch for PR6400. The problem is that and_operands_ok was checking one operand to see if it was a memory_operand but MIPS16 addressing is more restrictive than what the general memory_operand allows. The fix was to call mips_classify_address if TARGET_MIPS16 is set because it will do a

[wwwdocs][PATCH] Add notes on -Wmisleading-indentation to GCC 6 porting guide

htdocs/gcc-6/porting_to.html is looking rather empty right now. The attached patch starts fleshing it out by adding some notes on -Wmisleading-indentation. [see the notes at https://gcc.gnu.org/ml/gcc/2016-01/msg00224.html on what -Wmisleading-indentation ran into on a mass-rebuild of Debian] I

Re: RFA (tree.c): PATCH for c++/68782 (wrong TREE_CONSTANT flag on C++ CONSTRUCTOR)

On Tue, Jan 26, 2016 at 03:20:04PM -0500, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu. Are the tree.c changes OK for trunk? The tree.c changes are ok. But I have nits and one bigger issue in constexpr.c: > --- a/gcc/cp/constexpr.c > +++ b/gcc/cp/constexpr.c > @@ -2214,6 +2214,9 @@ cxx_eval

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On Tue, Jan 26, 2016 at 12:23 PM, Marc Glisse wrote: > On Tue, 26 Jan 2016, H.J. Lu wrote: > >> On Tue, Jan 26, 2016 at 11:27 AM, Jason Merrill wrote: >>> >>> On 12/14/2015 05:08 PM, H.J. Lu wrote: + if (abi_version_at_least (10)) +TYPE_EMPTY_RECORD (t) = is_really_empty_

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On Tue, 26 Jan 2016, H.J. Lu wrote: On Tue, Jan 26, 2016 at 11:27 AM, Jason Merrill wrote: On 12/14/2015 05:08 PM, H.J. Lu wrote: + if (abi_version_at_least (10)) +TYPE_EMPTY_RECORD (t) = is_really_empty_class (t); This should use is_empty_class or CLASSTYPE_EMPTY_P. We don't want t

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

Jakub Jelinek writes: > On Tue, Jan 26, 2016 at 11:00:52AM -0800, Mike Stump wrote: >> On Jan 26, 2016, at 10:21 AM, Jakub Jelinek wrote >> > The question is, shall we do what wi::lshift does and have the fast path >> > only for the constant shifts, as the untested patch below does, or shall we >

RFA (tree.c): PATCH for c++/68782 (wrong TREE_CONSTANT flag on C++ CONSTRUCTOR)

The problem in this bug was that the constexpr code builds a lot of CONSTRUCTORs and then fills in the elements later without ever going back and updating TREE_CONSTANT and TREE_SIDE_EFFECTS. This patch adds middle end functions recompute_constructor_flags and verify_constructor_flags, and fix

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On Tue, Jan 26, 2016 at 11:17 AM, Jakub Jelinek wrote: > On Tue, Jan 26, 2016 at 11:00:52AM -0800, Mike Stump wrote: >> On Jan 26, 2016, at 10:21 AM, Jakub Jelinek wrote >> > The question is, shall we do what wi::lshift does and have the fast path >> > only for the constant shifts, as the unteste

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On Tue, Jan 26, 2016 at 11:27 AM, Jason Merrill wrote: > On 12/14/2015 05:08 PM, H.J. Lu wrote: >> >> + if (abi_version_at_least (10)) >> +TYPE_EMPTY_RECORD (t) = is_really_empty_class (t); > > > This should use is_empty_class or CLASSTYPE_EMPTY_P. We don't want to > change how classes with

[patch] libstdc++/69478 Fix assertions for move assignment of trivial types

The PR shows that we are incorrectly asserting that types are copy-assignable when we are going to move-assign them. Tested powerpc64-linux, committed to trunk. Branch commits to follow shortly. commit d11631c7c7f6630e83fdbe7f8e16f55eea2dd773 Author: Jonathan Wakely Date: Tue Jan 26 13:38:33

Re: [C++ PATCH] Handle error_mark_node in cp_fold (PR c++/68357)

On 01/26/2016 08:56 AM, Jakub Jelinek wrote: PR c++/68357 * cp-gimplify.c (cp_fold): If some operand folds to error_mark_node, return error_mark_node instead of building trees with error_mark_node operands. OK. Jason

Re: PING^1: [PATCH] Add TYPE_EMPTY_RECORD for C++ empty class

On 12/14/2015 05:08 PM, H.J. Lu wrote: + if (abi_version_at_least (10)) +TYPE_EMPTY_RECORD (t) = is_really_empty_class (t); This should use is_empty_class or CLASSTYPE_EMPTY_P. We don't want to change how classes with just a vptr are passed. Otherwise, it looks OK to me. Jason

Re: [PATCH] Partial fix for PR target/68662

On Tue, Jan 26, 2016 at 2:15 PM, Jakub Jelinek wrote: > Hi! > > As Alan mentioned in the PR, there is some other issue still around, but > by the time I've noticed that, I already had this patch being > bootstrapped/regtested on powerpc64{,le}-linux (which just passed). > Ok for trunk and deal wit

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On Tue, Jan 26, 2016 at 11:00:52AM -0800, Mike Stump wrote: > On Jan 26, 2016, at 10:21 AM, Jakub Jelinek wrote > > The question is, shall we do what wi::lshift does and have the fast path > > only for the constant shifts, as the untested patch below does, or shall we > > check shift dynamically (

[PATCH] Partial fix for PR target/68662

Hi! As Alan mentioned in the PR, there is some other issue still around, but by the time I've noticed that, I already had this patch being bootstrapped/regtested on powerpc64{,le}-linux (which just passed). Ok for trunk and deal with the rest incrementally? 2016-01-26 Jakub Jelinek PR

Re: [C++ PATCH] Handle error_mark_node in cp_fold (alt; PR c++/68357)

On Jan 26, 2016, at 8:39 AM, Jakub Jelinek wrote: > On Tue, Jan 26, 2016 at 02:56:24PM +0100, Jakub Jelinek wrote: >> Another alternative would be to make sure tree folders don't introduce >> error_mark_node (if it wasn't there already), but instead fold the call say >> to build_int_cst (returntyp

Re: [PATCH] Fix up wi::lrshift (PR c++/69399)

On Jan 26, 2016, at 10:21 AM, Jakub Jelinek wrote > The question is, shall we do what wi::lshift does and have the fast path > only for the constant shifts, as the untested patch below does, or shall we > check shift dynamically (thus use > shift < HOST_BITS_PER_WIDE_INT > instead of > STATIC_CONS

[PATCH] Fix up wi::lrshift (PR c++/69399)

Hi! On Tue, Jan 26, 2016 at 04:54:43PM +0100, Richard Biener wrote: > > Somehow PR 65656 miscompiled: > > > > if (STATIC_CONSTANT_P (xi.precision > HOST_BITS_PER_WIDE_INT) > > ? xi.len == 1 && xi.val[0] >= 0 > > : xi.precision <= HOST_BITS_PER_WIDE_INT) > > > > which turn

Re: [PATCH][ARM] Enable fusion of AES instructions

ping > -Original Message- > From: Wilco Dijkstra [mailto:wilco.dijks...@arm.com] > Sent: 19 November 2015 18:12 > To: gcc-patches@gcc.gnu.org > Subject: [PATCH][ARM] Enable fusion of AES instructions > > Enable instruction fusion of AES instructions on ARM for Cortex-A53 and > Cortex-A57

Re: [PATCH][AArch64] Add TARGET_IRA_CHANGE_PSEUDO_ALLOCNO_CLASS

ping (note the regressions discussed below are addressed by https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01761.html) From: Wilco Dijkstra Sent: 17 December 2015 13:37 To: James Greenhalgh Cc: gcc-patches@gcc.gnu.org; nd Subject: RE: [PATCH][AArch64] Add T

Re: [Fortran, gcc-5, patch, pr69268, v1] [5 Regression] Sourced allocation calls function twice

Dear Andre, The patch looks fine to me. OK for 5-branch. Thanks for the patch. Paul On 26 January 2016 at 13:28, Andre Vehreschild wrote: > Hi all, > > please find attached a patch to solve the issue of evaluating a source= > expression of an allocate() twice in gcc-5. The patch is a combinati

[trans-mem, committed] Fix 60908

Just a silly think-o in building the tm region tree, which resulted in the one region being found twice. r~ PR middle-end/60908 * trans-mem.c (tm_region_init): Mark entry block as visited. testsuite/ * gcc.dg/tm/pr60908.c: New test. diff --git a/gcc/testsuite/gcc.dg/tm

Re: Patch RFA: Add option -fcollectible-pointers, use it in ivopts

On Tue, Jan 26, 2016 at 8:03 AM, David Malcolm wrote: > > Is the patch missing some logic to make the option be enabled by default > for gc-using languages? (presumably go, and maybe java?) I am intentionally leaving that to a separate patch, yes. I think this option is useful by itself for C/C

[PR 69355] Correct hole detection when total_scalarization fails

Hi, PR 69355 has revealed that when SRA attempts total scalarization of an aggregate but this fails because the user type-casts a scalar field and stores into a it a smaller aggregate (and the scalar field is not written to, whether directly or as a part of an aggregate store), the pass can loose

Re: [PATCH, 69217]: [6 Regression] ICE at var-tracking.c:5038 Segmentation fault

On Jan 23, 2016, Iain Buclaw wrote: > PR rtl-optimization/69217 > * var-tracking.c (tracked_record_parameter_p): Don't segfault if there > are no TYPE_FIELDS set for the record type. This looks good to me, thanks. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoli

[PR69315] enable finish_function to recurse for constexpr functions

We don't want finish_function to be called recursively from mark_used. However, it's desirable and necessary to call itself recursively when performing delayed folding, because that may have to instantiate and evaluate constexpr template functions. So, arrange for finish_function to accept being c

Re: [PATCH][ARM] Fix PR target/69245 Rewrite arm_set_current_function

On 26/01/16 16:56, Christian Bruel wrote: On 01/26/2016 04:58 PM, Kyrill Tkachov wrote: Hi Christian, On 26/01/16 15:29, Christian Bruel wrote: On 01/25/2016 05:37 PM, Kyrill Tkachov wrote: So this is ok for trunk with the testcase changed as discussed above and using -O2 optimisation l

Re: [PATCH, PR69110] Don't return NULL access_fns in dr_analyze_indices

Tom de Vries wrote: > diff --git a/gcc/tree-data-ref.c b/gcc/tree-data-ref.c > index a40f40d..4c29fc2 100644 > --- a/gcc/tree-data-ref.c > +++ b/gcc/tree-data-ref.c > @@ -1510,8 +1510,9 @@ initialize_data_dependence_relation (struct > data_reference *a, >if (operand_equal_p (DR_REF (a), DR_REF

Re: Speedup configure and build with system.h

Hi, On Tue, 26 Jan 2016, Uros Bizjak wrote: > > Meh. Can you try the attached patch with a configure test (it > > includes the generated files)? It works for me with 4.3.4, and should > > make your build include always. > > Yes, this patch works for me and allows bootstrap with gcc-4.1.2 to

[C++ PATCH] Handle error_mark_node in cp_fold (alt; PR c++/68357)

On Tue, Jan 26, 2016 at 02:56:24PM +0100, Jakub Jelinek wrote: > Another alternative would be to make sure tree folders don't introduce > error_mark_node (if it wasn't there already), but instead fold the call say > to build_int_cst (returntype, 0). The known cases that would need to change > are

[PATCH] Fix PR c++/69139 (deduction failure with trailing return type)

This patch makes the parser more robust in determining whether an 'auto' specifier that appears in a parameter declaration corresponds to a placeholder for a late return type, or corresponds to an implicit template parameter as for an abbreviated function template. Bootstrap + regtest in progress

Re: [C PATCH] Fix -Wunused-function (PR debug/66869)

On Tue, Jan 26, 2016 at 04:21:08PM +0100, Richard Biener wrote: > > --- gcc/c/c-decl.c.jj 2016-01-21 00:41:47.0 +0100 > > +++ gcc/c/c-decl.c 2016-01-25 16:36:31.973504082 +0100 > > @@ -10741,11 +10741,19 @@ c_write_global_declarations_1 (tree glob > >if (TREE_CODE (decl) == F

Re: [PATCH] PR c++/69399: Add HAVE_WORKING_CXX_BUILTIN_CONSTANT_P

On Tue, Jan 26, 2016 at 04:54:43PM +0100, Richard Biener wrote: > > Somehow PR 65656 miscompiled: > > > > if (STATIC_CONSTANT_P (xi.precision > HOST_BITS_PER_WIDE_INT) > > ? xi.len == 1 && xi.val[0] >= 0 > > : xi.precision <= HOST_BITS_PER_WIDE_INT) > > > > which turned th

Re: Wonly-top-basic-asm

On Tue, Jan 26, 2016 at 01:11:36PM +0100, Bernd Schmidt wrote: > On 01/26/2016 01:29 AM, Segher Boessenkool wrote: > > >In my opinion we should not warn for any asm that means the same both > >as basic and as extended asm. The problem then becomes, what *is* the > >meaning of a basic asm, what do

[Patch AArch64] Restrict 16-bit sqrdml{sa}h instructions to FP_LO_REGS

Hi, In their forms using 16-bit lanes, the sqrdmlah and sqrdmlsh instruction available when compiling with -march=armv8.1-a are only usable with a register number in the range 0 to 15 for operand 3, as gas will point out: Error: register number out of range 0 to 15 at operand 3 -- `sqrdmls

Re: Patch RFA: Add option -fcollectible-pointers, use it in ivopts

On Tue, 2016-01-26 at 05:35 -0800, Ian Lance Taylor wrote: [...] > Index: common.opt > === > --- common.opt (revision 232580) > +++ common.opt (working copy) > @@ -1380,6 +1380,10 @@ > Enable hoisting adjacent loads to encourage ge

Re: [PATCH][ARM] Fix PR target/69245 Rewrite arm_set_current_function

Hi Christian, On 26/01/16 15:29, Christian Bruel wrote: On 01/25/2016 05:37 PM, Kyrill Tkachov wrote: So this is ok for trunk with the testcase changed as discussed above and using -O2 optimisation level and with a couple comment fixes below. Hi Kyrill, I realized afterwards that my imple

Re: [PATCH] PR c++/69399: Add HAVE_WORKING_CXX_BUILTIN_CONSTANT_P

On Mon, Jan 25, 2016 at 5:25 PM, H.J. Lu wrote: > On Mon, Jan 25, 2016 at 4:40 AM, Richard Biener > wrote: >> On Fri, Jan 22, 2016 at 7:55 PM, H.J. Lu wrote: >>> Without the fix for PR 65656, g++ miscompiles __builtin_constant_p in >>> wi::lrshift in wide-int.h. Add a check with PR 65656 testca

Re: [PATCH] Handle -fsanitize=* in lto-wrapper (PR lto/69254)

On Tue, Jan 26, 2016 at 03:06:43PM +0100, Richard Biener wrote: > I'm somewhat confused about that you drop -fsanitize options from > the LTO options section writing in lto-opts.c but then add code to > parse it from there in lto-wrapper.c. The code there also looks Sorry, as I said to Bernd, tha

Re: [PATCH] PR other/69006: fix extra newlines after diagnostics (v2)

On Tue, 2016-01-26 at 12:18 +0100, Bernd Schmidt wrote: > On 01/25/2016 09:13 PM, David Malcolm wrote: > > Here's an updated version of the patch. > > Thanks! > > > Instead of testing one particular kind of output via a plugin, > > this version of the patch adds code to gcc-dg-prune to issue a >

Re: [PATCH] Fix up ICE with initializer containing address of invalid var (PR tree-optimization/69483)

On Tue, Jan 26, 2016 at 3:17 PM, Jakub Jelinek wrote: > Hi! > > If as in the testcase below a VAR_DECL has error_mark_node type > (and that unfortunately happens (and has to) quite late, at the end of > parsing the TU), canonicalize_constructor_val can ICE on that, because it > will try to fold co

Re: [C PATCH] Fix -Wunused-function (PR debug/66869)

On Mon, Jan 25, 2016 at 9:38 PM, Jakub Jelinek wrote: > Hi! > > The early-debug changes moved warnings about unused functions into cgraph. > The problem is that if we have just unused declarations, they aren't > sometimes even registered with cgraph and therefore we no longer warn. > > Here is an

Re: [PATCH] ARM PR68620 (ICE with FP16 on armeb)

On 26 January 2016 at 14:20, Kyrill Tkachov wrote: > Hi Christophe, > > On 20/01/16 21:10, Christophe Lyon wrote: >> >> On 19 January 2016 at 15:51, Alan Lawrence >> wrote: >>> >>> On 19/01/16 11:15, Christophe Lyon wrote: >>> >> For neon_vdupn, I chose to implement neon_vdup_nv4hf and >>

Re: [PATCH], PowerPC IEEE 128-bit fp, #12 (default -mfloat128 on PowerPC-Linux)

On Thu, Jan 21, 2016 at 4:25 PM, Michael Meissner wrote: > This is the final patch (at least so far) that turns on -mfloat128 by default > for PowerPC Linux systems where the VSX instruction set is enabled. As I > mentioned in the last email, because we don't build the __float128 emulator on > ot

Re: [PATCH][AArch64] Add vector permute cost

On Tue, Dec 15, 2015 at 11:35:45AM +, Wilco Dijkstra wrote: > > Add support for vector permute cost since various permutes can expand into a > complex > sequence of instructions. This fixes major performance regressions due to > recent changes > in the SLP vectorizer (which now vectorizes m

Re: [AArch64] Disable pcrelative_literal_loads with fix-cortex-a53-843419

On 26/01/16 14:42, Christophe Lyon wrote: Hi, This is a followup to PR63304. As discussed in bugzilla, this patch disables pcrelative_literal_loads when -mfix-cortex-a53-843419 (or its default configure option) is used. I copied the behavior of -mfix-cortex-a53-835769 (e.g. in aarch64_can_inl

Re: [AArch64] Disable pcrelative_literal_loads with fix-cortex-a53-843419

With the attachment On 26 January 2016 at 15:42, Christophe Lyon wrote: > Hi, > > This is a followup to PR63304. > > As discussed in bugzilla, this patch disables pcrelative_literal_loads > when -mfix-cortex-a53-843419 (or its default configure option) is > used. > > I copied the behavior of

[AArch64] Disable pcrelative_literal_loads with fix-cortex-a53-843419

Hi, This is a followup to PR63304. As discussed in bugzilla, this patch disables pcrelative_literal_loads when -mfix-cortex-a53-843419 (or its default configure option) is used. I copied the behavior of -mfix-cortex-a53-835769 (e.g. in aarch64_can_inline_p), and I have tested by building the Lin

Re: [PATCH][AArch64] Add vector permute cost

ping From: Wilco Dijkstra Sent: 16 December 2015 11:37 To: Richard Biener; James Greenhalgh Cc: GCC Patches; nd Subject: RE: [PATCH][AArch64] Add vector permute cost Richard Biener wrote: > On Wed, Dec 16, 2015 at 10:32 AM, James Greenhalgh > wrote: > >

Re: [PATCH] Handle -fsanitize=* in lto-wrapper (PR lto/69254)

On Tue, Jan 26, 2016 at 03:06:43PM +0100, Richard Biener wrote: > > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? > > Can you split out the non -fsanitize part? It is ok. Ok, I've committed following patch: 2016-01-26 Jakub Jelinek PR lto/69254 * lto-w

RFA: Fix for cygwin/mingw PR 66655

Hi Guys, The patch below is offered as a fix for PR 66655. In testing it appears that the patch does work, and does not break building libstdc++-v3 for cygwin or mingw. (Unlike the earlier version...) Due to my brain being so small, I have already checked the patch in, without receivi

[committed, PATCH] Remove -m32 from gcc.target/i386/pr68986-2.c

Index: ChangeLog === --- ChangeLog (revision 232829) +++ ChangeLog (working copy) @@ -1,5 +1,9 @@ 2016-01-26 H.J. Lu + * gcc.target/i386/pr68986-2.c: Remove -m32. + +2016-01-26 H.J. Lu + PR target/68986

  1   2   >