[PATCH v4] SH FDPIC backend support

2015-10-22 Thread Rich Felker
Here's my updated version of the FDPIC patch with all requested changes made and Changelog added. I've included all the original authors. This is my first time writing such an extensive Changelog entry so please let me know if there are things I got wrong. Rich 2010-08-19 Daniel Jacobowitz

[RFA] Fix pr67830, another type narrowing problem

2015-10-22 Thread Jeff Law
/* This is another case of narrowing, specifically when there's an outer BIT_AND_EXPR which masks off bits outside the type of the innermost operands. Like the previous case we have to convert the operands to unsigned types to avoid introducing undefined behaviour for the arithmetic

Re: [patch 1/3] Header file reduction - backend files.

2015-10-22 Thread Jeff Law
On 10/22/2015 04:25 PM, Jeff Law wrote: On 10/01/2015 08:33 PM, Andrew MacLeod wrote: these are all in the main gcc directory. 297 files total. [ ... ] Out of time for now. More to follow... So a quirk of show-headers. Let's look at cgraphunit.c on the trunk: [law@tor gcc]$ ../contrib/s

Re: Handle CONSTRUCTOR in operand_equal_p

2015-10-22 Thread Jan Hubicka
> > But only via GENERIC folding I suppose. Yes, we don't value-number > aggregates and generally PRE (and DOM via excessive jump-threading) > is the only pass that remotely handles this kind of situation. I actually think it is tail merging unifying the code, but I did not really look too deep

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-22 Thread Jan Hubicka
Hello, this is a variant of patch I tested. After looking into the issue more, I think we don't really need to check types to be compatible (or we want to check it in other references, too). It seems to me that we should be able to drop /* Verify that access happens in similar ty

Do not compare TYPE_MODE in operand_equal_p when OEP_ADDRESS_OF is set

2015-10-22 Thread Jan Hubicka
Hi, this patch disables TYPE_MODE comparing when we care about address only. I already disabled other matching of types, but missed this one as it is placed later in the function body. Bootstrapped/regtested x86_64-linux, OK? Honza * fold-const.c (operand_equal_p): Do not compare TYPE_MO

Re: Move some bit and binary optimizations in simplify and match

2015-10-22 Thread Hurugalawadi, Naveen
Hi, >> So I suggest to modify your patch to do Done. Please find attached the modified patch. Regression tested successfully on X86_64. Thanks, Naveendiff --git a/gcc/fold-const.c b/gcc/fold-const.c index 1e7fbb4..23c6fa9 100644 --- a/gcc/fold-const.c +++ b/gcc/fold-const.c @@ -9692,28 +9692,6

[PATCH] libjava: fix locale handling when sorting JNI methods

2015-10-22 Thread Mike Frysinger
When building under LANG=cs_CZ.UTF-8, the JNI method check fails: /bin/bash ../../scripts/check_jni_methods.sh Found a problem with the JNI methods declared and implemented. (<) missing in implementation, (>) missing in header files > Java_gnu_java_awt_peer_gtk_GtkClipboard_advertiseContent > Java

[PATCH] clarify documentation of -Q --help=optimizers

2015-10-22 Thread Martin Sebor
[Sending to the right list this time] The documentation of the -Q --help=optimizers options leads some to expect that when options are reported as enabled imply the corresponding optimization will take place. (See the following question on gcc-help: https://gcc.gnu.org/ml/gcc-help/2015-10/msg001

C++ PATCH for template conversion function call

2015-10-22 Thread Jason Merrill
A testcase in a comment for 67847 led me to realize that our code for calling the result of a conversion template to pointer-to-function type was fundamentally broken (and apparently untested). This patch fixes it. Tested x86_64-pc-linux-gnu, applying to trunk. commit 89411e903d2bfea13933ad1d7

[PATCH] isl schedule tree

2015-10-22 Thread Aditya Kumar
From: Abderrazek Zaafrani Use isl_schedule_node instead of isl_band_list for isl-0.15. Passes regtest and bootstrap for isl-0.15. gcc/ChangeLog: 2015-10-22 Abderrazek Zaafrani * graphite-optimize-isl.c (get_schedule_for_node_st): New callback function to schedule based on i

Re: [PATCH 3 of 3] print help for undocumented options

2015-10-22 Thread Joseph Myers
On Thu, 22 Oct 2015, Martin Sebor wrote: > Good point. It didn't occur to me that the "leaf" .exp files are all > part of the same process. > > While testing it, I noticed that a COLUMNS setting in the environment > can cause some other tests in the help.exp file to fail. Setting the > variable e

Re: [PATCH 3 of 3] print help for undocumented options

2015-10-22 Thread Martin Sebor
On 10/22/2015 03:47 PM, Joseph Myers wrote: On Thu, 22 Oct 2015, Martin Sebor wrote: While fixing up the ChangeLogs for the commit (as requested below) I noticed that a number of new options have been added with help text with no period at the end. The attached patch fixes those up and adds a

Re: [patch 1/3] Header file reduction - backend files.

2015-10-22 Thread Andrew MacLeod
On 10/22/2015 06:25 PM, Jeff Law wrote: On 10/01/2015 08:33 PM, Andrew MacLeod wrote: these are all in the main gcc directory. 297 files total. Everything bootstraps on x86_64-pc-linux-gnu and powerpc64le-unknown-linux-gnu. All targets in config-list.mk still build. Regressions tests also came

Re: [patch 1/3] Header file reduction - backend files.

2015-10-22 Thread Jeff Law
On 10/01/2015 08:33 PM, Andrew MacLeod wrote: these are all in the main gcc directory. 297 files total. Everything bootstraps on x86_64-pc-linux-gnu and powerpc64le-unknown-linux-gnu. All targets in config-list.mk still build. Regressions tests also came up clean. OK for trunk? So just to be

Re: [patch] header file re-ordering.

2015-10-22 Thread Jeff Law
On 10/22/2015 03:07 PM, Andrew MacLeod wrote: On 10/22/2015 04:55 PM, Jeff Law wrote: On 10/08/2015 07:37 AM, Andrew MacLeod wrote: On 10/07/2015 06:02 PM, Jeff Law wrote: However, the tool has been run, and I've made the minor adjustments required to the source files to make it work. (ie, a

Re: [PATCH 3 of 3] print help for undocumented options

2015-10-22 Thread Joseph Myers
On Thu, 22 Oct 2015, Martin Sebor wrote: > While fixing up the ChangeLogs for the commit (as requested below) > I noticed that a number of new options have been added with help > text with no period at the end. The attached patch fixes those > up and adds a test to help catch these problems befor

[PATCH, testsuite]: Fix gcc.target/i386/pr67985-3.c scan-assembler FAILs

2015-10-22 Thread Uros Bizjak
2015-10-22 Uros Bizjak * gcc.target/i386/pr67985-3.c (dg-options): Add -mfpmath=sse. Tested on x86_64-linux-gnu {,-m32} and committed to mainline SVN. Uros. Index: gcc.target/i386/pr67985-3.c === --- gcc.target/i386/pr67985-

Re: [PATCH 3 of 3] print help for undocumented options

2015-10-22 Thread Martin Sebor
While fixing up the ChangeLogs for the commit (as requested below) I noticed that a number of new options have been added with help text with no period at the end. The attached patch fixes those up and adds a test to help catch these problems before they creep in again. Martin https://gcc.gnu.o

Re: [patch] header file re-ordering.

2015-10-22 Thread Andrew MacLeod
On 10/22/2015 04:55 PM, Jeff Law wrote: On 10/08/2015 07:37 AM, Andrew MacLeod wrote: On 10/07/2015 06:02 PM, Jeff Law wrote: However, the tool has been run, and I've made the minor adjustments required to the source files to make it work. (ie, a few multi-line comments and the fact that mul-t

Re: [patch] header file re-ordering.

2015-10-22 Thread Jeff Law
On 10/08/2015 07:37 AM, Andrew MacLeod wrote: On 10/07/2015 06:02 PM, Jeff Law wrote: However, the tool has been run, and I've made the minor adjustments required to the source files to make it work. (ie, a few multi-line comments and the fact that mul-tables.c is generated on the tile* targets

C++ PATCH for c++/68006 (broken value-initialization with -flifetime-dse)

2015-10-22 Thread Jason Merrill
My change to clobber the object contents on entry to a constructor was forgetting that for value-initialization of a class with an implicitly-defined default constructor, we do zero-initialization before calling the copy constructor, and that zero-initialization should not be clobbered. Teste

Re: [OpenACC 0/7] host_data construct

2015-10-22 Thread James Norris
To all, On 10/22/2015 03:36 PM, Joseph Myers wrote: I think this patch is small enough, and the pieces insufficiently self-contained, that splitting it up rather than posting as one patch just makes it harder to understand. My strong preference is that the same patch that introduces a feature s

Re: [OpenACC 0/7] host_data construct

2015-10-22 Thread Joseph Myers
I think this patch is small enough, and the pieces insufficiently self-contained, that splitting it up rather than posting as one patch just makes it harder to understand. My strong preference is that the same patch that introduces a feature should also add the testcases for that feature, for

Re: [PATCH] Fix abort in write_eligible_delay

2015-10-22 Thread Jeff Law
On 10/22/2015 01:59 PM, Trevor Saunders wrote: I've verified this fixes the 47 newly failing targets in config-list.mk and survives the usual bootstrap & comparison test on x86_64-linux-gnu. thanks for taking care of this. No problem. +write_dummy_eligible_delay (FILE *outf, const char *k

Re: [PATCH v2 12/13] Document the x86 address spaces

2015-10-22 Thread Richard Henderson
I believe I've addressed all of your comments like so. r~ diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index e54fe67..5793868 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -1240,8 +1240,8 @@ As an extension, GNU C supports named address spaces as defined in the N1275 d

Re: [OpenACC 1/11] UNIQUE internal function

2015-10-22 Thread Nathan Sidwell
On 10/22/15 04:04, Jakub Jelinek wrote: + /* Ignore blocks containing non-clonable function calls. */ + for (gsi = gsi_start_bb (CONST_CAST_BB (bb)); + !gsi_end_p (gsi); gsi_next (&gsi)) +{ + g = gsi_stmt (gsi); + + if (is_gimple_call (g) && gimple_call_internal_p (g) +

[PATCH, rs6000][v4] powerpc musl libc support

2015-10-22 Thread Szabolcs Nagy
On 16/10/15 16:58, Szabolcs Nagy wrote: Revision of https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01640.html This adds musl libc support to powerpc: - The dynamic-linker name is /lib/ld-musl-powerpc{64}{le}{-sf}.so.1 - The include order is changed for musl as in linux.h. New in this revision:

Re: [testsuite] Fix potential race conditions in gfortran tests

2015-10-22 Thread Maxim Kuvyrkov
Hi, And this is a similar patch for gfortran.dg/streamio_N.f90 tests. OK to commit? -- Maxim Kuvyrkov www.linaro.org > On Oct 18, 2015, at 4:17 PM, Mikael Morin wrote: > > Le 16/10/2015 10:08, Christophe Lyon a écrit : >> Hi, >> >> We have noticed a few random failures in gfortran tests in

Re: [PATCH] Fix abort in write_eligible_delay

2015-10-22 Thread Trevor Saunders
On Thu, Oct 22, 2015 at 01:18:29PM -0600, Jeff Law wrote: > > Various ports are currently failing to build, faulting in > write_eligible_delay. > > This can happen if the target has delay slots defined, but does not have > annul-true or annul-false slots. cris is a reasonable example. > > This

Re: [PATCH] gcc/fold-const.c: Correct the report warning position.

2015-10-22 Thread Jeff Law
On 10/21/2015 04:31 PM, Chen Gang wrote: Hello all: It is for bug63510, which reported by another members (not me), I guess, this patch should fix this bug. Welcome any other members' ideas, suggestions, and completions. Note that the call to fold_binary from tree-ssa-sccvn.c has been removed.

Re: [PATCH][optabs.c] Fix PR 67989: Handle const0_rtx target in expand_atomic_compare_and_swap

2015-10-22 Thread Jeff Law
On 10/22/2015 10:24 AM, Kyrill Tkachov wrote: Hi all, The ICE in this PR (reduced from LLVM) occurs because the atomic_load builtin expansion ends up calling expand_atomic_compare_and_swap without caring about the result. The convention in the optabs/builtin machinery is to use const0_rtx for th

Re: [PATCH] Fix PR rtl-optimization/67736 in combine.c

2015-10-22 Thread Steve Ellcey
On Thu, 2015-10-22 at 13:46 -0500, Segher Boessenkool wrote: > One nit and maybe a problem: > > > --- a/gcc/testsuite/gcc.dg/combine-subregs.c > > +++ b/gcc/testsuite/gcc.dg/combine-subregs.c > > @@ -0,0 +1,36 @@ > > +/* { dg-do run } */ > > +/* { dg-options "-O2 -fexpensive-optimizations" } */ >

Re: [PATCH] Fix sanitizer/68042

2015-10-22 Thread Jeff Law
On 10/22/2015 10:45 AM, Maxim Ostapenko wrote: Hi, currently we have memcmp-1.c and sanity-check-pure-c-1.c (ASan testsuite) output pattern test failures on x86_64-apple-darwin14. This patch adjusts their expecting patterns to match real ones. Tested by me on x86_64-unknown-linux-gnu and by Dom

Re: [gomp4 00/14] NVPTX: further porting

2015-10-22 Thread Alexander Monakov
On Thu, 22 Oct 2015, Bernd Schmidt wrote: > On 10/22/2015 08:08 PM, Alexander Monakov wrote: > > On Thu, 22 Oct 2015, Bernd Schmidt wrote: > > > > > I'm not really familiar with OpenMP and what it allows, so take all my > > > comments with a grain of salt. > > > > > > On 10/22/2015 06:41 PM, Ale

Re: [PATCH 3/9] ENABLE_CHECKING refactoring: Java and Ada

2015-10-22 Thread Jeff Law
On 10/05/2015 05:30 PM, Mikhail Maltsev wrote: gcc/java/ChangeLog: 2015-10-05 Mikhail Maltsev * decl.c (java_mark_decl_local): Use flag_checking instead of ENABLE_CHECKING. gcc/ada/ChangeLog: 2015-10-05 Mikhail Maltsev * gcc-interface/decl.c (gnat_to_gnu_entity): U

[OpenACC 7/7] host_data construct (runtime tests)

2015-10-22 Thread James Norris
libgomp/testsuite/libgomp.oacc-c-c++-common/host_data-1.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/host_data-1.c libgomp/testsuite/libgomp.oacc-c-c++-common/host_data-2.c b/libgomp/testsuite/libgomp.oacc-c-c++-common/host_data-2.c - New runtime tests for host_data. diff

[OpenACC 6/7] host_data construct

2015-10-22 Thread James Norris
libgomp/libgomp.map b/libgomp/libgomp.map - Add new symbol GOACC_deviceptr. libgomp/oacc-mem.c b/libgomp/oacc-mem.c - Add new function GOACC_deviceptr() to handle pointer lookup for host_data regions. diff --git a/libgomp/libgomp.map b/libgomp/libgomp.map index

[OpenACC 5/7] host_data construct (gcc tests)

2015-10-22 Thread James Norris
gcc/testsuite/c-c++-common/goacc/host_data-1.c b/gcc/testsuite/c-c++-common/goacc/host_data-1.c gcc/testsuite/c-c++-common/goacc/host_data-2.c b/gcc/testsuite/c-c++-common/goacc/host_data-2.c gcc/testsuite/c-c++-common/goacc/host_data-3.c b/gcc/testsuite/c-c++-common/goacc/host_dat

[PATCH] Fix abort in write_eligible_delay

2015-10-22 Thread Jeff Law
Various ports are currently failing to build, faulting in write_eligible_delay. This can happen if the target has delay slots defined, but does not have annul-true or annul-false slots. cris is a reasonable example. This is most easily addressed by writing out a trivial dummy function if

[OpenACC 4/7] host_data construct (middle end)

2015-10-22 Thread James Norris
gcc/gimplify.c b/gcc/gimplify.c - Add new enum for use_device clause handling to gimplify_omp_var_data. - Add new enum for host_data regions to omp_region_type. - Move handling of use_device clause in gimplify_scan_omp_clauses(). - Add new functions gimplify_h

Re: [PATCH v2 08/13] Add TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID

2015-10-22 Thread Richard Henderson
On 10/21/2015 05:12 PM, Sandra Loosemore wrote: On 10/20/2015 03:27 PM, Richard Henderson wrote: +@deftypefn {Target Hook} bool TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID (addr_space_t @var{as}) +Define this to modify the default handling of address 0 for the +address space. Return true if 0 should

[OpenACC 2/7] host_data construct (C FE)

2015-10-22 Thread James Norris
gcc/c/c-parser.c b/gcc/c/c-parser.c - Add handling of use_device clause in c_parser_omp_clause_name(). - Add new function c_parser_oacc_clause_use_device() to handle use_device clause with host_data. - Add handling of use_device clause in c_parser_oacc_all_c

[OpenACC 3/7] host_data construct (C front-end)

2015-10-22 Thread James Norris
gcc/cp/cp-tree.h b/gcc/cp/cp-tree.h - Add definition for c_finish_oacc_host_data(). gcc/cp/parser.c b/gcc/cp/parser.c - Add handling of use_device clause in cp_parser_omp_clause_name(). - Add handling of use_device clause in cp_parser_oacc_all_clauses().

[OpenACC 1/7] host_data construct (C/C++ common)

2015-10-22 Thread James Norris
gcc/c-family/c-pragma.c b/gcc/c-family/c-pragma.c - Add host_data pragma definition to list in oacc_pragma[]. gcc/c-family/c-pragma.h b/gcc/c-family/c-pragma.h - Add host_data pragma enum to list in pragma_kind[]. - Add use_device clause enum to list in pragma_o

[OpenACC 0/7] host_data construct

2015-10-22 Thread James Norris
Hi! This patch series adds the handling of OpenACC host_data construct in the C and C++ front-ends, gimple, and supporting functions in libgomp. Commentary on the changes is included in each individual patch. All of the code is in the gomp-4_0-branch. Regtested on x86_64

RE: [PATCH] Disable -mbranch-likely for -Os when targetting generic architecture

2015-10-22 Thread Moore, Catherine
> -Original Message- > From: Robert Suchanek [mailto:robert.sucha...@imgtec.com] > Sent: Friday, September 04, 2015 10:21 AM > To: Matthew Fortune; Richard Sandiford > Cc: Moore, Catherine; gcc-patches@gcc.gnu.org > Subject: RE: [PATCH] Disable -mbranch-likely for -Os when targetting gene

Re: [PATCH] Fix PR rtl-optimization/67736 in combine.c

2015-10-22 Thread Segher Boessenkool
On Thu, Oct 22, 2015 at 09:47:23AM -0700, Steve Ellcey wrote: > OK to checkin? > 2015-10-21 Steve Ellcey > Andrew Pinski > > PR rtl-optimization/67736 > * combine.c (simplify_comparison): Use gen_lowpart_or_truncate instead > of gen_lowpart when we had a truncati

[gomp4] OpenACC async clause regressions (was: [gomp4.1] Add new versions of GOMP_target{,_data,_update} and GOMP_target_enter_exit_data)

2015-10-22 Thread Thomas Schwinge
Hi! On Mon, 19 Oct 2015 18:24:35 +0200, I wrote: > Chung-Lin, would you please have a look at the following (on > gomp-4_0-branch)? Also, anyone else got any ideas off-hand? Ilya, Jakub, thanks for your comments! > On Tue, 23 Jun 2015 13:51:39 +0200, Jakub Jelinek wrote: > > On Tue, Jun 23, 20

Re: [PATCH 0/4] OpenMP 4.0 offloading to Intel MIC

2015-10-22 Thread Ilya Verbin
On Mon, Dec 22, 2014 at 13:01:40 +0100, Thomas Schwinge wrote: > By chance (when tracking down a different problem), I've found the > following. Would you please check whether that's a real problem in > liboffloadmic, or its libgomp plugin, or just a mis-diagnosis by > Valgrind? > > ==21327==

Re: [gomp4 00/14] NVPTX: further porting

2015-10-22 Thread Bernd Schmidt
On 10/22/2015 08:08 PM, Alexander Monakov wrote: On Thu, 22 Oct 2015, Bernd Schmidt wrote: I'm not really familiar with OpenMP and what it allows, so take all my comments with a grain of salt. On 10/22/2015 06:41 PM, Alexander Monakov wrote: The second approach is to run all threads in the wa

Re: [gomp4 00/14] NVPTX: further porting

2015-10-22 Thread Alexander Monakov
On Thu, 22 Oct 2015, Julian Brown wrote: > > The second approach is to run all threads in the warp all the time, > > making sure they execute the same code with the same data, and thus > > build up the same local state. In this case we'd need to ensure this > > invariant: if threads in the warp ha

Re: [Patch, fortran] PR58754 - [4.9/5 Regression] ICE on allocating character array with source

2015-10-22 Thread Paul Richard Thomas
Thanks FX! Committed to 5 branch as revision 229179 and the testcase to 4_9 as revision 229180. Cheers Paul On 22 October 2015 at 19:32, FX wrote: >> 2015-10-22 Paul Thomas >> >>PR fortran/58754 >>* trans-stmt.c (gfc_trans_allocate): Do not use the scalar >>character assignment

Re: [gomp4 00/14] NVPTX: further porting

2015-10-22 Thread Alexander Monakov
On Thu, 22 Oct 2015, Bernd Schmidt wrote: > I'm not really familiar with OpenMP and what it allows, so take all my > comments with a grain of salt. > > On 10/22/2015 06:41 PM, Alexander Monakov wrote: > > The second approach is to run all threads in the warp all the time, making > > sure they exe

Re: [OpenACC 1/11] UNIQUE internal function

2015-10-22 Thread Nathan Sidwell
On 10/22/15 10:26, Richard Biener wrote: On Thu, Oct 22, 2015 at 4:01 PM, Nathan Sidwell wrote: On 10/22/15 04:07, Richard Biener wrote: Yeah, please make them either end or start a BB so we have to check at most a single stmt. ECF_RETURNS_TWICE should achieve that, it also makes it a code m

Re: [PATCH] New attribute to create target clones

2015-10-22 Thread Evgeny Stupachenko
PING. On Thu, Oct 15, 2015 at 12:32 AM, Evgeny Stupachenko wrote: > Bootstrap and make check for x86 passed. No new fails. > Please ignore an empty line added to omp-low.c in the patch, the > misprint will be removed prior to a commit. > > Thanks, > Evgeny > > On Tue, Oct 13, 2015 at 2:35 AM, Evg

Re: [OpenACC 1/11] UNIQUE internal function

2015-10-22 Thread Nathan Sidwell
On 10/22/15 04:07, Richard Biener wrote: Yeah, please make them either end or start a BB so we have to check at most a single stmt. ECF_RETURNS_TWICE should achieve that, it also makes it a code motion barrier. I'm having a hard time making UNIQUE the end of a BB. I'm emitting code to a gim

Re: [PATCH] unconditionally compile most of the delay slot code

2015-10-22 Thread Jeff Law
On 10/22/2015 11:34 AM, Steve Ellcey wrote: On Wed, 2015-10-21 at 11:13 -0400, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders Hi, $subject bootstrapped+ regtested x86_64-linux-gnu, I wouldn't mind a second pair of eyes on this one given its not totally trivial. Trev gcc/ChangeLog:

Re: [Patch, fortran] PR58754 - [4.9/5 Regression] ICE on allocating character array with source

2015-10-22 Thread FX
> 2015-10-22 Paul Thomas > >PR fortran/58754 >* trans-stmt.c (gfc_trans_allocate): Do not use the scalar >character assignment if the allocate expression sis an array >descriptor. > > 2015-10-22 Paul Thomas > >PR fortran/58754 >* gfortran.dg/pr58754.f90: New test O

Re: [PATCH] unconditionally compile most of the delay slot code

2015-10-22 Thread Steve Ellcey
On Wed, 2015-10-21 at 11:13 -0400, tbsaunde+...@tbsaunde.org wrote: > From: Trevor Saunders > > Hi, > > $subject > > bootstrapped+ regtested x86_64-linux-gnu, I wouldn't mind a second pair of > eyes > on this one given its not totally trivial. > > Trev > > gcc/ChangeLog: > > 2015-10-20 Tre

Re: [Patch, fortran] PR58754 - [4.9/5 Regression] ICE on allocating character array with source

2015-10-22 Thread Paul Richard Thomas
Dear All, Only the testcase will be applied to 4.9. At some time, it seems to have fixed itself! Cheers Paul On 22 October 2015 at 16:31, Paul Richard Thomas wrote: > Dear All, > > This patch speaks for itself. It is by no means as comprehensive as > the work on ALLOCATE that Andre has done on

Re: [gomp4 00/14] NVPTX: further porting

2015-10-22 Thread Bernd Schmidt
I'm not really familiar with OpenMP and what it allows, so take all my comments with a grain of salt. On 10/22/2015 06:41 PM, Alexander Monakov wrote: The second approach is to run all threads in the warp all the time, making sure they execute the same code with the same data, and thus build up

Re: [gomp4 00/14] NVPTX: further porting

2015-10-22 Thread Julian Brown
On Thu, 22 Oct 2015 19:41:51 +0300 Alexander Monakov wrote: > On Thu, 22 Oct 2015, Jakub Jelinek wrote: > > Does that apply also to threads within a warp? I.e. is .local > > local to each thread in the warp, or to the whole warp, and if the > > former, how can say at the start of a SIMD region o

[PATCH 3/5] Properly handle -fno-plt in ix86_expand_call

2015-10-22 Thread H.J. Lu
prepare_call_address in calls.c is the wrong place to handle -fno-plt. We shoudn't force function address into register and hope that load function address via GOT and indirect call via register will be folded into indirect call via GOT, which doesn't always happen. Also non-PIC case can only be h

[PATCH 4/5] Check if x86 binutils supports R_386_GOT32X/R_X86_64_GOTPCRELX

2015-10-22 Thread H.J. Lu
Define HAVE_LD_R_386_GOT32X to 1 if 32-bit x86 assembler generates R_386_GOT32X for "jmp *foo@GOT". Define HAVE_LD_R_X86_64_GOTPCRELX to 1 if 64-bit x86 assembler generates R_X86_64_GOTPCRELX for "jmp *foo@GOTPCREL(%rip)". * configure.ac (HAVE_LD_R_386_GOT32X): New. Defined to 1

[PATCH 1/5] X86: Optimize access to globals in PIE with copy reloc

2015-10-22 Thread H.J. Lu
Normally, with PIE, GCC accesses globals that are extern to the module using GOT. This is two instructions, one to get the address of the global from GOT and the other to get the value. Examples: --- extern int a_glob; int main () { return a_glob; } --- With PIE, the generated code accesses g

[PATCH 2/5] Enable -fsymbolic in LTO if -Bsymbolic is used

2015-10-22 Thread H.J. Lu
When -Bsymbolic is passed to linker, references to global symbols defined in the shared library are resolved locally. We should pass -fsymbolic to GCC in this case. * collect2.c (main): Add -fsymbolic to COLLECT_GCC_OPTIONS if -Bsymbolic is used. * doc/invoke.texi: Updated

[PATCH 0/5] Improve x86 Position-Independent codegen

2015-10-22 Thread H.J. Lu
This set of patches improves x86 Position-Independent codegen by 1. Use copy reloction to access externally defined global data from PIE if linker supports it. 2. Add -fsymbolic to control how references to global symbols are bound, avoiding copy relocation in PIE against DSO created by -Wl,-Bsymb

[PATCH 5/5] Generate R_386_GOT32x relocation for -fno-plt -fno-pic

2015-10-22 Thread H.J. Lu
This patch extends -fno-plt to non-PIC on x86. -fno-plt works in 64-bit mode with the existing binutils. For 32-bit, we need the updated assembler and linker to support "call/jmp *foo@GOT", which accesses the GOT slot without a base register, with a new R_386_GOT32x relocation. gcc/ * c

[PATCH] Fix PR rtl-optimization/67736 in combine.c

2015-10-22 Thread Steve Ellcey
This is a new patch to fix PR rtl-optimization/67736. My original patch was MIPS specific and that was rejected and Andrew Pinski pointed me to a patch he had sent out several years ago but that was never checked in. I updated the patch and tested it with no regressions and would like to check it

[PATCH] Fix sanitizer/68042

2015-10-22 Thread Maxim Ostapenko
Hi, currently we have memcmp-1.c and sanity-check-pure-c-1.c (ASan testsuite) output pattern test failures on x86_64-apple-darwin14. This patch adjusts their expecting patterns to match real ones. Tested by me on x86_64-unknown-linux-gnu and by Dominique on x86_64-apple-darwin14. Ok to app

Re: [Boolean Vector, patch 1/5] Introduce boolean vector to be used as a vector comparison type

2015-10-22 Thread Jeff Law
On 10/22/2015 10:21 AM, Ilya Enkovich wrote: On 22 Oct 12:37, Andreas Schwab wrote: Ilya Enkovich writes: 2015-10-22 13:13 GMT+03:00 Andreas Schwab : FAIL: gcc.c-torture/compile/pr54713-1.c -O0 (internal compiler error) Can't reproduce it on i386. What's config used? http://gcc.gnu.or

Re: [gomp4 00/14] NVPTX: further porting

2015-10-22 Thread Alexander Monakov
On Thu, 22 Oct 2015, Jakub Jelinek wrote: > Does that apply also to threads within a warp? I.e. is .local local to each > thread in the warp, or to the whole warp, and if the former, how can say at > the start of a SIMD region or at its end the local vars be broadcast to > other threads and collec

Re: [PATCH 1 of 2] print help for undocumented options

2015-10-22 Thread Martin Sebor
On 10/22/2015 04:24 AM, Eric Botcazou wrote: Martin, some subdirectories have their own ChangeLog file so you need to move... 2015-10-21 Martin Sebor PR driver/68043 * opts.c (undocumented_msg, use_diagnosed_msg): New globals. (print_filtered_help): Reference a

Re: [vec-cmp, patch 5/6] Disable bool patterns when possible

2015-10-22 Thread Jeff Law
On 10/22/2015 10:04 AM, Ilya Enkovich wrote: 2015-09-12 Ilya Enkovich * tree-vect-patterns.c (check_bool_pattern): Check fails if we can vectorize comparison directly. (search_type_for_mask): New. (vect_recog_bool_pattern): Support cases when bool pattern

[PATCH][optabs.c] Fix PR 67989: Handle const0_rtx target in expand_atomic_compare_and_swap

2015-10-22 Thread Kyrill Tkachov
Hi all, The ICE in this PR (reduced from LLVM) occurs because the atomic_load builtin expansion ends up calling expand_atomic_compare_and_swap without caring about the result. The convention in the optabs/builtin machinery is to use const0_rtx for the target destination when that is the case.

Re: [Boolean Vector, patch 1/5] Introduce boolean vector to be used as a vector comparison type

2015-10-22 Thread Ilya Enkovich
On 22 Oct 12:37, Andreas Schwab wrote: > Ilya Enkovich writes: > > > 2015-10-22 13:13 GMT+03:00 Andreas Schwab : > >> FAIL: gcc.c-torture/compile/pr54713-1.c -O0 (internal compiler error) > > > > Can't reproduce it on i386. What's config used? > > http://gcc.gnu.org/ml/gcc-testresults/2015-10

Re: [vec-cmp, patch 1/6] Add optabs for vector comparison

2015-10-22 Thread Ilya Enkovich
2015-10-22 18:52 GMT+03:00 Jeff Law : > On 10/22/2015 04:35 AM, Ilya Enkovich wrote: >> >> 2015-10-21 20:25 GMT+03:00 Jeff Law : >>> >>> On 10/08/2015 08:52 AM, Ilya Enkovich wrote: Hi, This series introduces autogeneration of vector comparison and its support on

Re: Change behavior of -fsched-verbose option

2015-10-22 Thread Nikolai Bozhenov
On 10/22/2015 06:56 PM, Bernd Schmidt wrote: On 10/22/2015 05:38 PM, Nikolai Bozhenov wrote: Currently -fsched-verbose option redirects debugging dumps to stderr if there is no dump_file for the current pass. It would be fine if there were the only scheduling pass. But for example for AArch64 t

[PATCH][AArch64] Enable autoprefetcher modelling in the scheduler

2015-10-22 Thread Kyrill Tkachov
Hi all, This patch enables the autoprefetcher heuristic for scheduling in AArch64. It is enabled for the Cortex-A53, Cortex-A57 cores and is off for the other cores, leaving their behaviour unchanged. When enabled, the scheduler will try to sort groups of loads or stores in order of the offset

Re: [vec-cmp, patch 5/6] Disable bool patterns when possible

2015-10-22 Thread Ilya Enkovich
On 21 Oct 11:45, Jeff Law wrote: > On 10/08/2015 09:15 AM, Ilya Enkovich wrote: > >Hi, > > > >This patch disables transformation of boolean computations into integer ones > >in case target supports vector comparison. Pattern still applies to > >transform resulting boolean value into integer or a

Commit: MSP430: Pass silicon errata options on to the assembler

2015-10-22 Thread Nick Clifton
Hi Guys, I am checking in the patch below to allow gcc to pass the new MSP430 -msilicon-errata and -msilicon-errata-warn option on to the assembler. Cheers Nick gcc/ChangeLog 2015-10-22 Nick Clifton * config/msp430/msp430.opt: Add -msilicon-errata and -msilicon-errata

Re: Change behavior of -fsched-verbose option

2015-10-22 Thread Bernd Schmidt
On 10/22/2015 05:38 PM, Nikolai Bozhenov wrote: Currently -fsched-verbose option redirects debugging dumps to stderr if there is no dump_file for the current pass. It would be fine if there were the only scheduling pass. But for example for AArch64 there are 3 scheduling passes in the default pi

Re: [vec-cmp, patch 1/6] Add optabs for vector comparison

2015-10-22 Thread Jeff Law
On 10/22/2015 04:35 AM, Ilya Enkovich wrote: 2015-10-21 20:25 GMT+03:00 Jeff Law : On 10/08/2015 08:52 AM, Ilya Enkovich wrote: Hi, This series introduces autogeneration of vector comparison and its support on i386 target. It lets comparison statements to be vectorized into vector comparison

Change behavior of -fsched-verbose option

2015-10-22 Thread Nikolai Bozhenov
Hi! Currently -fsched-verbose option redirects debugging dumps to stderr if there is no dump_file for the current pass. It would be fine if there were the only scheduling pass. But for example for AArch64 there are 3 scheduling passes in the default pipeline: sched1, fusion and sched2. So, when p

[hsa] Also copy distribute pre-body

2015-10-22 Thread Martin Jambor
Hi, I had to interrupt my porting to OpenMP 4.5 to fix this bug. We were not copying the distribute loop pre-body to before target, thus setting the grid size of quite a few kernels to bogus values. Fixed thusly and committed to the branch. Thanks, Martin 2015-10-22 Martin Jambor

more accurate omp in fortran

2015-10-22 Thread Cesar Philippidis
Currently, for certain omp and oacc errors the fortran will inaccurately report exactly where in the omp/acc construct the error has occurred. E.g. !$acc parallel copy (i) copy (i) copy (j) 1 Error: Symbol ‘i’ present on multiple clauses at (1) instea

Re: RFA/RFC: insns that do not start a source line

2015-10-22 Thread Bernd Schmidt
On 10/22/2015 05:08 PM, Bernd Schmidt wrote: So I'm not entirely sure yet what's supposed to happen here, but I think the problem could well be in the expansion phase. Forgot to mention another possibility that crossed my mind: don't compare locations for equality in fixup_reorder_chain, inst

Re: RFA/RFC: insns that do not start a source line

2015-10-22 Thread Bernd Schmidt
On 10/22/2015 04:19 PM, Nick Clifton wrote: It is in cfgrtl.c:fixup_reorder_chain() nb = split_edge (e); if (!INSN_P (BB_END (nb))) BB_END (nb) = emit_insn_after_noloc (gen_nop (), BB_END (nb), nb); INSN_LOCATION (BB_END (nb)) = e->goto_lo

Re: Constify host-side offload data`

2015-10-22 Thread Ilya Verbin
On Thu, Oct 22, 2015 at 07:35:55 -0700, H.J. Lu wrote: > On Thu, Oct 22, 2015 at 7:11 AM, Ilya Verbin wrote: > > On Wed, Oct 21, 2015 at 10:44:56 -0700, H.J. Lu wrote: > >> On Wed, Oct 21, 2015 at 10:42 AM, Ilya Verbin wrote: > >> > On Wed, Oct 21, 2015 at 10:38:10 -0700, H.J. Lu wrote: > >> >> O

Re: [PATCH, MIPS, PR/61114] Migrate to reduc_..._scal optabs.

2015-10-22 Thread Alan Lawrence
On closer inspection I think you can also remove this guy (from loongson.md): (define_insn "reduc_uplus_v8qi" [(set (match_operand:V8QI 0 "register_operand" "=f") (unspec:V8QI [(match_operand:V8QI 1 "register_operand" "f")] UNSPEC_LOONGSON_BIADD))] "TARGET_HARD_FL

Re: [OpenACC 11/11] execution tests

2015-10-22 Thread Cesar Philippidis
On 10/22/2015 08:00 AM, Jakub Jelinek wrote: > On Thu, Oct 22, 2015 at 07:47:01AM -0700, Cesar Philippidis wrote: >>> But it is unclear from the parsing what from these is allowed: >> >> int v, w; >> ... >> gang(26) // equivalent to gang(num:26) >> gang(v) // gang(num:v) >> vector(length: 16) /

Re: Benchmarks of v2 (was Re: [PATCH 0/5] RFC: Overhaul of diagnostics (v2))

2015-10-22 Thread David Malcolm
On Mon, 2015-10-19 at 16:51 +0200, Michael Matz wrote: > Hi, > > On Fri, 16 Oct 2015, David Malcolm wrote: > > > This fixes much of the bloat seen for influence.i when sending ranges > > through for every token. > > Yeah, I think that's on the right track. Thanks. > > This was with 8 bits al

Re: [OpenACC 11/11] execution tests

2015-10-22 Thread Jakub Jelinek
On Thu, Oct 22, 2015 at 07:47:01AM -0700, Cesar Philippidis wrote: > > But it is unclear from the parsing what from these is allowed: > > int v, w; > ... > gang(26) // equivalent to gang(num:26) > gang(v) // gang(num:v) > vector(length: 16) // vector(length: 16) > vector(length: v) // vector(

Re: [OpenACC 11/11] execution tests

2015-10-22 Thread Nathan Sidwell
On 10/22/15 10:47, Cesar Philippidis wrote: Interesting question. The spec is unclear. It defines gang, worker and vector as follows in section 2.7 in the OpenACC 2.0a spec: gang [( gang-arg-list )] worker [( [num:] int-expr )] vector [( [length:] int-expr )] where gang-arg is one of:

Re: [OpenACC 2/11] PTX backend changes

2015-10-22 Thread Nathan Sidwell
On 10/22/15 10:32, Jakub Jelinek wrote: There is a warning for if (cond); but not for if (cond) ; or if (cond) /* comment */ ; which is the style used in various places throughout the compiler. Sadly, that's not quite accurate. The warning occurs for all the empty if's you

Re: [OpenACC 11/11] execution tests

2015-10-22 Thread Cesar Philippidis
On 10/22/2015 07:23 AM, Nathan Sidwell wrote: > On 10/22/15 10:05, Jakub Jelinek wrote: >> On Thu, Oct 22, 2015 at 09:53:46AM -0400, Nathan Sidwell wrote: >>> On 10/22/15 05:37, Jakub Jelinek wrote: >>> And, I must say I'm at least missing testcases that check parsing but also runtim

Re: [OpenACC 1/11] UNIQUE internal function

2015-10-22 Thread Nathan Sidwell
On 10/22/15 10:30, Richard Biener wrote: On Thu, Oct 22, 2015 at 3:24 PM, Nathan Sidwell wrote: Essentially, yes. a set of IFN_UNIQUE form a group which must not be separated from each other. The set is discovered implicitly by following the CFG (though I suppose we could add an identifyin

Re: [OpenACC 2/11] PTX backend changes

2015-10-22 Thread Nathan Sidwell
On 10/22/15 10:28, Bernd Schmidt wrote: On 10/22/2015 04:24 PM, Nathan Sidwell wrote: + else +{ /* Parent will skip this parallel itself. */ } Here too - actually no need to have an empty else at all. I wanted somewhere clear for the comment to go. (Actually, I think this is the on

Re: Constify host-side offload data`

2015-10-22 Thread H.J. Lu
On Thu, Oct 22, 2015 at 7:11 AM, Ilya Verbin wrote: > On Wed, Oct 21, 2015 at 10:44:56 -0700, H.J. Lu wrote: >> On Wed, Oct 21, 2015 at 10:42 AM, Ilya Verbin wrote: >> > On Wed, Oct 21, 2015 at 10:38:10 -0700, H.J. Lu wrote: >> >> On Wed, Oct 21, 2015 at 10:33 AM, Ilya Verbin wrote: >> >> > H.J.

  1   2   >