Re: [PATCH][ARM] Fix for testcase after r228661

2015-10-21 Thread Ramana Radhakrishnan
On Tue, Oct 20, 2015 at 5:38 PM, Andre Vieira wrote: > > > On 20/10/15 17:25, Ramana Radhakrishnan wrote: >> >> On Tue, Oct 20, 2015 at 4:52 PM, Andre Vieira >> wrote: >>> >>> Hi, >>> >>> This patch addresses PR-67948 by changing the xor-and.c test, initially >>> written for a simplify-rtx patter

Re: [Patch AArch64 63304] Fix issue with global state.

2015-10-21 Thread Ramana Radhakrishnan
> Yuk... but I don't have a better suggestion to hand. Yeah , it didn't feel right to bloat cfun->machine for this... > >> +++ b/gcc/testsuite/gcc.target/aarch64/pr63304-1.c > > In that directory I've been pestering folks to follow the name > convention on the wiki for new additions, so _1 please

Re: [PATCH v2 12/13] Document the x86 address spaces

2015-10-21 Thread Sandra Loosemore
On 10/20/2015 03:27 PM, Richard Henderson wrote: --- gcc/doc/extend.texi | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index bdbf513..677a4d4 100644 --- a/gcc/doc/extend.texi +++ b/g

Re: [PATCH v2 08/13] Add TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID

2015-10-21 Thread Sandra Loosemore
On 10/20/2015 03:27 PM, Richard Henderson wrote: +@deftypefn {Target Hook} bool TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID (addr_space_t @var{as}) +Define this to modify the default handling of address 0 for the +address space. Return true if 0 should be considered a valid address. +@end deftypefn +

Add non-constant vector ctors to operand_equal_p

2015-10-21 Thread Jan Hubicka
Hi, this patch adds matching of non-constant CONSTRUCTOR expressions into operand_equal_p. As discussed with Richard, those can happen when we are building vectors out of components. I also added a testcase that triggers this path and gets folded bit earlier (tree-ssa fold it in tree-pre eventuall

Re: [PATCH] gcc/fold-const.c: Correct the report warning position.

2015-10-21 Thread Chen Gang
Hello all: It is for bug63510, which reported by another members (not me), I guess, this patch should fix this bug. Welcome any other members' ideas, suggestions, and completions. Thanks. On 10/13/15 06:36, Chen Gang wrote: > Hello all: > > Is this patch OK? If it still needs to do anything, p

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-21 Thread Jeff Law
On 10/18/2015 06:56 PM, Mikhail Maltsev wrote: On 10/12/2015 11:57 PM, Jeff Law wrote: >On 10/06/2015 06:40 AM, Bernd Schmidt wrote: >>I'm not entirely sure what to make of this series. There seem to be good >>bits in there but also some things I find questionable. I'll add some >>comments on t

Re: Add VIEW_CONVERT_EXPR to operand_equal_p

2015-10-21 Thread Jan Hubicka
> > > > * tree.c (verify_type): Verify that TYPE_MODE match > > between TYPE_CANONICAL and type. > > * expr.c (store_expr_with_bounds): Revert my previous change. > > * expmed.c (store_bit_field_1): Revert prevoius change. > > * gimple-expr.c (useless_type_conversion_p): Requir

Re: [Patch, MIPS] Frame header optimization for MIPS (part 2)

2015-10-21 Thread Joseph Myers
On Wed, 21 Oct 2015, Bernd Schmidt wrote: > On 10/21/2015 11:29 PM, Joseph Myers wrote: > > On Wed, 21 Oct 2015, Steve Ellcey wrote: > > > > > Hm, how about a separate warning that wasn't part of -Wall but could > > > still be used by GCC or other products that wanted to enforce a 'no > > > unnec

Re: [PATCH 1 of 2] print help for undocumented options

2015-10-21 Thread Joseph Myers
On Wed, 21 Oct 2015, Martin Sebor wrote: > I went ahead and fixed all the .opt files as you suggested. > Even with scripting it was a lot more work that I initially > planned or expected but it's done now. Since those changes > are large and mechanical, I will submit them in a standalone > patch,

Re: [PATCH 2 of 2] print help for undocumented options

2015-10-21 Thread Joseph Myers
On Wed, 21 Oct 2015, Martin Sebor wrote: > Following up on PATCH 1 of 2 (below), attached is patch 2 for PR > driver/68043 with mostly generated changes to .opt files to end > each final sentence describing an option with a period. > > https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02171.html O

Re: [Patch, MIPS] Frame header optimization for MIPS (part 2)

2015-10-21 Thread Bernd Schmidt
On 10/21/2015 11:29 PM, Joseph Myers wrote: On Wed, 21 Oct 2015, Steve Ellcey wrote: Hm, how about a separate warning that wasn't part of -Wall but could still be used by GCC or other products that wanted to enforce a 'no unnecessary parenthesis' coding style. Not that I'm volunteering. What

Re: [PATCH] PR fortran/67939 -- Fix zero length strings in DATA statement

2015-10-21 Thread Steve Kargl
On Wed, Oct 21, 2015 at 11:20:55PM +0200, Paul Richard Thomas wrote: > > It looks good to me - OK to commit. > > Cheers > > Paul > > PS You, as far as I can tell, are the second most prolific bug fixer > of 2015. The only person that beats you is Mr(or Ms) Unassigned. We > need to sort out who

Re: [Patch, MIPS] Frame header optimization for MIPS (part 2)

2015-10-21 Thread Joseph Myers
On Wed, 21 Oct 2015, Steve Ellcey wrote: > Hm, how about a separate warning that wasn't part of -Wall but could > still be used by GCC or other products that wanted to enforce a 'no > unnecessary parenthesis' coding style. Not that I'm volunteering. What's "unnecessary"? It's normal in GNU styl

Re: [PATCH v2 08/13] Add TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID

2015-10-21 Thread Jeff Law
On 10/21/2015 02:50 PM, Richard Henderson wrote: On 10/21/2015 03:57 AM, Jeff Law wrote: On 10/20/2015 03:27 PM, Richard Henderson wrote: --- gcc/config/i386/i386.c | 10 ++ gcc/doc/tm.texi| 5 + gcc/doc/tm.texi.in | 2 ++ gcc/fold-const.c | 6 +- gcc/

Re: [PATCH] PR fortran/67939 -- Fix zero length strings in DATA statement

2015-10-21 Thread Paul Richard Thomas
Hi Steve, It looks good to me - OK to commit. Cheers Paul PS You, as far as I can tell, are the second most prolific bug fixer of 2015. The only person that beats you is Mr(or Ms) Unassigned. We need to sort out who this person is. On 21 October 2015 at 22:05, Steve Kargl wrote: > The att

[PATCH] Fix arm-none-eabi -mbig-endian -flto

2015-10-21 Thread Jonathan Roelofs
This fixes: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67871 2015-10-20 Jonathan Roelofs * config/arm/bpabi.h: Tell the linker which emulation to use based on the endianness of the target. 2015-10-20 Jonathan Roelofs * ld/configure.tgt: Support big-endian emula

[patch] Define Feature-test macro for std::bool_constant

2015-10-21 Thread Jonathan Wakely
The latest feature-testing document defines the __cpp_lib_bool_constant macro, so this uncomments the placeholder I left in . Tested powerpc64le-linux, committed to trunk. commit 00ce7154a868daa8195d5bbc0b04370edf3e0de8 Author: Jonathan Wakely Date: Wed Oct 21 07:34:28 2015 +0100 * inc

Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp

2015-10-21 Thread Jeff Law
On 10/06/2015 06:40 AM, Bernd Schmidt wrote: I'm not entirely sure what to make of this series. There seem to be good bits in there but also some things I find questionable. I'll add some comments on things that occur to me. On 10/06/2015 01:28 AM, Mikhail Maltsev wrote: * include/line-map

Re: [PATCH] PR fortran/67939 -- Fix zero length strings in DATA statement

2015-10-21 Thread FX
> 2015-10-21 Steven G. Kargl > > PR fortran/67939 > * data.c (create_character_initializer): Deal with zero length string. > > 2015-10-21 Steven G. Kargl > > PR fortran/67939 > * gfortran.dg/pr67939.f90: New test. OK, thanks

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Jeff Law
On 10/18/2015 12:17 AM, Mikhail Maltsev wrote: Also, gcc_checking_assert in libcpp requires gcc_assert to be defined. That was missing in my original patch (and was added in patch 2/9), but I think it would be better to fix it here, as Bernd noticed (in the last paragraph of [1]). Besides, I li

Re: [PATCH 1 of 2] print help for undocumented options

2015-10-21 Thread Martin Sebor
I went ahead and fixed all the .opt files as you suggested. Even with scripting it was a lot more work that I initially planned or expected but it's done now. Since those changes are large and mechanical, I will submit them in a standalone patch, separate from code changes that I include in this

Re: [patch] Fix failure of ACATS c45503c at -O2

2015-10-21 Thread Richard Sandiford
Eric Botcazou writes: >> Maybe add the comments to tree.def instead. > > Good idea, revised patch attached. > > > * tree.def (CEIL_DIV_EXPR, FLOOR_DIV_EXPR, ROUND_DIV_EXPR): Tweak > comments. > (TRUNC_MOD_EXPR, CEIL_MOD_EXPR, FLOOR_MOD_EXPR, ROUND_MOD_EXPR): > Add comments

[PATCH 2/2] [graphite] a scalar depending on vdefs in the current region is not invariant

2015-10-21 Thread Sebastian Pop
When a scalar is defined in function of an array reference in the current scop, it does variate. Graphite cannot represent the condition in scop-11.c, as a[*] variates in the current region, and it is not an affine condition: for (j = 0; j <= 20; j++) a[j] = b + i; if (a[12] == 23) b

[PATCH 1/2] [graphite] add an upper limit on the number of array references

2015-10-21 Thread Sebastian Pop
* graphite-scop-detection.c (build_scops): Do not handle scops with more than PARAM_GRAPHITE_MAX_ARRAYS_PER_SCOP arrays. * params.def (PARAM_GRAPHITE_MAX_ARRAYS_PER_SCOP): New. --- gcc/graphite-scop-detection.c | 11 +++ gcc/params.def| 7 +++ 2

Re: [C++ Patches] PR c++/66781 and c++/67847

2015-10-21 Thread Jason Merrill
OK. Jason

Re: [PATCH v2 08/13] Add TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID

2015-10-21 Thread Richard Henderson
On 10/21/2015 03:57 AM, Jeff Law wrote: On 10/20/2015 03:27 PM, Richard Henderson wrote: --- gcc/config/i386/i386.c | 10 ++ gcc/doc/tm.texi| 5 + gcc/doc/tm.texi.in | 2 ++ gcc/fold-const.c | 6 +- gcc/gimple.c | 12 +--- gcc/target.

Re: [PATCH v2 02/13] Relax ADDR_SPACE_GENERIC_P checks for default address space hooks

2015-10-21 Thread Richard Henderson
On 10/21/2015 03:59 AM, Jeff Law wrote: On 10/20/2015 03:27 PM, Richard Henderson wrote: If all address spaces use the same modes and forms, we would be forced to replicate these hooks in the backend. Which would then require the creation of a new hook to replace target_default_pointer_address_

Re: [Patch, MIPS] Patch to fix MIPS optimization bug in combine

2015-10-21 Thread Steve Ellcey
Andrew, Here is the new patch that I am currently testing with your change and incorporating Eric's comment. I included both test cases but renamed yours and put it into gcc.dg/torture. Does the code in combine.c to address Eric's comment look OK to you? Steve Ellcey steve.ell...@imgtec.com 2

Re: [C++ Patches] PR c++/66781 and c++/67847

2015-10-21 Thread Paolo Carlini
Hi, and thanks a lot for your quick and helpful reply. On 10/21/2015 09:19 PM, Jason Merrill wrote: On 10/21/2015 04:37 AM, Paolo Carlini wrote: +"%qD is not an enumerator-name", identifier); This should be enum-name or "does not name an enumeration". We should also print the n

Fix PR ipa/67056

2015-10-21 Thread Jan Hubicka
Hi, this patch fixes a thinko in possible_placement_new which derives that placement new can not happen before beggining of the memory location of the known type. While analysitng the testcase I found that check_stmt_for_type_change is bit stupid to stop on first construction found. In case the co

Re: [OpenACC 11/11] execution tests

2015-10-21 Thread Nathan Sidwell
On 10/21/15 16:14, Ilya Verbin wrote: <11-trunk-tests.patch> Does the testcase with offload IR appear here accidentally? D'oh! yup, fixed. nathan 2015-10-20 Nathan Sidwell * testsuite/libgomp.oacc-c-c++-common/loop-g-1.c: New. * testsuite/libgomp.oacc-c-c++-common/loop-w-1.c: New. *

Re: [PATCH v3] SH FDPIC backend support

2015-10-21 Thread Rich Felker
On Wed, Oct 21, 2015 at 10:17:51PM +0900, Oleg Endo wrote: > Rich, > > Thanks for the updated patch. > Please do not start new threads for a continuation of an existing > thread. This makes it difficult to track in the archives. > > On Tue, 2015-10-20 at 23:41 -0400, Rich Felker wrote: > > Attac

Re: [OpenACC 11/11] execution tests

2015-10-21 Thread Ilya Verbin
> On 21 Oct 2015, at 22:53, Nathan Sidwell wrote: > > This patch has some new execution tests, verifying loop partitioning is > behaving as expected. > > There are more execution tests on the gomp4 branch, but many of them use > reductions. We'll merge those once reductions are merged. > >

[PATCH] PR fortran/67939 -- Fix zero length strings in DATA statement

2015-10-21 Thread Steve Kargl
The attach patch properly sets the length for a zero length string in a data. Built and regression tested on x86_64-*-freebsd. The testcase is self-explanatory. OK to commit? 2015-10-21 Steven G. Kargl PR fortran/67939 * data.c (create_character_initializer): Deal with zero

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Jeff Law
On 10/21/2015 10:22 AM, Bernd Schmidt wrote: On 10/21/2015 06:18 PM, Jeff Law wrote: To avoid conditionally compiled code. I'm of the opinion we should be stomping out as much as we reasonably can. Yeah, I get that, but the point I'm trying to make is that if you get rid of all conditional co

Re: [Patch, MIPS] Patch to fix MIPS optimization bug in combine

2015-10-21 Thread Segher Boessenkool
Hi, On Wed, Oct 21, 2015 at 09:44:25AM -0700, Steve Ellcey wrote: > (jump_insn 16 15 17 2 (set (pc) > (if_then_else (ne (subreg:SI (reg:DI 207) 4) > (subreg:SI (reg:DI 196 [ *last_3(D)+-4 ]) 4)) > (label_ref:DI 35) > (pc))) x.c:21 472 {*branch_equal

Re: [Patch, MIPS] Patch to fix MIPS optimization bug in combine

2015-10-21 Thread Andrew Pinski
On Thu, Oct 22, 2015 at 3:32 AM, wrote: > > >> On Oct 22, 2015, at 12:44 AM, Steve Ellcey wrote: >> >> >> A bug was reported against the GCC MIPS64 compiler that involves a bad >> combine >> and this patch fixes the bug. >> >> When using '-fexpensive-optimizations -march=mips64r2 -mabi=64' GCC

Re: [OpenACC 8/11] device-specific lowering

2015-10-21 Thread Nathan Sidwell
This patch is the device-specific half of the previous patch. It processes the partition head & tail markers and loop abstraction functions inserted during omp lowering. In the oacc_device_lower pass we scan the CFG reconstructing the set of nested loops demarked by IFN_UNIQUE (HEAD_MARK) & I

Re: [OpenACC 11/11] execution tests

2015-10-21 Thread Nathan Sidwell
This patch has some new execution tests, verifying loop partitioning is behaving as expected. There are more execution tests on the gomp4 branch, but many of them use reductions. We'll merge those once reductions are merged. nathan 2015-10-20 Nathan Sidwell * testsuite/libgomp.oacc-c-c+

Re: [Patch, MIPS] Patch to fix MIPS optimization bug in combine

2015-10-21 Thread Andrew Pinski
On Thu, Oct 22, 2015 at 3:47 AM, Segher Boessenkool wrote: > Hi, > > On Wed, Oct 21, 2015 at 09:44:25AM -0700, Steve Ellcey wrote: >> (jump_insn 16 15 17 2 (set (pc) >> (if_then_else (ne (subreg:SI (reg:DI 207) 4) >> (subreg:SI (reg:DI 196 [ *last_3(D)+-4 ]) 4)) >>

Re: [OpenACC 10/11] remove plugin restriction

2015-10-21 Thread Nathan Sidwell
Here's another obvious patch. The ptx plugin no longer needs to barf on gang or worker dimensions of non-unity. nathan 2015-10-20 Nathan Sidwell * plugin/plugin-nvptx.c (nvptx_exec): Remove check on compute dimensions. Index: libgomp/plugin/plugin-nvptx.c ==

Re: [OpenACC 9/11] oacc_device_lower pass gate

2015-10-21 Thread Nathan Sidwell
This patch is obvious, but included for completeness. We always want to run the device lowering pass (when openacc is enabled), in order to delete the marker and loop functions that should never be seen after this point. nathan 2015-10-20 Nathan Sidwell * omp-low.c (pass_oacc_device_lowe

Re: [OpenACC 7/11] execution model

2015-10-21 Thread Nathan Sidwell
This patch is the early lowering part of OpenACC loops. Rather than piggy-back onto expand_omp_for_static_nochunk & expand_omp_for_static_chunk, we have a new function 'expand_oacc_for', which does the OpenACC equivalent expension. Except that it uses a new internal builtin to abstract the ac

Re: [Patch, MIPS] Frame header optimization for MIPS (part 2)

2015-10-21 Thread Steve Ellcey
On Wed, 2015-10-21 at 20:45 +0200, Bernd Schmidt wrote: > On 10/21/2015 07:38 PM, Mike Stump wrote: > > On Oct 20, 2015, at 3:55 PM, Bernd Schmidt wrote: > >> There are many unnecessary parentheses in this patch which should be > >> removed. > > > > I can smell a -Wall patch. :-) > > Not really

Re: [Patch, MIPS] Patch to fix MIPS optimization bug in combine

2015-10-21 Thread pinskia
> On Oct 22, 2015, at 12:44 AM, Steve Ellcey wrote: > > > A bug was reported against the GCC MIPS64 compiler that involves a bad combine > and this patch fixes the bug. > > When using '-fexpensive-optimizations -march=mips64r2 -mabi=64' GCC is > combining these instructions: > > (insn 13 12

Re: [OpenACC 6/11] Reduction initialization

2015-10-21 Thread Nathan Sidwell
This patch is a temporary measure to avoid breaking reductions, until I post the reductions patch set (which builds on this). Currently OpenACC reductions are handled by (a) spawning all threads throughout the offload region (b) having them each individually write to an allocated slot in a 'redu

Re: [C++ Patches] PR c++/66781 and c++/67847

2015-10-21 Thread Jason Merrill
On 10/21/2015 04:37 AM, Paolo Carlini wrote: + "%qD is not an enumerator-name", identifier); This should be enum-name or "does not name an enumeration". We should also print the nested-name-specifier. + error_at (type_start_token->location, "nested name specif

Re: [OpenACC 5/11] C++ FE changes

2015-10-21 Thread Nathan Sidwell
This patch is the C++ changes matching the C ones of patch 4. In finish_omp_clauses, the gang, worker, & vector clauses are handled the same as OpenMP's 'num_threads' clause. One change to num_threads is the augmentation of a diagnostic to add %<...%> markers to the clause name. nathan 201

Re: [OpenACC 4/11] C FE changes

2015-10-21 Thread Nathan Sidwell
This patch implements changes to the C parser to deal with the 'gang', 'worker', 'vector', 'seq' and 'auto' clauses on an OpenACC loop directive. The first 3 can take a numeric argument, which is used within a kernels offload region and the gang clause can take an additional 'static' argument,

Re: [OpenACC 2/11] PTX backend changes

2015-10-21 Thread Nathan Sidwell
This patch is the PTX backend changes for partitioned execution. We implement some new expanders: oacc_dim_size, oacc_dim_pos -- span and location within the compute cube oacc_fork, oacc_join -- expanders for IFN_UNIQUE (OACC_FORK) & IFN_UNIQUE (OACC_JOIN) The fork & join markers are non-copya

Re: [OpenACC 3/11] new target hook

2015-10-21 Thread Nathan Sidwell
This patch implements a new OpenACC target hook. It is used during device-specific lowering and allows a backend to indicate whether it needs to know about a fork/join for a particular axis. For instance, in PTX we don't care about gang-level fork and join. We also don't care if the size of

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Richard Henderson
On 10/21/2015 06:19 AM, Ulrich Weigand wrote: Richard Henderson wrote: +@deftypefn {Target Hook} int TARGET_ADDR_SPACE_DEBUG (addr_space_t @var{as}) +Define this to define how the address space is encoded in dwarf. +The result, @var{r}, should be positive to indicate +@code{DW_AT_address_class

Re: Handle CONSTRUCTOR in operand_equal_p

2015-10-21 Thread Jan Hubicka
Hi, this is updated patch I am going to commit. As discussed, we also need to match non-empty CONSTRUCTOR of vectors, but those should never be having CONSTANT flags set, so they need care in the other path trhough operand_equal_p, so I will post separate patch for that. I updated the comment pe

[PATCH] Add missing INCLUDE_DEFAULTS_MUSL_LOCAL

2015-10-21 Thread Doug Evans
Heya. I happened to notice local prefixes not working with musl. Fixes thusly. 2015-10-21 Doug Evans * config/linux.h (INCLUDE_DEFAULTS): Add INCLUDE_DEFAULTS_MUSL_LOCAL. Index: config/linux.h === --- config/linux.h

Re: [OpenACC 1/11] UNIQUE internal function

2015-10-21 Thread Nathan Sidwell
This patch implements a new internal function that has a 'uniqueness' property. Jump-threading cannot clone it and tail-merging cannot combine multiple instances. The uniqueness is implemented by a new gimple fn, gimple_call_internal_unique_p. Routines that check for identical or cloneable

[OpenACC 0/11] execution model

2015-10-21 Thread Nathan Sidwell
I'll be posting a patch series for trunk, which implements the core of the OpenACC execution model. This is split into the following patches: 01-trunk-unique.patch Internal function with a 'uniqueness' property 02-trunk-nvptx-partition.patch NVPTX backend patch set for partitioned execution

Re: [Patch, MIPS] Frame header optimization for MIPS (part 2)

2015-10-21 Thread Bernd Schmidt
On 10/21/2015 07:38 PM, Mike Stump wrote: On Oct 20, 2015, at 3:55 PM, Bernd Schmidt wrote: There are many unnecessary parentheses in this patch which should be removed. I can smell a -Wall patch. :-) Not really, because -Wall isn't in the business of enforcing a coding style. Bernd

[OpenACC 0/11] execution model

2015-10-21 Thread Nathan Sidwell
I'll be posting a patch series for trunk, which implements the core of the OpenACC execution model. This is split into the following patches: 01-trunk-unique.patch Internal function with a 'uniqueness' property 02-trunk-nvptx-partition.patch NVPTX backend patch set for partitioned execution

[PATCH] [graphite] avoid generation of empty guards in trivial cases

2015-10-21 Thread Sebastian Pop
We used to insert a trivial integer_onep condition around loops we know have more than an iteration. This patch avoids generating those conditions. * graphite-isl-ast-to-gimple.c (graphite_create_new_loop_guard): Do not call create_empty_if_region_on_edge when cond_expr is true.

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread H.J. Lu
The i386 psABI draft is at https://github.com/hjl-tools/x86-psABI/wiki/intel386-psABI-20151021.pdf -- H.J.

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-10-21 Thread Richard Henderson
On 10/21/2015 03:56 AM, Richard Biener wrote: On Wed, Oct 21, 2015 at 2:45 PM, Richard Biener wrote: On Tue, Oct 20, 2015 at 10:03 PM, Kugan wrote: On 07/09/15 12:53, Kugan wrote: This a new version of the patch posted in https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00226.html. I have do

Re: [PATCH v2 09/13] Fix PR 66768

2015-10-21 Thread Richard Henderson
On 10/21/2015 03:55 AM, Jeff Law wrote: On 10/20/2015 03:27 PM, Richard Henderson wrote: --- gcc/tree-ssa-address.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I think this change is fine. Needs a testcase though. I'll also note you need ChangeLogs for all these patches. I know

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Richard Henderson
On 10/21/2015 07:23 AM, H.J. Lu wrote: We can define them as 93 and 94. 50-92 were used for other registers before and have been deprecated now. But some old tools may still use them. Thanks. I'll update the patch. r~

Re: [vec-cmp, patch 5/6] Disable bool patterns when possible

2015-10-21 Thread Jeff Law
On 10/08/2015 09:15 AM, Ilya Enkovich wrote: Hi, This patch disables transformation of boolean computations into integer ones in case target supports vector comparison. Pattern still applies to transform resulting boolean value into integer or avoid COND_EXPR with SSA_NAME as condition. Tha

Re: [vec-cmp, patch 5/6] Disable bool patterns when possible

2015-10-21 Thread Jeff Law
On 10/08/2015 09:15 AM, Ilya Enkovich wrote: Hi, This patch disables transformation of boolean computations into integer ones in case target supports vector comparison. Pattern still applies to transform resulting boolean value into integer or avoid COND_EXPR with SSA_NAME as condition. Tha

Re: [PATCH] Fix bootsrap/68041

2015-10-21 Thread Mike Stump
On Oct 21, 2015, at 8:01 AM, Jakub Jelinek wrote: > On Wed, Oct 21, 2015 at 05:56:42PM +0300, Maxim Ostapenko wrote: >> >> recent libsanitizer merge ( >> https://gcc.gnu.org/ml/gcc-patches/2015-10/msg01851.html) broke bootstrap on >> x86_64-apple-darwin14 because for Darwin sanitizer libs shouldn

Re: Constify host-side offload data`

2015-10-21 Thread Nathan Sidwell
On 10/21/15 13:33, Ilya Verbin wrote: Hi! This happens because .gnu.offload_{funcs,vars} sections in crtoffload{begin,end}.o now doesn't have WRITE flag, but the same sections produced by omp_finish_file has it. When linker joins writable + nonwritable sections from several objects, it insert

Re: Constify host-side offload data`

2015-10-21 Thread H.J. Lu
On Wed, Oct 21, 2015 at 10:42 AM, Ilya Verbin wrote: > On Wed, Oct 21, 2015 at 10:38:10 -0700, H.J. Lu wrote: >> On Wed, Oct 21, 2015 at 10:33 AM, Ilya Verbin wrote: >> > H.J., >> > Maybe linker should print some warning about joining writable + nonwritable >> > sections? Here is a simple testca

Re: Constify host-side offload data`

2015-10-21 Thread Ilya Verbin
On Wed, Oct 21, 2015 at 10:38:10 -0700, H.J. Lu wrote: > On Wed, Oct 21, 2015 at 10:33 AM, Ilya Verbin wrote: > > H.J., > > Maybe linker should print some warning about joining writable + nonwritable > > sections? Here is a simple testcase: > > > > $ cat t1.s > > .section ".AAA", "a" > > .long 0x

Re: [Patch, MIPS] Frame header optimization for MIPS (part 2)

2015-10-21 Thread Mike Stump
On Oct 20, 2015, at 3:55 PM, Bernd Schmidt wrote: > On 10/16/2015 10:21 PM, Steve Ellcey wrote: >> Here is the second part of the MIPS frame header optimization patch. > > I'll leave reviewing the functionality to the MIPS maintainers. But... > >> + return TARGET_OLDABI && flag_frame_heade

Re: Constify host-side offload data`

2015-10-21 Thread H.J. Lu
On Wed, Oct 21, 2015 at 10:33 AM, Ilya Verbin wrote: > Hi! > > On Wed, Jul 15, 2015 at 20:56:50 -0400, Nathan Sidwell wrote: >> --- libgcc/offloadstuff.c (revision 225851) >> +++ libgcc/offloadstuff.c (working copy) >> ... >> -void *__offload_func_table[0] >> +const void *const __offload_f

Re: Constify host-side offload data`

2015-10-21 Thread Ilya Verbin
Hi! On Wed, Jul 15, 2015 at 20:56:50 -0400, Nathan Sidwell wrote: > --- libgcc/offloadstuff.c (revision 225851) > +++ libgcc/offloadstuff.c (working copy) > ... > -void *__offload_func_table[0] > +const void *const __offload_func_table[0] > ... > -void *__offload_var_table[0] > +const void

Re: [vec-cmp, patch 1/6] Add optabs for vector comparison

2015-10-21 Thread Jeff Law
On 10/08/2015 08:52 AM, Ilya Enkovich wrote: Hi, This series introduces autogeneration of vector comparison and its support on i386 target. It lets comparison statements to be vectorized into vector comparison instead of VEC_COND_EXPR. This allows to avoid some restrictions implied by boole

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread H.J. Lu
On Wed, Oct 21, 2015 at 10:17 AM, Richard Henderson wrote: > On 10/21/2015 04:53 AM, H.J. Lu wrote: >> >> On Tue, Oct 20, 2015 at 2:27 PM, Richard Henderson wrote: >>> >>> --- >>> gcc/config/i386/i386.c | 21 + >>> gcc/doc/tm.texi| 7 +++ >>> gcc/doc/tm.texi.i

Re: [C PATCH] Warn about variadic functions defined without prototypes (PR c/68024)

2015-10-21 Thread Joseph Myers
On Wed, 21 Oct 2015, Marek Polacek wrote: > Joseph, is this what you had in mind in this PR? With this patch, we > warn anytime we see a prototype-less function that is variadic. It > seems rare enough not to warrant a separate warning option for it. > > Bootstrapped/regtested on x86_64-linux,

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Richard Henderson
On 10/21/2015 04:53 AM, H.J. Lu wrote: On Tue, Oct 20, 2015 at 2:27 PM, Richard Henderson wrote: --- gcc/config/i386/i386.c | 21 + gcc/doc/tm.texi| 7 +++ gcc/doc/tm.texi.in | 2 ++ gcc/dwarf2out.c| 48 +

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-10-21 Thread Joseph Myers
On Wed, 21 Oct 2015, Richard Biener wrote: > Or maybe we should simply make GIMPLE _always_ adhere to the ABI > details from the start (gimplification). Note that this does not only involve > PROMOTE_MODE. Note that for what GIMPLE is concerned I'd only > "lower" passing / returning in registers

Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces

2015-10-21 Thread Richard Henderson
On 10/21/2015 03:37 AM, Jeff Law wrote: On 10/20/2015 03:27 PM, Richard Henderson wrote: --- gcc/cselib.c | 22 +- gcc/fold-const.c | 14 +++--- gcc/testsuite/gcc.target/i386/addr-space-2.c | 11 +

[gomp4] loop nesting check

2015-10-21 Thread Nathan Sidwell
This is the gomp4-branch variant of the loop nesting patch I just committed to trunk. The gomp4 branch had some checking, but a) it didn't catch all erroreous cases b) gave an ambiguous error, by not mentioning 'OpenACC' committed to gomp4 nathan 2015-10-21 Nathan Sidwell gcc/ * omp-low.c

Re: [PATCH] Fix partial template specialization syntax in wide-int.h

2015-10-21 Thread Mike Stump
On Oct 19, 2015, at 12:46 PM, H.J. Lu wrote: Ok. Does this need to go into the gcc-5 release branch as well? If so, ok there too. Thanks. >>> I think there is no need for it. >> >> It is also need for gcc-5. I am backporting it now. > > This is what I checked into gcc-5-branch. Tha

[Patch, MIPS] Patch to fix MIPS optimization bug in combine

2015-10-21 Thread Steve Ellcey
A bug was reported against the GCC MIPS64 compiler that involves a bad combine and this patch fixes the bug. When using '-fexpensive-optimizations -march=mips64r2 -mabi=64' GCC is combining these instructions: (insn 13 12 14 2 (set (reg:DI 206 [ *last_3(D)+-4 ]) (zero_extend:DI (subreg/s

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Jakub Jelinek
On Wed, Oct 21, 2015 at 06:22:37PM +0200, Bernd Schmidt wrote: > On 10/21/2015 06:18 PM, Jeff Law wrote: > >To avoid conditionally compiled code. I'm of the opinion we should be > >stomping out as much as we reasonably can. > > Yeah, I get that, but the point I'm trying to make is that if you get

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Jeff Law
On 10/21/2015 10:18 AM, Richard Biener wrote: On October 21, 2015 6:04:38 PM GMT+02:00, Bernd Schmidt wrote: On 10/21/2015 05:56 PM, Jeff Law wrote: The problem is the existing ENABLE_CHECKING conditions. Anything which is #ifdef ENABLE_CHECKING will have its behavior changed if we change

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Bernd Schmidt
On 10/21/2015 06:18 PM, Jeff Law wrote: To avoid conditionally compiled code. I'm of the opinion we should be stomping out as much as we reasonably can. Yeah, I get that, but the point I'm trying to make is that if you get rid of all conditional compilation, you don't need either ENABLE_CHEC

[C PATCH] Warn about variadic functions defined without prototypes (PR c/68024)

2015-10-21 Thread Marek Polacek
Joseph, is this what you had in mind in this PR? With this patch, we warn anytime we see a prototype-less function that is variadic. It seems rare enough not to warrant a separate warning option for it. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2015-10-21 Marek Polacek P

Re: [PATCH v2 13/13] Add hook for modifying debug info for address spaces

2015-10-21 Thread Ulrich Weigand
Richard Henderson wrote: > +@deftypefn {Target Hook} int TARGET_ADDR_SPACE_DEBUG (addr_space_t @var{as}) > +Define this to define how the address space is encoded in dwarf. > +The result, @var{r}, should be positive to indicate > +@code{DW_AT_address_class @var{r}} should be emitted; or negative >

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Jeff Law
On 10/21/2015 10:04 AM, Bernd Schmidt wrote: On 10/21/2015 05:56 PM, Jeff Law wrote: The problem is the existing ENABLE_CHECKING conditions. Anything which is #ifdef ENABLE_CHECKING will have its behavior changed if we change things so that ENABLE_CHECKING is always defined with a value. So if

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Richard Biener
On October 21, 2015 6:04:38 PM GMT+02:00, Bernd Schmidt wrote: >On 10/21/2015 05:56 PM, Jeff Law wrote: >> The problem is the existing ENABLE_CHECKING conditions. >> >> Anything which is #ifdef ENABLE_CHECKING will have its behavior >changed >> if we change things so that ENABLE_CHECKING is alway

Re: [OpenACC] loop nesting check

2015-10-21 Thread Nathan Sidwell
On 10/21/15 12:06, Bernd Schmidt wrote: Were they just compile tests? Yes, some of the tests already expected errors, but missed some. I think one test didn't expect an error, but is a clearly bogus test. nathan

Re: [gomp4 00/14] NVPTX: further porting

2015-10-21 Thread Bernd Schmidt
On 10/21/2015 05:18 PM, Alexander Monakov wrote: On Wed, 21 Oct 2015, Bernd Schmidt wrote: On 10/20/2015 08:34 PM, Alexander Monakov wrote: This patch series ports enough of libgomp.c to get warp-level parallelism working for OpenMP offloading. The overall approach is as follows. Could you

Re: [OpenACC] loop nesting check

2015-10-21 Thread Jakub Jelinek
On Wed, Oct 21, 2015 at 11:59:03AM -0400, Nathan Sidwell wrote: > Hi, > in preparing a patch set of the OpenACC execution model for trunk, I > discovered some broken tests in the testsuite. We were failing to diagnose > some incorrectly nested loops, and that led to ICEs in my patch set. > > This

Re: [OpenACC] loop nesting check

2015-10-21 Thread Bernd Schmidt
On 10/21/2015 05:59 PM, Nathan Sidwell wrote: in preparing a patch set of the OpenACC execution model for trunk, I discovered some broken tests in the testsuite. We were failing to diagnose some incorrectly nested loops, and that led to ICEs in my patch set. This patch implements a check for op

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Bernd Schmidt
On 10/21/2015 05:56 PM, Jeff Law wrote: The problem is the existing ENABLE_CHECKING conditions. Anything which is #ifdef ENABLE_CHECKING will have its behavior changed if we change things so that ENABLE_CHECKING is always defined with a value. So if we wanted to continue to use ENABLE_CHECKING,

[PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c

2015-10-21 Thread Alan Lawrence
gcc.dg/tree-ssa/sra-12.c is skipped on a bunch of targets, including AArch64, because the default max-scalarization-size depends on MOVE_RATIO, and on those targets thus ends up being too small for SRA to optimize the testcase. Recently I noticed that the test has been failing for some time on ARM

Re: [PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c

2015-10-21 Thread Jeff Law
On 10/21/2015 09:52 AM, Alan Lawrence wrote: gcc.dg/tree-ssa/sra-12.c is skipped on a bunch of targets, including AArch64, because the default max-scalarization-size depends on MOVE_RATIO, and on those targets thus ends up being too small for SRA to optimize the testcase. Recently I noticed that

[OpenACC] loop nesting check

2015-10-21 Thread Nathan Sidwell
Hi, in preparing a patch set of the OpenACC execution model for trunk, I discovered some broken tests in the testsuite. We were failing to diagnose some incorrectly nested loops, and that led to ICEs in my patch set. This patch implements a check for openacc loop directives, checking that the

Re: [PATCH 1/9] ENABLE_CHECKING refactoring

2015-10-21 Thread Jeff Law
On 10/19/2015 07:23 AM, Mikhail Maltsev wrote: On 10/19/2015 02:13 PM, Bernd Schmidt wrote: But for normal C conditions the patches end up using flag_checking, so the CHECKING_P macro buys us nothing over ENABLE_CHECKING. Presumably 'if (CHECKING_P)' can be used for performance-critical parts (

Re: [PATCH] unconditionally compile most of the delay slot code

2015-10-21 Thread Jeff Law
On 10/21/2015 09:13 AM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders Hi, $subject bootstrapped+ regtested x86_64-linux-gnu, I wouldn't mind a second pair of eyes on this one given its not totally trivial. Trev gcc/ChangeLog: 2015-10-20 Trevor Saunders * cfgrtl.c (pass

Re: [gomp4 00/14] NVPTX: further porting

2015-10-21 Thread Alexander Monakov
On Wed, 21 Oct 2015, Bernd Schmidt wrote: > On 10/20/2015 08:34 PM, Alexander Monakov wrote: > > This patch series ports enough of libgomp.c to get warp-level parallelism > > working for OpenMP offloading. The overall approach is as follows. > > Could you elaborate a bit what you mean by this ju

  1   2   >