Re: Mostly rewrite genrecog

2015-05-15 Thread Andreas Krebbel
Hi Richard, I see regressions with the current IBM z13 vector patchset which appear to be related to the new genrecog. The following two insn definitions only differ in the mode and predicate of the shift count operand. (define_insn "lshr3" [(set (match_operand:VI 0 "register_op

Re: [RFC]: Remove Mem/address type assumption in combiner

2015-05-15 Thread Hans-Peter Nilsson
On Fri, 1 May 2015, Segher Boessenkool wrote: > On Wed, Apr 29, 2015 at 12:03:35PM -0500, Segher Boessenkool wrote: > > On Wed, Apr 29, 2015 at 09:25:21AM +, Kumar, Venkataramanan wrote: > > > diff --git a/gcc/combine.c b/gcc/combine.c > > > index 5c763b4..945abdb 100644 > > > --- a/gcc/combine

Re: [patch] Clean up detection of SJLJ exceptions in target libraries

2015-05-15 Thread Ian Lance Taylor
On Wed, May 13, 2015 at 10:52 AM, Eric Botcazou wrote: >> The libgo parts are fine, but since libgo is mirrored from an external >> repository I'll commit those parts myself. > > Thanks! > >> I assume I can go ahead and commit them now? > > Yes, you can, the libgo bits are independent. libgo port

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread Rich Felker
On Fri, May 15, 2015 at 04:34:57PM -0700, H.J. Lu wrote: > On Fri, May 15, 2015 at 4:30 PM, H.J. Lu wrote: > > On Fri, May 15, 2015 at 4:14 PM, H.J. Lu wrote: > >> My relax branch proposal works even without LTO. > >> > > > > I will borrow GOTPCREL from x86-64 and do > > > > [hjl@gnu-6 relax-4]$

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread Rich Felker
On Fri, May 15, 2015 at 04:14:07PM -0700, H.J. Lu wrote: > On Fri, May 15, 2015 at 4:08 PM, Jan Hubicka wrote: > > Hello, > >> > >> There are codes like > >> > >> extern void foo (void); > >> > >> void > >> bar (void) > >> { > >> foo (); > >> } > >> > >> Even with LTO, compiler may have to assum

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 4:30 PM, H.J. Lu wrote: > On Fri, May 15, 2015 at 4:14 PM, H.J. Lu wrote: >> My relax branch proposal works even without LTO. >> > > I will borrow GOTPCREL from x86-64 and do > > [hjl@gnu-6 relax-4]$ cat b.S > call *foo@GOTPCREL(%eax) call *foo@GOTPLT(%eax) is a better c

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 4:14 PM, H.J. Lu wrote: > My relax branch proposal works even without LTO. > I will borrow GOTPCREL from x86-64 and do [hjl@gnu-6 relax-4]$ cat b.S call *foo@GOTPCREL(%eax) [hjl@gnu-6 relax-4]$ ./as -32 -o b.o b.S [hjl@gnu-6 relax-4]$ ./objdump -dwr b.o b.o: file for

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 4:08 PM, Jan Hubicka wrote: > Hello, >> >> There are codes like >> >> extern void foo (void); >> >> void >> bar (void) >> { >> foo (); >> } >> >> Even with LTO, compiler may have to assume foo is external >> when foo is compiled with LTO. > > This is not exactly true if F

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread Jan Hubicka
Hello, > > There are codes like > > extern void foo (void); > > void > bar (void) > { > foo (); > } > > Even with LTO, compiler may have to assume foo is external > when foo is compiled with LTO. This is not exactly true if FOO is defined in other translation unit compiled with LTO and hidde

Re: [PATCH] fortran/64925 -- fix conflict between names

2015-05-15 Thread FX
> 2015-05-XX Steven G. Kargl > > PR fortran/64925 > * symbol.c(check_conflict): Check for a conflict between a dummy > argument and an internal procedure name. > > 2015-05-XX Steven G. Kargl > > PR fortran/64925 > * gfortran.dg/pr64925.f90: New test. OK

Re: [PATCH] Handle OS X deployment targets correctly

2015-05-15 Thread Mike Stump
On May 14, 2015, at 11:42 PM, Lawrence Velázquez wrote: > As described in PR target/63810, this addresses several problems > With this change, trunk matches the behavior of Apple LLVM Compiler > 6.1.0 on 8,451 of 8,464 generated test inputs. (The discrepancies are > due to a bug in Clang.) I do

[match-and-simplify] fix incorrect code-gen in 'for' pattern

2015-05-15 Thread Prathamesh Kulkarni
Hi, genmatch generates incorrect code for following (artificial) pattern: (for op (plus) op2 (op) (simplify (op @x @y) (op2 @x @y) generated gimple code: http://pastebin.com/h1uau9qB 'op' is not replaced in the generated code on line 33: *res_code = op; I think it would be a bett

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 1:42 PM, Rich Felker wrote: > On Fri, May 15, 2015 at 01:35:14PM -0700, H.J. Lu wrote: >> On Fri, May 15, 2015 at 1:23 PM, Rich Felker wrote: >> > On Fri, May 15, 2015 at 01:08:15PM -0700, H.J. Lu wrote: >> >> With relax branch in 32-bit, there are 2 cases: >> >> >> >> 1.

Re: [PATCH] [PATCH][ARM] Fix thumb1-far-jump-2.c testcase.

2015-05-15 Thread Mike Stump
On May 15, 2015, at 11:07 AM, Alex Velenko wrote: > This patch fixes testcase thumb1-far-jump-2.c to confirm to newer compilation > defaults. > > Is patch ok? Ok.

Re: Last part of verify_type_vairant checks

2015-05-15 Thread Eric Botcazou
> - Ada builds !TYPE_ARTIFICIAL variant of TYPE_ARTIFICIAL type. >Eric, I can not really make sense of this. Is this expected? >If we have artificial type, how it can become not? Yes, that's a bit unexpected and probably comes from the case where we build a variant and it's not really ap

Re: [PATCH] fortran/66044 -- Convert ICE into ordinary error

2015-05-15 Thread FX
> 2015-05-XX Steven G. Kargl > > PR fortran/66044 > * decl.c(gfc_match_entry): Change a gfc_internal_error() into > a gfc_error() > > 2015-05-XX Steven G. Kargl > > PR fortran/66044 > * gfortran.dg/entry_21.f90: New test. OK

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread Rich Felker
On Fri, May 15, 2015 at 01:35:14PM -0700, H.J. Lu wrote: > On Fri, May 15, 2015 at 1:23 PM, Rich Felker wrote: > > On Fri, May 15, 2015 at 01:08:15PM -0700, H.J. Lu wrote: > >> With relax branch in 32-bit, there are 2 cases: > >> > >> 1. PIC or PIE: We generate > >> > >> set up EBX > >> relax cal

Re: [PATCH] fortran/66039 -- Check for mangled file positioning

2015-05-15 Thread FX
> 2015-05-XX Steven G. Kargl > > PR fortran/66039 > * io.c (match_filepos): Check for incomplete/mangled REWIND, FLUSH, > BACKSPACE, and ENDFILE statements > > 2015-05-XX Steven G. Kargl > > PR fortran/66039 > * gfortran.dg/filepos1.f90: New test OK

Re: [PATCH] fortran/66040 -- convert internal error into normal error

2015-05-15 Thread FX
> 2015-05-XX Steven G. Kargl > > PR fortran/66040 > * parse.c(verify_st_order): Replace a gfc_internal_error with your > generic gfc_error. > > 2015-05-XX Steven G. Kargl > > PR fortran/66040 > * gfortran.dg/misplaced_statement.f90: New test. OK

Re: [PATCH] fortran/66057 -- detect malformed GENERIC statement

2015-05-15 Thread FX
Does it also catch the other cases shown in the PR? Things like: generic :: 2 generic :: 2 = generic :: 1 => x generic :: ? etc. OK if so. If not, maybe it’s worth adding them at the same time? FX

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 1:23 PM, Rich Felker wrote: > On Fri, May 15, 2015 at 01:08:15PM -0700, H.J. Lu wrote: >> With relax branch in 32-bit, there are 2 cases: >> >> 1. PIC or PIE: We generate >> >> set up EBX >> relax call foo@PLT >> >> It is almost the same as we do now, except for the relax

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread Rich Felker
On Fri, May 15, 2015 at 01:08:15PM -0700, H.J. Lu wrote: > With relax branch in 32-bit, there are 2 cases: > > 1. PIC or PIE: We generate > > set up EBX > relax call foo@PLT > > It is almost the same as we do now, except for the relax prefix. > If foo is defined in another shared library or may

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 12:48 PM, Jan Hubicka wrote: >> On Fri, May 15, 2015 at 9:27 AM, Alexander Monakov >> wrote: >> > Ping? Any comment about this patch? >> > >> > On Mon, 4 May 2015, Alexander Monakov wrote: >> > >> >> With -fno-plt, we don't have to reject even direct calls as sibcall >>

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread Jan Hubicka
> On Fri, May 15, 2015 at 9:27 AM, Alexander Monakov wrote: > > Ping? Any comment about this patch? > > > > On Mon, 4 May 2015, Alexander Monakov wrote: > > > >> With -fno-plt, we don't have to reject even direct calls as sibcall > >> candidates. > >> > >> This patch depends on '-fplt' flag that

Re: [PATCH 2/2] IPA ICF: add support for debug counter.

2015-05-15 Thread Jeff Law
On 05/15/2015 03:03 AM, mliska wrote: Hi. Following patch add support of dbg-cnt for IPA ICF pass. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2015-05-15 Martin Liska * dbgcnt.def: Add new counter. * ipa-icf.c (sem_item_optimizer::merge_classes): Use the counter

Re: [PATCH 1/2] dbgcnt: enhance behavior.

2015-05-15 Thread Jeff Law
On 05/15/2015 04:36 AM, mliska wrote: Hi. Following patch changes GCC so that it exits after -fdbg-cnt-list and counters are sorted in dbgcnt.def file. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2015-05-15 Martin Liska * dbgcnt.def: Sort counters. * opts.c (common_hand

Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc

2015-05-15 Thread Jeff Law
On 05/15/2015 12:39 PM, Eric Botcazou wrote: You might consider a comment in active_insn_p and emit_pattern_{after,before}_setloc so that if someone fixes active_insn_p, they'll know to fix emit_pattern_{after,before}_setloc. "FIXME" doesn't capture this interaction at all ;-) I beg to differ,

Re: [patch, c, ping] Fix PR c/48956: diagnostics for conversions involving complex types (reviewed)

2015-05-15 Thread Jeff Law
On 05/15/2015 12:25 PM, Mikhail Maltsev wrote: On 04/17/2015 05:01 AM, Mikhail Maltsev wrote: I would like to ping the following patch: https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01925.html Review: https://gcc.gnu.org/ml/gcc-patches/2015-01/msg02672.html I fixed minor issues mentioned in the

Re: [v3 patch] Fix some Filesystem TS operations

2015-05-15 Thread Jonathan Wakely
On 15/05/15 19:37 +0100, Jonathan Wakely wrote: I've also made filesystem::temp_directory_path() check the TMP, TEMPDIR and TEMP environment variables, as suggested in [fs.op.temp_dir_path] at http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4099.html#fs.op.temp_dir_path rather than my or

Re: [PATCH] Fix PR ipa/65908.

2015-05-15 Thread Jan Hubicka
> +/* Return true if DECL_ARGUMENT types are valid to be merged. */ Perhaps bettter as Perform additional check needed to match types function parameters that are used. Unlike for normal parameters it matters if type is TYPE_RESTRICT and we make an assumption that REFERENCE_TYPE parameters are a

Re: Fix RTL checking failure in emit_pattern_{after|before}_setloc

2015-05-15 Thread Eric Botcazou
> You might consider a comment in active_insn_p and > emit_pattern_{after,before}_setloc so that if someone fixes > active_insn_p, they'll know to fix emit_pattern_{after,before}_setloc. > "FIXME" doesn't capture this interaction at all ;-) I beg to differ, it's the same file and anyone fiddling w

[v3 patch] Fix some Filesystem TS operations

2015-05-15 Thread Jonathan Wakely
Testing revealed a few bugs in how I handled paths that don't exist. The new __gnu_test::nonexistent_path() function is a bit hacky but should be good enough for the testsuite. I've also made filesystem::temp_directory_path() check the TMP, TEMPDIR and TEMP environment variables, as suggested in

Re: [patch, c, ping] Fix PR c/48956: diagnostics for conversions involving complex types (reviewed)

2015-05-15 Thread Mikhail Maltsev
On 04/17/2015 05:01 AM, Mikhail Maltsev wrote: > I would like to ping the following patch: > https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01925.html > Review: https://gcc.gnu.org/ml/gcc-patches/2015-01/msg02672.html > > I fixed minor issues mentioned in the review and updated the changelog > mess

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread FX
> Whoops, sorry about that. As you can see I have small patches > sitting in my tree. I tried to untangle the 'svn diff’ Thanks for cleaning and submitting those! I’ll try to review them over the next 2 days, if nobody beats me to it :) FX

[patch,gomp4] error on invalid acc loop clauses

2015-05-15 Thread Cesar Philippidis
This patch teaches the c and c++ front ends to error on invalid and conflicting acc loop clauses. E.g., an acc loop cannot have 'gang seq' and the worker and vector clauses inside parallel regions cannot have optional kernel-specific arguments. The c and c++ front end also error when it detects a

[PATCH] [PATCH][ARM] Fix thumb1-far-jump-2.c testcase.

2015-05-15 Thread Alex Velenko
Hi, This patch fixes testcase thumb1-far-jump-2.c to confirm to newer compilation defaults. Is patch ok? gcc/testsuite 2015-05-15 Alex Velenko * gcc.target/arm/thumb1-far-jump-2.c (r4): Added int in definition. --- gcc/testsuite/gcc.target/arm/thumb1-far-jump-2.c | 2 +- 1 file cha

Re: *ping* Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-05-15 Thread Paul Richard Thomas
Dear Mikael, dear all, I am struggling to find time for gfortran at present because of the change in my personal circumstances. I am still working full time as a consultant, whilst trying to sell the house and fix up all those things that l'Administration Francaise makes so "interesting" (Having h

Re: [PATCH] [AArch32] Additional bics patterns.

2015-05-15 Thread Alex Velenko
On 01/05/15 10:28, Kyrill Tkachov wrote: Can you please confirm that bootstraps with both arm and thumb pass? That is, configured with --with-mode=arm and --with-mode=thumb Hi Kyrill, Bootstrapped on arm-none-gnueabihf with arm and thumb mode. Following patch requires bics shift operand on

Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-05-15 Thread Jeff Law
On 05/15/2015 04:37 AM, Dharmakan Rohit Arul Raj wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Friday, May 15, 2015 10:30 AM Just to summarize: By default in GCC v4.7.x, all the constants are put into '.rodata.str1.4' section. In GCC v4.8.x from r192719 onward

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-15 Thread Martin Galvan
On Fri, May 15, 2015 at 1:58 PM, Ramana Radhakrishnan wrote: > Thanks for doing this now the patch looks much better and I can apply it ! > Unfortunately there are still problems with it and I'm not sure about your > testing procedures. > >> >> >> mov ip, r0 >> mov r0, r2 >

match.pd: (x | y) & ~x -> y & ~x

2015-05-15 Thread Marc Glisse
Hello, we already have the more complicated: x & ~(x & y) -> x & ~y (which I am reindenting by the way) and the simpler: (~x | y) & x -> x & y, so I am proposing this one for completeness. Regtested on ppc64le-redhat-linux. 2015-05-15 Marc Glisse gcc/ * match.pd ((x | y) & ~x -> y

Re: [PATCH 13/13] fix incompatible posix_memalign declaration on x86

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 9:09 AM, Szabolcs Nagy wrote: > > > On 15/05/15 16:05, H.J. Lu wrote: >> On Mon, Apr 20, 2015 at 12:00 PM, Szabolcs Nagy >> wrote: >>> The posix_memalign declaration is incompatible with musl for C++, >>> because of the exception specification. It also pollutes the >>> n

*ping* Re: [Patch, fortran] PR65792 - allocation of scalar elemental function with structure constructor fails

2015-05-15 Thread Mikael Morin
Le 09/05/2015 15:12, Mikael Morin a écrit : > Le 01/05/2015 20:25, Paul Richard Thomas a écrit : >> Dear All, >> >> By the time I went to commit, something had changed and the patch >> caused a regression. I presume that the version that I had of Andre's >> patch was not the same as the one committ

Re: Fwd: [PING 2][PATCH] libgcc: Add CFI directives to the soft floating point support code for ARM

2015-05-15 Thread Ramana Radhakrishnan
On 13/05/15 19:11, Martin Galvan wrote: Here's the new patch. I downloaded the gcc sources from the SVN repository, removed the extra semicolon from my version of the files and re-generated the patch using svn diff, making sure the context info had all the tabs from the original. I then e-maile

Re: [patch, fortran] fix for PR 60780, PR 40958

2015-05-15 Thread russelldub .
>> The change may be small enough that an assignment isn't needed. >> We (ie, the gfortran developers) will need to check. > > I think that’s small enough, compared to what we’ve accepted as such in the > past. > If not, a disclaimer by Russell putting his change in the public domain would > also

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread H.J. Lu
On Fri, May 15, 2015 at 9:27 AM, Alexander Monakov wrote: > Ping? Any comment about this patch? > > On Mon, 4 May 2015, Alexander Monakov wrote: > >> With -fno-plt, we don't have to reject even direct calls as sibcall >> candidates. >> >> This patch depends on '-fplt' flag that is introduced in a

Re: [PATCH i386] Allow sibcalls in no-PLT PIC

2015-05-15 Thread Alexander Monakov
Ping? Any comment about this patch? On Mon, 4 May 2015, Alexander Monakov wrote: > With -fno-plt, we don't have to reject even direct calls as sibcall > candidates. > > This patch depends on '-fplt' flag that is introduced in another patch. > > This patch requires that with -fno-plt all sibcal

[PATCH] Fix memory orders description in atomic ops built-ins docs.

2015-05-15 Thread Torvald Riegel
This patch improves the documentation of the built-ins for atomic operations. First, to be consistent with the C++11 standard and make it easier for users to relate the built-ins to the C++11 specification, the patch changes 'memory model' to 'memory order'. The memory model is the whole thing, w

Re: [PATCH] fortran/66043 -- Check for NULL() in STORAGE_SIZE()

2015-05-15 Thread FX
> I can change the error to something like > > "Intrinsic function NULL() cannot be an actual argument to > STORAGE_SIZE because it returns a disassociated pointer” I think that’d be better, indeed. > No. This isn't a numbered constraint. I spent an hour or so > tracing though parent namespac

Re: [PATCH 13/13] fix incompatible posix_memalign declaration on x86

2015-05-15 Thread Szabolcs Nagy
On 15/05/15 16:05, H.J. Lu wrote: > On Mon, Apr 20, 2015 at 12:00 PM, Szabolcs Nagy wrote: >> The posix_memalign declaration is incompatible with musl for C++, >> because of the exception specification. It also pollutes the >> namespace and lacks protection against a potential macro definition

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread Steve Kargl
On Fri, May 15, 2015 at 05:45:54PM +0200, FX wrote: > - You're missing the match.c part of the patch (I really had > a hard time figuring out how the patch was supposed to work! > then I read the one posted in the PR) Whoops, sorry about that. As you can see I have small patches sitting in my

Re: [PATCH] fortran/66043 -- Check for NULL() in STORAGE_SIZE()

2015-05-15 Thread Steve Kargl
On Fri, May 15, 2015 at 05:34:14PM +0200, FX wrote: > Hi Steve, > > + gfc_error ("%qs argument of %qs intrinsic at %L shall not be an " > + "unallocated allocatable variable or a disassociated or " > + "undefined pointer???, > > Given that we know explicitly that th

Re: [PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread FX
- You’re missing the match.c part of the patch (I really had a hard time figuring out how the patch was supposed to work! then I read the one posted in the PR) - Let’s avoid the strcmp() string comparison and use “op == INTRINSIC_NONE” as the condition (seems clearer and more efficient to me)

[PATCH v2 6/6] i386: Implement asm flag outputs

2015-05-15 Thread Richard Henderson
Version 2 includes proper test cases and documentation. Hopefully the documentation even makes sense. Suggestions and improvements there gratefully appreciated. r~ --- gcc/config/i386/constraints.md | 5 ++ gcc/config/i386/i386.c | 137 +

Re: [PATCH] fortran/66043 -- Check for NULL() in STORAGE_SIZE()

2015-05-15 Thread FX
Hi Steve, + gfc_error ("%qs argument of %qs intrinsic at %L shall not be an " +"unallocated allocatable variable or a disassociated or " +"undefined pointer”, Given that we know explicitly that the expr is NULL, wouldn’t it be nicer to give only the relevant

[PATCH] fortran/66052 -- Prevent dereference of NULL pointer

2015-05-15 Thread Steve Kargl
Regression tested on trunk. OK to commit? Subject says it all. 2015-05-XX Steven G. Kargl PR fortran/66052 * decl.c(gfc_match_protected): Prevent dereference of NULL pointer. 2015-05-XX Steven G. Kargl PR fortran/66052 * gfortran.dg/protected_9.f90: New

[PATCH] fortran/66106 -- Enforce C1202 from F2008

2015-05-15 Thread Steve Kargl
Regression tested on trunk. OK to commit? The patch allows gfortran to check a portion of C1202 that was previously mishandled. 2015-05-XX Steven G. Kargl PR fortran/66057 * interface.c(gfc_match_end_interface): Enfornce F2008 C1202 (R1201). 2015-05-XX Steven G. Kargl

[PATCH] fortran/66057 -- detect malformed GENERIC statement

2015-05-15 Thread Steve Kargl
Regression tested on trunk. OK to commit? See the test case for the type of error that this patch catches. 2015-05-XX Steven G. Kargl PR fortran/66057 * decl.c(gfc_match_generic): Detected a malformed GENERIC statement. 2015-05-XX Steven G. Kargl PR fortran/6605

[PATCH] fortran/66045 -- NULL() on RHS of assignment

2015-05-15 Thread Steve Kargl
Regression tested on trunk. OK to commit? The patch is self-explanatory. Steven G. Kargl PR fortran/66045 * expr.c (gfc_check_assign): Check for assignment of NULL() instead of the (intended) pointer assignment. 2015-05-XX Steven G. Kargl PR fortran/66045

Re: [PATCH 13/13] fix incompatible posix_memalign declaration on x86

2015-05-15 Thread H.J. Lu
On Mon, Apr 20, 2015 at 12:00 PM, Szabolcs Nagy wrote: > The posix_memalign declaration is incompatible with musl for C++, > because of the exception specification. It also pollutes the > namespace and lacks protection against a potential macro definition > that is allowed by POSIX. The fix avoi

[PATCH] fortran/66044 -- Convert ICE into ordinary error

2015-05-15 Thread Steve Kargl
Regression tested on trunk. OK to commit? Poorly written code could invoke an ICE when an ordinary error could have been emitted. 2015-05-XX Steven G. Kargl PR fortran/66044 * decl.c(gfc_match_entry): Change a gfc_internal_error() into a gfc_error() 2015-05-XX St

[PATCH] fortran/66043 -- Check for NULL() in STORAGE_SIZE()

2015-05-15 Thread Steve Kargl
Regression tested on trunk. OK to commit? The patch shuold be self-explanatory. 2015-05-XX Steven G. Kargl PR fortran/66043 * check.c (gfc_check_storage_size): Prevent the direct use of NULL() in STORAGE_SIZE() reference. 2015-05-XX Steven G. Kargl PR for

[PATCH] fortran/66040 -- convert internal error into normal error

2015-05-15 Thread Steve Kargl
The attached patch has been regression tested on trunk. OK to commit? As shown by the testcase, each individual line of code is legal, but the ordering is incorrect. This leads to an ICE, which can be correctly reported as a user error. 2015-05-XX Steven G. Kargl PR fortran/66040

[PATCH] fortran/66039 -- Check for mangled file positioning

2015-05-15 Thread Steve Kargl
The attached patch checks for mangled/incomplete file positioning statements. Regression tested on trunk with no new failures? OK to commit 2015-05-XX Steven G. Kargl PR fortran/66039 * io.c (match_filepos): Check for incomplete/mangled REWIND, FLUSH, BACKSPACE, and E

[PATCH] fortran/64925 -- fix conflict between names

2015-05-15 Thread Steve Kargl
I've had the attached patch in my tree for a long and have had no issues. Regression tested numerous times on trunk. OK to commit? 2015-05-XX Steven G. Kargl PR fortran/64925 * symbol.c(check_conflict): Check for a conflict between a dummy argument and an internal pr

Re: [PATCH, alpha]: Fix PR66140, ICE at extract_insn, at recog.c

2015-05-15 Thread Richard Henderson
On 05/15/2015 05:26 AM, Uros Bizjak wrote: > 2015-05-15 Uros Bizjak > > PR target/66140 > * config/alpha/alpha.c (get_aligned_mem): Also look for reload > replacements in memory addresses. > (get_unaligned_address): Ditto. Ok. r~

Re: [RFC, PATCH] nonzero attribute, static array parameter

2015-05-15 Thread Marek Polacek
On Sat, May 09, 2015 at 09:42:23AM -0700, Martin Uecker wrote: > here is a tentative patch to implement a new attribute nonzero, > which is similar to nonnull, but is not a function attribute > but a type attribute. > > One reason is that nonnull is awkward to use. For this reason, > clang allows

Re: [PATCH 9/13] x86 musl support

2015-05-15 Thread Kyrill Tkachov
On 15/05/15 13:43, Uros Bizjak wrote: On Fri, May 15, 2015 at 2:33 PM, Szabolcs Nagy wrote: On 27/04/15 15:52, Szabolcs Nagy wrote: On 20/04/15 19:57, Szabolcs Nagy wrote: Set up dynamic linker name for x86. Patch v2. (undef MUSL_DYNAMIC_LINKER* before defining it). ping (now with maint

Re: [PATCH] Fix PR ipa/65908.

2015-05-15 Thread Martin Liška
On 05/15/2015 12:38 PM, Jakub Jelinek wrote: On Fri, May 15, 2015 at 10:38:57AM +0200, Martin Liška wrote: Following patch is fix for GCC-5 branch for PR ipa/65908, was tested on x86_64-linux-pc, as well as bootstrapped. As soon as the patch is applied, I'm going to send the similar patch for t

Re: [PATCH] [PR libitm/61164] Remove redefinition of glibc internal macro __always_inline

2015-05-15 Thread Torvald Riegel
On Wed, 2015-05-06 at 17:54 +0300, Gleb Fotengauer-Malinovskiy wrote: > 2015-05-06 Gleb Fotengauer-Malinovskiy > > PR libitm/61164 > * local_atomic (__always_inline): Rename to... > (__libitm_always_inline): ... this. OK. Thanks.

Re: [PATCH 13/13] fix incompatible posix_memalign declaration on x86

2015-05-15 Thread Uros Bizjak
On Fri, May 15, 2015 at 2:34 PM, Szabolcs Nagy wrote: > On 20/04/15 20:00, Szabolcs Nagy wrote: >> The posix_memalign declaration is incompatible with musl for C++, >> because of the exception specification. It also pollutes the >> namespace and lacks protection against a potential macro definiti

Re: [PATCH 9/13] x86 musl support

2015-05-15 Thread Uros Bizjak
On Fri, May 15, 2015 at 2:33 PM, Szabolcs Nagy wrote: > On 27/04/15 15:52, Szabolcs Nagy wrote: >> On 20/04/15 19:57, Szabolcs Nagy wrote: >>> Set up dynamic linker name for x86. >>> >> Patch v2. >> >> (undef MUSL_DYNAMIC_LINKER* before defining it). > > ping > > (now with maintainers in cc) > >>

Re: [PATCH 4/13] arm musl support

2015-05-15 Thread Szabolcs Nagy
On 20/04/15 19:53, Szabolcs Nagy wrote: > Set up dynamic linker name for arm. > ping (now with maintainer in cc) > gcc/Changelog: > > 2015-04-16 Gregor Richards > > * config/arm/linux-eabi.h (MUSL_DYNAMIC_LINKER): Define. >

Re: [PATCH 13/13] fix incompatible posix_memalign declaration on x86

2015-05-15 Thread Szabolcs Nagy
On 20/04/15 20:00, Szabolcs Nagy wrote: > The posix_memalign declaration is incompatible with musl for C++, > because of the exception specification. It also pollutes the > namespace and lacks protection against a potential macro definition > that is allowed by POSIX. The fix avoids source level

Re: [PATCH 9/13] x86 musl support

2015-05-15 Thread Szabolcs Nagy
On 27/04/15 15:52, Szabolcs Nagy wrote: > On 20/04/15 19:57, Szabolcs Nagy wrote: >> Set up dynamic linker name for x86. >> > Patch v2. > > (undef MUSL_DYNAMIC_LINKER* before defining it). ping (now with maintainers in cc) > gcc/Changelog: > > 2015-04-27 Gregor Richards > > * config/

Re: [PATCH 3/13] aarch64 musl support

2015-05-15 Thread Szabolcs Nagy
On 27/04/15 15:33, Szabolcs Nagy wrote: > > On 21/04/15 15:16, pins...@gmail.com wrote: >> >> I don't think you need to check if defaulting to little or big-endian here >> are the specs always have one or the other passing through. >> >> Also if musl does not support ilp32, you might want to err

[PATCH, alpha]: Fix PR66140, ICE at extract_insn, at recog.c

2015-05-15 Thread Uros Bizjak
Hello! As shown in the PR [1], reload can also schedule a replacement inside memory address. Attached patch removes invalid check. 2015-05-15 Uros Bizjak PR target/66140 * config/alpha/alpha.c (get_aligned_mem): Also look for reload replacements in memory addresses. (get_unali

Re: [PATCH] rs6000: Improve rtx_costs for EQ a bit (PR30967)

2015-05-15 Thread Segher Boessenkool
On Thu, May 14, 2015 at 09:51:18AM -0400, David Edelsohn wrote: > On Wed, May 13, 2015 at 1:29 PM, Segher Boessenkool > wrote: > > On Wed, May 13, 2015 at 01:25:16PM -0400, David Edelsohn wrote: > >> > PR rtl-optimization/30967 > >> > * config/rs6000/rs6000.c (rs6000_rtx_costs): Do

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

2015-05-15 Thread Manuel López-Ibáñez
On 15 May 2015 at 10:39, Dodji Seketeli wrote: > Manuel López-Ibáñez writes: >> -/* Expand the location of this diagnostic. Use this function for >> consistency. */ >> +/* Return the location associated to this diagnostic. WHICH specifies > > Here, I think only the 'W' (in WHICH) should be upper

[PATCH 1/2] dbgcnt: enhance behavior.

2015-05-15 Thread mliska
Hi. Following patch changes GCC so that it exits after -fdbg-cnt-list and counters are sorted in dbgcnt.def file. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2015-05-15 Martin Liska * dbgcnt.def: Sort counters. * opts.c (common_handle_option): Do not compile if -f

[PATCH 2/2] IPA ICF: add support for debug counter.

2015-05-15 Thread mliska
Hi. Following patch add support of dbg-cnt for IPA ICF pass. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2015-05-15 Martin Liska * dbgcnt.def: Add new counter. * ipa-icf.c (sem_item_optimizer::merge_classes): Use the counter. --- gcc/dbgcnt.def | 1 + gcc/ipa-icf

Re: [patch, fortran] fix for PR 60780, PR 40958

2015-05-15 Thread FX
> The change may be small enough that an assignment isn't needed. > We (ie, the gfortran developers) will need to check. I think that’s small enough, compared to what we’ve accepted as such in the past. If not, a disclaimer by Russell putting his change in the public domain would also be a quic

Small fold-const.c / match.pd tweaks

2015-05-15 Thread Marc Glisse
Hello, these are just a few tweaks / clean-ups. The 'ord' pattern is the dual of the 'unord' one I added last month. The tree_unary_nonnegative_warnv_p change should have no effect (it is only used from VRP which does not handle vectors (yet?)) but it seems right to handle vectors like scalars

Re: [PATCH] Fix PR ipa/65908.

2015-05-15 Thread Jakub Jelinek
On Fri, May 15, 2015 at 10:38:57AM +0200, Martin Liška wrote: > Following patch is fix for GCC-5 branch for PR ipa/65908, was tested on > x86_64-linux-pc, as well as bootstrapped. > As soon as the patch is applied, I'm going to send the similar patch for > trunk. I'll leave the review to Honza o

RE: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2

2015-05-15 Thread Dharmakan Rohit Arul Raj
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Friday, May 15, 2015 10:30 AM > > Just to summarize: By default in GCC v4.7.x, all the constants are put > > into '.rodata.str1.4' section. In GCC v4.8.x from r192719 onwards, one > > of the move instruction of the stri

Improve error message for vector conversion

2015-05-15 Thread Marc Glisse
Hello, this patch was regtested on ppc64le-redhat-linux. 2015-05-15 Marc Glisse gcc/ * convert.c (convert_to_integer, convert_to_vector): Include the types in the error message. gcc/testsuite/ * gcc.dg/simd-1.c: Update to the new message. -- Marc GlisseIndex: gcc/con

[PATCH, PR middle-end/66134] Fix coalescing for bounds used in abnormal phi

2015-05-15 Thread Ilya Enkovich
Hi, This patch fixes misuse of abnormal bounds copy to avoid coalescing issue. Bootstrapped and regtested for x86_64-unknown-linux-gnu. Applied to trunk. Is it OK for gcc-5? Thanks, Ilya -- gcc/ 2015-05-15 Ilya Enkovich PR middle-end/66134 * tree-chkp.c (chkp_get_orgina

Re: [PATCH][AArch64] Removed unused SLOWMUL target flags

2015-05-15 Thread James Greenhalgh
On Fri, May 15, 2015 at 09:04:52AM +0100, Kyrill Tkachov wrote: > Hi all, > > It seems that AARCH64_TUNE_SLOWMUL somehow slipped from the arm backend into > the aarch64 one. > This macro is not used anywhere and I don't expect it will be used. It has > been there since > October 2012 i.e. when t

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

2015-05-15 Thread Dodji Seketeli
Manuel López-Ibáñez writes: > Thanks for the review. I followed all your suggestions. For the > accessor functions, I was not sure what type you would prefer, so I > implemented them as C++ methods and made use of 'private' to be sure > they are the only way to access the locations array. If you

[PATCH] Fix PR ipa/65908.

2015-05-15 Thread Martin Liška
Hello. Following patch is fix for GCC-5 branch for PR ipa/65908, was tested on x86_64-linux-pc, as well as bootstrapped. As soon as the patch is applied, I'm going to send the similar patch for trunk. Ready for 5 branch? Thanks, Martin gcc/testsuite/ChangeLog: 2015-05-12 Martin Liska

Re: [ARM] fix arm bootstrap

2015-05-15 Thread Ramana Radhakrishnan
On 15/05/15 07:41, Kugan wrote: Hi Richard, r223090 seem to miss a parenthesis and seem to be causing: from ../../widen/gcc/fold-const.c:46: ../../widen/gcc/fold-const.c: In function 'tree_node* fold_range_test(location_t, tree_code, tree, tree, tree)': ../../widen/gcc/confi

[PATCH][AArch64] Removed unused SLOWMUL target flags

2015-05-15 Thread Kyrill Tkachov
Hi all, It seems that AARCH64_TUNE_SLOWMUL somehow slipped from the arm backend into the aarch64 one. This macro is not used anywhere and I don't expect it will be used. It has been there since October 2012 i.e. when the port was first contributed. This patch removes that and the relevant AARCH

Re: [ARM] fix arm bootstrap

2015-05-15 Thread Kyrill Tkachov
On 15/05/15 07:46, Kugan wrote: Sorry, this is not the right fix. Looking at it. Hi Kugan, FWIW, I'm seeing this bootstrap failure as well. If you have a patch for this, it would be appreciated. Kyrill Thanks, Kugan On 15/05/15 16:41, Kugan wrote: Hi Richard, r223090 seem to miss a pare

Refactor gimple_expr_type

2015-05-15 Thread Aditya K
Hi, I have tried to refactor gimple_expr_type to make it more readable. Removed the switch block and redundant if. Please review this patch. Thanks, -Aditya gcc/ChangeLog: 2015-05-15  hiraditya           * gimple.h (gimple_expr_type): Refactor to make it concise. Remove redundant if. diff