Re: [BUILDROBOT] tilepro-linux/tilegx-linux fallout from flattening

On 12 January 2015 at 11:19, Michael Collison wrote: > The issue is that tilegx includes expr.h which includes tree-core.h. A > simple solution is to include "symtab.h" before "expr.h" in tilegx.c. The > port has a unrelated link error after this change. Yes, I am seeing this link error after buil

Fix ICE in estimate_edge_growth

Hi, this patch fixed -fprofile-use ICE where call_stmt_size is 0 while it should be non-zero. This is becuase of cgraph_merge_profiles using get_body that applies transformations and kills the profile. This is not intended to happen. Bootstrapped/regtested x86_64-linux, will commit it shortly.

Re: [PATCH] Fix enum operands exchange in ipa-inline.c

Hi, Sorry, Had forgot the ChangeLog. ChangeLog 2015-01-12 Naveen H.S * ipa-inline.c (inline_small_functions): Swap the operands in enum. Thanks, Naveen

[PATCH] Fix enum operands exchange in ipa-inline.c

Hi, Please find attached the patch that fixes swap of operands to enum in ipa-inline.c. This issue popped up when running dhrystone with -fdump-ipa-all. Please review the patch and let me know it its okay? Regression tested on aarch64-elf. Thanks, Naveen--- a/gcc/ipa-inline.c 2015-01-12 11:04

Re: [BUILDROBOT] tilepro-linux/tilegx-linux fallout from flattening

The issue is that tilegx includes expr.h which includes tree-core.h. A simple solution is to include "symtab.h" before "expr.h" in tilegx.c. The port has a unrelated link error after this change. The second possiblity is to resolve this using Prathmesh latest patch (submitted today) for flatte

[PING] Re: [PATCH] add option to emit more array bounds warnigs

Please consider this patch. The additional warnings would be useful IMHO, are also emitted by clang, and the change seems trivial. Previous discussion about potential false positives: https://gcc.gnu.org/ml/gcc/2014-11/msg00114.html Tue, 11 Nov 2014 22:13:20 -0800 Martin Uecker : > > Hi, >

[BUILDROBOT] tilepro-linux/tilegx-linux fallout from flattening (was: [PATCH] Flatten tree.h and tree-core.h (Version 3))

On Sat, 2015-01-10 01:50:42 +0530, Prathamesh Kulkarni wrote: > On 9 January 2015 at 16:21, Richard Biener wrote: > > On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison > > wrote: > > > This patch flattens tree.h and tree-core.h. This is a revised > > > patch that does not include tree-core.h a

PATCH: PR bootstrap/64561: [5 Regression] HAVE_LD_PIE_COPYRELOC is defined to 1 for broken linker

Hi, This patch updates Linux/x86-64 linker test for PIE with copy reloc. Tested with broken and working linkers on Linux/x86-64. OK to install? Thanks. H.J. --- 2015-01-12 H.J. Lu PR bootstrap/64561 * configure.ac (HAVE_LD_PIE_COPYRELOC): Update Linux/x86-64 linker

[testsuite] PATCH: Add -fno-pie to gcc.target/i386/pr54445-2.c

Since PIE is also PIC, we need to add -fno-pie to avoid PIC. OK for trunk? Thanks. H.J. --- gcc/testsuite/gcc.target/i386/pr54445-2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 2015-01-11 H.J. Lu * gcc.target/i386/pr54445-2.c: Add -fno-pie. diff --git a/gcc/testsuite/gc

[testsuite] PATCH: Correct target selector in gcc.target/i386/nop-mcount.c

nonpic in target selector in gcc.target/i386/nop-mcount.c is ignored since {} is misplaced. This patch properly places {} in target selector. Tested on Linux/x86. OK for trunk? Thanks. H.J. --- gcc/testsuite/gcc.target/i386/nop-mcount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 20

[testsuite] PATCH: Support PIE in gcc.dg/tree-ssa/ssa-store-ccp-3.c

target nonpic is always false for -fPIE since it defines both __PIC__ and __PIE__. This patch changes gcc.dg/tree-ssa/ssa-store-ccp-3.c to make it to pass with -fPIE by excluding PIE when nonpic is true. OK to for trunk? Thanks. H.J. --- gcc/testsuite/gcc.dg/tree-ssa/ssa-store-ccp-3.c | 4 ++--

[testsuite] PATCH: Ignore additional messages on Linux/x86 with PIE

g++.dg/other/anon5.C is expected to fail to link. On Linux/x86 with PIE, there are additional messages linker: [hjl@gnu-tools-1 gcc]$ g++ -fPIE -pie /export/gnu/import/git/sources/gcc/gcc/testsuite/g++.dg/other/anon5.C /tmp/ccwg53fj.o: In function `f()': anon5.C:(.text+0x7): undefined reference

[testsuite] PATCH: Add check_effective_target_pie

Hi, This patch adds check_effective_target_pie to check if the current multilib generatse PIE by default. I will submit other patches to use it. OK for trunk? Thanks. H.J. --- 2015-01-11 H.J. Lu * gcc.target/i386/pie.c: New test. * lib/target-supports.exp (check_profiling_

Re: [PATCH, committed] Fix build of jit (was Re: [PATCH] Flatten tree.h and tree-core.h (Version 3))

On 10 January 2015 at 03:17, David Malcolm wrote: > On Sat, 2015-01-10 at 01:50 +0530, Prathamesh Kulkarni wrote: >> On 9 January 2015 at 16:21, Richard Biener >> wrote: >> > On Fri, Jan 9, 2015 at 10:39 AM, Michael Collison >> > wrote: >> >> This patch flattens tree.h and tree-core.h. This is

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

On Sun, Jan 11, 2015 at 1:32 PM, Magnus Granberg wrote: > söndag 11 januari 2015 09.47.09 skrev H.J. Lu: >> On Sun, Jan 11, 2015 at 9:40 AM, H.J. Lu wrote: >> > On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg wrote: >> >> söndag 11 januari 2015 14.29.56 skrev Magnus Granberg: >> >>> söndag 11

Re: [Patch, Fortran, OOP] PR 63733: [4.8/4.9/5 Regression] wrong resolution for OPERATOR generics

> Well done for sorting that out. OK for trunk. Thanks, Paul. Committed as r219440. What about the branches? Cheers, Janus > On 11 January 2015 at 14:38, Janus Weil wrote: >> Hi all, >> >> this patch fixes a wrong-code regression related to operators, by >> making sure that we look for typeb

[RFC PATCH Fortran] make enum_9/10.f90 testcases work under FreeBSD ARM

Hi, I have here a possible way to make the enum_9.f90 and the enum_10.f90 work under arm*-*-freebsd*. The solution for enum_9.f90 is straight forward. But the one for enum_10.f90 requires a reordering of the dg-additional-sources line. This I do not understand yet, but maybe one of you does.

RE: [RFC, PATCH][LRA, MIPS] ICE: in decompose_normal_address, at rtlanal.c:5817

Richard Sandiford writes: > Matthew Fortune writes: > > Richard Sandiford writes: > >> Jeff Law writes: > >> > On 01/09/15 04:32, Robert Suchanek wrote: > >> >> Hi Steven/Vladimir, > >> >> > >> >>> It's hard to say what the correct fix should be, but it sounds > >> >>> like the address you get

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

söndag 11 januari 2015 09.47.09 skrev H.J. Lu: > On Sun, Jan 11, 2015 at 9:40 AM, H.J. Lu wrote: > > On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg wrote: > >> söndag 11 januari 2015 14.29.56 skrev Magnus Granberg: > >>> söndag 11 januari 2015 03.37.14 skrev H.J. Lu: > >>> > On Sun, Jan 11,

Re: [PING^5][PATCH] Warn about unclosed pragma omp declare target.

Ping :) On 04 Dec 15:18, Ilya Tocar wrote: > Ping. > On 19 Nov 16:34, Ilya Tocar wrote: > > As omp target and offloading support is committed to trunk, > > I think it's reasonable to add some new warnings. > > > > On 06 Nov 15:27, Ilya Tocar wrote: > > > Ping. > > > On 30 Oct 18:31, Ilya Tocar wr

[PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

Hi! Currently if a target* pragma appears within a target region, GCC successfully compiles such code (with a warning). But the binary fails at run-time, since it tries to call GOMP_target* functions on target. The spec says: "If a target, target update, or target data construct appears within a

Re: LTO streaming of TARGET_OPTIMIZE_NODE

On 09 Jan 12:45, Jakub Jelinek wrote: > --- gcc/cgraphunit.c.jj 2015-01-09 12:01:33.0 +0100 > +++ gcc/cgraphunit.c 2015-01-09 12:22:27.742692667 +0100 > @@ -2108,11 +2108,14 @@ ipa_passes (void) >if (g->have_offload) > { > section_name_prefix = OFFLOAD_SECTION_N

Re: [Patch, Fortran, OOP] PR 63733: [4.8/4.9/5 Regression] wrong resolution for OPERATOR generics

Dear Janus, Well done for sorting that out. OK for trunk. Thanks for the patch. Paul On 11 January 2015 at 14:38, Janus Weil wrote: > Hi all, > > this patch fixes a wrong-code regression related to operators, by > making sure that we look for typebound operators first, before looking > for non

Re: [PATCH][OpenMP] Forbid usage of non-target functions in target regions

On 09 Jan 16:02, Jakub Jelinek wrote: > On Fri, Jan 09, 2015 at 05:57:02PM +0300, Ilya Verbin wrote: > > If one (by mistake) calls a non-target function from the target region, the > > offload compiler crashes in input_overwrite_node. This is because > > compute_ltrans_boundary during streaming-ou

[Patch, Fortran, committed] PR 58023: ICE on invalid with bad PPC declaration

Hi all, I have just committed as obvious a small patch for an ICE-on-invalid problem with procedure-pointer components: https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=219439 Cheers, Janus

Re: [PATCH] testsuite/lib/target-supports.exp: Fix check_effective_target_lto

On 09 Jan 10:29, Thomas Schwinge wrote: > As this was the only use of ENABLE_LTO in the testsuite, I suggest to > also remove it from the gcc/Makefile.in:site.exp rule. Done. Here is an updated and retested patch. OK for trunk? gcc/ * Makefile.in (site.exp): Do not set ENABLE_LTO. gcc/t

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

On Sun, Jan 11, 2015 at 9:40 AM, H.J. Lu wrote: > On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg wrote: >> söndag 11 januari 2015 14.29.56 skrev Magnus Granberg: >>> söndag 11 januari 2015 03.37.14 skrev H.J. Lu: >>> > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay >> wrote: >>> > > On 11/01/

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

On Sun, Jan 11, 2015 at 5:29 AM, Magnus Granberg wrote: > söndag 11 januari 2015 03.37.14 skrev H.J. Lu: >> On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay wrote: >> > On 11/01/15 03:52 AM, Daniel Micay wrote: >> >> This branch works well for me. It doesn't automatically turn off the >> >> linker

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

On Sun, Jan 11, 2015 at 6:04 AM, Magnus Granberg wrote: > söndag 11 januari 2015 14.29.56 skrev Magnus Granberg: >> söndag 11 januari 2015 03.37.14 skrev H.J. Lu: >> > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay > wrote: >> > > On 11/01/15 03:52 AM, Daniel Micay wrote: >> > >> This branch wor

Re: [Patch docs 2/5] Update "Instruction Patterns" in md.texi

On Thu, Jan 08, 2015 at 10:00:02PM +, Jeff Law wrote: > On 01/06/15 04:21, James Greenhalgh wrote: > If I havne't commented, then those hunks should be considered OK -- you > can check those hunks in if you want. Thanks Jeff, I've committed the attached as revision 219432. I'll work on respi

Re: [Patch, Fortran, F03] PR 64508: interface check missing for procedure pointer component as actual argument

Committed as r219431. Thanks for the review! Cheers, Janus 2015-01-11 16:16 GMT+01:00 Paul Richard Thomas : > Dear Janus, > > As you say, the patch is pretty straightforward :-) OK for trunk. > > Thanks for the patch > > Paul > > On 11 January 2015 at 11:21, Janus Weil wrote: >> Ping! (I think

Re: LTO streaming of TARGET_OPTIMIZE_NODE

> On Fri, Jan 09, 2015 at 12:07:26PM +0100, Thomas Schwinge wrote: > > On Thu, 8 Jan 2015 15:11:49 +0100, Jakub Jelinek wrote: > > > On Thu, Nov 20, 2014 at 01:27:08PM +0100, Bernd Schmidt wrote: > > > > On 11/13/2014 05:06 AM, Jan Hubicka wrote: > > > > >this patch adds infrastructure for proper

Re: [PATCH] cgraph_edge: small refactoring

> Hello. > > Following patch is motivated by seen utilization of > cgraph_edge::redirect_callee in Chromium > compiled with LTO. Thus, I decided to move the function to header file as > well as few small > functions it calls. Changes are just of mechanical nature. > > Patch has been tested on x

Re: [Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

Hi Paul, thanks for the review. I do not have commits rights. Unfortunately is the patch not ok. I figured today, that it needs an extension when function calls that return deferred char len arrays are nested. In this special case the string length would have been lost. The attached extended vers

Re: [Patch, Fortran, F03] PR 64508: interface check missing for procedure pointer component as actual argument

Dear Janus, As you say, the patch is pretty straightforward :-) OK for trunk. Thanks for the patch Paul On 11 January 2015 at 11:21, Janus Weil wrote: > Ping! (I think this patch is pretty straightforward ...) > > Cheers, > Janus > > > > 2015-01-06 16:19 GMT+01:00 Janus Weil : >> Hi all, >> >>

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

On 11/01/15 06:37 AM, H.J. Lu wrote: > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay wrote: >> On 11/01/15 03:52 AM, Daniel Micay wrote: >>> This branch works well for me. It doesn't automatically turn off the >>> linker flag when -fno-PIE or -fno-PIC are passed like most of the >>> wrapper script

Re: [Fortran, Patch] PR60334 - Segmentation fault on character pointer assignments

Dear Andre, This is OK for trunk. I have not been keeping track of whether or not you have commit rights yet. If not, I will get to it sometime this week. Thanks for the patch. Paul On 10 January 2015 at 15:59, Andre Vehreschild wrote: > Hi all, > > attached patch fixes the bug reported in pr

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

söndag 11 januari 2015 14.29.56 skrev Magnus Granberg: > söndag 11 januari 2015 03.37.14 skrev H.J. Lu: > > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay wrote: > > > On 11/01/15 03:52 AM, Daniel Micay wrote: > > >> This branch works well for me. It doesn't automatically turn off the > > >> lin

[PATCH] config/h8300/h8300.c: Regress part of the original commit for fixing issue

The related commit "1a1ed14 config/h8300: Use rtx_insn" gives an extra check for rtx, which will cause building libgcc break, after regress it, it can still generate the correct assemble code. The related information is below: [root@localhost libgcc]# cat libgcc2.i typedef int DItype __attrib

[Patch, Fortran, OOP] PR 63733: [4.8/4.9/5 Regression] wrong resolution for OPERATOR generics

Hi all, this patch fixes a wrong-code regression related to operators, by making sure that we look for typebound operators first, before looking for non-typebound ones. (Note: Each typebound operator is also added to the list of non-typebound ones, for reasons of diagnostics.) Regtested on x86_64

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

söndag 11 januari 2015 03.37.14 skrev H.J. Lu: > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay wrote: > > On 11/01/15 03:52 AM, Daniel Micay wrote: > >> This branch works well for me. It doesn't automatically turn off the > >> linker flag when -fno-PIE or -fno-PIC are passed like most of the > >>

RE: [PATCH] Fix parameters of __tsan_vptr_update

Hi, On Sun, 4 Jan 2015 14:54:56, Bernd Edlinger wrote: > > Hi Jakub, > > > I think I have found a reasonable test case, see the attached patch file. > The use case is: a class that destroys an owned thread in the destructor. > The destructor sets the vptr again to thread::vptr but this should >

RE: [PATCH] Enable experimental TSAN support for Ada

Hi Richard, On Fri, 9 Jan 2015 17:19:57, Richard Biener wrote: > > > Yes. As said, you generally need to run folding results through > force_gimple_operand. > > Richard. > I have now used force_gimple_operand instead of special casing the VIEW_CONVERT_EXPRs. And I see that all Ada test cases s

Re: [RFC PATCH] Handle sequence in reg_set_p

On Thu, 2015-01-08 at 14:18 -0700, Jeff Law wrote: > On 01/08/15 05:23, Oleg Endo wrote: > > Hi, > > > > Currently reg_set_p doesn't handle sequence rtx, which I've identified > > as the root cause of PR 64479. There is another alternative fix for the > > PR, but I'd like to get some comments rega

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay wrote: > On 11/01/15 03:52 AM, Daniel Micay wrote: >> This branch works well for me. It doesn't automatically turn off the >> linker flag when -fno-PIE or -fno-PIC are passed like most of the >> wrapper scripts / downstream patches do, but that might n

Re: [Patch, Fortran, F03] PR 64508: interface check missing for procedure pointer component as actual argument

Ping! (I think this patch is pretty straightforward ...) Cheers, Janus 2015-01-06 16:19 GMT+01:00 Janus Weil : > Hi all, > > here is a patch which adds an interface check for procedure pointer > components as acual arguments. Such a check is there already for > ordinary procedures and procedure

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

On 11/01/15 03:52 AM, Daniel Micay wrote: > This branch works well for me. It doesn't automatically turn off the > linker flag when -fno-PIE or -fno-PIC are passed like most of the > wrapper scripts / downstream patches do, but that might not be a problem > in practice. Er, Thunderbird did a terri

Re: [PING][PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

This branch works well for me. It doesn't automatically turn off the linker flag when -fno-PIE or -fno-PIC are passed like most of the wrapper scripts / downstream patches do, but that might not be a problem in practice. signature.asc Description: OpenPGP digital signature