On 11/01/15 06:37 AM, H.J. Lu wrote: > On Sun, Jan 11, 2015 at 1:05 AM, Daniel Micay <danielmi...@gmail.com> wrote: >> On 11/01/15 03:52 AM, Daniel Micay wrote: >>> This branch works well for me. It doesn't automatically turn off the >>> linker flag when -fno-PIE or -fno-PIC are passed like most of the >>> wrapper scripts / downstream patches do, but that might not be a problem >>> in practice. > > -fno-PIE and -fno-PIC aren't linking options. We don't turn on PIE with > > # gcc -fPIE .... > > You need to use > > # gcc -pie -fPIE > > To turn off PIE, you should use > > # gcc -no-pie -fno-PIE
Yeah, it's cleaner this way. Disabling the linker option when the reloc model is known to be incompatible might be a bit too magical. I don't expect that it avoids many compatibility issues anyway. As implemented it's more than good enough to allow distributions to enable PIE across the board which is all I care about :).
signature.asc
Description: OpenPGP digital signature
