RE: Small multiplier support in Cortex-M0/1/+

2014-11-12 Thread Hale Wang
> -Original Message- > From: Hale Wang [mailto:hale.w...@arm.com] > Sent: Thursday, November 13, 2014 2:16 PM > To: 'Christophe Lyon' > Cc: gcc-patches@gcc.gnu.org > Subject: RE: Small multiplier support in Cortex-M0/1/+ > > > -Original Message- > > From: Christophe Lyon [mailto:c

Re: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4 (fix s390 build)

2014-11-12 Thread Richard Henderson
On 11/13/2014 08:49 AM, Zhenqiang Chen wrote: > After adding HAVE_cbranchcc4, we can just use HAVE_cbranchcc4. No need to > add a local variable allow_cc_mode. > > Here is the updated patch. This is ok. Since I've already approved Ulrich's s390 fix, there should not be a problem there for long.

RE: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4 (fix s390 build)

2014-11-12 Thread Zhenqiang Chen
> -Original Message- > From: Richard Henderson [mailto:r...@redhat.com] > Sent: Thursday, November 06, 2014 4:23 PM > To: Zhenqiang Chen; 'Jan-Benedict Glaw'; Hartmut Penner; Ulrich Weigand; > Andreas Krebbel > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, ifcvt] Allow CC mode if HAVE

Re: [Patch, libstdc++/63775] Fix regex bracket expression parsing

2014-11-12 Thread Tim Shen
On Mon, Nov 10, 2014 at 10:32 AM, Jonathan Wakely wrote: > OK for trunk with the small change above - thanks! Committed with comment fix and slight change on testcase (VERIFY(false) at end of the try block -- must throw). -- Regards, Tim Shen commit 63544c468fa784a354def7bc240b2cd93210f6d8

Re: [PATCH] Propagate nonfreeing_call_p using ipa-pure-const

2014-11-12 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 12:11:08AM +0100, Jan Hubicka wrote: > > + else if (gimple_call_internal_p (call) && !nonfreeing_call_p (call)) > > +local->can_free = true; > > Actually I think you want to do this for can_throw, too. > We probably do not have throwing internal calls, but it is better

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-12 Thread Richard Henderson
On 11/12/2014 10:18 PM, Iain Sandoe wrote: > * config/darwin/host-config.h New. > * config/darwin/lock.c New. > * configure.tgt (DEFAULT_X86_CPU): New, (target): New entry for darwin. Looks pretty good. > +# ifndef USE_ATOMIC > +#define USE_ATOMIC 1 > +# endif Why would

Re: [PATCH ARM]Prefer neon for stringops on a53/a57 in AArch32 mode

2014-11-12 Thread Bin.Cheng
On Thu, Nov 13, 2014 at 3:20 PM, Yangfei (Felix) wrote: >> >> > Just curious about this. Can we make sure that FPAdvSIMD are >> >> > always >> >> enabled? >> >> > >> >> >> >> I am not sure I understand correct, do you mean enable options like >> >> below default? >> >> --with-fpu=crypto-neon-fp-a

Re: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4 (fix s390 build)

2014-11-12 Thread Richard Henderson
On 11/12/2014 09:41 PM, Ulrich Weigand wrote: > * optabs.c (prepare_operand): Gracefully fail if the mode of X > does not match the operand mode expected by the insn pattern. This is ok. Another solution I'd thought about involved accepting the mode with the predicate, but FAILing in

Re: [PATCH][AArch64] Implement TARGET_SCHED_MACRO_FUSION_PAIR_P

2014-11-12 Thread Andrew Pinski
On Tue, Nov 11, 2014 at 3:55 AM, Kyrill Tkachov wrote: > Hi all, > > This is the aarch64 implementation of the macro fusion hook, used to fuse > mov+movk instructions together. > > A new field is declared in the tuning struct and as we add more fuseable ops > in the future we will fill in more bit

Re: [PATCH ARM]Prefer neon for stringops on a53/a57 in AArch32 mode

2014-11-12 Thread Yangfei (Felix)
> >> > Just curious about this. Can we make sure that FPAdvSIMD are > >> > always > >> enabled? > >> > > >> > >> I am not sure I understand correct, do you mean enable options like > >> below default? > >> --with-fpu=crypto-neon-fp-armv8/--with-float=hard > >> > >> Thanks, > >> bin > > > > > > I m

Re: [PATCH ARM]Prefer neon for stringops on a53/a57 in AArch32 mode

2014-11-12 Thread Bin.Cheng
On Thu, Nov 13, 2014 at 3:04 PM, Yangfei (Felix) wrote: >> On Thu, Nov 13, 2014 at 2:33 PM, Yangfei (Felix) >> wrote: >> >> Hi, >> >> As commented at >> >> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00684.html, >> >> this is a simple patch enabling neon memset inlining on >> >> cortex-a53/cort

Re: [PATCH ARM]Prefer neon for stringops on a53/a57 in AArch32 mode

2014-11-12 Thread Yangfei (Felix)
> On Thu, Nov 13, 2014 at 2:33 PM, Yangfei (Felix) > wrote: > >> Hi, > >> As commented at > >> https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00684.html, > >> this is a simple patch enabling neon memset inlining on > >> cortex-a53/cortex-a57 in AArch32 mode. > >> > >> Test on > >> arm-none-linux-gn

Re: [PATCH ARM]Prefer neon for stringops on a53/a57 in AArch32 mode

2014-11-12 Thread Bin.Cheng
On Thu, Nov 13, 2014 at 2:33 PM, Yangfei (Felix) wrote: >> Hi, >> As commented at https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00684.html, >> this is a simple patch enabling neon memset inlining on >> cortex-a53/cortex-a57 in AArch32 mode. >> >> Test on >> arm-none-linux-gnueabihf/--with-cpu=cort

Re: [PATCH] Make -fdiagnostics-color= default configurable, default to =auto

2014-11-12 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 01:27:29AM +0100, Manuel López-Ibáñez wrote: > I think it is great that =auto becomes the default. However, adding a > configure option for this seems overkill. If anyone really really > wishes to change the default, they can simply edit a single-line in > common.opt. Confi

Re: PATCH GCC5.0: conditionally skip gcc_version in plugin-version.h

2014-11-12 Thread Basile Starynkevitch
On Wed, 2014-11-12 at 14:36 +0100, Basile Starynkevitch wrote: > On Wed, Nov 12, 2014 at 02:29:13PM +0100, Jakub Jelinek wrote: > > On Wed, Nov 12, 2014 at 02:20:22PM +0100, Basile Starynkevitch wrote: > > > Most plugin don't need any configure, because they are installed in > > > a version specif

Re: [PATCH 2/5] remove the remaining uses of if_marked

2014-11-12 Thread Marek Polacek
On Thu, Nov 13, 2014 at 12:55:40AM -0500, tsaund...@mozilla.com wrote: > From: Trevor Saunders > diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c > index b70c56c..227509a 100644 > --- a/gcc/config/i386/i386.c > +++ b/gcc/config/i386/i386.c > @@ -14032,14 +14032,34 @@ legitimize_tls_add

Re: [PATCH ARM]Prefer neon for stringops on a53/a57 in AArch32 mode

2014-11-12 Thread Yangfei (Felix)
> Hi, > As commented at https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00684.html, > this is a simple patch enabling neon memset inlining on > cortex-a53/cortex-a57 in AArch32 mode. > > Test on > arm-none-linux-gnueabihf/--with-cpu=cortex-a57/--with-fpu=crypto-neon-fp-ar > m > v8/--with-float=hard.

RE: Small multiplier support in Cortex-M0/1/+

2014-11-12 Thread Hale Wang
> -Original Message- > From: Christophe Lyon [mailto:christophe.l...@linaro.org] > Sent: Wednesday, November 12, 2014 9:49 PM > To: Hale Wang > Cc: gcc-patches@gcc.gnu.org > Subject: Re: Small multiplier support in Cortex-M0/1/+ > > On 21 October 2014 12:01, Hale Wang wrote: > > Hi, > > >

[PATCH, trivial][AArch64] Fix mode iterator for *aarch64_simd_ld1r pattern

2014-11-12 Thread Yangfei (Felix)
Hi, We find that the VALLDI mode iterator used in *aarch64_simd_ld1r pattern is not appropriate. The reason is that it's impossible to get a new operand of DImode by vec_duplicating an operand of the same mode. So this patch just excludes the DImode and uses VALL instead. Reg-tested f

[PATCH 3/5] fix hash_table when empty elements are not 0

2014-11-12 Thread tsaunders
From: Trevor Saunders hi, The problem here is that hash_table used to zero element storage, but if the empty element is not 0 then all elements appear to be in use. bootstrapped + regtested x86_64-unknown-linux-gnu, ok? Trev gcc/ChangeLog: 2014-11-13 Trevor Saunders * hash-table

[PATCH 4/5] remove param$N_is usage

2014-11-12 Thread tsaunders
From: Trevor Saunders Hi, The only user of this is splay_tree. We only have a couple splay trees in ggc memory, and it wasn't clear to me any of them were tree based instead of hash based for performance reasons, so I chose to just convert them to hash_map rather than writing a templated splay

[PATCH 5/5] use vec in lto_tree_ref_table

2014-11-12 Thread tsaunders
From: Trevor Saunders Hi, gengtype fails to create valid user marking functions for this type, which is fixed by using vec here (which seems cleaner anyway). bootstrapped + regtested powerpc64-linux (gcc 110 since gcc20 died) ok? Trev gcc/ChangeLog: 2014-11-13 Trevor Saunders *

[PATCH 2/5] remove the remaining uses of if_marked

2014-11-12 Thread tsaunders
From: Trevor Saunders Hi, $subject. bootstrapped + regtested x86_64-unknown-linux-gnu, ok? Trev ada/ * gcc-interface/decl.c, gcc-interface/utils.c: replace htab with hash_table. cp/ * cp-objcp-common.c: Use hash_table instead of htab. gcc/ * config/i386/i

[PATCH 1/5] add an alternative to if_marked using hash_table

2014-11-12 Thread tsaunders
From: Trevor Saunders Hi, This adds a gty cache attribute that calls user code after marking and before sweeping allowing user code to mark more objects or clear caches as appropriate. User code for hash_table is set up to work similarly to if_marked for htab. bootstrapped + regtested x86_64-

[PATCH ARM]Prefer neon for stringops on a53/a57 in AArch32 mode

2014-11-12 Thread Bin Cheng
Hi, As commented at https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00684.html, this is a simple patch enabling neon memset inlining on cortex-a53/cortex-a57 in AArch32 mode. Test on arm-none-linux-gnueabihf/--with-cpu=cortex-a57/--with-fpu=crypto-neon-fp-arm v8/--with-float=hard. I will further co

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Andrew Pinski
On Wed, Nov 12, 2014 at 9:38 PM, Teresa Johnson wrote: > On Wed, Nov 12, 2014 at 9:30 PM, Andrew Pinski wrote: >> On Wed, Nov 12, 2014 at 9:25 PM, Teresa Johnson wrote: >>> Added testcase. Here is the new patch: >>> >>> 2014-11-12 >>> >>> gcc: >>> PR tree-optimization/63841 >>>

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Teresa Johnson
On Wed, Nov 12, 2014 at 9:30 PM, Andrew Pinski wrote: > On Wed, Nov 12, 2014 at 9:25 PM, Teresa Johnson wrote: >> Added testcase. Here is the new patch: >> >> 2014-11-12 >> >> gcc: >> PR tree-optimization/63841 >> * tree.c (initializer_zerop): A constructor with no elements >>

[gomp4] fix omp_clause_code_name

2014-11-12 Thread Cesar Philippidis
debug_tree was throwing an ICE when I was debugging scan_sharing_clauses in omp-low.c. The problem turned out to be a missing comma. I've applied this fix to gomp-4_0-branch. Cesar 2014-11-12 Cesar Philippidis gcc/ * tree.c (omp_clause_code_name): Add missing comma after "_Cilk_for_count_".

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Andrew Pinski
On Wed, Nov 12, 2014 at 9:25 PM, Teresa Johnson wrote: > Added testcase. Here is the new patch: > > 2014-11-12 > > gcc: > PR tree-optimization/63841 > * tree.c (initializer_zerop): A constructor with no elements > does not zero initialize. Actually an empty constructor

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Teresa Johnson
Added testcase. Here is the new patch: 2014-11-12 gcc: PR tree-optimization/63841 * tree.c (initializer_zerop): A constructor with no elements does not zero initialize. gcc/testsuite: * g++.dg/tree-ssa/pr63841.C: New test. Index: tree.c ==

Re: Updated LRA rematerialization patch has been committed

2014-11-12 Thread Vladimir Makarov
On 2014-11-12 11:06 PM, H.J. Lu wrote: Unfortunately, it breaks bootstrap on Linux/ia32: https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00288.html ../../../src-trunk/libgcc/config/libbid/bid_round.c: In function â__bid_round128_19_38â: ../../../src-trunk/libgcc/config/libbid/bid_round.c:391:

LTO streaming of TARGET_OPTIMIZE_NODE

2014-11-12 Thread Jan Hubicka
Hi, this patch adds infrastructure for proper streaming and merging of TREE_TARGET_OPTION. The catch is that TREE_TARGET_OPTION is autogenerated structure. For x86_64 it looks as follows: /* Structure to save/restore selected target specific options. */ struct GTY(()) cl_target_option { HOST_

Re: Updated LRA rematerialization patch has been committed

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 7:08 PM, Vladimir Makarov wrote: > After submitting LRA rematerialization patch, I got a lot of > feedback. Some people reported performance degradation and pointed me > out the most important problem which looks like > > p0 <- p1 + p2 p0 <- p1 + p

Re: [RTL, Patch] Int div by constant compilation enhancement

2014-11-12 Thread H.J. Lu
On Mon, Nov 3, 2014 at 9:01 AM, Alex Velenko wrote: > Hi, > This patch adds a mid-end check to catch division by > constant case and optimize it to generate one shift, > instead of two. > > A testacase to check the correct codegeneration for aarch64 > is added. This check is not made generic, beca

Updated LRA rematerialization patch has been committed

2014-11-12 Thread Vladimir Makarov
After submitting LRA rematerialization patch, I got a lot of feedback. Some people reported performance degradation and pointed me out the most important problem which looks like p0 <- p1 + p2 p0 <- p1 + p2 spilled_pseudo <- p0 spilled_pseudo <- p0 ..

Re: PATCH [3 of 7], rs6000, add support for scalar floating point in Altivec registers

2014-11-12 Thread David Edelsohn
On Tue, Nov 11, 2014 at 8:02 PM, Michael Meissner wrote: > Last year, in preparation for the upper regs patch, I went through the > instructions, and changed the iterators, so the vector support was in vsx.md, > while the scalar support was in rs6000.md. I missed the int<->fp conversion > operato

Re: PATCH [2 of 7], rs6000, add support for scalar floating point in Altivec registers

2014-11-12 Thread David Edelsohn
On Tue, Nov 11, 2014 at 7:56 PM, Michael Meissner wrote: > When I did the original power7 work, I put the reload handlers into vector.md, > since they were only used for vector types. Since they are now more general, > I > am moving these insns from vector.md to rs6000.md. Is this patch accepta

Re: PATCH [patch 1 of 7], rs6000, add support for scalar floating point in Altivec registers

2014-11-12 Thread David Edelsohn
On Tue, Nov 11, 2014 at 7:53 PM, Michael Meissner wrote: > At one stage in working on the patches, I was editing the easy_fp_constant > predicate, and I noticed there was a test for the constant 0.0 at the top of > the function, as well as redundant tests in SFmode/DFmode. I deleted these > redun

Re: [PR c/52952] More precise locations within format strings

2014-11-12 Thread Manuel López-Ibáñez
On 13 November 2014 03:07, Mike Stump wrote: > On Nov 12, 2014, at 3:52 PM, Manuel López-Ibáñez > wrote: >> On 12 November 2014 22:41, Jakub Jelinek wrote: >>> I think we had discussions on this topic, the important thing is that we >>> don't want to generate different warnings based on whether

Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

2014-11-12 Thread David Malcolm
On Tue, 2014-11-11 at 08:26 +0100, Jakub Jelinek wrote: > On Mon, Nov 10, 2014 at 05:27:50PM -0500, David Malcolm wrote: > > On Sat, 2014-11-08 at 14:56 +0100, Jakub Jelinek wrote: > > > On Sat, Nov 08, 2014 at 01:07:28PM +0100, Richard Biener wrote: > > > > To be constructive here - the above case

Re: [PR c/52952] More precise locations within format strings

2014-11-12 Thread Mike Stump
On Nov 12, 2014, at 3:52 PM, Manuel López-Ibáñez wrote: > On 12 November 2014 22:41, Jakub Jelinek wrote: >> I think we had discussions on this topic, the important thing is that we >> don't want to generate different warnings based on whether -save-temps has >> been used, there could be just com

Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

2014-11-12 Thread David Malcolm
On Tue, 2014-11-11 at 11:43 +0100, Richard Biener wrote: > On Tue, Nov 11, 2014 at 8:26 AM, Jakub Jelinek wrote: > > On Mon, Nov 10, 2014 at 05:27:50PM -0500, David Malcolm wrote: > >> On Sat, 2014-11-08 at 14:56 +0100, Jakub Jelinek wrote: > >> > On Sat, Nov 08, 2014 at 01:07:28PM +0100, Richard

libsanitizer merge from upstream r221802

2014-11-12 Thread Konstantin Serebryany
Hi, Here is one more merge of libsanitizer (last one was in Sept). Tested on x86_64 Ubuntu 14.04 like this: rm -rf */{*/,}libsanitizer && make -j 50 make -j 40 -C gcc check-g{cc,++} RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} asan.exp' && \ make -j 40 -C gcc check-g{cc,++} RUNTESTFLAGS='--targ

[PATCH obvious] Fix quoting in several diagnostics

2014-11-12 Thread Manuel López-Ibáñez
Committed as obvious (after bootstrapping®test). https://gcc.gnu.org/r217457 2014-11-13 Manuel López-Ibáñez * opts-global.c (postpone_unknown_option_warning): Fix spelling. (print_ignored_options): Fix quoting. * opts.c (common_handle_option): Likewise. (set_debug_level): Lik

Re: [PATCH] Make -fdiagnostics-color= default configurable, default to =auto

2014-11-12 Thread Manuel López-Ibáñez
I think it is great that =auto becomes the default. However, adding a configure option for this seems overkill. If anyone really really wishes to change the default, they can simply edit a single-line in common.opt. Apart from that, I really cannot understand why someone would want the options non

Go patch committed: Report unused packages correctly for ambiguous lookups

2014-11-12 Thread Ian Taylor
This patch from Chris Manghane fixes the Go frontend to correctly report unused packages when there are ambiguous lookups. Previously some cases involving composite literals could cause a package to be considered as used, when it was really not used. That is, in some cases, the compiler did not r

Re: [patch] libstdc++/57250 shared_ptr atomic operations

2014-11-12 Thread Jonathan Wakely
On 17/10/14 19:27 +0100, Jonathan Wakely wrote: I'm not very proud of this solution, but unless anyone has a better ideas this is how I plan to add the atomic operations for shared_ptr. I used __gnu_cxx::__mutex instead of std::mutex because it has fewer dependencies, so the atomic operations sh

Re: [PR c/52952] More precise locations within format strings

2014-11-12 Thread Manuel López-Ibáñez
On 12 November 2014 22:41, Jakub Jelinek wrote: > I think we had discussions on this topic, the important thing is that we > don't want to generate different warnings based on whether -save-temps has > been used, there could be just comment in between ) and ; etc. How can --save-temps influence w

Re: [GRAPHITE, PATCH] Loop unroll and jam optimization

2014-11-12 Thread Mircea Namolaru
> > > At this point pbb->transformed has two basic maps, one is the mapping for > > unroll and jam, > > and one for the full tile for the striped dimension. Introduce a check that > > differentiate > > between them as the image of one maps should be included in the other. > > I didn't do a full

Re: [PATCH][wwwdocs] Update changes.html with Cortex-A53 erratum workaround options

2014-11-12 Thread Gerald Pfeifer
On Wednesday 2014-11-12 16:31, Kyrill Tkachov wrote: This patch adds the Cortex-A53 erratum workaround options item to the changes page (and adds the AArch64 section of that page in the process) Ok? Looks perfect to me. Thanks, Gerald

Re: [PATCH][wwwdocs] Update changes.html with Cortex-A53 erratum workaround options

2014-11-12 Thread Jeff Law
On 11/12/14 09:31, Kyrill Tkachov wrote: Hi all, This patch adds the Cortex-A53 erratum workaround options item to the changes page (and adds the AArch64 section of that page in the process) Ok? OK jeff

Re: [PATCH][12/n] Merge from match-and-simplify, pointer-plus patterns and forwprop re-org

2014-11-12 Thread H.J. Lu
On Fri, Nov 7, 2014 at 12:53 AM, Richard Biener wrote: > > This interleaves stmt folding and manual simplifications done in > forwprop into a single loop over all basic-blocks. It somewhat > complicates things as we need to make sure the lattice stays > valid when releasing SSA names from old cod

Re: [PATCH][sched-deps] Remove needless check for modified_in_p when trying to fuse two non-conditional jump insns

2014-11-12 Thread Jeff Law
On 11/12/14 09:23, Kyrill Tkachov wrote: Hi all, I noticed that the check for modified_in_p in sched-deps is not needed and needlessly restricts the insn pairs that we can check for macro fusion in the backend hooks. This patch removes the check. Currently that execution path is only used in ar

Re: Concepts code review

2014-11-12 Thread Andrew Sutton
>> Agreed. I'll probably start looking at this on Friday morning. > > > Note that end of stage 1 is Saturday, as I just realized today. So the > sooner the better. :) Ouch. Good thing my merge with trunk broke in unexpected ways this morning -- minimally, something in cgraph ended up missing a #

Re: [PATCH] Propagate nonfreeing_call_p using ipa-pure-const

2014-11-12 Thread Jan Hubicka
> On Wed, Nov 12, 2014 at 02:49:30PM +0400, Maxim Ostapenko wrote: > > We used this code for IPA propagation of nonfreeing_call_p. It implemented > > with a separate pass, but it probably could be propagated in some existing > > one. This analysis doesn't seem to be costly thought, we didn't see an

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-12 Thread Joseph Myers
On Thu, 13 Nov 2014, Ilya Enkovich wrote: > It's hard to decide which of runtime functionality should be > considered as basic and how it should be used. We may say that the > only basic thing is hardware enabling which is enable_mpx and stop > here. But then you get minimal but quite useless li

Re: [PATCH] Fix ipa-pure-const can_throw propagation

2014-11-12 Thread Jan Hubicka
> Hi! > > The following testcase is miscompiled starting with 4.6. > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk? > > For 4.9/4.8, I'd prefer to use a one-liner instead: > - for (ie = node->indirect_calls; ie; ie = ie->next_callee) > + for

RE: [PATCHv4][MIPS] Implement O32 ABI extensions (GCC)

2014-11-12 Thread Matthew Fortune
> > Moore, Catherine writes: > > > The patch looks good. Please fix up these couple of nits prior to > > > committing. > > > > OK, thanks for the second read through. One further amendment below, > > I'll aim to commit later today. > > > > Yes, that's better. Committed as r217446 Fingers cros

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-12 Thread Ilya Enkovich
2014-11-13 0:40 GMT+03:00 Joseph Myers : > On Wed, 12 Nov 2014, Ilya Enkovich wrote: > >> MPX runtime needs to be linked with programs using MPX because it >> initializes hardware. Without it all MPX instructions are just NOPs. >> Thus it's not an extra functionality, but is for basic MPX >> funct

[PATCH] Propagate nonfreeing_call_p using ipa-pure-const

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 02:49:30PM +0400, Maxim Ostapenko wrote: > We used this code for IPA propagation of nonfreeing_call_p. It implemented > with a separate pass, but it probably could be propagated in some existing > one. This analysis doesn't seem to be costly thought, we didn't see any > sign

[PATCH] Optimize ASAN_CHECK checks

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 02:09:59PM +0300, Yury Gribov wrote: > >For asan you're right, we can have addresses of decls there etc. > >If you have spare cycles, feel free to take over the patch and adjust it. > > I guess I'd wait when this gets to trunk? Ok, in that case I've bootstrapped/regtested

[PATCH] Fix ipa-pure-const can_throw propagation

2014-11-12 Thread Jakub Jelinek
Hi! The following testcase is miscompiled starting with 4.6. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? For 4.9/4.8, I'd prefer to use a one-liner instead: - for (ie = node->indirect_calls; ie; ie = ie->next_callee) + for (ie = w->indirect

[PATCH] Make -fdiagnostics-color= default configurable, default to =auto

2014-11-12 Thread Jakub Jelinek
Hi! This patch makes the -fdiagnostics-color= default configurable, and changes the default (if no configure option is specified for it) to --with-diagnostics-color=auto. The previous behavior can be restored with --with-diagnostics-color=auto-if-env , the 4.8 behavior (never coloring anything) w

Re: [PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-12 Thread Joseph Myers
On Wed, 12 Nov 2014, Iain Sandoe wrote: > libatomic: PR target/59305 (at least, I presume this fixes that bug; I don't know if there are any other relevant bugs in Bugzilla). > * config/darwin/host-config.h New. > * config/darwin/lock.c New. > * configure.tgt (DEFAULT

Re: [PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Xinliang David Li
missing test case? David On Wed, Nov 12, 2014 at 2:13 PM, Teresa Johnson wrote: > This patch fixes an issue where tree-strlen was incorrectly removing a > store of 0 into a string because it thought a prior CLOBBER (which is > an empty constructor with no elements) was zero-initializing the > st

[PATCH] Fix PR/63841: empty constructor doesn't zero-initialize

2014-11-12 Thread Teresa Johnson
This patch fixes an issue where tree-strlen was incorrectly removing a store of 0 into a string because it thought a prior CLOBBER (which is an empty constructor with no elements) was zero-initializing the string. Bootstrapped and tested on x86_64-unknown-linux-gnu. OK for trunk? Thanks, Teresa

Re: [PATCH, RFC, C] Add -fno-float to forbid floating point data types

2014-11-12 Thread Joseph Myers
On Wed, 12 Nov 2014, Thomas Preud'homme wrote: > In several occasions (see [1][2] people requested a switch to tell GCC > that a given compilation unit should not contain any float and that GCC > should warn about any violation of this assumption. Such a switch would > ensure that no softfloat

Re: [PATCH] Add a way to mark regions of code which assume that the GC won't run

2014-11-12 Thread David Malcolm
On Wed, 2014-11-12 at 13:16 -0500, David Malcolm wrote: > We make assumptions in the codebase about when the GC can run, and when > it can't (e.g. within numerous passes) but these aren't captured in a way > that's verifiable. > > This patch introduces macros GGC_{BEGIN|END}_ASSERT_NO_COLLECTIONS

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 2:00 PM, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 01:51:01PM -0800, H.J. Lu wrote: >> > So, all in all, SET_REGNO sounds inappropriate to me, everywhere else >> > gen_raw_REG or gen_rtx_REG is used instead, so IMNSHO you should do the >> > same. >> > >> > Jaku

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread Uros Bizjak
On Wed, Nov 12, 2014 at 11:00 PM, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 01:51:01PM -0800, H.J. Lu wrote: >> > So, all in all, SET_REGNO sounds inappropriate to me, everywhere else >> > gen_raw_REG or gen_rtx_REG is used instead, so IMNSHO you should do the >> > same. >> > >> > Jak

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 01:51:01PM -0800, H.J. Lu wrote: > > So, all in all, SET_REGNO sounds inappropriate to me, everywhere else > > gen_raw_REG or gen_rtx_REG is used instead, so IMNSHO you should do the > > same. > > > > Jakub > > It makes sense. I checked in the following patch. gen

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 1:39 PM, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 01:11:40PM -0800, H.J. Lu wrote: >> On Wed, Nov 12, 2014 at 1:02 PM, Jakub Jelinek wrote: >> > On Wed, Nov 12, 2014 at 12:43:17PM -0800, H.J. Lu wrote: >> >> @@ -42686,8 +42692,12 @@ x86_output_mi_thunk (FILE *file, t

Re: [RFC testsuite] Allow wrappers to choose file names based on pids

2014-11-12 Thread Mike Stump
On Nov 12, 2014, at 8:53 AM, Ramana Radhakrishnan wrote: > One of the problems we appear to face with multilib testing especially > with conflicting ABIs in the ARM world is the occasional case where a > testglue file is built for one ABI but gets linked against a multilib test > invocat

Re: Concepts code review

2014-11-12 Thread Jason Merrill
On 11/12/2014 10:27 AM, Andrew Sutton wrote: Agreed. I'll probably start looking at this on Friday morning. Note that end of stage 1 is Saturday, as I just realized today. So the sooner the better. :) deduce_concept_introduction (tree expr) Do you still need this coerce_template_parms

Re: [PR c/52952] More precise locations within format strings

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 01:24:18PM -0800, Mike Stump wrote: > On Nov 12, 2014, at 7:04 AM, Manuel López-Ibáñez > wrote: > > And I think GCC is wrong to wan here. The point of the Wempty-body > > warning is to catch things like: > > > > if(a); > > return 2; > > return 3; > > > > However, > > >

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-12 Thread Joseph Myers
On Wed, 12 Nov 2014, Ilya Enkovich wrote: > MPX runtime needs to be linked with programs using MPX because it > initializes hardware. Without it all MPX instructions are just NOPs. > Thus it's not an extra functionality, but is for basic MPX > functionality. So what if you just have the cons

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 01:11:40PM -0800, H.J. Lu wrote: > On Wed, Nov 12, 2014 at 1:02 PM, Jakub Jelinek wrote: > > On Wed, Nov 12, 2014 at 12:43:17PM -0800, H.J. Lu wrote: > >> @@ -42686,8 +42692,12 @@ x86_output_mi_thunk (FILE *file, tree, > >> HOST_WIDE_INT delta, > >>else > >> { > >

Re: The nvptx port [0/11+]

2014-11-12 Thread Jeff Law
On 11/12/14 05:34, Richard Biener wrote: Now that this has been committed - I notice that there is no entry in MAINTAINERS for the port. I propose Bernd. Well, ahead of you there. I proposed Bernd to the steering committee as the maintainer a little while ago. I need to go back and count v

Re: [PR c/52952] More precise locations within format strings

2014-11-12 Thread Mike Stump
On Nov 12, 2014, at 7:04 AM, Manuel López-Ibáñez wrote: > And I think GCC is wrong to wan here. The point of the Wempty-body > warning is to catch things like: > > if(a); > return 2; > return 3; > > However, > > if(a) > ; > return 2; In the olden days, we didn’t have enough information to do

[PATCH, Libatomic, Darwin] Initial libatomic port for *darwin*.

2014-11-12 Thread Iain Sandoe
Hi Richard, The posix fallback for libatomic locks on unsupported item sizes (using pthreads) might be reliable, but is (not surprisingly) somewhat slow. Whereas the built-in testsuite from libatomic passes .. .. every Darwin platform from powerpc-darwin9 (on a G5) .. through x86-64-darwin14 (

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 1:02 PM, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 12:43:17PM -0800, H.J. Lu wrote: >> @@ -42686,8 +42692,12 @@ x86_output_mi_thunk (FILE *file, tree, >> HOST_WIDE_INT delta, >>else >> { >>if (ix86_cmodel == CM_LARGE_PIC && SYMBOLIC_CONST (fnaddr)) >>

Re: [PATCH 1/5] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin (repost)

2014-11-12 Thread Mike Stump
On Nov 12, 2014, at 2:55 AM, Thomas Schwinge wrote: > There is no mechanism in DejaGnu to pass environment variables to remote > boards (which we're using in internal testing), and we currently use that > to circle through available accelerators/libgomp plugins So, two thoughts come to mind. In

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 12:43:17PM -0800, H.J. Lu wrote: > @@ -42686,8 +42692,12 @@ x86_output_mi_thunk (FILE *file, tree, HOST_WIDE_INT > delta, >else > { >if (ix86_cmodel == CM_LARGE_PIC && SYMBOLIC_CONST (fnaddr)) > - fnaddr = legitimize_pic_address (fnaddr, > -

Re: [RFC testsuite] Allow wrappers to choose file names based on pids

2014-11-12 Thread Jeff Law
On 11/12/14 09:53, Ramana Radhakrishnan wrote: Hi, One of the problems we appear to face with multilib testing especially with conflicting ABIs in the ARM world is the occasional case where a testglue file is built for one ABI but gets linked against a multilib test invocation with another

Re: PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread Uros Bizjak
On Wed, Nov 12, 2014 at 9:43 PM, H.J. Lu wrote: > Hi, > > r216154 exposed an x86 backend bug. For large PIC mode thunk, there > are > > if (ix86_cmodel == CM_LARGE_PIC && SYMBOLIC_CONST (fnaddr)) > fnaddr = legitimize_pic_address (fnaddr, > g

Re: [PATCH, MPX runtime 1/2] Integrate MPX runtime library

2014-11-12 Thread Jeff Law
On 11/11/14 13:22, Ilya Enkovich wrote: This library (some version of it) was only published in a binary form some time ago. AFAIK currently it is not a part of any product. Sources were never made public before. Sources go under the same license as Cilk runtime and therefore require approval

Re: libgomp: "GNU OpenMP Runtime Library" (was: [PATCH 1/5] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin (repost))

2014-11-12 Thread David Malcolm
On Wed, 2014-11-12 at 21:30 +0100, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 03:22:21PM -0500, David Malcolm wrote: > > On Wed, 2014-11-12 at 14:47 +0100, Jakub Jelinek wrote: > > > On Wed, Nov 12, 2014 at 08:33:34AM -0500, David Malcolm wrote: > > > > Apologies for bikeshedding, and I normall

PATCH: PR target/63815: [5 Regression] g++.dg/other/pr53811.C fails with -mcmodel=large -fpic

2014-11-12 Thread H.J. Lu
Hi, r216154 exposed an x86 backend bug. For large PIC mode thunk, there are if (ix86_cmodel == CM_LARGE_PIC && SYMBOLIC_CONST (fnaddr)) fnaddr = legitimize_pic_address (fnaddr, gen_rtx_REG (Pmode, tmp_regno)); and legitimize_pic_address doe

Re: [PATCH, ifcvt] Allow CC mode if HAVE_cbranchcc4 (fix s390 build)

2014-11-12 Thread Ulrich Weigand
Zhenqiang Chen wrote: > Function noce_emit_store_flag tries to generate instruction to store flag by > emit_store_flag for general_operand. For s390, CCU is a general _operand, > but can not match cstorecc4, then it tries to generate a register move > instruction from CCU to CCZ1, which will trigg

Re: libgomp: "GNU OpenMP Runtime Library" (was: [PATCH 1/5] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin (repost))

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 03:22:21PM -0500, David Malcolm wrote: > On Wed, 2014-11-12 at 14:47 +0100, Jakub Jelinek wrote: > > On Wed, Nov 12, 2014 at 08:33:34AM -0500, David Malcolm wrote: > > > Apologies for bikeshedding, and I normally dislike "cute" names, but > > > renaming it to > > > > > >

Re: libgomp: "GNU OpenMP Runtime Library" (was: [PATCH 1/5] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin (repost))

2014-11-12 Thread David Malcolm
On Wed, 2014-11-12 at 14:47 +0100, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 08:33:34AM -0500, David Malcolm wrote: > > Apologies for bikeshedding, and I normally dislike "cute" names, but > > renaming it to > > > >"GNU Offloading and Multi Processing library" > > > > would allow a backr

Re: Follow-up to PR51471

2014-11-12 Thread Jeff Law
On 11/11/14 15:28, Eric Botcazou wrote: In https://gcc.gnu.org/ml/gcc-patches/2012-01/msg00363.html, Tom reported an ICE in the DWARF CFI pass because a frame-related insn was speculated by the reorg pass and, therefore, disabled the optimization. It turns out that the same code (when condition

[patch] Apply LWG 2399, 2400 and 2401 to std::shared_ptr and std::function

2014-11-12 Thread Jonathan Wakely
These issues just became DRs in Urbana. Tested x86_64-linux, committed to trunk. The other new DRs we need to make changes for are 2212 (to shuffle some code between headers), 2217 (which I sent an email about earlier) and 2354 (adding some new insert overloads in RB trees). commit 5930336c2050

RE: [PATCH 0/4][Vectorizer] Reductions: replace VEC_RSHIFT_EXPR with VEC_PERM_EXPR

2014-11-12 Thread Matthew Fortune
> (for MIPS) https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01481.html, > although I have not been able to test this as there doesn't seem to be > any working MIPS/Loongson hardware in the Compile Farm; I will post a patch to remove vec_shl and only support vec_shr for little endian. This is on the

RE: [PATCHv4][MIPS] Implement O32 ABI extensions (GCC)

2014-11-12 Thread Moore, Catherine
> -Original Message- > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > Sent: Wednesday, November 12, 2014 1:59 PM > To: Moore, Catherine; 'gcc-patches@gcc.gnu.org' (gcc- > patc...@gcc.gnu.org); Eric Christopher (echri...@gmail.com) > Cc: Richard Sandiford; Rich Fuhler; Rozycki

Re: [PATCH 10/11][RS6000] Migrate reduction optabs to reduc_..._scal

2014-11-12 Thread Michael Meissner
On Wed, Nov 12, 2014 at 03:26:35AM -0600, Segher Boessenkool wrote: > On Tue, Nov 11, 2014 at 08:27:22PM -0500, Michael Meissner wrote: > > > Before the patch, the final reduction used *vsx_reduc_splus_v2df; after > > > the patch, it is *vsx_reduc_plus_v2df_scalar. The former does a vector > > > a

RE: [PATCHv4][MIPS] Implement O32 ABI extensions (GCC)

2014-11-12 Thread Matthew Fortune
Moore, Catherine writes: > The patch looks good. Please fix up these couple of nits prior to > committing. OK, thanks for the second read through. One further amendment below, I'll aim to commit later today. > Index: gcc/config/mips/mips.c > ===

Re: [PATCH][17/n] Merge from match-and-simplify, plus/minus association patterns

2014-11-12 Thread H.J. Lu
On Wed, Nov 12, 2014 at 9:55 AM, H.J. Lu wrote: > On Tue, Nov 11, 2014 at 5:13 AM, Richard Biener wrote: >> >> This merges patterns from associate_plusminus and adjusts them with >> details from their fold-const.c pendants. It also fixes missing >> flag_sanitize checks on negate contraction on t

Re: [PATCH][AArch64] Add bounds checking to vqdm*_lane intrinsics via a qualifier that also flips endianness

2014-11-12 Thread Alan Lawrence
Pushed as r217440, also with Charles' whitespace fixes ('' -> tab) - good spot! Cheers, Alan Marcus Shawcroft wrote: On 6 November 2014 10:19, Alan Lawrence wrote: This generates out-of-range errors at compile- (rather than assemble-)time for the vqdm*_lane intrinsics, and also provi

Re: [PATCH 10/11][RS6000] Migrate reduction optabs to reduc_..._scal

2014-11-12 Thread Alan Lawrence
Have run check-gcc on gcc110.fsffrance.org (powerpc64-unknown-linux-gnu) using this snippet on top of original patch; no regressions. Alan Lawrence wrote: So I'm no expert on RS6000 here, but following on from Segher's observation about the change in pattern...so the difference in 'expand' is e

  1   2   3   >