Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-01 Thread Ed Smith-Rowland
On 10/01/2014 11:28 AM, Jonathan Wakely wrote: On 02/09/14 10:24 +0100, Jonathan Wakely wrote: On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: Index: include/bits/stl_function.h === --- include/bits/stl_function.h(revision 214

Re: std::regex: inserting std::wregex to std::vector loses some std::wregex values

2014-10-01 Thread Tim Shen
On Tue, Sep 30, 2014 at 5:15 AM, Jonathan Wakely wrote: > Please put the PR number in the ChangeLog, so it updates Bugzilla > automatically. Good catch ;) > You've spelled it "ompatibility" everywhere. I think we only need the > note once, maybe on the move constructor or rvalue basic_regex::ass

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 10:43 PM, Jakub Jelinek wrote: > > For PR62128, IMHO the right fix is attached. Note, this is again covered > > in vshuf-*.c tests (test 22 in both vshuf-v32*.c and vshuf-v16*.c). > > With that attached patch, pr62128.c (aka test_22 in vshuf-v32qi.c), changes: > > -

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 04:21:29PM -0700, Alexey Samsonov wrote: > Speaking of plain -f(no-)sanitize-recover - it would probably be > better to change the semantics of this flag, > so that "-f(no-)?sanitize-recover" means "enable(disable) recovery for > all sanitizers enabled at this point". > That

Fix ipa.c dumping ICE

2014-10-01 Thread Jan Hubicka
Hi, this patch fixes ICE on missing call_stmt during WPA. Index: ChangeLog === --- ChangeLog (revision 215791) +++ ChangeLog (working copy) @@ -1,5 +1,10 @@ 2014-10-01 Jan HUbicka + * ipa.c (walk_polymorphic_call_target

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 4:09 PM, Jan Hubicka wrote: >> The block frequencies are very small in this case leading to rounding >> errors when computing the edge frequency. The rounding error was then >> propagated into the recomputed probabilities, leading to insanities in >> the outgoing edge probab

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 3:46 PM, Steve Ellcey wrote: > On Wed, 2014-10-01 at 13:04 -0700, Teresa Johnson wrote: > >> 2014-10-01 Teresa Johnson >> >> * tree-ssa-threadupdate.c (freqs_to_counts_path): Scale frequencies >> up when synthesizing counts to avoid rounding errors. > > I

Avoid creation of bogus type variant in cgraphclones.c

2014-10-01 Thread Jan Hubicka
Hi, this patch avoids creation of bogus type variant i ncgraphclones.c. This is same as my earlier patch to ipa-prop Bootstrapped/regtested x86_64-linux. Honza * cgraphclones.c (build_function_type_skip_args): Do not add new type as variant. Index: cgraphclones.c =

Re: Infrastructure for forward propagation of polymorphic call contexts

2014-10-01 Thread Jan Hubicka
Hi, this is version of patch I comitted after testing at firefox and libreoffice. It fixes some issues with mixing in non-C++ types and upper-casting. The number of devirtualizations is now down to 5000 for Firefox, but that seems more realistic. Bootstrapped/regtested x86_64-linux, comitted. Hon

[PATCH 1/5] Fix error location for cilk error message

2014-10-01 Thread Andi Kleen
From: Andi Kleen Output the correct location for an existing cilk error message. gcc/c-family/: 2014-09-28 Andi Kleen * cilk.c (recognize_spawn): Use expression location for error message. --- gcc/c-family/cilk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH 2/5] Error out for Cilk_spawn or array expression in forbidden places

2014-10-01 Thread Andi Kleen
From: Andi Kleen _Cilk_spawn or Cilk array expressions are only allowed on their own, but not in for(), if(), switch, do, while, goto, etc. The C parser didn't always check for that, which lead to ICEs earlier for invalid code. Add a generic helper that checks this and call it where needed in th

[PATCH 4/5] Fix some of the existing Cilk tests for the new errors.

2014-10-01 Thread Andi Kleen
From: Andi Kleen gcc/testsuite/: 2014-09-30 Andi Kleen * c-c++-common/cilk-plus/AN/misc.c (main): Handle new cilk errors. --- gcc/testsuite/c-c++-common/cilk-plus/AN/misc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/testsuite/c-c++-common

[PATCH 5/5] Add illegal cilk checks to C++ front.

2014-10-01 Thread Andi Kleen
From: Andi Kleen Add calls for several illegal Cilk cases to the C++ frontend. C++ usually doesn't ICE unlike C on illegal cilk, but it's better to match C in what is allowed and what is not. if (_Cilk_spawn ...) is still not errored, but at least it doesn't ICE. gcc/cp/: 2014-09-30 Andi Klee

[PATCH 3/5] Add test cases for all the new cilk errors

2014-10-01 Thread Andi Kleen
From: Andi Kleen gcc/testsuite/: 2014-09-30 Andi Kleen * c-c++-common/cilk-plus/CK/errors.c: New test. --- gcc/testsuite/c-c++-common/cilk-plus/CK/errors.c | 56 1 file changed, 56 insertions(+) create mode 100644 gcc/testsuite/c-c++-common/cilk-plus/CK/err

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-01 Thread DJ Delorie
> It seems like the int128 code here was broken and this is continuing > that brokenness. Extended integer types have integer conversion rank > corresponding to their bitsize, so int128 should have higher rank than > long long, but here it was being checked after long long, and your code > al

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-01 Thread Jason Merrill
On 09/30/2014 07:14 PM, DJ Delorie wrote: Could one of you two please review the remaining C++ parts (cp/*) ? https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02360.html + for (i = 0; i < NUM_INT_N_ENTS; i ++) { + if (int_n_enabled_p [i] + && (same_type_p (TYP

Re: [C++ Patch/RFC] PR 53025

2014-10-01 Thread Jason Merrill
On 10/01/2014 12:31 PM, Paolo Carlini wrote: in this issue Daniel argued that the value of a noexcept expression should not depend on constructor elision. I'm open to that, but I don't think it's at all clear in the standard. Then, in the audit trail Marc tentatively suggested something like

Re: RFA: RTL typesafety improvements for ira.c

2014-10-01 Thread David Malcolm
On Wed, 2014-10-01 at 16:34 -0600, Jeff Law wrote: > This was inspired by a discussion with Felix who was making changes in > this area. > > Basically this promotes the "init_insns" field within struct equivalence > from an rtx to an rtx_insn_list. > > The only thing that's really interesting h

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-10-01 Thread Alexey Samsonov
Speaking of plain -f(no-)sanitize-recover - it would probably be better to change the semantics of this flag, so that "-f(no-)?sanitize-recover" means "enable(disable) recovery for all sanitizers enabled at this point". That is, it would be pretty much like -Werror flag. For example, "-fsanitize=u

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Jan Hubicka
> The block frequencies are very small in this case leading to rounding > errors when computing the edge frequency. The rounding error was then > propagated into the recomputed probabilities, leading to insanities in > the outgoing edge probabilities on the jump threading path. Eventually > during

Re: [PATCH] Fix performance break-down in gcc.c-torture/unsorted/dump-noaddr.c

2014-10-01 Thread Jeff Law
On 10/01/14 07:27, Bernd Edlinger wrote: Hi Jeff, as you know, this test case takes too long to complete if the test suite is run with this command line: MALLOC_PERTURB_=237 make -k check The reason was found in libcpp/charset.c, where a reallocation is done one byte at a time. It seems

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-10-01 Thread Jeff Law
On 10/01/14 16:36, Segher Boessenkool wrote: On Sat, Sep 27, 2014 at 05:03:26PM -0500, Segher Boessenkool wrote: I've tried to make a stable future-proof testcase that does such a three-insn combination. Not easy at all. Turns out it is quite easy (when you've seen the solution, anyway :-P )

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Steve Ellcey
On Wed, 2014-10-01 at 13:04 -0700, Teresa Johnson wrote: > 2014-10-01 Teresa Johnson > > * tree-ssa-threadupdate.c (freqs_to_counts_path): Scale frequencies > up when synthesizing counts to avoid rounding errors. I tried this patch on my MIPS toolchain build but GCC is still f

Re: [PATCH] combine: Allow substituting the target reg of a clobber

2014-10-01 Thread Segher Boessenkool
On Sat, Sep 27, 2014 at 05:03:26PM -0500, Segher Boessenkool wrote: > I've tried to make a stable future-proof testcase that does such a three-insn > combination. Not easy at all. Turns out it is quite easy (when you've seen the solution, anyway :-P ) Tested on powerpc64-linux as before, and boo

Re: [Fortran, Patch] Implement IMPLICIT NONE

2014-10-01 Thread Tobias Burnus
Tobias Burnus wrote: IMPLICIT NONE (external) While I have implemented is as vendor extension (-std=gnu) Ups, I forgot to include the gcc/fortran/libgfortran.h change in the patch. See updated attachment. Build and regtested on x86-64-gnu-linux. OK for the trunk? Tobias 2014-10-02 Tobia

RFA: RTL typesafety improvements for ira.c

2014-10-01 Thread Jeff Law
This was inspired by a discussion with Felix who was making changes in this area. Basically this promotes the "init_insns" field within struct equivalence from an rtx to an rtx_insn_list. The only thing that's really interesting here is the old code exploits the fact that we could put any

[Fortran, Patch] Implement IMPLICIT NONE

2014-10-01 Thread Tobias Burnus
I don't want to implement Fortran 90's implicit none, which is of course already supported. However, I would like to implement as vendor extension: IMPLICIT NONE (external) which forces at that least an "external" or "procedure" is used or an explicit interface available, if one tries to inv

Re: [libgo, arm64] Future of reflection

2014-10-01 Thread Ian Lance Taylor
On Wed, Oct 1, 2014 at 2:14 PM, Richard Henderson wrote: > > I've been looking at reflection, and support for non-x86 targets. > > In mainline, there's some support for using libffi, but I wasn't completely > confident that things are working correctly. It doesn't help that the > testsuite still

[debug-early] C++: emit early debug info for all globals, not just statics

2014-10-01 Thread Aldy Hernandez
While hunting another bug, I noticed that the namespace code dumping early debug information was only dumping statics. Ooops... The patch below fixes this oversight. Jason also suggested that we could look into emitting debug info for DECLs directly in rest_of_decl_compilation as we currently

Re: 4.9 backports

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 11:22:14PM +0200, Jan Hubicka wrote: > > Hi! > > > > I'd like to create 4.9.2-rc1 soon (anyone has any pending patches > > for 4.9 branch?), so I've bootstrapped/regtested following 3 > > backports on x86_64-linux and i686-linux. > > > > Ok for 4.9? > > Is the new PR63306

Re: 4.9 backports

2014-10-01 Thread Jan Hubicka
> Hi! > > I'd like to create 4.9.2-rc1 soon (anyone has any pending patches > for 4.9 branch?), so I've bootstrapped/regtested following 3 > backports on x86_64-linux and i686-linux. > > Ok for 4.9? > Is the new PR63306 testcase ok for trunk too? > > Jakub > 2014-10-01 Jakub Jelinek >

[libgo, arm64] Future of reflection

2014-10-01 Thread Richard Henderson
I've been looking at reflection, and support for non-x86 targets. In mainline, there's some support for using libffi, but I wasn't completely confident that things are working correctly. It doesn't help that the testsuite still has conditionals like func TestMakeFunc(t *testing.T) { swi

Re: [PATCH] Fix dwarf2out ICE (PR debug/63342)

2014-10-01 Thread Jason Merrill
On 10/01/2014 04:39 PM, Jakub Jelinek wrote: Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Ok except for the MEM_REF change for 4.9/4.8 (where the mem_loc_descriptor fix also went)? Yes. Jason

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 04:12:15PM +0200, Jakub Jelinek wrote: > For PR62128, IMHO the right fix is attached. Note, this is again covered > in vshuf-*.c tests (test 22 in both vshuf-v32*.c and vshuf-v16*.c). > With that attached patch, pr62128.c (aka test_22 in vshuf-v32qi.c), changes: > - v

[PATCH] Fix dwarf2out ICE (PR debug/63342)

2014-10-01 Thread Jakub Jelinek
Hi! Since r214899 we ICE on the following testcase, because when mem_loc_descriptor gives up on a complex TLS related address that can't be (easily) delegitimized, we try to build location description from MEM_EXPR, but in this case it is a TARGET_MEM_REF which wasn't handled. I've implemented mor

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
The block frequencies are very small in this case leading to rounding errors when computing the edge frequency. The rounding error was then propagated into the recomputed probabilities, leading to insanities in the outgoing edge probabilities on the jump threading path. Eventually during rtl expans

Re: [PATCH, PR 63375] Make SRA check references for volatility

2014-10-01 Thread Richard Biener
On October 1, 2014 4:46:42 PM CEST, Martin Jambor wrote: >Hi, > >at the moment, the only check in SRA for volatility is of the DECLs >themselves. As PR 63375 shows, there can be volatile references to a >non-volatile declaration which must not be ignored, otherwise SRA can >loose the volatility o

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 2:56 PM, Jakub Jelinek wrote: > On Wed, Oct 01, 2014 at 02:25:01PM +0200, Uros Bizjak wrote: >> OK. > > And now the expand_vec_perm_palignr improvement, tested > with GCC_TEST_RUN_EXPENSIVE=1 make check-gcc \ > RUNTESTFLAGS='--target_board=unix/-mavx2 dg-torture.exp=vshuf*.c

Re: [PATCH, i386, Pointer Bounds Checker 33/x] MPX ABI

2014-10-01 Thread Vladimir Makarov
On 2014-09-25 5:46 AM, Ilya Enkovich wrote: 2014-09-25 1:51 GMT+04:00 Ilya Enkovich : 2014-09-24 23:09 GMT+04:00 Jeff Law : On 09/24/14 07:13, Ilya Enkovich wrote: I tried to generate PARALLEL with all regs set by call. Here is a memset call I got: (call_insn 23 22 24 2 (set (parallel [

Re: Enable TBAA on anonymous types with LTO

2014-10-01 Thread Jan Hubicka
> > Ok, as Jason explained this wouldn't work, so we indeed need to stream > TYPE_CANONICAL in this case (and also properly SCC-walk it!) Yep, my patch streams and SCC walks them when they are anonymous. By incremental patch I plan to handle all ODR and component types, so basically stream canoni

Re: [PATCH, i386, Pointer Bounds Checker 30/x] Size relocation

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 7:02 PM, Ilya Enkovich wrote: > 2014-10-01 19:17 GMT+04:00 Uros Bizjak : >> On Wed, Oct 1, 2014 at 4:10 PM, Ilya Enkovich wrote: >> +;; Return true if size of VALUE can be stored in a sign +;; extended immediate field. +(define_predicate "x86_64_immediate_siz

Re: [Patch AArch64] Fix extended register width

2014-10-01 Thread Eric Christopher
On Wed, Oct 1, 2014 at 1:42 AM, Richard Earnshaw wrote: > On 30/09/14 21:30, Eric Christopher wrote: >> On Tue, Sep 30, 2014 at 5:57 AM, Marcus Shawcroft >> wrote: >>> On 22 September 2014 19:41, Carrot Wei wrote: Hi The extended register width in add/adds/sub/subs/cmp instruction

Re: C++ PATCHes to add __is_trivially_*

2014-10-01 Thread Ville Voutilainen
On 1 October 2014 20:20, Jason Merrill wrote: > Here are two more patches: the first fixes trivial_fn_p for a defaulted > default constructor overloaded with a template default constructor, and the > second fixes the variadic case above. Excellent, thank you very much. Paolo, feel free to close

Re: C++ PATCHes to add __is_trivially_*

2014-10-01 Thread Jason Merrill
On 09/30/2014 06:48 PM, Ville Voutilainen wrote: Ville asked for help with the necessary compiler intrinsics for the is_trivially_* >>C++11 library traits. The first patch cleans up a few oddities I noticed with the Great. I think this can be as well marked as PR c++/26099. There's also PR c

Re: [Patch AArch64] Fix extended register width

2014-10-01 Thread Xinliang David Li
On Wed, Oct 1, 2014 at 1:42 AM, Richard Earnshaw wrote: > On 30/09/14 21:30, Eric Christopher wrote: >> On Tue, Sep 30, 2014 at 5:57 AM, Marcus Shawcroft >> wrote: >>> On 22 September 2014 19:41, Carrot Wei wrote: Hi The extended register width in add/adds/sub/subs/cmp instruction

Re: [PATCH] Fix PR63422 to handle profile insanities

2014-10-01 Thread Xinliang David Li
Probably need to file a bug to track the copyrename2 problem. David On Wed, Oct 1, 2014 at 9:59 AM, Teresa Johnson wrote: > This patch removes some asserts my jump threading patch r215739 added. > An upstream pass (copyrename2) is introducing some bogus profile > counts, so we can't assert that

Re: [PATCH, i386, Pointer Bounds Checker 30/x] Size relocation

2014-10-01 Thread Ilya Enkovich
2014-10-01 19:17 GMT+04:00 Uros Bizjak : > On Wed, Oct 1, 2014 at 4:10 PM, Ilya Enkovich wrote: > >>> +;; Return true if size of VALUE can be stored in a sign >>> +;; extended immediate field. >>> +(define_predicate "x86_64_immediate_size_operand" >>> + (match_code "symbol_ref") >>> +{ >>> + if

[PATCH] Fix PR63422 to handle profile insanities

2014-10-01 Thread Teresa Johnson
This patch removes some asserts my jump threading patch r215739 added. An upstream pass (copyrename2) is introducing some bogus profile counts, so we can't assert that counts are 0 when there is no profile data for the function. Tested on testcase attached to PR63422. Currently running gcc regress

Re: Fix libgomp crash without TLS (PR42616)

2014-10-01 Thread Varvara Rainchik
Ok, then here it is a new patch (tested and bootstrapped on linux). On linux with --disable-tls now all libgomp make check tests pass; for Android I've patched toolchain and tried test from one of the mentioned bugs, test passes too. Is there some benchmark to check performance? 2014-10-01 Var

Re: [Patchv2 3/4] Control SRA and IPA-SRA by a param rather than MOVE_RATIO

2014-10-01 Thread James Greenhalgh
On Fri, Sep 26, 2014 at 10:11:13AM +0100, Richard Biener wrote: > On Thu, Sep 25, 2014 at 4:57 PM, James Greenhalgh > wrote: > Given the special value to note the default for the new --params is > zero a user cannot disable scalarization that way. > > I still somehow dislike that you need a targe

Re: Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-01 Thread Ed Smith-Rowland
On 10/01/14, Jonathan Wakely wrote: On 02/09/14 10:24 +0100, Jonathan Wakely wrote: >On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: >>Index: include/bits/stl_function.h >>=== >>--- include/bits/stl_function.h (revision 214680)

[C++ Patch/RFC] PR 53025

2014-10-01 Thread Paolo Carlini
Hi, in this issue Daniel argued that the value of a noexcept expression should not depend on constructor elision. Then, in the audit trail Marc tentatively suggested something like the parser.c hunk below, which just disables our -felide-constructors optimization when parsing the noexcept exp

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 9:20 AM, H.J. Lu wrote: > On Wed, Oct 1, 2014 at 8:29 AM, Teresa Johnson wrote: >> I got the preprocessed source. With the aarch64 cross-compiler I built >> I am able to reproduce the ICE. Looking at it now. > > It may also cause: > > https://gcc.gnu.org/bugzilla/show_bug.c

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread H.J. Lu
On Wed, Oct 1, 2014 at 8:29 AM, Teresa Johnson wrote: > I got the preprocessed source. With the aarch64 cross-compiler I built > I am able to reproduce the ICE. Looking at it now. It may also cause: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63432 -- H.J.

Re: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming

2014-10-01 Thread Ilya Verbin
On 30 Sep 13:40, Thomas Schwinge wrote: > As just discussed for the libgcc changes in > , > just some suggestions regarding the terminology, where I think that the > term »target« might be confusing in comments or

Outstanding MIPS patches

2014-10-01 Thread Moore, Catherine
If you have posted a MIPS patch that needs to be reviewed, please send a link to the original patch and copy Matthew and I. We may not be aware that your patch is outstanding. Thanks, Catherine

Re: [PATCH 1/n] OpenMP 4.0 offloading infrastructure

2014-10-01 Thread Ilya Verbin
On 26 Sep 22:02, Joseph S. Myers wrote: > Any patch adding new configure options needs to add documentation of the > semantics of those options in install.texi. I see no such documentation > in this patch. Done. On 30 Sep 13:16, Thomas Schwinge wrote: > Doesn't that comment belong to real_targ

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Sebastian Pop
Christophe Lyon wrote: > I did it in a followup mail, but the list server rejected it because > it was too large. > I suppose Teresa did receive it though. > > Not sure whether I can attach it in .xz format? Is this allowed? You can open a bug report and attach the preprocessed file there. Thank

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
I got the preprocessed source. With the aarch64 cross-compiler I built I am able to reproduce the ICE. Looking at it now. Thanks, Teresa On Wed, Oct 1, 2014 at 8:25 AM, Christophe Lyon wrote: > On 1 October 2014 17:22, Sebastian Pop wrote: >> Christophe Lyon wrote: >>> Since this commit, I can

Re: [PATCH C++] - SD-6 Implementation Part 3 - .

2014-10-01 Thread Jonathan Wakely
On 02/09/14 10:24 +0100, Jonathan Wakely wrote: On 01/09/14 21:46 -0400, Ed Smith-Rowland wrote: Index: include/bits/stl_function.h === --- include/bits/stl_function.h (revision 214680) +++ include/bits/stl_function.h (working copy)

Re: Fix g++.dg/cpp0x/static_assert9.C failure

2014-10-01 Thread Thomas Schwinge
Hi! On Sat, 20 Sep 2014 01:59:25 +0200, Jan Hubicka wrote: > Bootstrapped/regtested x86_64-linux, comitted. (In r215409.) > PR c++/61825 > * c-family/c-common.c (handle_alias_ifunc_attribute): Check > that visibility change is possible > (handle_weakref_attribute): Likew

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Christophe Lyon
On 1 October 2014 17:22, Sebastian Pop wrote: > Christophe Lyon wrote: >> Since this commit, I can see all my builds for arm*linux* and >> aarch64*linux* fail while building glibc: >> >> /tmp/3496222_18.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/bin/aarch64-none-linux-gnu-gcc >> iso-2022-cn.c

Re: [debug-early] rearrange some checks in gen_subprogram_die

2014-10-01 Thread Aldy Hernandez
On 10/01/14 07:04, Richard Biener wrote: No, checking ->gimple_df would be odd indeed. The check seems to be coming from Michas patch-set? Correct.

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Sebastian Pop
Christophe Lyon wrote: > Since this commit, I can see all my builds for arm*linux* and > aarch64*linux* fail while building glibc: > > /tmp/3496222_18.tmpdir/aci-gcc-fsf/builds/gcc-fsf-gccsrc/tools/bin/aarch64-none-linux-gnu-gcc > iso-2022-cn.c -c -std=gnu99 -fgnu89-inline -O2 -Wall -Win > line -

Re: 4.9 backports

2014-10-01 Thread Vladimir Makarov
On 2014-10-01 5:39 AM, Jakub Jelinek wrote: Hi! I'd like to create 4.9.2-rc1 soon (anyone has any pending patches for 4.9 branch?), so I've bootstrapped/regtested following 3 backports on x86_64-linux and i686-linux. Ok for 4.9? Yes, my patch is ok. Thanks for backporting it, Jakub.

Re: [PATCH, i386, Pointer Bounds Checker 30/x] Size relocation

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 4:10 PM, Ilya Enkovich wrote: >> +;; Return true if size of VALUE can be stored in a sign >> +;; extended immediate field. >> +(define_predicate "x86_64_immediate_size_operand" >> + (match_code "symbol_ref") >> +{ >> + if (!TARGET_64BIT) >> +return true; >> + >> + /*

Re: [Patch ARM-AArch64/testsuite v2 01/21] Neon intrinsics execution tests initial framework.

2014-10-01 Thread Marcus Shawcroft
On 30 September 2014 15:27, Christophe Lyon wrote: > On 10 July 2014 12:12, Marcus Shawcroft wrote: >> On 1 July 2014 11:05, Christophe Lyon wrote: >>> * documentation (README) >>> * dejanu driver (neon-intrinsics.exp) >>> * support macros (arm-neon-ref.h, compute-ref-data.h) >>> * Tests for 3 i

[PATCH, PR 63375] Make SRA check references for volatility

2014-10-01 Thread Martin Jambor
Hi, at the moment, the only check in SRA for volatility is of the DECLs themselves. As PR 63375 shows, there can be volatile references to a non-volatile declaration which must not be ignored, otherwise SRA can loose the volatility of the reference. Since the point of SRA is to produce unaddress

Re: 4.9 backports

2014-10-01 Thread Richard Biener
On Wed, Oct 1, 2014 at 11:39 AM, Jakub Jelinek wrote: > Hi! > > I'd like to create 4.9.2-rc1 soon (anyone has any pending patches > for 4.9 branch?), so I've bootstrapped/regtested following 3 > backports on x86_64-linux and i686-linux. > > Ok for 4.9? > Is the new PR63306 testcase ok for trunk to

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 4:12 PM, Jakub Jelinek wrote: > On Wed, Oct 01, 2014 at 03:09:59PM +0200, Uros Bizjak wrote: >> > 2014-10-01 Jakub Jelinek >> > >> > * config/i386/i386.c (expand_vec_perm_palignr): Handle >> > 256-bit vectors for TARGET_AVX2. >> >> Please mention PR 62128

Re: Enable TBAA on anonymous types with LTO

2014-10-01 Thread Richard Biener
On Mon, Sep 29, 2014 at 5:36 PM, Jan Hubicka wrote: >> >> Why not just make all anonymous types their own canonical type? >> (of course considering type variants) > > If C++ FE sets canonical type always to main variant, it should work. > Is it always the case? I noticed you do this for variadic t

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 03:09:59PM +0200, Uros Bizjak wrote: > > 2014-10-01 Jakub Jelinek > > > > * config/i386/i386.c (expand_vec_perm_palignr): Handle > > 256-bit vectors for TARGET_AVX2. > > Please mention PR 62128 and include the testcase from the PR. Also, > please add a ve

RE: libcilkrts: Use AC_USE_SYSTEM_EXTENSIONS (was: Cilk Library)

2014-10-01 Thread Tannenbaum, Barry M
The problem arose in our internal build which is a (relatively) simple Makefile. Now that I know what AC_USE_SYSTEM_EXTENSIONS is doing I can adjust it accordingly. Thanks. - Barry -Original Message- From: Thomas Schwinge [mailto:tho...@codesourcery.com] Sent: Wednesday, October 01,

Re: [PATCH, i386, Pointer Bounds Checker 30/x] Size relocation

2014-10-01 Thread Ilya Enkovich
2014-09-18 18:00 GMT+04:00 Ilya Enkovich : > On 17 Sep 20:51, Uros Bizjak wrote: >> On Wed, Sep 17, 2014 at 8:35 PM, Ilya Enkovich >> wrote: >> > On 16 Sep 12:22, Uros Bizjak wrote: >> >> On Tue, Sep 16, 2014 at 11:37 AM, Ilya Enkovich >> >> wrote: >> >> > 2014-09-16 13:08 GMT+04:00 Uros Bizjak

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
On Wed, Oct 1, 2014 at 6:20 AM, Teresa Johnson wrote: > Sorry, yes, will try to reproduce. > Teresa > > On Wed, Oct 1, 2014 at 12:03 AM, Christophe Lyon > wrote: >> On 30 September 2014 20:20, Teresa Johnson wrote: >>> On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law wrote: On 09/29/14 08:19, Ter

Re: [debug-early] rearrange some checks in gen_subprogram_die

2014-10-01 Thread Richard Biener
On Tue, Sep 30, 2014 at 5:06 PM, Aldy Hernandez wrote: > On 09/30/14 03:23, Richard Biener wrote: >> >> On Mon, Sep 29, 2014 at 8:54 PM, Aldy Hernandez wrote: >>> >>> I'm rearranging some code in Michael's original patch to minimize the >>> difference with mainline. >>> >>> It seems that the chec

Re: libcilkrts: Use AC_USE_SYSTEM_EXTENSIONS (was: Cilk Library)

2014-10-01 Thread Thomas Schwinge
Hi! On Mon, 29 Sep 2014 20:13:38 +0200, I wrote: > On Wed, 9 Oct 2013 18:32:11 +, "Iyer, Balaji V" > wrote: > > [libcilkrts] > > Here is a patch to have libcilkrts use AC_USE_SYSTEM_EXTENSIONS (as other > libraries are doing) instead of manually fiddling with the _GNU_SOURCE > definition.

[PATCH] Fix performance break-down in gcc.c-torture/unsorted/dump-noaddr.c

2014-10-01 Thread Bernd Edlinger
Hi Jeff, as you know, this test case takes too long to complete if the test suite is run with this command line: MALLOC_PERTURB_=237 make -k check The reason was found in libcpp/charset.c, where a reallocation is done one byte at a time. It seems to be in the macro expansion of this constr

Re: [PATCH] Redesign jump threading profile updates

2014-10-01 Thread Teresa Johnson
Sorry, yes, will try to reproduce. Teresa On Wed, Oct 1, 2014 at 12:03 AM, Christophe Lyon wrote: > On 30 September 2014 20:20, Teresa Johnson wrote: >> On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law wrote: >>> On 09/29/14 08:19, Teresa Johnson wrote: > > > Just an update - I found some

[patch] Update C++11 library status table on 4.8 branch

2014-10-01 Thread Jonathan Wakely
Committed to the 4.8 branch. commit 68b51473c3eb66b5a53e216579a8000a86c5cfd9 Author: redi Date: Wed Oct 1 12:34:28 2014 + * doc/xml/manual/status_cxx2011.xml: Corrections. * doc/html/manual/status.html: Regenerate. diff --git a/libstdc++-v3/doc/xml/manual/status_cxx2011.xml b/li

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 2:56 PM, Jakub Jelinek wrote: > And now the expand_vec_perm_palignr improvement, tested > with GCC_TEST_RUN_EXPENSIVE=1 make check-gcc \ > RUNTESTFLAGS='--target_board=unix/-mavx2 dg-torture.exp=vshuf*.c' > E.g. > typedef unsigned long long V __attribute__ ((vector_size (32

Re: [PATCH] testsuite: Error out with meaningful message in target-supports

2014-10-01 Thread Bernhard Reutner-Fischer
On 1 October 2014 14:21, Mike Stump wrote: > On Oct 1, 2014, at 2:10 AM, Bernhard Reutner-Fischer > wrote: >> It would be handy to see the reason(s) why target-supports errors out. > >> Ok for the trunk? > > Ok. Installed as r215759. Thanks!

Re: [PATCH][ARM] Disable store_minmaxsi pattern for arm_restrict_i

2014-10-01 Thread Richard Earnshaw
On 02/09/14 16:34, Kyrill Tkachov wrote: > Hi all, > > The store_minmaxsi produces a cmp + ite + 2 conditional stores and is > thus inappropriate when the ARMv8-A IT block rules are in place. > Previously we had disabled it for speed optimisations, but it should be > disabled completely when -m

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 02:25:01PM +0200, Uros Bizjak wrote: > OK. And now the expand_vec_perm_palignr improvement, tested with GCC_TEST_RUN_EXPENSIVE=1 make check-gcc \ RUNTESTFLAGS='--target_board=unix/-mavx2 dg-torture.exp=vshuf*.c' E.g. typedef unsigned long long V __attribute__ ((vector_size

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 05:31:46AM -0700, Mike Stump wrote: > > > On 10/01/2014 11:09 AM, Maxim Ostapenko wrote: > >> Hi, > >> > >> some time ago, Andrew wrote a patch that fixes PR58867 > >> (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it > >> wasn't committed to trunk. > >

[patch] Update C++11 library status table on 4.9 branch

2014-10-01 Thread Jonathan Wakely
Committed to the 4.9 branch. commit e653a57aa442cea124feaf67b65b9d80ca2e7ec6 Author: redi Date: Wed Oct 1 12:34:28 2014 + * doc/xml/manual/status_cxx2011.xml: Corrections. * doc/html/manual/status.html: Regenerate. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-

Re: [patch] std::vector::assign should not call std::vector::swap

2014-10-01 Thread Jonathan Wakely
On 25/09/14 13:14 +0100, Jonathan Wakely wrote: With C++11 allocator semantics the swap() member might also replace the allocator, which is only allowed in specific circumstances. Even though the worst that could happen is we replace the allocator with an equal one, we should avoid using swap an

Re: [patch] Fix std::try_lock behaviour

2014-10-01 Thread Jonathan Wakely
On 22/09/14 15:54 +0100, Jonathan Wakely wrote: When I fixed std::try_lock a few years ago I misread the spec, exceptions should not be caught and turned into a return value. Tested x86_64-linux, committed to trunk. ... and also the 4.9 branch. * include/std/mutex (try_lock): Do not

Re: [patch] Fix specializations of std::uses_allocator in and

2014-10-01 Thread Jonathan Wakely
On 22/09/14 17:01 +0100, Jonathan Wakely wrote: Include missing header, and add tests. Tested x86_64-linux, committed to trunk. ... and the 4.9 branch. Include in and . * include/bits/stl_queue.h: Include missing header. * include/bits/stl_stack.h: Likewise. * t

Re: [patch] libstdc++/59603 Prevent self-swapping in random_shuffle

2014-10-01 Thread Jonathan Wakely
On 12/09/14 14:34 +0100, Jonathan Wakely wrote: Swapping an object with itself is pointless, and asserts in debug mode (but we should probably remove that check from debug mode, since it can happen in reasonable code). Tested x86_64-linux, committed to trunk. I think this makes sense for the br

Re: [PATCH] PR58867 ASan and UBSan tests not run for installed testing.

2014-10-01 Thread Mike Stump
> On 10/01/2014 11:09 AM, Maxim Ostapenko wrote: >> Hi, >> >> some time ago, Andrew wrote a patch that fixes PR58867 >> (http://patchwork.ozlabs.org/patch/286866/), but for some reasons it >> wasn't committed to trunk. >> >> This is resurrected Andrew's patch, extended to support Tsan testsuite

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 2:17 PM, Jakub Jelinek wrote: > On Wed, Oct 01, 2014 at 01:45:54PM +0200, Uros Bizjak wrote: >> OK. > > Thanks. Second step is a tiny optimization, for the > simplified 122 (now 24) vshuf-v4di.c testcase: > typedef unsigned long long V __attribute__ ((vector_size (32))); >

Re: [PATCH] testsuite: Error out with meaningful message in target-supports

2014-10-01 Thread Mike Stump
On Oct 1, 2014, at 2:10 AM, Bernhard Reutner-Fischer wrote: > It would be handy to see the reason(s) why target-supports errors out. > Ok for the trunk? Ok.

Re: Fix for "FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)"

2014-10-01 Thread Mike Stump
On Oct 1, 2014, at 1:50 AM, Richard Earnshaw wrote: > Isn't that exactly what I suggested? > > "However, since > GCC is supposed to bootstrap using a portable ISO C++ compiler, there's > an argument for removing the ambiguity entirely by being explicit.” I think one can read that and not underst

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 01:45:54PM +0200, Uros Bizjak wrote: > OK. Thanks. Second step is a tiny optimization, for the simplified 122 (now 24) vshuf-v4di.c testcase: typedef unsigned long long V __attribute__ ((vector_size (32))); V a, b, c, d; int main () { int i; for (i = 0; i < 4; ++i)

Re: [Bug libstdc++/62313] Data race in debug iterators

2014-10-01 Thread Jonathan Wakely
On 30/09/14 22:18 +0200, François Dumont wrote: Hi I prefer to submit this patch to you cause I am not very comfortable with Python stuff. I simply rely on Python cast feature. It doesn't really matter but is it going to simply consider the debug iterator as a normal one or Yes. is

Re: [Patch ARM] Turn on hot cold partitioning ?

2014-10-01 Thread Christian Bruel
OK, thanks for the update. partitioning would be very important for my current work so I'd like to understand what is so special with ARM that it's the only target that can't achieve that (on the V7 at least ). Christophe, Mathew, did you have a test case (I don't have a direct access to the Linaro

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Uros Bizjak
On Wed, Oct 1, 2014 at 1:38 PM, Jakub Jelinek wrote: >> That doesn't compile, will post a new version; got interrupted when >> I found that in >> GCC_TEST_RUN_EXPENSIVE=1 make check-gcc >> RUNTESTFLAGS='--target_board=unix/-mavx2 dg-torture.exp=vshuf*.c' >> one test is miscompiled even with unpa

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Jakub Jelinek
On Wed, Oct 01, 2014 at 12:35:14PM +0200, Jakub Jelinek wrote: > On Wed, Oct 01, 2014 at 12:28:51PM +0200, Uros Bizjak wrote: > > On Wed, Oct 1, 2014 at 12:16 PM, Evgeny Stupachenko > > wrote: > > > Getting back to initial patch, is it ok? > > > > IMO, we should start with Jakub's proposed patch

Re: [PATCH 1/2, x86] Add palignr support for AVX2.

2014-10-01 Thread Evgeny Stupachenko
This is not a fix for the case { 1, 2, 3, ..., 31, 0 }. This patch is an extension of expand_vec_perm_palignr on AVX2 case. For the case { 1, 2, 3, ..., 31, 0 } we should use separate function/pattern. I like split as it is similar to already handled SSE byte rotate {1,2,3,.,15, 0}: ssse3_palig

  1   2   >