[committed] Another test for designated_init (PR c/59855)

2014-08-01 Thread Marek Polacek
Test also anonymous union in a structure. Tested on x86_64-linux, applying to trunk. 2014-08-02 Marek Polacek PR c/59855 * gcc.dg/Wdesignated-init-2.c: New test. diff --git gcc/testsuite/gcc.dg/Wdesignated-init-2.c gcc/testsuite/gcc.dg/Wdesignated-init-2.c index e69de29..d5e

Re: [PATCH] Redesign jump threading profile updates

2014-08-01 Thread Andrew Pinski
On Fri, Aug 1, 2014 at 10:10 PM, Teresa Johnson wrote: > On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson wrote: >> On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote: >>> On 03/26/14 17:44, Teresa Johnson wrote: Recently I discovered that the profile updates being performed by jump t

Re: [PATCH] Redesign jump threading profile updates

2014-08-01 Thread Teresa Johnson
On Wed, Jul 23, 2014 at 2:08 PM, Teresa Johnson wrote: > On Tue, Jul 22, 2014 at 7:29 PM, Jeff Law wrote: >> On 03/26/14 17:44, Teresa Johnson wrote: >>> >>> Recently I discovered that the profile updates being performed by jump >>> threading were incorrect in many cases, particularly in the case

Re: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-08-01 Thread David Edelsohn
On Fri, Aug 1, 2014 at 2:03 PM, rohitarul...@freescale.com wrote: > Hello Ulrich, > > Thanks. > >> > /* Use gcc hard register numbering for eh_frame. */ -#define >> >DWARF_FRAME_REGNUM(REGNO) (REGNO) >> >+#define DWARF_FRAME_REGNUM(REGNO) \ >> >+ ((REGNO) >= FIRST_SPE_HIGH_REGNO ? ((REGNO) - >>

Re: [C++ Patch] PR 15339

2014-08-01 Thread Paolo Carlini
... the below seems better to me: 1- FUNCTION_DECLs and TEMPLATE_DECLs are handled in their own places. 2- When I tweaked default3.C I didn't notice at first the real reason for the existing xfail: in such case we didn't give the check_default_args diagnostics. Restored in the below. 3- By handl

libgo patch committed: Ignore small argv[0] for backtrace

2014-08-01 Thread Ian Lance Taylor
Reportedly in some cases Docker starts processes with argv[0] pointing to an empty file. That would cause libgo to pass that empty file to libbacktrace, which would then fail to do any backtraces. Everything should work fine if libbacktrace falls back to /proc/self/exe. This patch to libgo works

Re: C++ PATCH for c++/60417 (explicit ctor vs aggregate init)

2014-08-01 Thread Jason Merrill
On 03/04/2014 05:14 PM, Jason Merrill wrote: In C++11, copy-list-initialization by explicit constructor is an error, even for the default constructor. But this combined with the change of aggregate initialization to use {} for any missing initializers means that well-formed C++03 code becomes il

Re: FWD: Re: OpenACC subarray specifications in the GCC Fortran front end

2014-08-01 Thread Cesar Philippidis
On 08/01/2014 12:48 AM, Jakub Jelinek wrote: > On Wed, Jul 23, 2014 at 05:42:32PM -0700, Cesar Philippidis wrote: Jakub, before your Fortran OpenMP 4 target changes, Ilmir had written the test case gcc/testsuite/gfortran.dg/gomp/map-1.f90 (based on his interpretation and implementati

[C++ Patch] PR 15339

2014-08-01 Thread Paolo Carlini
Hi, thus this is what I have tested for c++/15339. By the way, I figured out why yesterday I got stupidly confused about DECL_TEMPLATE_INFO: at this point, for a member function template, newdecl does *not* have DECL_TEMPLATE_INFO set, only olddecl does. Consistently, I adjusted all the code

Re: [PATCH, libfortran] Backport xmallocarray to 4.8/4.9 (CVE-2014-5044)

2014-08-01 Thread Jakub Jelinek
On Sat, Aug 02, 2014 at 12:09:24AM +0300, Janne Blomqvist wrote: > > --- libgfortran/runtime/memory.c.jj 2014-06-18 08:50:33.0 +0200 > > +++ libgfortran/runtime/memory.c2014-08-01 14:41:08.385856116 +0200 > > @@ -56,7 +56,9 @@ xmallocarray (size_t nmemb, size_t size) > > > >

Re: [PATCH, libfortran] Backport xmallocarray to 4.8/4.9 (CVE-2014-5044)

2014-08-01 Thread Janne Blomqvist
On Fri, Aug 1, 2014 at 3:49 PM, Jakub Jelinek wrote: > On Thu, Jul 31, 2014 at 11:32:12PM +0300, Janne Blomqvist wrote: >> a while ago I committed a patch to trunk adding a function >> xmallocarray to libgfortran, which is a malloc wrapper like xmalloc >> but has two arguments and does an overflow

Re: [Patch, Fortran] -fcoarray=lib - support CRITICAL, prepare for locking support

2014-08-01 Thread Alessandro Fanfarillo
Hello, I was implementing lock/unlock on the library side when I found a possible problem in the patch: if (is_lock_type == GFC_CAF_CRITICAL) +reg_type = sym->attr.artificial ? GFC_CAF_CRITICAL : GFC_CAF_LOCK_STATIC; + else +reg_type = GFC_CAF_COARRAY_STATIC; the if statement cannot be

Re: [C++ Patch] DR 217 follow up (and more)

2014-08-01 Thread Paolo Carlini
Hi, On 08/01/2014 08:30 PM, Jason Merrill wrote: On 07/31/2014 01:36 PM, Paolo Carlini wrote: The problem is that when grokfndecl calls duplicate_decls in such member cases it looks through TEMPLATE_DECLs and then telling apart the two cases above is tough, both are FUNCTION_DECLs Ideas abou

Re: [PATCH] libstdc++: add _GLIBCXX_ macro prefix in atexit_thread.cc

2014-08-01 Thread Jonathan Wakely
On 30/07/14 23:36 +0800, Zifei Tong wrote: On Wed, Jul 30, 2014 at 11:25 PM, Jonathan Wakely wrote: On 30/07/14 22:42 +0800, Zifei Tong wrote: Hi, I found an issue that the __cxa_thread_atexit_impl() function never called by __cxa_thread_atexit() even with newest glibc which have __cxa_threa

Re: [PATCH][Ping v5] Add patch for debugging compiler ICEs

2014-08-01 Thread Jeff Law
On 08/01/14 02:00, Jakub Jelinek wrote: On Thu, Jul 24, 2014 at 04:39:28PM +0400, Maxim Ostapenko wrote: Ping. Don't want to review a patch I wrote partially, so just a few comments: 1) IMHO it should be configure time selectable (not sure about the default, but for non-release branches IMHO i

Re: [Ada] Remove xgnatugn in doc generation

2014-08-01 Thread Arnaud Charlet
> > 2014-08-01 Arnaud Charlet > > > > * ug_words, xgnatugn.adb, gcc-interface/Make-lang.in: Remove > > xgnatugn.adb and ug_words. > > Could you check if this needs any changes to the support in > update_web_docs_svn for generating the online manuals, which would > previously have run

Re: [C++ Patch] DR 217 follow up (and more)

2014-08-01 Thread Jason Merrill
On 07/31/2014 01:36 PM, Paolo Carlini wrote: The problem is that when grokfndecl calls duplicate_decls in such member cases it looks through TEMPLATE_DECLs and then telling apart the two cases above is tough, both are FUNCTION_DECLs Ideas about the best way to handle that? Could you just cond

Re: [Patch] PR 61692 - Fix for inline asm ICE

2014-08-01 Thread Jeff Law
On 08/01/14 02:07, David Wohlferd wrote: I'd love to. Unfortunately, my platform doesn't support valgrind. Ah. Also, please include the testcase you had nlabels part. I have created the testcase for the 31 labels problem. However, not so much for the nclobbers part. And if I'm going to

Re: [PATCH][testsuite] Don't run cproj-fails-with-broken-glibc.c for broken glibc

2014-08-01 Thread Mike Stump
On Aug 1, 2014, at 3:35 AM, Rainer Orth wrote: > I'm not at all happy with this patch > That test, even if we go the glibc version route, needs to be XFAILed > instead of requiring the working version. Apart from that, new > effective-target keywords need documenting in doc/sourcebuild.texi. So

Re: [PATCH, i386] Handle extended family cpuid info for AMD

2014-08-01 Thread Uros Bizjak
On Fri, Aug 1, 2014 at 5:00 PM, Jakub Jelinek wrote: >> --- a/gcc/config/i386/driver-i386.c >> +++ b/gcc/config/i386/driver-i386.c >> @@ -432,7 +432,8 @@ const char *host_detect_local_cpu (int argc, const char >> **argv) >> >>model = (eax >> 4) & 0x0f; >>family = (eax >> 8) & 0x0f; >> -

RE: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-08-01 Thread rohitarul...@freescale.com
Jakub, > On Fri, Aug 01, 2014 at 06:03:56PM +, rohitarul...@freescale.com wrote: > > PR target/60102 > > --- libgcc/config/rs6000/linux-unwind.h (revision 213110) > +++ libgcc/config/rs6000/linux-unwind.h (working copy) > @@ -274,8 +274,8 @@ ppc_fallback_frame_state (struct _Unwind > #if

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Jeff Law
On 08/01/14 05:35, Martin Liška wrote: 2014-07-31 Martin Liska * cgraph.h (cgraph_node_set, varpool_node_set): Removed structs and all related functions that manipulated these data structures. (cgraph_new_nodes): vec replaces cgraph_node_set. * cgraphunit.c (cgra

Re: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-08-01 Thread Jakub Jelinek
On Fri, Aug 01, 2014 at 06:03:56PM +, rohitarul...@freescale.com wrote: > PR target/60102 --- libgcc/config/rs6000/linux-unwind.h (revision 213110) +++ libgcc/config/rs6000/linux-unwind.h (working

RE: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-08-01 Thread rohitarul...@freescale.com
Hello Ulrich, Thanks. > > /* Use gcc hard register numbering for eh_frame. */ -#define > >DWARF_FRAME_REGNUM(REGNO) (REGNO) > >+#define DWARF_FRAME_REGNUM(REGNO) \ > >+ ((REGNO) >= FIRST_SPE_HIGH_REGNO ? ((REGNO) - > FIRST_SPE_HIGH_REGNO + > >+1200) : (REGNO)) > > Any reason for not using SPE_

a patch was backported to gcc 4.9 branch

2014-08-01 Thread Vladimir Makarov
The following patch was backported from mainline to gcc-4.9 branch: https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00845.html Committed as rev. 213497. 2014-08-01 Vladimir Makarov * lra-constraints.c (remove_inheritance_pseudos): Process destination pseudo too.

Re: [PATCH] Move memory builtin foldings to GIMPLE

2014-08-01 Thread Jeff Law
On 08/01/14 06:43, Richard Biener wrote: The following patch removes folding of bzero, memset, bcopy, memcpy, mempcpy and memmove from builtins.c and re-implements them in gimple-fold.c. This means those foldings are no longer accessible from GENERIC folding. Bootstrapped on x86_64-unknown-lin

Re: [Ada] Legality checks involving aspect Import

2014-08-01 Thread Mike Stump
On Aug 1, 2014, at 3:16 AM, Arnaud Charlet wrote: > This patch adds some missing legality checks No, GNU English doesn’t have us using legal/illegal unless the motivation is a law of some specific jurisdiction. > q.ads:2:28: imported entities cannot have explicit initialization (RM 8.1 > (24))

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-01 Thread Kugan
>>> if (rhs_uns) >>>return wi::ge_p (min, 0); // if min >= 0 then range contains positive >>> values >>> else >>>return wi::le_p (max, wi::max_value (TYPE_PRECISION (TREE_TYPE >>> (ssa)), SIGNED); // if max <= signed-max-of-type then range doesn't >>> need sign-extension >> >> I think

Re: [PATCH] Move memory builtin foldings to GIMPLE

2014-08-01 Thread Joseph S. Myers
On Fri, 1 Aug 2014, Richard Biener wrote: > Does this look sensible? In particular, does any Frontend maintainer > object to no longer getting these simplifications? Note they > will still apply during gimplification and given they now work > on GENERIC we can simplify them quite a bit (but as f

Re: [PATCH][Ping v5] Add patch for debugging compiler ICEs

2014-08-01 Thread Jakub Jelinek
On Fri, Aug 01, 2014 at 12:13:18PM +0400, Yury Gribov wrote: > On 08/01/2014 12:00 PM, Jakub Jelinek wrote: > >Don't want to review a patch I wrote partially, so just a few comments: > >1) IMHO it should be configure time selectable (not sure about the default, > >but for non-release branches IMHO

Re: [PATCH AArch64] Removed unused get_lane and dup_lane builtins.

2014-08-01 Thread Marcus Shawcroft
On 1 August 2014 16:09, Alan Lawrence wrote: > None of the variants of __builtin_aarch64_get_lane or > __builtin_aarch64_dup_lane are used in arm_neon.h (vdup_lane uses vget_lane > and vdup_n, vget_lane uses be_checked_get_lane to do an endianness swap, > vdup_n uses gcc vector extension code). So

Re: [PATCH][Ping v5] Add patch for debugging compiler ICEs

2014-08-01 Thread Jakub Jelinek
On Fri, Aug 01, 2014 at 08:43:27AM -0700, Andi Kleen wrote: > Jakub Jelinek writes: > > Don't want to review a patch I wrote partially, so just a few comments: > > 1) IMHO it should be configure time selectable (not sure about the default, > > but for non-release branches IMHO it should default to

Re: [Ada] Generate Machine, Model and Rounding FP attributes in line

2014-08-01 Thread Joseph S. Myers
On Fri, 1 Aug 2014, Arnaud Charlet wrote: > This change makes it so that the Machine, Model and Rounding FP attributes > are generated in line by the compiler (in conjunction with a conversion to > an integer type for the third) and optimized on architectures that do not > make use of internal ext

Re: [PATCH][Ping v5] Add patch for debugging compiler ICEs

2014-08-01 Thread Andi Kleen
Jakub Jelinek writes: > Don't want to review a patch I wrote partially, so just a few comments: > 1) IMHO it should be configure time selectable (not sure about the default, > but for non-release branches IMHO it should default to off, for release > branches I don't know). The point is that while

Re: [Ada] Remove xgnatugn in doc generation

2014-08-01 Thread Joseph S. Myers
On Fri, 1 Aug 2014, Arnaud Charlet wrote: > [ > Note: the previous related change was rejected due to a too large > patch file attached. The mail was: > > This is another step in removing VMS code, and also a step in converting the > documentation to the rest/sphinx format. > > The xgnatugn prep

Re: [PATCH] PowerPC: Implement TARGET_ATOMIC_ASSIGN_EXPAND_FENV

2014-08-01 Thread Joseph S. Myers
On Thu, 31 Jul 2014, David Edelsohn wrote: > Thanks for implementing the FENV support. The patch generally looks > good to me. > > My one concern is a detail in the implementation of "update". I do not > have enough experience with GENERIC to verify the details and it seems > like it is missing

[PATCH AArch64] Removed unused get_lane and dup_lane builtins.

2014-08-01 Thread Alan Lawrence
None of the variants of __builtin_aarch64_get_lane or __builtin_aarch64_dup_lane are used in arm_neon.h (vdup_lane uses vget_lane and vdup_n, vget_lane uses be_checked_get_lane to do an endianness swap, vdup_n uses gcc vector extension code). So remove them. Regression tested on aarch64-none-e

Re: [PATCH, i386] Handle extended family cpuid info for AMD

2014-08-01 Thread Jakub Jelinek
On Fri, Aug 01, 2014 at 02:52:28PM +, Gopalasubramanian, Ganesh wrote: > --- a/gcc/config/i386/driver-i386.c > +++ b/gcc/config/i386/driver-i386.c > @@ -432,7 +432,8 @@ const char *host_detect_local_cpu (int argc, const char > **argv) > >model = (eax >> 4) & 0x0f; >family = (eax >> 8

Re: [PATCH] Add target macro to override DWARF2 frame register size

2014-08-01 Thread Steven Bosscher
On Fri, Aug 1, 2014 at 3:31 PM, Matthew Fortune wrote: > This patch adds a target macro Please don't add target macros. Add a hook if you must, but we're supposed to remove target macros, not add new ones :-) Ciao! Steven

RE: [PATCH, i386] Handle extended family cpuid info for AMD

2014-08-01 Thread Gopalasubramanian, Ganesh
> In this case, having only check for family ID should be enough. If >BTVER1 and BTVER2 can be uniquely determined by their family IDs , >IMO, this would be the most future-proof approach. Signature checks will >override family id checks which will override cpuid checks. Thank you Uros! I have

[COMMITTED] Add myself to MAINTAINERS file (Write After Approval)

2014-08-01 Thread Jiong Wang
Hi, This patch adds myself to the MAINTAINERS file (Write After Approval). Commmitted as 213481 Thanks. -- Jiong Index: MAINTAINERS === --- MAINTAINERS (revision 213472) +++ MAINTAINERS (working copy) @@ -564,6 +564,7 @@ Tom de

[Ada] Fix breach of privacy with type derived from private discriminated

2014-08-01 Thread Arnaud Charlet
This fixes a breach of privacy for types derived from private discriminated record types whose full view has no discriminants, as well as factors out the code doing the full derivation in the various cases into a single child procedure of Build_Derived_Private_Type. As a consequence, this removes

Re: [RFC: Patch, PR 60102] [4.9/4.10 Regression] powerpc fp-bit ices@dwf_regno

2014-08-01 Thread Ulrich Weigand
Rohit, > #define DWARF_REG_TO_UNWIND_COLUMN(r) \ >- ((r) > 1200 ? ((r) - 1200 + (DWARF_FRAME_REGISTERS - 32)) : (r)) >+ ((r) >= 1200 ? ((r) - 1200 + (DWARF_FRAME_REGISTERS - 32)) : (r)) OK, makes sense. > /* Use gcc hard register numbering for eh_frame. */ >-#define DWARF_FRAME_REGNUM(REGNO)

[Ada] Crash on generic instance with class-wide actual

2014-08-01 Thread Arnaud Charlet
This patch reimplements part of the support for AI05-0071 which deals with generic/instance scenarios involving a formal type with unknown discriminants, a generic primitive operation of the formal type declared with a box and an actual class-wide type. -- Source -- --

[Ada] Minor internal cleanup

2014-08-01 Thread Arnaud Charlet
Underlying_Type now recursively goes down the chain of private derivations, including the Underlying_Full_View if any, so we call it instead of making the descent manually in Build_Initialization_Call. No functional changes. Tested on x86_64-pc-linux-gnu, committed on trunk 2014-08-01 Eric Botc

[Ada] Access types that designate limited views of types with tasks.

2014-08-01 Thread Arnaud Charlet
This patch fixes the handling of access types whose designated types are limited views of untagged types with tasks. executing the following: gnatmake -q main.adb main must yield: Task started Task started --- with Package_Common; use Package_Common; with Package_A; use Package_A;

[Ada] Crash on entry call with preconditions and access parameters

2014-08-01 Thread Arnaud Charlet
When an entry has preconditions, the entry call is wrapped in a procedure call that incorporates the precondition checks. To prevent a double expansion, with possible duplication of extra formals, that procedure call must only be pre- nalyzed and resolved. Expansion takes place upon return to the c

[PATCH] Add target macro to override DWARF2 frame register size

2014-08-01 Thread Matthew Fortune
This patch adds a target macro to allow a backend to override the size of a dwarf frame register. This is already supported to some extent by allowing the HARD_REGNO_CALL_PART_CLOBBERED to reduce the size of a specific register to only that which is saved. However, for the new MIPS O32 FP64 ABI e

[Ada] Parameterless calls to protected operations on selected components.

2014-08-01 Thread Arnaud Charlet
A multi-level selected component can designate a call to a parameterless protected operation whose target object is itself given by a selected component. When the node is rewritten as a function call, it is necessary to preserve the tree structure of the name, so that overload information and subse

[Ada] Improved handling of info messages

2014-08-01 Thread Arnaud Charlet
The count of info messages is now separated from the count of warnings and -gnatwe never turns info messages into errors. The following compiles as shown, and generates object code since no error is found when compilation options -gnatwe -gnatld7 -gnatj55 are used. Compiling: infoerr.adb 1.

[Ada] Give missing entity messages in -gnatc mode

2014-08-01 Thread Arnaud Charlet
This patch forces expansion on (but not actual code generation) for configurable run time mode or no run time mode in -gnatc mode. This means that we get error messages about unsupported features even in -gnatc mode, which was not true before. The following is compiled in -gnatc mode with a gnat.ad

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Marcus Shawcroft
On 1 August 2014 13:49, Jiong Wang wrote: > > > Hmm... thanks for pointing this out. > > > updated the patch to match three keyword. "mem", "plus" and > "virtual-stack-vars" > > ok for trunk? OK /Marcus

Re: [PATCH][AArch64] Add constrain to address offset in storewb_pair/loadwb_pair insns

2014-08-01 Thread Marcus Shawcroft
On 29 July 2014 16:31, Jiong Wang wrote: > gcc/ > * config/aarch64/aarch64.c (offset_7bit_signed_scaled_p): Rename to > aarch64_offset_7bit_signed_scaled_p, remove static and use it . > * config/aarch64/aarch64-protos.h (aarch64_offset_7bit_signed_scaled_p): > Declaration. > * config/aa

Re: [PATCH][AArch64]Fix offset glitch in load reg pair pattern

2014-08-01 Thread Marcus Shawcroft
On 29 July 2014 16:25, Jiong Wang wrote: > gcc/ > * config/aarch64/aarch64.md (loadwb_pair_): Fix offset. > (loadwb_pair_): Likewise. > * config/aarch64/aarch64.c (aarch64_gen_loadwb_pair): Likewise. OK /Marcus

Re: [Ada] Don't unconditionally define _LARGEFILE_SOURCE

2014-08-01 Thread Arnaud Charlet
> 2014-08-01 Pascal Obry > > * cstreams.c: Only enable large file support on know supported > platforms. Add missing defines/includes. > > broke Ada bootstrap on Solaris: > > /vol/gcc/src/hg/trunk/local/gcc/ada/cstreams.c:34:0: error: > "_LARGEFILE_SOURCE" redefined [-Werror]

[Ada] Don't unconditionally define _LARGEFILE_SOURCE

2014-08-01 Thread Rainer Orth
This patch 2014-08-01 Pascal Obry * cstreams.c: Only enable large file support on know supported platforms. Add missing defines/includes. broke Ada bootstrap on Solaris: /vol/gcc/src/hg/trunk/local/gcc/ada/cstreams.c:34:0: error: "_LARGEFILE_SOURCE" redefined [-Werror] #def

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Jiong Wang
On 01/08/14 13:20, Marcus Shawcroft wrote: On 1 August 2014 09:31, Jiong Wang wrote: gcc/ * config/aarch64/aarch64.c (aarch64_classify_address): Accept all offset for frame access when strict_p is false. This part is OK. gcc/testsuite * gcc.target/aarch64/legitimize_stack_var_bef

Re: [PATCH, libfortran] Backport xmallocarray to 4.8/4.9 (CVE-2014-5044)

2014-08-01 Thread Jakub Jelinek
On Thu, Jul 31, 2014 at 11:32:12PM +0300, Janne Blomqvist wrote: > a while ago I committed a patch to trunk adding a function > xmallocarray to libgfortran, which is a malloc wrapper like xmalloc > but has two arguments and does an overflow check before multiplying > them together. That seems to b

[PATCH] Move memory builtin foldings to GIMPLE

2014-08-01 Thread Richard Biener
The following patch removes folding of bzero, memset, bcopy, memcpy, mempcpy and memmove from builtins.c and re-implements them in gimple-fold.c. This means those foldings are no longer accessible from GENERIC folding. Bootstrapped on x86_64-unknown-linux-gnu - testing seems to reveal some tests

[PATCH] Fix PR61762 testcase

2014-08-01 Thread Richard Biener
After trying to fix the missed optimization on strict-align targets in a fancy way for some time I gave up and this fixes the testcase instead. Tested on a sparc cross and on x86_64-unknown-linux-gnu, applied. Richard. 2014-08-01 Richard Biener PR middle-end/61762 * gcc.dg/p

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Marcus Shawcroft
On 1 August 2014 09:31, Jiong Wang wrote: > gcc/ > * config/aarch64/aarch64.c (aarch64_classify_address): Accept all offset > for frame access > when strict_p is false. This part is OK. > gcc/testsuite > * gcc.target/aarch64/legitimize_stack_var_before_reload_1.c: New testcase. This tes

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Jiong Wang
Hi Venkataramanan, thanks for review. On 01/08/14 11:59, Venkataramanan Kumar wrote: Hi Jiong, (Snip) + && (op0 == virtual_stack_vars_rtx + || op0 == frame_pointer_rtx + || op0 == arg_pointer_rtx) (Snip) The above check is means that these are the ways to access the frame. is it po

[C++ PATCH] Improve location info [1/many]

2014-08-01 Thread Marek Polacek
This is the first patch in a series that strives to improve C++ location info. The following is more like a base for another improvements, thus it contains only one small test. It adds a location_t parameter and a vector of location_t of arguments to finish_call_expr - so functions such as build_

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Martin Liška
Hi, thank you for your comment. Fixed. Martin On 08/01/2014 01:46 PM, Jakub Jelinek wrote: > Hi! > > Just a random comment: > > On Fri, Aug 01, 2014 at 01:35:47PM +0200, Martin Liška wrote: >> @@ -357,8 +356,8 @@ cgraph_process_new_functions (void) >>break; >> } >> } >> - fr

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Jakub Jelinek
Hi! Just a random comment: On Fri, Aug 01, 2014 at 01:35:47PM +0200, Martin Liška wrote: > @@ -357,8 +356,8 @@ cgraph_process_new_functions (void) > break; > } > } > - free_cgraph_node_set (cgraph_new_nodes); > - cgraph_new_nodes = NULL; > + > +cgraph_new_nodes.release ()

Re: [RFC, PATCH 3/n] IPA C++ refactoring

2014-08-01 Thread Martin Liška
On 08/01/2014 02:34 AM, Trevor Saunders wrote: >> +++ b/gcc/cgraph.h >> @@ -27,6 +27,7 @@ along with GCC; see the file COPYING3. If not see >> #include "basic-block.h" >> #include "function.h" >> #include "ipa-ref.h" >> +#include "indexed-set.h" > you don't actually use that here so why are yo

Re: [PATCH 2/2] Enable elimination of zext/sext

2014-08-01 Thread Richard Biener
On Fri, Aug 1, 2014 at 6:51 AM, Kugan wrote: >> + lhs_type = lang_hooks.types.type_for_mode (lhs_mode, lhs_uns); >> ... >> + && ((!lhs_uns && !wi::neg_p (min, TYPE_SIGN (lhs_type))) >> ... >> + type_min = wide_int::from (TYPE_MIN_VALUE (lhs_type), prec, >> +TYPE_

Re: [PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Venkataramanan Kumar
Hi Jiong, (Snip) + && (op0 == virtual_stack_vars_rtx + || op0 == frame_pointer_rtx + || op0 == arg_pointer_rtx) (Snip) The above check is means that these are the ways to access the frame. is it possible to have stack_pointer_rtx has op0? On 1 August 2014 14:01, Jiong Wang wrote: >

Re: [PATCH] convert many pointer_map to hash_map

2014-08-01 Thread Richard Biener
On Fri, Aug 1, 2014 at 12:34 PM, wrote: > From: Trevor Saunders > > Hi, > > This patch replaces a bunch of usage of pointer_map with hash_map. It also > adds an overload to hash_map::traverse that allows modifying the value, and a > remove method. > > bootstrapped + regtested on x86_64-unknown-

Re: [RFC][Vectorizer, AArch64] Fix PR/61114 by redefining REDUC_xxx_EXPR tree codes to return scalars

2014-08-01 Thread Richard Biener
On Fri, Aug 1, 2014 at 12:19 PM, Alan Lawrence wrote: > This fixes PR/61114 by redefining the REDUC_{MIN,MAX,PLUS}_EXPR tree codes. > > These are presently documented as producing a vector with the result in > element 0, and this is inconsistent with their use in tree-vect-loop.c > (which on bigen

[PATCH] convert many pointer_map to hash_map

2014-08-01 Thread tsaunders
From: Trevor Saunders Hi, This patch replaces a bunch of usage of pointer_map with hash_map. It also adds an overload to hash_map::traverse that allows modifying the value, and a remove method. bootstrapped + regtested on x86_64-unknown-linux-gnu, ok? Trev c-family/ * cilk.c: Use ha

Re: [PATCH][testsuite] Don't run cproj-fails-with-broken-glibc.c for broken glibc

2014-08-01 Thread Rainer Orth
Hi Tom, > The test-case cproj-fails-with-broken-glibc.c does not work with broken > glibcs, as the header comment mentions: > ... >Check the runtime behavior of the C library's cproj() function and >whether it follows the standard. Versions of GLIBC through 2.11.1 >had an incorrect im

[Ada] Conformance checking in instantiations

2014-08-01 Thread Arnaud Charlet
Within an instance, a subprogram declaration and the corresponding body may be fully conformant, but one may use in its profile a formal type while the other uses a declared subtype of that formal. The routine Same_Generic_Actual is used to recognize this case and prevent a spurious conformance err

[Ada] Spurious warning on generated with_clause for renamed unit

2014-08-01 Thread Arnaud Charlet
This patch suppresses spurious warnings that may be generated when the prefix of a with_clause for a child unit denotes the renaming of a parent unit. Such renamings generate internal with_clauses that are not marked Implicit_With because they must be properly installed as part of the context, but

Re: Patch for constexpr variable templates

2014-08-01 Thread Braden Obrzut
On 07/31/2014 08:53 AM, Jason Merrill wrote: In the original mail you mentioned doing it in cp_parser_template_id; I agree that we probably don't want to do it there because of the complications you are seeing. I was thinking about doing it when we normally resolve an id-expression that refers

[RFC][Vectorizer, AArch64] Fix PR/61114 by redefining REDUC_xxx_EXPR tree codes to return scalars

2014-08-01 Thread Alan Lawrence
This fixes PR/61114 by redefining the REDUC_{MIN,MAX,PLUS}_EXPR tree codes. These are presently documented as producing a vector with the result in element 0, and this is inconsistent with their use in tree-vect-loop.c (which on bigendian targets pulls the bits out of the other end of the vecto

[Ada] Add support for non-capturing parenthesis in GNAT.Regpat

2014-08-01 Thread Arnaud Charlet
It is now possible to use the (?:...) syntax to group elements in a regular expression without making their matched substring available in the Match_Array. The following test must output: Matched (0)= 1.. 6 Matched (1)= 5.. 5 Matched (2)= 0.. 0 with GNAT.Regpat; use GNAT.Regpat;

[Ada] Legality checks involving aspect Import

2014-08-01 Thread Arnaud Charlet
This patch adds some missing legality checks on uses of aspect Import. These checks were performed properly in the presence of pragmas, but were incomplete when using aspects. Compiling q.ads must yield: q.ads:2:28: imported entities cannot have explicit initialization (RM 8.1 (24)) q.ads:6:24: n

gcov tidy up

2014-08-01 Thread Nathan Sidwell
In developing the next patch I found some places to tidy up first. Committed. nathan 2014-08-01 Nathan Sidwell * Makefile.in (LIBGCOV_MERGE, LIBGCOV_PROFILER, LIBGCOV_INTERFACE): Reformat. * libgcov-driver.c (gcov_exit, __gcov_init): Disable when IN_GCOV_TOOL.

[Ada] Improve messages for lack of inlining in GNATprove mode

2014-08-01 Thread Arnaud Charlet
Expression functions with a separate declarations should never be inlined in GNATprove mode, hence no message should be issued for these. Correct a problem in call resolution which lead to such a message. Also change the message for lack of inlining in GNATprove mode, so that an info message is iss

[C++ Patch, committed] Use DECL_TYPE_TEMPLATE_P

2014-08-01 Thread Paolo Carlini
Hi, committed as obvious the below. Thanks, Paolo. /// 2014-08-01 Paolo Carlini * pt.c (lookup_template_class_1): Use DECL_TYPE_TEMPLATE_P. Index: pt.c === --- pt.c(revision 213428) +++ pt.c

Re: [PATCH] Extended if-conversion for loops marked with pragma omp simd.

2014-08-01 Thread Richard Biener
On Wed, Jun 25, 2014 at 4:06 PM, Yuri Rumyantsev wrote: > Hi All, > > We implemented additional support for pragma omp simd in part of > extended if-conversion loops with such pragma. These extensions > include: > > 1. All extensions are performed only if considered loop or its outer >loop was

[Ada] Generate Machine, Model and Rounding FP attributes in line

2014-08-01 Thread Arnaud Charlet
This change makes it so that the Machine, Model and Rounding FP attributes are generated in line by the compiler (in conjunction with a conversion to an integer type for the third) and optimized on architectures that do not make use of internal extended precision in the FPU. The following function

[Ada] Remove xgnatugn in doc generation

2014-08-01 Thread Arnaud Charlet
[ Note: the previous related change was rejected due to a too large patch file attached. The mail was: This is another step in removing VMS code, and also a step in converting the documentation to the rest/sphinx format. The xgnatugn preprocessing step will also soon be removed. 2014-08-01 Ben

Re: [AArch64] Implement movmem for the benefit of inline memcpy

2014-08-01 Thread pinskia
> On Jun 6, 2014, at 1:50 AM, James Greenhalgh wrote: > > > Hi, > > The move_by_pieces infrastructure performs a copy by repeatedly trying > the largest safe copy it can make. So for a 15-byte copy we might see: > > offset amount bytes copied > 08 0-7 > 84 8-11

Re: [PATCH] Move Asan instrumentation to sanopt pass

2014-08-01 Thread Richard Biener
On Fri, Aug 1, 2014 at 9:17 AM, Jakub Jelinek wrote: > On Mon, Jul 28, 2014 at 06:14:08PM +0400, Yury Gribov wrote: >> On 07/24/2014 11:48 AM, Jakub Jelinek wrote: >> > So, either support for just EAF*, or perhaps support for DECL_ATTRIBUTES >> > for internal-fns, say by having some tree array whe

Re: [AArch64] Implement movmem for the benefit of inline memcpy

2014-08-01 Thread Richard Biener
On Fri, Aug 1, 2014 at 8:38 AM, Andrew Pinski wrote: > On Fri, Jun 6, 2014 at 1:50 AM, James Greenhalgh > wrote: >> >> Hi, >> >> The move_by_pieces infrastructure performs a copy by repeatedly trying >> the largest safe copy it can make. So for a 15-byte copy we might see: >> >> offset amount

RE: [PATCH, Cilk+] Fix for PR61962

2014-08-01 Thread Zamyatin, Igor
> > diff --git a/gcc/c-family/array-notation-common.c > > b/gcc/c-family/array-notation-common.c > > index c010039..5db14c6 100644 > > --- a/gcc/c-family/array-notation-common.c > > +++ b/gcc/c-family/array-notation-common.c > > @@ -221,7 +221,9 @@ find_rank (location_t loc, tree orig_expr, tree ex

Re: [PATCH, Cilk+] Fix for PR61962

2014-08-01 Thread Richard Biener
On Thu, Jul 31, 2014 at 9:51 PM, Zamyatin, Igor wrote: > Hi! > > This patch fixes endless compilation for the case of array notation for an > array which is a structure member > > Ok for trunk/4.9 once testing finished? > > Thanks, > Igor > > Changelog: > > gcc/c-family: > > 2014-07-31 Igor Zamy

Re: [PATCH][1-3] New configure options that make the compiler use -fPIE and -pie as default option

2014-08-01 Thread Rainer Orth
Hi Magnus, a couple of comments, mostly nits. > 2014-07-31 Magnus Granberg > > /gcc > * config/gnu-user.h: Define PIE_DRIVER_SELF_SPECS for PIE > as default and GNU_DRIVER_SELF_SPECS. > * config/i386/gnu-user-common.h: Define DRIVER_SELF_SPECS > * configure.ac: A

[PATCH][AArch64] Improve TARGET_LEGITIMIZE_ADDRESS_P hook

2014-08-01 Thread Jiong Wang
currently, aarch64 LEGITIMIZE_ADDRESS_P hook will reject all "reg + offset" address given "offset" is beyond supported range. while this may be too strict. we should honor the "strict_p" parameter in the hook. before reload, we accept all offset if it's a frame access, because the offset may c

[Ada] More VMS clean ups

2014-08-01 Thread Arnaud Charlet
In various parts of the front-end. Tested on x86_64-pc-linux-gnu, committed on trunk 2014-08-01 Robert Dewar * inline.adb, inline.ads, fe.h, einfo.adb, einfo.ads, sem_util.adb, sem_util.ads, exp_ch4.adb, exp_ch11.adb, exp_ch6.adb, cstand.adb, sem_mech.adb, sem_ch6.adb,

Re: [PATCH][Ping v5] Add patch for debugging compiler ICEs

2014-08-01 Thread Yury Gribov
On 08/01/2014 12:00 PM, Jakub Jelinek wrote: Don't want to review a patch I wrote partially, so just a few comments: 1) IMHO it should be configure time selectable (not sure about the default, but for non-release branches IMHO it should default to off, for release branches I don't know). The poi

[Ada] Remove VMS handling in most tools

2014-08-01 Thread Arnaud Charlet
Continuation of VMS removal in the GNAT front-end. Tested on x86_64-pc-linux-gnu, committed on trunk 2014-08-01 Arnaud Charlet * binde.adb, bindgen.adb, butil.adb, clean.adb, gnatbind.adb, gnatchop.adb, gnatcmd.adb, gnatls.adb, gnatname.adb, krunch.adb, make.adb, makeu

Re: [Patch] PR 61692 - Fix for inline asm ICE

2014-08-01 Thread David Wohlferd
On 7/30/2014 9:58 PM, Jeff Law wrote: On 07/28/14 16:39, David Wohlferd wrote: On 7/28/2014 12:42 PM, Jeff Law wrote: On 07/27/14 01:26, David Wohlferd wrote: I'm not sure which maintainer to cc for inline asm stuff? I have a release on file with the FSF, but don't have SVN write access.

Re: [PATCH][Ping v5] Add patch for debugging compiler ICEs

2014-08-01 Thread Jakub Jelinek
On Thu, Jul 24, 2014 at 04:39:28PM +0400, Maxim Ostapenko wrote: > Ping. Don't want to review a patch I wrote partially, so just a few comments: 1) IMHO it should be configure time selectable (not sure about the default, but for non-release branches IMHO it should default to off, for release branc

Re: [PATCH, i386] Handle extended family cpuid info for AMD

2014-08-01 Thread Uros Bizjak
On Fri, Aug 1, 2014 at 8:18 AM, Gopalasubramanian, Ganesh wrote: >> I would like to have a check for a family at the beginning, something like: > >> if (name == signature_NSC_ebx) >>processor = PROCESSOR_GEODE; >> else if (family == 22) >>{ >> if (has_movbe) > > I get your

Re: FWD: Re: OpenACC subarray specifications in the GCC Fortran front end

2014-08-01 Thread Jakub Jelinek
On Wed, Jul 23, 2014 at 05:42:32PM -0700, Cesar Philippidis wrote: > >> Jakub, before your Fortran OpenMP 4 target changes, Ilmir had written the > >> test case gcc/testsuite/gfortran.dg/gomp/map-1.f90 (based on his > >> interpretation and implementation of OpenMP 4 target), which I have now > >> a

Re: [PATCH] Keep patch file permissions in mklog

2014-08-01 Thread Yury Gribov
On 08/01/2014 10:52 AM, Tom de Vries wrote: This patch adds a script contrib/mklog-in-patch, which uses mklog to generate the skeleton log, but generates the log at the start of the patch as mklog did before (which is how I like to use it). Yeah, we had some argument about this but kind of agre

Re: [PATCH] Move Asan instrumentation to sanopt pass

2014-08-01 Thread Jakub Jelinek
On Mon, Jul 28, 2014 at 06:14:08PM +0400, Yury Gribov wrote: > On 07/24/2014 11:48 AM, Jakub Jelinek wrote: > > So, either support for just EAF*, or perhaps support for DECL_ATTRIBUTES > > for internal-fns, say by having some tree array where you'd store what you > > stick into DECL_ATTRIBUTES norm

  1   2   >