[libcpp] use CPP_PEDANTIC

2014-04-24 Thread Prathamesh Kulkarni
Use macro CPP_PEDANTIC (PF) instead of directly using it's definition: CPP_OPTION (PF, cpp_pedantic). [libcpp] * directives.c (_cpp_handle_directive): Use CPP_PEDANTIC macro. * macro.c (parse_params): Likewise. Bootstrapped on x86_64-unknown-linux-gnu. OK for trunk ? Thanks and Regards, Prathame

Re: [PATCH] Fix PR60930

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 09:20:50PM -0600, Jeff Law wrote: > > PR tree-optimization/60930 > > * gcc.dg/torture/pr60930.c: New test. > Doesn't the test depend on long long being at least 64 bits? But that is guaranteed by C99, isn't it? 5.2.4.2.1 says: ... Their implementation-defined val

libgo patch committed: Fix madvise on systems with page size != 4096

2014-04-24 Thread Ian Lance Taylor
This patch from Anton Blanchard fixes libgo to adjust to the system page size when calling madvise. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Ian diff -r 3a53301d24d7 libgo/runtime/mheap.c --- a/libgo/runtime/mheap.c Tue Apr 22 16:43:35

[patch, toplevel] configure nios2-elf libraries to build with -mno-gpopt

2014-04-24 Thread Sandra Loosemore
People are now starting to build quite large programs for nios2-elf and are running into problems with the small data section getting too large to be entirely within range for GP-relative addressing with a 16-bit offset. This architecture doesn't have an indirect addressing mode with 32-bit of

Re: [PATCH] Fix PR60930

2014-04-24 Thread Jeff Law
On 04/24/14 10:20, Bill Schmidt wrote: Hi, PR60930 exposes an SLSR problem with a fold. When multiplying two constants to create a new stride, the result must fit in the stride type for the computation or the fold is invalid. Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no reg

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Mike Stump
On Apr 24, 2014, at 4:09 PM, Dimitris Papavasiliou wrote: > On 04/24/2014 07:00 PM, Mike Stump wrote: >> On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou wrote: >>> This is a patch regarding a couple of Objective-C related dialect options >>> and warning switches. >> >> Ok. >> >> Committed re

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Mike Stump
On Apr 24, 2014, at 4:16 PM, Dimitris Papavasiliou wrote: > On 04/24/2014 11:17 PM, Jakub Jelinek wrote: >> How has this been tested? >> >> I'm seeing: >> >> +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line 39) >> +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test fo

[PATCH] A new reload-rewrite pattern recognizer for GCC vectorizer.

2014-04-24 Thread Cong Hou
In this patch a new reload-rewrite pattern detector is composed to handle the following pattern in the loop being vectorized: x = *p; ... y = *p; or *p = x; ... y = *p; In both cases, *p is reloaded because there may exist other defs to another memref that may alias with p.

Re: version typeinfo for 128bit types

2014-04-24 Thread Jonathan Wakely
On 24/04/14 20:03 +0200, Marc Glisse wrote: Grep seems to indicate that the manual is the only other place that needs updating, but that can wait. Is this patch ok, assuming the tests pass? OK, and sorry for forgetting about that file in the testsuite!

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Dimitris Papavasiliou
On 04/24/2014 11:17 PM, Jakub Jelinek wrote: How has this been tested? I'm seeing: +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line 39) +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line 41) +FAIL: obj-c++.dg/private-2.mm -fgnu-runtime (test for

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Dimitris Papavasiliou
On 04/24/2014 07:00 PM, Mike Stump wrote: On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou wrote: This is a patch regarding a couple of Objective-C related dialect options and warning switches. Ok. Committed revision 209753. If you could, please add documentation and a test case. Thank

Re: [wide-int, committed] Obvious s390 build fix

2014-04-24 Thread Mike Stump
On Apr 24, 2014, at 2:45 PM, Richard Sandiford wrote: > I committed this patch as obvious to fix the s390 build. Looks good, thanks.

Re: [PATCH] Adjust hoist-register-pressure* testcases to work for S/390

2014-04-24 Thread Jeff Law
On 04/10/14 02:00, Andreas Krebbel wrote: Hi, the hoist-register-pressure testcases currently fail on S/390 since the rtl hoist pass requires that the expression to be hoisted can be assigned without clobbering cc. We do not have a 32 bit add which does not clobber cc. On 64 bit we might use l

[wide-int] Stricter type checking in wide_int constructor

2014-04-24 Thread Richard Sandiford
At the moment we prohibit "widest_int = wide_int" and "offset_int = wide_int". These would be correct only if the wide_int had the same precision as widest_int and offset_int respectively, but since those precisions don't really correspond to a particular language-level precision, such cases should

Re: Skip gcc.dg/tree-ssa/isolate-*.c for AVR Target

2014-04-24 Thread Jeff Law
On 03/31/14 02:20, K_s, Vishnu wrote: Changed the comment in log as the tests are not skipping for AVR only, but for all The targets keeps_null_pointer_checks is true. Corrected the log as per the comments. Please review it and commit it if it's OK. Regards Vishnu KS 2014-03-31 Vishnu K S

Re: Skip gcc.dg/tree-ssa/isolate-*.c for AVR Target

2014-04-24 Thread Jeff Law
On 04/07/14 01:10, K_s, Vishnu wrote: Added comment to avr.c on why disabling -fdelete-null-pointer-checks. Patch Attached in the mail. Previously approved patch can be found here - http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01697.html. I don't have commit access to the source, please commit

Re: [RFC] Add aarch64 support for ada

2014-04-24 Thread Richard Henderson
On 04/23/2014 01:37 PM, Eric Botcazou wrote: >> But it breaks on IA-64 for the same reason as on Aarch64 so we'll need to >> > find something else. > Tentative revised patch attached. Can you give it a try when you have some > time? There is a rationale based on my understanding in types.h. TIA

[wide-int] tree-ssa-ccp fix

2014-04-24 Thread Richard Sandiford
The asm comparison showed a problem with my r204593 change, which dropped a "val.mask &" in the second hunk below. Seeing that the problem was in ccp made me look at the whole file again. I noticed that we'd changed the VARYING mask value from -1 to 1, which didn't look intentional. Tested on x86

Re: [PATCH (for next stage 1)] Add return type to gimple function dumps

2014-04-24 Thread Jeff Law
On 03/10/14 13:22, David Malcolm wrote: Gimple function dumps contain the types of parameters, but not of the return type. The attached patch fixes this omission; here's an example of the before/after diff: $ diff -up /tmp/pr23401.c.004t.gimple.old /tmp/pr23401.c.004t.gimple.new --- /tmp/pr23401

[wide-int, committed] Obvious s390 build fix

2014-04-24 Thread Richard Sandiford
I committed this patch as obvious to fix the s390 build. Thanks, Richard Index: gcc/config/s390/s390.c === --- gcc/config/s390/s390.c 2014-04-24 22:42:21.799411496 +0100 +++ gcc/config/s390/s390.c 2014-04-24 22:42:42.99357

[committed] Fix atomic seq_cst parsing

2014-04-24 Thread Jakub Jelinek
Hi! I've apparently missed a paragraph that made into OpenMP 4.0 on page 131: "In all atomic construct forms, the seq_cst clause and the clause that denotes the type of the atomic construct can appear in any order. In addition, an optional comma may be used to separate the clauses." While the sy

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-04-24 Thread Jeff Law
On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. Looks good now, but I can't approve it. Thanks, Applied to the trunk. Th

[committed] Fix some linear/lastprivate omp issues

2014-04-24 Thread Jakub Jelinek
Hi! As the testcase shows, this patch fixes some issues with lastprivate/linear iteration vars of OpenMP loops (for/simd). One issue was that we were disallowing explicit linear or lastprivate clause for the iteration var, but in the final 4.0 standard while it is predetermined linear (collapse =

Re: [C PATCH] Warn about variadic main (PR c/60156)

2014-04-24 Thread Jeff Law
On 02/12/14 02:51, Marek Polacek wrote: I figured it might be a good idea to warn about variadic main decl (well, not in freestanding environment where it's implementation-defined). Regtested/bootstrapped on x86_64-linux, ok for 5.0? 2014-02-12 Marek Polacek PR c/60156 c-family/

Re: Inline functions tweeks 2/n: bring some heavy functions offline

2014-04-24 Thread Jeff Law
On 01/02/14 10:30, Jan Hubicka wrote: Hi, those functions are not inlined since they are too large anyway. I do not think it is disaster. get_attr_length_1 takes a callback that may make it more interesting inlining candidate than others, perhaps. Bootstrapped/regtested x86_64-linux, OK? Honza

Re: Inline functions tweeks 1/n

2014-04-24 Thread Jeff Law
On 01/02/14 10:21, Jan Hubicka wrote: Hi, While looking for -Winline messages I noticed that sched-int.h has self recursive function declared inline. The recursion is tail recursion but we fail to recognize it as such. The problem ist hat there is a local variable link whose address is passed

Re: [build] PR 43538: Don't overwrite CXXFLAGS_FOR_TARGET in config/mt-gnu

2014-04-24 Thread Jeff Law
On 04/18/14 02:28, Marc Glisse wrote: Ping http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01480.html On Thu, 23 Jan 2014, Marc Glisse wrote: Hello, although setting CFLAGS_FOR_TARGET before compiling gcc works fine, CXXFLAGS_FOR_TARGET is ignored. I don't see any good reason for that. I tested

Re: [PATCH GCC]Fix pr60363 by adding backtraced value of phi arg along jump threading path

2014-04-24 Thread Jeff Law
On 04/17/14 04:07, Bin.Cheng wrote: On Thu, Apr 17, 2014 at 1:30 PM, Jeff Law wrote: On 03/18/14 04:13, bin.cheng wrote: Hi, After control flow graph change made by http://gcc.gnu.org/ml/gcc-patches/2014-02/msg01492.html, case gcc.dg/tree-ssa/ssa-dom-thread-4.c is broken on logical_op_short_c

Re: [PATCH] PR60822 (m68k, missing earlyclobber in extendplussidi)

2014-04-24 Thread Jeff Law
On 04/16/14 18:20, seg...@kernel.crashing.org wrote: On Wed, Apr 16, 2014 at 02:45:28PM -0600, Jeff Law wrote: Isn't the problem that operands 1 is a MEM which use the same register as operands 3 in the memory address? Yes, exactly. ISTM either removing the memory constraint entirely, or spl

Re: [PATCH] Enable multiple duplicated blocks on threading path

2014-04-24 Thread H.J. Lu
On Wed, Dec 25, 2013 at 6:23 AM, H.J. Lu wrote: > On Thu, Nov 21, 2013 at 7:59 AM, H.J. Lu wrote: >> On Tue, Nov 19, 2013 at 9:11 PM, Jeff Law wrote: >>> On 11/19/13 19:33, David Malcolm wrote: FWIW, it looks like you attached the whitespace cleanup patch again, rather than t

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 01:12:02PM +0300, Dimitris Papavasiliou wrote: > Ping! Does anybody know the current record of longest ping? I'd > like to at least break it before giving up. How has this been tested? I'm seeing: +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line

Re: [Patch] Fix a typo in Chinese msg

2014-04-24 Thread Tobias Burnus
Jeff Law wrote: On 04/24/14 01:23, Jincheng Miao wrote: There is a minor typo in zh_CN.po, should change '-pic' to '-fpic'. Thanks for the patch Thanks. Applied to the trunk. Jeff, are you sure that this will not be overridden? I think the translations are always synced from http://tran

Re: wide-int, cfg

2014-04-24 Thread Mike Stump
On Nov 25, 2013, at 2:57 AM, Richard Biener wrote: > On Sat, Nov 23, 2013 at 8:21 PM, Mike Stump wrote: >> Richi has asked the we break the wide-int patch so that the individual port >> and front end maintainers can review their parts without have to go through >> the entire patch.This patc

Re: [C PATCH] Improve error on attrs after declarator in a fndef (PR c/60915)

2014-04-24 Thread Marek Polacek
On Thu, Apr 24, 2014 at 08:25:52PM +0200, Marc Glisse wrote: > On Thu, 24 Apr 2014, Marek Polacek wrote: > > >This PR is about not very clear error message when one tries to > >add attributes *after* the declarator in a function definition. > >cc1plus already handles this well, so I used the same

Re: wide-int, ada

2014-04-24 Thread Mike Stump
On Nov 25, 2013, at 12:46 AM, Eric Botcazou wrote: >> Richi has asked the we break the wide-int patch so that the individual port >> and front end maintainers can review their parts without have to go through >> the entire patch.This patch covers the ada front-end. > > I don't think that th

Re: [PATCH], Add DFP, extended divide, BCD builtins to PowerPC

2014-04-24 Thread David Edelsohn
On Tue, Apr 22, 2014 at 4:21 PM, Michael Meissner wrote: > This patch adds the last set of instructions in the ISA 2.05 (power6), ISA > 2.06 > (power7), and ISA 2.07 (power8) specifications as builtins. As far as I know, > this completes the set of user space instructions that users might want t

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Tim Shen
On Thu, Apr 24, 2014 at 12:38 PM, Jonathan Wakely wrote: > Great, thanks - OK for trunk. > > Assuming no problems on the trunk we might want to backport it for > 4.9.1 in a few weeks. > Committed. Thanks. -- Regards, Tim Shen

Re: [C PATCH] Improve error on attrs after declarator in a fndef (PR c/60915)

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Marek Polacek wrote: This PR is about not very clear error message when one tries to add attributes *after* the declarator in a function definition. cc1plus already handles this well, so I used the same message. I thought you had an earlier version of the patch where, inst

Re: version typeinfo for 128bit types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Rainer Orth wrote: Marc Glisse writes: this is a follow-up for this patch: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00618.html once committed, g++ will generate typeinfo for __float128, and it needs versioning. While there, I noticed that __int128 has "typeinfo" but

Re: [Patch] Fix crtstuff.c compilation with mingw build.

2014-04-24 Thread Rainer Orth
"Steve Ellcey " writes: > diff --git a/libgcc/crtstuff.c b/libgcc/crtstuff.c > index 12bed4b..d09455f 100644 > --- a/libgcc/crtstuff.c > +++ b/libgcc/crtstuff.c > @@ -54,6 +54,7 @@ see the files COPYING3 and COPYING.RUNTIME respectively. > If not, see > #include "auto-host.h" > #undef pid_t >

[PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

2014-04-24 Thread Cong Hou
Given the following loop: int a[N]; short b[N*2]; for (int i = 0; i < N; ++i) a[i] = b[i*2]; After being vectorized, the access to b[i*2] will be compiled into several packing statements, while the type promotion from short to int will be compiled into several unpacking statements. With this

RE: [PATCH, ARM] Suppress Redundant Flag Setting for Cortex-A15

2014-04-24 Thread Ian Bolton
> Hi, > > On 28 January 2014 13:10, Ramana Radhakrishnan > wrote: > > On Fri, Jan 24, 2014 at 5:16 PM, Ian Bolton > wrote: > >> Hi there! > >> > >> An existing optimisation for Thumb-2 converts t32 encodings to > >> t16 encodings to reduce codesize, at the expense of causing > >> redundant flag

Re: [Patch] Fix obsolete autoconf macros in configure.ac

2014-04-24 Thread Steve Ellcey
On Thu, 2014-04-24 at 10:23 +0200, Richard Biener wrote: > >> > +AC_CHECK_TYPES([ssize_t]) > >> > +AC_CHECK_TYPES([caddr_t]) > > > > But I am not sure what header file this code would go in. > > In system.h. > > > Steve Ellcey FYI: I ran into problems defining ssize_t and caddr_t in system.h b

Re: version typeinfo for 128bit types

2014-04-24 Thread Rainer Orth
Marc Glisse writes: > this is a follow-up for this patch: > http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00618.html > > once committed, g++ will generate typeinfo for __float128, and it needs > versioning. While there, I noticed that __int128 has "typeinfo" but not > "typeinfo name", so I am addi

[Patch] Fix crtstuff.c compilation with mingw build.

2014-04-24 Thread Steve Ellcey
I sent an earlier patch to change how GCC configure was setting default values of caddr_t and ssize_t. That patch fixed a build problem I had when building GCC for Windows using the mingw tools but only because my patch was wrong. Here is a new patch to fix the problem. The problem was that crts

[PATCH] Step down as a gengtype reviewer

2014-04-24 Thread Laurynas Biveinis
Even though gengtype patches needing review are quite rare, I am unable to review quickly enough those few that do come. Thus stepping down, the patch below is committed. Index: ChangeLog === --- ChangeLog (revision 209731) +++ Change

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Kyrill Tkachov
On 24/04/14 17:46, Ryan Mansfield wrote: On 14-04-24 12:12 PM, Kyrill Tkachov wrote: On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patc

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Ryan Mansfield
On 14-04-24 12:12 PM, Kyrill Tkachov wrote: On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit ho

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Jonathan Wakely
On 24/04/14 11:49 -0400, Tim Shen wrote: This testcase fails before the patch. Sorry for that. Great, thanks - OK for trunk. Assuming no problems on the trunk we might want to backport it for 4.9.1 in a few weeks.

[PATCH] Fix PR60930

2014-04-24 Thread Bill Schmidt
Hi, PR60930 exposes an SLSR problem with a fold. When multiplying two constants to create a new stride, the result must fit in the stride type for the computation or the fold is invalid. Bootstrapped and tested on powerpc64le-unknown-linux-gnu with no regressions. The same patch applies equally

[PATCH, trunk, 4.9, 4.8] Fix PR57653, filename information discarded when using -imacros

2014-04-24 Thread Peter Bergner
Allan reported this, but we've had people report the same issue to us. Manuel supplied the patch, but couldn't bootstrap and regtest it. He did have a question of whether this was the "correct" fix: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=57653#c18 ...so I thought I could at least bootstr

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Kyrill Tkachov
On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit host gcc. Hi Ryan, Does this patch fix it fo

Re: Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-24 Thread Michael Matz
Hi, On Thu, 24 Apr 2014, David Malcolm wrote: > Implicit naming > === > Several people have suggested that the "gimple_" prefix is redundant. Not generally though (for instance I find it redundant in the cast-method names, but _not_ in the global types). > Andrew MacLeod suggested

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Mike Stump
On Feb 6, 2014, at 1:25 AM, Dimitris Papavasiliou wrote: > This is a patch regarding a couple of Objective-C related dialect options and > warning switches. Ok. Committed revision 209753. If you could, please add documentation and a test case.

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Tim Shen
On Thu, Apr 24, 2014 at 6:56 AM, Jonathan Wakely wrote: > Unless I'm doing something wrong the new tests you added already give > the right results, do you have a testcase that fails with the current > code? This testcase fails before the patch. Sorry for that. -- Regards, Tim Shen commit f333

Re: [Patch] Fix a typo in Chinese msg

2014-04-24 Thread Jeff Law
On 04/24/14 01:23, Jincheng Miao wrote: There is a minor typo in zh_CN.po, should change '-pic' to '-fpic'. Best wishes, Jincheng Miao Thanks. Applied to the trunk. jeff

Re: [4.9.1 RFA] [tree-optimization/60902] Invalidate outputs of GIMPLE_ASMs when threading around loops

2014-04-24 Thread Jeff Law
On 04/24/14 02:22, Richard Biener wrote: + + if (backedge_seen) + FOR_EACH_SSA_TREE_OPERAND (op, stmt, iter, SSA_OP_ALL_DEFS) You only need SSA_OP_DEF here, no need to process virtual operands. I went back and forth on this. I couldn't come up with a case where we'd do the w

Re: [c++] typeinfo for target types

2014-04-24 Thread Tejas Belagod
Marc Glisse wrote: On Thu, 24 Apr 2014, Ramana Radhakrishnan wrote: On Wed, Apr 23, 2014 at 8:43 PM, Marc Glisse wrote: On Wed, 23 Apr 2014, Richard Henderson wrote: On 04/13/2014 01:41 AM, Marc Glisse wrote: Hello, this patch generates typeinfo for target types. On x86_64, it adds these

Re: Add post_expand_call_insn hook

2014-04-24 Thread Eric Botcazou
> The hook is called right after expansion of calls, and allows a target to do > additional processing, such as f.i. adding clobbers to > CALL_INSN_FUNCTION_USAGE. > > Instead of using the hook, we could add code to the preparation statements > operand of the different call expands, but that requi

Re: Add clobber_reg

2014-04-24 Thread Eric Botcazou
> Richard Sandiford mentioned here ( > http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00870.html ): > ... > Although we really should have a utility function like use_reg, but for > clobbers, so that the above would become: > >clobber_reg (&CALL_INSN_FUNCTION_USAGE (insn), gen_rtx_REG (word_mode

Examples of gimple statement API (was Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.)

2014-04-24 Thread David Malcolm
On Thu, 2014-04-24 at 09:09 -0400, Andrew MacLeod wrote: > On 04/24/2014 04:33 AM, Richard Biener wrote: > > On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: > >> On 04/23/14 15:13, David Malcolm wrote: > >>> On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: > On 04/21/14 10:56, David Malco

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-24 Thread Michael Matz
Hi, On Thu, 24 Apr 2014, Andrew MacLeod wrote: > Well, we ought to settle on one... either use the is_a, as_a, and > dyn_cast paradigm as they exist today, or we use the cast_as_method > approach everywhere. I'm not fond of each potential project having a > different approach... I'd like to

Re: [wide-int] Fix signed min / -1 quotient

2014-04-24 Thread Kenneth Zadeck
This is fine with me. kenny On 04/24/2014 10:34 AM, Richard Sandiford wrote: For signed min / -1 we set the overflow flag (good) but also returned a quotient of 0. It should be 0x80...0 instead. Since that's also the value of the original dividend, we can just copy the representation over. T

Re: [PATCH] Fix PR60911

2014-04-24 Thread Jan Hubicka
> > Simple IPA passes are supposed to see function bodies with IPA transforms > applied - this is what the code in execute_one_pass tries to ensure. > But that doesn't work anymore with on-demand function-body loading. > The following addresses this in the least intrusive way - inlining > do_per_

[wide-int] Fix signed min / -1 quotient

2014-04-24 Thread Richard Sandiford
For signed min / -1 we set the overflow flag (good) but also returned a quotient of 0. It should be 0x80...0 instead. Since that's also the value of the original dividend, we can just copy the representation over. The value for division by 0 is probably pretty arbitrary. double-int.c seems to t

[C PATCH] Improve error on attrs after declarator in a fndef (PR c/60915)

2014-04-24 Thread Marek Polacek
This PR is about not very clear error message when one tries to add attributes *after* the declarator in a function definition. cc1plus already handles this well, so I used the same message. Regtested/bootstrapped on x86_64-linux, ok for trunk? 2014-04-24 Marek Polacek PR c/60915

Re: [PATCH, AArch64] Enable shuffle on big-endian and turn on the testsuite

2014-04-24 Thread Tejas Belagod
Marcus Shawcroft wrote: gcc/ChangeLog: 2014-04-11 Alan Lawrence * config/aarch64/aarch64.c (aarch64_evpc_tbl): enable for bigendian. gcc/testsuite/ChangeLog: 2014-04-11 Alan Lawrence * lib/target-supports.exp (check_effective_target_vect_perm): return true for aar

Re: [c++] typeinfo for target types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Ramana Radhakrishnan wrote: Well some of these scalar types are not really user visible which is where I believe the problem is coming from and prima-facie I don't think we should be inventing mangling for some of these "internal" types. If the types are not user-visible,

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Ramana Radhakrishnan
On Thu, Apr 24, 2014 at 2:54 PM, Kyrill Tkachov wrote: > On 24/04/14 14:44, Ryan Mansfield wrote: >> >> On 14-04-23 11:38 AM, Kyrill Tkachov wrote: >>> >>> http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html >>> (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) >> >> This patch breaks

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Kyrill Tkachov
On 24/04/14 14:44, Ryan Mansfield wrote: On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit host gcc. e.g ../../gcc/config/arm/aa

Re: [Committed][ARM][AArch64] Patches previously ok'd for stage1

2014-04-24 Thread Ryan Mansfield
On 14-04-23 11:38 AM, Kyrill Tkachov wrote: http://gcc.gnu.org/ml/gcc-patches/2014-03/msg00934.html (http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01634.html) This patch breaks building arm-eabi with a 32bit host gcc. e.g ../../gcc/config/arm/aarch-common.c ../../gcc/config/arm/aarch-c

Re: [c++] typeinfo for target types

2014-04-24 Thread Ramana Radhakrishnan
>> Well some of these scalar types are not really user visible which is >> where I believe the problem is coming from and prima-facie I don't >> think we should be inventing mangling for some of these "internal" >> types. > > > If the types are not user-visible, it is not clear to me why they need

Re: [PATCH 02/89] Introduce gimple_switch and use it in various places

2014-04-24 Thread David Malcolm
On Wed, 2014-04-23 at 13:58 -0600, Jeff Law wrote: > On 04/21/14 10:56, David Malcolm wrote: [...] > So, generally I like it. It looks pretty much like what I'd expect from > this kind of work. > > So it sounds like Richi really prefers the explicit casting rather than > member functions. It s

Re: [c++] typeinfo for target types

2014-04-24 Thread Marc Glisse
On Thu, 24 Apr 2014, Ramana Radhakrishnan wrote: On Wed, Apr 23, 2014 at 8:43 PM, Marc Glisse wrote: On Wed, 23 Apr 2014, Richard Henderson wrote: On 04/13/2014 01:41 AM, Marc Glisse wrote: Hello, this patch generates typeinfo for target types. On x86_64, it adds these 6 lines to nm -C li

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-24 Thread Andrew MacLeod
On 04/23/2014 10:42 AM, Michael Matz wrote: Hi, On Mon, 21 Apr 2014, David Malcolm wrote: case GIMPLE_SWITCH: dump_gimple_switch (buffer, gs->as_a_gimple_switch (), spc, flags); break; where the ->as_a_gimple_switch is a no-op cast from "gimple" to the more concrete "gimpl

Re: [PATCH 03/89] Introduce gimple_bind and use it for accessors.

2014-04-24 Thread Andrew MacLeod
On 04/24/2014 04:33 AM, Richard Biener wrote: On Wed, Apr 23, 2014 at 11:23 PM, Jeff Law wrote: On 04/23/14 15:13, David Malcolm wrote: On Wed, 2014-04-23 at 15:04 -0600, Jeff Law wrote: On 04/21/14 10:56, David Malcolm wrote: This updates all of the gimple_bind_* accessors in gimple.h from

Re: [VRP][PATCH] Improve value range for loop index

2014-04-24 Thread Richard Biener
On Wed, Apr 9, 2014 at 10:07 PM, Kugan wrote: > Value range propagation simplifies convergence in vrp_visit_phi_node by > setting minimum to TYPE_MIN when the computed minimum is smaller than > the previous minimum. This can however result in pessimistic value > ranges in some cases. > > for examp

Re: [PATCH, AArch64] Enable shuffle on big-endian and turn on the testsuite

2014-04-24 Thread Marcus Shawcroft
> gcc/ChangeLog: > 2014-04-11 Alan Lawrence > > * config/aarch64/aarch64.c (aarch64_evpc_tbl): enable for bigendian. > > gcc/testsuite/ChangeLog: > 2014-04-11 Alan Lawrence > > * lib/target-supports.exp (check_effective_target_vect_perm): return > true for aarch64_be.

Re: [PATCH] Fix PR60896

2014-04-24 Thread Richard Biener
On Wed, 23 Apr 2014, Cong Hou wrote: > See http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60896 for bug report. > > The cause of PR60896 is that those statements in PATTERN_DEF_SEQ in > pre-recognized widen-mult pattern are not forwarded to later > recognized dot-product pattern. > > Another issue

Re: [PATCH 00/89] Compile-time gimple-checking

2014-04-24 Thread Richard Sandiford
Jeff Law writes: > On 04/22/14 02:03, Richard Sandiford wrote: >> First of all, thanks a lot for doing this. Maybe one day we'll have >> the same in rtl :-) > Funny you should mention that. I blocked off a hunk of time for David > to investigate doing some work on that this year. That'd be gre

[PATCH] Fix PR60911

2014-04-24 Thread Richard Biener
Simple IPA passes are supposed to see function bodies with IPA transforms applied - this is what the code in execute_one_pass tries to ensure. But that doesn't work anymore with on-demand function-body loading. The following addresses this in the least intrusive way - inlining do_per_function (ap

[PATCH] Fix PR60912

2014-04-24 Thread Richard Biener
The following fixes PR60912 - a bug with IPA PTA computing the use/clobber sets for direct calls where it "optimized" walking using the cgraph nodes caller list. But that can be incomplete in the face of aliases. Luckily that optimization is no longer necessary because we now cache the outcome o

Re: [Patch] Fix a bug of consecutive range quantifiers in regex

2014-04-24 Thread Jonathan Wakely
On 24 April 2014 04:47, Tim Shen wrote: >> Booted and tested with -m32 and -m64. > > I should give an explanation: > > When traversing a graph in _M_clone(), it should stop at a node with > id _M_end. However, if _M_end has other outgoing edge (_M_alt), the > edge should be concerned too. So this p

[PATCH] Update libstdc++ baseline symbols for ia64

2014-04-24 Thread Andreas Schwab
Tested on ia64-suse-linux and installed as obvious. Andreas. * config/abi/post/ia64-linux-gnu/baseline_symbols.txt: Update for new CXXABI_1.3.9 symbols. diff --git a/libstdc++-v3/config/abi/post/ia64-linux-gnu/baseline_symbols.txt b/libstdc++-v3/config/abi/post/ia64-linux-gnu/ba

Re: [c++] typeinfo for target types

2014-04-24 Thread Ramana Radhakrishnan
On Wed, Apr 23, 2014 at 8:43 PM, Marc Glisse wrote: > On Wed, 23 Apr 2014, Richard Henderson wrote: > >> On 04/13/2014 01:41 AM, Marc Glisse wrote: >>> >>> Hello, >>> >>> this patch generates typeinfo for target types. On x86_64, it adds these >>> 6 >>> lines to nm -C libsupc++.a. A follow-up patc

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Dimitris Papavasiliou
Ping! Does anybody know the current record of longest ping? I'd like to at least break it before giving up. On 04/03/2014 06:32 PM, Dimitris Papavasiliou wrote: Still pinging. On 03/28/2014 11:58 AM, Dimitris Papavasiliou wrote: Ping! On 03/23/2014 03:20 AM, Dimitris Papavasiliou wrote: P

Re: [AArch64/ARM 1/3] Add execution + assembler tests of AArch64 EXT intrinsics

2014-04-24 Thread Marcus Shawcroft
On 23 April 2014 21:01, Alan Lawrence wrote: > This adds DejaGNU tests of the existing AArch64 vext* intrinsics, both > checking the assembler output and the runtime results. Test bodies are in > separate files ready to reuse for ARM in the third patch. > > All passing on aarch64-none-elf and aarc

Re: [AArch64/ARM 2/3] Recognize shuffle patterns for REV instructions on AARch64, rewrite intrinsics.

2014-04-24 Thread Marcus Shawcroft
On 23 April 2014 20:44, Alan Lawrence wrote: > This patch (borrowing heavily from the ARM backend) makes > aarch64_expand_vec_perm_const output REV instructions when appropriate, > and then implements the vrev_XXX intrinsics in terms of __builtin_shuffle > (which > now produces the same assembly i

Re: [AArch64/ARM 1/3] Add execution + assembler tests of AArch64 REV Neon Intrinsics

2014-04-24 Thread Marcus Shawcroft
On 23 April 2014 20:17, Alan Lawrence wrote: > This adds DejaGNU tests of the existing AArch64 vrev_* intrinsics, both > checking the assembler output and the runtime results. Test bodies are in > separate files ready to reuse for ARM in the third patch. > > All tests passing on aarch64-none-elf a

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Richard Biener wrote: > On Thu, 24 Apr 2014, Eric Botcazou wrote: > > > > Meanwhile is does the patch look ok? > > > > No, the current wording is just fine and yours doesn't bring anything (even > > the contrary, since you're listing known problematic versions). This will

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Eric Botcazou wrote: > > Meanwhile is does the patch look ok? > > No, the current wording is just fine and yours doesn't bring anything (even > the contrary, since you're listing known problematic versions). This will > also break http://gcc.gnu.org/install/specific.html#s

Re: [PATCH] Fix web/60933

2014-04-24 Thread Eric Botcazou
> Meanwhile is does the patch look ok? No, the current wording is just fine and yours doesn't bring anything (even the contrary, since you're listing known problematic versions). This will also break http://gcc.gnu.org/install/specific.html#sparc-x-x I don't see why we should special case GMP,

Re: [PATCH] Fix web/60933

2014-04-24 Thread Rainer Orth
Richard Biener writes: >> I'd strongly advise against it: in the past we've had serious problems >> with versions newer than advertised in install.texi on some platforms. >> Until we have positive evidence that specific newer versions work on a >> wide range of platforms, we shouldn't suggest to

Re: [PATCH] Fix web/60933

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 10:38:38AM +0200, Richard Biener wrote: > > Is there a reason why you have lowered the minimum versions (4.3.2 -> 4.2.3, > > 2.4.2 -> 2.4.0, 0.8.1 -> 0.8.0)? > > As I say "will not work" I checked what we reject at configure time > (for the oldest versions that work we'll c

Only redefine ASM_PREFERRED_EH_DATA_FORMAT if necessary on Solaris/x86

2014-04-24 Thread Rainer Orth
Currently, Solaris/x86 uses a private version of ASM_PREFERRED_EH_DATA_FORMAT since older versions of the Solaris assembler couldn't calculate the difference between labels in different sections. This restriction has been lifted in Solaris 10 patch 119961-07 from May 2010. Since the redefinition

Re: [c++] typeinfo for target types

2014-04-24 Thread Kyrill Tkachov
On 23/04/14 21:35, Richard Henderson wrote: On 04/23/2014 12:43 PM, Marc Glisse wrote: Any c++ compilation aborts at That's surprising, the code I touched is only ever supposed to run while compiling one file in libsupc++, if I understand correctly. Ah, well, perhaps it's one of the first buil

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Jakub Jelinek wrote: > On Thu, Apr 24, 2014 at 10:15:31AM +0200, Richard Biener wrote: > > We probably should try to bump the versions used by that script > > to something more recent though (should we do that for the 4.9 > > branch even?). Any idea what to choose here? I'd

RE: [PATCH][2/3] Fix PR54733 Optimize endian independent load/store

2014-04-24 Thread Thomas Preud'homme
> > Bootstrapped on x86_64-linux-gnu with no testsuite regression. Also did a > arm-none-eabi cross build with no regression after running testsuite via > qemu Forgot to ask if it's ok for trunk. Same question for part 1 and 3. Best regards, Thomas

Re: [PATCH] Fix web/60933

2014-04-24 Thread Richard Biener
On Thu, 24 Apr 2014, Rainer Orth wrote: > Richard Biener writes: > > > The GMP people complained that we "advertise" outdated versions > > in our install instructions. I tried to address that by not > > explicitely listing a "good" version but only mention the version > > that is the minimum re

Re: GCC's -fsplit-stack disturbing Mach's vm_allocate

2014-04-24 Thread Svante Signell
On Fri, 2014-04-18 at 10:03 +0200, Samuel Thibault wrote: > Samuel Thibault, le Thu 17 Apr 2014 00:03:45 +0200, a écrit : > > Thomas Schwinge, le Wed 09 Apr 2014 09:36:42 +0200, a écrit : > > > Well, the first step is to verify that TARGET_THREAD_SPLIT_STACK_OFFSET > > > and similar configury is co

  1   2   >