Re: Recent Go patch broke Alpha bootstrap

2013-11-11 Thread Uros Bizjak
On Mon, Nov 11, 2013 at 8:52 PM, Ian Lance Taylor wrote: > On Fri, Nov 8, 2013 at 1:10 AM, Uros Bizjak wrote: >> >> panic: runtime error: invalid memory address or nil pointer dereference >> [signal 0xb code=0x1 addr=0x1c] >> FAIL: runtime/pprof >> gmake[2]: *** [runtime/pprof/check] Error 1 >>

Re: [PATCH, i386] Fix -mpreferred-stack-boundary

2013-11-11 Thread Uros Bizjak
There was something wrong with Bernd's address, retrying. >> Currently on trunk the option -mpreferred-stack-boundary does not work >> together with #pragma GCC target("sse") or __attribute__((target("sse"))). >> >> There is already a test case that detects this: >> gcc.target/i386/fastcall-ssere

Re: [PATCH, i386] Fix -mpreferred-stack-boundary

2013-11-11 Thread Uros Bizjak
Hello! > Currently on trunk the option -mpreferred-stack-boundary does not work > together with #pragma GCC target("sse") or __attribute__((target("sse"))). > > There is already a test case that detects this: > gcc.target/i386/fastcall-sseregparm.c > > The attached patch fixes this test case unde

RE: [PATCH GCC]Compute, cache and use cost of auto-increment rtx patterns in IVOPT

2013-11-11 Thread bin.cheng
Ping in this one. Hi Bernd, could you please help us on this one? Please ignore the previous ping message because I used the wrong email account. Sorry for the inconvenience. Thanks, bin > -Original Message- > From: Bin.Cheng [mailto:amker.ch...@gmail.com] > Sent: Monday, November 04, 20

[patch] [arm] New option for PIC offset unfixed

2013-11-11 Thread Joey Ye
For RTOS who need to relocate executable, PC relative and GOTOFF cannot be used as the offset between any sections won't be fixed. Only GOT can be used, just as VxWorks RTP does. This patch introduces a new option enable user to choose between fixed offset or not. Enabled for VxWorks RTP to keep i

Missing line (?) in better_state in ipa-pure-const.c

2013-11-11 Thread Marc Glisse
Hello, this patch passed bootstrap+testsuite. I don't have a testcase, the code just looked strange. 2013-11-05 Marc Glisse PR tree-optimization/59077 * ipa-pure-const.c (better_state): Update *state. -- Marc GlisseIndex: gcc/ipa-pure-const.c =

RE: [PATCH] Fix for PR bootstrap/58951

2013-11-11 Thread Iyer, Balaji V
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Jeff Law > Sent: Monday, November 11, 2013 11:40 PM > To: Iyer, Balaji V; Gerald Pfeifer > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Fix for PR bootstrap/58951 > > O

RE: PING Cilk Plus failures on non-LTO targets

2013-11-11 Thread Iyer, Balaji V
> -Original Message- > From: David Edelsohn [mailto:dje@gmail.com] > Sent: Monday, November 11, 2013 11:36 AM > To: Iyer, Balaji V > Cc: GCC Patches; Joseph S. Myers > Subject: Re: PING Cilk Plus failures on non-LTO targets > > On Mon, Nov 4, 2013 at 11:06 AM, David Edelsohn > wrote

Re: [PATCH] Fix for PR bootstrap/58951

2013-11-11 Thread Jeff Law
On 11/11/13 21:30, Iyer, Balaji V wrote: -Original Message- From: Gerald Pfeifer [mailto:ger...@pfeifer.com] Sent: Monday, November 11, 2013 6:52 PM To: Iyer, Balaji V Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix for PR bootstrap/58951 Hi Balaji, any chance to get this fixed?

RE: [PATCH] Fix for PR bootstrap/58951

2013-11-11 Thread Iyer, Balaji V
> -Original Message- > From: Gerald Pfeifer [mailto:ger...@pfeifer.com] > Sent: Monday, November 11, 2013 6:52 PM > To: Iyer, Balaji V > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] Fix for PR bootstrap/58951 > > Hi Balaji, > > any chance to get this fixed? Bootstrap on FreeBSD h

Re: [committed] Remove duplicate contents in gcc/config/rs6000/t-xilinx

2013-11-11 Thread Michael Eager
On 11/09/13 03:29, Tom de Vries wrote: Michael, This patch removes duplicate contents in gcc/config/rs6000/t-xilinx. Looks like a patch was applied twice. Committed as trivial. Thanks, - Tom 2013-11-08 Tom de Vries * config/rs6000/t-xilinx: Remove duplicate contents. Thanks. That'

Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.

2013-11-11 Thread Jason Merrill
On 11/11/2013 02:44 PM, Adam Butcher wrote: Yes, using add_outermost_template_args. I have done this (diff -w -b follows). The route to this seems even more costly though; current_template_parms needs to first be converted to a vec by current_template_args() then the last nesting level is thro

Re: [C++ Patch] PR 57734

2013-11-11 Thread Jason Merrill
OK. Jason

Re: Honnor ix86_accumulate_outgoing_args again

2013-11-11 Thread H.J. Lu
On Mon, Nov 11, 2013 at 4:18 PM, Jakub Jelinek wrote: > On Thu, Oct 10, 2013 at 08:40:05PM +0200, Jan Hubicka wrote: >> --- config/i386/x86-tune.def (revision 203387) >> +++ config/i386/x86-tune.def (working copy) > >> +/* X86_TUNE_AVX256_UNALIGNED_LOAD_OPTIMAL: if true, unaligned loads are >> +

Re: Honnor ix86_accumulate_outgoing_args again

2013-11-11 Thread Jakub Jelinek
On Thu, Oct 10, 2013 at 08:40:05PM +0200, Jan Hubicka wrote: > --- config/i386/x86-tune.def (revision 203387) > +++ config/i386/x86-tune.def (working copy) > +/* X86_TUNE_AVX256_UNALIGNED_LOAD_OPTIMAL: if true, unaligned loads are > + split. */ > +DEF_TUNE (X86_TUNE_AVX256_UNALIGNED_LOAD_OPTI

Re: [RFC] replace malloc with a decl on the stack

2013-11-11 Thread Marc Glisse
On Mon, 11 Nov 2013, Ondřej Bílka wrote: On Sun, Nov 10, 2013 at 04:27:00PM +0100, Marc Glisse wrote: Hello, I am posting this patch to get some feedback on the approach. The goal is to replace malloc+free with a stack allocation (a decl actually) when the size is a small constant. Why const

Re: [RFC] replace malloc with a decl on the stack

2013-11-11 Thread Marc Glisse
On Mon, 11 Nov 2013, Richard Biener wrote: On Sun, Nov 10, 2013 at 4:27 PM, Marc Glisse wrote: Hello, I am posting this patch to get some feedback on the approach. The goal is to replace malloc+free with a stack allocation (a decl actually) when the size is a small constant. For testing, I h

Re: [PATCH] Fix for PR bootstrap/58951

2013-11-11 Thread Gerald Pfeifer
Hi Balaji, any chance to get this fixed? Bootstrap on FreeBSD has now been broken for some two weeks overall and I hope there aren't other things hidden behind this one. Gerald On Tue, 5 Nov 2013, Gerald Pfeifer wrote: > thanks for looking into this. Unfortunately, with SVN revision 204424 > (

[C++ Patch] PR 57734

2013-11-11 Thread Paolo Carlini
Hi, this issue points out that we aren't handling correctly alias template declarations of enums. The core problem in lookup_template_class_1 is easy to spot: we check for (and handle) TREE_CODE (template_type) == ENUMERAL_TYPE *before* DECL_ALIAS_TEMPLATE_P (gen_tmpl). Besides this more or l

Re: [Patch,Aarch64] Make frame grow downwards

2013-11-11 Thread Christophe Lyon
Ping? The original post is here: http://gcc.gnu.org/ml/gcc-patches/2013-06/msg01588.html Thanks, Christophe. On 28 June 2013 13:41, Christophe Lyon wrote: > Hi, > Following the discussion on > http://gcc.gnu.org/ml/gcc/2013-05/msg00208.html > here is a patch to change the frame direction. > >

Re: [PATCH, rs6000] ELFv2 ABI 1/8: Add options and infrastructure

2013-11-11 Thread Jakub Jelinek
On Mon, Nov 11, 2013 at 03:40:48PM +0100, Ulrich Weigand wrote: > @@ -355,7 +364,11 @@ extern int dot_symbols; > #define LINK_OS_DEFAULT_SPEC "%(link_os_linux)" > > #define GLIBC_DYNAMIC_LINKER32 "/lib/ld.so.1" > -#define GLIBC_DYNAMIC_LINKER64 "/lib64/ld64.so.1" > +#ifdef LINUX64_DEFAULT_ABI_E

Re: [PATCH, rs6000] ELFv2 ABI 1/8: Add options and infrastructure

2013-11-11 Thread Joseph S. Myers
On Mon, 11 Nov 2013, Ulrich Weigand wrote: > Hello, > > this is the first patch in the series to add support for the ELFv2 ABI. > > The ELFv2 ABI is the intended ABI for the new powerpc64le-linux port. > However, it is not inherently tied to the byte order; it it possible > in principle to use t

Re: [wwwdocs] backend -> back end

2013-11-11 Thread Joseph S. Myers
On Mon, 11 Nov 2013, Gerald Pfeifer wrote: > Working to address a user question, I noticed that many of our pages use > the spelling of "backend" when http://gcc.gnu.org/codingconventions.html > suggest "back end" (noun) and "back-end" (adjective). > > Joseph, if you confirm that back end it is

Re: [PATCH], PR target/59054, powerpc code regression for power7/power8

2013-11-11 Thread Michael Meissner
On Mon, Nov 11, 2013 at 04:45:36PM -0500, Michael Meissner wrote: > [gcc] > 2013-11-11 Michael Meissner > > PR target/59054 > * config/rs6000/rs6000.md (movdi_internal32): Eliminate > constraints that would allow DImode into the traditional Altivec > registers, but cause

[PATCH], PR target/59054, powerpc code regression for power7/power8

2013-11-11 Thread Michael Meissner
This patch fixes PR 59054, which is a bug I introduced in early October, when I added initial patches for allowing DFmode values in the traditional Altivec registers on ISA 2.06, and SFmode values on ISA 2.07. This patch eliminates the constraints that allowed DImode values to go into the Altivec

Re: Recent Go patch broke Solaris bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 4:01 AM, Rainer Orth wrote: > The recent Go patch (couldn't find the submission on gcc-patches) broke > Solaris bootstrap: on Solaris 10/x86 I get > > /vol/gcc/src/hg/trunk/local/libgo/go/net/tcpsockopt_unix.go:26:103: error: > reference to undefined identifier 'syscall.TC

Re: Recent Go patch broke CentOS 5.10 bootstrap

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 7:08 AM, Uros Bizjak wrote: > > Building latest gcc+go on CentOS 5.10 breaks with following build failure: > > ../../../gcc-svn/trunk/libgo/go/net/fd_unix.go:414:72: error: > reference to undefined identifier ‘syscall.F_DUPFD_CLOEXEC’ >r0, _, e1 := syscall.Syscall(sysca

Re: Recent Go patch broke Solaris bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 4:01 AM, Rainer Orth wrote: > The recent Go patch (couldn't find the submission on gcc-patches) broke > Solaris bootstrap: on Solaris 10/x86 I get > > /vol/gcc/src/hg/trunk/local/libgo/go/net/fd_unix.go:414:72: error: reference > to undefined identifier 'syscall.F_DUPFD_CL

Re: [patch 4/4] Separate gimple.[ch] and gimplify.[ch]

2013-11-11 Thread Andrew MacLeod
This one covers the config target files which included gimple.h Bootstraps on x86_64-unknown-linux-gnu with no new regressions, and compiled stage1 on each of the targets utilizing these config/*.c files to ensure they compiled. targets I used were: aarch64-linux-gnu alpha-linux-gnu ia64-lin

[patch 3/4] Separate gimple.[ch] and gimplify.[ch] - front end files

2013-11-11 Thread Andrew MacLeod
This one covers the front end files which included gimple.h Bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? Andrew * ada/gcc-interface/trans.c: Include gimplify.h. * c/c-typeck.c: Include gimplify.h. * c-family/c-common.c: Include gimplify.h. * c-family/c-gimplify.c:

Re: [PATCH i386 4/8] [AVX512] [1/n] Add substed patterns.

2013-11-11 Thread Richard Henderson
On 11/05/2013 11:05 PM, Kirill Yukhin wrote: > Hello, > Small correction. > > On 01 Nov 16:19, Kirill Yukhin wrote: >> +(define_insn "avx512f_store_mask" >> + [(set (match_operand:VI48F_512 0 "memory_operand" "=m") >> +(vec_merge:VI48F_512 >> + (match_operand:VI48F_512 1 "register_operan

[patch 2/4] Separate gimple.[ch] and gimplify.[ch]

2013-11-11 Thread Andrew MacLeod
This one covers the middle and back end files which included gimple.h Bootstraps on x86_64-unknown-linux-gnu with no new regressions. OK? Andrew * asan.c: Include gimplify.h rather than gimple.h. * cfgloopmanip.c: Likewise. * cgraphunit.c: Likewise. * cilk-common.c: Likewise. * dwarf2out.

[patch 1/4] Separate gimple.[ch] and gimplify.[ch]

2013-11-11 Thread Andrew MacLeod
This was/is relatively painful, and there will be another set after this to really finish it. The front ends and the middle end both make extensive use of gimplification There is no way at this early point to really separate them unless we created a gimplify-fe.[ch] and gimplfy-be.[ch] so a

[PATCH, i38]: Fix PR58853, ICE in expand_set_or_movmem_prologue_epilogue_by_misaligned_moves

2013-11-11 Thread Uros Bizjak
Hello! Attached patch fixes a typo in ix86_expand_set_or_movmem, where a wrong define was used in a condition. The patch also adds additional condition (as proposed by H.J.) as a correctness improvement (although patched gcc bootstraps and regression tests OK without). I took the liberty to rena

Re: Recent Go patch broke Alpha bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 1:10 AM, Uros Bizjak wrote: > > panic: runtime error: invalid memory address or nil pointer dereference > [signal 0xb code=0x1 addr=0x1c] > > goroutine 5 [running]: > syscall.Exitsyscall > ../../../gcc-svn/trunk/libgo/runtime/proc.c:1986 > pprof.profileWriter >

Re: [C++ PATCH] Refactor implicit function template implementation and fix 58534, 58536, 58548, 58549 and 58637.

2013-11-11 Thread Adam Butcher
On 2013-11-10 23:21, Jason Merrill wrote: On 11/10/2013 02:39 PM, Adam Butcher wrote: I assumed that tsubst simply doesn't do anything with a null tree substitution (i.e. it is an identity op). Substituting NULL_TREE for a template parameter gives a template parameter with a reduced level; thi

Re: Recent Go patch broke Alpha bootstrap

2013-11-11 Thread Ian Lance Taylor
On Fri, Nov 8, 2013 at 1:10 AM, Uros Bizjak wrote: > On Fri, Nov 8, 2013 at 12:39 AM, Ian Lance Taylor wrote: > >>> Recent Go mega-patch broke Alpha bootstrap. Following fixlet is needed: >>> >> Thanks for the patch and report. This patch should fix them. >> Bootstrapped and tested on x86_64-unk

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-11-11 Thread Cong Hou
Hi James Sorry for the late reply. On Fri, Nov 8, 2013 at 2:55 AM, James Greenhalgh wrote: >> On Tue, Nov 5, 2013 at 9:58 AM, Cong Hou wrote: >> > Thank you for your detailed explanation. >> > >> > Once GCC detects a reduction operation, it will automatically >> > accumulate all elements in th

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 10:55 AM, Eric Botcazou wrote: >> Simply trapping doesn't tell you anything about caused the trap. >> There are at least two distinct possibilities: NULL pointer >> dereference and integer division by zero. There should be some way to >> distinguish those two cases. It's

Re: [PATCH] Fix failing assertion in calls.c:store_unaligned_arguments_into_pseudos

2013-11-11 Thread Ulrich Weigand
Jeff Law wrote: > On 11/11/13 07:32, Ulrich Weigand wrote: > > However, looking more closely, it seems > > store_unaligned_arguments_into_pseudos > > is not really useful for PARALLEL arguments in the first place. What this > > routine does is load arguments into args[i].aligned_regs. But if we

Re: PATCH: other/59039: Undocumented __builtin_longjmp/__builtin_setjmp

2013-11-11 Thread Joseph S. Myers
On Sun, 10 Nov 2013, H.J. Lu wrote: > +@code{__builtin_setjmp} and @code{__builtin_longjmp} may not be used > +in the same function with the same @code{setjmp} buffer. Are there any other restrictions? Do they, for example, guarantee to restore all call-saved registers to their values at the ti

Re: [PATCH] Bug fix for PR59050

2013-11-11 Thread Cong Hou
Thank you for your advice! I will follow this instruction in future. thanks, Cong On Mon, Nov 11, 2013 at 1:32 AM, Richard Biener wrote: > On Fri, 8 Nov 2013, Cong Hou wrote: > >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59050 >> >> This is my bad. I forget to check the test result for gfor

Re: [PATCH] Bug fix for PR59050

2013-11-11 Thread Cong Hou
Hi Jeff I have committed the fix. Please update your repo. Thank you! Cong On Mon, Nov 11, 2013 at 10:32 AM, Jeff Law wrote: > On 11/11/13 02:32, Richard Biener wrote: >> >> On Fri, 8 Nov 2013, Cong Hou wrote: >> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59050 >>> >>> This is my bad.

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-11 Thread Rong Xu
On Mon, Nov 11, 2013 at 7:17 AM, Jan Hubicka wrote: >> Here is the patch that includes profile-tool. >> Profile-tool now has two functions: merge and rewrite. I'll add diff later. >> >> Compiler is tested with spec2006 and profiledbootstrap. >> profile-tool is tested with spec2006 profiles. > > Hi

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Eric Botcazou
> Simply trapping doesn't tell you anything about caused the trap. > There are at least two distinct possibilities: NULL pointer > dereference and integer division by zero. There should be some way to > distinguish those two cases. It's reasonably easy to do so in a > signal handler. When should

Committed: Adjust testsuite for ARC LOGICAL_OP_NON_SHORT_CIRCUIT definition.

2013-11-11 Thread Joern Rennecke
2013-11-11 Joern Rennecke * gcc.dg/tree-ssa/forwprop-28.c: Adjust for ARC LOGICAL_OP_NON_SHORT_CIRCUIT definition. * gcc.dg/tree-ssa/ssa-dom-thread-4.c: Likewise. * gcc.dg/tree-ssa/ssa-ifcombine-ccmp-1.c: Likewise. * gcc.dg/tree-ssa/ssa-ifcombine-ccm

Re: [PATCH] Bug fix for PR59050

2013-11-11 Thread Jeff Law
On 11/11/13 02:32, Richard Biener wrote: On Fri, 8 Nov 2013, Cong Hou wrote: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59050 This is my bad. I forget to check the test result for gfortran. With this patch the bug should be fixed (tested on x86-64). Ok. Btw, requirements are to bootstrap a

Re: [PATCH] Fix failing assertion in calls.c:store_unaligned_arguments_into_pseudos

2013-11-11 Thread Jeff Law
On 11/11/13 07:32, Ulrich Weigand wrote: Hello, when implementing the new ABI for powerpc64le-linux, I ran into an assertion failure in store_unaligned_arguments_into_pseudos: gcc_assert (args[i].partial % UNITS_PER_WORD == 0); This can happen in the new ABI since we pass "homogene

Re: RFC: simd enabled functions (omp declare simd / elementals)

2013-11-11 Thread Jakub Jelinek
On Mon, Nov 11, 2013 at 06:57:39PM +0100, Martin Jambor wrote: > > --- a/gcc/ipa-prop.h > > +++ b/gcc/ipa-prop.h > > @@ -609,6 +609,31 @@ extern alloc_pool ipcp_values_pool; > > extern alloc_pool ipcp_sources_pool; > > extern alloc_pool ipcp_agg_lattice_pool; > > > > +/* Operation to be perform

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 9:41 AM, Eric Botcazou wrote: >> But throw what? It is up to the runtimes of -fnon-call-exceptions languages >> to decide if they actually want to throw or do something else in the signal >> handlers, and what exactly to throw. > > Throw nothing per se, __builtin_throw wou

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-11 Thread Rong Xu
On Mon, Nov 11, 2013 at 7:02 AM, Jan Hubicka wrote: >> 2013-11-04 Rong Xu >> >> * libgcc/libgcov.c: Delete as part of re-factoring. >> * libgcc/libgcov-profiler.c (__gcov_interval_profiler): Moved from >> libgcov.c >> (__gcov_pow2_profiler): Ditto. >> (__gcov_one_v

Re: PR37132 – RFC patch for generation of DWARF symbol for Fortran's namelists (DW_TAG_namelist)

2013-11-11 Thread Cary Coutant
> But for "USE mod_name, only: nml", one is supposed to generate a > DW_TAG_imported_declaration. > > And there I am stuck. For normal variables, the DW_TAG_imported_declaration > refers to a DW_TAG_variable die. Analogously, for a namelist one would have > to refer to a DW_TAG_namelist die. But su

Re: PATCH: other/59039: Undocumented __builtin_longjmp/__builtin_setjmp

2013-11-11 Thread Mike Stump
On Nov 10, 2013, at 8:28 AM, H.J. Lu wrote: > This patch documents __builtin_setjmp and __builtin_longjmp. OK to > install? I like it. I think these two should be documented.

Re: PING Cilk Plus failures on non-LTO targets

2013-11-11 Thread Mike Stump
On Nov 11, 2013, at 8:35 AM, David Edelsohn wrote: > I continue to see extra Cilk Plus failures on AIX. Tests that require > LTO should check that the target supports LTO. Iyer, sprinkle /* { dg-require-effective-target lto } */ on those test cases and see if they then work ok as expected.

Re: RFC: simd enabled functions (omp declare simd / elementals)

2013-11-11 Thread Martin Jambor
Hi, thanks for the followup. I like it, I only don't understand... On Fri, Nov 08, 2013 at 10:48:43AM -0700, Aldy Hernandez wrote: > On 11/07/13 09:09, Martin Jambor wrote: > <...> > --- a/gcc/ipa-prop.h > +++ b/gcc/ipa-prop.h > @@ -609,6 +609,31 @@ extern alloc_pool ipcp_values_pool; > exte

Re: [PATCH] Time profiler - phase 1

2013-11-11 Thread Martin Liška
On 11 November 2013 15:57, Jan Hubicka wrote: >> +2013-10-29 Martin Liska >> + Jan Hubicka >> + >> + * cgraph.c (dump_cgraph_node): Profile dump added. >> + * cgraph.h (struct cgraph_node): New time profile variable added. >> + * cgraphc

Go patch committed: Check for nil pointers when taking address

2013-11-11 Thread Ian Lance Taylor
In Go 1.2 the language was changed slightly to prohibit taking the address of a field in a struct given a nil pointer to the struct (http://golang.org/s/go12nil). This patch by Chris Manghane implements that check in gccgo. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed

Re: Fix for PR c++/59031

2013-11-11 Thread Easwaran Raman
Ping. On Thu, Nov 7, 2013 at 11:14 AM, Easwaran Raman wrote: > Before r193504, if a method can not be overridden, LOOKUP_NONVIRTUAL > is set and the call is direct. The changes at r193504 (to fix PR > c++/11750) caused a regression to this behavior. This patch attempts > to fix that. Bootstraps

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Eric Botcazou
> But throw what? It is up to the runtimes of -fnon-call-exceptions languages > to decide if they actually want to throw or do something else in the signal > handlers, and what exactly to throw. Throw nothing per se, __builtin_throw would simply trap and ensure that the exception thrown by the s

Re: [PATCH] make has_gate and has_execute useless

2013-11-11 Thread Paolo Bonzini
Il 08/11/2013 10:37, Richard Biener ha scritto: > /* If we have a gate, combine the properties that we could have with > and without the pass being examined. */ > if (pass->has_gate) > properties &= new_properties; > else > properties = new_properties; >

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-11 Thread Teresa Johnson
On Mon, Nov 11, 2013 at 9:13 AM, Jan Hubicka wrote: >> On Mon, Nov 11, 2013 at 8:22 AM, Jan Hubicka wrote: >> >> I have a warning like that already in drop_profile(). Is that >> > >> > I think it should be warning (or silent) for COMDAT and error/note for >> > other functions (depending on flag_p

Re: [gomp4] rewrite simd clone argument adjustment to avoid regimplification

2013-11-11 Thread Aldy Hernandez
On 11/07/13 10:58, Martin Jambor wrote: Sorry for the delay. I'd just like to re-iterate one comment from my previous email which is that I do not think tree-sra.c should export any function to the outside world apart from the entry points of the passes (yes, there is already build_ref_for_offs

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-11 Thread Jan Hubicka
> On Mon, Nov 11, 2013 at 8:22 AM, Jan Hubicka wrote: > >> I have a warning like that already in drop_profile(). Is that > > > > I think it should be warning (or silent) for COMDAT and error/note for > > other functions (depending on flag_profile_correction). > > I guess drop_profile is better pla

Re: [PATCH] Optional alternative base_expr in finding basis for CAND_REFs

2013-11-11 Thread Bill Schmidt
Hi Yufeng, The idea is a good one but I don't like your implementation of adding an extra expression parameter to look at on the find_basis_for_candidate lookup. This goes against the design of the pass and may not be sufficiently general (might there be situations where a third possible basis co

Re: [patch] Fix PR ada/35998

2013-11-11 Thread Eric Botcazou
> Due to the different interfaces of int_size_in_bytes and > simple_type_size_in_bits (and 'size' in add_byte_size_attribute being > unsigned and not [unsigned] HWI) it would be cleaner to > add an early return after the call to int_size_in_bytes if its > return value is -1 (and make sure the retur

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-11 Thread Teresa Johnson
On Mon, Nov 11, 2013 at 8:22 AM, Jan Hubicka wrote: >> I have a warning like that already in drop_profile(). Is that > > I think it should be warning (or silent) for COMDAT and error/note for > other functions (depending on flag_profile_correction). > I guess drop_profile is better place for it in

Re: [patch] Add CONSTRUCTOR_NO_CLEARING flag

2013-11-11 Thread Eric Botcazou
> Ok. Can you update doc/generic.texi? Thanks, done (it was still talking about TREE_LIST). -- Eric Botcazou

Re: PING Cilk Plus failures on non-LTO targets

2013-11-11 Thread David Edelsohn
On Mon, Nov 4, 2013 at 11:06 AM, David Edelsohn wrote: > Balaji, > > I am seeing a large number of libcilkrts failures on AIX. These all > are of the form: > > Executing on host: /tmp/20131103/gcc/xgcc -B/tmp/20131103/gcc/ > /nasfarm/edelsohn > /src/src/gcc/testsuite/c-c++-common/cilk-plus/CK/sy

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Ian Lance Taylor
On Mon, Nov 11, 2013 at 8:27 AM, Jakub Jelinek wrote: > On Mon, Nov 11, 2013 at 09:24:27AM -0700, Jeff Law wrote: >> On 11/11/13 02:33, Eric Botcazou wrote: >> >>However, that brings up an couple interesting questions. >> >> >> >>Let's say we find a NULL pointer which reaches a return statement in

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Jakub Jelinek
On Mon, Nov 11, 2013 at 09:24:27AM -0700, Jeff Law wrote: > On 11/11/13 02:33, Eric Botcazou wrote: > >>However, that brings up an couple interesting questions. > >> > >>Let's say we find a NULL pointer which reaches a return statement in a > >>function which is marked as returns_nonnull. In that

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Jeff Law
On 11/11/13 02:33, Eric Botcazou wrote: However, that brings up an couple interesting questions. Let's say we find a NULL pointer which reaches a return statement in a function which is marked as returns_nonnull. In that case there is no dereference. Presumably for that kind of scenario we'll

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-11 Thread Jan Hubicka
> I have a warning like that already in drop_profile(). Is that I think it should be warning (or silent) for COMDAT and error/note for other functions (depending on flag_profile_correction). I guess drop_profile is better place for it indeed. > sufficient? Also, Steven Bosscher suggested putting

Re: [PATCH] Fix asan regtest failures c-c++-common/asan/{memcmp-1.c,strncpy-overflow-1.c}

2013-11-11 Thread Dodji Seketeli
Jakub Jelinek writes: > On Mon, Nov 11, 2013 at 03:01:53PM +0100, Dodji Seketeli wrote: >> Since a couple of days I am seeing failure on the tests above on my >> Fedora system. The errors look like: >> >> FAIL: c-c++-common/asan/memcmp-1.c -O0 output pattern test, is >> =

Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals

2013-11-11 Thread Dodji Seketeli
Jakub Jelinek writes: >> -OBJS-libcommon = diagnostic.o diagnostic-color.o pretty-print.o intl.o >> input.o version.o >> +OBJS-libcommon = diagnostic.o diagnostic-color.o pretty-print.o intl.o >> vec.o input.o version.o > > Too long line? Fixed in my local copy of the patch, thanks. > >> +

Re: [PATCH] make has_gate and has_execute useless

2013-11-11 Thread Trevor Saunders
On Mon, Nov 11, 2013 at 12:58:36PM +0100, Richard Biener wrote: > On Mon, Nov 11, 2013 at 1:39 AM, Trevor Saunders > wrote: > > On Fri, Nov 08, 2013 at 10:37:00AM +0100, Richard Biener wrote: > >> On Thu, Nov 7, 2013 at 5:00 PM, wrote: > >> > From: Trevor Saunders > >> > > >> > Hi, > >> > > >>

Re: [RFA][PATCH] Isolate erroneous paths optimization

2013-11-11 Thread Jeff Law
On 11/11/13 05:16, Richard Biener wrote: On Mon, Nov 11, 2013 at 4:11 AM, Jeff Law wrote: On 11/10/13 05:34, Eric Botcazou wrote: But I think that you cannot transform foo () { *0 = 1; } to __builtin_trap as you can catch the trap via an exception handler in a caller of foo, no? Th

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-11 Thread Teresa Johnson
On Mon, Nov 11, 2013 at 7:23 AM, Jan Hubicka wrote: >> 2013-11-08 Teresa Johnson >> Jan Hubicka >> >> * predict.c (drop_profile): New function. >> (handle_missing_profiles): Ditto. >> (counts_to_freqs): Don't overwrite estimated frequencies >> when

[gomp4] Fix two typos

2013-11-11 Thread Jakub Jelinek
Hi! Dunno how I've managed to break the branch on Friday, anyway, here is an obvious fix, committed to the branch. 2013-11-11 Jakub Jelinek * tree-vect-data-refs.c (vect_analyze_data_refs): Check loop->safelen rather than loop->simdlen. * tree-vect-stmts.c (vectorizabl

Re: Some wide-int review comments

2013-11-11 Thread Kenneth Zadeck
On 11/11/2013 10:29 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 4:04 PM, Kenneth Zadeck wrote: On 11/11/2013 09:42 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck wrote: On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zad

Re: Some wide-int review comments

2013-11-11 Thread Kenneth Zadeck
On 11/11/2013 10:04 AM, Kenneth Zadeck wrote: On 11/11/2013 09:42 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck wrote: On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck wrote: On 11/08/2013 05:30 AM, Richard Sandiford w

Re: Some wide-int review comments

2013-11-11 Thread Richard Biener
On Mon, Nov 11, 2013 at 4:04 PM, Kenneth Zadeck wrote: > On 11/11/2013 09:42 AM, Richard Biener wrote: >> >> On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck >> wrote: >>> >>> On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck wrote: >

Re: [PATCH] decide edge's hotness when there is profile info

2013-11-11 Thread Jan Hubicka
> 2013-11-08 Teresa Johnson > Jan Hubicka > > * predict.c (drop_profile): New function. > (handle_missing_profiles): Ditto. > (counts_to_freqs): Don't overwrite estimated frequencies > when function has no profile counts. > * predict.h (hand

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-11 Thread Jan Hubicka
> Here is the patch that includes profile-tool. > Profile-tool now has two functions: merge and rewrite. I'll add diff later. > > Compiler is tested with spec2006 and profiledbootstrap. > profile-tool is tested with spec2006 profiles. Hi, it would be nice if you could elaborate bit more on the to

Recent Go patch broke CentOS 5.10 bootstrap

2013-11-11 Thread Uros Bizjak
Hello! Building latest gcc+go on CentOS 5.10 breaks with following build failure: ../../../gcc-svn/trunk/libgo/go/net/fd_unix.go:414:72: error: reference to undefined identifier ‘syscall.F_DUPFD_CLOEXEC’ r0, _, e1 := syscall.Syscall(syscall.SYS_FCNTL, uintptr(fd), syscall.F_DUPFD_CLOEXEC, 0)

Re: [PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-11-11 Thread Richard Biener
On Mon, Nov 11, 2013 at 3:45 PM, Ilya Enkovich wrote: > 2013/11/11 Richard Biener : >> On Mon, Nov 11, 2013 at 3:00 PM, Ilya Enkovich >> wrote: >>> 2013/11/11 Richard Biener : On Fri, Nov 8, 2013 at 11:03 AM, Ilya Enkovich wrote: > 2013/11/8 Richard Biener : >> On Thu, Nov 7,

Re: Some wide-int review comments

2013-11-11 Thread Kenneth Zadeck
On 11/11/2013 09:42 AM, Richard Biener wrote: On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck wrote: On 11/11/2013 06:49 AM, Richard Biener wrote: On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck wrote: On 11/08/2013 05:30 AM, Richard Sandiford wrote: From tree-vrp.c: @@ -1893,6 +1884,10

Re: [RFC] libgcov.c re-factoring and offline profile-tool

2013-11-11 Thread Jan Hubicka
> 2013-11-04 Rong Xu > > * libgcc/libgcov.c: Delete as part of re-factoring. > * libgcc/libgcov-profiler.c (__gcov_interval_profiler): Moved from > libgcov.c > (__gcov_pow2_profiler): Ditto. > (__gcov_one_value_profiler_body): Ditto. > (__gcov_one_value_profi

Re: [PATCH] Time profiler - phase 1

2013-11-11 Thread Jan Hubicka
> +2013-10-29 Martin Liska > + Jan Hubicka > + > + * cgraph.c (dump_cgraph_node): Profile dump added. > + * cgraph.h (struct cgraph_node): New time profile variable added. > + * cgraphclones.c (cgraph_clone_node): Time profile is cloned.

[PATCH, rs6000] ELFv2 ABI 8/8: Enable by default on little-endian

2013-11-11 Thread Ulrich Weigand
Hello, this patch finally throws the switch and enables the ELFv2 ABI by default on powerpc64le-linux. Bye, Ulrich ChangeLog: 2013-11-11 Ulrich Weigand * config/rs6000/sysv4le.h (LINUX64_DEFAULT_ABI_ELFv2): Define. Index: gcc/gcc/config/rs6000/sysv4le.h ==

[PATCH, rs6000] ELFv2 ABI 6/8: Eliminate register save area in some cases

2013-11-11 Thread Ulrich Weigand
Hello, the final area of changes implemented by the ELFv2 ABI is stack space consumption. Reducing the miminum stack size requirements is important for environments where stack space is restricted, e.g. Linux kernel code, or where we have a large number of stacks (e.g. heavily multi-threaded appl

Re: [PATCH, MPX, 2/X] Pointers Checker [10/25] Calls copy and verification

2013-11-11 Thread Ilya Enkovich
2013/11/11 Richard Biener : > On Mon, Nov 11, 2013 at 3:00 PM, Ilya Enkovich wrote: >> 2013/11/11 Richard Biener : >>> On Fri, Nov 8, 2013 at 11:03 AM, Ilya Enkovich >>> wrote: 2013/11/8 Richard Biener : > On Thu, Nov 7, 2013 at 7:55 PM, Jeff Law wrote: >> On 11/07/13 04:50, Ilya E

[PATCH, rs6000] ELFv2 ABI 5/8: Struct return calling convention changes

2013-11-11 Thread Ulrich Weigand
Hello, analogously to the previous patch handling homogeneous aggregates as arguments, this patch handles such aggregates as return values. In addition, the ELFv2 ABI returns any aggregate of up to 16 bytes in size (that is not otherwise handled) in up to two GPRs. In either case, the return val

[PATCH, rs6000] ELFv2 ABI 7/8: Eliminate some stack frame fields

2013-11-11 Thread Ulrich Weigand
Hello, this is the second part of reducing stack space consumption for the ELFv2 ABI: the old ABI reserved six words in every stack frame for various purposes, and two of those were basically unused: one word for "compiler use" and one word for "linker use". Since neither the compiler nor the lin

[PATCH, rs6000] ELFv2 ABI 4/8: Struct passing calling convention changes

2013-11-11 Thread Ulrich Weigand
Hello, this patch implements the new struct calling convention for ELFv2. With the new ABI, so-called "homogeneous" aggregates, i.e. struct, arrays, or unions that (recursively) contain only elements of the same floating- point or vector type are passed as if those elements were passed as separat

[PATCH, rs6000] ELFv2 ABI 1/8: Add options and infrastructure

2013-11-11 Thread Ulrich Weigand
Hello, this is the first patch in the series to add support for the ELFv2 ABI. The ELFv2 ABI is the intended ABI for the new powerpc64le-linux port. However, it is not inherently tied to the byte order; it it possible in principle to use the ELFv2 ABI in big-endian mode too. Therefore, it is int

Re: Some wide-int review comments

2013-11-11 Thread Richard Biener
On Mon, Nov 11, 2013 at 3:26 PM, Kenneth Zadeck wrote: > On 11/11/2013 06:49 AM, Richard Biener wrote: >> >> On Sat, Nov 9, 2013 at 3:23 PM, Kenneth Zadeck >> wrote: >>> >>> On 11/08/2013 05:30 AM, Richard Sandiford wrote: From tree-vrp.c: @@ -1893,6 +1884,10 @@ vrp_int_cons

Re: PING^3 Re: [PATCH] Add -fno-instrument-function v2

2013-11-11 Thread Andi Kleen
Andi Kleen writes: PING^3 Since it doesn't look like a generic solution for the LTO options problem will appear this development cycle, I would still like to pursue this option for 4.9. This would help fixing parts of the linux kernel LTO build. Can someone please review the patch? Thanks >

[PATCH, rs6000] ELFv2 ABI 2/8: Remove function descriptors

2013-11-11 Thread Ulrich Weigand
Hello, this patch adds the first major feature of the ELFv2 ABI: removal of function descriptors. In the current ABI, it is the responsibility of a caller to set up the TOC pointer needed by the callee by loading the correct value into r2. This typically happens in one of these ways: - For a d

[PATCH, rs6000] ELFv2 ABI 3/8: Track single CR fields in DWARF CFI

2013-11-11 Thread Ulrich Weigand
Hello, this patch adds another ELFv2 ABI feature: explicit tracking of CR fields in DWARF CFI. In the current ABI, DWARF CFI contains only a single record describing the save location of the whole CR field. It is implicit that all (or at least all call-clobbered) fields are present at that locat

Re: RFA: Fix PR middle-end/59049

2013-11-11 Thread Jakub Jelinek
On Fri, Nov 08, 2013 at 05:11:39PM +, Joern Rennecke wrote: > On 8 November 2013 15:50, Steven Bosscher wrote: > > Even with the gimple opts disabled, a const-const comparison would > > normally be folded by the RTL expanders. > > Well, in this spirit, attached is another way to address the R

  1   2   >