> -----Original Message-----
> From: David Edelsohn [mailto:[email protected]]
> Sent: Monday, November 11, 2013 11:36 AM
> To: Iyer, Balaji V
> Cc: GCC Patches; Joseph S. Myers
> Subject: Re: PING Cilk Plus failures on non-LTO targets
>
> On Mon, Nov 4, 2013 at 11:06 AM, David Edelsohn <[email protected]>
> wrote:
> > Balaji,
> >
> > I am seeing a large number of libcilkrts failures on AIX. These all
> > are of the form:
> >
> > Executing on host: /tmp/20131103/gcc/xgcc -B/tmp/20131103/gcc/
> > /nasfarm/edelsohn /src/src/gcc/testsuite/c-c++-common/cilk-
> plus/CK/sync_wo_spawn.c -fno-diagnosti
> > cs-show-caret -fdiagnostics-color=never -O0 -flto -g -fcilkplus -
> L/tmp/2013110
> > 3/powerpc-ibm-aix7.1.0.0/./libcilkrts/.libs -fcilkplus -S -o
> > sync_wo_spawn.s (timeout = 300)
> > cc1: error: LTO support has not been enabled in this configuration
> > compiler exited with status 1
> >
> > If the feature / functionality requires LTO, the tests should check
> > that LTO is supported with check_effective_target_lto, either in each
> > relevant test or in cilk-plus.exp.
>
> Balaji,
>
> I continue to see extra Cilk Plus failures on AIX. Tests that require LTO
> should
> check that the target supports LTO.
>
Hi David,
Here is a patch that should fix this issue. Is this Patch OK to install?
Thanks,
Balaji V. iyer.
Index: testsuite/gcc.dg/cilk-plus/cilk-plus.exp
===================================================================
--- testsuite/gcc.dg/cilk-plus/cilk-plus.exp (revision 204591)
+++ testsuite/gcc.dg/cilk-plus/cilk-plus.exp (working copy)
@@ -18,6 +18,7 @@
load_lib gcc-dg.exp
+load_lib lto.exp
if { ![check_effective_target_cilkplus] } {
return;
@@ -48,8 +49,9 @@
dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] "
-O2 -std=c99 -fcilkplus $ALWAYS_CFLAGS" " "
dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] "
-O2 -ftree-vectorize -fcilkplus $ALWAYS_CFLAGS" " "
dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] "
-O3 -g -fcilkplus $ALWAYS_CFLAGS" " "
+if { [check_effective_target_lto] } {
dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] "
-O3 -flto -g -fcilkplus $ALWAYS_CFLAGS" " "
+}
-
dg-finish
Index: testsuite/ChangeLog
===================================================================
--- testsuite/ChangeLog (revision 204591)
+++ testsuite/ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2013-11-11 Balaji V. Iyer <[email protected]>
+
+ * gcc.dg/cilk-plus/cilk-plus.exp: Added a check for LTO before running
+ LTO tests.
+
2013-11-08 Cong Hou <[email protected]>
PR tree-optimization/58508
> Thanks, David
