Re: [PATCH] Keep REG_INC note in subreg2 pass

2013-10-30 Thread Zhenqiang Chen
On 31 October 2013 00:08, Jeff Law wrote: > On 10/30/13 00:09, Zhenqiang Chen wrote: >> >> On 30 October 2013 02:47, Jeff Law wrote: >>> >>> On 10/24/13 02:20, Zhenqiang Chen wrote: Hi, REG_INC note is lost in subreg2 pass when resolve_simple_move, which might lead t

Re: Pre-Patch RFC: proposed changes to option-lookup

2013-10-30 Thread Jeff Law
On 10/30/13 14:39, David Malcolm wrote: [Sending this to gcc-patches to double-check that the idea is sound before continuing to work on this large patch. [1] ] I want to eliminate hidden use of the preprocessor in our code, in favor of using block caps to signal to people reading the code that

[RFA][PATCH] Isolate erroneous paths optimization

2013-10-30 Thread Jeff Law
I've incorporated the various suggestions from Marc and Richi, except for Richi's to integrate this into jump threading. I've also made the following changes since the last version: 1. Added more testcases. 2. Use infer_nonnull_range, moving it from tree-vrp.c into gimple.c. Minor imp

ICE with "[PATCH, PR 10474] Split live-ranges of function arguments to help shrink-wrapping"

2013-10-30 Thread Hans-Peter Nilsson
> From: Jakub Jelinek > Date: Thu, 31 Oct 2013 00:16:41 +0100 > On Fri, Oct 25, 2013 at 05:19:06PM +0200, Martin Jambor wrote: > > 2013-10-23 Martin Jambor > > > > PR rtl-optimization/10474 > > * ira.c (find_moveable_pseudos): Do not calculate dominance info > > nor df analysis. >

Re: [PATCH][RFA] Improvements to infer_nonnull_range

2013-10-30 Thread Jeff Law
On 10/28/13 23:02, Jeff Law wrote: Based on a suggestion from Marc, I want to use infer_nonnull_range in the erroneous path isolation optimization. In the process of doing that, I found a few deficiencies in infer_nonnull_range that need to be addressed. First, infer_nonnull_range_p doesn't

Re: RFC: gimple.[ch] break apart

2013-10-30 Thread Jeff Law
On 10/30/13 21:18, Andrew MacLeod wrote: Hopefully the other attempts to send this aren't queued up... in any case, maybe I can't even attach a .dot file?... So no attachments this time... instead, the diagram is here: http://gcc.gnu.org/wiki/rearch?action=AttachFile&do=view&target=gimple.png

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Jeff Law
On 10/30/13 16:50, Steven Bosscher wrote: On Tue, Oct 29, 2013 at 4:12 PM, Vladimir Makarov wrote: Tomorrow I'd like commit the following patch. The patch removes regmove pass. I can barely hold my tears... of joy :-) Attached patch cleans up some left-overs. Nothing to test, really, a

RFC: gimple.[ch] break apart

2013-10-30 Thread Andrew MacLeod
Hopefully the other attempts to send this aren't queued up... in any case, maybe I can't even attach a .dot file?... So no attachments this time... instead, the diagram is here: http://gcc.gnu.org/wiki/rearch?action=AttachFile&do=view&target=gimple.png

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Vladimir Makarov
On 10/30/2013, 7:40 PM, David Edelsohn wrote: Where was this patch bootstrapped? This appears to have broken bootstrap on PowerPC (Linux and AIX) /nasfarm/edelsohn/src/src/libgcc/libgcov.c: In function 'gcov_exit': /nasfarm/edelsohn/src/src/libgcc/libgcov.c:827:1: internal compiler error: in up

patch to fix PR58933 (ppc bootstrap)

2013-10-30 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58933. The problem occurs for reload based targets. Successfully bootstrapped on ppc64. Committed as rev. 204245. 2013-10-30 Vladimir Makarov PR bootstrap/58933 * ira-color.c (update_costs_from_copies): A

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Vladimir Makarov
On 10/30/2013, 6:50 PM, Steven Bosscher wrote: On Tue, Oct 29, 2013 at 4:12 PM, Vladimir Makarov wrote: Tomorrow I'd like commit the following patch. The patch removes regmove pass. I can barely hold my tears... of joy :-) Attached patch cleans up some left-overs. Nothing to test, reall

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-30 Thread Jason Merrill
On 10/30/2013 12:15 PM, Marek Polacek wrote: On Wed, Oct 30, 2013 at 11:56:25AM -0400, Jason Merrill wrote: Saving 'size' here doesn't help since it's already been used above. Could you use itype instead of size here? I already experimented with that and I think I can't, since we call the fini

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-10-30 Thread Ramana Radhakrishnan
On Thu, Oct 31, 2013 at 12:29 AM, Cong Hou wrote: > On Tue, Oct 29, 2013 at 4:49 PM, Ramana Radhakrishnan > wrote: >> Cong, >> >> Please don't do the following. >> >>>+++ b/gcc/testsuite/gcc.dg/vect/ >> vect-reduc-sad.c >> @@ -0,0 +1,54 @@ >> +/* { dg-require-effective-target sse2 { target { i?86

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-30 Thread Sandra Loosemore
On 10/29/2013 02:51 AM, Bernd Edlinger wrote: On Mon, 28 Oct 2013 21:29:24, Sandra Loosemore wrote: On 10/28/2013 03:20 AM, Bernd Edlinger wrote: I have attached an update to your patch, that should a) fix the recursion problem. b) restrict the -fstrict-volatile-bitfields to not violate the C+

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-10-30 Thread Cong Hou
On Tue, Oct 29, 2013 at 4:49 PM, Ramana Radhakrishnan wrote: > Cong, > > Please don't do the following. > >>+++ b/gcc/testsuite/gcc.dg/vect/ > vect-reduc-sad.c > @@ -0,0 +1,54 @@ > +/* { dg-require-effective-target sse2 { target { i?86-*-* x86_64-*-* } } } */ > > you are adding a test to gcc.dg/ve

[rx] fix no-argument builtins

2013-10-30 Thread DJ Delorie
Apparently, there's a subtle difference between "function that takes no argument" and "function that takes void" :-P Committed. * config/rx/rx.c (ADD_RX_BUILTIN0): New macro, used for builtins that take no arguments. Index: config/rx/rx.c

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2013-10-30 Thread Cong Hou
On Wed, Oct 30, 2013 at 4:27 AM, Richard Biener wrote: > On Tue, 29 Oct 2013, Cong Hou wrote: > >> Hi >> >> SAD (Sum of Absolute Differences) is a common and important algorithm >> in image processing and other areas. SSE2 even introduced a new >> instruction PSADBW for it. A SAD loop can be great

[patch] make the libstdc++ pretty printers compatible with both Python 2 and Python3

2013-10-30 Thread Matthias Klose
Starting with gdb 7.6, gdb can be linked with both Python 2.x and Python 3.x. Therefore the pretty printers should be compatible with both Python versions. This patch should be backported to 4.7 and 4.8 as well. Ok for the trunk? Matthias * python/libstdcxx/v6/printers.py: Make prett

Go testsuite patch committed: Remove empty directory

2013-10-30 Thread Ian Lance Taylor
I removed the empty directory gcc/testsuite/go.test/test/fixedbugs/bug479.dir. Ian

Re: [PATCH, rs6000] Correct handling of multiply high-part for little endian

2013-10-30 Thread David Edelsohn
On Wed, Oct 30, 2013 at 6:55 PM, Bill Schmidt wrote: > Hi, > > When working around the peculiar little-endian semantics of the vperm > instruction, our usual fix is to complement the permute control vector > and swap the order of the two vector input operands, so that we get a > double-wide vector

Re: [RFC/CFT] auto-wipe dump files [was: Re: [committed] Fix up bb-slp-31.c testcase]

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 2:41 AM, Bernhard Reutner-Fischer wrote: >> I've noticed that this testcase doesn't clean up after itself. > This was nagging me last weekend.. ;) > What about automating this? So, the idea sounds very nice. One thing that I worry about is the testing speed hit for people (

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread David Edelsohn
Where was this patch bootstrapped? This appears to have broken bootstrap on PowerPC (Linux and AIX) /nasfarm/edelsohn/src/src/libgcc/libgcov.c: In function 'gcov_exit': /nasfarm/edelsohn/src/src/libgcc/libgcov.c:827:1: internal compiler error: in up date_costs_from_allocno, at ira-color.c:1334 -

Re: [PATCH] arm: emit neon alignment hints for 32/16-bit loads/stores

2013-10-30 Thread Ramana Radhakrishnan
Mans, Can you please follow the guidelines as in http://gcc.gnu.org/contribute.html ? Notably what's missing in your submission here is 1. A changelog entry - well I'll create one for you . (see below) 2. A note on how this was tested and what impact this has on any testcase that you have. 3. A c

Re: [PATCH, committed] libcilkrts - Add check for availability of alloca.h (Bug Bootstrap/58918)

2013-10-30 Thread Jakub Jelinek
On Wed, Oct 30, 2013 at 04:08:19PM -0700, Mike Stump wrote: > On Oct 30, 2013, at 3:49 PM, "Iyer, Balaji V" wrote: > > Yes, the library is compiled by GCC, but it is also used by LLVM and ICC. > > So, we would like to keep the same code base for all. > > Ah, dual use… that would explain it. Ce

Re: [PATCH, PR 10474] Split live-ranges of function arguments to help shrink-wrapping

2013-10-30 Thread Jakub Jelinek
On Fri, Oct 25, 2013 at 05:19:06PM +0200, Martin Jambor wrote: > 2013-10-23 Martin Jambor > > PR rtl-optimization/10474 > * ira.c (find_moveable_pseudos): Do not calculate dominance info > nor df analysis. > (interesting_dest_for_shprep): New function. > (split_liv

Re: [PATCH, committed] libcilkrts - Add check for availability of alloca.h (Bug Bootstrap/58918)

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 3:49 PM, "Iyer, Balaji V" wrote: > Yes, the library is compiled by GCC, but it is also used by LLVM and ICC. So, > we would like to keep the same code base for all. Ah, dual use… that would explain it. Certainly in that case the config hair is desirable, I mean, serves a p

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Marc Glisse
On Wed, 30 Oct 2013, Steven Bosscher wrote: Attached patch cleans up some left-overs. Nothing to test, really, as it's just comments and NOPs. OK for trunk? -would be better to run a full CSE/propogation pass on it through, or -re-run regmove, but that has not yet been attempted. +would be be

Re: Pre-Patch RFC: proposed changes to option-lookup

2013-10-30 Thread Joseph S. Myers
On Wed, 30 Oct 2013, David Malcolm wrote: > My idea is to introduce a GCC_OPTION macro, and replace the above with: > > static bool > gate_vrp (void) > { > return GCC_OPTION (flag_tree_vrp) != 0; > } That's only slightly shorter than the full expansion using global_options; I'd pref

[PATCH, rs6000] Correct handling of multiply high-part for little endian

2013-10-30 Thread Bill Schmidt
Hi, When working around the peculiar little-endian semantics of the vperm instruction, our usual fix is to complement the permute control vector and swap the order of the two vector input operands, so that we get a double-wide vector in the proper order. We don't want to swap the operands when we

Re: C++14 digit separators..

2013-10-30 Thread Ed Smith-Rowland
On 10/28/2013 09:44 AM, Jason Merrill wrote: On 10/28/2013 09:10 AM, Joseph S. Myers wrote: On Sun, 27 Oct 2013, Ed Smith-Rowland wrote: Here is an implementation for C++14 digit separators (single quote). I tend to think that such features should come with a test that the feature is not ena

Re: patch to improve register preferencing in IRA and to *remove regmove* pass

2013-10-30 Thread Steven Bosscher
On Tue, Oct 29, 2013 at 4:12 PM, Vladimir Makarov wrote: > Tomorrow I'd like commit the following patch. > > The patch removes regmove pass. I can barely hold my tears... of joy :-) Attached patch cleans up some left-overs. Nothing to test, really, as it's just comments and NOPs. OK for trunk

RE: [PATCH, committed] libcilkrts - Add check for availability of alloca.h (Bug Bootstrap/58918)

2013-10-30 Thread Iyer, Balaji V
> -Original Message- > From: Mike Stump [mailto:mikest...@comcast.net] > Sent: Wednesday, October 30, 2013 6:48 PM > To: Iyer, Balaji V > Cc: 'ger...@pfeifer.com'; Jeff Law; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, committed] libcilkrts - Add check for availability of > alloca.h >

Re: [PATCH, committed] libcilkrts - Add check for availability of alloca.h (Bug Bootstrap/58918)

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 3:40 PM, "Iyer, Balaji V" wrote: > This attached patch will check for usage of alloca.h before using it. > The change is entirely in libcilkrts and I am committing this change as it is > pretty obvious. Uh, no? Usually runtimes are compiled by the built compiler?! T

RE: [PATCH, committed] libcilkrts - Add check for availability of alloca.h (Bug Bootstrap/58918)

2013-10-30 Thread Iyer, Balaji V
Err... I meant to say "...*availability* of alloca.h before using it..." > -Original Message- > From: Iyer, Balaji V > Sent: Wednesday, October 30, 2013 6:41 PM > To: 'ger...@pfeifer.com' > Cc: Jeff Law; 'gcc-patches@gcc.gnu.org' > Subject: [PATCH, committed] libcilkrts - Add check for ava

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 3:15 PM, Marek Polacek wrote: > I had a quick look at the CLEANUP_STMT and cp-tree.def says > "A CLEANUP_STMT marks the point at which a declaration is fully > constructed.", while doc says > "Used to represent an action that should take place upon exit from the > enclosing sco

[PATCH, committed] libcilkrts - Add check for availability of alloca.h (Bug Bootstrap/58918)

2013-10-30 Thread Iyer, Balaji V
Hello Everyone, This attached patch will check for usage of alloca.h before using it. The change is entirely in libcilkrts and I am committing this change as it is pretty obvious (the change was lifted from the autconf manual example). Thanks, Balaji V. Iyer. Index: libcilkrts/configu

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 3:14 PM, Bernhard Reutner-Fischer wrote: > On 30 October 2013 22:47, Mike Stump wrote: >> >> Was there a significant purpose for the added C++ comment? If not, can you >> remove that? If so, can you explain? > > grep -A9 "CONTENTS is" gcc/testsuite/lib/target-supports.ex

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-30 Thread Marek Polacek
Thanks Mike. I had a quick look at the CLEANUP_STMT and cp-tree.def says "A CLEANUP_STMT marks the point at which a declaration is fully constructed.", while doc says "Used to represent an action that should take place upon exit from the enclosing scope. Typically, these actions are calls to dest

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-30 Thread Bernhard Reutner-Fischer
On 30 October 2013 22:47, Mike Stump wrote: > On Oct 30, 2013, at 2:56 AM, Bernhard Reutner-Fischer > wrote: >> - set result [check_compile pchtest object "int i;" "-x c-header"] >> + set result [check_compile pchtest object "$chk_type" "$chk_lang"] > > the patch uses chk_type, but, I ca

[v3 patch] enable commented out tests

2013-10-30 Thread Jonathan Wakely
GCC allows arithmetic on void pointers so std::atomic does too, but the VERIFY checks in this test were commented out, probably because they failed due to using sizeof(void*) when they should have used sizeof(void), which is 1. 2013-10-30 Jonathan Wakely * testsuite/29_atomics/atomic/opera

Re: Pre-Patch RFC: proposed changes to option-lookup

2013-10-30 Thread Steven Bosscher
On Wed, Oct 30, 2013 at 9:39 PM, David Malcolm wrote: > I want to eliminate hidden use of the preprocessor in our code, in favor > of using block caps to signal to people reading the code that macro > magic is happening. Good idea. In the past this kind of change would be sort-of controversial (l

Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 2:56 AM, Bernhard Reutner-Fischer wrote: > - set result [check_compile pchtest object "int i;" "-x c-header"] > + set result [check_compile pchtest object "$chk_type" "$chk_lang"] the patch uses chk_type, but, I can't find where it is being set? Was there a significa

Pre-Patch RFC: proposed changes to option-lookup

2013-10-30 Thread David Malcolm
[Sending this to gcc-patches to double-check that the idea is sound before continuing to work on this large patch. [1] ] I want to eliminate hidden use of the preprocessor in our code, in favor of using block caps to signal to people reading the code that macro magic is happening. As a specific e

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Joseph S. Myers
On Wed, 30 Oct 2013, Tobias Burnus wrote: > On the other hand, one could use the existence of libcilkrts* as detected by > the patch to decide whether to link or not: If the library is there, one can > link – if not found, it is unlikely to work (unless it is, e.g. found in > /usr/lib). The way t

Re: RFA [reload]: Fix PR other/58545

2013-10-30 Thread Jeff Law
On 10/03/13 14:23, Joern Rennecke wrote: 2013-10-02 Joern Rennecke PR other/58545 * reload1.c (update_eliminables_and_spill): New function, broken out of reload. (reload): Use it. Check for frame size change after frame size alignment, and call update_e

[PATCH] arm: emit neon alignment hints for 32/16-bit loads/stores

2013-10-30 Thread Mans Rullgard
--- gcc/config/arm/arm.c | 4 1 file changed, 4 insertions(+) diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 8c9897e..8183a8e 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -21247,6 +21247,10 @@ arm_print_operand (FILE *stream, rtx x, int code) alig

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-30 Thread Mike Stump
On Oct 30, 2013, at 9:15 AM, Marek Polacek wrote: > I admit I don't understand the cleanup_points very much and I don't > know exactly where they are coming from So, here is the mental model… and how it is related to the standard. C++ mandates that destructors for objects and temporary objects

Re: [PATCH] decide edge's hotness when there is profile info

2013-10-30 Thread Teresa Johnson
On Fri, Oct 18, 2013 at 2:17 PM, Jan Hubicka wrote: >> Here is the patch updated to use the new parameter from r203830. >> Passed bootstrap and regression tests. >> >> 2013-10-18 Jan Hubicka >> Teresa Johnson >> >> * predict.c (handle_missing_profiles): New function. >>

Re: [PATCH 1/n] Add conditional compare support

2013-10-30 Thread Richard Henderson
> +/* RCODE0, RCODE1 and a valid return value should be enum rtx_code. > + TCODE should be enum tree_code. > + Check whether two compares are a valid combination in the target to > generate > + a conditional compare. If valid, return the new compare after > combination. > + */ > +DEFHOOK

Re: RFA [reload]: Fix PR other/58545

2013-10-30 Thread Jeff Law
On 10/11/13 08:40, Joern Rennecke wrote: On 11 October 2013 04:53, Jeff Law wrote: > With your change it seems to me that we do a single round of spilling & caller-save setup, then align the stack, then restart. The net result being we align the stack a lot more often. Yes, but AFAICT, tha

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-30 Thread Cong Hou
I have run check_GNU_style.sh on my patch. The patch is submitted. Thank you for your comments and help on this patch! thanks, Cong On Wed, Oct 30, 2013 at 11:13 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 7:01 PM, Cong Hou wrote: > I found my problem: I put DONE outside of if not

Re: PATCH to use -Wno-format during stage1

2013-10-30 Thread Ian Lance Taylor
On Wed, Oct 30, 2013 at 8:47 AM, Jason Merrill wrote: > I find -Wformat warnings about unknown % codes when building with an older > GCC to be mildly annoying noise; this patch avoids them by passing > -Wno-format during stage 1. > > Tested x86_64-pc-linux-gnu. Is this OK for trunk? Do you have

Two tiny C++ cleanup PATCHes

2013-10-30 Thread Jason Merrill
1) We want to skip anonymous structs when pushing member cleanups, too. 2) We shouldn't create a static variable for a compound literal in e.g. sizeof. I don't think either of these will actually affect compiler output, they're just cleanups I noticed while working on other things. Tested x8

[v3 patch] Extend smart ptr assertions to reject void*

2013-10-30 Thread Jonathan Wakely
Because of the GNU extension that allows sizeof(void) we fail to reject ill-formed programs. This patch fixes that. 2013-10-30 Jonathan Wakely * include/bits/shared_ptr (__shared_ptr): Assert non-void pointer. * include/bits/shared_ptr (default_delete): Likewise. * incl

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-30 Thread Jeff Law
On 10/30/13 12:12, Ilya Enkovich wrote: GIMPLE layout depending on flag_check_pointer_bounds sounds like a recipie for desaster if you consider TUs compiled with and TUs compiled without and LTO. Or if you consider using optimized attribute with that flag. Sorry, I don't follow. Can you elabo

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 04:34, Tobias Burnus wrote: Without that patch, which I have copied from asan-dg.exp, I get tons of failures because "ld" cannot find libcilkrts. OK for committal? Tobias cilk.diff 2013-10-30 Tobias Burnus * gcc.dg/cilk-plus/cilk-plus.exp: Add the libcilkrts library

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 13:27, Iyer, Balaji V wrote: * * * Actually, I was wondering whether -fcilkplus should always automatically link libcilkrts - akin to -fopenmp which links libgomp. Currently, one has to specify it manually.* Yes, I would like that to happen. Do you have any pointers about how to d

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Tobias Burnus
Iyer, Balaji V wrote: * * * Actually, I was wondering whether -fcilkplus should always automatically link libcilkrts - akin to -fopenmp which links libgomp. Currently, one has to specify it manually.* Yes, I would like that to happen. Do you have any pointers about how to do that? Well, if y

Re: [C++ Patch] PR 58581

2013-10-30 Thread Jason Merrill
OK. Jason

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Iyer, Balaji V
> * * * > > Actually, I was wondering whether -fcilkplus should always automatically link > libcilkrts - akin to -fopenmp which links libgomp. Currently, one has to > specify it > manually.* Yes, I would like that to happen. Do you have any pointers about how to do that?

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Tobias Burnus
Iyer, Balaji V wrote: What I ideally wanted to do with my testsuite files was that I want all the Cilk keywords test to compile no matter what the architecture is, but it should only run in certain architectures where the runtime is enabled (this is known statically and thus the testsuite doesn

Re: [PATCH][RFC] fix reload causing ICE in subreg_get_info on m68k (PR58369)

2013-10-30 Thread Jeff Law
On 10/18/13 14:17, Mikael Pettersson wrote: > Thanks Mikael. My only concern is the lack of adjustment when the value > found was already a SUBREG. > > ie, let's assume rld[r].in_reg was something like > (subreg:XF (reg:DF) 0) > > and our target is (reg:DF) > > In this case it

[C++ Patch] PR 58581

2013-10-30 Thread Paolo Carlini
Hi, to resolve this simple ICE we only have to check the return value of mark_used, like we do in a number of other places. Tested x86_64-linux. Thanks! Paolo. / /cp 2013-10-30 Paolo Carlini PR c++/58581 * call.c (build_over_call): Check return valu

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-30 Thread Ilya Enkovich
2013/10/30 Jeff Law : > On 10/30/13 04:34, Ilya Enkovich wrote: >> >> On 30 Oct 10:26, Richard Biener wrote: >>> >>> >>> Ick - you enlarge all return statements? But you don't set the >>> actual value? So why allocate it with 2 ops in the first place?? >> >> >> When return does not return bounds i

Re: C++ PATCH to deal with trivial but non-callable [cd]tors

2013-10-30 Thread Eric Botcazou
> > +/* Return whether DECL, a method of a C++ TYPE, is trivial, that is to > > say + doesn't do anything for the objects of TYPE. */ > > + > > +static bool > > +is_trivial_method (const_tree decl, const_tree type) > > +{ > > + if (cpp_check (decl, IS_CONSTRUCTOR) && !TYPE_NEEDS_CONSTRUCTING >

Re: [wide-int] Update main comment

2013-10-30 Thread Richard Sandiford
Kenneth Zadeck writes: > On 10/30/2013 07:01 AM, Richard Sandiford wrote: >> Kenneth Zadeck writes: >>> On 10/29/2013 06:37 PM, Richard Sandiford wrote: This patch tries to update the main wide_int comment to reflect the current implementation. - bitsizetype is TImode on x86_6

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-30 Thread Uros Bizjak
On Wed, Oct 30, 2013 at 7:01 PM, Cong Hou wrote: >>> I found my problem: I put DONE outside of if not inside. You are >>> right. I have updated my patch. >> >> OK, great that we put things in order ;) >> >> Does this patch need some extra middle-end functionality? I was not >> able to vectorize c

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-30 Thread Ilya Enkovich
On 30 Oct 11:40, Jeff Law wrote: > On 10/30/13 04:48, Richard Biener wrote: > >foo (int * p, unsigned int size) > >{ > >__bound_tmp.0; > > long unsigned int D.2239; > > long unsigned int _2; > > sizetype _6; > > int * _7; > > > > : > > __bound_tmp.0_4 = __builtin_ia32_arg_bnd (p_3(D

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-30 Thread Cong Hou
Also, as the current expand for abs() on 8/16bit integer is not used at all, should I comment them temporarily now? Later I can uncomment them once I finished the pattern recognizer. thanks, Cong On Wed, Oct 30, 2013 at 10:22 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 6:01 PM, Cong Hou

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-30 Thread Cong Hou
On Wed, Oct 30, 2013 at 10:22 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 6:01 PM, Cong Hou wrote: >> I found my problem: I put DONE outside of if not inside. You are >> right. I have updated my patch. > > OK, great that we put things in order ;) > > Does this patch need some extra middle-en

Re: RFA: patch to fix PR58785 (an ARM LRA crash)

2013-10-30 Thread Richard Earnshaw (home)
On 30 Oct 2013, at 08:16, "Vladimir Makarov" wrote: > The following patch fixes: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58785 > > LRA chooses constraint 'm' for const_int operand. It means that the > const_int should be placed in memory but it does not happen as preferred > reload c

Re: [RFC PATCH] For TARGET_AVX use *mov_internal for misaligned loads

2013-10-30 Thread Uros Bizjak
On Wed, Oct 30, 2013 at 6:42 PM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 12:11 PM, Jakub Jelinek wrote: > >>> > Yesterday I've noticed that for AVX which allows unaligned operands in >>> > AVX arithmetics instructions we still don't combine unaligned loads with >>> > the >>> > AVX arithmeti

Re: [RFC PATCH] For TARGET_AVX use *mov_internal for misaligned loads

2013-10-30 Thread Uros Bizjak
On Wed, Oct 30, 2013 at 12:11 PM, Jakub Jelinek wrote: >> > Yesterday I've noticed that for AVX which allows unaligned operands in >> > AVX arithmetics instructions we still don't combine unaligned loads with >> > the >> > AVX arithmetics instructions. So say for -O2 -mavx -ftree-vectorize >> >

Re: [RFC PATCH] For TARGET_AVX use *mov_internal for misaligned loads

2013-10-30 Thread Jakub Jelinek
On Wed, Oct 30, 2013 at 09:17:04AM -0700, Richard Henderson wrote: > On 10/30/2013 02:47 AM, Jakub Jelinek wrote: > > 2013-10-30 Jakub Jelinek > > > > * config/i386/i386.c (ix86_avx256_split_vector_move_misalign): If > > op1 is misaligned_operand, just use *mov_internal insn > > rat

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-30 Thread Jeff Law
On 10/30/13 04:48, Richard Biener wrote: foo (int * p, unsigned int size) { __bound_tmp.0; long unsigned int D.2239; long unsigned int _2; sizetype _6; int * _7; : __bound_tmp.0_4 = __builtin_ia32_arg_bnd (p_3(D)); : _2 = (long unsigned int) size_1(D); __builtin_i

Re: [Patch, C, C++] Accept GCC ivdep for 'do' and 'while', and for C++11's range-based loops

2013-10-30 Thread Jason Merrill
OK. Jason

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 11:16, Iyer, Balaji V wrote: -Original Message- From: Joseph Myers [mailto:jos...@codesourcery.com] Sent: Wednesday, October 30, 2013 1:15 PM To: Jeff Law Cc: Iyer, Balaji V; Tobias Burnus; gcc patches Subject: Re: Testsuite / Cilk Plus: Include library path in compile flag

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-30 Thread Uros Bizjak
On Wed, Oct 30, 2013 at 6:01 PM, Cong Hou wrote: > I found my problem: I put DONE outside of if not inside. You are > right. I have updated my patch. OK, great that we put things in order ;) Does this patch need some extra middle-end functionality? I was not able to vectorize char and short part

C++ PATCH to C++1y VLA of 0 length

2013-10-30 Thread Jason Merrill
At the Chicago meeting the EWG agreed that we don't need to throw on 0-length VLAs. Tested x86_64-pc-linux-gnu, applying to trunk. commit 1e328cbd26bfb641db8e218e4a4c32fc1a9a8d9d Author: Jason Merrill Date: Fri Oct 25 06:15:01 2013 -0400 * decl.c (cp_finish_decl): Never throw for VLA bo

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 11:12, Iyer, Balaji V wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Wednesday, October 30, 2013 1:08 PM To: Iyer, Balaji V; Tobias Burnus; gcc patches Subject: Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-p

[Patch] Fix canadian cross build on systems with no fenv.h

2013-10-30 Thread Steve Ellcey
I ran into a build problem while doing a canadian cross build of GCC. I was building on linux to create a Windows (mingw) GCC that generates code for mips-mti-elf. The mips-mti-elf target uses newlib for its system headers and libraries and the headers do not include a fenv.h header file. Howeve

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Iyer, Balaji V
> -Original Message- > From: Joseph Myers [mailto:jos...@codesourcery.com] > Sent: Wednesday, October 30, 2013 1:15 PM > To: Jeff Law > Cc: Iyer, Balaji V; Tobias Burnus; gcc patches > Subject: Re: Testsuite / Cilk Plus: Include library path in compile flags in > gcc.dg/cilk-plus/cilk-plu

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Joseph S. Myers
On Wed, 30 Oct 2013, Jeff Law wrote: > /* { dg-do compile } */ > /* { dg-do run { target i?86-*-* x86-64-*-* } } */ But with an effective-target keyword cilkplusrts or similar, rather than hardcoding the same list of targets in lots of places, please. -- Joseph S. Myers jos...@codesourcery.com

RE: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Iyer, Balaji V
> -Original Message- > From: Jeff Law [mailto:l...@redhat.com] > Sent: Wednesday, October 30, 2013 1:08 PM > To: Iyer, Balaji V; Tobias Burnus; gcc patches > Subject: Re: Testsuite / Cilk Plus: Include library path in compile flags in > gcc.dg/cilk-plus/cilk-plus.exp > > On 10/30/13 09:09,

Re: Testsuite / Cilk Plus: Include library path in compile flags in gcc.dg/cilk-plus/cilk-plus.exp

2013-10-30 Thread Jeff Law
On 10/30/13 09:09, Iyer, Balaji V wrote: Hello Everyone, What I ideally wanted to do with my testsuite files was that I want all the Cilk keywords test to compile no matter what the architecture is, but it should only run in certain architectures where the runtime is enabled (this is known static

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-30 Thread Cong Hou
Forget to attach the patch file. thanks, Cong On Wed, Oct 30, 2013 at 10:01 AM, Cong Hou wrote: > I found my problem: I put DONE outside of if not inside. You are > right. I have updated my patch. > > I appreciate your comment and test on it! > > > thanks, > Cong > > > > diff --git a/gcc/Chan

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-30 Thread Cong Hou
I found my problem: I put DONE outside of if not inside. You are right. I have updated my patch. I appreciate your comment and test on it! thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8a38316..84c7ab5 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2013-10-22

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-30 Thread Jeff Law
On 10/30/13 04:34, Ilya Enkovich wrote: On 30 Oct 10:26, Richard Biener wrote: Ick - you enlarge all return statements? But you don't set the actual value? So why allocate it with 2 ops in the first place?? When return does not return bounds it has operand with zero value similar to case whe

Re: C++ PATCH to deal with trivial but non-callable [cd]tors

2013-10-30 Thread Jason Merrill
On 10/30/2013 06:14 AM, Eric Botcazou wrote: +/* Return whether DECL, a method of a C++ TYPE, is trivial, that is to say + doesn't do anything for the objects of TYPE. */ + +static bool +is_trivial_method (const_tree decl, const_tree type) +{ + if (cpp_check (decl, IS_CONSTRUCTOR) && !TYPE_NE

Re: [RFC PATCH] For TARGET_AVX use *mov_internal for misaligned loads

2013-10-30 Thread Richard Henderson
On 10/30/2013 02:47 AM, Jakub Jelinek wrote: > 2013-10-30 Jakub Jelinek > > * config/i386/i386.c (ix86_avx256_split_vector_move_misalign): If > op1 is misaligned_operand, just use *mov_internal insn > rather than UNSPEC_LOADU load. > (ix86_expand_vector_move_misalign): L

Re: [RFA][PATCH] Minor fix to aliasing machinery

2013-10-30 Thread Marc Glisse
On Wed, 30 Oct 2013, Richard Biener wrote: Btw, get_addr_base_and_unit_offset may also return an offsetted MEM_REF (from &MEM [p_3, 17] for example). As we are interested in pointers this could be handled by not requiring a memory reference but extracting the base address and offset, covering m

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-30 Thread Marek Polacek
On Wed, Oct 30, 2013 at 11:56:25AM -0400, Jason Merrill wrote: > On 10/30/2013 10:52 AM, Marek Polacek wrote: > >+ if ((flag_sanitize & SANITIZE_VLA) > >+ && !processing_template_decl > > You don't need to check processing_template_decl; the template case > was already handled

Re: PATCH to use -Wno-format during stage1

2013-10-30 Thread Paolo Bonzini
Il 30/10/2013 16:47, Jason Merrill ha scritto: > I find -Wformat warnings about unknown % codes when building with an > older GCC to be mildly annoying noise; this patch avoids them by passing > -Wno-format during stage 1. > > Tested x86_64-pc-linux-gnu. Is this OK for trunk? Ok.

Re: [PATCH, MPX, 2/X] Pointers Checker [5/25] Tree and gimple ifaces

2013-10-30 Thread Jeff Law
On 10/30/13 03:26, Richard Biener wrote: diff --git a/gcc/gimple.c b/gcc/gimple.c index 3ddceb9..20f6010 100644 --- a/gcc/gimple.c +++ b/gcc/gimple.c @@ -174,7 +174,7 @@ gimple_build_with_ops_stat (enum gimple_code code, unsigned subcode, gimple gimple_build_return (tree retval) { - gimpl

Re: [PATCH] Keep REG_INC note in subreg2 pass

2013-10-30 Thread Jeff Law
On 10/30/13 00:09, Zhenqiang Chen wrote: On 30 October 2013 02:47, Jeff Law wrote: On 10/24/13 02:20, Zhenqiang Chen wrote: Hi, REG_INC note is lost in subreg2 pass when resolve_simple_move, which might lead to wrong dependence for ira. e.g. In function validate_equiv_mem of ira.c, it checks

Re: [PATCH v2 3/6] Split symtab_node declarations onto multiple lines

2013-10-30 Thread David Malcolm
On Tue, 2013-09-10 at 15:36 +0200, Jan Hubicka wrote: > > Amongst other things, the rename_symtab.py script converts > > "symtab_node" to "symtab_node *". > > > > This will lead to broken code on declarations that declare > > more than one variable (only the first would get a "*"), so split > > up

Re: [RFA][PATCH] Minor fix to aliasing machinery

2013-10-30 Thread Jeff Law
On 10/30/13 03:34, Richard Biener wrote: * tree-ssa-alias.c (stmt_kills_ref_p_1): Handle case where ao_ref_base returns a MEM_REF. * gcc.dg/tree-ssa/alias-26.c: New test. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/alias-26.c b/gcc/testsuite/gcc.dg/tree-ssa/alias-26.c

Re: [PATCH][ubsan] Add VLA bound instrumentation

2013-10-30 Thread Jason Merrill
On 10/30/2013 10:52 AM, Marek Polacek wrote: + if ((flag_sanitize & SANITIZE_VLA) + && !processing_template_decl You don't need to check processing_template_decl; the template case was already handled above. + tree x = cp_save_expr (size); + x = b

PATCH to use -Wno-format during stage1

2013-10-30 Thread Jason Merrill
I find -Wformat warnings about unknown % codes when building with an older GCC to be mildly annoying noise; this patch avoids them by passing -Wno-format during stage 1. Tested x86_64-pc-linux-gnu. Is this OK for trunk? Do you have another theory of how this should work? commit c40b06619fc

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-30 Thread Jason Merrill
On 10/29/2013 01:37 PM, Dehao Chen wrote: If we're actually emitting the name now, we need to give it a name different from the complete constructor. I suppose it makes sense to go with C4/D4 as in the decloning patch, Shall we do it in a separate patch? And I suppose binutils also need to be

  1   2   >