Also, as the current expand for abs() on 8/16bit integer is not used at all, should I comment them temporarily now? Later I can uncomment them once I finished the pattern recognizer.
thanks, Cong On Wed, Oct 30, 2013 at 10:22 AM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Wed, Oct 30, 2013 at 6:01 PM, Cong Hou <co...@google.com> wrote: >> I found my problem: I put DONE outside of if not inside. You are >> right. I have updated my patch. > > OK, great that we put things in order ;) > > Does this patch need some extra middle-end functionality? I was not > able to vectorize char and short part of your patch. > > Regarding the testcase - please put it to gcc.target/i386/ directory. > There is nothing generic in the test, as confirmed by target-dependent > scan test. You will find plenty of examples in the mentioned > directory. I'd suggest to split the testcase in three files, and to > simplify it to something like the testcase with global variables I > used earlier. > > Modulo testcase, the patch is OK otherwise, but middle-end parts > should be committed first. > > Thanks, > Uros.
