Re: free is a killer

2013-10-28 Thread Marc Glisse
On Mon, 28 Oct 2013, Jeff Law wrote: On 10/28/13 16:05, Marc Glisse wrote: I checked and it does the wrong thing (I don't have the testcase handy anymore, but it shouldn't be hard to recreate one), I even wrote a patch (attached) but it is related to: http://gcc.gnu.org/ml/gcc-patches/2013-10/

Re: [Patch, fortran] PRs 57893 and 58858

2013-10-28 Thread Tobias Burnus
Am 28.10.2013 23:26, schrieb Paul Richard Thomas: This patch addresses issues arising from PR57893. It is entirely obvious. Bootstraps and regtests on FC17/x86_64 - OK for trunk? Thanks for the patch. It's OK except for the following change: *** gcc/testsuite/gfortran.dg/unlimited_polymorphic

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-28 Thread Jeff Law
On 10/27/13 12:55, Andrew Pinski wrote: Here is my latest patch which adds the testcases from Zhenqiang's patch and fixes item 1 and 2. OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. Thanks, Andrew Pinski ChangeLog: * tree-ssa-ifcombine.c: Include rtl.h and tm_p.h. (ifco

Re: [PATCH (updated)] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-10-28 Thread Jeff Law
On 10/28/13 20:57, David Malcolm wrote: * cgraph.h (symtab_node_base): Convert to a class; add GTY((desc ("%h.type"), tag ("SYMTAB_SYMBOL"))). (cgraph_node): Inherit from symtab_node; add GTY option tag ("SYMTAB_FUNCTION"). (varpool_node): Inherit from symt

Re: free is a killer

2013-10-28 Thread Jeff Law
On 10/28/13 16:05, Marc Glisse wrote: I checked and it does the wrong thing (I don't have the testcase handy anymore, but it shouldn't be hard to recreate one), I even wrote a patch (attached) but it is related to: http://gcc.gnu.org/ml/gcc-patches/2013-10/msg02238.html so it can't go in. A more

[PATCH][RFA] Improvements to infer_nonnull_range

2013-10-28 Thread Jeff Law
Based on a suggestion from Marc, I want to use infer_nonnull_range in the erroneous path isolation optimization. In the process of doing that, I found a few deficiencies in infer_nonnull_range that need to be addressed. First, infer_nonnull_range_p doesn't infer ranges from a GIMPLE_RETUR

Re: [GOOGLE] Don't update the callee count if caller is not resolved node

2013-10-28 Thread Xinliang David Li
Is it sufficient to check if the final caller is defined in primary module? Note that in some cases, doing profile update 'speculatively' (without your fix) can be more precise (assuming the inlining gets materialized in a different compilation), but in general it might be better to be conservativ

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-28 Thread Sandra Loosemore
On 10/28/2013 03:20 AM, Bernd Edlinger wrote: On Sun, 20 Oct 2013 20:23:49, Sandra Loosemore wrote: I tried a backport to GCC 4.8 and tested on arm-none-eabi. On the new pr56997-1.c testcase, it got stuck in infinite recursion between store_split_bit_field/store_fixed_bit_field and/or extract_

Re: [PATCH (updated)] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-10-28 Thread David Malcolm
On Mon, 2013-10-28 at 22:57 -0400, David Malcolm wrote: > On Fri, 2013-09-20 at 17:33 +0200, Jan Hubicka wrote: > > > This patch is the handwritten part of the conversion of these types > > > to C++; it requires the followup patch, which is autogenerated. > > > > > > It converts: > > > struct sy

[PATCH (updated)] Convert symtab, cgraph and varpool nodes into a real class hierarchy

2013-10-28 Thread David Malcolm
On Fri, 2013-09-20 at 17:33 +0200, Jan Hubicka wrote: > > This patch is the handwritten part of the conversion of these types > > to C++; it requires the followup patch, which is autogenerated. > > > > It converts: > > struct symtab_node_base > > to: > > class symtab_node_base > > > > and con

Re: [SH] PR 54236 - add some more addc patterns

2013-10-28 Thread Kaz Kojima
Oleg Endo wrote: > This adds some more patterns to utilize the SH addc instruction. > Tested on rev 204111 with > make -k check RUNTESTFLAGS="--target_board=sh-sim > \{-m2a/-mb,-m2a-single/-mb,-m4/-ml,-m4-single/-ml,-m4/-mb,-m4-single/-mb}" > > and no new failures. > OK for trunk? Using same "*a

RE: [PATCH 1/n] Add conditional compare support

2013-10-28 Thread Hans-Peter Nilsson
On Tue, 22 Oct 2013, Zhenqiang Chen wrote: > ChangeLog: > 2013-10-22 Zhenqiang Chen > > * config/arm/arm.c (arm_fixed_condition_code_regs, arm_ccmode_to_code, > arm_select_dominance_ccmp_mode): New functions. > (arm_select_dominance_cc_mode_1): New function extracted from >

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

2013-10-28 Thread Cong Hou
As there are some issues with abs() type conversions, I removed the related content from the patch but only kept the SSE2 support for abs(int). For the define_expand I added as below, the else body is there to avoid fall-through transformations to ABS operation in optabs.c. Otherwise ABS will be c

Limited support for inheritance in gengtype now in trunk (was Re: [PATCH] make gengtype more robust against user error)

2013-10-28 Thread David Malcolm
On Mon, 2013-10-28 at 15:19 -0600, Jeff Law wrote: > On 10/25/13 15:37, David Malcolm wrote: > > This patch addresses various forms of failure described in > > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01974.html > > > [...] > Thanks for diving into this stuff and getting it fixed. > > OK for t

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

2013-10-28 Thread Zhenqiang Chen
On 28 October 2013 02:55, Andrew Pinski wrote: > On Sat, Oct 26, 2013 at 4:49 PM, Andrew Pinski wrote: >> On Sat, Oct 26, 2013 at 2:30 PM, Andrew Pinski wrote: >>> On Fri, Oct 18, 2013 at 2:21 AM, Zhenqiang Chen >>> wrote: On 18 October 2013 00:58, Jeff Law wrote: > On 10/17/13 05:03,

Re: [PATCH v2 3/4] Handle simple inheritance in gengtype.

2013-10-28 Thread David Malcolm
On Tue, 2013-10-15 at 12:58 -0600, Jeff Law wrote: [...] > This is OK. Thanks; committed to trunk as r204146. (I was holding off until approval of the robustification followup, which you've now approved, as [1]). Dave [1] http://gcc.gnu.org/ml/gcc-patches/2013-10/msg02330.html

patch to fix a LRA crash on ppc

2013-10-28 Thread Vladimir Makarov
The following patch is a new version of a fix for LRA crash on 32-bit ppc SPEC2006 gamess. The previous version broke mode-switching optimization on x86/x86-64. The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev. 204140. 2013-10-28 Vladimir Makarov

Re: [ARM][PATCH] Fix testsuite testcase neon-vcond-[ltgt,unordered].c

2013-10-28 Thread Kugan
On 25/10/13 19:04, Kyrill Tkachov wrote: > On 24/10/13 20:03, Kugan wrote: >> >> Hi Kyrill, >> >> It happens for armv5te arm-none-linux-gnueabi. --with-mode=arm >> --with-arch=armv5te --with-float=soft > > Ah ok, I can reproduce it now. So, while I agree that we add a scan for > vbit and vbif to t

Re: [PATCH] libstdc++ testsuite cxxflags

2013-10-28 Thread Mike Stump
On Oct 28, 2013, at 3:29 PM, Cesar Philippidis wrote: > This patch addresses two issues with the libstdc++ testsuite: > > * duplicate "-g -O2" CXXFLAGS > * missing "-g -O2" for remote targets I need to defer this to the libstdc++ people… there is enough of them, and they do such a nice job…

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-28 Thread Mike Stump
On Oct 28, 2013, at 1:30 PM, DJ Delorie wrote: > Who needs to approve this? THe target maintainers, or some global maintainer? So Richard said he'd review/approve it… He's been busy clearing out a backlog or email/patches and reviewing wide-int stuff… when next he comes up for air, I suspect

[GOOGLE] Don't update the callee count if caller is not resolved node

2013-10-28 Thread Dehao Chen
This patch changes to no update callee count if caller count is not a resolved node (in LIPO mode) during AutoFDO compilation. This is because AutoFDO will have the same edge counts for all unresolved nodes. Original update method will lead to multi-update of the callee. Bootstrapped and testing o

[PATCH] libstdc++ testsuite cxxflags

2013-10-28 Thread Cesar Philippidis
This patch addresses two issues with the libstdc++ testsuite: * duplicate "-g -O2" CXXFLAGS * missing "-g -O2" for remote targets The duplicate "-g -O2" flags is a result of testsuite_flags.in using build-time CXXFLAGS and proc libstdc++_init using the environmental CXXFLAGS, which defaults t

[Patch, fortran] PRs 57893 and 58858

2013-10-28 Thread Paul Richard Thomas
Dear All, This patch addresses issues arising from PR57893. It is entirely obvious. Bootstraps and regtests on FC17/x86_64 - OK for trunk? Cheers Paul PS I wash my hands of all attempts to use BT_HOLLERITH types! 2013-10-29 Paul Thomas PR fortran 57893 * trans-types.c (gfc_typeno

Re: [PATCH] Do not append " *INTERNAL* " to the decl name

2013-10-28 Thread Dehao Chen
ping... Thanks, Dehao On Fri, Oct 18, 2013 at 11:06 AM, Dehao Chen wrote: > On Fri, Oct 18, 2013 at 10:39 AM, Jason Merrill wrote: >> On 10/11/2013 01:59 PM, Dehao Chen wrote: >>> >>> It's hard to get a testcase without >>> http://gcc.gnu.org/viewcvs/gcc?view=revision&revision=201856 because >>

Re: free is a killer

2013-10-28 Thread Marc Glisse
On Mon, 28 Oct 2013, Jeff Law wrote: On 10/26/13 01:15, Marc Glisse wrote: Hello, this patch teaches gcc that free kills the memory its argument points to. The equality test is probably too strict, I guess we can loosen it later (unless you have suggestions?). Note that the corresponding code

Re: [Patch, C, C++] Accept GCC ivdep for 'do' and 'while', and for C++11's range-based loops

2013-10-28 Thread Tobias Burnus
Jason Merrill wrote: On 10/25/2013 04:46 PM, Tobias Burnus wrote: +do_range_for_auto_deduction (range_decl, range_expr); // FIXME:IVDEP I think in this situation let's set a flag on the RANGE_FOR_STMT so we can do ivdep handling at instantiation time. I am not completely sure whether yo

Re: [PATCH i386 4/8] [AVX512] [1/n] Add substed patterns.

2013-10-28 Thread Richard Henderson
On 10/28/2013 01:58 PM, Kirill Yukhin wrote: > Hello Richard, > On 28 Oct 08:20, Richard Henderson wrote: >> Why is a masked *scalar* operation useful? > > The reason the instructions exist is so that > you can do fully fault correct predicated scalar algorithms. Using VEC_MERGE isn't the proper

[PATCH] Fix comment typo

2013-10-28 Thread Jeff Law
Just something I noticed while reviewing a patch. Committed. diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e525748..013fe73 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2013-10-28 Jeff Law + + * lower-subreg.c (resolve_simple_move): Fix comment typo. + 2013-10-

Re: [PATCH] fixing typo in expr.c to allow proper recognition of complex addresses in some arches.

2013-10-28 Thread Jeff Law
On 10/25/13 02:39, Eric Botcazou wrote: Thanks. Installed on the trunk. Well, no, that will be problematic for some architectures. The history of this piece of code is complicated and it's admittedly lacking a comment, but the purpose of the block is clear enough: op0 = expand_expr (

[SH] PR 54236 - add some more addc patterns

2013-10-28 Thread Oleg Endo
Hello, This adds some more patterns to utilize the SH addc instruction. Tested on rev 204111 with make -k check RUNTESTFLAGS="--target_board=sh-sim \{-m2a/-mb,-m2a-single/-mb,-m4/-ml,-m4-single/-ml,-m4/-mb,-m4-single/-mb}" and no new failures. OK for trunk? Cheers, Oleg gcc/ChangeLog: P

Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins

2013-10-28 Thread Jeff Law
On 10/25/13 11:57, Ilya Enkovich wrote: There are currently two known issues with LTO. The first one is ICE in LTO streamer when it reads instrumented code. The second one is unitialized flag_check_pointers when code is compiled by lto1 (do you know why it may happen BTW?). It also causes ICE b

Re: [PATCH] make gengtype more robust against user error

2013-10-28 Thread Jeff Law
On 10/25/13 15:37, David Malcolm wrote: This patch addresses various forms of failure described in http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01974.html It adds a "default: gcc_unreachable();" to the autogenerated switch() statement in the routines for a base class, converting various kinds of

Re: free is a killer

2013-10-28 Thread Jeff Law
On 10/26/13 01:15, Marc Glisse wrote: Hello, this patch teaches gcc that free kills the memory its argument points to. The equality test is probably too strict, I guess we can loosen it later (unless you have suggestions?). Note that the corresponding code for BUILT_IN_MEMCPY and others seems s

RE: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C (and C++)

2013-10-28 Thread Iyer, Balaji V
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Jeff Law > Sent: Monday, October 28, 2013 4:24 PM > To: Iyer, Balaji V; r...@redhat.com; Jason Merrill (ja...@redhat.com); Aldy > Hernandez (al...@redhat.com) > Cc: gcc-patche

Re: [PATCH i386 4/8] [AVX512] [1/n] Add substed patterns.

2013-10-28 Thread Kirill Yukhin
Hello Richard, On 28 Oct 08:20, Richard Henderson wrote: > Why is a masked *scalar* operation useful? The reason the instructions exist is so that you can do fully fault correct predicated scalar algorithms. I example. In fact, with some hacky tricks, you can fully predicate normal C code in the

Re: [PATCH, MPX, 2/X] Pointers Checker [1/25] Hooks

2013-10-28 Thread Jeff Law
On 10/28/13 09:12, Ilya Enkovich wrote: I fixed documentation for bounds load/store hooks. Also added documentation for list of builtins returned by builtin_chkp_function. Thanks, Ilya -- gcc/ 2013-10-28 Ilya Enkovich * target.def (builtin_chkp_function): New. (chkp_bound

Re: [PATCH, testsuite/rs6000] Adjust two VMX tests for little endian

2013-10-28 Thread David Edelsohn
On Mon, Oct 28, 2013 at 3:17 PM, Bill Schmidt wrote: > Hi, > > These two test cases require source changes when compiled on a little > endian target. Verified on powerpc64{,le}-unknown-linux-gnu. Ok to > commit? > > Thanks, > Bill > > > 2013-10-28 Bill Schmidt > > * gcc.dg/vmx/gcc-bug

Re: [PATCH] Cilk Keywords (_Cilk_spawn and _Cilk_sync) for C (and C++)

2013-10-28 Thread Jeff Law
On 10/22/13 10:22, Iyer, Balaji V wrote: Hi Jeff, I have attached 2 patches - 1 for C and 1 for C++ - along with the changelogs (ChangeLog.cilkplus for C and common changes, cp-ChangeLog.cilkplus for C++ specific files) with the changes you have requested. Answers to your questions are given bel

Re: Apply attribute returns_nonnull in libiberty

2013-10-28 Thread DJ Delorie
Sure, go for it.

Re: Apply attribute returns_nonnull in libiberty

2013-10-28 Thread Marc Glisse
On Fri, 11 Oct 2013, Marc Glisse wrote: Hello, here are some uses for returns_nonnull in libiberty. Bootstrap+testsuite (default languages) on x86_64-unknown-linux-gnu. 2013-10-11 Marc Glisse PR tree-optimization/58689 include/ * ansidecl.h (ATTRIBUTE_RETURNS_NONNULL): New

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-28 Thread DJ Delorie
Who needs to approve this? THe target maintainers, or some global maintainer?

Re: Commit: MSP430: Pass -md on to assembler

2013-10-28 Thread Mike Stump
Ping? On Sep 27, 2013, at 11:21 AM, Mike Stump wrote: > On Sep 27, 2013, at 1:48 AM, nick clifton wrote: >> OK by me, although I cannot approve that particular patch. > > I know, the intent is for someone that can, to approve it. > >> But I ran into a very strange problem. With your PARTIAL_I

Re: Using gen_int_mode instead of GEN_INT minor testsuite fallout on MIPS

2013-10-28 Thread Mike Stump
Ping? On Oct 18, 2013, at 10:03 AM, Mike Stump wrote: > On Oct 18, 2013, at 4:24 AM, Richard Biener > wrote: >> I agree. Btw, the "implementation defined" precision of PDI on SH-5 >> definitely >> looks interesting, but I wonder how you can perform "implementation defined" >> arithmetic on th

Re: [PATCH] Final removal of mudflap

2013-10-28 Thread Mike Stump
On Oct 28, 2013, at 11:24 AM, Jeff Law wrote: > On 10/26/13 15:08, Joseph S. Myers wrote: >> As far as I can see, the commit left empty libmudflap directories around >> rather than removing them (SVN, unlike git, allows empty directories to be >> represented in the repository). > I'll check out an

Re: [patch] Mostly remove tree-core.h from other .h files.

2013-10-28 Thread Jeff Law
On 10/28/13 13:38, Andrew MacLeod wrote: I noticed there were a few .h files which we including tree-core.h themselves. expr.h was one of them, and many of the rtl files used that to get at the basic tree structure for various bits. I moved the include of tree-core.h to rtl.h instead. That w

Re: [PATCH] rewrite stack vectors

2013-10-28 Thread Jeff Law
On 10/25/13 13:56, Trevor Saunders wrote: On Fri, Oct 25, 2013 at 03:30:47PM -0400, Diego Novillo wrote: On 2013-10-10 14:07 , tsaund...@mozilla.com wrote: This makes the implementation of stack vectors simpler and easier to use. This

Re: [PATCH i386 4/8] [AVX512] Add substed patterns: mask_scalar_merge subst.

2013-10-28 Thread Richard Henderson
On 10/28/2013 07:53 AM, Kirill Yukhin wrote: > This patch introduces "mask_scalar_merge" subst. > > Is it ok to commit to main trunk? Ok. r~

[patch] Mostly remove tree-core.h from other .h files.

2013-10-28 Thread Andrew MacLeod
I noticed there were a few .h files which we including tree-core.h themselves. expr.h was one of them, and many of the rtl files used that to get at the basic tree structure for various bits. I moved the include of tree-core.h to rtl.h instead. That way all the rtl files get it, and when w

Re: [PATCH] Final removal of mudflap

2013-10-28 Thread pinskia
> On Oct 28, 2013, at 11:24 AM, Jeff Law wrote: > >> On 10/26/13 15:08, Joseph S. Myers wrote: >> As far as I can see, the commit left empty libmudflap directories around >> rather than removing them (SVN, unlike git, allows empty directories to be >> represented in the repository). > I'll chec

[PATCH, testsuite/rs6000] Adjust two VMX tests for little endian

2013-10-28 Thread Bill Schmidt
Hi, These two test cases require source changes when compiled on a little endian target. Verified on powerpc64{,le}-unknown-linux-gnu. Ok to commit? Thanks, Bill 2013-10-28 Bill Schmidt * gcc.dg/vmx/gcc-bug-i.c: Add little endian variant. * gcc.dg/vmx/eg-5.c: Likewise. I

Re: [PATCH] rewrite stack vectors

2013-10-28 Thread Jeff Law
On 10/25/13 13:56, Trevor Saunders wrote: On Fri, Oct 25, 2013 at 03:30:47PM -0400, Diego Novillo wrote: On 2013-10-10 14:07 , tsaund...@mozilla.com wrote: This makes the implementation of stack vectors simpler and easier to use. This

Re: [patch] Flatten tree-outof-ssa.h

2013-10-28 Thread Jeff Law
On 10/28/13 12:24, Andrew MacLeod wrote: This is even more trivial... Remove the 3 includes from tree-outof-ssa.h and pushed the required ones down to the .c files that include tree-outof-ssa.h. Bootstraps on x86_64-unknown-linux-gnu, regressions are running. Assuming no issues, OK? OK. jeff

[patch] Flatten tree-outof-ssa.h

2013-10-28 Thread Andrew MacLeod
This is even more trivial... Remove the 3 includes from tree-outof-ssa.h and pushed the required ones down to the .c files that include tree-outof-ssa.h. Bootstraps on x86_64-unknown-linux-gnu, regressions are running. Assuming no issues, OK? Andrew * tree-outof-ssa.h: Remove include fil

Re: [PATCH] Final removal of mudflap

2013-10-28 Thread Jeff Law
On 10/26/13 15:08, Joseph S. Myers wrote: As far as I can see, the commit left empty libmudflap directories around rather than removing them (SVN, unlike git, allows empty directories to be represented in the repository). I'll check out an SVN tree and remove the empty directory. jeff

Re: Fix for cris-elf breakage from mudflap removal, take 2

2013-10-28 Thread Jeff Law
On 10/27/13 08:43, Hans-Peter Nilsson wrote: PRED_NORETURN seems a better match; not that I see anything in the current source that actually treats them differently other than generating them, but my grep-fu may be weak and certainly my crystall-ball-fu is. After testing (no regressions compared

Re: [patch] Remove gimple.h from header files.

2013-10-28 Thread Jeff Law
On 10/28/13 11:39, Andrew MacLeod wrote: There are currently only 2 .h files which include gimple.h, so removing this indirection is not too difficult. Similar to the tree.h change Diego made, only .c files should include gimple.h. Bootstraps on x86_64-unknown-linux-gnu, regression tests are ru

Re: [C++ Patch] PR 58888

2013-10-28 Thread Jason Merrill
My question is, why do we need that whole block for massaging VAR_DECL initializers? That all ought to be handled properly by cp_finish_decl. Does removing everything after else if (!VAR_P (value)) gcc_unreachable (); work? Jason

[patch] Remove gimple.h from header files.

2013-10-28 Thread Andrew MacLeod
There are currently only 2 .h files which include gimple.h, so removing this indirection is not too difficult. Similar to the tree.h change Diego made, only .c files should include gimple.h. Bootstraps on x86_64-unknown-linux-gnu, regression tests are running. Assuming no issues, OK? Andr

Re: RFA: Andes nds32 port v4 patch

2013-10-28 Thread Joseph S. Myers
Since Richard looked at the machine description part of the port, I looked at the other pieces. I'm happy with those pieces with the following minor changes: http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00520.html (libgcc): remove the .file directive from crtzero.S. See

Re: RFC/A: PR 58079: CONST_INT mode assert in combine.c:do_SUBST

2013-10-28 Thread Uros Bizjak
Hello! > PR 58079 is about the do_SUBST assert: > > /* Sanity check that we're replacing oldval with a CONST_INT > that is a valid sign-extension for the original mode. */ > gcc_assert (INTVAL (newval) > == trunc_int_for_mode (INTVAL (newval), GET_MODE (oldval))); > > triggering whil

[C++ Patch] PR 58888

2013-10-28 Thread Paolo Carlini
Hi, here we reject the declaration of b with the invalid use of ‘auto’ error. The reason is that, at the beginning of grokfield, init != NULL_TREE, processing_template_decl is false (in fact, a "templatized" version of the testcase is accepted) and we get to: if (TREE_CODE (init) == CONSTRUC

Re: [PATCH i386 4/8] [AVX512] [1/n] Add substed patterns.

2013-10-28 Thread Richard Henderson
On 10/28/2013 03:24 AM, Kirill Yukhin wrote: > Hello Richard, > On 22 Oct 08:16, Richard Henderson wrote: >> On 10/22/2013 07:42 AM, Kirill Yukhin wrote: >>> Hello Richard, >>> Thanks for remarks, they all seems reasonable. >>> >>> One question >>> >>> On 21 Oct 16:01, Richard Henderson wrote:

Re: [PATCH, MPX, 2/X] Pointers Checker [1/25] Hooks

2013-10-28 Thread Ilya Enkovich
On 24 Oct 23:21, Jeff Law wrote: > On 10/24/13 02:24, Ilya Enkovich wrote: > >These two hooks are used by expand pass to pass/receive bounds for > >args. When bounds are passed in a register, expand does not need this > >hook and uses regular move insn. If we are out of bound register or > >platfor

Re: [PATCH 1/n] Add conditional compare support

2013-10-28 Thread Richard Henderson
On 10/28/2013 01:32 AM, Zhenqiang Chen wrote: > Patch is updated according to your comments. Main changes are: > * Add two hooks: legitimize_cmp_combination and legitimize_ccmp_combination > * Improve document. No, these are not the hooks I proposed. You should *not* have a ccmp_optab, because th

Re: [PATCH i386 4/8] [AVX512] Add substed patterns: mask_scalar_merge subst.

2013-10-28 Thread Kirill Yukhin
Hello, This patch introduces "mask_scalar_merge" subst. Is it ok to commit to main trunk? Testing pass. -- Thanks, K --- gcc/config/i386/sse.md | 26 +- gcc/config/i386/subst.md | 16 2 files changed, 29 insertions(+), 13 deletions(-) diff --git a/

Re: [PATCH i386 4/8] [AVX512] [2/n] Add substed patterns: mask scalar subst.

2013-10-28 Thread Kirill Yukhin
Hello, This patch introduces mask scalar subst. Is it ok to commit to main trunk? Testing pass. -- Thanks, K --- gcc/config/i386/sse.md | 104 --- gcc/config/i386/subst.md | 23 +++ 2 files changed, 95 insertions(+), 32 deletions(-) diff

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-28 Thread Dodji Seketeli
"Joseph S. Myers" writes: > On Mon, 28 Oct 2013, Dodji Seketeli wrote: > >> * c-family/c-common.c (unsafe_conversion_p): Make this function > > As previously noted, c-family/ has its own ChangeLog, so the c-family/ > part does not go in the ChangeLog entry. Agreed. I missed this. --

Re: C++14 digit separators..

2013-10-28 Thread Jason Merrill
On 10/28/2013 09:10 AM, Joseph S. Myers wrote: On Sun, 27 Oct 2013, Ed Smith-Rowland wrote: Here is an implementation for C++14 digit separators (single quote). I tend to think that such features should come with a test that the feature is not enabled for language / standard versions for whic

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-28 Thread Joseph S. Myers
On Mon, 28 Oct 2013, Dodji Seketeli wrote: > * c-family/c-common.c (unsafe_conversion_p): Make this function As previously noted, c-family/ has its own ChangeLog, so the c-family/ part does not go in the ChangeLog entry. -- Joseph S. Myers jos...@codesourcery.com

Re: C++14 digit separators..

2013-10-28 Thread Joseph S. Myers
On Sun, 27 Oct 2013, Ed Smith-Rowland wrote: > Here is an implementation for C++14 digit separators (single quote). I tend to think that such features should come with a test that the feature is not enabled for language / standard versions for which it shouldn't be. That is, something like #d

Re: Rework c99status.html

2013-10-28 Thread Joseph S. Myers
On Mon, 28 Oct 2013, Gerald Pfeifer wrote: > > I think it would be appropriate to redirect all the c99status.html files > > for particular GCC versions to this file, now it covers all versions. > > To make sure I understand: you are proposing we remove all > individual c99status.html pages and

Committed: Add testcase / extra comment to recent arc_ccfsm_post_advance patch

2013-10-28 Thread Joern Rennecke
gcc/testsuite: 2013-10-28 Claudiu Zissulescu Joern Rennecke * gcc.target/arc/jump-around-jump.c: New test. gcc: 2013-10-28 Joern Rennecke * config/arc/arc.c (arc_ccfsm_post_advance): Add comment about TYPE_RETURN. tmp Description: Binary data

Re: [PATCH i386 4/8] [AVX512] [1/n] Add substed patterns.

2013-10-28 Thread Kirill Yukhin
Hello Richard, On 22 Oct 08:16, Richard Henderson wrote: > On 10/22/2013 07:42 AM, Kirill Yukhin wrote: > > Hello Richard, > > Thanks for remarks, they all seems reasonable. > > > > One question > > > > On 21 Oct 16:01, Richard Henderson wrote: > >>> +(define_insn "avx512f_moves_mask" > >>> + [(

Re: [PATCH, ARM] Fix line number data for PIC register setup code

2013-10-28 Thread Tom de Vries
On 27/10/13 17:04, Eric Botcazou wrote: >> The PIC register setup code is emitted after NOTE_INSNS_FUNCTION_BEG, >> because it uses the insert_insn_on_edge mechanism, and the corresponding >> insertion in cfgexpand.c:gimple_expand_cfg takes care to insert the code >> after the parm_birth_insn: >> .

RE: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-28 Thread Bernd Edlinger
Hi Sandra, On Sun, 20 Oct 2013 20:23:49, Sandra Loosemore wrote: > > On 10/18/2013 10:38 AM, Richard Biener wrote: >> Sandra Loosemore wrote: >>> On 10/18/2013 04:50 AM, Richard Biener wrote: On Sat, Sep 28, 2013 at 4:19 AM, Sandra Loosemore wrote: > This patch fixes various -fstr

Re: [PATCH, PR 53001] Re: Patch to split out new warning flag for floating point conversion

2013-10-28 Thread Dodji Seketeli
Hello Joshua, Joshua J Cogliati writes: > I am not certain that c.opt was modified correctly. I don't see any problem with the c.opt part. So unless another maintainer says otherwise, I'd say this is OK. > 1. warn_float_patch_and_new_testcase.diff > This adds a new testcase and checks for flo

Re: C++14 digit separators..

2013-10-28 Thread Václav Zeman
On 10/28/2013 03:51 AM, Ed Smith-Rowland wrote: > Here is an implementation for C++14 digit separators (single quote). > > It's still testing on x86_64-linux but I wanted to give folks a chance > to check it out. > > Ed > > Index: gcc/testsuite/g++.dg/cpp1y/digit-sep-neg.C >