On 10/25/13 13:56, Trevor Saunders wrote:
On Fri, Oct 25, 2013 at 03:30:47PM -0400, Diego Novillo wrote:
On 2013-10-10 14:07 , tsaund...@mozilla.com wrote:
This makes the implementation of stack vectors simpler and easier to use. This
works by
making the size of the on stack storage a template argument, so the
size is embedded in the type. This allows you to implicitly convert a
stack_vec<T, N> to a vec<T, va_heap> *, and it will just work. Because there's
no need to support stack vectors in unions we can make them be a more normal
c++ class with a constructor and destructor that are nontrivial.
Thanks. This looks much simpler, indeed. The patch is fine to
commit. Just a couple of observations/questions:
I don't have commit access, so can someone check it in for me? I
bootstrapped and got no changes in regression tests two weeks ago, but
haven't checked it since if that helps.
Just doing a quick sanity build given things change quite a bit in a
couple weeks. Once the sanity build completes, I'll check it in.
Thanks,
Jeff
